D5394: KAuth integration in document saving - vol. 2

2017-04-20 Thread Fabian Vogt 
fvogt added a comment.


  Thanks again!
  The changes look good, but strace shows that the QFile operation still use 
absolute paths, apparently it resolves the "." manually with getcwd:
  
chdir("/tmp")   = 0
stat("/tmp/permfile", {st_mode=S_IFREG|0644, st_size=5, ...}) = 0
open("/tmp/kate.X31571", O_RDONLY|O_CLOEXEC) = 11
fstat(11, {st_mode=S_IFREG|0600, st_size=14, ...}) = 0
getcwd("/tmp", 4096)= 5
open("/tmp/permfile.J31580", O_RDWR|O_CREAT|O_EXCL|O_CLOEXEC, 0600) = 12
[...]
stat("/tmp/permfile", {st_mode=S_IFREG|0644, st_size=5, ...}) = 0
chmod("/tmp/permfile.J31580", 0644) = 0
fchown(12, 0, 0)= 0
rename("permfile.J31580", "permfile")
  
  
  
  >   ...this looks like a bug in KAuth since I only should get job->exec() 
result when my particular job was finished. I tried to differentiate the jobs 
by returning a unique data in reply.data() map and retrieving them in 
job->data() map, but that does not work either (another bug?). I'll try to 
investigate KAuth code further and report/propose-fix in proper facilities :).
  
  Yup, looks like a KAuth bug to me as well.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5394

To: martinkostolny, #ktexteditor, fvogt
Cc: elvisangelaccio, aacid, ivan, lbeltrame, fvogt, apol, anthonyfieroni, 
cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel, 
dfaure, #frameworks, head7, kfunk, sars

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 553 - Fixed!

2017-04-20 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/553/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Apr 2017 05:27:33 +
Build duration: 5 min 7 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 72/205 
(35%)CONDITIONAL 34/172 (20%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 25/27 (93%)CONDITIONAL 
5/10 (50%)
src.kstyle
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 47/178 (26%)CONDITIONAL 
29/162 (18%)

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 553 - Fixed!

2017-04-20 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/553/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Apr 2017 05:27:33 +
Build duration: 5 min 7 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 72/205 
(35%)CONDITIONAL 34/172 (20%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 25/27 (93%)CONDITIONAL 
5/10 (50%)
src.kstyle
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 47/178 (26%)CONDITIONAL 
29/162 (18%)

Jenkins-kde-ci: kactivities master kf5-qt5 » Linux,gcc - Build # 535 - Fixed!

2017-04-20 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kactivities%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/535/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Apr 2017 05:27:51 +
Build duration: 4 min 52 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages

Jenkins-kde-ci: kactivities master kf5-qt5 » Linux,gcc - Build # 535 - Fixed!

2017-04-20 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kactivities%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/535/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Apr 2017 05:27:51 +
Build duration: 4 min 52 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

2017-04-20 Thread KJ Tsanaktsidis 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130090/
---

(Updated April 20, 2017, 8:49 a.m.)


Review request for KDE Frameworks.


Changes
---

Add my name to license header
Fix style of pointer declarations


Repository: solid


Description
---

Previously, udesksblock.cpp was attempting to find a definition for
major/minor on Linux in  by checking Q_OS_LINUX before
importing the header. Q_OS_LINUX is however only set when
qsystemdetection.h is included, and the macro was being checked first.

Even had this check worked, it would still be wrong. On a modern version
of the userspace linux-headers,  includes definitions for
major and minor that assume each is limited to 8 bits and that dev_t is
16 bits. This is no longer true anymore; on Linux, major numbers can be
up to 12 bits at present and minor numbers up to 20. Calling these
macros with dev_t values > 2^16 would give incorrect results.

Because the Q_OS_LINUX check failed, a fallback version of the macros
were defined for use on all platforms. The code is allegedly copied from
kdev_t.h, except it is copied from the *kernel* version of the header,
not the userspace version. Linux internally uses a different
representation of dev_t than it exposes to userspace - the kernelspace
version is 20 bits of minor/12 bits of major contiguously, but the
userspace version packs the bits in a different order to maintain
compatability with old 16-bit device numbers. Thus, this code also does
not work for dev_t values > 2^16.

To fix this, we add CMake rules to search for a system-provided
definition of the major/minor macros - on various systems, these can be
in a few different places. As a fallback, we assume old-style 16-bit
dev_t (although I suspect that is only used for Windows, where
major/minor numbers are pretty meaningless anyway).


Diffs (updated)
-

  autotests/CMakeLists.txt 54adeea62b954b9169b37f1eab8fa3e215fafafa 
  autotests/fakeUdisks2.h PRE-CREATION 
  autotests/fakeUdisks2.cpp PRE-CREATION 
  autotests/solidudisks2test.cpp PRE-CREATION 
  src/solid/devices/backends/udisks2/CMakeLists.txt 
34390064af29ace07cbb3470945be098cc606d04 
  src/solid/devices/backends/udisks2/udisksblock.cpp 
0622ec77fcf670a2005d34b7a6c31ca8b53a18d8 

Diff: https://git.reviewboard.kde.org/r/130090/diff/


Testing
---

I've written a little snippet to iterate through block devices, print their 
major/minor number, and their device properties. It was previously incorrectly 
labeling all my disks with major 0 and minor == device_number (since it was 
using the first 20 bits for the minor). It now correctly identifies their 
major/minor number.


Thanks,

KJ Tsanaktsidis

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

2017-04-20 Thread KJ Tsanaktsidis 


> On April 19, 2017, 11:28 a.m., Lamarque Souza wrote:
> > autotests/solidudisks2test.cpp, line 78
> > 
> >
> > I think registering to systemBus only works if you are root or has the 
> > right permissions in dbus' configuration. Have you tested this unit test 
> > when running as normal user?

Actually it's not registering to the real system bus. The 
`QTEST_GUILESS_MAIN_SYSTEM_DBUS` macro sets up a new session bus and sets the 
`DBUS_SYSTEM_BUS_ADDRESS` environment variable to point to that bus, faking the 
real system bus out. The test definitely works as non root. This is the same 
strategy used by the solidfreedesktoptest tests.


- KJ


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130090/#review103067
---


On April 20, 2017, 8:49 a.m., KJ Tsanaktsidis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130090/
> ---
> 
> (Updated April 20, 2017, 8:49 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> Previously, udesksblock.cpp was attempting to find a definition for
> major/minor on Linux in  by checking Q_OS_LINUX before
> importing the header. Q_OS_LINUX is however only set when
> qsystemdetection.h is included, and the macro was being checked first.
> 
> Even had this check worked, it would still be wrong. On a modern version
> of the userspace linux-headers,  includes definitions for
> major and minor that assume each is limited to 8 bits and that dev_t is
> 16 bits. This is no longer true anymore; on Linux, major numbers can be
> up to 12 bits at present and minor numbers up to 20. Calling these
> macros with dev_t values > 2^16 would give incorrect results.
> 
> Because the Q_OS_LINUX check failed, a fallback version of the macros
> were defined for use on all platforms. The code is allegedly copied from
> kdev_t.h, except it is copied from the *kernel* version of the header,
> not the userspace version. Linux internally uses a different
> representation of dev_t than it exposes to userspace - the kernelspace
> version is 20 bits of minor/12 bits of major contiguously, but the
> userspace version packs the bits in a different order to maintain
> compatability with old 16-bit device numbers. Thus, this code also does
> not work for dev_t values > 2^16.
> 
> To fix this, we add CMake rules to search for a system-provided
> definition of the major/minor macros - on various systems, these can be
> in a few different places. As a fallback, we assume old-style 16-bit
> dev_t (although I suspect that is only used for Windows, where
> major/minor numbers are pretty meaningless anyway).
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 54adeea62b954b9169b37f1eab8fa3e215fafafa 
>   autotests/fakeUdisks2.h PRE-CREATION 
>   autotests/fakeUdisks2.cpp PRE-CREATION 
>   autotests/solidudisks2test.cpp PRE-CREATION 
>   src/solid/devices/backends/udisks2/CMakeLists.txt 
> 34390064af29ace07cbb3470945be098cc606d04 
>   src/solid/devices/backends/udisks2/udisksblock.cpp 
> 0622ec77fcf670a2005d34b7a6c31ca8b53a18d8 
> 
> Diff: https://git.reviewboard.kde.org/r/130090/diff/
> 
> 
> Testing
> ---
> 
> I've written a little snippet to iterate through block devices, print their 
> major/minor number, and their device properties. It was previously 
> incorrectly labeling all my disks with major 0 and minor == device_number 
> (since it was using the first 20 bits for the minor). It now correctly 
> identifies their major/minor number.
> 
> 
> Thanks,
> 
> KJ Tsanaktsidis
> 
>

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

2017-04-20 Thread Aleix Pol Gonzalez 
apol added a comment.


  Make them optional dependencies.
  
  What is `KF5::Service` used for? You don't seem to be `#ifdef` it. Maybe it's 
not needed at all?

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D5521

To: palokisa, graesslin, mck182
Cc: apol, #frameworks

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

2017-04-20 Thread Palo Kisa 
palokisa added a comment.


  > Make them optional dependencies.
  
  What do you mean by this?
  
  > What is `KF5::Service` used for? You don't seem to be `#ifdef` it. Maybe 
it's not needed at all?
  
  I don't know. I didn't investigate that.I thought, it's some kind of 
"self-initializing" component and it is enough to link the library.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D5521

To: palokisa, graesslin, mck182
Cc: apol, #frameworks

D5515: Update the ungrabMouse hack for Qt 5.8

2017-04-20 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D5515

To: davidedmundson, #plasma, mart
Cc: anthonyfieroni, mvourlakos, plasma-devel, #frameworks, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

2017-04-20 Thread Aleix Pol Gonzalez 
apol added a comment.


  In https://phabricator.kde.org/D5521#103535, @palokisa wrote:
  
  > > Make them optional dependencies.
  >
  > What do you mean by this?
  
  
  
  
find_package(KF5Crash) #note there's no REQUIRED
if (KF5Crash_FOUND)
somethingsomething()
endif()
  
  
  
  >> What is `KF5::Service` used for? You don't seem to be `#ifdef` it. Maybe 
it's not needed at all?
  > 
  > I don't know. I didn't investigate that.I thought, it's some kind of 
"self-initializing" component and it is enough to link the library.
  
  I don't think it's the case for KService (it is for KCrash though). Please 
investigate (or wait for feedback).

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D5521

To: palokisa, graesslin, mck182
Cc: apol, #frameworks

Re: Threadweaver compilation failure: Windows

2017-04-20 Thread Ben Cooksley 
On Wed, Apr 19, 2017 at 7:24 PM, Alexey Min  wrote:
> Built fine for me with "Build Tools for Visual Studio 2017"
> (https://www.visualstudio.com/downloads/ "Other Tools And Frameworks"
> section) which contains only compiler and libs without IDE.

Okay. Would you mind checking what version of VS 2017 you've got?
The system i'm using has 15.0.26403.7 (per the CMD prompt)

>
> I used part of the environment provided by craft, for cmake to able to
> find ECM (my KDEROOT is E:\KDE, or R:\).
> First I built threadweaver using craft, msvc2015 x64, to make sure it
> compiles with msvc2015.
>
> I went for manual procedure with vc2017: manually installed
> cmake-3.8.0 into craft's dir R:/dev-utils/cmake (by default craft has
> 3.7)
> Then launched Start menu -> Visual Studio 2017 -> x64 Native Tools
> Command Prompt.
> From there manually launched cmake with source dir set to where craft
> downloaded sources, E:/KDE/download/git/threadweaver, build dir to
> manually created E:/KDE/build/frameworks/threadweaver/vc2017.
> Configured with generator "NMake Makefiles", "Use default native compilers"
>
> and full build log https://paste.kde.org/pvhyt3xxo
>

Cheers,
Ben

>
> 2017-04-18 14:37 GMT+05:00 Ben Cooksley :
>> On Tue, Apr 18, 2017 at 6:53 PM, Kevin Funk  wrote:
>>> On Monday, 17 April 2017 22:43:56 CEST Aleix Pol wrote:
 On Mon, Apr 17, 2017 at 6:09 AM, Ben Cooksley  wrote:
 > Hi all,
 >
 > If someone could take a look at the following build log that would be
 > appreciated:
 > https://paste.kde.org/pzyhxydjw/xxx39x/raw

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

2017-04-20 Thread Palo Kisa 
palokisa added a comment.


  In https://phabricator.kde.org/D5521#103536, @apol wrote:
  
  > In https://phabricator.kde.org/D5521#103535, @palokisa wrote:
  >
  > > > Make them optional dependencies.
  > >
  > > What do you mean by this?
  >
  >
  >
  >
  >   find_package(KF5Crash) #note there's no REQUIRED
  >   if (KF5Crash_FOUND)
  >   somethingsomething()
  >   endif()
  >
  
  
  Why not give the packager/builder full control of what she/he wants to do and 
leave the decision to presence of `dev` package during the build process? IMO 
this is error prone.
  
  >>> What is `KF5::Service` used for? You don't seem to be `#ifdef` it. Maybe 
it's not needed at all?
  >> 
  >> I don't know. I didn't investigate that.I thought, it's some kind of 
"self-initializing" component and it is enough to link the library.
  > 
  > I don't think it's the case for KService (it is for KCrash though). Please 
investigate (or wait for feedback).
  
  Then I believe, it's only some remnant, because it's not used anywhere in the 
code.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D5521

To: palokisa, graesslin, mck182
Cc: apol, #frameworks

D5515: Update the ungrabMouse hack for Qt 5.8

2017-04-20 Thread Marco Martin 
mart added a comment.


  do you know off hand a list of places where this is needed?
  i think kicker,taskmanager,systray... anything else?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D5515

To: davidedmundson, #plasma, mart
Cc: anthonyfieroni, mvourlakos, plasma-devel, #frameworks, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Re: Threadweaver compilation failure: Windows

2017-04-20 Thread Alexey Min 
Again, I don't have full Visual Studio installed, only build tools.
Command Prompt does not show me anything, but installer displays
version number - 15.1 (26403.7)
( https://puu.sh/vqgvx/f9122db5ef.png )

2017-04-20 15:31 GMT+05:00 Ben Cooksley :
> On Wed, Apr 19, 2017 at 7:24 PM, Alexey Min  wrote:
>> Built fine for me with "Build Tools for Visual Studio 2017"
>> (https://www.visualstudio.com/downloads/ "Other Tools And Frameworks"
>> section) which contains only compiler and libs without IDE.
>
> Okay. Would you mind checking what version of VS 2017 you've got?
> The system i'm using has 15.0.26403.7 (per the CMD prompt)
>
>>
>> I used part of the environment provided by craft, for cmake to able to
>> find ECM (my KDEROOT is E:\KDE, or R:\).
>> First I built threadweaver using craft, msvc2015 x64, to make sure it
>> compiles with msvc2015.
>>
>> I went for manual procedure with vc2017: manually installed
>> cmake-3.8.0 into craft's dir R:/dev-utils/cmake (by default craft has
>> 3.7)
>> Then launched Start menu -> Visual Studio 2017 -> x64 Native Tools
>> Command Prompt.
>> From there manually launched cmake with source dir set to where craft
>> downloaded sources, E:/KDE/download/git/threadweaver, build dir to
>> manually created E:/KDE/build/frameworks/threadweaver/vc2017.
>> Configured with generator "NMake Makefiles", "Use default native compilers"
>>
>> and full build log https://paste.kde.org/pvhyt3xxo
>>
>
> Cheers,
> Ben
>
>>
>> 2017-04-18 14:37 GMT+05:00 Ben Cooksley :
>>> On Tue, Apr 18, 2017 at 6:53 PM, Kevin Funk  wrote:
 On Monday, 17 April 2017 22:43:56 CEST Aleix Pol wrote:
> On Mon, Apr 17, 2017 at 6:09 AM, Ben Cooksley  wrote:
> > Hi all,
> >
> > If someone could take a look at the following build log that would be
> > appreciated:
> > https://paste.kde.org/pzyhxydjw/xxx39x/raw
>

Re: Threadweaver compilation failure: Windows

2017-04-20 Thread Ben Cooksley 
On Thu, Apr 20, 2017 at 10:54 PM, Alexey Min  wrote:
> Again, I don't have full Visual Studio installed, only build tools.
> Command Prompt does not show me anything, but installer displays
> version number - 15.1 (26403.7)
> ( https://puu.sh/vqgvx/f9122db5ef.png )

Okay. Could you try building with these arguments to CMake and see what happens?

-DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON

Thanks,
Ben



>
> 2017-04-20 15:31 GMT+05:00 Ben Cooksley :
>> On Wed, Apr 19, 2017 at 7:24 PM, Alexey Min  wrote:
>>> Built fine for me with "Build Tools for Visual Studio 2017"
>>> (https://www.visualstudio.com/downloads/ "Other Tools And Frameworks"
>>> section) which contains only compiler and libs without IDE.
>>
>> Okay. Would you mind checking what version of VS 2017 you've got?
>> The system i'm using has 15.0.26403.7 (per the CMD prompt)
>>
>>>
>>> I used part of the environment provided by craft, for cmake to able to
>>> find ECM (my KDEROOT is E:\KDE, or R:\).
>>> First I built threadweaver using craft, msvc2015 x64, to make sure it
>>> compiles with msvc2015.
>>>
>>> I went for manual procedure with vc2017: manually installed
>>> cmake-3.8.0 into craft's dir R:/dev-utils/cmake (by default craft has
>>> 3.7)
>>> Then launched Start menu -> Visual Studio 2017 -> x64 Native Tools
>>> Command Prompt.
>>> From there manually launched cmake with source dir set to where craft
>>> downloaded sources, E:/KDE/download/git/threadweaver, build dir to
>>> manually created E:/KDE/build/frameworks/threadweaver/vc2017.
>>> Configured with generator "NMake Makefiles", "Use default native compilers"
>>>
>>> and full build log https://paste.kde.org/pvhyt3xxo
>>>
>>
>> Cheers,
>> Ben
>>
>>>
>>> 2017-04-18 14:37 GMT+05:00 Ben Cooksley :
 On Tue, Apr 18, 2017 at 6:53 PM, Kevin Funk  wrote:
> On Monday, 17 April 2017 22:43:56 CEST Aleix Pol wrote:
>> On Mon, Apr 17, 2017 at 6:09 AM, Ben Cooksley  wrote:
>> > Hi all,
>> >
>> > If someone could take a look at the following build log that would be
>> > appreciated:
>> > https://paste.kde.org/pzyhxydjw/xxx39x/raw
>>

D5523: use correct variable for fetch-translations injection

2017-04-20 Thread Harald Sitter 
sitter created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.

REVISION SUMMARY
  KDE_L10N_AUTO_TRANSLATIONS is the name of the relevant option

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5523

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake

To: sitter, apol
Cc: #frameworks, #build_system

D5523: use correct variable for fetch-translations injection

2017-04-20 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5523

To: sitter, apol
Cc: #frameworks, #build_system

D5523: use correct variable for fetch-translations injection

2017-04-20 Thread Harald Sitter 
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:fe46a935227f: use correct variable for fetch-translations 
injection (authored by sitter).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5523?vs=13634&id=13635

REVISION DETAIL
  https://phabricator.kde.org/D5523

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake

To: sitter, apol
Cc: #frameworks, #build_system

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 162 - Unstable!

2017-04-20 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/162/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Apr 2017 12:13:45 +
Build duration: 3 min 8 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 8 
test(s)Failed: TestSuite.ThreadWeaverJobTests

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 55/69 (80%)CLASSES 55/69 (80%)LINE 1474/1896 
(78%)CONDITIONAL 1153/2618 (44%)

By packages
  
autotests
FILES 11/11 (100%)CLASSES 11/11 (100%)LINE 413/413 
(100%)CONDITIONAL 493/962 (51%)
src
FILES 44/58 (76%)CLASSES 44/58 (76%)LINE 1061/1483 
(72%)CONDITIONAL 660/1656 (40%)

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 163 - Fixed!

2017-04-20 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/163/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Apr 2017 12:57:54 +
Build duration: 1 min 17 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 8 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 70/78 (90%)CLASSES 70/78 (90%)LINE 2518/2755 
(91%)CONDITIONAL 3006/5962 (50%)

By packages
  
autotests
FILES 19/19 (100%)CLASSES 19/19 (100%)LINE 1264/1269 
(100%)CONDITIONAL 2173/4302 (51%)
src
FILES 51/59 (86%)CLASSES 51/59 (86%)LINE 1254/1486 
(84%)CONDITIONAL 833/1660 (50%)

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 163 - Fixed!

2017-04-20 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/163/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Apr 2017 12:57:54 +
Build duration: 1 min 17 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 8 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 70/78 (90%)CLASSES 70/78 (90%)LINE 2518/2755 
(91%)CONDITIONAL 3006/5962 (50%)

By packages
  
autotests
FILES 19/19 (100%)CLASSES 19/19 (100%)LINE 1264/1269 
(100%)CONDITIONAL 2173/4302 (51%)
src
FILES 51/59 (86%)CLASSES 51/59 (86%)LINE 1254/1486 
(84%)CONDITIONAL 833/1660 (50%)

D5167: Move .po and .ts files look-up to build-time

2017-04-20 Thread Harald Sitter 
sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  Note that there's still an ordering problem with the new fetch-translations 
target now. The {ts,po}files-* targets can run before the fetch-translations 
target so on first run you may have no `BINDIR/po` directory yet, if 
`KDE_L10N_AUTO_TRANSLATIONS` was use anyway. make 👉 `pofiles-123abc` runs and 
does nothing on account of the dir not existing 👉 `fetch-translations` runs 
creating the dir 👉 pofiles haven't been made.
  
  I am not sure how to best solve this but I guess you'll need an `if target 
fetch-translations; add_dependencies(fetch-translations pofiles)` or somesuch.
  
  Not really a problem with the change though, so this is good enough for 
landing for me. Still would prefer if it had tests though :P

REPOSITORY
  R249 KI18n

BRANCH
  fetchbuildtime

REVISION DETAIL
  https://phabricator.kde.org/D5167

To: apol, #frameworks, sitter, ltoscano, ilic
Cc: aacid

D5525: adapt to fetchpo changes and use vars for target directories to dry code

2017-04-20 Thread Harald Sitter 
sitter created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.

REVISION SUMMARY
  - fetchpo now expects the output dirs as named arguments
  - new argument for poqm directories where releaseme will put _qt.po files
  - variables for both po/ and poqm/ to not repeat the paths all over the place

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5525

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake

To: sitter, apol
Cc: #frameworks, #build_system

D5525: adapt to fetchpo changes and use vars for target directories to dry code

2017-04-20 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Okay, note that we should stabilize fetchpo.rb though as when it's released 
we won't get to do these changes anymore.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5525

To: sitter, apol
Cc: #frameworks, #build_system

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

2017-04-20 Thread Martin Gräßlin 
graesslin added a comment.


  I don't really understand what this change is supposed to fix. Distributions 
will ship only one variant of kglobalaccel and that will most likely be the one 
which is wanted by KDE. If kglobalaccel is shipped without KCrash support I 
would consider this as a serious problem and report that to the distributions. 
Also given my experience about breakage in weird situations I'm against such 
build flexibility. KCrash is an important component for kglobalaccel and I'm 
not interested in having to spend time on bug reports because a distro 
mis-configured kglobalaccel.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D5521

To: palokisa, graesslin, mck182
Cc: apol, #frameworks

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 547 - Failure!

2017-04-20 Thread no-reply 

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/547/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Apr 2017 14:32:12 +
Build duration: 58 sec

CHANGE SET
No changes

D5525: adapt to fetchpo changes and use vars for target directories to dry code

2017-04-20 Thread Harald Sitter 
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:77623d19b627: adapt to fetchpo changes and use vars for 
target directories to dry code (authored by sitter).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5525?vs=13641&id=13648

REVISION DETAIL
  https://phabricator.kde.org/D5525

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake

To: sitter, apol
Cc: #frameworks, #build_system

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

2017-04-20 Thread Palo Kisa 
palokisa added a comment.


  > Distributions will ship only one variant of kglobalaccel and that will most 
likely be the one which is wanted by KDE
  
  Why is that? Why can't we have e.g. one `foo-kde` and other `foo-lxqt` 
package, both providing virtual `foo` (these will be in conflict as they will 
provide the same file(s)). Then KDE can depend strictly on `foo-kde`.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D5521

To: palokisa, graesslin, mck182
Cc: apol, #frameworks

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 528 - Unstable!

2017-04-20 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/528/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Apr 2017 15:16:46 +
Build duration: 10 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 
53 test(s)Failed: TestSuite.kiocore-threadtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 22/22 (100%)FILES 274/343 (80%)CLASSES 274/343 (80%)LINE 29938/51988 
(58%)CONDITIONAL 16414/39055 (42%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7936/8253 
(96%)CONDITIONAL 4434/8672 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8101/14183 
(57%)CONDITIONAL /9267 (48%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3464/7561 
(46%)CONDITIONAL 1293/4381 (30%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1767/3781 
(47%)CONDITIONAL 1275/3462 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.remote
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 
14/200 (7%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 727/1173 
(62%)CONDITIONAL 411/851 (48%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 
461/970 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3665/11070 
(33%)CONDITIONAL 1762/7138 (25%)

Jenkins-kde-ci: threadweaver master kf5-qt5 » Linux,gcc - Build # 164 - Unstable!

2017-04-20 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/threadweaver%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/164/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Apr 2017 15:16:53 +
Build duration: 3 min 9 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 8 
test(s)Failed: TestSuite.ThreadWeaverJobTests

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 55/69 (80%)CLASSES 55/69 (80%)LINE 1476/1896 
(78%)CONDITIONAL 1143/2598 (44%)

By packages
  
autotests
FILES 11/11 (100%)CLASSES 11/11 (100%)LINE 413/413 
(100%)CONDITIONAL 493/962 (51%)
src
FILES 44/58 (76%)CLASSES 44/58 (76%)LINE 1063/1483 
(72%)CONDITIONAL 650/1636 (40%)

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 186 - Unstable!

2017-04-20 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/186/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Thu, 20 Apr 2017 15:16:53 +
Build duration: 4 min 17 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 3 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
13 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: 
TestSuite.kwindowsystem-kwindowsystem_threadtestFailed: 
TestSuite.kwindowsystem-kwindowsystemx11test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 39/49 (80%)CLASSES 39/49 (80%)LINE 5652/8634 
(65%)CONDITIONAL 3072/6581 (47%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 2394/2564 
(93%)CONDITIONAL 1284/2627 (49%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 12/16 (75%)CLASSES 12/16 (75%)LINE 603/1434 
(42%)CONDITIONAL 289/710 (41%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 12/16 (75%)CLASSES 12/16 (75%)LINE 2648/4537 
(58%)CONDITIONAL 1496/3236 (46%)

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 164 - Unstable!

2017-04-20 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/164/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Apr 2017 15:18:23 +
Build duration: 3 min 8 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 8 
test(s)Failed: TestSuite.ThreadWeaverJobTests

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 55/69 (80%)CLASSES 55/69 (80%)LINE 1474/1896 
(78%)CONDITIONAL 1155/2618 (44%)

By packages
  
autotests
FILES 11/11 (100%)CLASSES 11/11 (100%)LINE 413/413 
(100%)CONDITIONAL 493/962 (51%)
src
FILES 44/58 (76%)CLASSES 44/58 (76%)LINE 1061/1483 
(72%)CONDITIONAL 662/1656 (40%)

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 548 - Fixed!

2017-04-20 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/548/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Apr 2017 15:40:57 +
Build duration: 1 min 26 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/5 (100%)FILES 19/25 (76%)CLASSES 19/25 (76%)LINE 740/1269 
(58%)CONDITIONAL 319/864 (37%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 402/484 (83%)CONDITIONAL 
192/484 (40%)
src.kdeclarative
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 150/312 (48%)CONDITIONAL 
60/166 (36%)
src.kdeclarative.private
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 24/58 (41%)CONDITIONAL 
6/32 (19%)
src.qmlcontrols.kquickcontrolsaddons
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 79/144 (55%)CONDITIONAL 
36/78 (46%)
src.quickaddons
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 85/271 (31%)CONDITIONAL 
25/104 (24%)

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 548 - Fixed!

2017-04-20 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/548/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Apr 2017 15:40:57 +
Build duration: 1 min 26 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/5 (100%)FILES 19/25 (76%)CLASSES 19/25 (76%)LINE 740/1269 
(58%)CONDITIONAL 319/864 (37%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 402/484 (83%)CONDITIONAL 
192/484 (40%)
src.kdeclarative
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 150/312 (48%)CONDITIONAL 
60/166 (36%)
src.kdeclarative.private
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 24/58 (41%)CONDITIONAL 
6/32 (19%)
src.qmlcontrols.kquickcontrolsaddons
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 79/144 (55%)CONDITIONAL 
36/78 (46%)
src.quickaddons
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 85/271 (31%)CONDITIONAL 
25/104 (24%)

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

2017-04-20 Thread Lamarque Souza 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130090/#review103071
---




autotests/fakeUdisks2.h (line 35)


It is common practice to pass QString parameters QString as const &:

FakeUdisks2BlockDevice(QObject *parent, const &QString device, quint64 
device_number);


- Lamarque Souza


On April 20, 2017, 8:49 a.m., KJ Tsanaktsidis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130090/
> ---
> 
> (Updated April 20, 2017, 8:49 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> Previously, udesksblock.cpp was attempting to find a definition for
> major/minor on Linux in  by checking Q_OS_LINUX before
> importing the header. Q_OS_LINUX is however only set when
> qsystemdetection.h is included, and the macro was being checked first.
> 
> Even had this check worked, it would still be wrong. On a modern version
> of the userspace linux-headers,  includes definitions for
> major and minor that assume each is limited to 8 bits and that dev_t is
> 16 bits. This is no longer true anymore; on Linux, major numbers can be
> up to 12 bits at present and minor numbers up to 20. Calling these
> macros with dev_t values > 2^16 would give incorrect results.
> 
> Because the Q_OS_LINUX check failed, a fallback version of the macros
> were defined for use on all platforms. The code is allegedly copied from
> kdev_t.h, except it is copied from the *kernel* version of the header,
> not the userspace version. Linux internally uses a different
> representation of dev_t than it exposes to userspace - the kernelspace
> version is 20 bits of minor/12 bits of major contiguously, but the
> userspace version packs the bits in a different order to maintain
> compatability with old 16-bit device numbers. Thus, this code also does
> not work for dev_t values > 2^16.
> 
> To fix this, we add CMake rules to search for a system-provided
> definition of the major/minor macros - on various systems, these can be
> in a few different places. As a fallback, we assume old-style 16-bit
> dev_t (although I suspect that is only used for Windows, where
> major/minor numbers are pretty meaningless anyway).
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 54adeea62b954b9169b37f1eab8fa3e215fafafa 
>   autotests/fakeUdisks2.h PRE-CREATION 
>   autotests/fakeUdisks2.cpp PRE-CREATION 
>   autotests/solidudisks2test.cpp PRE-CREATION 
>   src/solid/devices/backends/udisks2/CMakeLists.txt 
> 34390064af29ace07cbb3470945be098cc606d04 
>   src/solid/devices/backends/udisks2/udisksblock.cpp 
> 0622ec77fcf670a2005d34b7a6c31ca8b53a18d8 
> 
> Diff: https://git.reviewboard.kde.org/r/130090/diff/
> 
> 
> Testing
> ---
> 
> I've written a little snippet to iterate through block devices, print their 
> major/minor number, and their device properties. It was previously 
> incorrectly labeling all my disks with major 0 and minor == device_number 
> (since it was using the first 20 bits for the minor). It now correctly 
> identifies their major/minor number.
> 
> 
> Thanks,
> 
> KJ Tsanaktsidis
> 
>

Re: Threadweaver compilation failure: Windows

2017-04-20 Thread Alexey Min 
I can't quickly and easily try Debug build, because for that I need a
separate craft build environment built with CMAKE_BUILD_TYPE=Debug,
otherwise I get linking errors about incomatible C++-runtime libraries
(Qt5 was built with release msvcrt, linking threadweaver with debug
one). It will take some time to craft debug build of the whole
environment, starting with zlib, openssl, dbus, icu, .. ending with
qtbase.

2017-04-20 16:03 GMT+05:00 Ben Cooksley :
> On Thu, Apr 20, 2017 at 10:54 PM, Alexey Min  wrote:
>> Again, I don't have full Visual Studio installed, only build tools.
>> Command Prompt does not show me anything, but installer displays
>> version number - 15.1 (26403.7)
>> ( https://puu.sh/vqgvx/f9122db5ef.png )
>
> Okay. Could you try building with these arguments to CMake and see what 
> happens?
>
> -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON
>
> Thanks,
> Ben
>
>
>
>>
>> 2017-04-20 15:31 GMT+05:00 Ben Cooksley :
>>> On Wed, Apr 19, 2017 at 7:24 PM, Alexey Min  wrote:
 Built fine for me with "Build Tools for Visual Studio 2017"
 (https://www.visualstudio.com/downloads/ "Other Tools And Frameworks"
 section) which contains only compiler and libs without IDE.
>>>
>>> Okay. Would you mind checking what version of VS 2017 you've got?
>>> The system i'm using has 15.0.26403.7 (per the CMD prompt)
>>>

 I used part of the environment provided by craft, for cmake to able to
 find ECM (my KDEROOT is E:\KDE, or R:\).
 First I built threadweaver using craft, msvc2015 x64, to make sure it
 compiles with msvc2015.

 I went for manual procedure with vc2017: manually installed
 cmake-3.8.0 into craft's dir R:/dev-utils/cmake (by default craft has
 3.7)
 Then launched Start menu -> Visual Studio 2017 -> x64 Native Tools
 Command Prompt.
 From there manually launched cmake with source dir set to where craft
 downloaded sources, E:/KDE/download/git/threadweaver, build dir to
 manually created E:/KDE/build/frameworks/threadweaver/vc2017.
 Configured with generator "NMake Makefiles", "Use default native compilers"

 and full build log https://paste.kde.org/pvhyt3xxo

>>>
>>> Cheers,
>>> Ben
>>>

 2017-04-18 14:37 GMT+05:00 Ben Cooksley :
> On Tue, Apr 18, 2017 at 6:53 PM, Kevin Funk  wrote:
>> On Monday, 17 April 2017 22:43:56 CEST Aleix Pol wrote:
>>> On Mon, Apr 17, 2017 at 6:09 AM, Ben Cooksley  wrote:
>>> > Hi all,
>>> >
>>> > If someone could take a look at the following build log that would be
>>> > appreciated:
>>> > https://paste.kde.org/pzyhxydjw/xxx39x/raw
>>>

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 529 - Still Unstable!

2017-04-20 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/529/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Apr 2017 16:36:48 +
Build duration: 27 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 
53 test(s)Failed: TestSuite.kiocore-threadtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 22/22 (100%)FILES 274/343 (80%)CLASSES 274/343 (80%)LINE 29944/51988 
(58%)CONDITIONAL 16417/39055 (42%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7936/8253 
(96%)CONDITIONAL 4432/8672 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8104/14183 
(57%)CONDITIONAL /9267 (48%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3465/7561 
(46%)CONDITIONAL 1294/4381 (30%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1759/3781 
(47%)CONDITIONAL 1267/3462 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.remote
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 
14/200 (7%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 737/1173 
(63%)CONDITIONAL 420/851 (49%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 
461/970 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3665/11070 
(33%)CONDITIONAL 1763/7138 (25%)

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

2017-04-20 Thread Martin Gräßlin 
graesslin added a comment.


  In https://phabricator.kde.org/D5521#103661, @palokisa wrote:
  
  > > Distributions will ship only one variant of kglobalaccel and that will 
most likely be the one which is wanted by KDE
  >
  > Why is that? Why can't we have e.g. one `foo-kde` and other `foo-lxqt` 
package, both providing virtual `foo` (these will be in conflict as they will 
provide the same file(s)). Then KDE can depend strictly on `foo-kde`.
  
  
  Talk to distros. My experience is that this will be an absolute no-go for 
most distros. You might find one or two, but I doubt any of the major 
distributions will do that. The obvious reason is that it would be impossible 
to install frameworks and lxqt at the same time. Note that this is about 
frameworks and not even Plasma. Plasma has no play in kglobalaccel.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D5521

To: palokisa, graesslin, mck182
Cc: apol, #frameworks

D5167: Move .po and .ts files look-up to build-time

2017-04-20 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R249:a54ae95b520e: Move .po and .ts files look-up to 
build-time (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D5167?vs=13404&id=13654#toc

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5167?vs=13404&id=13654

REVISION DETAIL
  https://phabricator.kde.org/D5167

AFFECTED FILES
  CMakeLists.txt
  cmake/KF5I18NMacros.cmake
  cmake/build-pofiles.cmake
  cmake/build-tsfiles.cmake

To: apol, #frameworks, sitter, ltoscano, ilic
Cc: aacid

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 530 - Fixed!

2017-04-20 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/530/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Apr 2017 18:49:51 +
Build duration: 21 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
53 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 22/22 (100%)FILES 275/344 (80%)CLASSES 275/344 (80%)LINE 30008/52023 
(58%)CONDITIONAL 16434/39077 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7971/8288 
(96%)CONDITIONAL 4447/8694 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8131/14183 
(57%)CONDITIONAL 4449/9267 (48%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3467/7561 
(46%)CONDITIONAL 1294/4381 (30%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1759/3781 
(47%)CONDITIONAL 1266/3462 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.remote
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 
14/200 (7%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 737/1173 
(63%)CONDITIONAL 420/851 (49%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 
461/970 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3665/11070 
(33%)CONDITIONAL 1763/7138 (25%)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 530 - Fixed!

2017-04-20 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/530/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Apr 2017 18:49:51 +
Build duration: 21 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
53 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 22/22 (100%)FILES 275/344 (80%)CLASSES 275/344 (80%)LINE 30008/52023 
(58%)CONDITIONAL 16434/39077 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7971/8288 
(96%)CONDITIONAL 4447/8694 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8131/14183 
(57%)CONDITIONAL 4449/9267 (48%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3467/7561 
(46%)CONDITIONAL 1294/4381 (30%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1759/3781 
(47%)CONDITIONAL 1266/3462 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.remote
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 
14/200 (7%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 737/1173 
(63%)CONDITIONAL 420/851 (49%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 
461/970 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3665/11070 
(33%)CONDITIONAL 1763/7138 (25%)

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

2017-04-20 Thread Elvis Angelaccio 
elvisangelaccio added a comment.


  @cfeck Ping?

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  kpassworddialog-leak

REVISION DETAIL
  https://phabricator.kde.org/D5312

To: elvisangelaccio, fvogt, cfeck
Cc: #frameworks

D5530: KNewPasswordWidget: don't hide visibility action in plaintext mode

2017-04-20 Thread Elvis Angelaccio 
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Otherwise the user cannot tell whether what's going to be typed will be
  visible or not. Same fix as in https://phabricator.kde.org/D5312.
  
  CCBUG: 378276

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  knewpasswordwidget-leak

REVISION DETAIL
  https://phabricator.kde.org/D5530

AFFECTED FILES
  autotests/knewpasswordwidgettest.cpp
  autotests/knewpasswordwidgettest.h
  src/knewpasswordwidget.cpp

To: elvisangelaccio, cfeck
Cc: #frameworks

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

2017-04-20 Thread Christoph Feck 
cfeck added a comment.


  Elvis, this was already accepted. If I had objections, I would have stopped 
you :)

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  kpassworddialog-leak

REVISION DETAIL
  https://phabricator.kde.org/D5312

To: elvisangelaccio, fvogt, cfeck
Cc: #frameworks

D5530: KNewPasswordWidget: don't hide visibility action in plaintext mode

2017-04-20 Thread Christoph Feck 
cfeck accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  knewpasswordwidget-leak

REVISION DETAIL
  https://phabricator.kde.org/D5530

To: elvisangelaccio, cfeck
Cc: #frameworks