D6102: KUrlRequester: Set NOTIFY signal to textChanged() for text property.
apol added inline comments. INLINE COMMENTS > elvisangelaccio wrote in kurlrequester.h:71 > Don't we need to add apidox with the @since tag? Well not really, maybe if we documented the properties instead of the methods (which could be a sensible thing to do on the other hand). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6102 To: arrowdodger, #frameworks Cc: apol, elvisangelaccio, kfunk
KDE CI: Frameworks attica kf5-qt5 WindowsQt5.7 - Build # 10 - Fixed!
BUILD SUCCESS Build URL https://build-sandbox.kde.org/job/Frameworks%20attica%20kf5-qt5%20WindowsQt5.7/10/ Project: Frameworks attica kf5-qt5 WindowsQt5.7 Date of build: Sat, 10 Jun 2017 23:04:13 + Build duration: 2 min 50 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s) build.log Description: Binary data
D6180: Makefile: Remove invalid keyword entries in makefile.xml
orgads added a reviewer: arichardson. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6180 To: orgads, #framework_syntax_hightlighting, arichardson Cc: #frameworks
D6180: Makefile: Remove invalid keyword entries in makefile.xml
orgads created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Those keywords are mapped to undefined lists. Reported in https://phabricator.kde.org/D3621#inline-17949 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6180 AFFECTED FILES data/syntax/makefile.xml To: orgads, #framework_syntax_hightlighting Cc: #frameworks
D6102: KUrlRequester: Set NOTIFY signal to textChanged() for text property.
elvisangelaccio added inline comments. INLINE COMMENTS > kurlrequester.h:71 > Q_PROPERTY(QString placeholderText READ placeholderText WRITE > setPlaceholderText) > -Q_PROPERTY(QString text READ text WRITE setText) > +Q_PROPERTY(QString text READ text WRITE setText NOTIFY textChanged) > Q_PROPERTY(Qt::WindowModality fileDialogModality READ fileDialogModality > WRITE setFileDialogModality) Don't we need to add apidox with the @since tag? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6102 To: arrowdodger, #frameworks Cc: elvisangelaccio, kfunk
KDE CI: Frameworks threadweaver kf5-qt5 XenialQt5.7 - Build # 9 - Unstable!
BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20XenialQt5.7/9/ Project: Frameworks threadweaver kf5-qt5 XenialQt5.7 Date of build: Sat, 10 Jun 2017 10:08:30 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 8 test(s)Failed: TestSuite.ThreadWeaverJobTests Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (2/2)80% (55/69)80% (55/69)78% (1479/1896)44% (1143/2598)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (11/11)100% (11/11)100% (413/413)51% (493/962)src76% (44/58)76% (44/58)72% (1066/1483)40% (650/1636) build.log Description: Binary data
KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.7 - Build # 11 - Fixed!
BUILD SUCCESS Build URL https://build-sandbox.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/11/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 10 Jun 2017 09:57:55 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s) build.log Description: Binary data
KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.7 - Build # 14 - Still Unstable!
BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.7/14/ Project: Frameworks kpty kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 10 Jun 2017 09:56:42 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.kptyprocesstest build.log Description: Binary data
KDE CI: Frameworks knewstuff kf5-qt5 FreeBSDQt5.7 - Build # 21 - Still Unstable!
BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.7/21/ Project: Frameworks knewstuff kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 10 Jun 2017 09:52:49 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kmoretoolstest build.log Description: Binary data
KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 - Build # 14 - Still Unstable!
BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/14/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 10 Jun 2017 09:54:31 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.plasma-packagestructuretest build.log Description: Binary data
KDE CI: Frameworks kservice kf5-qt5 XenialQt5.7 - Build # 14 - Unstable!
BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kservice%20kf5-qt5%20XenialQt5.7/14/ Project: Frameworks kservice kf5-qt5 XenialQt5.7 Date of build: Sat, 10 Jun 2017 09:58:22 + Build duration: 2 min 27 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.ksycocathreadtest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report86% (6/7)89% (76/85)89% (76/85)68% (5489/8028)48% (3003/6264)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (14/14)100% (14/14)93% (1465/1571)50% (908/1820)src.kbuildsycoca100% (1/1)100% (1/1)91% (61/67)65% (13/20)src.kdeinit0% (0/2)0% (0/2)0% (0/326)0% (0/262)src.plugin67% (2/3)67% (2/3)47% (47/100)38% (36/96)src.services97% (30/31)97% (30/31)58% (1767/3046)40% (770/1904)src.sycoca84% (26/31)84% (26/31)73% (2041/2798)59% (1242/2112)tests.pluginlocator100% (3/3)100% (3/3)90% (108/120)68% (34/50) build.log Description: Binary data
KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 22 - Still Unstable!
BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/22/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Sat, 10 Jun 2017 09:37:54 + Build duration: 6 min 31 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: TestSuite.kdirwatch_fam_unittestFailed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (10/10)85% (79/93)85% (79/93)73% (6039/8239)43% (10830/25227)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests83% (33/40)83% (33/40)97% (2599/2682)49% (6620/13503)src.desktoptojson100% (3/3)100% (3/3)79% (84/106)38% (146/384)src.lib67% (2/3)67% (2/3)56% (302/536)22% (192/893)src.lib.caching100% (2/2)100% (2/2)45% (352/787)18% (195/1086)src.lib.io90% (9/10)90% (9/10)58% (817/1397)29% (932/3214)src.lib.jobs71% (5/7)71% (5/7)52% (159/304)39% (57/146)src.lib.plugin100% (8/8)100% (8/8)86% (646/748)44% (1035/2326)src.lib.randomness100% (2/2)100% (2/2)67% (66/99)58% (45/78)src.lib.text63% (5/8)63% (5/8)46% (349/764)40% (794/1981)src.lib.util100% (10/10)100% (10/10)81% (665/816)50% (814/1616) build.log Description: Binary data
KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.7 - Build # 12 - Unstable!
BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.7/12/ Project: Frameworks kconfig kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 10 Jun 2017 09:36:46 + Build duration: 4 min 59 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 34 test(s), Skipped: 0 test(s), Total: 35 test(s)Failed: TestSuite.kconfigcore-kconfigtest build.log Description: Binary data
KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 11 - Still Unstable!
BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/11/ Project: Frameworks baloo kf5-qt5 XenialQt5.7 Date of build: Sat, 10 Jun 2017 09:29:26 + Build duration: 7 min 38 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (12/12)77% (111/144)77% (111/144)73% (5039/6932)50% (2613/5194)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.benchmarks100% (2/2)100% (2/2)100% (42/42)89% (16/18)autotests.integration100% (3/3)100% (3/3)95% (242/255)64% (140/220)autotests.unit.codecs100% (3/3)100% (3/3)100% (40/40)57% (25/44)autotests.unit.engine100% (17/17)100% (17/17)100% (736/736)53% (390/740)autotests.unit.file100% (11/11)100% (11/11)97% (788/809)51% (438/864)autotests.unit.lib100% (6/6)100% (6/6)97% (315/326)52% (156/302)src.codecs100% (5/5)100% (5/5)87% (120/138)76% (32/42)src.engine97% (38/39)97% (38/39)79% (1607/2038)58% (796/1379)src.file39% (17/44)39% (17/44)45% (678/1506)38% (374/980)src.file.extractor100% (2/2)100% (2/2)69% (20/29)58% (7/12)src.file.extractor.autotests100% (1/1)100% (1/1)100% (22/22)61% (11/18)src.lib55% (6/11)55% (6/11)43% (429/991)40% (228/575) build.log Description: Binary data
Re: Application usage statistics and targeted user surveys
On Thursday, 8 June 2017 01:36:44 CEST Aleix Pol wrote: > On Thu, Jun 8, 2017 at 12:27 AM, Albert Astals Cid wrote: > > El dissabte, 3 de juny de 2017, a les 11:49:00 CEST, Volker Krause va > > > > escriure: > >> On Thursday, 25 May 2017 12:33:49 CEST Volker Krause wrote: > >> > On Tuesday, 23 May 2017 18:31:35 CEST Aleix Pol wrote: > >> > > I would have looked into fixing it, but I'm not sure I understand why > >> > > there's all the RPATH logic in place, so I'd prefer to hear from you > >> > > first. > >> > > >> > I have removed the remains of the pre-ECM rpath handling. This also > >> > changed > >> > binary output directories on Linux to follow KDE standards, so you > >> > might > >> > want to do a clean build to avoid issues with outdated binaries in the > >> > build dir. > >> > > >> > > A good next step would also be to get it running on build.kde.org, so > >> > > we can identify these issues. > >> > > >> > Indeed, I've requested CI coverage now. > >> > >> Looks like in order to get CI coverage we need to move to kdereview > >> (which > >> is fine, I think it's ready for that), but that requires to know where > >> this > >> should end up afterwards. > >> > >> I guess the candidates are extragear/libs or frameworks? frameworks seems > >> conceptually like the right place, but putting something there that is > >> still fairly new and has seen little field testing seems sub-optimal. > >> Opinions?> > > To me it seems a few releases from extragear would make sense before > > moving to frameworks and promise full API/ABI compatibility. Sounds sensible to me, let's do that. > > OTOH when moving from extreagear to frameworks we may have to rename > > library (to have the KF5 suffix) which would break also API (at least at > > the cmake level). > > > > How do people feel having libs in extreager having the KF5 "cmake naming" > > in the understanding that we're stabilizing them to be part of frameworks > > eventually? > > IMO it's a bit weird and unsettling. But then, we're already doing it > for many pim libraries (not in extragear but in applications, still > not part of KF5). But isn't the rename the least of our problems if we start in extragear/libs exactly to be able to still do ABI, API and behavior changes until we are happy with things for frameworks? I'll try to get all currently pending API changes in ASAP, and then get it moved to kdereview within this month. Regards, Volker signature.asc Description: This is a digitally signed message part.
