Re: Application usage statistics and targeted user surveys

[Albert Astals Cid]

El dissabte, 10 de juny de 2017, a les 10:11:44 CEST, Volker Krause va 
escriure:
> On Thursday, 8 June 2017 01:36:44 CEST Aleix Pol wrote:
> > On Thu, Jun 8, 2017 at 12:27 AM, Albert Astals Cid  wrote:
> > > El dissabte, 3 de juny de 2017, a les 11:49:00 CEST, Volker Krause va
> > > 
> > > escriure:
> > >> On Thursday, 25 May 2017 12:33:49 CEST Volker Krause wrote:
> > >> > On Tuesday, 23 May 2017 18:31:35 CEST Aleix Pol wrote:
> > >> > > I would have looked into fixing it, but I'm not sure I understand
> > >> > > why
> > >> > > there's all the RPATH logic in place, so I'd prefer to hear from
> > >> > > you
> > >> > > first.
> > >> > 
> > >> > I have removed the remains of the pre-ECM rpath handling. This also
> > >> > changed
> > >> > binary output directories on Linux to follow KDE standards, so you
> > >> > might
> > >> > want to do a clean build to avoid issues with outdated binaries in
> > >> > the
> > >> > build dir.
> > >> > 
> > >> > > A good next step would also be to get it running on build.kde.org,
> > >> > > so
> > >> > > we can identify these issues.
> > >> > 
> > >> > Indeed, I've requested CI coverage now.
> > >> 
> > >> Looks like in order to get CI coverage we need to move to kdereview
> > >> (which
> > >> is fine, I think it's ready for that), but that requires to know where
> > >> this
> > >> should end up afterwards.
> > >> 
> > >> I guess the candidates are extragear/libs or frameworks? frameworks
> > >> seems
> > >> conceptually like the right place, but putting something there that is
> > >> still fairly new and has seen little field testing seems sub-optimal.
> > >> Opinions?>
> > > 
> > > To me it seems a few releases from extragear would make sense before
> > > moving to frameworks and promise full API/ABI compatibility.
> 
> Sounds sensible to me, let's do that.
> 
> > > OTOH when moving from extreagear to frameworks we may have to rename
> > > library (to have the KF5 suffix) which would break also API (at least at
> > > the cmake level).
> > > 
> > > How do people feel having libs in extreager having the KF5 "cmake
> > > naming"
> > > in the understanding that we're stabilizing them to be part of
> > > frameworks
> > > eventually?
> > 
> > IMO it's a bit weird and unsettling. But then, we're already doing it
> > for many pim libraries (not in extragear but in applications, still
> > not part of KF5).
> 
> But isn't the rename the least of our problems if we start in extragear/libs
> exactly to be able to still do ABI, API and behavior changes until we are
> happy with things for frameworks?

Yes/No, at some point we'll reach some code that we like and we'll say "ok 
let's move it to frameworks", apps that had used that last code will still get 
an extra ABI break because of the name change.

But oh well, i guess it's ok.

Cheers,
  Albert

> 
> I'll try to get all currently pending API changes in ASAP, and then get it
> moved to kdereview within this month.
> 
> Regards,
> Volker

D6202: Expand apidox of KJobWidget::setWindow()

[Elvis Angelaccio]

elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Follow up of https://phabricator.kde.org/D6142

REPOSITORY
  R288 KJobWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6202

AFFECTED FILES
  src/kjobwidgets.h

To: elvisangelaccio, #frameworks

D6142: Fix drop menu position on Wayland

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:1e251d2f6a42: Fix drop menu position on Wayland (authored 
by elvisangelaccio).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6142?vs=15263=15399

REVISION DETAIL
  https://phabricator.kde.org/D6142

AFFECTED FILES
  src/widgets/dropjob.cpp
  src/widgets/dropjob.h

To: elvisangelaccio, dfaure, mart, davidedmundson
Cc: davidedmundson, #frameworks

D6198: Add KAuth support to delete operation

[Chinmoy Ranjan Pradhan]

chinmoyr edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6198

To: chinmoyr, elvisangelaccio, #frameworks

D6197: Add basic KAuth support to file ioslave

[Chinmoy Ranjan Pradhan]

chinmoyr edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6197

To: chinmoyr, elvisangelaccio, #frameworks

D6190: Expose and use Engine's page size variable

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  It all makes sense, so good from my side.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6190

To: leinir, #knewstuff, apol
Cc: apol, #frameworks, ZrenBot

D6199: Allow deleting from write-protected location in dolphin

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
Restricted Application added a subscriber: Konqueror.

REVISION SUMMARY
  This is a temporary patch which allows deleting items from write-protected 
location. This is only for testing the diff's https://phabricator.kde.org/D6197 
and https://phabricator.kde.org/D6198.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D6199

AFFECTED FILES
  src/dolphinmainwindow.cpp
  src/views/dolphinview.cpp

To: chinmoyr, elvisangelaccio, #frameworks, #dolphin
Cc: #konqueror

D6197: Add basic KAuth support to file ioslave

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D6198: Add KAuth support to delete 
operation.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6197

To: chinmoyr, elvisangelaccio, #frameworks

D6198: Add KAuth support to delete operation

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  This patch makes it possible to delete root owned files and folders.
  To avoid any accidental deletion a warning is shown informing the user about 
the write-protection. The warnings can either be from KIO::JobUIDelegate or 
from file ioslave because there arise two cases while deleting with escalated 
privilege.
  
  Case 1: The parent dir of the item(s) to be deleted is write-protected 
  In this case the warning will be shown from JobUIDelegate. Since this will be 
a privileged operation, the warning dialog won't have the "Don't show again" 
checkbox. Following the warning the polkit authentication dialog will be shown 
if the user has not authenticated himself otherwise if the delete was performed 
within the threshold time the file will be deleted imediately.
  
  Case 2: The parent isn't write-protected but some of the children are
  In this case the regular warning is shown from JobUIDelegate and ioslave 
performs the delete operation. It continues till a root owned item is 
encountered. At this point either the polkit authentication dialog is shown or 
the warning from the ioslave.
  
  Depends on https://phabricator.kde.org/D6197

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6198

AFFECTED FILES
  src/core/jobuidelegateextension.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/kauth/file.actions
  src/ioslaves/file/kauth/helper.cpp
  src/ioslaves/file/kauth/helper.h
  src/widgets/jobuidelegate.cpp

To: chinmoyr, elvisangelaccio, #frameworks

D6197: Add basic KAuth support to file ioslave

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  This patch adds the relevant KAuth code to file ioslave that can be used to 
perform various file management operations with escalated privilege.
  //execWithRoot()// : This method performs the specified operation as root
  //warningMessage()//: Decides upon the warning message. As of yet it only has 
warning for the delete operation.
  //showWarning()//: Shows the warning.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6197

AFFECTED FILES
  src/ioslaves/file/CMakeLists.txt
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/kauth/CMakeLists.txt
  src/ioslaves/file/kauth/file.actions
  src/ioslaves/file/kauth/helper.cpp
  src/ioslaves/file/kauth/helper.h

To: chinmoyr, elvisangelaccio, #frameworks

D5069: initial implementation of a platform plugin for OS X

[René J . V . Bertin]

rjvbb updated this revision to Diff 15380.
rjvbb edited the summary of this revision.
rjvbb added a comment.


  rebased on v4.100.0-rc1-220-g0196c66

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5069?vs=12521=15380

REVISION DETAIL
  https://phabricator.kde.org/D5069

AFFECTED FILES
  src/kwindowsystem.cpp
  src/kwindowsystem.h
  src/platforms/CMakeLists.txt
  src/platforms/osx/CMakeLists.txt
  src/platforms/osx/cocoa.json
  src/platforms/osx/kkeyserver.cpp
  src/platforms/osx/kwindowinfo.cpp
  src/platforms/osx/kwindowinfo.mm
  src/platforms/osx/kwindowinfo_mac_p.h
  src/platforms/osx/kwindowinfo_p_cocoa.h
  src/platforms/osx/kwindowsystem.cpp
  src/platforms/osx/kwindowsystem_mac_p.h
  src/platforms/osx/kwindowsystem_macobjc.mm
  src/platforms/osx/kwindowsystem_p_cocoa.h
  src/platforms/osx/plugin.cpp
  src/platforms/osx/plugin.h

To: rjvbb, #frameworks
Cc: kde-mac, #frameworks

D5069: KWindowSystem: initial implementation of a platform plugin for OS X

[René J . V . Bertin]

rjvbb retitled this revision from "initial implementation of a platform plugin 
for OS X" to "KWindowSystem: initial implementation of a platform plugin for OS 
X".
rjvbb edited the test plan for this revision.
rjvbb set the repository for this revision to R278 KWindowSystem.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D5069

To: rjvbb, #frameworks
Cc: kde-mac, #frameworks

D6192: Set Containments to have focus within the view

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b0e8ea29fab4: Set Containments to have focus within the 
view (authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6192?vs=15378=15379

REVISION DETAIL
  https://phabricator.kde.org/D6192

AFFECTED FILES
  src/plasmaquick/containmentview.cpp

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6192: Set Containments to have focus within the view

[Kai Uwe Broulik]

broulik added a comment.


  BUG: 381124

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6192

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6192: Set Containments to have focus within the view

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6192

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6190: Expose and use Engine's page size variable

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 15377.
leinir added a comment.


  Don't const & an int, that's just silly.

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6190?vs=15373=15377

REVISION DETAIL
  https://phabricator.kde.org/D6190

AFFECTED FILES
  src/core/engine.cpp

To: leinir, #knewstuff
Cc: apol, #frameworks, ZrenBot

D6192: Set Containments to have focus within the view

[David Edmundson]

davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Now that applets are their own focus scope (which makes sense) we've
  also made containments their own focus scope.
  
  We therefore need to also say the containment FocusScope has the focus
  within the view.

TEST PLAN
  Renamed something in folderview
  Used cursor nav

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6192

AFFECTED FILES
  src/plasmaquick/containmentview.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6190: Expose and use Engine's page size variable

[Dan Leinir Turthra Jensen]

leinir added a comment.


  As far as i can gather, it was simply never added because, well, it was never 
used in a lot of places... This really is more a case of equalising some 
features between requestData and other parts of the engine (so they can all be 
paginated by the size they really want to be).

INLINE COMMENTS

> apol wrote in engine.cpp:144
> I wouldn't pass an int as `const&`

No, quite true - force of habit and all that :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6190

To: leinir, #knewstuff
Cc: apol, #frameworks, ZrenBot

D6122: Add since tags.

[Thomas Friedrichsmeier]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:e48e34bd0288: Add since tags. (authored by tfry).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6122?vs=15226=15376

REVISION DETAIL
  https://phabricator.kde.org/D6122

AFFECTED FILES
  src/lib/abstracthighlighter.h
  src/lib/definition.h
  src/lib/definitiondownloader.h
  src/lib/foldingregion.h
  src/lib/format.h
  src/lib/repository.h
  src/lib/state.h
  src/lib/syntaxhighlighter.h
  src/lib/theme.h

To: tfry, #frameworks, dfaure
Cc: dfaure, cfeck

D6190: Expose and use Engine's page size variable

[Aleix Pol Gonzalez]

apol added a comment.


  I have no idea about the patch itself, why it wasn't exposed so far that is.

INLINE COMMENTS

> engine.cpp:144
> + */
> +void setPageSize(const int& pageSize);
>  Q_SIGNALS:

I wouldn't pass an int as `const&`

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6190

To: leinir, #knewstuff
Cc: apol, #frameworks, ZrenBot

D6190: Expose and use Engine's page size variable

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added a project: KNewStuff.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Engine has a pageSize variable which has been mostly unused, but which comes 
in very handy when getting large sets of data. This patch exposes that variable 
through a setter, and makes use of it internally whenever a request is made (so 
the page size is actually honoured the way it seems to have been intended)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6190

AFFECTED FILES
  src/core/engine.cpp

To: leinir, #knewstuff
Cc: #frameworks, ZrenBot

D6180: Makefile: Remove invalid keyword entries in makefile.xml

[Alex Richardson]

arichardson accepted this revision.
arichardson added a comment.
This revision is now accepted and ready to land.


  Looks good to me! I forgot to remove these when I commited the bmake support.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D6180

To: orgads, #framework_syntax_hightlighting, arichardson
Cc: #frameworks

D6102: KUrlRequester: Set NOTIFY signal to textChanged() for text property.

[Gleb Popov]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:f7dfb713a852: KUrlRequester: Set NOTIFY signal to 
textChanged() for text property. (authored by arrowdodger).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6102?vs=15177=15371

REVISION DETAIL
  https://phabricator.kde.org/D6102

AFFECTED FILES
  src/widgets/kurlrequester.h

To: arrowdodger, #frameworks, dfaure
Cc: apol, elvisangelaccio, kfunk

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 20 - Unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/20/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
 Date of build:
Mon, 12 Jun 2017 09:09:11 +
 Build duration:
2 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 22 test(s)Failed: TestSuite.kdirwatch_stat_unittestFailed: TestSuite.kshelltest

build.log
Description: Binary data

D6149: [KOpenWithDialog] HTML-escape file name

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:90c1f7c8a9d6: [KOpenWithDialog] HTML-escape file name 
(authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6149?vs=15275=15370

REVISION DETAIL
  https://phabricator.kde.org/D6149

AFFECTED FILES
  src/widgets/kopenwithdialog.cpp

To: broulik, kde-frameworks-devel, dfaure
Cc: dfaure, #frameworks

D5417: add an extractor using qtmultimedia

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  If this extractor is worse than the taglib one, shouldn't the cmake run issue 
a warning about that? Or does it already do so because "taglib not found"?

INLINE COMMENTS

> qtmultimediaextractortest.cpp:2
> +/*
> +<<< HEAD
> + * TagLibExtractor tests.

you probably don't want to commit a merge conflict...

> qtmultimediaextractortest.cpp:8
> + *
> + * Copyright (C) 2015  Juan Palacios 
> + *

+ your own copyright?

> qtmultimediaextractortest.cpp:39
> +{
> +return QLatin1String(INDEXER_TESTS_SAMPLE_FILES_PATH) + 
> QDir::separator() + fileName;
> +}

What if the path contains non-latin characters?
This should use QFile::decodeName instead.

> qtmultimediaextractor.cpp:2
> +/*
> +
> +Copyright (C) 2012  Vishesh Handa 

todo

> qtmultimediaextractor.cpp:78
> +if (available && mMetadataExtractor->isMetaDataAvailable()) {
> +album = mMetadataExtractor->metaData(QMediaMetaData::AlbumTitle);
> +title = mMetadataExtractor->metaData(QMediaMetaData::Title);

The mutex needs to be locked for all these writes.

> qtmultimediaextractor.cpp:210
> +
> +auto extractionResult = mSynchronizeCondition.wait(, 
> 400);
> +

If setMediaSource calls wakeAll before this thread gets here, we will wait 
forever (QWaitCondition = if you're not sleeping, you miss the wakeup call).

Use a QSemaphore instead of a QWaitCondition to fix this problem.

> qtmultimediaextractor.cpp:213
> +if (!extractionResult) {
> +mSynchronizeMutex.unlock();
> +return;

Use QMutexLocker instead of manual lock/unlock, to make sure no unlock is 
forgotten.

> qtmultimediaextractor.h:2
> +/*
> +
> +Copyright (C) 2012  Vishesh Handa 

todo ;)

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D5417

To: mgallien, #frameworks, dfaure
Cc: dfaure, #frameworks

Re: Application usage statistics and targeted user surveys

[David Faure]

On samedi 10 juin 2017 10:11:44 CEST Volker Krause wrote:
> On Thursday, 8 June 2017 01:36:44 CEST Aleix Pol wrote:
> > On Thu, Jun 8, 2017 at 12:27 AM, Albert Astals Cid  wrote:
> > > El dissabte, 3 de juny de 2017, a les 11:49:00 CEST, Volker Krause va
> > > 
> > > escriure:
> > >> On Thursday, 25 May 2017 12:33:49 CEST Volker Krause wrote:
> > >> > On Tuesday, 23 May 2017 18:31:35 CEST Aleix Pol wrote:
> > >> > > I would have looked into fixing it, but I'm not sure I understand
> > >> > > why
> > >> > > there's all the RPATH logic in place, so I'd prefer to hear from
> > >> > > you
> > >> > > first.
> > >> > 
> > >> > I have removed the remains of the pre-ECM rpath handling. This also
> > >> > changed
> > >> > binary output directories on Linux to follow KDE standards, so you
> > >> > might
> > >> > want to do a clean build to avoid issues with outdated binaries in
> > >> > the
> > >> > build dir.
> > >> > 
> > >> > > A good next step would also be to get it running on build.kde.org,
> > >> > > so
> > >> > > we can identify these issues.
> > >> > 
> > >> > Indeed, I've requested CI coverage now.
> > >> 
> > >> Looks like in order to get CI coverage we need to move to kdereview
> > >> (which
> > >> is fine, I think it's ready for that), but that requires to know where
> > >> this
> > >> should end up afterwards.
> > >> 
> > >> I guess the candidates are extragear/libs or frameworks? frameworks
> > >> seems
> > >> conceptually like the right place, but putting something there that is
> > >> still fairly new and has seen little field testing seems sub-optimal.
> > >> Opinions?>
> > > 
> > > To me it seems a few releases from extragear would make sense before
> > > moving to frameworks and promise full API/ABI compatibility.
> 
> Sounds sensible to me, let's do that.
> 
> > > OTOH when moving from extreagear to frameworks we may have to rename
> > > library (to have the KF5 suffix) which would break also API (at least at
> > > the cmake level).
> > > 
> > > How do people feel having libs in extreager having the KF5 "cmake
> > > naming"
> > > in the understanding that we're stabilizing them to be part of
> > > frameworks
> > > eventually?
> > 
> > IMO it's a bit weird and unsettling. But then, we're already doing it
> > for many pim libraries (not in extragear but in applications, still
> > not part of KF5).

And that's a bug, and certainly not an example to follow.

When people look at an installed linux distro, all they see is installed libs,
they don't see whether we call it "extragear" or "frameworks". So anything 
called somethingKF5something looks like it's part of KF5, with API/ABI 
promises.

> But isn't the rename the least of our problems if we start in extragear/libs
> exactly to be able to still do ABI, API and behavior changes until we are
> happy with things for frameworks?

Yes, exactly. Do it in extragear but *without* KF5 suffix.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D6149: [KOpenWithDialog] HTML-escape file name

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Man you have fun filenames :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6149

To: broulik, kde-frameworks-devel, dfaure
Cc: dfaure, #frameworks

D6122: Add since tags.

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Excellent idea. I would say, we should have done the same in other new 
frameworks. If we treat KF5 as a whole, then these classes are simply "new 
since 5.28" in a bigger "package" that already existed (KF5).

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6122

To: tfry, #frameworks, dfaure
Cc: dfaure, cfeck

D6102: KUrlRequester: Set NOTIFY signal to textChanged() for text property.

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6102

To: arrowdodger, #frameworks, dfaure
Cc: apol, elvisangelaccio, kfunk