D6527: [Containment Interface] Keep containment in RequiresAttentionStatus while context menu is open
mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > broulik wrote in containmentinterface.cpp:1073 > Not sure if we should use `this` (and then check `if m_containment` as > context or `m_containment` should be the same REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6527 To: broulik, #plasma, mart Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6537: Fix display of formatDuration with rounding.
davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY When showing the time (1 hour 59.5 minutes) with seconds hidden we want to show "2 hours 0 minutes" not "1 hour 60 minutes". This is fixed by performing the rounding before we split the number of miliseconds into component parts, rather than splitting and then rounding. BUG: 360681 BUG: 382069 TEST PLAN Updated unit test REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D6537 AFFECTED FILES autotests/kformattest.cpp src/lib/util/kformatprivate.cpp To: davidedmundson Cc: #frameworks
D6233: KKeyServer: fix handling of KeypadModifier.
dfaure marked 4 inline comments as done. dfaure added a comment. What if you write me down as maintainer of this code, can this then go in? REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D6233 To: dfaure, graesslin Cc: graesslin, #frameworks
D6466: Android: scan for qml files in the source dir, not in the install dir.
dfaure added a comment. In https://phabricator.kde.org/D6466#121152, @apol wrote: > This will be problematic as soon as your application depends on any libraries. You mean, libraries which themselves have installed QML files, right? Depending on e.g. ki18n is no problem. But yeah I can see how this would be a problem for something that depends on kirigami for instance. If we can't find a better solution, then at least it should be documented in the ECM android stuff to NOT put qml files into a .qrc... > So far we've worked with the assumption that you'd install the applications into a prefix then ran `androiddeployqt` over this file. Well, that's exactly what I was doing... but if the QML files are built into a .qrc rather than installed, then this fails. (The assumption also requires that the install prefix is only used for one android app only, otherwise it would all get mixed up) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6466 To: dfaure, apol, mart Cc: #build_system, #frameworks
D6535: Use mutually exclusive group in Default Mark Type
kfunk edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6535 To: kfunk Cc: kwrite-devel, #frameworks
D6535: Use mutually exclusive group in Default Mark Type
kfunk updated this revision to Diff 16265. kfunk added a comment. Polish commit message REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6535?vs=16264=16265 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6535 AFFECTED FILES src/view/kateviewhelpers.cpp To: kfunk Cc: kwrite-devel, #frameworks
D6535: Use mutually exclusive group in Default Mark Type
kfunk created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY Before: Set Default Mark Type: [ ] Bookmark [X] Breakpoint After: Set Default Mark Type: ( ) Bookmark (x) Breakpoint Follow-up on KDevelop patch: https://phabricator.kde.org/D6179 REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D6535 AFFECTED FILES src/view/kateviewhelpers.cpp To: kfunk Cc: kwrite-devel, #frameworks
D6523: check Buffer validity
graesslin added a comment. Erm why was this pushed although it was in state changes requested? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6523 To: mart, #plasma, davidedmundson, graesslin Cc: graesslin, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6532: When requesting from the cache, report all entries at bulk
apol created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY No need to signal separate times. This gives the client the possibility to know whether it should request for more entries or not. Otherwise it might request them when they will be fetched anyway. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D6532 AFFECTED FILES src/core/engine.cpp To: apol, #frameworks, whiting, leinir
D6518: guard against themes without a valid shadow
mart abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6518 To: mart, #plasma Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6390: Add remote runners over DBus
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner BRANCH dbusrunner REVISION DETAIL https://phabricator.kde.org/D6390 To: davidedmundson, #plasma, broulik Cc: broulik, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6390: Add remote runners over DBus
davidedmundson updated this revision to Diff 16245. davidedmundson marked 2 inline comments as done. davidedmundson added a comment. Kai's comments REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6390?vs=16231=16245 BRANCH dbusrunner REVISION DETAIL https://phabricator.kde.org/D6390 AFFECTED FILES autotests/CMakeLists.txt autotests/dbusrunnertest.cpp autotests/dbusrunnertest.desktop autotests/testremoterunner.cpp autotests/testremoterunner.h src/CMakeLists.txt src/abstractrunner.cpp src/data/org.kde.krunner1.xml src/data/servicetypes/plasma-runner.desktop src/dbusrunner.cpp src/dbusrunner_p.h src/dbusutils_p.h src/querymatch.cpp src/querymatch.h src/runnermanager.cpp To: davidedmundson, #plasma Cc: broulik, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 8 - Failure!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/8/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Thu, 06 Jul 2017 15:54:06 + Build duration: 50 sec and counting CONSOLE OUTPUT [...truncated 90.27 KB...]-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/private/SwipeItemEventFilter.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/private/PrivateActionToolButton.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/private/DefaultListItemBackground.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/private/PageActionPropertyGroup.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/private/RefreshableScrollView.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/private/CornerShadow.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/private/EdgeShadow.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/templates-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/templates/OverlaySheet.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/templates/OverlayDrawer.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/templates/private-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/templates/private/ScrollView.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/templates/private/PassiveNotification.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/templates/private/BackButton.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/templates/private/MenuIcon.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/templates/private/ContextIcon.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/templates/SwipeListItem.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/templates/AbstractApplicationHeader.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/templates/ApplicationHeader.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/templates/AbstractListItem.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/ScrollablePage.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/Theme.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/SwipeListItem.qml-- Installing: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 XenialQt5.7/install-divert/home/jenkins/install-prefix/lib/x86_64-linux-gnu/qml/org/kde/kirigami.2/Label.qml-- Installing:
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 7 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/7/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 06 Jul 2017 15:54:06 + Build duration: 28 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests build.log Description: Binary data
D6527: [Containment Interface] Keep containment in RequiresAttentionStatus while context menu is open
broulik added inline comments.
INLINE COMMENTS
> containmentinterface.cpp:1073
> +
> +connect(desktopMenu, ::aboutToHide, m_containment, [this,
> oldStatus] {
> +m_containment->setStatus(oldStatus);
Not sure if we should use `this` (and then check `if m_containment` as context
or `m_containment`
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6527
To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
D6523: check Buffer validity
This revision was automatically updated to reflect the committed changes. Closed by commit R127:dd8e084a685e: check Buffer validity (authored by mart). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6523?vs=16229=16242 REVISION DETAIL https://phabricator.kde.org/D6523 AFFECTED FILES src/client/shadow.cpp To: mart, #plasma, davidedmundson, graesslin Cc: graesslin, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6523: check Buffer validity
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. please add a test case for the problem. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6523 To: mart, #plasma, davidedmundson, graesslin Cc: graesslin, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
KDE CI: Frameworks kwayland kf5-qt5 XenialQt5.7 - Build # 20 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/20/ Project: Frameworks kwayland kf5-qt5 XenialQt5.7 Date of build: Thu, 06 Jul 2017 14:30:32 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 36 test(s), Skipped: 0 test(s), Total: 37 test(s)Failed: TestSuite.kwayland-testWaylandSurface Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (4/4)99% (196/197)99% (196/197)93% (20978/22543)54% (10359/19072)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.client100% (32/32)100% (32/32)99% (10225/10285)50% (6741/13405)autotests.server100% (5/5)100% (5/5)99% (356/359)49% (211/428)src.client100% (62/62)100% (62/62)87% (4757/5480)65% (1570/2420)src.server99% (97/98)99% (97/98)88% (5640/6419)65% (1837/2819) build.log Description: Binary data
D6527: [Containment Interface] Keep containment in RequiresAttentionStatus while context menu is open
broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This ensures the panel does not auto-hide then. It also forces a re-evaluation of auto-hide status when the menu closes, so even if we mess up with mouse grabbing, it should more reliably auto-hide afterwards. BUG: 344205 CCBUG: 351823 TEST PLAN Right clicked a couple of applets, panel stayed visible while the menu was open. It auto-hid again when I closed the menu. Task Manager needs a separate patch but this should be fairly trivial, something like `Plasmoid.status: contextMenu && contextMenu.status === PlasmaCore.Dialog.Open ? PlasmaCore.Types.RequiresAttentionStatus : PlasmaCore.Types.ActiveStatus` I tried meddling with `focusWindow` and `applicationState` but I never got a meaningful change in the two when the context menu closed, so I chose this crude approach REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6527 AFFECTED FILES src/scriptengines/qml/plasmoid/containmentinterface.cpp To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6390: Add remote runners over DBus
davidedmundson marked 9 inline comments as done. davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in dbusrunnertest.cpp:88 > Why are you using `QString` and not `QStringLiteral` all over the place? because it's in a test... > broulik wrote in dbusrunner.cpp:109 > We cannot have matches with different actions then, right? I don't think we > do that in any other runner, so this is fine. It would be possible to do, we can have RemoteMatch have a list of actionIDs with it. We'd then have to cache that in the queryMatch, which would be easier if I wasn't already using setData as id gets mangled and could fetch them here. > broulik wrote in querymatch.h:77 > ` = nullptr` > > Seems an unrelated (and unneccessary?) change to me, though I have to Q_DECLARE_METATYPE for QSignalSpy. That means it needs a default constructor. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D6390 To: davidedmundson, #plasma Cc: broulik, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6523: check Buffer validity
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D6523 To: mart, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6523: check Buffer validity
mart added a comment. In https://phabricator.kde.org/D6523#122107, @davidedmundson wrote: > Same question as before, what happens when we go from a theme with shadows to a theme without? I tried to switch back and forth several times between breeze and keramiek(the theme linked in the bug which could reproduce the crash) and all seems to be fine the shadows go from visible to absent and back and doesn't crash REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6523 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6390: Add remote runners over DBus
broulik added a comment.
Cool stuff!
A bunch of nitpicks but then it's good to go.
INLINE COMMENTS
> dbusrunnertest.cpp:45
> +void testMatch();
> +//
> +private:
Remove
> dbusrunnertest.cpp:52
> +{
> +m_process = new QProcess(this);
> +m_process->start(QFINDTESTDATA("testremoterunner"));
Put in initializer list
DBusRunnerTest::DBusRunnerTest()
: m_process(new QProcess(this))
> dbusrunnertest.cpp:65
> +{
> +QStandardPaths::enableTestMode(true);
> +
> QDir(QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation)).mkpath("kservices5");
This is deprecated, use `setTestModeEnabled`
> dbusrunnertest.cpp:88
> +//see testremoterunner.cpp
> +QCOMPARE(result.id(), QString("dbusrunnertest_id1")); //note the runner
> name is prepended
> +QCOMPARE(result.text(), QString("Match 1"));
Why are you using `QString` and not `QStringLiteral` all over the place?
> dbusrunnertest.cpp:99
> +
> +QCOMPARE(action->text(), QString("Action 1"));
> +
`QStringLiteral`
> dbusrunnertest.desktop:14
> +X-Plasma-API=DBus
> +X-Plasma-DBusRunner-Service=net.dave
> +X-Plasma-DBusRunner-Path=/dave
:D
> testremoterunner.cpp:27
> +
> +//Test DBus runner, if the search term is "foo" it returns a match,
> otherwise nothing
> +//Run prints a line to stdout
you say "is" but below you do `contains`
> testremoterunner.cpp:34
> +QDBusConnection::sessionBus().registerService("net.dave");
> +QDBusConnection::sessionBus().registerObject("/dave", this);
> +qDBusRegisterMetaType();
`registerObject` before `registerService` (Thiago iirc said that should be done
with the new threaded dbus thing to avoid a service being exported in an
inconsistent state)
> dbusrunner.cpp:98
> +
> +//split is essential items are as native DBus types, optional extras
> are in the property map (which is obviously a lot slower to parse)
> +
> m.setUrls(QUrl::fromStringList(match.properties.value("urls").toStringList()));
I see.
subtext is widely used from what I can tell, whereas setMatchCategory is only
used by baloo runner but that one typically spawns a ton of results for a
query. (Just a comment, doesn't mean you neccessarily should change this)
> dbusrunner.cpp:109
> +{
> +return actions().values();
> +}
We cannot have matches with different actions then, right? I don't think we do
that in any other runner, so this is fine.
> dbusrunner_p.h:38
> +
> +protected slots:
> +private:
Remove
> querymatch.h:77
> */
> -explicit QueryMatch(AbstractRunner *runner);
> +explicit QueryMatch(AbstractRunner *runner=0);
>
` = nullptr`
Seems an unrelated (and unneccessary?) change to me, though
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D6390
To: davidedmundson, #plasma
Cc: broulik, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6519: Use CMAKE_INSTALL_BINDIR for dbus service generation
This revision was automatically updated to reflect the committed changes. Closed by commit R311:f5ce89309e29: Use CMAKE_INSTALL_BINDIR for dbus service generation (authored by bkchr, committed by apol). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6519?vs=16215=16233 REVISION DETAIL https://phabricator.kde.org/D6519 AFFECTED FILES src/runtime/kwalletd/org.kde.kwalletd5.service.in To: bkchr, apol Cc: #frameworks
D6519: Use CMAKE_INSTALL_BINDIR for dbus service generation
bkchr added a comment. Use g...@kchr.de Thank you :) REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D6519 To: bkchr, apol Cc: #frameworks
D6519: Use CMAKE_INSTALL_BINDIR for dbus service generation
apol added a comment. In https://phabricator.kde.org/D6519#122060, @bkchr wrote: > @apol do you will push this change for me? Or will this happen automatically? ^^ I can do that, can you tell me what e-mail to use? REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D6519 To: bkchr, apol Cc: #frameworks
D6523: check Buffer validity
davidedmundson added a comment. Same question as before, what happens when we go from a theme with shadows to a theme without? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6523 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6331: Make sure that the tsfiles target is generated
This revision was automatically updated to reflect the committed changes. apol marked an inline comment as done. Closed by commit R249:77eab970fde3: Make sure that the tsfiles target is generated (authored by apol). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6331?vs=16202=16232 REVISION DETAIL https://phabricator.kde.org/D6331 AFFECTED FILES cmake/KF5I18NMacros.cmake To: apol, #frameworks, ltoscano, lueck, aacid Cc: aacid, asturmlechner
D6390: Add remote runners over DBus
davidedmundson retitled this revision from "WIP: Add remote runners over DBus" to "Add remote runners over DBus". REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D6390 To: davidedmundson, #plasma Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6390: WIP: Add remote runners over DBus
davidedmundson updated this revision to Diff 16231. davidedmundson added a comment. Added unit test, support actions REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6390?vs=15870=16231 BRANCH dbusrunner REVISION DETAIL https://phabricator.kde.org/D6390 AFFECTED FILES autotests/CMakeLists.txt autotests/dbusrunnertest.cpp autotests/dbusrunnertest.desktop autotests/testremoterunner.cpp autotests/testremoterunner.h src/CMakeLists.txt src/abstractrunner.cpp src/data/org.kde.krunner1.xml src/data/servicetypes/plasma-runner.desktop src/dbusrunner.cpp src/dbusrunner_p.h src/dbusutils_p.h src/querymatch.cpp src/querymatch.h src/runnermanager.cpp To: davidedmundson, #plasma Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6519: Use CMAKE_INSTALL_BINDIR for dbus service generation
bkchr added a comment. @apol do you will push this change for me? Or will this happen automatically? ^^ REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D6519 To: bkchr, apol Cc: #frameworks
D6519: Use CMAKE_INSTALL_BINDIR for dbus service generation
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D6519 To: bkchr, apol Cc: #frameworks
D6518: guard against themes without a valid shadow
mart added a comment. replaced by https://phabricator.kde.org/D6523 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6518 To: mart, #plasma Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6523: check Buffer validity
mart created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY if a plasma theme doesn't provide shadow graphics, the buffer will be a nullptr as would be created from an invalid image and would crash BUG:381953 TEST PLAN no crash anymore when using a theme that doesn't provide shadows REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D6523 AFFECTED FILES src/client/shadow.cpp To: mart, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6518: guard against themes without a valid shadow
davidedmundson added a comment.
Buffer::Ptr ShmPool::createBuffer(const QImage& image)
{
if (image.isNull() || !d->valid) {
return QWeakPointer();
}
...
if our image is null (which it is), we get an an invalid Buffer::Ptr
Shadow::attach expects that to be valid.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6518
To: mart, #plasma
Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart,
lukas
D6518: guard against themes without a valid shadow
mart added a comment. In https://phabricator.kde.org/D6518#121981, @davidedmundson wrote: > What if a theme only has shadow-top, but not right etc. > (or a more likely scenario, they exist, but the metadata has them be 0px big) > > What would happen if you have a theme with shadow then switch to one without? yeah, a better fix is needed. i can either check for every element, or try to make kwayland not crash (tough i'm still not really understanding why it does) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6518 To: mart, #plasma Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
