D1231: Add Remote Access interface to KWayland

2017-07-07 Thread Oleg Chernovskiy 
Kanedias added a comment.


  I'll get rid of the fakeinput-related changes and test it with KRfb tomorrow.
  
  @davidedmundson , can you test this with multiple outputs?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D1231: Add Remote Access interface to KWayland

2017-07-07 Thread Oleg Chernovskiy 
Kanedias updated this revision to Diff 16318.
Kanedias added a comment.


  Added wl_output reference for buffers as requested by @davidedmundson and 
@graesslin

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1231?vs=15553&id=16318

REVISION DETAIL
  https://phabricator.kde.org/D1231

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_remote_access.cpp
  src/client/CMakeLists.txt
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/protocols/remote-access.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/remote_access.cpp
  src/client/remote_access.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h
  src/server/remote_access_interface.cpp
  src/server/remote_access_interface.h
  src/server/remote_access_interface_p.h
  src/tools/mapping.txt
  src/tools/testserver/testserver.cpp

To: Kanedias, graesslin, davidedmundson
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab.

2017-07-07 Thread Matthew Dawson 
mdawson added a comment.


  +1 LGTM.  Before submitting, can you poke the usability people about this 
change please?  If they are also happy, then it's got a ship it from me.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D6553

To: dfaure, mdawson
Cc: ltoscano, apol, #frameworks

D6558: do not stderr that NoDisplay is set

2017-07-07 Thread Harald Sitter 
sitter created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  KF5PackageMacros turns stderr output into cmake level warnings.
  
  setting nodisplay is perfectly reasonable and doesn't warrant a warning.
  additionally these warnings are turned into test data by the CI, so
  every plasmoid with nodisplay is causing unstable builds for no reason.
  
  iff kpackagetool had a `-o outputfile` argument and stopped using stdout
  for file output there'd be a place to print non-essential info such as
  nodisplay being off. alas, no such luck.

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6558

AFFECTED FILES
  src/kpackagetool/kpackagetool.cpp

To: sitter, mart, sebas, apol
Cc: #frameworks

D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab.

2017-07-07 Thread Aleix Pol Gonzalez 
apol added a comment.


  In https://phabricator.kde.org/D6553#122749, @ltoscano wrote:
  
  > Just to be sure, does it touch all applications which uses tabs (like 
Okular)?
  
  
  Yes, unless Okular is not using the standard action.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D6553

To: dfaure, mdawson
Cc: ltoscano, apol, #frameworks

D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab.

2017-07-07 Thread Luigi Toscano 
ltoscano added a comment.


  Just to be sure, does it touch all applications which uses tabs (like Okular)?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D6553

To: dfaure, mdawson
Cc: ltoscano, apol, #frameworks

D6532: When requesting from the cache, report all entries at bulk

2017-07-07 Thread Aleix Pol Gonzalez 
apol closed this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6532

To: apol, #frameworks, whiting, leinir

D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab.

2017-07-07 Thread Aleix Pol Gonzalez 
apol added a comment.


  +1, this has annoyed me in the past.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D6553

To: dfaure, mdawson
Cc: apol, #frameworks

D6554: [Plasma Dialog] Fix flag condition

2017-07-07 Thread David Edmundson 
davidedmundson added a comment.


  Your description doesn't match the code
  
  > This didn't work when other flags,, such as WindowStaysOnTopHint were 
present.
  
  & Flag is the same as TestFlag()
  
  From what I can tell, you've changed:
  
  if (!tooltipFlag && !notification)
  into if(!   (tooltipFlag && !notification)
  
  which is quite possibly correct and valid, but it doesn't match what you said.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6554

To: broulik, #plasma, mart
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6554: [Plasma Dialog] Fix flag condition

2017-07-07 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6554

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6554: [Plasma Dialog] Fix flag condition

2017-07-07 Thread Kai Uwe Broulik 
broulik edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6554

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6554: [Plasma Dialog] Fix flag condition

2017-07-07 Thread Kai Uwe Broulik 
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  The code wants to check whether we're not a tooltip. This didn't work.

TEST PLAN
  My Alternatives popup now slides in from the panel. Verified that it follows 
the panel location (top/bottom)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6554

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab.

2017-07-07 Thread David Faure 
dfaure created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  This is what other webbrowsers like Firefox and Chrome do,
  and is certainly much more international than Ctrl+Comma/Ctrl+Dot which
  is very qwerty centric.

TEST PLAN
  Switching tabs in Konqueror

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6553

AFFECTED FILES
  src/gui/kstandardshortcut.cpp

To: dfaure, mdawson
Cc: #frameworks

D6466: Android: scan for qml files in the source dir, not in the install dir.

2017-07-07 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  In https://phabricator.kde.org/D6466#122419, @dfaure wrote:
  
  > In https://phabricator.kde.org/D6466#121152, @apol wrote:
  >
  > > This will be problematic as soon as your application depends on any 
libraries.
  >
  >
  > You mean, libraries which themselves have installed QML files, right? 
Depending on e.g. ki18n is no problem.
  >
  > But yeah I can see how this would be a problem for something that depends 
on kirigami for instance.
  >
  > If we can't find a better solution, then at least it should be documented 
in the ECM android stuff to NOT put qml files into a .qrc...
  
  
  Yes, that's what I meant.
  
  >> So far we've worked with the assumption that you'd install the 
applications into a prefix then ran `androiddeployqt` over this file.
  > 
  > Well, that's exactly what I was doing... but if the QML files are built 
into a .qrc rather than installed, then this fails.
  
  Yes, I understand your problem.
  
  > (The assumption also requires that the install prefix is only used for one 
android app only, otherwise it would all get mixed up)
  
  Yes.
  
  I've been thinking it through, I agree that the qrc use-case should be 
properly supported. Let's get this one in and if something's missing we can fix 
it in `androiddeployqt`.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6466

To: dfaure, apol, mart
Cc: #build_system, #frameworks

D6543: [KPageListViewDelegate] Pass widget to drawPrimitive

2017-07-07 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:abe58c287c32: [KPageListViewDelegate] Pass widget to 
drawPrimitive in drawFocus (authored by broulik).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6543?vs=16286&id=16301

REVISION DETAIL
  https://phabricator.kde.org/D6543

AFFECTED FILES
  src/kpageview_p.cpp

To: broulik, kde-frameworks-devel, fvogt
Cc: #frameworks

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 29 - Still Unstable!

2017-07-07 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/29/
 Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
 Date of build:
Fri, 07 Jul 2017 11:46:35 +
 Build duration:
4 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: TestSuite.kdirwatch_fam_unittestFailed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(10/10)85%
(79/93)85%
(79/93)73%
(6052/8252)43%
(10538/24499)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests83%
(33/40)83%
(33/40)97%
(2610/2693)49%
(6474/13211)src.desktoptojson100%
(3/3)100%
(3/3)79%
(84/106)38%
(123/324)src.lib67%
(2/3)67%
(2/3)56%
(302/536)22%
(181/825)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/787)18%
(192/1076)src.lib.io90%
(9/10)90%
(9/10)58%
(817/1397)29%
(921/3154)src.lib.jobs71%
(5/7)71%
(5/7)52%
(159/304)39%
(57/146)src.lib.plugin100%
(8/8)100%
(8/8)86%
(646/748)44%
(984/2216)src.lib.randomness100%
(2/2)100%
(2/2)67%
(66/99)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)46%
(349/764)40%
(748/1867)src.lib.util100%
(10/10)100%
(10/10)82%
(667/818)51%
(814/1604)

build.log
Description: Binary data

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 24 - Unstable!

2017-07-07 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/24/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
 Date of build:
Fri, 07 Jul 2017 11:46:35 +
 Build duration:
2 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 22 test(s)Failed: TestSuite.kdirwatch_stat_unittestFailed: TestSuite.kshelltest

build.log
Description: Binary data

D6537: Fix display of formatDuration with rounding.

2017-07-07 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:13675d6ab695: Fix display of formatDuration with 
rounding. (authored by davidedmundson).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6537?vs=16271&id=16300

REVISION DETAIL
  https://phabricator.kde.org/D6537

AFFECTED FILES
  autotests/kformattest.cpp
  src/lib/util/kformatprivate.cpp

To: davidedmundson, dfaure
Cc: #frameworks

D6537: Fix display of formatDuration with rounding.

2017-07-07 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6537

To: davidedmundson, dfaure
Cc: #frameworks

D6527: [Containment Interface] Keep containment in RequiresAttentionStatus while context menu is open

2017-07-07 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f3dcff28b8fb: [Containment Interface] Keep containment in 
RequiresAttentionStatus while… (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6527?vs=16238&id=16298

REVISION DETAIL
  https://phabricator.kde.org/D6527

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: broulik, #plasma, mart
Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D6547: Fix build with Qt 5.9.1 and clang

2017-07-07 Thread Kevin Funk 
kfunk accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6547

To: elvisangelaccio, #frameworks, kfunk

D6547: Fix build with Qt 5.9.1 and clang

2017-07-07 Thread Elvis Angelaccio 
elvisangelaccio edited the summary of this revision.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D6547

To: elvisangelaccio, #frameworks

D6547: Fix build with Qt 5.9.1 and clang

2017-07-07 Thread Elvis Angelaccio 
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Qt 5.9.1 expands Q_REQUIRED_RESULT to the 
 attribute (see
  commit d254d8c19 in qtbase). This breaks the build with clang compilers
  because  cannot be used at the end 
of a function
  declaration:
  
error: 'nodiscard' attribute cannot be applied to types
  
  For the record, GCC just issues a 'attribute ignored' warning when
   is used at the end of a 
declaration.

TEST PLAN
  ki18n now builds with clang + Qt 5.9.1

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6547

AFFECTED FILES
  src/klocalizedstring.h

To: elvisangelaccio, #frameworks

D6543: [KPageListViewDelegate] Pass widget to drawPrimitive

2017-07-07 Thread Fabian Vogt 
fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  Tested, works fine here.
  
  I don't see any other cases of drawPrimitive being invoked without passing a 
widget.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D6543

To: broulik, kde-frameworks-devel, fvogt
Cc: #frameworks

D6543: [KPageListViewDelegate] Pass widget to drawPrimitive

2017-07-07 Thread Kai Uwe Broulik 
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Ensure the style knows what widget its painting focus for.
  Also take the widget's style (as is done in the delegate paint method)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D6543

AFFECTED FILES
  src/kpageview_p.cpp

To: broulik, kde-frameworks-devel, fvogt
Cc: #frameworks

D6532: When requesting from the cache, report all entries at bulk

2017-07-07 Thread Dan Leinir Turthra Jensen 
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  Hmm... i was thinking this //could// cause issues, i don't see anywhere 
assumptions are made about page size on the consumption side (damn we're lucky 
this whole split thing's so new ;) ). Nothing in the API suggests you might get 
more than the requested number when you ask for entries, but conversely nothing 
says you will potentially get less, and that happens on a regular basis, so... 
sure, why not :)

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6532

To: apol, #frameworks, whiting, leinir

D6535: Use mutually exclusive group in Default Mark Type

2017-07-07 Thread Kevin Funk 
kfunk updated this revision to Diff 16285.
kfunk added a comment.


  Fix logic. Sorry, must have been asleep here... :\

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6535?vs=16284&id=16285

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6535

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: kfunk
Cc: croick, kwrite-devel, #frameworks

D6535: Use mutually exclusive group in Default Mark Type

2017-07-07 Thread Kevin Funk 
kfunk updated this revision to Diff 16284.
kfunk added a comment.


  Simplify code, address concerns

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6535?vs=16265&id=16284

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6535

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: kfunk
Cc: croick, kwrite-devel, #frameworks

D6541: Emit signals from icon border when no mark was clicked

2017-07-07 Thread Christoph Roick 
croick created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  - currently it is not possible to get a signal from the icon border menu when 
no mark is clicked, which prevents the creation of custom context menus for no 
marks
  - would probably break programs which set handled to true in any case without 
checking the mark type

TEST PLAN
  - tested the change with KDevelop and observed no change

REPOSITORY
  R39 KTextEditor

BRANCH
  defaultmarker

REVISION DETAIL
  https://phabricator.kde.org/D6541

AFFECTED FILES
  src/document/katedocument.cpp

To: croick, #ktexteditor
Cc: kwrite-devel, #frameworks

D6535: Use mutually exclusive group in Default Mark Type

2017-07-07 Thread Christoph Roick 
croick added inline comments.

INLINE COMMENTS

> kateviewhelpers.cpp:2257
>  dMA = selectDefaultMark.addAction(i18n("Mark Type %1",  bit + 
> 1));
> +selectDefaultMarkActionGroup->addAction(dMA);
>  }

this could be done once, after the if-else-block

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D6535

To: kfunk
Cc: croick, kwrite-devel, #frameworks

D6540: Use QActionGroup in icon border default marker menu

2017-07-07 Thread Christoph Roick 
croick abandoned this revision.
croick added a comment.


  Duplicate of D6535 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D6540

To: croick, #ktexteditor
Cc: kwrite-devel, #frameworks