D6541: Emit signals from icon border when no mark was clicked

[Christoph Roick]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:3b202d26f2ee: Emit signals from icon border when no mark 
was clicked (authored by croick).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6541?vs=16282=16605

REVISION DETAIL
  https://phabricator.kde.org/D6541

AFFECTED FILES
  src/document/katedocument.cpp

To: croick, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, #frameworks

Re: Review Request 130179: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130179/
---

(Updated July 12, 2017, 8:19 p.m.)


Review request for KDE Frameworks.


Changes
---

Removed trailing spaces


Bugs: 358139 and 359233
https://bugs.kde.org/show_bug.cgi?id=358139
https://bugs.kde.org/show_bug.cgi?id=359233


Repository: kio


Description
---

The current "open with" dialog implementation does not follow the KDE principle 
"Simple by default, powerful when needed" for the following reasons:
- The current primary goal of the lineedit is to type in a command. Indeed when 
start typing a drop-down list with command auto-completion appears.

Usability problems:
- The mentioned drop-down list covers the application tree
- It's not possible to search in the application tree, so to find a software it 
is necessary to guess the category every time


My patch changes the behavior as follow:

Simple by default:
- The primary goal of the lineedit is to be a search box that allows to filter 
the applications in the tree
- The command auto-completion is disabled by default

Powerful when needed
- The command autocompletion can be turned on by advanced users by selecting 
the preferred autocompletion mode in the right click context menu of the 
lineedit (this behavior is quite hidden, and I guess most of the normal users 
don't even know it's possible (I didn't know it until I dig into the code))


Implementation details:
- The application tree filtering is achieved using a subclass of 
QSortFilterProxyModel
- When 3 characters are typed in the search box all the tree is expanded (there 
should be few matching entries at this point)
- When the 3rd character is deleted all the tree is collapsed
- In order to be able to filter, it's necessary to fetch all the tree nodes 
when the model is created, and not on demand as it was before. This is achieved 
by adding a fetchAll method. Maybe there is a more elegant way.

I've tested the implementation, but I'm pretty sure I haven't covered all the 
possible cases, so a careful testing is necessary.

Relevant discussions:
https://bugs.kde.org/show_bug.cgi?id=359233
https://forum.kde.org/viewtopic.php?f=285=131014


Diffs (updated)
-

  src/widgets/kopenwithdialog.cpp b28c5b05186bc77413524c99ef61b7967b0ec8b9 
  src/widgets/kopenwithdialog_p.h 52e1bf4febcd5085a12769fc5e9fd614cb490dd6 

Diff: https://git.reviewboard.kde.org/r/130179/diff/


Testing
---

With and without some text in the line edit:
- Double click on category opens it
- Double click on entry launches the software
- Remember program association for mime works
- Run in terminal works
- Keep open terminal works


Thanks,

Simone Gaiarin

Re: Review Request 130179: Improve usability of "Open With" dialog by adding option to filter the application tree

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130179/#review103438
---




src/widgets/kopenwithdialog.cpp (line 261)


Remove trailing spaces. Kate -> settings -> open/save -> remove trailing 
spaces -> in entire document


- Anthony Fieroni


On Юли 12, 2017, 8:33 след обяд, Simone Gaiarin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130179/
> ---
> 
> (Updated Юли 12, 2017, 8:33 след обяд)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 358139 and 359233
> https://bugs.kde.org/show_bug.cgi?id=358139
> https://bugs.kde.org/show_bug.cgi?id=359233
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> The current "open with" dialog implementation does not follow the KDE 
> principle "Simple by default, powerful when needed" for the following reasons:
> - The current primary goal of the lineedit is to type in a command. Indeed 
> when start typing a drop-down list with command auto-completion appears.
> 
> Usability problems:
> - The mentioned drop-down list covers the application tree
> - It's not possible to search in the application tree, so to find a software 
> it is necessary to guess the category every time
> 
> 
> My patch changes the behavior as follow:
> 
> Simple by default:
> - The primary goal of the lineedit is to be a search box that allows to 
> filter the applications in the tree
> - The command auto-completion is disabled by default
> 
> Powerful when needed
> - The command autocompletion can be turned on by advanced users by selecting 
> the preferred autocompletion mode in the right click context menu of the 
> lineedit (this behavior is quite hidden, and I guess most of the normal users 
> don't even know it's possible (I didn't know it until I dig into the code))
> 
> 
> Implementation details:
> - The application tree filtering is achieved using a subclass of 
> QSortFilterProxyModel
> - When 3 characters are typed in the search box all the tree is expanded 
> (there should be few matching entries at this point)
> - When the 3rd character is deleted all the tree is collapsed
> - In order to be able to filter, it's necessary to fetch all the tree nodes 
> when the model is created, and not on demand as it was before. This is 
> achieved by adding a fetchAll method. Maybe there is a more elegant way.
> 
> I've tested the implementation, but I'm pretty sure I haven't covered all the 
> possible cases, so a careful testing is necessary.
> 
> Relevant discussions:
> https://bugs.kde.org/show_bug.cgi?id=359233
> https://forum.kde.org/viewtopic.php?f=285=131014
> 
> 
> Diffs
> -
> 
>   src/widgets/kopenwithdialog.cpp b28c5b05186bc77413524c99ef61b7967b0ec8b9 
>   src/widgets/kopenwithdialog_p.h 52e1bf4febcd5085a12769fc5e9fd614cb490dd6 
> 
> Diff: https://git.reviewboard.kde.org/r/130179/diff/
> 
> 
> Testing
> ---
> 
> With and without some text in the line edit:
> - Double click on category opens it
> - Double click on entry launches the software
> - Remember program association for mime works
> - Run in terminal works
> - Keep open terminal works
> 
> 
> Thanks,
> 
> Simone Gaiarin
> 
>

Review Request 130180: Make advanced options of "open with" dialog collabsible and hidden by default

[Simone Gaiarin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130180/
---

Review request for KDE Frameworks.


Bugs: 359233
https://bugs.kde.org/show_bug.cgi?id=359233


Repository: kio


Description
---

The current "open with" dialog implementation does not follow the KDE principle 
"Simple by default, powerful when needed" for the following reasons:
- The "run in terminal" and "keep terminal open" options are advanced options 
and should not be exposed by default
- The primary goal of the dialog should be to select an application from the 
app tree, running command is an advanced feature

My patch changes the behavior as follow:

- Put the two options in a KCollapsibleComboBox collapsed by default
- The user can expand it only if he needs to use a command line command


Implementation details:
- When the KCollapsibleComboBox is clicked it is expanded upward keeping the 
dialog size fixed and compressing the treeview, I'm not sure this is the best 
approach, but to make it expand downwards we need to fix the size of the dialog 
with setSizeConstraint(QLayout::SetFixedSize); which may not be desiderable. 
Maybe there is a way to keep the dialog resizable and expand the combobox 
downwards, but I couldn't find it.
- I've increased the vertical size of the dialog (which I think it was too 
small) also to accomodate the upward expansion which otherwise would make the 
app tree almost disappear


Relevant discussions:
https://bugs.kde.org/show_bug.cgi?id=359233
https://forum.kde.org/viewtopic.php?f=285=131014


Diffs
-

  src/widgets/kopenwithdialog.cpp b28c5b05186bc77413524c99ef61b7967b0ec8b9 

Diff: https://git.reviewboard.kde.org/r/130180/diff/


Testing
---


Thanks,

Simone Gaiarin

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

[Ralf Habacker]

habacker added a comment.


  > So bin isn't in %PATH%, but found relatively to the app being run?
  
  yes
  
  > This makes me wonder if libexec could be bin/libexec/kf5/ on Windows, 
relative too.
  
  This requires to add support for finding executables located in libexec based 
on install root e.g. instead of using
  
  QString command = 
QStandardPaths::findExecutable(QStringLiteral("ksendbugmail5"));
  
  to use something like this
  
  QString installroot = getKF5Prefix();   // similar to what is implemented 
in KDE4 (see  
https://cgit.kde.org/kdelibs.git/tree/kdecore/kernel/kkernel_win.cpp?h=KDE/4.14#n97)
  QString command = 
QStandardPaths::findExecutable(QStringLiteral("ksendbugmail"), installRoot + 
QStringLiteral("bin/libexec/kf5/"));  
  or 
  QString command = 
QStandardPaths::findExecutable(QStringLiteral("ksendbugmail"), installRoot + 
QStringLiteral(KF5_LIBEXEC_INSTALL_DIR));
  
  if KF5_LIBEXEC_INSTALL_DIR is a relative path to the requested subdir based 
on the install root.
  
  > Then we could have an ECM-provided string that expands to
  >  CMAKE_INSTALL_PREFIX "/" KF5_LIBEXEC_INSTALL_DIR on Unix (i.e. absolute), 
and
  >  KF5_LIBEXEC_INSTALL_DIR on Windows (i.e. relative).
  
  
  
  > Wouldn't this keep the Unix/Windows differences to a minimum?
  
  Related to install layout it would be reduce the difference, but on the 
source code side you need to add detecting the install root to any code where 
an executable located in libexec needs to be searched, which increases the 
differences in the source code.
  
  The complete code fragment would look like 
  #ifndef Q_OS_WIN32
  
QString command = 
QStandardPaths::findExecutable(QStringLiteral("ksendbugmail"));
if (command.isEmpty()) {
command = QFile::decodeName(CMAKE_INSTALL_PREFIX "/" 
KF5_LIBEXEC_INSTALL_DIR "/ksendbugmail");
  
  #else
  
QString searchPath = getKF5Prefix() + 
QStringLiteral(KF5_LIBEXEC_INSTALL_DIR);
QString command = 
QStandardPaths::findExecutable(QStringLiteral("ksendbugmail"), searchPath);  
  
  #endif
  
  An optimization would be to call getKF5Prefix() on non Windows too, which 
returns  CMAKE_INSTALL_PREFIX "/". This  reduced the above mentioned code to
  
  QString searchPath = getKF5Prefix() + QStringLiteral(KF5_LIBEXEC_INSTALL_DIR);
  QString command = 
QStandardPaths::findExecutable(QStringLiteral("ksendbugmail"), searchPath);
  
  BTW: You mentioned  that KF5_LIBEXEC_INSTALL_DIR is 'bin/libexec/kf5/' on 
Windows, Should it not be lib/libexec/kf5  ? On unix this is located in 
'lib[64]/libexec/kf5 '  - why this difference ?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D5173

To: habacker
Cc: dfaure, aacid, #frameworks

Re: Review Request 130179: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130179/
---

(Updated July 12, 2017, 5:33 p.m.)


Review request for KDE Frameworks.


Bugs: 358139 and 359233
https://bugs.kde.org/show_bug.cgi?id=358139
https://bugs.kde.org/show_bug.cgi?id=359233


Repository: kio


Description
---

The current "open with" dialog implementation does not follow the KDE principle 
"Simple by default, powerful when needed" for the following reasons:
- The current primary goal of the lineedit is to type in a command. Indeed when 
start typing a drop-down list with command auto-completion appears.

Usability problems:
- The mentioned drop-down list covers the application tree
- It's not possible to search in the application tree, so to find a software it 
is necessary to guess the category every time


My patch changes the behavior as follow:

Simple by default:
- The primary goal of the lineedit is to be a search box that allows to filter 
the applications in the tree
- The command auto-completion is disabled by default

Powerful when needed
- The command autocompletion can be turned on by advanced users by selecting 
the preferred autocompletion mode in the right click context menu of the 
lineedit (this behavior is quite hidden, and I guess most of the normal users 
don't even know it's possible (I didn't know it until I dig into the code))


Implementation details:
- The application tree filtering is achieved using a subclass of 
QSortFilterProxyModel
- When 3 characters are typed in the search box all the tree is expanded (there 
should be few matching entries at this point)
- When the 3rd character is deleted all the tree is collapsed
- In order to be able to filter, it's necessary to fetch all the tree nodes 
when the model is created, and not on demand as it was before. This is achieved 
by adding a fetchAll method. Maybe there is a more elegant way.

I've tested the implementation, but I'm pretty sure I haven't covered all the 
possible cases, so a careful testing is necessary.

Relevant discussions:
https://bugs.kde.org/show_bug.cgi?id=359233
https://forum.kde.org/viewtopic.php?f=285=131014


Diffs
-

  src/widgets/kopenwithdialog.cpp b28c5b05186bc77413524c99ef61b7967b0ec8b9 
  src/widgets/kopenwithdialog_p.h 52e1bf4febcd5085a12769fc5e9fd614cb490dd6 

Diff: https://git.reviewboard.kde.org/r/130179/diff/


Testing
---

With and without some text in the line edit:
- Double click on category opens it
- Double click on entry launches the software
- Remember program association for mime works
- Run in terminal works
- Keep open terminal works


Thanks,

Simone Gaiarin

Re: Review Request 130179: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130179/
---

(Updated July 12, 2017, 4:50 p.m.)


Review request for KDE Frameworks.


Summary (updated)
-

Improve usability of "Open With" dialog by adding option to filter the 
application tree


Bugs: 359233
https://bugs.kde.org/show_bug.cgi?id=359233


Repository: kio


Description
---

The current "open with" dialog implementation does not follow the KDE principle 
"Simple by default, powerful when needed" for the following reasons:
- The current primary goal of the lineedit is to type in a command. Indeed when 
start typing a drop-down list with command auto-completion appears.

Usability problems:
- The mentioned drop-down list covers the application tree
- It's not possible to search in the application tree, so to find a software it 
is necessary to guess the category every time


My patch changes the behavior as follow:

Simple by default:
- The primary goal of the lineedit is to be a search box that allows to filter 
the applications in the tree
- The command auto-completion is disabled by default

Powerful when needed
- The command autocompletion can be turned on by advanced users by selecting 
the preferred autocompletion mode in the right click context menu of the 
lineedit (this behavior is quite hidden, and I guess most of the normal users 
don't even know it's possible (I didn't know it until I dig into the code))


Implementation details:
- The application tree filtering is achieved using a subclass of 
QSortFilterProxyModel
- When 3 characters are typed in the search box all the tree is expanded (there 
should be few matching entries at this point)
- When the 3rd character is deleted all the tree is collapsed
- In order to be able to filter, it's necessary to fetch all the tree nodes 
when the model is created, and not on demand as it was before. This is achieved 
by adding a fetchAll method. Maybe there is a more elegant way.

I've tested the implementation, but I'm pretty sure I haven't covered all the 
possible cases, so a careful testing is necessary.

Relevant discussions:
https://bugs.kde.org/show_bug.cgi?id=359233
https://forum.kde.org/viewtopic.php?f=285=131014


Diffs
-

  src/widgets/kopenwithdialog.cpp b28c5b05186bc77413524c99ef61b7967b0ec8b9 
  src/widgets/kopenwithdialog_p.h 52e1bf4febcd5085a12769fc5e9fd614cb490dd6 

Diff: https://git.reviewboard.kde.org/r/130179/diff/


Testing
---

With and without some text in the line edit:
- Double click on category opens it
- Double click on entry launches the software
- Remember program association for mime works
- Run in terminal works
- Keep open terminal works


Thanks,

Simone Gaiarin

Review Request 130179: Disable autocompletion by default

[Simone Gaiarin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130179/
---

Review request for KDE Frameworks.


Bugs: 359233
https://bugs.kde.org/show_bug.cgi?id=359233


Repository: kio


Description
---

The current "open with" dialog implementation does not follow the KDE principle 
"Simple by default, powerful when needed" for the following reasons:
- The current primary goal of the lineedit is to type in a command. Indeed when 
start typing a drop-down list with command auto-completion appears.

Usability problems:
- The mentioned drop-down list covers the application tree
- It's not possible to search in the application tree, so to find a software it 
is necessary to guess the category every time


My patch changes the behavior as follow:

Simple by default:
- The primary goal of the lineedit is to be a search box that allows to filter 
the applications in the tree
- The command auto-completion is disabled by default

Powerful when needed
- The command autocompletion can be turned on by advanced users by selecting 
the preferred autocompletion mode in the right click context menu of the 
lineedit (this behavior is quite hidden, and I guess most of the normal users 
don't even know it's possible (I didn't know it until I dig into the code))


Implementation details:
- The application tree filtering is achieved using a subclass of 
QSortFilterProxyModel
- When 3 characters are typed in the search box all the tree is expanded (there 
should be few matching entries at this point)
- When the 3rd character is deleted all the tree is collapsed
- In order to be able to filter, it's necessary to fetch all the tree nodes 
when the model is created, and not on demand as it was before. This is achieved 
by adding a fetchAll method. Maybe there is a more elegant way.

I've tested the implementation, but I'm pretty sure I haven't covered all the 
possible cases, so a careful testing is necessary.

Relevant discussions:
https://bugs.kde.org/show_bug.cgi?id=359233
https://forum.kde.org/viewtopic.php?f=285=131014


Diffs
-

  src/widgets/kopenwithdialog.cpp b28c5b05186bc77413524c99ef61b7967b0ec8b9 
  src/widgets/kopenwithdialog_p.h 52e1bf4febcd5085a12769fc5e9fd614cb490dd6 

Diff: https://git.reviewboard.kde.org/r/130179/diff/


Testing
---

With and without some text in the line edit:
- Double click on category opens it
- Double click on entry launches the software
- Remember program association for mime works
- Run in terminal works
- Keep open terminal works


Thanks,

Simone Gaiarin

Re: kaboutlicense api extension ::spdxId()?

[Harald Sitter]

On Tue, Jul 11, 2017 at 2:17 PM, Sebastian Kügler  wrote:
> It does parse "and later", it's indicated by the + sign, but it's not
> reflected in the enum, GPLv2+ would be mapped to GPLv2, so you're right, our
> current system is lacking in that regard (but could be extended, although I
> don't know what would break then.

Well, yes, no, I don't know.

Currently it "handles" a trailing plus being present. So yeah, we
could actually build something. What we could do on the code side of
things is add a property `bool andLater` which would be fully
backwards compatible as querying the property is opt-in. That would
allow us to represent the and later on the code side and consequently
carry it into the spdx notation.

That said, after a bit of musing I am kinda thinking the enum should
go away (in KF6). From an API-use POV it serves no purpose to have the
licenses serialized as an enum, or at least I can't think of one. And
even internally I don't quite appreciate the way it is used.

Right now we get a stringy license key, we convert that into a License
object. And internally the type is then used to run excessively long
switch cases to translate the type into what is essentially a
displayName for displaying to the user and a full text representation
of the license. Simply put it looks to me the reason we have an enum
is so we can convert undefined input strings into well-defined output
strings. A crutch really.

With well-defined input strings (spdx license keys) we would have no
use for the enum and could write infinitely smarter code which would
be a fraction of what we have now.

In `byKeyword` one would parse proper spdx.
Once the spdx expression has been torn apart you can run the spdx key
against a hash to map it to a `name` and for the `text` you simply
`File("licensedir/$KEY.txt").open` which will also work reliably
because the key is well known. If spdx grows more options we'll not
have to care that way. If we have no fancy name we can simply fallback
to the spdx key as name, if we have no full license that's tough luck.
If we later decide that this is not good enough we can integrate spdx'
own license data https://github.com/spdx/license-list-data

In the end a plasma applet author could then define "MPL-2.0" as a
license and our UIs will know what that means without having to invent
a bunch of stringy representations to parse for, expand an enum and
write switch-case code around that in a number of methods.

(Only useful thing we'd lose is kAboutData.addLicense(enum) which does
add compiler safety, but if desired we could replace it with
kAboutData.addLicense(KAboutLicense::staticGPLv2InstanceThing); I
supose)

Something to think about maybe.

HS

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 60 - Failure!

[no-reply]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/60/
 Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
 Date of build:
Wed, 12 Jul 2017 09:47:46 +
 Build duration:
30 min and counting
   CONSOLE OUTPUT
  [...truncated 437.85 KB...] from /home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/pluginloader.cpp:46:/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/private/../packagestructure.h:45:32: note: declared here PLASMA_DEPRECATED explicit PackageStructure(QObject *parent = 0, const QVariantList  = QVariantList());^/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/pluginloader.cpp:479:33: warning: 'Plasma::Package::Package(Plasma::PackageStructure*)' is deprecated [-Wdeprecated-declarations] return Package(structure); ^In file included from /home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/build/src/plasma/plasma/package.h:1:0, from /home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/pluginloader.h:23, from /home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/pluginloader.cpp:20:/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/package.h:95:32: note: declared here PLASMA_DEPRECATED explicit Package(PackageStructure *structure = 0);^/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/pluginloader.cpp:479:33: warning: 'Plasma::Package::Package(const Plasma::Package&)' is deprecated [-Wdeprecated-declarations] return Package(structure); ^In file included from /home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/build/src/plasma/plasma/package.h:1:0, from /home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/pluginloader.h:23, from /home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/pluginloader.cpp:20:/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/package.h:107:23: note: declared here PLASMA_DEPRECATED Package(const Package );   ^/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/pluginloader.cpp:486:20: warning: 'Plasma::Package::Package(Plasma::PackageStructure*)' is deprecated [-Wdeprecated-declarations] return Package();^In file included from /home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/build/src/plasma/plasma/package.h:1:0, from /home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/pluginloader.h:23, from /home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/pluginloader.cpp:20:/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/package.h:95:32: note: declared here PLASMA_DEPRECATED explicit Package(PackageStructure *structure = 0);^/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/pluginloader.cpp:486:20: warning: 'Plasma::Package::Package(const Plasma::Package&)' is deprecated [-Wdeprecated-declarations] return Package();^In file included from /home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/build/src/plasma/plasma/package.h:1:0, from /home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/pluginloader.h:23, from /home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/pluginloader.cpp:20:/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/package.h:107:23: note: declared here PLASMA_DEPRECATED Package(const Package );   ^/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/pluginloader.cpp: In member function 'KPluginInfo::List Plasma::PluginLoader::listAppletInfo(const QString&, const QString&)':/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/pluginloader.cpp:531:142: warning: 'KPluginInfo::KPluginInfo(KService::Ptr)' is deprecated [-Wdeprecated-declarations] auto pi = md.metaDataFileName().endsWith(".json") ? KPluginInfo(md) : KPluginInfo(KService::serviceByStorageId(md.metaDataFileName()));  ^In file included from /home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 XenialQt5.7/src/plasma/package.h:25:0, 

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 64 - Failure!

[no-reply]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/64/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
 Date of build:
Wed, 12 Jul 2017 09:35:43 +
 Build duration:
8 min 45 sec and counting
   CONSOLE OUTPUT
  [...truncated 249.64 KB...]PLASMA_DEPRECATED Package =(const Package );   ^[ 34%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/dataengine.cpp.o/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7/src/plasma/private/applet_p.cpp:155:47: warning: 'loadPackage' is deprecated [-Wdeprecated-declarations]Plasma::Package p = PluginLoader::self()->loadPackage(QStringLiteral("Plasma/Applet"), api);  ^/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7/src/plasma/pluginloader.h:156:31: note: 'loadPackage' has been explicitly marked deprecated herePLASMA_DEPRECATED Package loadPackage(const QString , const QString  = QString());  ^/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7/src/plasma/private/applet_p.cpp:155:25: warning: 'Package' is deprecated [-Wdeprecated-declarations]Plasma::Package p = PluginLoader::self()->loadPackage(QStringLiteral("Plasma/Applet"), api);^/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7/src/plasma/private/../package.h:107:23: note: 'Package' has been explicitly marked deprecated herePLASMA_DEPRECATED Package(const Package );  ^/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7/src/plasma/private/applet_p.cpp:156:7: warning: 'setPath' is deprecated [-Wdeprecated-declarations]p.setPath(path);  ^/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7/src/plasma/private/../package.h:135:28: note: 'setPath' has been explicitly marked deprecated herePLASMA_DEPRECATED void setPath(const QString );   ^[ 35%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/dataengineconsumer.cpp.o4 warnings generated.1 warning and 1 error generated.[ 35%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/service.cpp.ogmake[2]: *** [src/plasma/CMakeFiles/KF5Plasma.dir/build.make:95: src/plasma/CMakeFiles/KF5Plasma.dir/pluginloader.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobs/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7/src/plasma/private/timetracker.cpp:86:18: warning: _expression_ result unused [-Wunused-value]*s_beginning * 1; // ensure it's initialized ^ ~/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7/src/plasma/dataengine.cpp:400:39: warning: 'Package' is deprecated [-Wdeprecated-declarations]return d->package ? *d->package : Package();  ^/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7/src/plasma/package.h:95:32: note: 'Package' has been explicitly marked deprecated herePLASMA_DEPRECATED explicit Package(PackageStructure *structure = 0);   ^/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7/src/plasma/dataengine.cpp:400:39: warning: 'Package' is deprecated [-Wdeprecated-declarations]return d->package ? *d->package : Package();  ^/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7/src/plasma/package.h:95:32: note: 'Package' has been explicitly marked deprecated herePLASMA_DEPRECATED explicit Package(PackageStructure *structure = 0);   ^/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7/src/plasma/dataengine.cpp:400:25: warning: 'Package' is deprecated [-Wdeprecated-declarations]return d->package ? *d->package : Package();^/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7/src/plasma/package.h:107:23: note: 'Package' has been explicitly marked deprecated herePLASMA_DEPRECATED Package(const Package );  ^/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7/src/plasma/dataengine.cpp:400:39: warning: 'Package' is deprecated [-Wdeprecated-declarations]return d->package ? *d->package : Package();  ^/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7/src/plasma/package.h:107:23: note: 'Package' has been explicitly marked deprecated herePLASMA_DEPRECATED Package(const Package );  ^/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7/src/plasma/dataengine.cpp:400:12: warning: 'Package' is deprecated [-Wdeprecated-declarations]return d->package ? *d->package : Package();   

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 15 - Still Unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/15/
 Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
 Date of build:
Wed, 12 Jul 2017 09:35:42 +
 Build duration:
7 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

build.log
Description: Binary data

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 14 - Still Unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/14/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
 Date of build:
Wed, 12 Jul 2017 09:35:42 +
 Build duration:
4 min 53 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

build.log
Description: Binary data

Re: Review Request 130177: Fix 'Deprecated hint for KUrl::path() is wrong on Windows'

[Kevin Funk]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130177/#review103432
---


Fix it, then Ship it!




Note: Please start to use Phabricator. We're phasing out ReviewBoard.


src/kdecore/kurl.h (line 437)


Maybe it's also worth pointing people to 
`QUrl::toDisplayString(QUrl::PreferLocalFile | ...)` as well -- because in fact 
that's what most people want when having used `KUrl::path()` before.

I've fixed `QUrl::toDisplayString(QUrl::PreferLocalFile | ...)` in Qt 5.6 
to do what one would expect from it...


- Kevin Funk


On July 12, 2017, 6:10 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130177/
> ---
> 
> (Updated July 12, 2017, 6:10 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 382242
> https://bugs.kde.org/show_bug.cgi?id=382242
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> ---
> 
> This patch extends the documentation of KUrl::path() to use toLocalFile() for 
> local file urls. See bug for more details
> 
> 
> Diffs
> -
> 
>   src/kdecore/kurl.h 1dcd77cca66b4ebc6fcdaa36a5451a71227eecb7 
> 
> Diff: https://git.reviewboard.kde.org/r/130177/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

D6473: Crash when replacing new lines with spaces

[Anthony Fieroni]

anthonyfieroni added a comment.


  
https://phabricator.kde.org/source/ktexteditor/browse/master/src/render/katelayoutcache.cpp;ad51cece443bc6bb643fa4ca94293a13d3c2f852$321
  The problem is ```realLine >= m_renderer->doc()->lines()``` it return a 
nullptr. First of all 
https://phabricator.kde.org/source/ktexteditor/browse/master/src/render/katelayoutcache.cpp;ad51cece443bc6bb643fa4ca94293a13d3c2f852$368
 should be checked against nullptr, even all other places that line(..) is used 
or better handling of corner case.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D6473

To: jsalatas, #ktexteditor
Cc: anthonyfieroni, dhaumann, kfunk, ltoscano, kwrite-devel, #frameworks

Review Request 130177: Fix 'Deprecated hint for KUrl::path() is wrong on Windows'

[Ralf Habacker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130177/
---

Review request for KDE Frameworks.


Bugs: 382242
https://bugs.kde.org/show_bug.cgi?id=382242


Repository: kdelibs4support


Description
---

This patch extends the documentation of QUrl::path() to use toLocalFile() for 
local file urls. See bug for more details


Diffs
-

  src/kdecore/kurl.h 1dcd77cca66b4ebc6fcdaa36a5451a71227eecb7 

Diff: https://git.reviewboard.kde.org/r/130177/diff/


Testing
---


Thanks,

Ralf Habacker

Re: Review Request 130177: Fix 'Deprecated hint for KUrl::path() is wrong on Windows'

[Ralf Habacker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130177/
---

(Updated Juli 12, 2017, 8:10 vorm.)


Review request for KDE Frameworks.


Bugs: 382242
https://bugs.kde.org/show_bug.cgi?id=382242


Repository: kdelibs4support


Description (updated)
---

This patch extends the documentation of KUrl::path() to use toLocalFile() for 
local file urls. See bug for more details


Diffs
-

  src/kdecore/kurl.h 1dcd77cca66b4ebc6fcdaa36a5451a71227eecb7 

Diff: https://git.reviewboard.kde.org/r/130177/diff/


Testing
---


Thanks,

Ralf Habacker