Re: Review Request 127111: kurlnavigator: add new signal selectParentOfPreviousUrl

2017-07-28 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127111/#review103504
---


Fix it, then Ship it!





src/filewidgets/kurlnavigator.h (line 432)


5.37 by now


- David Faure


On July 27, 2017, 11:15 a.m., Gregor Mi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127111/
> ---
> 
> (Updated July 27, 2017, 11:15 a.m.)
> 
> 
> Review request for KDE Frameworks, Emmanuel Pescosta and Frank Reininghaus.
> 
> 
> Bugs: 335616
> https://bugs.kde.org/show_bug.cgi?id=335616
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Moved logic from https://git.reviewboard.kde.org/r/123253 to here.
> 
> Provides a signal to implement bug 
> https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent 
> folder selects child folder".
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 83b7b73b4b92e09076ece2d4618559ddb8089368 
>   autotests/urlutiltest.cpp PRE-CREATION 
>   src/filewidgets/kurlnavigator.h ff155c7bbdc8c72f579f730993286a4dccae6338 
>   src/filewidgets/kurlnavigator.cpp 033046f06dd5bea3f4124669c55803aba3a31789 
>   src/filewidgets/urlutil_p.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127111/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 40 - Still Unstable!

2017-07-28 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/40/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
 Date of build:
Sat, 29 Jul 2017 02:42:13 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.bug205447

build.log
Description: Binary data

KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 - Build # 40 - Still Unstable!

2017-07-28 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/40/
 Project:
Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7
 Date of build:
Fri, 28 Jul 2017 23:21:02 +
 Build duration:
3 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 49 test(s)Failed: TestSuite.KDEInstallDirsTest.relative_or_absolute

build.log
Description: Binary data

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

2017-07-28 Thread Friedrich W . H . Kossebau 
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:03fc1de44ef9: Fix usage of query_qmake: differ between 
calls expecting qmake or not (authored by kossebau).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6772?vs=16912=17344

REVISION DETAIL
  https://phabricator.kde.org/D6772

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake
  modules/ECMAddQch.cmake
  modules/ECMGeneratePriFile.cmake
  modules/ECMQueryQmake.cmake

To: kossebau, #frameworks, ltoscano, rdieter, apol
Cc: #build_system

D6972: Add CC BY-SA 4.0 International

2017-07-28 Thread Luigi Toscano 
ltoscano updated this revision to Diff 17339.
ltoscano added a comment.


  Simplify the link

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6972?vs=17337=17339

BRANCH
  add-ccbysa4

REVISION DETAIL
  https://phabricator.kde.org/D6972

AFFECTED FILES
  common/en/ccbysa4-license.html
  src/customization/en/catalog.xml
  src/customization/en/entities/ccbysa4-notice.docbook
  src/customization/en/entities/underCCBYSA4.docbook
  src/customization/en/lang.entities
  src/customization/entities/general.entities
  src/template.docbook

To: ltoscano
Cc: #frameworks, #documentation, skadinna

D6972: Add CC BY-SA 4.0 International

2017-07-28 Thread Luigi Toscano 
ltoscano created this revision.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: Documentation, Frameworks.

REVISION SUMMARY
  New default license (for new documents or relicensed).
  Discussed in the previous months on the kde-community@ list
  and during Akademy 2017.

TEST PLAN
  kdoctools compiles. The new license is rendered (with an inline
  notice, differently from the "Legal Notice" of FDL).

REPOSITORY
  R238 KDocTools

BRANCH
  add-ccbysa4

REVISION DETAIL
  https://phabricator.kde.org/D6972

AFFECTED FILES
  common/en/ccbysa4-license.html
  src/customization/en/catalog.xml
  src/customization/en/entities/ccbysa4-notice.docbook
  src/customization/en/entities/underCCBYSA4.docbook
  src/customization/en/lang.entities
  src/customization/entities/general.entities
  src/template.docbook

To: ltoscano
Cc: #frameworks, #documentation, skadinna

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 22 - Still Unstable!

2017-07-28 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/22/
 Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
 Date of build:
Fri, 28 Jul 2017 16:09:24 +
 Build duration:
4 min 23 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

build.log
Description: Binary data

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 21 - Still Unstable!

2017-07-28 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/21/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
 Date of build:
Fri, 28 Jul 2017 16:09:24 +
 Build duration:
45 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

build.log
Description: Binary data

D6964: Force Plasma style for QQC2 in applets

2017-07-28 Thread Marco Martin 
mart added a comment.


  In https://phabricator.kde.org/D6964#129762, @davidedmundson wrote:
  
  > > ‎[13:51] ‎<‎notmart‎>‎ hmm, still random failures in loading components
  > > ‎[13:58] ‎<‎notmart‎>‎ gaah, import of a subdirectory still breaks
  >
  > Is this fixed?
  
  
  no, that's the problem of having to have a "private" subfolder in both themes 
i mentioned in the commit message, will need to look deeper in qml parsing to 
figure out what's going wrong and maybe patching qt, if both the style that we 
replace and the new one are controlled by us, that's workable around (as they 
happen to have the same directory structure) fragile but works
  
  > Also we'll need to maybe look at changing how kirigami does its theme stuff 
so we can make that work.
  
  kirigami does it exactly as qqc2 does, so should work as well. also in that 
case, we should make sure that both kirigami themes which we both control have 
the same directory structure

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6964

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6964: Force Plasma style for QQC2 in applets

2017-07-28 Thread David Edmundson 
davidedmundson added a comment.


  > ‎[13:51] ‎<‎notmart‎>‎ hmm, still random failures in loading components
  > ‎[13:58] ‎<‎notmart‎>‎ gaah, import of a subdirectory still breaks
  
  Is this fixed?
  
  Also we'll need to maybe look at changing how kirigami does its theme stuff 
so we can make that work.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6964

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6964: Force Plasma style for QQC2 in applets

2017-07-28 Thread Marco Martin 
mart updated this revision to Diff 17325.
mart added a comment.


  comment useless debug

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6964?vs=17324=17325

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6964

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/packageurlinterceptor.cpp
  src/plasmaquick/packageurlinterceptor.h
  src/plasmaquick/view.cpp

To: mart, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6964: Force Plasma style for QQC2 in applets

2017-07-28 Thread Marco Martin 
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  using the qml url interceptor, rewrite imports in order
  to load always the plasma styled qqc2 controls in plasmoids
  and plasma views. As is per-engine, is possible to load
  controls with qstyle theme in configuration dialogs
  and plasma style in plasmoids.
  
  Note: this replaces just the style org.kde.desktop
  to Plasma and not every style (so with Material
  set as QT_QUICK_CONTROLS_STYLE environment variable
  plasma would load controls with material style) because
  we can control both org.kde.desktop and Plasma styles:
  they must have the same subdirectories as unlike files,
  their existence is checked before the rewrite (in our case,
   "private"), so in order to work they must exist in both
  styles

TEST PLAN
  a qqc2 button in a plasmoid has the plasma style, in
  a config dialog has the qwidget style. rewrite works
  only from org.kde.desktop to Plasma and not from other
  styles, due to the existence of the "private" subdirectory

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6964

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/packageurlinterceptor.cpp
  src/plasmaquick/packageurlinterceptor.h
  src/plasmaquick/view.cpp

To: mart, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6963: Don't block starting notification service

2017-07-28 Thread David Edmundson 
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  We don't need to manually start the DBus service. 
  It blocks the calling app, and dbusServiceExists means that we will
  always end up going the DBus route over a popup anyway, so it won't 
  do anything useful.
  
  The service (in the plasma case plasma-wait-for-name) will be started
  automatically when we actually send the notification.
  
  BUG: 382444

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6963

AFFECTED FILES
  src/notifybypopup.cpp

To: davidedmundson
Cc: #frameworks

D6960: Properly handle org.fd.Notifications service failing to start

2017-07-28 Thread Daniel Vrátil 
dvratil created this revision.
dvratil added a project: Frameworks.

REVISION SUMMARY
  Handle the situation when the startServiceByName invoked from the 
NotifyByPopup plugin fails by setting dbusServiceExists back to false. This 
forces the plugin to fallback to KPassivePopup instead of putting all 
notifications into a queue that will likely never be processed.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D6960

AFFECTED FILES
  src/notifybypopup.cpp

To: dvratil, mck182, #frameworks

D6906: Create a "." entry even on empty dirs

2017-07-28 Thread David Faure 
dfaure added a comment.


  Difficult to test in kio itself, but for sure testable in the autotest for 
kio_desktop (plasma-workspace/kioslave/desktop/tests)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6906

To: albertvaka, #frameworks, elvisangelaccio
Cc: aacid, dfaure

D6906: Create a "." entry even on empty dirs

2017-07-28 Thread David Faure 
dfaure added a comment.


  This commit breaks plasmashell startup for me, with a non-empty desktop:/
  
  2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister 
KCoreDirListerCache::slotEntries: KCoreDirListerCache(0x7f6a2002c980) 
KIO::ListJob(0x26a9ae0) new entries for  QUrl("desktop:/")
  2017-07-28T10:51:54 plasmashell(5605)/default 
KCoreDirListerCache::slotEntries: ".directory"
  2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister 
KCoreDirListerCache::slotEntries: Adding item:  QUrl("desktop:/.directory")
  2017-07-28T10:51:54 plasmashell(5605)/default 
KCoreDirListerCache::slotEntries: ".."
  2017-07-28T10:51:54 plasmashell(5605)/default 
KCoreDirListerCache::slotEntries: "."
  2017-07-28T10:51:54 plasmashell(5605)/default 
KCoreDirListerCache::slotEntries: "Home.desktop"
  2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister 
KCoreDirListerCache::slotEntries: Adding item:  QUrl("desktop:/Home.desktop")
  2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister 
KCoreDirLister::Private::addNewItem: in QUrl("desktop:/") item: 
QUrl("desktop:/Home.desktop")
  2017-07-28T10:51:54 plasmashell(5605)/default 
KCoreDirListerCache::slotEntries: "trash.desktop"
  2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister 
KCoreDirListerCache::slotEntries: Adding item:  QUrl("desktop:/trash.desktop")
  2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister 
KCoreDirLister::Private::addNewItem: in QUrl("desktop:/") item: 
QUrl("desktop:/trash.desktop")
  2017-07-28T10:51:54 plasmashell(5605)/default 
KCoreDirListerCache::slotEntries: done
  2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister 
KCoreDirListerCache::slotEntries: KCoreDirListerCache(0x7f6a2002c980) 
KIO::ListJob(0x26a9ae0) new entries for  QUrl("desktop:/")
  2017-07-28T10:51:54 plasmashell(5605)/default unknown: ASSERT: 
"dir->rootItem.isNull()" in file 
/d/kde/src/5/frameworks/kio/src/core/kcoredirlister.cpp, line 1202
  
  At first sight it looks like "." is emitted multiple times.
  
  Please revert and fix it better ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6906

To: albertvaka, #frameworks, elvisangelaccio
Cc: dfaure

D6727: Destroy all kwayland objects created by registry when it is destroyed

2017-07-28 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:b669d4148a39: Destroy all kwayland objects created by 
registry when it is destroyed (authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6727?vs=17272=17312

REVISION DETAIL
  https://phabricator.kde.org/D6727

AFFECTED FILES
  autotests/client/test_wayland_registry.cpp
  src/client/blur.h
  src/client/contrast.h
  src/client/datadevice.h
  src/client/datadevicemanager.h
  src/client/dataoffer.h
  src/client/datasource.h
  src/client/dpms.h
  src/client/event_queue.h
  src/client/fakeinput.h
  src/client/idle.h
  src/client/output.cpp
  src/client/output.h
  src/client/outputconfiguration.h
  src/client/outputdevice.cpp
  src/client/outputdevice.h
  src/client/outputmanagement.h
  src/client/plasmashell.h
  src/client/plasmawindowmanagement.h
  src/client/pointerconstraints.h
  src/client/pointergestures.h
  src/client/registry.cpp
  src/client/registry.h
  src/client/relativepointer.h
  src/client/seat.h
  src/client/server_decoration.h
  src/client/shadow.h
  src/client/shm_pool.h
  src/client/slide.h
  src/client/surface.h
  src/client/textinput.h
  src/client/xdgshell.h

To: davidedmundson, graesslin
Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, 
hein, lukas

D6946: Emit connectionDied if the QPA is destroyed

2017-07-28 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:7dd186258620: Emit connectionDied if the QPA is destroyed 
(authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6946?vs=17273=17311

REVISION DETAIL
  https://phabricator.kde.org/D6946

AFFECTED FILES
  src/client/connection_thread.cpp

To: davidedmundson, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas