[sysadmin/ci-tooling] system-images/neon: Kirigami has a silent dependency on the dev-tools for QtDeclarative.

2017-08-05 Thread Ben Cooksley
Git commit b0bb726e8020f52140520d6d77a4da291daed157 by Ben Cooksley.
Committed on 06/08/2017 at 05:52.
Pushed by bcooksley into branch 'master'.

Kirigami has a silent dependency on the dev-tools for QtDeclarative.
Add it to our system image for Frameworks builds.
CCMAIL: kde-frameworks-devel@kde.org
CCMAIL: plasma-de...@kde.org

M  +1-0system-images/neon/Dockerfile

https://commits.kde.org/sysadmin/ci-tooling/b0bb726e8020f52140520d6d77a4da291daed157

diff --git a/system-images/neon/Dockerfile b/system-images/neon/Dockerfile
index a69a14b..d5b0b8d 100644
--- a/system-images/neon/Dockerfile
+++ b/system-images/neon/Dockerfile
@@ -23,6 +23,7 @@ RUN apt-get update &&  DEBIAN_FRONTEND=noninteractive apt-get 
-y --force-yes ins
 qtbase5-private-dev \
 qtconnectivity5-dev \
 qtdeclarative5-dev \
+qtdeclarative5-dev-tools \
 qtmultimedia5-dev \
 qtpositioning5-dev \
 qtscript5-dev \


KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 36 - Still Unstable!

2017-08-05 Thread no-reply
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/36/
 Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
 Date of build:
Sun, 06 Aug 2017 05:48:51 +
 Build duration:
1 min 3 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

build.log
Description: Binary data


KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 45 - Still Unstable!

2017-08-05 Thread no-reply
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/45/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
 Date of build:
Sun, 06 Aug 2017 02:44:58 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.bug205447

build.log
Description: Binary data


KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 16 - Fixed!

2017-08-05 Thread no-reply
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/16/
 Project:
Frameworks baloo kf5-qt5 XenialQt5.7
 Date of build:
Sun, 06 Aug 2017 02:43:33 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(12/12)77%
(111/144)77%
(111/144)73%
(5049/6932)50%
(2620/5194)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(42/42)89%
(16/18)autotests.integration100%
(3/3)100%
(3/3)95%
(242/255)64%
(140/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(40/40)57%
(25/44)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(736/736)53%
(390/740)autotests.unit.file100%
(11/11)100%
(11/11)98%
(791/809)51%
(441/864)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(315/326)52%
(156/302)src.codecs100%
(5/5)100%
(5/5)87%
(120/138)76%
(32/42)src.engine97%
(38/39)97%
(38/39)79%
(1607/2038)58%
(796/1379)src.file39%
(17/44)39%
(17/44)45%
(685/1506)39%
(378/980)src.file.extractor100%
(2/2)100%
(2/2)69%
(20/29)58%
(7/12)src.file.extractor.autotests100%
(1/1)100%
(1/1)100%
(22/22)61%
(11/18)src.lib55%
(6/11)55%
(6/11)43%
(429/991)40%
(228/575)

build.log
Description: Binary data


KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 33 - Still Unstable!

2017-08-05 Thread no-reply
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/33/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
 Date of build:
Sun, 06 Aug 2017 02:44:21 +
 Build duration:
2 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

build.log
Description: Binary data


KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 35 - Still Unstable!

2017-08-05 Thread no-reply
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/35/
 Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
 Date of build:
Sun, 06 Aug 2017 02:44:22 +
 Build duration:
1 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

build.log
Description: Binary data


D7130: KMoreTools: Update and fix desktopfiles

2017-08-05 Thread gregormi
gregormi added a comment.


  In https://phabricator.kde.org/D7130#132762, @elvisangelaccio wrote:
  
  > In https://phabricator.kde.org/D7130#132742, @gregormi wrote:
  >
  > > In https://phabricator.kde.org/D7130#132640, @elvisangelaccio wrote:
  > >
  > > > It doesn't seem to fix the bug here, it's still saying that filelight 
and partitionmanager are not installed (but they are).
  > >
  > >
  > > Can you tell me what distro you are using and maybe the full path to the 
installed desktop files of filelight and partitionmanager
  >
  >
  >
  >
  >   /usr/share/applications/org.kde.filelight.desktop
  >   /usr/share/applications/org.kde.partitionmanager.desktop
  >
  >
  > (on archlinux)
  
  
  Hmm, this looks fine. Actually, KMoreTools uses KService to find out if an 
application is installed by passing the desktop filename (without extension), 
i.e. "org.kde.filelight" or "org.kde.partitionmanager" 
(KService::serviceByDesktopName(desktopEntryName)). I did not fully understand 
how it works internally. It uses some caching mechanism. Could you run 
kbuildsycoca5 or relogin and try again? I have no idea how I should reproduce 
it here on my machine because it works here. When dealing with KService I got 
the impression that it is hard to find out why a particular service (desktop 
file) is _not_ found.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D7130

To: gregormi, ltoscano, elvisangelaccio
Cc: ltoscano, #frameworks


D7156: Qt5DBus is only required with HAVE_XSCREENSAVER

2017-08-05 Thread Andreas Sturmlechner
asturmlechner added a reviewer: Frameworks.

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D7156

To: asturmlechner, #frameworks
Cc: #frameworks


D7156: Qt5DBus is only required with HAVE_XSCREENSAVER

2017-08-05 Thread Andreas Sturmlechner
asturmlechner created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

TEST PLAN
  Continues to build fine.

REPOSITORY
  R274 KIdleTime

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7156

AFFECTED FILES
  CMakeLists.txt

To: asturmlechner
Cc: #frameworks


KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 34 - Still Unstable!

2017-08-05 Thread no-reply
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/34/
 Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
 Date of build:
Sat, 05 Aug 2017 19:17:48 +
 Build duration:
1 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

build.log
Description: Binary data


KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 32 - Still Unstable!

2017-08-05 Thread no-reply
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/32/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
 Date of build:
Sat, 05 Aug 2017 19:17:48 +
 Build duration:
48 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

build.log
Description: Binary data


D7154: Only require Qt5X11Extras when we actually need it

2017-08-05 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R274 KIdleTime

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7154

To: vkrause, #frameworks, apol


D7154: Only require Qt5X11Extras when we actually need it

2017-08-05 Thread Volker Krause
vkrause created this revision.
Restricted Application added a project: Frameworks.

REPOSITORY
  R274 KIdleTime

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7154

AFFECTED FILES
  CMakeLists.txt

To: vkrause, #frameworks


D7130: KMoreTools: Update and fix desktopfiles

2017-08-05 Thread Elvis Angelaccio
elvisangelaccio added a comment.


  In https://phabricator.kde.org/D7130#132742, @gregormi wrote:
  
  > In https://phabricator.kde.org/D7130#132640, @elvisangelaccio wrote:
  >
  > > It doesn't seem to fix the bug here, it's still saying that filelight and 
partitionmanager are not installed (but they are).
  >
  >
  > Can you tell me what distro you are using and maybe the full path to the 
installed desktop files of filelight and partitionmanager
  
  
  
  
/usr/share/applications/org.kde.filelight.desktop
/usr/share/applications/org.kde.partitionmanager.desktop
  
  (on archlinux)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D7130

To: gregormi, ltoscano, elvisangelaccio
Cc: ltoscano, #frameworks


D7153: Drop broken mid-button click handling

2017-08-05 Thread Elvis Angelaccio
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  It's been broken for years and no one complained, which probably means
  no one was using the feature (middle-click to trigger toolbar actions).
  
  While it would be trivial to fix, we probably shouldn't.
  It would just make kxmlgui toolbars inconsistent with non-kxmlgui toolbars.
  
  BUG: 383162

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7153

AFFECTED FILES
  src/ktoolbar.cpp

To: elvisangelaccio, #frameworks


D7130: KMoreTools: Update and fix desktopfiles

2017-08-05 Thread gregormi
gregormi added a comment.


  In https://phabricator.kde.org/D7130#132640, @elvisangelaccio wrote:
  
  > It doesn't seem to fix the bug here, it's still saying that filelight and 
partitionmanager are not installed (but they are).
  
  
  Can you tell me what distro you are using and maybe the full path to the 
installed desktop files of filelight and partitionmanager

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D7130

To: gregormi, ltoscano, elvisangelaccio
Cc: ltoscano, #frameworks


D6992: Fix build on Linux without X11

2017-08-05 Thread Volker Krause
vkrause added a comment.


  Ok, now I've hit the same problem in kinit, but unlike the comment in the 
code here suggests it's not actually identical... So, how should this work in 
an ideal scenario?
  
  kinit/src/wrapper.cpp would use an empty display string if neither X11 nor 
XCB are found at compile time. Is that good enough, or do we want something 
like use DISPLAY if present, otherwise use WAYLAND_DISPLAY if present, 
otherwise error out on non-macos/non-windows? I can't seem to find any 
reference about MAC_DISPLAY or WIN_DISPLAY, so no idea what to do about those 
cases.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D6992

To: vkrause, #frameworks, bshah, graesslin
Cc: graesslin, bshah


D7130: KMoreTools: Update and fix desktopfiles

2017-08-05 Thread Elvis Angelaccio
elvisangelaccio added a comment.


  It doesn't seem to fix the bug here, it's still saying that filelight and 
partitionmanager are not installed (but they are).

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D7130

To: gregormi, ltoscano, elvisangelaccio
Cc: ltoscano, #frameworks