D7423: Populate UDS_CREATION_TIME on Linux if QT version and Linux kernel support it (no effect if they don't)

2017-08-19 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if QT version and Linux kernel support it (no effect if they don't)

2017-08-19 Thread Nathaniel Graham 
ngraham created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  This speculative commit will populate UDS_CREATION_TIME if the Linux Kernel 
and QT version support it, following changes to do the same in FreeBSD and 
OpenBSD earlier this year .
  
  The minimum Linux kernel version is 4.11, which includes the statx() system 
call  that reports file creation time.
  
  Support has already been added to QFile 
, 
but this hasn't made it into any released QT versions yet.
  
  This commit should populate UDS_CREATION_TIME if the above two conditions are 
met, which will have the effect of causing DOlphin to display file creation 
time (support for this was already added earlier 
)

TEST PLAN
  Tested these changes with Dolphin in KDE Neon, and there were no regressions. 
File creation date was not displayed (as expected, due to lack of a released QT 
version that supports this), but nothing broke.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

AFFECTED FILES
  src/ioslaves/file/file.cpp

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: #frameworks

Re: KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 87 - Unstable!

2017-08-19 Thread David Faure 
On samedi 19 août 2017 11:09:05 CEST no-re...@kde.org wrote:
> Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstest
> Failed: TestSuite.kiowidgets-kurifiltertest

I'll work on this, by porting away from KServiceTypeTrader.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D7380: KCD: use modern logging classes throughout

2017-08-19 Thread David Faure 
dfaure added a comment.


  Information printed by command-line programs can be done with qInfo(), which 
is enabled by default, while qDebug() should be disabled by defualt.

REPOSITORY
  R349 KCompactDisc Library

REVISION DETAIL
  https://phabricator.kde.org/D7380

To: rjvbb, #frameworks, davidedmundson, ltoscano
Cc: dfaure, ltoscano, davidedmundson

D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab.

2017-08-19 Thread Nathaniel Graham 
ngraham added a comment.


  FYI this has caused a conflict in Kate: 
https://bugs.kde.org/show_bug.cgi?id=383721
  
  Also, I have created a patch to add the new shortcuts to Konsole, which does 
not use `KStandardShortcut`s: https://phabricator.kde.org/D7354

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D6553

To: dfaure, mdawson
Cc: ngraham, cfeck, aacid, ltoscano, apol, #frameworks

D6972: Add CC BY-SA 4.0 International and set it as default

2017-08-19 Thread Luigi Toscano 
This revision was automatically updated to reflect the committed changes.
Closed by commit R238:8c32e153fae8: Add CC BY-SA 4.0 International and set it 
as default (authored by ltoscano).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6972?vs=17466=18401

REVISION DETAIL
  https://phabricator.kde.org/D6972

AFFECTED FILES
  common/en/ccbysa4-license.html
  src/customization/af/lang.entities
  src/customization/bg/lang.entities
  src/customization/ca/lang.entities
  src/customization/cs/lang.entities
  src/customization/da/lang.entities
  src/customization/de/lang.entities
  src/customization/el/lang.entities
  src/customization/en-GB/lang.entities
  src/customization/en/catalog.xml
  src/customization/en/entities/ccbysa4-notice.docbook
  src/customization/en/entities/underCCBYSA4.docbook
  src/customization/en/lang.entities
  src/customization/entities/general.entities
  src/customization/eo/lang.entities
  src/customization/es/lang.entities
  src/customization/et/lang.entities
  src/customization/fi/lang.entities
  src/customization/fo/lang.entities
  src/customization/fr/lang.entities
  src/customization/gl/lang.entities
  src/customization/he/lang.entities
  src/customization/hu/lang.entities
  src/customization/id/lang.entities
  src/customization/it/lang.entities
  src/customization/ja/lang.entities
  src/customization/ko/lang.entities
  src/customization/lt/lang.entities
  src/customization/nds/lang.entities
  src/customization/nl/lang.entities
  src/customization/nn/lang.entities
  src/customization/no/lang.entities
  src/customization/pl/lang.entities
  src/customization/pt-BR/lang.entities
  src/customization/pt/lang.entities
  src/customization/ro/lang.entities
  src/customization/ru/lang.entities
  src/customization/sk/lang.entities
  src/customization/sl/lang.entities
  src/customization/sq/lang.entities
  src/customization/sr/lang.entities
  src/customization/sr@ijekavian/lang.entities
  src/customization/sr@ijekavianlatin/lang.entities
  src/customization/sr@latin/lang.entities
  src/customization/sv/lang.entities
  src/customization/th/lang.entities
  src/customization/tr/lang.entities
  src/customization/uk/lang.entities
  src/customization/wa/lang.entities
  src/customization/xh/lang.entities
  src/customization/xx/lang.entities
  src/customization/zh-CN/lang.entities
  src/customization/zh-TW/lang.entities
  src/template.docbook

To: ltoscano, jriddell, lueck, yurchor
Cc: jriddell, lueck, #frameworks, #documentation, skadinna

D7415: kconfig: kcfg.xsd do not require a kcfgfile

2017-08-19 Thread Allen Winter 
winterz reclaimed this revision.
winterz added a comment.


  un-abandon.  I retested and it does work as intended

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D7415

To: winterz
Cc: #frameworks

D7415: kconfig: kcfg.xsd do not require a kcfgfile

2017-08-19 Thread Allen Winter 
winterz abandoned this revision.
winterz added a comment.


  not good. ignore.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D7415

To: winterz
Cc: #frameworks

D7415: kconfig: kcfg.xsd do not require a kcfgfile

2017-08-19 Thread Allen Winter 
winterz created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  I'm seeing quite a few kconfigxt files that don't set the kcfgfile element.
  This patch changes the xsd so such files will validate.
  
  now you can have 0 or 1 setting of kcfgfile in a .kcfg file and it will still 
validate

TEST PLAN
  running xmllint against a bunch of .kcfgfiles, some with a kcfgfile element 
and some without

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D7415

AFFECTED FILES
  src/kconfig_compiler/kcfg.xsd

To: winterz
Cc: #frameworks

D4861: [ConfigCategory] Deduce name and icon from pluginName

2017-08-19 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4861

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D5799: Rebase Less syntax highlighting on SCSS one

2017-08-19 Thread Grzegorz Szymaszek 
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:ca846fbda318: Rebased Less syntax highlighting on SCSS 
one (authored by gszymaszek).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5799?vs=18296=18391

REVISION DETAIL
  https://phabricator.kde.org/D5799

AFFECTED FILES
  autotests/input/highlight.less
  data/syntax/less.xml

To: gszymaszek, #framework_syntax_hightlighting, jtamate, dhaumann
Cc: jtamate, dhaumann, #frameworks, cullmann, vkrause

KDE CI: Frameworks syntax-highlighting kf5-qt5 XenialQt5.7 - Build # 79 - Unstable!

2017-08-19 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/79/
 Project:
Frameworks syntax-highlighting kf5-qt5 XenialQt5.7
 Date of build:
Sat, 19 Aug 2017 14:03:20 +
 Build duration:
3 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.folding_testFailed: TestSuite.htmlhighlighter_testFailed: TestSuite.testhighlighter_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)92%
(36/39)92%
(36/39)85%
(2111/2490)70%
(1587/2263)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)97%
(501/515)65%
(347/534)src.indexer100%
(1/1)100%
(1/1)72%
(60/83)77%
(75/98)src.lib90%
(27/30)90%
(27/30)82%
(1550/1892)71%
(1165/1631)

build.log
Description: Binary data

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7 - Build # 77 - Unstable!

2017-08-19 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/77/
 Project:
Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7
 Date of build:
Sat, 19 Aug 2017 14:03:20 +
 Build duration:
1 min 47 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 8 test(s)Failed: TestSuite.folding_testFailed: TestSuite.htmlhighlighter_testFailed: TestSuite.testhighlighter_test

build.log
Description: Binary data

Re: KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 2 - Failure!

2017-08-19 Thread Ben Cooksley 
This failure was caused by processes spawned by tests (namely kioslave.exe)
hanging around.
I've killed them now which should allow the next run to succeed.

Cheers,
Ben

On Sat, Aug 19, 2017 at 10:12 PM,  wrote:

> *BUILD FAILURE*
> Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%
> 20WindowsMSVCQt5.9/2/
> Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.9
> Date of build: Sat, 19 Aug 2017 08:51:47 +
> Build duration: 1 hr 20 min and counting
> * CONSOLE OUTPUT *
> Started by an SCM change
> [Pipeline] node
> Still waiting to schedule task
> Waiting for next available executor on WindowsMSVCQt5.9
> Running on Windows Builder 2 in C:\JenkinsWS\workspace\Frameworks kio
> kf5-qt5 WindowsMSVCQt5.9
> [Pipeline] {
> [Pipeline] timestamps
> [Pipeline] {
> [Pipeline] catchError
> [Pipeline] {
> [Pipeline] stage
> [Pipeline] { (Checkout Sources)
> [Pipeline] deleteDir
> [Pipeline] }
> [Pipeline] // stage
> [Pipeline] }
> java.nio.file.FileSystemException: C:\JenkinsWS\workspace\Frameworks kio
> kf5-qt5 WindowsMSVCQt5.9\build\autotests: The process cannot access the
> file because it is being used by another process.
> at sun.nio.fs.WindowsException.translateToIOException(Unknown Source)
> at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)
> at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)
> at sun.nio.fs.WindowsFileSystemProvider.implDelete(Unknown Source)
> at sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(Unknown Source)
> at java.nio.file.Files.deleteIfExists(Unknown Source)
> at hudson.Util.tryOnceDeleteFile(Util.java:290)
> at hudson.Util.deleteFile(Util.java:245)
> at hudson.FilePath.deleteRecursive(FilePath.java:1211)
> at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220)
> at hudson.FilePath.deleteRecursive(FilePath.java:1202)
> at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220)
> at hudson.FilePath.deleteRecursive(FilePath.java:1202)
> at hudson.FilePath.access$1000(FilePath.java:197)
> at hudson.FilePath$14.invoke(FilePath.java:1181)
> at hudson.FilePath$14.invoke(FilePath.java:1178)
> at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2750)
> at hudson.remoting.UserRequest.perform(UserRequest.java:181)
> at hudson.remoting.UserRequest.perform(UserRequest.java:52)
> at hudson.remoting.Request$2.run(Request.java:336)
> at hudson.remoting.InterceptingExecutorService$1.call(
> InterceptingExecutorService.java:68)
> at java.util.concurrent.FutureTask.run(Unknown Source)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
> at hudson.remoting.Engine$1$1.run(Engine.java:98)
> at java.lang.Thread.run(Unknown Source)
> Caused: java.io.IOException: Unable to delete 
> 'C:\JenkinsWS\workspace\Frameworks
> kio kf5-qt5 WindowsMSVCQt5.9\build\autotests'. Tried 3 times (of a
> maximum of 3) waiting 0.1 sec between attempts.
> at hudson.Util.deleteFile(Util.java:250)
> at hudson.FilePath.deleteRecursive(FilePath.java:1211)
> at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220)
> at hudson.FilePath.deleteRecursive(FilePath.java:1202)
> at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220)
> at hudson.FilePath.deleteRecursive(FilePath.java:1202)
> at hudson.FilePath.access$1000(FilePath.java:197)
> at hudson.FilePath$14.invoke(FilePath.java:1181)
> at hudson.FilePath$14.invoke(FilePath.java:1178)
> at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2750)
> at hudson.remoting.UserRequest.perform(UserRequest.java:181)
> at hudson.remoting.UserRequest.perform(UserRequest.java:52)
> at hudson.remoting.Request$2.run(Request.java:336)
> at hudson.remoting.InterceptingExecutorService$1.call(
> InterceptingExecutorService.java:68)
> at java.util.concurrent.FutureTask.run(Unknown Source)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
> at hudson.remoting.Engine$1$1.run(Engine.java:98)
> at java.lang.Thread.run(Unknown Source)
> at ..remote call to JNLP4-connect connection from
> katze.kde.org/5.9.99.173:49688(Native Method)
> at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1554)
> at hudson.remoting.UserResponse.retrieve(UserRequest.java:281)
> at hudson.remoting.Channel.call(Channel.java:839)
> at hudson.FilePath.act(FilePath.java:987)
> Caused: java.io.IOException: remote file operation failed:
> C:\JenkinsWS\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9 at
> hudson.remoting.Channel@e934d7:JNLP4-connect connection from
> katze.kde.org/5.9.99.173:49688
> at hudson.FilePath.act(FilePath.java:994)
> at hudson.FilePath.act(FilePath.java:976)
> at hudson.FilePath.deleteRecursive(FilePath.java:1178)
> at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$
> Execution.run(DeleteDirStep.java:77)
> at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$
> Execution.run(DeleteDirStep.java:69)
> at

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 2 - Failure!

2017-08-19 Thread no-reply 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/2/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Sat, 19 Aug 2017 08:51:47 +
 Build duration:
1 hr 20 min and counting
   CONSOLE OUTPUT
  Started by an SCM change[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on WindowsMSVCQt5.9Running on Windows Builder 2 in C:\JenkinsWS\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] }[Pipeline] // stage[Pipeline] }java.nio.file.FileSystemException: C:\JenkinsWS\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\build\autotests: The process cannot access the file because it is being used by another process.	at sun.nio.fs.WindowsException.translateToIOException(Unknown Source)	at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)	at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)	at sun.nio.fs.WindowsFileSystemProvider.implDelete(Unknown Source)	at sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(Unknown Source)	at java.nio.file.Files.deleteIfExists(Unknown Source)	at hudson.Util.tryOnceDeleteFile(Util.java:290)	at hudson.Util.deleteFile(Util.java:245)	at hudson.FilePath.deleteRecursive(FilePath.java:1211)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220)	at hudson.FilePath.deleteRecursive(FilePath.java:1202)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220)	at hudson.FilePath.deleteRecursive(FilePath.java:1202)	at hudson.FilePath.access$1000(FilePath.java:197)	at hudson.FilePath$14.invoke(FilePath.java:1181)	at hudson.FilePath$14.invoke(FilePath.java:1178)	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2750)	at hudson.remoting.UserRequest.perform(UserRequest.java:181)	at hudson.remoting.UserRequest.perform(UserRequest.java:52)	at hudson.remoting.Request$2.run(Request.java:336)	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)	at java.util.concurrent.FutureTask.run(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)	at hudson.remoting.Engine$1$1.run(Engine.java:98)	at java.lang.Thread.run(Unknown Source)Caused: java.io.IOException: Unable to delete 'C:\JenkinsWS\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\build\autotests'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.	at hudson.Util.deleteFile(Util.java:250)	at hudson.FilePath.deleteRecursive(FilePath.java:1211)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220)	at hudson.FilePath.deleteRecursive(FilePath.java:1202)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220)	at hudson.FilePath.deleteRecursive(FilePath.java:1202)	at hudson.FilePath.access$1000(FilePath.java:197)	at hudson.FilePath$14.invoke(FilePath.java:1181)	at hudson.FilePath$14.invoke(FilePath.java:1178)	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2750)	at hudson.remoting.UserRequest.perform(UserRequest.java:181)	at hudson.remoting.UserRequest.perform(UserRequest.java:52)	at hudson.remoting.Request$2.run(Request.java:336)	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)	at java.util.concurrent.FutureTask.run(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)	at hudson.remoting.Engine$1$1.run(Engine.java:98)	at java.lang.Thread.run(Unknown Source)	at ..remote call to JNLP4-connect connection from katze.kde.org/5.9.99.173:49688(Native Method)	at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1554)	at hudson.remoting.UserResponse.retrieve(UserRequest.java:281)	at hudson.remoting.Channel.call(Channel.java:839)	at hudson.FilePath.act(FilePath.java:987)Caused: java.io.IOException: remote file operation failed: C:\JenkinsWS\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9 at hudson.remoting.Channel@e934d7:JNLP4-connect connection from katze.kde.org/5.9.99.173:49688	at hudson.FilePath.act(FilePath.java:994)	at hudson.FilePath.act(FilePath.java:976)	at hudson.FilePath.deleteRecursive(FilePath.java:1178)	at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:77)	at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:69)	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1$1.call(SynchronousNonBlockingStepExecution.java:49)	at hudson.security.ACL.impersonate(ACL.java:260)	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1.run(SynchronousNonBlockingStepExecution.java:46)	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)	at

D7402: Use QUrls from match to create mimeData in base implementation

2017-08-19 Thread Kai Uwe Broulik 
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> abstractrunner.cpp:204
>  {
> -Q_UNUSED(match)
> -return nullptr;
> +if (match.urls().isEmpty()) {
> +return nullptr;

Weird indentation

REPOSITORY
  R308 KRunner

BRANCH
  dbusrunner

REVISION DETAIL
  https://phabricator.kde.org/D7402

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7407: audiocd-kio : modernise debugging

2017-08-19 Thread René J . V . Bertin 
rjvbb created this revision.

REVISION SUMMARY
  Modernises the use of debugging classes in audiocd-kio (cf. 
https://phabricator.kde.org/D7380).
  
  I've named the category the way most kioslaves seem to name their categories, 
using the `kf5` toplevel domain rather than `org.kde` mostly because it's 
shorter and leaves no doubt that messages come from the KF5 version of the 
slave.

TEST PLAN
  Works as intended.
  
  I haven't checked if this removes the last dependency on kdelibs4support, 
does it?

REPOSITORY
  R342 KIO AudioCD

REVISION DETAIL
  https://phabricator.kde.org/D7407

AFFECTED FILES
  CMakeLists.txt
  audiocd.cpp

To: rjvbb, #frameworks

D7328: Don't enter test subdirectories if BUILD_TESTING=OFF

2017-08-19 Thread Andreas Sturmlechner 
asturmlechner closed this revision.
asturmlechner added a comment.


  Merged, closing manually.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7328

To: asturmlechner, #frameworks, dfaure

D6972: Add CC BY-SA 4.0 International and set it as default

2017-08-19 Thread Burkhard Lück 
lueck accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R238 KDocTools

BRANCH
  add-ccbysa4-translatable

REVISION DETAIL
  https://phabricator.kde.org/D6972

To: ltoscano, jriddell, lueck, yurchor
Cc: jriddell, lueck, #frameworks, #documentation, skadinna