D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData
vandenoever added a comment. > "X-KDE-InitialPreference": "5" is a string "X-KDE-InitialPreference": 5 is a number REVISION DETAIL https://phabricator.kde.org/D7533 To: dfaure, apol, davidedmundson, arichardson Cc: vandenoever, elvisangelaccio, bshah, #frameworks
D7487: Make KCMultiDialog scrollable
valeriymalov updated this revision to Diff 18774. valeriymalov edited the summary of this revision. valeriymalov added a comment. Oops, should be fixed now REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7487?vs=18616=18774 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7487 AFFECTED FILES src/kcmultidialog.cpp To: valeriymalov, #frameworks Cc: wbauer, broulik
D7487: Make KCMultiDialog scrollable
wbauer added a comment. The referenced bug number seems to be wrong. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D7487 To: valeriymalov, #frameworks Cc: wbauer, broulik
KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 43 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/43/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 25 Aug 2017 19:33:21 + Build duration: 4 min 21 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittest build.log Description: Binary data
D7236: DesktopFileParser: add fallback lookup in ":/kservicetypes5/*"
dfaure closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D7236 To: dfaure, mart, arichardson, davidedmundson Cc: #frameworks
D7236: DesktopFileParser: add fallback lookup in ":/kservicetypes5/*"
dfaure added a comment. It will be tested at every "make test" in kio and kpackage ;-) REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D7236 To: dfaure, mart, arichardson, davidedmundson Cc: #frameworks
D7236: DesktopFileParser: add fallback lookup in ":/kservicetypes5/*"
arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. Looks good to me. Test would be great but the patch is pretty trivial so not really needed. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D7236 To: dfaure, mart, arichardson, davidedmundson Cc: #frameworks
KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 60 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/60/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Fri, 25 Aug 2017 19:08:51 + Build duration: 1 min 7 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests Cobertura Report Project Coverage Summary Name Cobertura Coverage Report build.log Description: Binary data
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 56 - Still unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/56/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 25 Aug 2017 19:08:51 + Build duration: 34 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests build.log Description: Binary data
D7369: [WIP] Wayland foreign protocol
mart updated this revision to Diff 18767. mart added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - get rid of setTransientFor REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7369?vs=18760=18767 BRANCH mart/xdgforeign REVISION DETAIL https://phabricator.kde.org/D7369 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_xdg_foreign.cpp src/client/CMakeLists.txt src/client/protocols/xdg-foreign-unstable-v1.xml src/client/registry.cpp src/client/registry.h src/client/xdgforeign.cpp src/client/xdgforeign.h src/client/xdgforeign_p.h src/client/xdgforeign_v1.cpp src/client/xdgforeign_v1.h src/server/CMakeLists.txt src/server/display.cpp src/server/display.h src/server/xdgforeign_interface.cpp src/server/xdgforeign_interface.h src/server/xdgforeign_v1_interface.cpp src/server/xdgforeign_v1_interface_p.h tests/CMakeLists.txt tests/xdgforeigntest.cpp To: mart, #plasma, #kwin, davidedmundson Cc: davidedmundson, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7236: DesktopFileParser: add fallback lookup in ":/kservicetypes5/*"
dfaure added a comment. ping? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D7236 To: dfaure, mart, arichardson, davidedmundson Cc: #frameworks
D7236: DesktopFileParser: add fallback lookup in ":/kservicetypes5/*"
dfaure added reviewers: arichardson, davidedmundson. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D7236 To: dfaure, mart, arichardson, davidedmundson Cc: #frameworks
D7369: [WIP] Wayland foreign protocol
mart updated this revision to Diff 18760. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - add a serverside setTransientFor in xdgshell REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7369?vs=18744=18760 BRANCH mart/xdgforeign REVISION DETAIL https://phabricator.kde.org/D7369 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_xdg_foreign.cpp src/client/CMakeLists.txt src/client/protocols/xdg-foreign-unstable-v1.xml src/client/registry.cpp src/client/registry.h src/client/xdgforeign.cpp src/client/xdgforeign.h src/client/xdgforeign_p.h src/client/xdgforeign_v1.cpp src/client/xdgforeign_v1.h src/server/CMakeLists.txt src/server/display.cpp src/server/display.h src/server/xdgforeign_interface.cpp src/server/xdgforeign_interface.h src/server/xdgforeign_v1_interface.cpp src/server/xdgforeign_v1_interface_p.h src/server/xdgshell_interface.cpp src/server/xdgshell_interface.h tests/CMakeLists.txt tests/xdgforeigntest.cpp To: mart, #plasma, #kwin, davidedmundson Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D7479: klauncher: fix appId matching for flatpak apps
dfaure accepted this revision. REPOSITORY R303 KInit BRANCH kdbus-appId REVISION DETAIL https://phabricator.kde.org/D7479 To: elvisangelaccio, dfaure, apol Cc: #frameworks
D7479: klauncher: fix appId matching for flatpak apps
elvisangelaccio updated this revision to Diff 18758. elvisangelaccio added a comment. Use `leftRef()` REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7479?vs=18700=18758 BRANCH kdbus-appId REVISION DETAIL https://phabricator.kde.org/D7479 AFFECTED FILES src/klauncher/klauncher.cpp To: elvisangelaccio, dfaure, apol Cc: #frameworks
D7249: Return high-resolution line edit clear icon
This revision was automatically updated to reflect the committed changes. Closed by commit R252:588cd0075612: Return high-resolution line edit clear icon (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7249?vs=18000=18757#toc REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7249?vs=18000=18757 REVISION DETAIL https://phabricator.kde.org/D7249 AFFECTED FILES src/kstyle/kstyle.cpp To: broulik, kde-frameworks-devel, hpereiradacosta, davidedmundson Cc: davidedmundson, hpereiradacosta, #frameworks
D6047: Support XDG v6
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. First round of review, client api is done. INLINE COMMENTS > registry.h:1275 > + * @param name The name for the removed interface > + * @since 5.25 > + **/ careful here: the since won't match > xdgshell.h:95 > + > +/* > + * Which edge of the anchor should the popup be positioned around In case you wanted to make those comments doxygen comments: you need to use /** instead of /* Applies for all comments in this class. > xdgshell.h:176 > + > +void setup(zxdg_shell_v6 *xdgshellv6); > + lacking documentation including an @since. > xdgshell.h:222 > **/ > XdgShellPopup *createPopup(Surface *surface, Surface *parentSurface, > Seat *seat, quint32 serial, const QPoint , QObject *parent = > nullptr); > If the comment is deprecated, the method should be deprecated as well. But I disagree on the point of deprecation. It is not deprecated if it's used with xdgShellv5. That should probably just be documented properly. > xdgshell.h:226 > + * Creates a new XdgShellPopup for the given @p surface on top of @p > parentSurface with the given @p positioner. > + **/ > +XdgShellPopup *createPopup(Surface *surface, XdgShellSurface > *parentSurface, const XdgPositioner , QObject *parent = nullptr); @since missing > xdgshell.h:229 > + > +/** > + * Creates a new XdgShellPopup for the given @p surface on top of @p > parentSurface with the given @p positioner. looks like wrong indentation. > xdgshell.h:231 > + * Creates a new XdgShellPopup for the given @p surface on top of @p > parentSurface with the given @p positioner. > + **/ > +XdgShellPopup *createPopup(Surface *surface, XdgShellPopup > *parentSurface, const XdgPositioner , QObject *parent = nullptr); @since missing > xdgshell.h:302 > + > +void setup(zxdg_surface_v6 *xdgsurfacev6, zxdg_toplevel_v6 *toplevel); > + missing documentation. > xdgshell.h:427 > > +/* > + * Set this surface to have a given maximum size same as with the other class: that's not a documentation comment. > xdgshell.h:500 > + * method. > + **/ > +void setup(zxdg_surface_v6 *xdgsurfacev6, zxdg_popup_v6 *xdgpopup6); @since missing > xdgshell.h:562 > +/** > + * > + **/ documentation missing > xdgshell_p.h:67 > +Q_UNUSED(parent) > +qWarning() << __func__ << " is not supported in this version"; > +return nullptr; Please no qWarning. Either qCWarning or not at all. > xdgshell_v6.cpp:28 > + > +#include > + I don't see any debug messages in this file REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma, graesslin Cc: graesslin, mart, plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, lukas
D7520: Fix icon of KStandardAction::MoveToTrash
elvisangelaccio added a comment. In https://phabricator.kde.org/D7520#139761, @broulik wrote: > I do have two somewhat different looking icons in the context menu. dolphin git master? Make sure you have https://phabricator.kde.org/D6778, which is what caused the regression > `user-trash` is for a place, not an action, so this might lead to a colorized icon showing up in the menu (when using larger icon sizes and/or high dpi) Right. Is there some other icon we could use? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D7520 To: elvisangelaccio, #frameworks Cc: broulik
D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData
elvisangelaccio added inline comments. INLINE COMMENTS > kurifilter.cpp:682-684 > // NOTE: Plugin priority is determined by the InitialPreference entry in > // the .desktop files, so the trader result is already sorted and should > // not be manually sorted. This comment looks outdated now, should probably be removed? REVISION DETAIL https://phabricator.kde.org/D7533 To: dfaure, apol, davidedmundson, arichardson Cc: elvisangelaccio, bshah, #frameworks
D7531: Update SurfaceInterface outputs when an output global gets destroyed
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH mart/xdgforeign REVISION DETAIL https://phabricator.kde.org/D7531 To: davidedmundson, #plasma, graesslin Cc: graesslin, anthonyfieroni, plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D7369: [WIP] Wayland foreign protocol
mart updated this revision to Diff 18744. mart added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - add a manual test for foreign - remove Unstable from public symbols REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7369?vs=18596=18744 BRANCH mart/xdgforeign REVISION DETAIL https://phabricator.kde.org/D7369 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_xdg_foreign.cpp src/client/CMakeLists.txt src/client/protocols/xdg-foreign-unstable-v1.xml src/client/registry.cpp src/client/registry.h src/client/xdgforeign.cpp src/client/xdgforeign.h src/client/xdgforeign_p.h src/client/xdgforeign_v1.cpp src/client/xdgforeign_v1.h src/server/CMakeLists.txt src/server/display.cpp src/server/display.h src/server/xdgforeign_interface.cpp src/server/xdgforeign_interface.h src/server/xdgforeign_v1_interface.cpp src/server/xdgforeign_v1_interface_p.h tests/CMakeLists.txt tests/xdgforeigntest.cpp To: mart, #plasma, #kwin, davidedmundson Cc: davidedmundson, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7531: Update SurfaceInterface outputs when an output global gets destroyed
davidedmundson updated this revision to Diff 18741. davidedmundson added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. bleh REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7531?vs=18740=18741 BRANCH mart/xdgforeign REVISION DETAIL https://phabricator.kde.org/D7531 AFFECTED FILES autotests/client/test_wayland_surface.cpp src/server/global.cpp src/server/global.h src/server/surface_interface.cpp src/server/surface_interface_p.h To: davidedmundson, #plasma Cc: graesslin, anthonyfieroni, plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D7531: Update SurfaceInterface outputs when an output global gets destroyed
davidedmundson updated this revision to Diff 18740. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. Update connections better REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7531?vs=18725=18740 BRANCH mart/xdgforeign REVISION DETAIL https://phabricator.kde.org/D7531 AFFECTED FILES autotests/client/test_wayland_surface.cpp src/server/global.cpp src/server/global.h src/server/surface_interface.cpp src/server/surface_interface_p.h To: davidedmundson, #plasma Cc: graesslin, anthonyfieroni, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7532: Guard failed testItem creation
This revision was automatically updated to reflect the committed changes. Closed by commit R242:a968892ba9d5: Guard failed testItem creation (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7532?vs=18726=18735 REVISION DETAIL https://phabricator.kde.org/D7532 AFFECTED FILES src/plasmaquick/appletquickitem.cpp To: davidedmundson, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6964: Force Plasma style for QQC2 in applets
This revision was automatically updated to reflect the committed changes. Closed by commit R242:ac2434087725: Force Plasma style for QQC2 in applets (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6964?vs=17706=18737 REVISION DETAIL https://phabricator.kde.org/D6964 AFFECTED FILES src/plasmaquick/appletquickitem.cpp src/plasmaquick/packageurlinterceptor.cpp src/plasmaquick/packageurlinterceptor.h src/plasmaquick/view.cpp To: mart, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6964: Force Plasma style for QQC2 in applets
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D6964 REVISION DETAIL https://phabricator.kde.org/D6964 To: mart, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6693: Install the PlasmaComponents.3/private folder
This revision was automatically updated to reflect the committed changes. Closed by commit R242:a25b628e25aa: Install the PlasmaComponents.3/private folder (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6693?vs=16682=18734 REVISION DETAIL https://phabricator.kde.org/D6693 AFFECTED FILES src/declarativeimports/CMakeLists.txt To: davidedmundson, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6693: Install the PlasmaComponents.3/private folder
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6693 To: davidedmundson, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7510: [Service] Use KConfig::SimpleConfig
This revision was automatically updated to reflect the committed changes. Closed by commit R242:5137a988b1f4: [Service] Use KConfig::SimpleConfig (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7510?vs=18673=18733#toc REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7510?vs=18673=18733 REVISION DETAIL https://phabricator.kde.org/D7510 AFFECTED FILES src/plasma/service.cpp To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData
bshah added a comment. > One thing I don't understand is the need for toString().toInt(), > or in other words, why my json file with a numeric value gets turned > into a string value when using qtplugininfo to inspect the plugin: Maybe you need to add following in the `src/widgets/kurifilterplugin.desktop` [PropertyDef::X-KDE-InitialPreference] Type=int REVISION DETAIL https://phabricator.kde.org/D7533 To: dfaure, apol, davidedmundson, arichardson Cc: bshah, #frameworks
D7516: Drop remains of "locolor" themes
This revision was automatically updated to reflect the committed changes. Closed by commit R242:b4c1c9cdfa01: Drop remains of "locolor" themes (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7516?vs=18681=18732 REVISION DETAIL https://phabricator.kde.org/D7516 AFFECTED FILES src/plasma/packagestructure/plasmathemepackage.cpp src/plasma/private/theme_p.cpp src/plasma/private/theme_p.h To: broulik, #plasma, mart Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D7534: [KUrlNavigator] Emit tabRequested when path in path selector menu is middle-clicked
broulik created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The breadcrumbs and menu items in the breadcrumb separators already did that but the path selector, which looks like a breadcrumb separator, did not. TEST PLAN I think this should be the last missing middle click tab handling in the address bar :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7534 AFFECTED FILES src/filewidgets/kurlnavigator.cpp To: broulik, kde-frameworks-devel, dfaure Cc: #frameworks
D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData
dfaure created this revision.
REVISION SUMMARY
This makes it possible to run the unittest without installing the
plugins first.
One thing I don't understand is the need for toString().toInt(),
or in other words, why my json file with a numeric value gets turned
into a string value when using qtplugininfo to inspect the plugin:
User Data: {
"X-KDE-InitialPreference": "5"
}
TEST PLAN
make uninstall; bin/jobtest
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7533
AFFECTED FILES
src/urifilters/fixhost/CMakeLists.txt
src/urifilters/fixhost/fixhosturifilter.cpp
src/urifilters/fixhost/fixhosturifilter.desktop
src/urifilters/fixhost/fixhosturifilter.h
src/urifilters/fixhost/fixhosturifilter.json
src/urifilters/ikws/CMakeLists.txt
src/urifilters/ikws/kuriikwsfilter.cpp
src/urifilters/ikws/kuriikwsfilter.desktop
src/urifilters/ikws/kuriikwsfilter.json
src/urifilters/ikws/kurisearchfilter.cpp
src/urifilters/ikws/kurisearchfilter.desktop
src/urifilters/ikws/kurisearchfilter.json
src/urifilters/localdomain/CMakeLists.txt
src/urifilters/localdomain/localdomainurifilter.cpp
src/urifilters/localdomain/localdomainurifilter.desktop
src/urifilters/localdomain/localdomainurifilter.json
src/urifilters/shorturi/CMakeLists.txt
src/urifilters/shorturi/kshorturifilter.cpp
src/urifilters/shorturi/kshorturifilter.desktop
src/urifilters/shorturi/kshorturifilter.json
src/widgets/kurifilter.cpp
To: dfaure, apol, davidedmundson, arichardson
Cc: #frameworks
D7510: [Service] Use KConfig::SimpleConfig
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7510 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7532: Guard failed testItem creation
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D7532 To: davidedmundson, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 9 - Still Failing!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/9/
Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
Date of build:
Fri, 25 Aug 2017 08:50:19 +
Build duration:
6 min 16 sec and counting
CONSOLE OUTPUT
Started by an SCM change[Pipeline] nodeRunning on Windows Builder 2 in C:\JenkinsWS\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] }[Pipeline] // stage[Pipeline] }java.nio.file.FileSystemException: C:\JenkinsWS\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\build\autotests: The process cannot access the file because it is being used by another process. at sun.nio.fs.WindowsException.translateToIOException(Unknown Source) at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source) at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source) at sun.nio.fs.WindowsFileSystemProvider.implDelete(Unknown Source) at sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(Unknown Source) at java.nio.file.Files.deleteIfExists(Unknown Source) at hudson.Util.tryOnceDeleteFile(Util.java:290) at hudson.Util.deleteFile(Util.java:245) at hudson.FilePath.deleteRecursive(FilePath.java:1211) at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220) at hudson.FilePath.deleteRecursive(FilePath.java:1202) at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220) at hudson.FilePath.deleteRecursive(FilePath.java:1202) at hudson.FilePath.access$1000(FilePath.java:197) at hudson.FilePath$14.invoke(FilePath.java:1181) at hudson.FilePath$14.invoke(FilePath.java:1178) at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2750) at hudson.remoting.UserRequest.perform(UserRequest.java:181) at hudson.remoting.UserRequest.perform(UserRequest.java:52) at hudson.remoting.Request$2.run(Request.java:336) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at hudson.remoting.Engine$1$1.run(Engine.java:98) at java.lang.Thread.run(Unknown Source)Caused: java.io.IOException: Unable to delete 'C:\JenkinsWS\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\build\autotests'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts. at hudson.Util.deleteFile(Util.java:250) at hudson.FilePath.deleteRecursive(FilePath.java:1211) at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220) at hudson.FilePath.deleteRecursive(FilePath.java:1202) at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220) at hudson.FilePath.deleteRecursive(FilePath.java:1202) at hudson.FilePath.access$1000(FilePath.java:197) at hudson.FilePath$14.invoke(FilePath.java:1181) at hudson.FilePath$14.invoke(FilePath.java:1178) at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2750) at hudson.remoting.UserRequest.perform(UserRequest.java:181) at hudson.remoting.UserRequest.perform(UserRequest.java:52) at hudson.remoting.Request$2.run(Request.java:336) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at hudson.remoting.Engine$1$1.run(Engine.java:98) at java.lang.Thread.run(Unknown Source) at ..remote call to JNLP4-connect connection from katze.kde.org/5.9.99.173:56823(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1554) at hudson.remoting.UserResponse.retrieve(UserRequest.java:281) at hudson.remoting.Channel.call(Channel.java:839) at hudson.FilePath.act(FilePath.java:987)Caused: java.io.IOException: remote file operation failed: C:\JenkinsWS\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9 at hudson.remoting.Channel@79c266ad:JNLP4-connect connection from katze.kde.org/5.9.99.173:56823 at hudson.FilePath.act(FilePath.java:994) at hudson.FilePath.act(FilePath.java:976) at hudson.FilePath.deleteRecursive(FilePath.java:1178) at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:77) at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:69) at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1$1.call(SynchronousNonBlockingStepExecution.java:49) at hudson.security.ACL.impersonate(ACL.java:260) at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1.run(SynchronousNonBlockingStepExecution.java:46) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at
D7513: [KUrlNavigator] Emit tabRequested when place in menu is middle-clicked
This revision was automatically updated to reflect the committed changes. Closed by commit R241:7dd46685bed7: [KUrlNavigator] Emit tabRequested when place in menu is middle-clicked (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7513?vs=18678=18729#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7513?vs=18678=18729 REVISION DETAIL https://phabricator.kde.org/D7513 AFFECTED FILES src/filewidgets/kurlnavigatorplacesselector.cpp src/filewidgets/kurlnavigatorplacesselector_p.h To: broulik, kde-frameworks-devel, dfaure, elvisangelaccio Cc: #frameworks
D7512: [KUrlNavigator] Emit tabRequested when places selector is middle-clicked
This revision was automatically updated to reflect the committed changes. Closed by commit R241:027576183f94: [KUrlNavigator] Emit tabRequested when places selector is middle-clicked (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7512?vs=18677=18728 REVISION DETAIL https://phabricator.kde.org/D7512 AFFECTED FILES src/filewidgets/kurlnavigator.cpp src/filewidgets/kurlnavigatorplacesselector.cpp src/filewidgets/kurlnavigatorplacesselector_p.h To: broulik, kde-frameworks-devel, dfaure, elvisangelaccio Cc: #frameworks
D7520: Fix icon of KStandardAction::MoveToTrash
broulik added a comment. I do have two somewhat different looking icons in the context menu. `user-trash` is for a place, not an action, so this might lead to a colorized icon showing up in the menu (when using larger icon sizes and/or high dpi) REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D7520 To: elvisangelaccio, #frameworks Cc: broulik
