D7531: Update SurfaceInterface outputs when an output global gets destroyed
graesslin added a comment. Could you please push this change, it fixes a crash in KWin when changing outputs (as discovered by PlasmaSurfaceTest::testOSDPlacement()): Thread 1 "testPlasmaSurfa" received signal SIGSEGV, Segmentation fault. KWayland::Server::OutputInterface::clientResources (this=, client=0x790460) at /workspace/build/src/server/output_interface.cpp:514 514 /workspace/build/src/server/output_interface.cpp: No such file or directory. (gdb) bt #0 KWayland::Server::OutputInterface::clientResources (this=, client=0x790460) at /workspace/build/src/server/output_interface.cpp:514 #1 0x76f59d87 in KWayland::Server::SurfaceInterface::setOutputs (this=, outputs=...) at /workspace/build/src/server/surface_interface.cpp:792 #2 0x77acbb4d in KWin::ShellClient::updateClientOutputs (this=0x78c710) at /home/martin/src/kde/workspace/kwin/shell_client.cpp:1540 #3 0x75784f46 in QtPrivate::QSlotObjectBase::call (a=0x7fffcc10, r=0x78c710, this=) at ../../include/QtCore/../../src/corelib/kernel/qobject_impl.h:101 #4 QMetaObject::activate (sender=0x6c8e40, signalOffset=, local_signal_index=, argv=) at kernel/qobject.cpp:3749 #5 0x75785c59 in QObject::event (this=0x6c8e40, e=) at kernel/qobject.cpp:1246 #6 0x762e23fc in QApplicationPrivate::notify_helper (this=, receiver=0x6c8e40, e=0x7e6ed0) at kernel/qapplication.cpp:3717 #7 0x762e9e07 in QApplication::notify (this=0x7fffdd80, receiver=0x6c8e40, e=0x7e6ed0) at kernel/qapplication.cpp:3476 #8 0x75758798 in QCoreApplication::notifyInternal2 (receiver=0x6c8e40, event=event@entry=0x7e6ed0) at kernel/qcoreapplication.cpp:1018 #9 0x7575af7b in QCoreApplication::sendEvent (event=0x7e6ed0, receiver=) at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:233 #10 QCoreApplicationPrivate::sendPostedEvents (receiver=receiver@entry=0x0, event_type=event_type@entry=0, data=0x641710) at kernel/qcoreapplication.cpp:1678 #11 0x757aa7e7 in QEventDispatcherUNIX::processEvents (this=0x657e20, flags=...) at kernel/qeventdispatcher_unix.cpp:466 #12 0x7fffdfe02ced in QUnixEventDispatcherQPA::processEvents(QFlags) () from /home/martin/build/kde/workspace/kwin/bin/KWinQpaPlugin.so #13 0x757567ca in QEventLoop::exec (this=this@entry=0x7fffd100, flags=..., flags@entry=...) at kernel/qeventloop.cpp:212 #14 0x00412034 in QTestEventLoop::enterLoopMSecs (ms=5000, this=0x7fffd1c8) at /usr/include/x86_64-linux-gnu/qt5/QtTest/qtesteventloop.h:105 #15 QSignalSpy::wait (this=0x7fffd1a0, timeout=5000) at /usr/include/x86_64-linux-gnu/qt5/QtTest/qsignalspy.h:149 ---Type to continue, or q to quit--- #16 0x0040e5db in PlasmaSurfaceTest::testOSDPlacement (this=) at /home/martin/src/kde/workspace/kwin/autotests/integration/plasma_surface_test.cpp:233 #17 0x757642d6 in QMetaMethod::invoke (this=, object=0x7fffdd50, connectionType=Qt::DirectConnection, returnValue=..., val0=..., val1=..., val2=..., val3=..., val4=..., val5=..., val6=..., val7=..., val8=..., val9=...) at kernel/qmetaobject.cpp: #18 0x77fa4f2c in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Test.so.5 #19 0x77fa5876 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Test.so.5 #20 0x77fa5ea2 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Test.so.5 #21 0x77fa6389 in QTest::qExec(QObject*, int, char**) () from /usr/lib/x86_64-linux-gnu/libQt5Test.so.5 #22 0x00409521 in main (argc=1, argv=0x7fffdf18) at /home/martin/src/kde/workspace/kwin/autotests/integration/plasma_surface_test.cpp:404 REPOSITORY R127 KWayland BRANCH mart/xdgforeign REVISION DETAIL https://phabricator.kde.org/D7531 To: davidedmundson, #plasma, graesslin Cc: graesslin, anthonyfieroni, plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 57 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/57/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 26 Aug 2017 08:50:59 + Build duration: 54 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests build.log Description: Binary data
KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 61 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/61/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Sat, 26 Aug 2017 08:50:59 + Build duration: 1 min 54 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests Cobertura Report Project Coverage Summary Name Cobertura Coverage Report build.log Description: Binary data
D7337: Port rest of scripting API to QJSValue-based solution
cullmann accepted this revision. cullmann added a comment. Looks ok for me. To shorten the code, I would have used const auto cursor = cursorFromScriptValue(jscursor); at most places, but that is taste, the explicit type makes more clear what the type is ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7337 To: dhaumann, carewolf, cullmann Cc: kwrite-devel, #frameworks
D7531: Update SurfaceInterface outputs when an output global gets destroyed
This revision was automatically updated to reflect the committed changes. Closed by commit R127:16f4486cc54c: Update SurfaceInterface outputs when an output global gets destroyed (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7531?vs=18741&id=18804#toc REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7531?vs=18741&id=18804 REVISION DETAIL https://phabricator.kde.org/D7531 AFFECTED FILES autotests/client/test_wayland_surface.cpp src/server/global.cpp src/server/global.h src/server/surface_interface.cpp src/server/surface_interface_p.h To: davidedmundson, #plasma, graesslin Cc: graesslin, anthonyfieroni, plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6047: Support XDG v6
davidedmundson updated this revision to Diff 18807. davidedmundson marked 10 inline comments as done. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. added some comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6047?vs=17813&id=18807 BRANCH xdg_merge REVISION DETAIL https://phabricator.kde.org/D6047 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_xdg_shell.cpp autotests/client/test_xdg_shell.h autotests/client/test_xdg_shell_v5.cpp autotests/client/test_xdg_shell_v6.cpp src/client/CMakeLists.txt src/client/protocols/xdg-shell-unstable-v6.xml src/client/registry.cpp src/client/registry.h src/client/xdgshell.cpp src/client/xdgshell.h src/client/xdgshell_p.h src/client/xdgshell_v5.cpp src/client/xdgshell_v6.cpp src/server/CMakeLists.txt src/server/display.cpp src/server/xdgshell_interface.cpp src/server/xdgshell_interface.h src/server/xdgshell_interface_p.h src/server/xdgshell_v5_interface.cpp src/server/xdgshell_v5_interface_p.h src/server/xdgshell_v6_interface.cpp src/server/xdgshell_v6_interface_p.h src/tools/mapping.txt tests/CMakeLists.txt tests/xdgtest.cpp To: davidedmundson, #plasma, graesslin Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D1231: Add Remote Access interface to KWayland
davidedmundson added a comment. Martin, I explicitly asked you to look at this on Monday. It's being really unfair to a new contributor to make them jump through all sorts of hoops to do things the way you want them, and leave them hanging for literally over a year. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: #frameworks, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
KDE CI: Frameworks baloo kf5-qt5 FreeBSDQt5.7 - Build # 26 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20FreeBSDQt5.7/26/ Project: Frameworks baloo kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 26 Aug 2017 12:13:41 + Build duration: 2 min 32 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 37 test(s) build.log Description: Binary data
D5716: Fix build on CI.
adridg abandoned this revision. adridg added a comment. Closed by 2e7cd3bc4704408358f11ad4d92af17a1b8ce2b5 REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D5716 To: adridg, winterz, bcooksley, vonreth Cc: #frameworks, #documentation, skadinna
D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData
dfaure added a comment. In https://phabricator.kde.org/D7533#139802, @bshah wrote: > > One thing I don't understand is the need for toString().toInt(), > > or in other words, why my json file with a numeric value gets turned > > into a string value when using qtplugininfo to inspect the plugin: > > Maybe you need to add following in the `src/widgets/kurifilterplugin.desktop` > > [PropertyDef::X-KDE-InitialPreference] > Type=int > Ah, indeed. That, and passing the servicetype file to kcoreaddons_add_plugin. Thanks! REVISION DETAIL https://phabricator.kde.org/D7533 To: dfaure, apol, davidedmundson, arichardson Cc: vandenoever, elvisangelaccio, bshah, #frameworks
D5716: Fix build on CI.
This revision was automatically updated to reflect the committed changes. Closed by commit R264:2e7cd3bc4704: Fix build on CI. (authored by adridg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5716?vs=14152&id=18817#toc REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5716?vs=14152&id=18817 REVISION DETAIL https://phabricator.kde.org/D5716 AFFECTED FILES CMakeLists.txt To: adridg, winterz, bcooksley, vonreth Cc: #frameworks, #documentation, skadinna
D7337: Port rest of scripting API to QJSValue-based solution
dhaumann closed this revision. dhaumann added a comment. Committed: https://cgit.kde.org/ktexteditor.git/commit/?id=fc510adaecf1dc83416eaf4392925ee4f3c5a1e0 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7337 To: dhaumann, carewolf, cullmann Cc: kwrite-devel, #frameworks
D7563: Add privilegeExecution field to file protocol description
chinmoyr created this revision. REVISION SUMMARY "privilegeExecution" field will specify if protocol can perform file operation with elevated privileges. Dolphin relies on `KFileItemListProperties` for enabling some of its context menu actions. Internally `KFileItemListProperties` uses `KProtocolManager` to determine if a location supports reading, writing, deleting and moving. With these changes `KProtocolManager` will now check for the said field. Consequently, dolphin will be aware of our new file protocol and will show its context menu without any action being disabled. BRANCH master REVISION DETAIL https://phabricator.kde.org/D7563 AFFECTED FILES src/core/kfileitemlistproperties.cpp src/core/kprotocolinfo.cpp src/core/kprotocolinfo_p.h src/core/kprotocolmanager.cpp src/core/kprotocolmanager.h src/ioslaves/file/file.json To: chinmoyr, #frameworks, dfaure Cc: elvisangelaccio
D7563: Add privilegeExecution field to file protocol description
chinmoyr added a task: T6561: Polkit support in KIO. REVISION DETAIL https://phabricator.kde.org/D7563 To: chinmoyr, #frameworks, dfaure Cc: elvisangelaccio
KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 63 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/63/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 26 Aug 2017 17:39:30 + Build duration: 9 min 7 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.kateindenttest_testCstyle build.log Description: Binary data
D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData
dfaure updated this revision to Diff 18829. dfaure added a comment. Provide servicetype file to the cmake macro so that the priority is stored as an int. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7533?vs=18731&id=18829 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7533 AFFECTED FILES src/urifilters/fixhost/CMakeLists.txt src/urifilters/fixhost/fixhosturifilter.cpp src/urifilters/fixhost/fixhosturifilter.desktop src/urifilters/fixhost/fixhosturifilter.h src/urifilters/fixhost/fixhosturifilter.json src/urifilters/ikws/CMakeLists.txt src/urifilters/ikws/kuriikwsfilter.cpp src/urifilters/ikws/kuriikwsfilter.desktop src/urifilters/ikws/kuriikwsfilter.json src/urifilters/ikws/kurisearchfilter.cpp src/urifilters/ikws/kurisearchfilter.desktop src/urifilters/ikws/kurisearchfilter.json src/urifilters/localdomain/CMakeLists.txt src/urifilters/localdomain/localdomainurifilter.cpp src/urifilters/localdomain/localdomainurifilter.desktop src/urifilters/localdomain/localdomainurifilter.json src/urifilters/shorturi/CMakeLists.txt src/urifilters/shorturi/kshorturifilter.cpp src/urifilters/shorturi/kshorturifilter.desktop src/urifilters/shorturi/kshorturifilter.json src/widgets/kurifilter.cpp src/widgets/kurifilterplugin.desktop To: dfaure, apol, davidedmundson, arichardson Cc: vandenoever, elvisangelaccio, bshah, #frameworks
D1231: Add Remote Access interface to KWayland
alexeymin added a comment. In https://phabricator.kde.org/D1231#39191, @Kanedias wrote: > ... > Besides, I didn't find any mentions of multi-screen capabilities in Krfb at all. It currently works like this: > > d->framebufferImage = XGetImage(QX11Info::display(), > id, > 0, > 0, > QApplication::desktop()->width(), > QApplication::desktop()->height(), > AllPlanes, > ZPixmap); > > > If that's the requirement, there will be huge amount of work to implement it from ground up. > Patchset for KRfb is already enormous and rewrites half of the input system into plugins instead of built-in libraries (to integrate it with fake-input). I doubt it will endure another set of additions, the review will take forever. > I think we should implement screen indexing in protocol but start with passing screen №1 only for now. Speaking about krfb, after https://phabricator.kde.org/D5211 X11 plugin (and `XGetImage` code) does not exist anymore. And krfb is aware of having multiple screens, but it shares only primary screen area: - xcb plugin: https://cgit.kde.org/krfb.git/tree/framebuffers/xcb/xcb_framebuffer.cpp#n171 - qt plugin: https://cgit.kde.org/krfb.git/tree/framebuffers/qt/qtframebuffer.cpp#n81 I cannot imagine how VNC server application can properly serve multiple monitors at once, especially if they have different resolutions (merge them into one big image covering all monitors at once, with black border around the smaller one?). So I think if krfb will ever support multiple monitors explicitly, there will be a combo box to select which screen to share. Do you think other screen recording applications will need to capture several monitors at once? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: alexeymin, #frameworks, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
