D7164: KSqueezedTextLabel: Respect indent, margin and frame width
cfeck added a comment. QLabel sends out a QEvent::ContentsRectChange event when the margins change or the frame style causes a size change. Could this be catched (using an event filter) instead of reimplementing the properties? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7164 To: rkflx, #frameworks, cfeck Cc: cfeck, dhaumann
D7164: KSqueezedTextLabel: Respect indent, margin and frame width
cfeck added a comment. I probably miss the big picture here. Why are these attributes needed? The lineWidth attribute, for example, looks like a thing from the past, where you could control the thickness of frames (CDE vs. Motif style). REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7164 To: rkflx, #frameworks, cfeck Cc: cfeck, dhaumann
D7164: KSqueezedTextLabel: Respect indent, margin and frame width
rkflx added a reviewer: cfeck. rkflx added a comment. @cfeck Friendly ping :) Please let me know if you have any questions or someone else should review this. We really don't want to BIC-break a Tier 1 framework… REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7164 To: rkflx, #frameworks, cfeck Cc: cfeck, dhaumann
D7367: Added Intel HEX file support for the Syntax highlighting database
aacid added a comment. Damnit, i commited it and now the tests are not passing :( https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/89/console REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7367 To: martonmiklos, #framework_syntax_hightlighting, cullmann, aacid Cc: aacid, dhaumann, cullmann, #frameworks, vkrause
D7367: Added Intel HEX file support for the Syntax highlighting database
This revision was automatically updated to reflect the committed changes. Closed by commit R216:3f9f38a18b60: Added Intel HEX file support for the Syntax highlighting database (authored by martonmiklos, committed by aacid). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7367?vs=18514=19215 REVISION DETAIL https://phabricator.kde.org/D7367 AFFECTED FILES autotests/html/highlight.hex.html autotests/input/highlight.hex data/syntax/intelhex.xml To: martonmiklos, #framework_syntax_hightlighting, cullmann, aacid Cc: aacid, dhaumann, cullmann, #frameworks, vkrause
KDE CI: Frameworks syntax-highlighting kf5-qt5 XenialQt5.7 - Build # 91 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/91/ Project: Frameworks syntax-highlighting kf5-qt5 XenialQt5.7 Date of build: Tue, 05 Sep 2017 21:12:02 + Build duration: 2 min 36 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.folding_testFailed: TestSuite.testhighlighter_test Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (3/3)92% (36/39)92% (36/39)85% (2113/2490)70% (1580/2263)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (8/8)100% (8/8)97% (501/515)63% (338/534)src.indexer100% (1/1)100% (1/1)72% (60/83)77% (75/98)src.lib90% (27/30)90% (27/30)82% (1552/1892)72% (1167/1631) build.log Description: Binary data
KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7 - Build # 89 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/89/ Project: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 05 Sep 2017 21:12:03 + Build duration: 2 min 1 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 8 test(s)Failed: TestSuite.folding_testFailed: TestSuite.testhighlighter_test build.log Description: Binary data
D7367: Added Intel HEX file support for the Syntax highlighting database
martonmiklos added a comment. In https://phabricator.kde.org/D7367#143314, @cullmann wrote: > syntax-highlighting.git, on first glance not landed atm. > > Can you commit on your own or should I push it for you Miklos? Hi guys, I am on holiday ATM so if you could push it that would be awesome. Otherwise I can take care of it next week. Thanks in advance! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7367 To: martonmiklos, #framework_syntax_hightlighting, cullmann, aacid Cc: aacid, dhaumann, cullmann, #frameworks, vkrause
D7367: Added Intel HEX file support for the Syntax highlighting database
aacid set the repository for this revision to R216 Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7367 To: martonmiklos, #framework_syntax_hightlighting, cullmann, aacid Cc: aacid, dhaumann, cullmann, #frameworks, vkrause
D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.
aacid closed this revision. aacid added a comment. Seems you commited this but forgot to close this? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux, kfunk Cc: kossebau, aacid, kfunk, #frameworks, #build_system
D7367: Added Intel HEX file support for the Syntax highlighting database
cullmann added a comment. syntax-highlighting.git, on first glance not landed atm. Can you commit on your own or should I push it for you Miklos? REVISION DETAIL https://phabricator.kde.org/D7367 To: martonmiklos, #framework_syntax_hightlighting, cullmann, aacid Cc: aacid, dhaumann, cullmann, #frameworks, vkrause
D7367: Added Intel HEX file support for the Syntax highlighting database
aacid added a comment. Which repo is this for? Has this landed? REVISION DETAIL https://phabricator.kde.org/D7367 To: martonmiklos, #framework_syntax_hightlighting, cullmann Cc: aacid, dhaumann, cullmann, #frameworks, vkrause
D7367: Added Intel HEX file support for the Syntax highlighting database
aacid requested changes to this revision. This revision now requires changes to proceed. REVISION DETAIL https://phabricator.kde.org/D7367 To: martonmiklos, #framework_syntax_hightlighting, cullmann, aacid Cc: aacid, dhaumann, cullmann, #frameworks, vkrause
D7487: Make KCMultiDialog scrollable
aacid closed this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D7487 To: valeriymalov, #frameworks, davidedmundson Cc: davidedmundson, wbauer, broulik
D7699: Add support for custom search paths for application-specific syntax and theme definitions
zrax retitled this revision from "Add support for custom search paths for application-specific syntax and themedefinitions" to "Add support for custom search paths for application-specific syntax and theme definitions". zrax edited the summary of this revision. zrax edited the test plan for this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7699 To: zrax, #kate, #framework_syntax_hightlighting Cc: #frameworks
D7699: Add support for custom search paths for application-specific syntax and themedefinitions
zrax retitled this revision from "Add support for custom search paths for application-specific syntax and theme definitions" to "Add support for custom search paths for application-specific syntax and themedefinitions". zrax added reviewers: Kate, Framework: Syntax Hightlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7699 To: zrax, #kate, #framework_syntax_hightlighting Cc: #frameworks
D7699: Add support for custom search paths for application-specific syntax and themedefinitions
zrax created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This allows applications to include application-specific syntax rules and themes which don't necessarily make sense to install globally to be used with syntax-highlighting. TEST PLAN Created custom syntax rule and sample application using QTextEdit; tested both standard syntax rules and the custom rule within the application, using the default theme. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D7699 AFFECTED FILES src/lib/repository.cpp src/lib/repository.h src/lib/repository_p.h To: zrax Cc: #frameworks
D7369: Wayland foreign protocol
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Overall lots of documentation is missing. From API layout that looks much better now, but we still have a few places where "Unstable" is needlessly in the API. Most important in Display the create method is not forward compatible by not having an enum to describe which interface version should be created. INLINE COMMENTS > registry.h:527-528 > + > +zxdg_exporter_v1 *bindXdgExporterUnstableV1(uint32_t name, uint32_t > version) const; > +zxdg_importer_v1 *bindXdgImporterUnstableV1(uint32_t name, uint32_t > version) const; > ///@} please add documentation > registry.h:940-941 > + > +XdgExporter *createXdgExporterUnstable(quint32 name, quint32 version, > QObject *parent = nullptr); > +XdgImporter *createXdgImporterUnstable(quint32 name, quint32 version, > QObject *parent = nullptr); > ///@} please add documentation > registry.h:940-941 > + > +XdgExporter *createXdgExporterUnstable(quint32 name, quint32 version, > QObject *parent = nullptr); > +XdgImporter *createXdgImporterUnstable(quint32 name, quint32 version, > QObject *parent = nullptr); > ///@} Why did you keep the suffix "Unstable"? > registry.h:1132-1133 > + > +void exporterUnstableV1Announced(quint32 name, quint32 version); > +void importerUnstableV1Announced(quint32 name, quint32 version); > ///@} please add documentation > registry.h:1288-1290 > +void exporterUnstableV1Removed(quint32 name); > +void importerUnstableV1Removed(quint32 name); > ///@} please add documentation > display.h:223 > > +XdgForeignInterface *createXdgForeignUnstableInterface(QObject *parent = > nullptr); > /** please add documentation. Also the common way would be to have an enum to describe which interface should be created, but therefore drop the Unstable from the API name. > xdgforeign_interface.h:37 > +class XdgImporterUnstableV1Interface; > + > +class KWAYLANDSERVER_EXPORT XdgForeignInterface : public QObject Something like an enum ForeignInterfaceVersion is missing, please compare TextInputInterface > xdgforeign_v1_interface.cpp:260 > + > +QPointer imp = new > XdgImportedUnstableV1Interface(s->q, surface); > +imp->create(s->display->getConnection(client), > wl_resource_get_version(resource), id); what's an imp? Could you please write full variable names? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7369 To: mart, #plasma, #kwin, davidedmundson, graesslin Cc: davidedmundson, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7491: Fix invalid id in viewitem.
This revision was automatically updated to reflect the committed changes. Closed by commit R242:8d38df353422: Fix invalid id in viewitem. (authored by xuetianweng). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7491?vs=18618=19209 REVISION DETAIL https://phabricator.kde.org/D7491 AFFECTED FILES src/desktoptheme/breeze/widgets/viewitem.svgz To: xuetianweng, mart, #plasma, davidedmundson Cc: #frameworks
D7369: Wayland foreign protocol
mart retitled this revision from "[WIP] Wayland foreign protocol" to "Wayland foreign protocol". REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7369 To: mart, #plasma, #kwin, davidedmundson Cc: davidedmundson, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
KDE CI: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 - Build # 45 - Still Failing!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/45/ Project: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 Date of build: Tue, 05 Sep 2017 09:10:07 + Build duration: 3 min 14 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 50 test(s)Failed: TestSuite.ECMPoQmToolsTest CONSOLE OUTPUT [...truncated 165.88 KB...] Start 20: ECMQMLModules20/50 Test #20: ECMQMLModules . Passed3.01 sec Start 21: ecm_add_tests-single_tests21/50 Test #21: ecm_add_tests-single_tests Passed3.19 sec Start 22: ecm_add_tests_did_run-single_tests22/50 Test #22: ecm_add_tests_did_run-single_tests Passed0.01 sec Start 23: ecm_add_tests-multi_tests23/50 Test #23: ecm_add_tests-multi_tests . Passed2.76 sec Start 24: ecm_add_tests_did_run-multi_tests24/50 Test #24: ecm_add_tests_did_run-multi_tests . Passed0.02 sec Start 25: ECMGenerateHeaders25/50 Test #25: ECMGenerateHeaders Passed0.03 sec Start 26: ecm_setup_version-old_simple26/50 Test #26: ecm_setup_version-old_simple .. Passed1.52 sec Start 27: ecm_setup_version-old_soversion27/50 Test #27: ecm_setup_version-old_soversion ... Passed2.56 sec Start 28: ecm_setup_version-old_version_file28/50 Test #28: ecm_setup_version-old_version_file Passed1.70 sec Start 29: ecm_setup_version-old_version_file_abspath29/50 Test #29: ecm_setup_version-old_version_file_abspath Passed2.59 sec Start 30: ecm_setup_version-old_version_file_anynewer30/50 Test #30: ecm_setup_version-old_version_file_anynewer ... Passed1.84 sec Start 31: ecm_setup_version-old_version_file_exact31/50 Test #31: ecm_setup_version-old_version_file_exact .. Passed1.70 sec Start 32: ecm_setup_version-old_version_file_samemajor32/50 Test #32: ecm_setup_version-old_version_file_samemajor .. Passed1.10 sec Start 33: ecm_setup_version-old_header33/50 Test #33: ecm_setup_version-old_header .. Passed1.03 sec Start 34: ecm_setup_version-old_header_abspath34/50 Test #34: ecm_setup_version-old_header_abspath .. Passed1.31 sec Start 35: ecm_setup_version-new_explicit_header35/50 Test #35: ecm_setup_version-new_explicit_header . Passed1.37 sec Start 36: ecm_setup_version-new_explicit_header_abspath36/50 Test #36: ecm_setup_version-new_explicit_header_abspath . Passed1.76 sec Start 37: ecm_setup_version-new_explicit_simple37/50 Test #37: ecm_setup_version-new_explicit_simple . Passed2.69 sec Start 38: ecm_setup_version-new_explicit_soversion38/50 Test #38: ecm_setup_version-new_explicit_soversion .. Passed2.69 sec Start 39: ecm_setup_version-new_explicit_version_file39/50 Test #39: ecm_setup_version-new_explicit_version_file ... Passed1.57 sec Start 40: ecm_setup_version-new_explicit_version_file_abspath40/50 Test #40: ecm_setup_version-new_explicit_version_file_abspath ... Passed1.54 sec Start 41: ecm_setup_version-new_project_header41/50 Test #41: ecm_setup_version-new_project_header .. Passed1.93 sec Start 42: ecm_setup_version-new_project_header_abspath42/50 Test #42: ecm_setup_version-new_project_header_abspath .. Passed1.79 sec Start 43: ecm_setup_version-new_project_header_prefix43/50 Test #43: ecm_setup_version-new_project_header_prefix ... Passed1.84 sec Start 44: ecm_setup_version-new_project_simple44/50 Test #44: ecm_setup_version-new_project_simple .. Passed2.21 sec Start 45: ecm_setup_version-new_project_simple_prefix45/50 Test #45: ecm_setup_version-new_project_simple_prefix ... Passed2.08 sec Start 46: ecm_setup_version-new_project_soversion46/50 Test #46: ecm_setup_version-new_project_soversion ... Passed2.22 sec Start 47: ecm_setup_version-new_project_soversion_prefix47/50 Test #47: ecm_setup_version-new_project_soversion_prefix Passed1.83 sec Start 48: ecm_setup_version-new_project_version_file48/50 Test #48: ecm_setup_version-new_project_version_file Passed1.19 sec Start 49: ecm_setup_version-new_project_version_file_abspath49/50 Test #49: ecm_setup_version-new_project_version_file_abspath Passed1.89 sec Start 50: ECMGeneratePkgConfigFile50/50 Test #50: ECMGeneratePkgConfigFile .. Passed0.02 sec98% tests passed, 1
D7697: emit dirty signal for a directory on creation of a file even if the file is being watched individually
progwolff abandoned this revision. progwolff added a comment. Invalid. Worked as expected without my changes. I did not test it correctly. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D7697 To: progwolff, #frameworks
D7676: Added openService() method to KRunProxy
maxrd2 added a comment. In https://phabricator.kde.org/D7676#143033, @broulik wrote: > Well it is now "openService" calling "runApplication", that's inconsistent isn't it Yes, but it will start services that have Exec line though. Should i just rename the method to "openApplication" or "runApplication" ? Adding something like this wont change much it seems. if(!service->isApplication()) KRun::runService(*service, QList(), nullptr) != 0; REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D7676 To: maxrd2, davidedmundson Cc: broulik, #frameworks
D7697: emit dirty signal for a directory on creation of a file even if the file is being watched individually
progwolff edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D7697 To: progwolff, #frameworks
D7697: emit dirty signal for a directory on creation of a file even if the file is being watched individually
progwolff created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY KDirWatch emits a dirty signal for a watched directory when a file is ceated in this directory. However, currently this signal is not emitted when a file is added that is watched individually. With this patch, a dirty signal for the directory is sent even if a watched file is added. This fixes a bug in Okular. BUG: 384185 See also the discussion in https://phabricator.kde.org/D7671 TEST PLAN Watched a directory and a file in this directory. Deleted and recreated the file. 1. a "deleted" signal for the file is emitted 2. a "dirty" signal for the directory is emitted 3. a "created" signal for the file is emitted 4. a "dirty" signal for the directory is emitted Tested only with inotify. There may be other places for other backends which need changes. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D7697 AFFECTED FILES src/lib/io/kdirwatch.cpp To: progwolff, #frameworks
