D7130: KMoreTools: Update and fix desktopfiles

2017-09-13 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.


  FWIW, this looks good to me.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D7130

To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, 
ngraham
Cc: ngraham, ltoscano, #frameworks


D7810: Add missing icon sizes

2017-09-13 Thread mandian
mandian planned changes to this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D7810

To: mandian, #breeze
Cc: #frameworks


D7810: Add missing icon sizes

2017-09-13 Thread mandian
mandian created this revision.
mandian added a project: Breeze.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Add missing icon sizes

TEST PLAN
  Add missing scalable icon sizes at index.theme. If not all size are covered 
by scalable icons some desktop environment other than PLASMA may show icons not 
properly scaled.
  
  See also bug #384473 for more detailed explaination and screenshot
  https://bugs.kde.org/show_bug.cgi?id=384473

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D7810

AFFECTED FILES
  icons/index.theme

To: mandian, #breeze
Cc: #frameworks


Re: KGlobalAccel regression in latest frameworks release

2017-09-13 Thread Kai Uwe Broulik
Oki, just KGlobalAccel seems fine, too.


  Ursprüngliche Nachricht  
Von: mgraess...@kde.org
Gesendet: 13. September 2017 8:33 nachm.
An: plasma-de...@kde.org; kde-frameworks-devel@kde.org
Antworten: kde-frameworks-devel@kde.org
Betreff: Re: KGlobalAccel regression in latest frameworks release

Am 2017-09-13 20:28, schrieb Kai Uwe Broulik:
> Hi,
> 
> either of the following reverts fix the problem for me:
> 
> KGlobalAccel: 2c20ddff034e4958bf0536ca91ae9e444955305d
> 
> or
> 
> KWindowSystem: 53ab31c663e63c18e30c69af445e9dd022a89acc and
> 32526718eae99ccb594360627586eebdf793372b
> 
> but perhaps both KGlobalAccel and KWindowSystem to be sure.

If KGlobalAccel itself is enough, then only KGlobalAccel. KWindowSystem 
introduces new API so reverting would cause ABI issues in worst case.

Cheers
Martin


Re: KGlobalAccel regression in latest frameworks release

2017-09-13 Thread Martin Flöser

Am 2017-09-13 20:28, schrieb Kai Uwe Broulik:

Hi,

either of the following reverts fix the problem for me:

KGlobalAccel: 2c20ddff034e4958bf0536ca91ae9e444955305d

or

KWindowSystem: 53ab31c663e63c18e30c69af445e9dd022a89acc and
32526718eae99ccb594360627586eebdf793372b

but perhaps both KGlobalAccel and KWindowSystem to be sure.


If KGlobalAccel itself is enough, then only KGlobalAccel. KWindowSystem 
introduces new API so reverting would cause ABI issues in worst case.


Cheers
Martin


Re: KGlobalAccel regression in latest frameworks release

2017-09-13 Thread Kai Uwe Broulik
Hi,

either of the following reverts fix the problem for me:

KGlobalAccel: 2c20ddff034e4958bf0536ca91ae9e444955305d

or

KWindowSystem: 53ab31c663e63c18e30c69af445e9dd022a89acc and 
32526718eae99ccb594360627586eebdf793372b

but perhaps both KGlobalAccel and KWindowSystem to be sure.

Cheers
Kai Uwe




Re: KGlobalAccel regression in latest frameworks release

2017-09-13 Thread Martin Flöser

Am 2017-09-13 19:06, schrieb Jonathan Riddell:

This patch?
https://phabricator.kde.org/D6234

I think reverting it for now and me or David can make a 5.38.1 release
would be easiest


Yes, that should be the change causing the issue. It could also be the 
change in KWindowSystem.


Best would be someone on an X11 system to test what helps (maybe 
Kai-Uwe?).


Cheers
Martin



Jonathan


On Wed, Sep 13, 2017 at 06:23:48PM +0200, Martin Flöser wrote:

Hi all,

unfortunately I have to inform you that KGlobalAccel has a severe
regression [1] in the latest framework release resulting in many
shortcuts no longer functioning.

As the current frameworks release is the one the next Plasma release
is going to depend on, we need to act quickly. In the current state
I would say a release of Plasma requiring this frameworks version is
an absolute no-no, this is release blocking. I'm saying this as the
maintainer of kglobalaccel and of the most affected application
KWin.

Following recommendations from my side:
* distributions who have not yet shipped out the latest frameworks
release should hold back kglobalaccel and maybe kwindowsystem
* in KGlobalAccel we need to get a fix for it, I'm not able to
provide it, though.
* Otherwise I would suggest that the change in KGlobalAccel gets
reverted

Due to the fact that Plasma depends on this release we must act
quickly and do a bug fix release for frameworks even if this is
uncommon and against the practice.

Sorry for any inconveniences.

Martin Flöser
KGlobalAccel maintainer

[1] https://bugs.kde.org/show_bug.cgi?id=384597


Re: KGlobalAccel regression in latest frameworks release

2017-09-13 Thread Jonathan Riddell

This patch?
https://phabricator.kde.org/D6234

I think reverting it for now and me or David can make a 5.38.1 release would be 
easiest

Jonathan


On Wed, Sep 13, 2017 at 06:23:48PM +0200, Martin Flöser wrote:
> Hi all,
> 
> unfortunately I have to inform you that KGlobalAccel has a severe
> regression [1] in the latest framework release resulting in many
> shortcuts no longer functioning.
> 
> As the current frameworks release is the one the next Plasma release
> is going to depend on, we need to act quickly. In the current state
> I would say a release of Plasma requiring this frameworks version is
> an absolute no-no, this is release blocking. I'm saying this as the
> maintainer of kglobalaccel and of the most affected application
> KWin.
> 
> Following recommendations from my side:
> * distributions who have not yet shipped out the latest frameworks
> release should hold back kglobalaccel and maybe kwindowsystem
> * in KGlobalAccel we need to get a fix for it, I'm not able to
> provide it, though.
> * Otherwise I would suggest that the change in KGlobalAccel gets
> reverted
> 
> Due to the fact that Plasma depends on this release we must act
> quickly and do a bug fix release for frameworks even if this is
> uncommon and against the practice.
> 
> Sorry for any inconveniences.
> 
> Martin Flöser
> KGlobalAccel maintainer
> 
> [1] https://bugs.kde.org/show_bug.cgi?id=384597


KGlobalAccel regression in latest frameworks release

2017-09-13 Thread Martin Flöser

Hi all,

unfortunately I have to inform you that KGlobalAccel has a severe 
regression [1] in the latest framework release resulting in many 
shortcuts no longer functioning.


As the current frameworks release is the one the next Plasma release is 
going to depend on, we need to act quickly. In the current state I would 
say a release of Plasma requiring this frameworks version is an absolute 
no-no, this is release blocking. I'm saying this as the maintainer of 
kglobalaccel and of the most affected application KWin.


Following recommendations from my side:
* distributions who have not yet shipped out the latest frameworks 
release should hold back kglobalaccel and maybe kwindowsystem
* in KGlobalAccel we need to get a fix for it, I'm not able to provide 
it, though.
* Otherwise I would suggest that the change in KGlobalAccel gets 
reverted


Due to the fact that Plasma depends on this release we must act quickly 
and do a bug fix release for frameworks even if this is uncommon and 
against the practice.


Sorry for any inconveniences.

Martin Flöser
KGlobalAccel maintainer

[1] https://bugs.kde.org/show_bug.cgi?id=384597


KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 80 - Still Unstable!

2017-09-13 Thread no-reply
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/80/
 Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
 Date of build:
Wed, 13 Sep 2017 12:48:58 +
 Build duration:
1 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

build.log
Description: Binary data


KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 76 - Still Unstable!

2017-09-13 Thread no-reply
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/76/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
 Date of build:
Wed, 13 Sep 2017 12:48:58 +
 Build duration:
47 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

build.log
Description: Binary data


D6233: KKeyServer: fix handling of KeypadModifier.

2017-09-13 Thread Kai Uwe Broulik
broulik added a comment.


  When I press Meta+Shift+PrintScreen previously I got 
`QKeySequence(Meta+Shift+Print)` which is correct but now I get 
`QKeySequence(Meta+Shift+SysReq)` which fails to map (on German layout SysReq 
is the key and Shift+SysReq results in PrintScreen)

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D6233

To: dfaure, graesslin
Cc: broulik, martinkostolny, bcooksley, graesslin, #frameworks


KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 79 - Still Unstable!

2017-09-13 Thread no-reply
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/79/
 Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
 Date of build:
Wed, 13 Sep 2017 07:48:27 +
 Build duration:
1 min 13 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

build.log
Description: Binary data


KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 75 - Still Unstable!

2017-09-13 Thread no-reply
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/75/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
 Date of build:
Wed, 13 Sep 2017 07:48:27 +
 Build duration:
38 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

build.log
Description: Binary data