D7859: KMessageBox: Use question mark icon for question dialogs

2017-09-17 Thread Henrik Fehlauer 
rkflx created this revision.
rkflx added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Besides `Information`, `Warning` and `Critical`, the `QMessageBox::Icon`
  enum supports icons of type `Question`. Instead of falling back to an
  "information" icon, use a "question mark" icon for every
  `KMessageBox::question*()`.
  
  Note: Using the Oxygen icon set still displays an "information" icon
  (may need investigation).

TEST PLAN
  - `kmessageboxtest` now shows question mark icon for some dialogs
  - cursory look at lxr suggest most usage is a proper question indeed
  - question mark icon supported in Breeze and Adwaita icon set

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7859

AFFECTED FILES
  src/kmessagebox.cpp

To: rkflx, #frameworks

D7859: KMessageBox: Use question mark icon for question dialogs

2017-09-17 Thread Christoph Feck 
cfeck accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7859

To: rkflx, #frameworks, cfeck
Cc: alexeymin

D7859: KMessageBox: Use question mark icon for question dialogs

2017-09-17 Thread Henrik Fehlauer 
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:9b05a12a43db: KMessageBox: Use question mark icon for 
question dialogs (authored by rkflx).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7859?vs=19604&id=19607

REVISION DETAIL
  https://phabricator.kde.org/D7859

AFFECTED FILES
  src/kmessagebox.cpp

To: rkflx, #frameworks, cfeck
Cc: alexeymin

KDE CI: Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7 - Build # 41 - Still Unstable!

2017-09-17 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20XenialQt5.7/41/
 Project:
Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7
 Date of build:
Sun, 17 Sep 2017 11:31:46 +
 Build duration:
5 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: TestSuite.ksqueezedtextlabelautotest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)55%
(80/146)55%
(80/146)29%
(4103/14284)21%
(1588/7741)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(32/32)100%
(32/32)99%
(1531/1542)51%
(793/1542)src42%
(48/114)42%
(48/114)20%
(2572/12742)13%
(795/6199)

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7 - Build # 41 - Still Unstable!

2017-09-17 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.7/41/
 Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7
 Date of build:
Sun, 17 Sep 2017 11:31:46 +
 Build duration:
7 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: TestSuite.ksqueezedtextlabelautotest

D7699: Add support for custom search paths for application-specific syntax and theme definitions

2017-09-17 Thread Christoph Cullmann 
cullmann added a comment.


  I think you are right, the indexer is an other issue.
  We could even just disable that index... files are used by the framework 
beside for its own internal dirs.
  
  I guess for this review just Volker needs to say which version should go in 
and we are done.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7699

To: zrax, #kate, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, vkrause, cullmann, #framework_syntax_highlighting, #frameworks

D7245: Improve reStructuredText highlighting

2017-09-17 Thread Christoph Cullmann 
cullmann added a comment.


  Hi, please add a testcase and we are done here.
  Without a test case this can easily degenerate later again.

REVISION DETAIL
  https://phabricator.kde.org/D7245

To: turbov, #kate, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, #frameworks

D7861: Support clojure's "@" macro with brackets

2017-09-17 Thread Koichi Akabe 
koichia created this revision.
koichia added a project: Framework: Syntax Highlighting.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  This change will fix clojure's syntax highlighting like the following code:
  
  `(@(.state this) k)`

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7861

AFFECTED FILES
  data/syntax/clojure.xml

To: koichia
Cc: #frameworks, cullmann, vkrause, dhaumann

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

2017-09-17 Thread Jonathan Marten 
marten updated this revision to Diff 19611.
marten added a comment.


  Diff updated to move library target definition after 
find_package_handle_standard_args.
  
  If these modules are accepted into ECM then KMix needs a further commit 
anyway, in order to remove the final requirement for KDELibs4Support.  So the 
correct variable names can be set at this point (I have already tested this 
configuration).  Other packages requiring PA and/or GLib may need to do the 
same when transitioning to use the ECM versions.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7823?vs=19576&id=19611

REVISION DETAIL
  https://phabricator.kde.org/D7823

AFFECTED FILES
  find-modules/FindGLIB2.cmake
  find-modules/FindPulseAudio.cmake

To: marten, #frameworks, #build_system
Cc: cgiboudeaux, cfeck, heikobecker

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

2017-09-17 Thread Jonathan Marten 
marten marked an inline comment as done.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D7823

To: marten, #frameworks, #build_system
Cc: cgiboudeaux, cfeck, heikobecker

D7861: Support clojure's "@" macro with brackets

2017-09-17 Thread Koichi Akabe 
koichia edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7861

To: koichia
Cc: #frameworks, cullmann, vkrause, dhaumann

D7849: Fix the tray icon scaling on HiDPI screens

2017-09-17 Thread Piotr Kosinski 
pgkos updated this revision to Diff 19612.
pgkos added a comment.


  Fixed the previous diff.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7849?vs=19592&id=19612

REVISION DETAIL
  https://phabricator.kde.org/D7849

AFFECTED FILES
  src/declarativeimports/core/units.cpp
  src/declarativeimports/core/units.h

To: pgkos, #plasma
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7849: Fix the tray icon scaling on HiDPI screens

2017-09-17 Thread Kai Uwe Broulik 
broulik added a comment.


  I don't understand this. RoundToIconSize is supposed to round down and that's 
it. If I pass it 100 px because I'm on a high dpi screen, it will still return 
100. Only if I pass it e.g. 34 it will change it to 32.

REVISION DETAIL
  https://phabricator.kde.org/D7849

To: pgkos, #plasma
Cc: broulik, #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7849: Fix the tray icon scaling on HiDPI screens

2017-09-17 Thread Piotr Kosinski 
pgkos added a comment.


  @broulik consider this case:
  
  The tray icons' size is defined by default in 
`org.kde.plasma.private.systemtray/contents/config/main.xml` to `smallMedium`, 
which means 22 pixels on a 96-dpi screen. On a 192-dpi screen, the icons' real 
size is 44 pixels.
  Now, in `org.kde.plasma.private.systemtray/contents/ui/main.qml` there is 
this line:
  
units.roundToIconSize(Math.min(Math.min(width, height), 
units.iconSizes[iconSizes[plasmoid.configuration.iconSize]]))
  
  The `height` property is the height of the panel (assuming the panel is 
horizontal). On my hidpi screen the default panel height is around 72 pixels 
(`32 px * 2`).
  
  So the above line evaluates to:
  `units.roundToIconSize(Math.min(72, units.iconSizes.smallMedium))`
  `units.roundToIconSize(Math.min(72, 44))`
  `units.roundToIconSize(44)`
  
  and that gets rounded to `medium` size, which is incorrect, because we want a 
`smallMedium` size multiplied by two (`32 px != 22 px * 2`).
  
  So, on a hidpi screen the `roundToIconSize` function returns a wrong size, 
and additionally it (wrongly) does not multiply the size by the icon dpi 
scaling factor (e.g. `2.0`).

REVISION DETAIL
  https://phabricator.kde.org/D7849

To: pgkos, #plasma
Cc: broulik, #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7849: Fix the tray icon scaling on HiDPI screens

2017-09-17 Thread Anthony Fieroni 
anthonyfieroni added a comment.


  So, Kai is right, it roundToIconSize only round size independent from dpi. 
Then when it used, it should be multiplyed by dpi.

REVISION DETAIL
  https://phabricator.kde.org/D7849

To: pgkos, #plasma
Cc: anthonyfieroni, broulik, #frameworks, davidedmundson, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D7849: Fix the tray icon scaling on HiDPI screens

2017-09-17 Thread Piotr Kosinski 
pgkos added a comment.


  @anthonyfieroni my first version of the diff changed only the tray icon QML 
file, but I think that it is better to fix it in the plasma framework, as that 
function is used in multiple other places and there is the same problem with 
wrongly sized icons on hidpi screens.

REVISION DETAIL
  https://phabricator.kde.org/D7849

To: pgkos, #plasma
Cc: anthonyfieroni, broulik, #frameworks, davidedmundson, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 74 - Still Unstable!

2017-09-17 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/74/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
 Date of build:
Sun, 17 Sep 2017 16:33:19 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.kateindenttest_testCstyle

D6103: scan the whole install folder for qml dependencies

2017-09-17 Thread patrick j pereira 
patrickelectric added a comment.


  I don't know if is related to this commit, but when compiling my application 
via kirigami with `make create-*` and uploading to my cellphone, a white screen 
appears.
  Using adb to debug with logcat, this error took my attention: 
`libatcore-gui.so: qrc:///main.qml:2 ((null)): qrc:///main.qml:2:1: module 
"QtQuick.Controls" plugin "qtquickcontrols2plugin" not found`, and than 
searching about it, this site took my attention 
.
  I don't know if it's a bug or related to this PR.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D6103

To: mart, apol
Cc: patrickelectric, #frameworks, #build_system

D7864: Basic support for PHP and Python fenced code blocks in Markdown

2017-09-17 Thread Grzegorz Szymaszek 
gszymaszek created this revision.
gszymaszek added a reviewer: KTextEditor.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  This patch enables syntax highlighting of PHP and Python code blocks in 
Markdown code.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  markdown-code-blocks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D7864

AFFECTED FILES
  data/syntax/markdown.xml

To: gszymaszek, #ktexteditor
Cc: kwrite-devel, #frameworks

D7864: Basic support for PHP and Python fenced code blocks in Markdown

2017-09-17 Thread Grzegorz Szymaszek 
gszymaszek added a subscriber: cfeck.
gszymaszek added a comment.


  Not ready to land, but uploaded per @cfeck’s suggestion (bug 356974 
).

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7864

To: gszymaszek, #ktexteditor
Cc: cfeck, kwrite-devel, #frameworks

D7864: Basic support for PHP and Python fenced code blocks in Markdown

2017-09-17 Thread Dominik Haumann 
dhaumann added a comment.


  Could you also extend the test case in
  
https://github.com/KDE/syntax-highlighting/blob/master/autotests/input/test.markdown
  
  This way, we can automatically guarantee that we will not break this feature 
accidentally.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7864

To: gszymaszek, #ktexteditor
Cc: dhaumann, cfeck, kwrite-devel, #frameworks

D7861: Support clojure's "@" macro with brackets

2017-09-17 Thread Dominik Haumann 
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.


  In general looks good, but 2 issues:
  
  1. Please increase the version number in the lab xml element.
  2. Please extend the unit test here: 
https://github.com/KDE/syntax-highlighting/blob/master/autotests/input/clojure.clj

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7861

To: koichia, dhaumann
Cc: dhaumann, #frameworks, cullmann, vkrause