D7864: Basic support for PHP and Python fenced code blocks in Markdown
gszymaszek updated this revision to Diff 19631. gszymaszek added a comment. - Removed JavaScript code blocks in Markdown support since it didn’t work - Added test cases for new code blocks in Markdown REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7864?vs=19622&id=19631 BRANCH markdown-code-blocks (branched from master) REVISION DETAIL https://phabricator.kde.org/D7864 AFFECTED FILES autotests/folding/example.rmd.fold autotests/folding/test.markdown.fold autotests/html/test.markdown.html autotests/input/test.markdown autotests/reference/test.markdown.ref data/syntax/markdown.xml To: gszymaszek, #ktexteditor Cc: dhaumann, cfeck, kwrite-devel, #frameworks
D7819: Add extra visual indicator for Checkbox/Radio keyboard focus
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D7819 To: davidedmundson, #plasma, #vdg, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7861: Support clojure's "@" macro with brackets
koichia updated this revision to Diff 19632. koichia added a comment. Hi, I updated the patch. However, some errors happen in clojure's test. These errors also happened in the previous revision. Start 1: appstreamtest 1/9 Test #1: appstreamtest Passed0.02 sec Start 2: wildcardmatcher_test 2/9 Test #2: wildcardmatcher_test . Passed0.01 sec Start 3: syntaxrepository_test 3/9 Test #3: syntaxrepository_test Passed0.46 sec Start 4: theme_test 4/9 Test #4: theme_test ... Passed0.01 sec Start 5: testhighlighter_test 5/9 Test #5: testhighlighter_test .***Failed1.80 sec Start 6: htmlhighlighter_test 6/9 Test #6: htmlhighlighter_test . Passed2.13 sec Start 7: folding_test 7/9 Test #7: folding_test . Passed2.52 sec Start 8: highlighter_benchmark 8/9 Test #8: highlighter_benchmark Passed3.06 sec Start 9: repository_benchmark 9/9 Test #9: repository_benchmark . Passed0.31 sec build/Testing/Temporary/LastTest.log: QWARN : TestHighlighterTest::testHighlight(clojure.clj) org.kde.ksyntaxhighlighting: Unknown format "String Char" in context "String" of definition "Clojure" QWARN : TestHighlighterTest::testHighlight(clojure.clj) org.kde.ksyntaxhighlighting: Unknown format "String Char" in context "String" of definition "Clojure" QWARN : TestHighlighterTest::testHighlight(clojure.clj) org.kde.ksyntaxhighlighting: Unknown format "DocumentationPossible" in context "DocumentationPossible" of definition "Clojure" QWARN : TestHighlighterTest::testHighlight(clojure.clj) org.kde.ksyntaxhighlighting: Unknown format "String Char" in context "String" of definition "Clojure" QWARN : TestHighlighterTest::testHighlight(clojure.clj) org.kde.ksyntaxhighlighting: Unknown format "String Char" in context "String" of definition "Clojure" QWARN : TestHighlighterTest::testHighlight(clojure.clj) org.kde.ksyntaxhighlighting: Unknown format "DocumentationPossible" in context "DocumentationPossible" of definition "Clojure" QWARN : TestHighlighterTest::testHighlight(clojure.clj) org.kde.ksyntaxhighlighting: Unknown format "Documentation Char" in context "Documentation" of definition "Clojure" QWARN : TestHighlighterTest::testHighlight(clojure.clj) org.kde.ksyntaxhighlighting: Unknown format "Documentation Char" in context "Documentation" of definition "Clojure" FAIL! : TestHighlighterTest::cleanupTestCase() 'coveredList.open(QFile::WriteOnly)' returned FALSE. () Loc: [/home/koichi/Desktop/kde-syntax-highlighting/syntax-highlighting/autotests/testhighlighter.cpp(103)] REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7861?vs=19610&id=19632 REVISION DETAIL https://phabricator.kde.org/D7861 AFFECTED FILES autotests/folding/clojure.clj.fold autotests/html/clojure.clj.html autotests/input/clojure.clj autotests/reference/clojure.clj.ref data/syntax/clojure.xml To: koichia, dhaumann Cc: dhaumann, #frameworks, cullmann, vkrause
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 78 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/78/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 18 Sep 2017 11:41:32 + Build duration: 1 min 55 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests
KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 82 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/82/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Mon, 18 Sep 2017 11:41:32 + Build duration: 4 min 29 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests Cobertura Report Project Coverage Summary Name Cobertura Coverage Report
[kdeclarative] src/qmlcontrols/kquickcontrolsaddons: Relicense some files to LGPL2.1+
Git commit db3bc821814117d765acec2d773ca6a1a40fddcd by Luca Beltrame. Committed on 18/09/2017 at 13:03. Pushed by lbeltrame into branch 'master'. Relicense some files to LGPL2.1+ This has been done with approval from the original authors (including myself). Some are still GPL-2.0. I will contact the author(s) to handle that. CCMAIL: m...@kde.org CCMAIL: h...@kde.org CCMAIL: k...@privat.broulik.de CCMAIL: kde-frameworks-devel@kde.org M +16 -17 src/qmlcontrols/kquickcontrolsaddons/eventgenerator.cpp M +17 -17 src/qmlcontrols/kquickcontrolsaddons/eventgenerator.h M +18 -18 src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp M +18 -18 src/qmlcontrols/kquickcontrolsaddons/kcmshell.h M +21 -20 src/qmlcontrols/kquickcontrolsaddons/qiconitem.h M +20 -19 src/qmlcontrols/kquickcontrolsaddons/qimageitem.h M +20 -19 src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h https://commits.kde.org/kdeclarative/db3bc821814117d765acec2d773ca6a1a40fddcd diff --git a/src/qmlcontrols/kquickcontrolsaddons/eventgenerator.cpp b/src/qmlcontrols/kquickcontrolsaddons/eventgenerator.cpp index b361e79..4931117 100644 --- a/src/qmlcontrols/kquickcontrolsaddons/eventgenerator.cpp +++ b/src/qmlcontrols/kquickcontrolsaddons/eventgenerator.cpp @@ -1,23 +1,22 @@ -/*** +/* * Copyright (C) 2015 by Eike Hein * Copyright (C) 2015 Marco Martin * - * * - * This program is free software; you can redistribute it and/or modify * - * it under the terms of the GNU General Public License as published by * - * the Free Software Foundation; either version 2 of the License, or * - * (at your option) any later version. * - * * - * This program is distributed in the hope that it will be useful, * - * but WITHOUT ANY WARRANTY; without even the implied warranty of* - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * - * GNU General Public License for more details. * - * * - * You should have received a copy of the GNU General Public License * - * along with this program; if not, write to the * - * Free Software Foundation, Inc., * - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA .* - ***/ + *This library is free software; you can redistribute it and/or + *modify it under the terms of the GNU Library General Public + *License as published by the Free Software Foundation; either + *version 2 of the License, or (at your option) any later version. + * + *This library is distributed in the hope that it will be useful, + *but WITHOUT ANY WARRANTY; without even the implied warranty of + *MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + *Library General Public License for more details. + * + *You should have received a copy of the GNU Library General Public License + *along with this library; see the file COPYING.LIB. If not, write to + *the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, + *Boston, MA 02110-1301, USA. + */ #include "eventgenerator.h" diff --git a/src/qmlcontrols/kquickcontrolsaddons/eventgenerator.h b/src/qmlcontrols/kquickcontrolsaddons/eventgenerator.h index 402a964..d456a76 100644 --- a/src/qmlcontrols/kquickcontrolsaddons/eventgenerator.h +++ b/src/qmlcontrols/kquickcontrolsaddons/eventgenerator.h @@ -1,23 +1,23 @@ -/*** +/* * Copyright (C) 2015 by Eike Hein * Copyright (C) 2015 Marco Martin * - * * - * This program is free software; you can redistribute it and/or modify * - * it under the terms of the GNU General Public License as published by * - * the Free Software Foundation; either version 2 of the License, or * - * (at your option) any later version. * - * * - * This program is distributed in the hope that it will be useful, * - * but WITHOUT ANY WARRANTY; without even the implied warranty of* - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * - * GNU General Public License for more details. * - * * - * You should have received a copy of the GNU General Public License * - * along with this program; if not, write to t
KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 112 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/112/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 18 Sep 2017 13:14:14 + Build duration: 5 min 19 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest
KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 108 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/108/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Mon, 18 Sep 2017 13:14:14 + Build duration: 9 min 28 sec and counting JUnit Tests Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report86% (6/7)62% (57/92)62% (57/92)38% (3492/9218)26% (1857/7148)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (22/22)100% (22/22)76% (607/795)38% (390/1028)src.declarativeimports.core57% (4/7)57% (4/7)28% (245/880)14% (85/618)src.plasma62% (13/21)62% (13/21)40% (1412/3572)29% (772/2695)src.plasma.private46% (11/24)46% (11/24)39% (649/1649)28% (303/1080)src.plasma.scripting0% (0/3)0% (0/3)0% (0/190)0% (0/126)src.plasmaquick50% (6/12)50% (6/12)27% (548/2019)19% (301/1579)src.plasmaquick.private33% (1/3)33% (1/3)27% (31/113)27% (6/22)
Re: Request for relicense: kdeclarative/src/calendarevents/*
Hey Luca, On Mon, Sep 18, 2017 at 9:09 AM, Luca Beltrame wrote: > Hello Martin, > > In kdeclarative, there are 3 files which bear your authorship: > > kdeclarative/src/calendarevents/calendareventsplugin.cpp > kdeclarative/src/calendarevents/calendareventsplugin.h > kdeclarative/src/calendarevents/eventdata_p.cpp > > These are GPL 2+ licensed. Unless there is a good reason for you to have > them > like that, would you mind giving permission to relicense them as LGPL2.1+ > like > the rest of the kdeclarative framework? > > This discrepancy was found when doing a license review as part of the > openSUSE > package submission process. > > Thanks. > Absolutely, I hereby give you the permission to relicense those files to LGPL2.1+. CC'ing frameworks devel to retain a public record of that. Cheers -- Martin Klapetek
Re: Request for relicense: kdeclarative/src/calendarevents/*
In data lunedì 18 settembre 2017 15:32:16 CEST, Martin Klapetek ha scritto: > Absolutely, I hereby give you the permission to relicense those files to > LGPL2.1+. > CC'ing frameworks devel to retain a public record of that. Thanks a lot! -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: A29D259B signature.asc Description: This is a digitally signed message part.
[kdeclarative] src/calendarevents: Relicense to LGPL2.1+ (part 2)
Git commit 62b8e461f2e5979180e1753651cc34dc5f3eb3b7 by Luca Beltrame. Committed on 18/09/2017 at 13:39. Pushed by lbeltrame into branch 'master'. Relicense to LGPL2.1+ (part 2) Permission granted by the author (Martin Klapetek) CCMAIL: martin.klape...@gmail.com CCMAIL: kde-frameworks-devel@kde.org M +17 -17 src/calendarevents/calendareventsplugin.cpp M +17 -17 src/calendarevents/calendareventsplugin.h M +17 -17 src/calendarevents/eventdata_p.cpp https://commits.kde.org/kdeclarative/62b8e461f2e5979180e1753651cc34dc5f3eb3b7 diff --git a/src/calendarevents/calendareventsplugin.cpp b/src/calendarevents/calendareventsplugin.cpp index bb528d8..6342fde 100644 --- a/src/calendarevents/calendareventsplugin.cpp +++ b/src/calendarevents/calendareventsplugin.cpp @@ -1,21 +1,21 @@ /* -Copyright (C) 2015 Martin Klapetek - -This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or -(at your option) any later version. - -This program is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. - -You should have received a copy of the GNU General Public License along -with this program; if not, write to the Free Software Foundation, Inc., -51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - -*/ + *Copyright 2015 Martin Klapetek + * + *This library is free software; you can redistribute it and/or + *modify it under the terms of the GNU Library General Public + *License as published by the Free Software Foundation; either + *version 2 of the License, or (at your option) any later version. + * + *This library is distributed in the hope that it will be useful, + *but WITHOUT ANY WARRANTY; without even the implied warranty of + *MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + *Library General Public License for more details. + * + *You should have received a copy of the GNU Library General Public License + *along with this library; see the file COPYING.LIB. If not, write to + *the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, + *Boston, MA 02110-1301, USA. + */ #include "calendareventsplugin.h" diff --git a/src/calendarevents/calendareventsplugin.h b/src/calendarevents/calendareventsplugin.h index 4e3f886..b0866aa 100644 --- a/src/calendarevents/calendareventsplugin.h +++ b/src/calendarevents/calendareventsplugin.h @@ -1,21 +1,21 @@ /* -Copyright (C) 2015 Martin Klapetek - -This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or -(at your option) any later version. - -This program is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. - -You should have received a copy of the GNU General Public License along -with this program; if not, write to the Free Software Foundation, Inc., -51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - -*/ + *Copyright 2015 Martin Klapetek + * + *This library is free software; you can redistribute it and/or + *modify it under the terms of the GNU Library General Public + *License as published by the Free Software Foundation; either + *version 2 of the License, or (at your option) any later version. + * + *This library is distributed in the hope that it will be useful, + *but WITHOUT ANY WARRANTY; without even the implied warranty of + *MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + *Library General Public License for more details. + * + *You should have received a copy of the GNU Library General Public License + *along with this library; see the file COPYING.LIB. If not, write to + *the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, + *Boston, MA 02110-1301, USA. + */ #ifndef CALENDAREVENTSPLUGIN_H #define CALENDAREVENTSPLUGIN_H diff --git a/src/calendarevents/eventdata_p.cpp b/src/calendarevents/eventdata_p.cpp index 51c1c43..d998959 100644 --- a/src/calendarevents/eventdata_p.cpp +++ b/src/calendarevents/eventdata_p.cpp @@ -1,21 +1,21 @@ /* -Copyright (C) 2015 Martin Klapetek - -This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or -(at your option) any later version. - -
D7861: Support clojure's "@" macro with brackets
dhaumann closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7861 To: koichia, dhaumann Cc: dhaumann, #frameworks, cullmann, vkrause
D7861: Support clojure's "@" macro with brackets
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks, closed with https://cgit.kde.org/syntax-highlighting.git/commit/?id=2d5ee5629eb9638a56bae56e9210d5757fb7bafe REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7861 To: koichia, dhaumann Cc: dhaumann, #frameworks, cullmann, vkrause
D7861: Support clojure's "@" macro with brackets
dhaumann added a comment. @koichia For me, the unit tests pass. And it's also green on https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/97/ REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7861 To: koichia, dhaumann Cc: dhaumann, #frameworks, cullmann, vkrause
D7245: Improve reStructuredText highlighting
dhaumann added a comment. @turbov ping REVISION DETAIL https://phabricator.kde.org/D7245 To: turbov, #kate, #framework_syntax_highlighting, dhaumann Cc: cullmann, dhaumann, #frameworks
D7870: Don't crash if a client (legally) uses a deleted global
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY There is a race condition in the following situation: - Server creates a global - Client binds to that global (making a new resource for that global) Simultaneously: - The client uses this resource - The server deletes the global We then process an event for a resource linked to a deleted global. This is noted in the specification, the client documentation says: "The object remains valid and requests to the object will be ignored until the client destroys it, to avoid races between the global going away and a client sending a request to it. " KWayland does not handle this at all. The global's user data refer to our C++ wrapper The resource's user data refer to *the same* C++ wrapper When the global is deleted the resource user data now refers to garbage. To fix the issue, instead of setting the resource userdata to the global, we set it to a smartpointer to the global stored on the heap. We can then validate if our global is still valid. Theoretically this applies to every global Practically there are only 3 globals that don't have the lifespan of the server. Output (which is read only and doesn't matter), Blur and BackgroundContrast. Blur resets it's global when a screen geometry changes. Unfotunately this exactly at the same time that Plasmashell is doing a lot of processing and creating some blurs. TEST PLAN See unit test REPOSITORY R127 KWayland BRANCH globalref REVISION DETAIL https://phabricator.kde.org/D7870 AFFECTED FILES autotests/client/test_wayland_registry.cpp src/server/blur_interface.cpp To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
D7660: Fix a regression caused by changing backspace key behavior
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
I think one further revision would be helpful, then the patch should be good
to go in.
INLINE COMMENTS
> navigationconfigwidget.ui:138
> +
> + When selected, composed characters are removed with thier
> diacritics instead of only removing the base character. This is useful for
> Indic locales.
> +
Typo: their instead of thier.
> navigationconfigwidget.ui:141
> +
> + Backspace key removes character’s base with it’s
> diacritics
> +
Typo: its instead of it's
> katedocument.cpp:3172
> +KTextEditor::Cursor beginCursor(line, 0);
> +if (!view->config()->backspaceRemoveComposed()) { // Normal
> backspace behavior
> +beginCursor.setColumn(col - 1);
I would prefer to have this if() only once:
KTextEditor::Cursor beginCursor(line, 0);
KTextEditor::Cursor endCursor(line, col);
if (!view->config()->backspaceRemoveComposed()) { // Normal backspace behavior
beginCursor.setColumn(col - 1);
// move to left of surrogate pair
if (!isValidTextPosition(beginCursor)) {
Q_ASSERT(col >= 2);
beginCursor.setColumn(col - 2);
}
} else {
beginCursor.setColumn(view->textLayout(c)->previousCursorPosition(c.column()));
}
> katedocument.cpp:3208
> } else {
> -KTextEditor::Cursor beginCursor(line,
> view->textLayout(c)->previousCursorPosition(c.column()));
> +KTextEditor::Cursor beginCursor(line, 0);
> +if (!view->config()->backspaceRemoveComposed()) { // Normal
> backspace behavior
Same here: Please if() case only once, which leads to less convoluted code.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7660
To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann
Cc: jgrulich, dhaumann, hein, kwrite-devel, #frameworks
D7870: Don't crash if a client (legally) uses a deleted global
davidedmundson updated this revision to Diff 19645. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. Mem leak in test REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7870?vs=19644&id=19645 BRANCH globalref REVISION DETAIL https://phabricator.kde.org/D7870 AFFECTED FILES autotests/client/test_wayland_registry.cpp src/server/blur_interface.cpp To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7167: Ignore default mark in icon border for single selectable mark
dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. I think the patch makes sense, but I would prefer using a Qt function qPopulationCount to count the bits instead of doing own bitmask magic. Could you provide an updated patch? INLINE COMMENTS > kateviewhelpers.cpp:2145 > +const uint singleMark = // is the default or the only > editable mark > +(editBits & (editBits - 1)) ? // true if number of > editable marks > 1 > +editBits & config->defaultMarkType() : I would prefer using qPopulationCounte (see http://doc.qt.io/qt-5/qtalgorithms.html#qPopulationCount): // is the default or the only editable mark const uint singleMark = (qPopulationCount(editBits) > 1) ? editBits & config->defaultMarkType() : editBits; REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7167 To: croick, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, #frameworks
D7872: Let qmake highlighting win over Prolog for .pro files
dhaumann created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY See bug: https://bugs.kde.org/show_bug.cgi?id=383349 TEST PLAN make test REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7872 AFFECTED FILES data/syntax/qmake.xml To: dhaumann Cc: #frameworks
D7872: Let qmake highlighting win over Prolog for .pro files
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7872 To: dhaumann, vkrause Cc: #frameworks
D7872: Let qmake highlighting win over Prolog for .pro files
This revision was automatically updated to reflect the committed changes. Closed by commit R216:aafd891ada94: Let qmake highlighting win over Prolog for .pro files (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7872?vs=19647&id=19648 REVISION DETAIL https://phabricator.kde.org/D7872 AFFECTED FILES data/syntax/qmake.xml To: dhaumann, vkrause Cc: #frameworks
D7870: Don't crash if a client (legally) uses a deleted global
anthonyfieroni added inline comments.
INLINE COMMENTS
> blur_interface.cpp:49
> static Private *cast(wl_resource *r) {
> -return reinterpret_cast(wl_resource_get_user_data(r));
> +auto blurManager =
> reinterpret_cast*>(wl_resource_get_user_data(r))->data();
> +if (blurManager) {
QPointer itself can determine that resource is deleted but QPointer* acts like
every normal pointer e.g. it can be dangling. So if unbind is called before
cast this line will crash.
> blur_interface.cpp:89
> {
> -Q_UNUSED(resource)
> -// TODO: implement?
> +delete
> reinterpret_cast*>(wl_resource_get_user_data(r));
> }
To work your idea this line should be
delete
reinterpret_cast*>(wl_resource_get_user_data(r))->data()
QPointer *should* live to not be dangling in cast, so you can have a static map
resource to QPointer* then you can update and delete them at server die.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7870
To: davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7870: Don't crash if a client (legally) uses a deleted global
davidedmundson marked 2 inline comments as done. davidedmundson added inline comments. INLINE COMMENTS > anthonyfieroni wrote in blur_interface.cpp:49 > QPointer itself can determine that resource is deleted but QPointer* acts > like every normal pointer e.g. it can be dangling. So if unbind is called > before cast this line will crash. I'm not going to get a callback on a resource if the resource doesn't exist. (Libwayland would have already crashed if that happens) That's not what we're guarding against here. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7870 To: davidedmundson, #plasma Cc: anthonyfieroni, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7870: Don't crash if a client (legally) uses a deleted global
graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. What surprises me is that BlurManager recreates for Output changes. That sounds like a bug in KWin (or an area which could be improved). REPOSITORY R127 KWayland BRANCH globalref REVISION DETAIL https://phabricator.kde.org/D7870 To: davidedmundson, #plasma, graesslin Cc: graesslin, anthonyfieroni, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7870: Don't crash if a client (legally) uses a deleted global
anthonyfieroni added inline comments. INLINE COMMENTS > davidedmundson wrote in blur_interface.cpp:49 > I'm not going to get a callback on a resource if the resource doesn't exist. > (Libwayland would have already crashed if that happens) > > That's not what we're guarding against here. I don't get that. So your patch is quite enough, treat this note as a noise :) REPOSITORY R127 KWayland BRANCH globalref REVISION DETAIL https://phabricator.kde.org/D7870 To: davidedmundson, #plasma, graesslin Cc: graesslin, anthonyfieroni, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
KDE CI: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7 - Build # 1 - Successful!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20FreeBSDQt5.7/1/ Project: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 18 Sep 2017 19:11:59 + Build duration: 30 sec and counting
D7870: Don't crash if a client (legally) uses a deleted global
graesslin added inline comments. INLINE COMMENTS > anthonyfieroni wrote in blur_interface.cpp:49 > I don't get that. So your patch is quite enough, treat this note as a noise :) The cast method here is only called from callbacks. Wayland works by having a global callback table where one just gets a wl_resource pointer which contains a reference to a user data. As long as the client doesn't call unbind on the wl_resource the pointer cannot dangle. That's why it won't happen here. REPOSITORY R127 KWayland BRANCH globalref REVISION DETAIL https://phabricator.kde.org/D7870 To: davidedmundson, #plasma, graesslin Cc: graesslin, anthonyfieroni, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
KDE CI: Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9 - Build # 1 - Successful!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20WindowsMSVCQt5.9/1/ Project: Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9 Date of build: Mon, 18 Sep 2017 19:12:00 + Build duration: 1 min 15 sec and counting
KDE CI: Frameworks qqc2-desktop-style kf5-qt5 XenialQt5.7 - Build # 1 - Successful!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20XenialQt5.7/1/ Project: Frameworks qqc2-desktop-style kf5-qt5 XenialQt5.7 Date of build: Mon, 18 Sep 2017 19:12:02 + Build duration: 1 min 29 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s) Cobertura Report Project Coverage Summary Name Cobertura Coverage Report
kde-frameworks-devel@kde.org
ltoscano created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Definitely not needed. A bit less clutter before switching to categorized logging. TEST PLAN Still compiles, and the debug output does not contain extra newlines. REPOSITORY R313 KHtml BRANCH debug-no-endl REVISION DETAIL https://phabricator.kde.org/D7875 AFFECTED FILES src/css/css_base.cpp src/css/css_valueimpl.cpp src/css/cssparser.cpp src/css/cssstyleselector.cpp src/dom/QualifiedName.cpp src/ecma/kjs_html.cpp src/editing/editor.cpp src/editing/htmlediting_impl.cpp src/editing/jsediting.cpp src/html/html_elementimpl.cpp src/html/htmlparser.cpp src/html/htmltokenizer.cpp src/imload/decoders/qimageioloader.cpp src/java/kjavaapplet.cpp src/java/kjavaappletcontext.cpp src/java/kjavaappletserver.cpp src/java/kjavaappletwidget.cpp src/java/kjavadownloader.cpp src/java/kjavaprocess.cpp src/khtml_caret.cpp src/khtml_part.cpp src/khtmlview.cpp src/rendering/RenderPath.cpp src/rendering/RenderSVGInlineText.cpp src/rendering/RenderSVGRoot.cpp src/rendering/RenderSVGText.cpp src/rendering/SVGInlineTextBox.cpp src/rendering/SVGRootInlineBox.cpp src/rendering/bidi.cpp src/rendering/render_block.cpp src/rendering/render_container.cpp src/rendering/render_flow.cpp src/rendering/render_form.cpp src/rendering/render_object.cpp src/rendering/render_position.cpp src/rendering/render_replaced.cpp src/rendering/render_table.cpp src/rendering/render_text.cpp src/svg/SVGDocumentExtensions.cpp src/svg/SVGElement.cpp src/svg/SVGGradientElement.cpp src/svg/SVGLinearGradientElement.cpp src/svg/SVGPolyElement.cpp src/svg/SVGRectElement.cpp src/svg/SVGSVGElement.cpp src/svg/SVGStopElement.cpp src/svg/SVGStyleElement.cpp src/svg/SVGTextElement.cpp src/svg/SVGTextPositioningElement.cpp src/svg/SVGURIReference.cpp src/svg/graphics/SVGPaintServerLinearGradient.cpp src/svg/graphics/qt/SVGPaintServerGradientQt.cpp src/svg/graphics/qt/SVGPaintServerRadialGradientQt.cpp src/ui/findbar/khtmlfind.cpp src/xml/dom_docimpl.cpp src/xml/dom_elementimpl.cpp src/xml/dom_position.cpp src/xml/dom_selection.cpp tests/test_regression_gui_window.cpp To: ltoscano Cc: #frameworks
D7245: Improve reStructuredText highlighting
turbov added a comment. In https://phabricator.kde.org/D7245#146719, @dhaumann wrote: > @turbov ping pong... I wanted to make some improvements... And it would be nice to have some hint about how to add the mentioned tests... REVISION DETAIL https://phabricator.kde.org/D7245 To: turbov, #kate, #framework_syntax_highlighting, dhaumann Cc: cullmann, dhaumann, #frameworks
