KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 94 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/94/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Sun, 01 Oct 2017 03:11:56 + Build duration: 5 min 6 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests Cobertura Report Project Coverage Summary Name Cobertura Coverage Report
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 89 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/89/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 01 Oct 2017 03:11:56 + Build duration: 2 min 1 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests
KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 31 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/31/ Project: Frameworks baloo kf5-qt5 XenialQt5.7 Date of build: Sat, 30 Sep 2017 20:00:01 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (12/12)77% (111/144)77% (111/144)73% (5039/6932)50% (2613/5194)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.benchmarks100% (2/2)100% (2/2)100% (42/42)89% (16/18)autotests.integration100% (3/3)100% (3/3)95% (242/255)64% (140/220)autotests.unit.codecs100% (3/3)100% (3/3)100% (40/40)57% (25/44)autotests.unit.engine100% (17/17)100% (17/17)100% (736/736)53% (390/740)autotests.unit.file100% (11/11)100% (11/11)97% (788/809)51% (438/864)autotests.unit.lib100% (6/6)100% (6/6)97% (315/326)52% (156/302)src.codecs100% (5/5)100% (5/5)87% (120/138)76% (32/42)src.engine97% (38/39)97% (38/39)79% (1607/2038)58% (796/1379)src.file39% (17/44)39% (17/44)45% (678/1506)38% (374/980)src.file.extractor100% (2/2)100% (2/2)69% (20/29)58% (7/12)src.file.extractor.autotests100% (1/1)100% (1/1)100% (22/22)61% (11/18)src.lib55% (6/11)55% (6/11)43% (429/991)40% (228/575)
D7330: Don't enter test subdirectories if BUILD_TESTING=OFF
asturmlechner closed this revision. asturmlechner added a comment. Thanks! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D7330 To: asturmlechner, #frameworks, dfaure, mgallien
D8042: Fix invalid itemData references of 57 highlighting files
dhaumann closed this revision. dhaumann added a comment. Closed with https://commits.kde.org/syntax-highlighting/164cac777fdf6911a52aba440277bc1d25406bc4 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D8042 To: dhaumann, vkrause, cullmann Cc: #frameworks
D8076: nfs: Skip mounts with no permission
z3ntu edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D8076 To: z3ntu, #frameworks, dfaure, davidedmundson Cc: ltoscano, ngraham
D7771: Fix memory leak
aacid closed this revision. REPOSITORY R279 ThreadWeaver REVISION DETAIL https://phabricator.kde.org/D7771 To: aacid, mirko, davidedmundson Cc: #frameworks
D8043: KDirWatch : make methods virtual
rjvbb abandoned this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D8043 To: rjvbb, #frameworks, mwolff, dfaure Cc: dhaumann, cfeck, dfaure, mwolff, kde-frameworks-devel
D8077: Fix org.kde.plasma.calendar with Qt 5.10
fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Module internal types are not implicitly available anymore simply by placing them inside the module's main directory. It is now necessary to mention them as internal types in the qmldir file. See qtdeclarative commits 22a2cc43387ec3b9f74a6c01f8665378a4541147 (introduced the change) and 930aea8b9ca59a24838cf7f279653e3b2ee40cee (explanation) TEST PLAN Built whole stack with Qt 5.10. The digital clock plasmoid does not load due to the DaysCalendar type not being available. With these changes to qmldir and a reload of the plasmoid it works. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D8077 AFFECTED FILES src/declarativeimports/calendar/qml/qmldir To: fvogt, #plasma Cc: #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8076: nfs: Skip mounts with no permission
ltoscano added a comment. As mentioned on IRC, this is a starting point but maybe the logic should be changed so that there is no error on connection is at least a mount point is accessible; the error should be on access. PS: changes to the commit message in the git patch are not reflected in the review, you should edit it from the web interface. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D8076 To: z3ntu, #frameworks, dfaure, davidedmundson Cc: ltoscano, ngraham
D8056: Improve usability of "Open With" dialog by adding option to filter the application tree
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I gave this a shot and it's an excellent change--a huge improvement over the status quo. I have two suggestions for further ergonomic refinement: - When the text field has focus, make the down arrow key move to the list of found result so that you can select one with the keyboard and not have to use the mouse at all - Pre-select the top result in the list so that you can immediately hit the return key to select that application REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: ngraham, alexeymin, #frameworks
D8076: nfs: Skip mounts with no permission
z3ntu updated this revision to Diff 20163. z3ntu added a comment. Add the bug keyword REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8076?vs=20160=20163 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8076 AFFECTED FILES nfs/nfsv3.cpp To: z3ntu, #frameworks, dfaure, davidedmundson Cc: ngraham
D8076: nfs: Skip mounts with no permission
z3ntu added a comment.
Well as we don't add failed mounts to the `failList` (if they fail because of
13 / MNT3ERR_ACCES) so the line `if (failList.size() == exportsCount) {` won't
work then.
Will add the bug keyword. Didn't know BugZilla and Phabricator were connected
:)
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D8076
To: z3ntu, #frameworks, dfaure, davidedmundson
Cc: ngraham
D8076: nfs: Skip mounts with no permission
ngraham added reviewers: Frameworks, dfaure, davidedmundson. ngraham added a comment. Thanks for the patch! Instead of a bugzilla link, you can just use a special keyword: "BUG: 375249" This will ensure that the bug gets closed once the patch is accepted and merged. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D8076 To: z3ntu, #frameworks, dfaure, davidedmundson Cc: ngraham
D8064: Correct installation of start_kdeinit when DESTDIR and libcap are used together
elvisangelaccio added a reviewer: dfaure. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D8064 To: awilcox, dfaure Cc: #frameworks
D7771: Fix memory leak
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R279 ThreadWeaver BRANCH master REVISION DETAIL https://phabricator.kde.org/D7771 To: aacid, mirko, davidedmundson Cc: #frameworks
KDE CI: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 - Build # 31 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/31/ Project: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 Date of build: Sat, 30 Sep 2017 13:07:50 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed: 7 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-compositingenabled_testFailed: TestSuite.kwindowsystem-kwindoweffectstestFailed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-kwindowsystem_threadtestFailed: TestSuite.kwindowsystem-kwindowsystemplatformwaylandtestFailed: TestSuite.kwindowsystem-kwindowsystemx11testFailed: TestSuite.kwindowsystem-netrootinfotestwm Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report75% (3/4)80% (35/44)80% (35/44)71% (5680/8023)47% (2989/6308)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (15/15)100% (15/15)84% (2556/3036)43% (1335/3129)src69% (11/16)69% (11/16)50% (715/1434)36% (258/712)src.platforms.wayland0% (0/2)0% (0/2)0% (0/89)0% (0/2)src.platforms.xcb82% (9/11)82% (9/11)70% (2409/3464)57% (1396/2465)
KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.7 - Build # 24 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.7/24/ Project: Frameworks kpty kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 30 Sep 2017 13:13:45 + Build duration: 1 min 38 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.kptyprocesstest
D8070: Fix build with Qt 5.10
This revision was automatically updated to reflect the committed changes. Closed by commit R291:baad91bc2c45: Fix build with Qt 5.10 (authored by fvogt). REPOSITORY R291 KPty CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8070?vs=20145=20151 REVISION DETAIL https://phabricator.kde.org/D8070 AFFECTED FILES src/kpty_p.h To: fvogt, #frameworks, lbeltrame Cc: lbeltrame, #frameworks
KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.7 - Build # 30 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.7/30/ Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 30 Sep 2017 13:07:50 + Build duration: 3 min 48 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: TestSuite.kwindowsystem-netrootinfotestwm
D8069: Fix build with Qt 5.10
This revision was automatically updated to reflect the committed changes. Closed by commit R278:ec6eec156604: Fix build with Qt 5.10 (authored by fvogt). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8069?vs=20144=20150 REVISION DETAIL https://phabricator.kde.org/D8069 AFFECTED FILES src/platforms/xcb/kxerrorhandler.cpp To: fvogt, #frameworks, graesslin, lbeltrame Cc: lbeltrame, #frameworks
D8070: Fix build with Qt 5.10
lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. LGTM. REPOSITORY R291 KPty BRANCH master REVISION DETAIL https://phabricator.kde.org/D8070 To: fvogt, #frameworks, lbeltrame Cc: lbeltrame, #frameworks
D8069: Fix build with Qt 5.10
lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. Trivial change, LGTM. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D8069 To: fvogt, #frameworks, graesslin, lbeltrame Cc: lbeltrame, #frameworks
D7330: Don't enter test subdirectories if BUILD_TESTING=OFF
mgallien accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D7330 To: asturmlechner, #frameworks, dfaure, mgallien
D7330: Don't enter test subdirectories if BUILD_TESTING=OFF
asturmlechner added a reviewer: dfaure. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D7330 To: asturmlechner, #frameworks, dfaure
D8070: Fix build with Qt 5.10
fvogt created this revision. fvogt added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY QByteArray does not include QString anymore, but QString is used in k_pty.h TEST PLAN Did not build before, now does. REPOSITORY R291 KPty BRANCH master REVISION DETAIL https://phabricator.kde.org/D8070 AFFECTED FILES src/kpty_p.h To: fvogt, #frameworks Cc: #frameworks
D8069: Fix build with Qt 5.10
fvogt created this revision. fvogt added reviewers: Frameworks, graesslin. Restricted Application added a project: Frameworks. REVISION SUMMARY QByteArray does not include QString anymore, but that is needed in kxerrorhandler.cpp due to usage of operator overloads. TEST PLAN Did not build before, now builds. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D8069 AFFECTED FILES src/platforms/xcb/kxerrorhandler.cpp To: fvogt, #frameworks, graesslin Cc: #frameworks
D7771: Fix memory leak
aacid added a comment. Ping, i'll commit this in two weeks unless anyone disagrees. REPOSITORY R279 ThreadWeaver REVISION DETAIL https://phabricator.kde.org/D7771 To: aacid, mirko Cc: #frameworks
D7771: Fix memory leak
aacid retitled this revision from "Fix leak in autotests/ThreadWeaverQueueTests" to "Fix memory leak". aacid edited the test plan for this revision. REPOSITORY R279 ThreadWeaver REVISION DETAIL https://phabricator.kde.org/D7771 To: aacid, mirko Cc: #frameworks
