KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 111 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/111/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Mon, 02 Oct 2017 03:02:17 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (22/22)80% (278/346)80% (278/346)57% (30005/52248)42% (16579/39291)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (67/67)100% (67/67)96% (8078/8399)51% (4502/8824)autotests.http100% (9/9)100% (9/9)100% (543/544)60% (200/336)autotests.kcookiejar100% (1/1)100% (1/1)90% (179/198)67% (60/90)src.core85% (99/117)85% (99/117)58% (8187/14198)49% (4569/9279)src.core.kssl100% (1/1)100% (1/1)38% (35/93)50% (3/6)src.filewidgets73% (27/37)73% (27/37)46% (3502/7603)30% (1301/4403)src.gui100% (2/2)100% (2/2)95% (104/110)75% (54/72)src.ioslaves.file100% (2/2)100% (2/2)51% (435/849)42% (317/749)src.ioslaves.http100% (8/8)100% (8/8)47% (1770/3781)38% (1326/3462)src.ioslaves.http.kcookiejar100% (2/2)100% (2/2)80% (622/782)72% (608/839)src.ioslaves.remote100% (2/2)100% (2/2)27% (70/258)8% (16/200)src.ioslaves.trash80% (8/10)80% (8/10)60% (704/1173)47% (404/851)src.ioslaves.trash.tests100% (2/2)100% (2/2)90% (707/785)48% (461/970)src.kioslave100% (1/1)100% (1/1)52% (14/27)50% (5/10)src.kntlm100% (2/2)100% (2/2)97% (373/385)80% (111/138)src.kpasswdserver100% (2/2)100% (2/2)63% (372/594)48% (276/580)src.kpasswdserver.autotests100% (1/1)100% (1/1)99% (283/286)56%
D8098: Strip down and re-write the tags KIO slave.
smithjd added a comment. Copying/cutting file tags works both from local files and also tagged files. Breaking tags works, e.g. nested tag foo in bar can be copied or cut to foobar/barfoo tag path. Cutting and pasting a file folder results in a new tag on the folder, copying applies the destination path + file path as a tag to all files recursively inside that folder. Deleting tags removes the tag from the file or directory. Making new directories / tags is possible, entering the directory results in an error and the directory disappears. Copying or cutting tags into this directory must happen before it's entered. Previews work, and a bug that caused nested tags to show up in similary named tag folders was also fixed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks, vhanda Cc: ngraham
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 112 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/112/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 02 Oct 2017 03:02:17 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: TestSuite.kiocore-ktcpsockettest
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 90 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/90/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 02 Oct 2017 03:02:33 + Build duration: 8 min 44 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests
D8098: Strip down and re-write the tags KIO slave.
ngraham added a reviewer: vhanda. ngraham added a comment. Oh, I'm a dolt. I was trying to apply this to KIO, not Baloo. Ignore me; works fine when you're not holding it wrong. :) REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks, vhanda Cc: ngraham
KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 95 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/95/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Mon, 02 Oct 2017 03:02:33 + Build duration: 1 min 41 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests Cobertura Report Project Coverage Summary Name Cobertura Coverage Report
D8098: Strip down and re-write the tags KIO slave.
smithjd added a comment. Maybe update your local repo? It is against the most recent commit in master. It was diff'ed from a non-master branch... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks Cc: ngraham
D8098: Strip down and re-write the tags KIO slave.
ngraham added a comment. Fantastic work. I wasn't able to apply it with `arc`, though: This diff is against commit 9383ea8927579555301eb378c1ce299dde2a2d08, but the commit is nowhere in the working copy. Try to apply it against the current working copy state? (e58d6ab06561e455576375e03cb25dd18fd4089f) Can you rebase the diff against current git master? Also, can you add some details of your testing? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks Cc: ngraham
D8098: Strip down and re-write the tags KIO slave.
smithjd created this revision. smithjd added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY Allow for more operations on tag trees (e.g. rename, copy, delete) and fix some existing issues. BUG: 314373 BUG: 340098 BUG: 376229 BUG: 332214 BUG: 340099 REPOSITORY R293 Baloo BRANCH master-nestedTags (branched from master) REVISION DETAIL https://phabricator.kde.org/D8098 AFFECTED FILES src/kioslaves/tags/kio_tags.cpp src/kioslaves/tags/kio_tags.h src/kioslaves/tags/tags.protocol To: smithjd, #frameworks
D8077: Fix org.kde.plasma.calendar with Qt 5.10
fvogt added a comment. In https://phabricator.kde.org/D8077#151362, @broulik wrote: > Meh. > > I suspect there are other modules affected as well? I'm not sure, I didn't test anything beyond the default plasma configuration. A quick scan with a script showed mostly false positives, but also > ./qml/org/kde/plasma/components.3/CheckIndicator.qml > ./qml/org/kde/plasma/components.3/RadioIndicator.qml So it probably needs to be fixed for those as well. I'm not sure where those are actually used. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8077 To: fvogt, #plasma, broulik Cc: broulik, #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8084: KAutoSaveFile breaks if source file name contains a space!
mardelle updated this revision to Diff 20216. mardelle added a comment. Added test to check stale file is correctly found REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8084?vs=20180=20216 REVISION DETAIL https://phabricator.kde.org/D8084 AFFECTED FILES autotests/kautosavefiletest.cpp src/lib/io/kautosavefile.cpp To: mardelle, #frameworks, shaforostoff Cc: ltoscano
KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 125 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/125/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 01 Oct 2017 21:06:55 + Build duration: 5 min 10 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest
KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 121 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/121/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Sun, 01 Oct 2017 21:06:55 + Build duration: 4 min 35 sec and counting JUnit Tests Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report86% (6/7)62% (57/92)62% (57/92)38% (3493/9222)26% (1859/7152)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (22/22)100% (22/22)76% (607/795)38% (390/1028)src.declarativeimports.core57% (4/7)57% (4/7)28% (246/883)14% (86/620)src.plasma62% (13/21)62% (13/21)40% (1412/3573)29% (773/2697)src.plasma.private46% (11/24)46% (11/24)39% (649/1649)28% (303/1080)src.plasma.scripting0% (0/3)0% (0/3)0% (0/190)0% (0/126)src.plasmaquick50% (6/12)50% (6/12)27% (548/2019)19% (301/1579)src.plasmaquick.private33% (1/3)33% (1/3)27% (31/113)27% (6/22)
D8077: Fix org.kde.plasma.calendar with Qt 5.10
This revision was automatically updated to reflect the committed changes. Closed by commit R242:4f43c236e34e: Fix org.kde.plasma.calendar with Qt 5.10 (authored by fvogt). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8077?vs=20165=20213 REVISION DETAIL https://phabricator.kde.org/D8077 AFFECTED FILES src/declarativeimports/calendar/qml/qmldir To: fvogt, #plasma, broulik Cc: broulik, #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7829: Fix kglobalaccel regression on Alt+Shift+arrowkey.
dfaure updated this revision to Diff 20212. dfaure added a comment. Add unittest for Alt+Tab and Alt+Shift+Tab, passes. Real-world testing passed too. REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7829?vs=20066=20212 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7829 AFFECTED FILES autotests/CMakeLists.txt autotests/kkeyserver_x11_unittest.cpp src/platforms/xcb/kkeyserver.cpp To: dfaure, graesslin, jriddell, martinkostolny, broulik Cc: #frameworks
D8077: Fix org.kde.plasma.calendar with Qt 5.10
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Meh. I suspect there are other modules affected as well? REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D8077 To: fvogt, #plasma, broulik Cc: broulik, #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8092: Fix non-existing itemDatas
This revision was automatically updated to reflect the committed changes. Closed by commit R216:2d8eab6f502e: Fix non-existing itemDatas (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8092?vs=20197=20203 REVISION DETAIL https://phabricator.kde.org/D8092 AFFECTED FILES data/syntax/julia.xml data/syntax/ocaml.xml data/syntax/prolog.xml data/syntax/toml.xml data/syntax/xslt.xml To: dhaumann, vkrause Cc: #frameworks
D8092: Fix non-existing itemDatas
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fix-more-attributes REVISION DETAIL https://phabricator.kde.org/D8092 To: dhaumann, vkrause Cc: #frameworks
D7750: fix crash when more than one instances of ExtractorCollection are destructed
mgallien updated this revision to Diff 20200. mgallien added a comment. add a setAutoDeletePlugin method and modify the name of the enum value to not use the shared word REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7750?vs=19918=20200 BRANCH fixPluginDelete REVISION DETAIL https://phabricator.kde.org/D7750 AFFECTED FILES autotests/extractorcollectiontest.cpp src/extractor.cpp src/extractor.h src/extractor_p.h src/extractorcollection.cpp To: mgallien, #frameworks, dfaure Cc: dfaure, anthonyfieroni
D8092: Fix non-existing itemDatas
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Still broken:
haml.xml" Reference of non-existing itemData attributes: QSet("Escaped
Text", "Ruby embedded in haml", "Array")
lilypond.xml" Reference of non-existing itemData attributes: QSet("Tremolo")
metafont.xml" Reference of non-existing itemData attributes: QSet("Tex",
"Bullet", "Verbatim")
relaxng.xml " Reference of non-existing itemData attributes: QSet("Entity
Reference")
rhtml.xml " Reference of non-existing itemData attributes: QSet("RUBY RAILS
ERB Text")
rmarkdown.xml" Reference of non-existing itemData attributes: QSet("Document
Headers", "Markdown")
stata.xml " Reference of non-existing itemData attributes: QSet("String2")
TEST PLAN
make && make test
REPOSITORY
R216 Syntax Highlighting
BRANCH
fix-more-attributes
REVISION DETAIL
https://phabricator.kde.org/D8092
AFFECTED FILES
data/syntax/julia.xml
data/syntax/ocaml.xml
data/syntax/prolog.xml
data/syntax/toml.xml
data/syntax/xslt.xml
To: dhaumann, vkrause
Cc: #frameworks
D8002: Improve DesktopFileParser heuristic for finding old-style service desktop entries
mpyne added a comment. Any objections? If not I'll try to commit in the next few days. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D8002 To: mpyne, #frameworks
D8056: Improve usability of "Open With" dialog by adding option to filter the application tree
ngraham added a comment. In https://phabricator.kde.org/D8056#151057, @simgunz wrote: > > - When the text field has focus, make the down arrow key move to the list of found results so that you can select one with the keyboard and not have to use the mouse at all > > I like the idea and in my personal opinion it should behave as you suggest, but before implementing it I want to be sure not to break other patterns people may use. In particular, the text box can have different autocompletion mode selected by the user, among which dropdown completion. This requires the use of the down arrow key, implementing your idea will break this behavior. Is it tolerable? I see what you mean. How about implementing "down-arrow-changes-focus" only when not using dropdown completion? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: ngraham, alexeymin, #frameworks
D6665: Make kssl compile against OpenSSL 1.1.0
ltoscano added a comment. I would say that the testing by @fvogt is enough, and given that most distributions are trying to phase out OpenSSL 1.0, and that they are compiling Qt with OpenSSL 1.1, I would suggest to push this and see fix any breakages later. It's low risk, as those functions from KDELibs4Support are probably not the most used around (and it's a porting-frameworks only anyway). @dfaure , what do you think? REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D6665 To: dvratil, #frameworks, dfaure Cc: aacid, arojas, fvogt, ltoscano, rdieter, #frameworks
D7750: fix crash when more than one instances of ExtractorCollection are destructed
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Looks good. To nitpick, setAutoDeletePlugin(true) would have been clearer IMHO. (Shared sounds like shared_ptr i.e. refcounting, which isn't the case here, it's just autodelete=off) REPOSITORY R286 KFileMetaData BRANCH fixPluginDelete REVISION DETAIL https://phabricator.kde.org/D7750 To: mgallien, #frameworks, dfaure Cc: dfaure, anthonyfieroni
D8084: KAutoSaveFile breaks if source file name contains a space!
ltoscano added a comment. I don't know the code too much, but would it be possible to add an autotest for this? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D8084 To: mardelle, #frameworks, shaforostoff Cc: ltoscano
D8084: KAutoSaveFile breaks if source file name contains a space!
mardelle created this revision.
mardelle added reviewers: Frameworks, shaforostoff.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
KAutoSaveFile does not correctly handle simple characters like spaces in file
names!!!
When creating a stale file (backup file) , to determine the file name it uses:
in tempFileName(), line 83:
return QString::fromLatin1(QUrl::toPercentEncoding(name).constData());
So the filename is encoded using percent encoding. But when checking for an
existing backup file, it does:
in extractManagedFilePath, line 180:
managedFileName.setPath(QUrl::fromPercentEncoding(encodedPath) +
QLatin1Char('/') + QFileInfo(staleFileName.left(sepPos)).fileName());
So the path part is correctly restored from percent encoding, but the
filename part is not decoded.
So we end up comparing "my file" with "my%20file" and the stale file is not
correctly identified!
TEST PLAN
Project files with space in their name in Kdenlive now have crash recovery
working
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D8084
AFFECTED FILES
src/lib/io/kautosavefile.cpp
To: mardelle, #frameworks, shaforostoff
D8060: allow to set a custom palette instead of colorSets
broulik added inline comments.
INLINE COMMENTS
> kiconloader.cpp:869
> % QLatin1Char('_')
> - % paletteId(qApp->palette(), mColorSet)
> + % paletteId(mPalette)
> % (q->theme() && q->theme()->followsColorScheme() && state ==
> KIconLoader::SelectedState ? QStringLiteral("_selected") : QString());
You don't seem to be following `qApp->palette()` anymore if no custom one is
set?
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D8060
To: mart, dfaure, #frameworks, rikmills
Cc: broulik, cfeck, #frameworks
D8056: Improve usability of "Open With" dialog by adding option to filter the application tree
simgunz added a comment. > - When the text field has focus, make the down arrow key move to the list of found results so that you can select one with the keyboard and not have to use the mouse at all I like the idea and in my personal opinion it should behave as you suggest, but before implementing it I want to be sure not to break other patterns people may use. In particular, the text box can have different autocompletion mode selected by the user, among which dropdown completion. This requires the use of the down arrow key, implementing your idea will break this behavior. Is it tolerable? > - Pre-select the top result in the list of found results so that you can immediately hit the return key to select that application I think this can be implemented independently of the previous point. We select the first result, and hitting enter will use that result even if the focus is still in the textbox. So no matter wether we decide to implement point 1, this should work. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: ngraham, alexeymin, #frameworks
