D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips
ngraham added a reviewer: aacid. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D8303 To: ngraham, #dolphin, #kde_applications, #frameworks, aacid Cc: anthonyfieroni, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp
D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips
ngraham updated this revision to Diff 20768. ngraham added a comment. Update current version REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8303?vs=20767=20768 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8303 AFFECTED FILES src/metadatafilter.cpp To: ngraham, #dolphin, #kde_applications, #frameworks Cc: anthonyfieroni, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp
D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips
anthonyfieroni added a comment.
Baloo doesn't have active developers so you can add Aacid to accept it.
INLINE COMMENTS
> metadatafilter.cpp:44
> {
> const int currentVersion = 6; // increase version, if the blacklist of
> disabled
> // properties should be updated
Increase it like commet advice.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D8303
To: ngraham, #dolphin, #kde_applications, #frameworks
Cc: anthonyfieroni, spoorun, navarromorales, firef, ngraham, andrebarros,
emmanuelp
D8056: Improve usability of "Open With" dialog by adding option to filter the application tree
ngraham added a comment. Any progress? This is too good a change to not merge. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: ngraham, alexeymin, #frameworks
KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 120 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/120/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Sun, 15 Oct 2017 02:58:15 + Build duration: 25 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (22/22)80% (278/346)80% (278/346)57% (29990/52248)42% (16577/39291)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (67/67)100% (67/67)96% (8078/8399)51% (4502/8824)autotests.http100% (9/9)100% (9/9)100% (543/544)60% (200/336)autotests.kcookiejar100% (1/1)100% (1/1)90% (179/198)67% (60/90)src.core85% (99/117)85% (99/117)58% (8178/14198)49% (4562/9279)src.core.kssl100% (1/1)100% (1/1)38% (35/93)50% (3/6)src.filewidgets73% (27/37)73% (27/37)46% (3491/7603)30% (1300/4403)src.gui100% (2/2)100% (2/2)95% (104/110)75% (54/72)src.ioslaves.file100% (2/2)100% (2/2)51% (435/849)42% (317/749)src.ioslaves.http100% (8/8)100% (8/8)47% (1770/3781)38% (1326/3462)src.ioslaves.http.kcookiejar100% (2/2)100% (2/2)80% (622/782)72% (608/839)src.ioslaves.remote100% (2/2)100% (2/2)27% (70/258)8% (16/200)src.ioslaves.trash80% (8/10)80% (8/10)60% (704/1173)47% (404/851)src.ioslaves.trash.tests100% (2/2)100% (2/2)90% (707/785)48% (461/970)src.kioslave100% (1/1)100% (1/1)52% (14/27)50% (5/10)src.kntlm100% (2/2)100% (2/2)97% (373/385)80% (111/138)src.kpasswdserver100% (2/2)100% (2/2)63% (377/594)48% (280/580)src.kpasswdserver.autotests100% (1/1)100% (1/1)99% (283/286)57%
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 121 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/121/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 15 Oct 2017 02:58:15 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)
D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips
ngraham edited the test plan for this revision. ngraham added reviewers: Dolphin, KDE Applications, Frameworks. ngraham added a project: Dolphin. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D8303 To: ngraham, #dolphin, #kde_applications, #frameworks Cc: spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp
D8296: Use Ctrl+, as the standard shortcut for "Configure "
ngraham added a comment. Any remaining concerns? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: graesslin, broulik, #frameworks
D8296: Use Ctrl+, as the standard shortcut for "Configure "
ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: graesslin, broulik, #frameworks
D7810: Add missing icon sizes
ngraham added a reviewer: Frameworks. ngraham added a comment. This seems okay to me, but I'm pretty new and I'd really like sign-off from someone more experienced first. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D7810 To: mandian, #breeze, #vdg, jensreuterberg, #frameworks Cc: ngraham, cfeck, #frameworks
KDE CI: Frameworks kwayland kf5-qt5 XenialQt5.7 - Build # 53 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/53/ Project: Frameworks kwayland kf5-qt5 XenialQt5.7 Date of build: Sat, 14 Oct 2017 16:07:37 + Build duration: 12 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 37 test(s), Skipped: 1 test(s), Total: 39 test(s)Failed: TestSuite.kwayland-testXdgForeign Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (4/4)96% (197/206)96% (197/206)88% (21163/24126)53% (10488/19843)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.client100% (34/34)100% (34/34)99% (10340/10404)50% (6825/13583)autotests.server100% (5/5)100% (5/5)99% (356/359)49% (211/428)src.client94% (61/65)94% (61/65)77% (4753/6185)59% (1599/2717)src.server95% (97/102)95% (97/102)80% (5714/7178)59% (1853/3115)
KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 - Build # 52 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/52/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 14 Oct 2017 16:07:37 + Build duration: 6 min 27 sec and counting JUnit Tests Name: (root) Failed: 16 test(s), Passed: 18 test(s), Skipped: 1 test(s), Total: 35 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testIdleFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandFullscreenShellFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurfaceFailed: TestSuite.kwayland-testXdgForeignFailed: TestSuite.kwayland-testXdgShellV5
D8284: Don't duplicate connect to wl_display_flush
This revision was automatically updated to reflect the committed changes. Closed by commit R127:f48b796c74d5: Dont duplicate connect to wl_display_flush (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8284?vs=20708=20744 REVISION DETAIL https://phabricator.kde.org/D8284 AFFECTED FILES src/client/connection_thread.cpp src/client/connection_thread.h To: davidedmundson, graesslin Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
D8296: Use Ctrl+, as the standard shortcut for "Configure "
ngraham added a comment. Unless I'm holding it wrong, https://lxr.kde.org/ident?_i=Comma&_remember=1 doesn't appear show any other uses of Ctrl+, as a keyboard shortcut. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: graesslin, broulik, #frameworks
D8296: Use Ctrl+, as the standard shortcut for "Configure "
graesslin added a comment. In https://phabricator.kde.org/D8296#155363, @ngraham wrote: > Sounds good. What's lxr? lxr.kde.org REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: graesslin, broulik, #frameworks
D8296: Use Ctrl+, as the standard shortcut for "Configure "
ngraham added a comment. Sounds good. What's lxr? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: graesslin, broulik, #frameworks
D8296: Use Ctrl+, as the standard shortcut for "Configure "
graesslin added a comment. Agree with Kai - this needs good testing that it is not used anywhere. Best by looking through lxr which apps use this framework. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: graesslin, broulik, #frameworks
D8296: Use Ctrl+, as the standard shortcut for "Configure "
ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: broulik, #frameworks
D8296: Use Ctrl+, as the standard shortcut for "Configure "
ngraham added a reviewer: VDG. ngraham added a comment. FWIW, I did some basic testing on that and couldn't find any conflicts among Plasma, KWin, Dolphin, Kate, Konsole, Gwenview, Okular, Konversation, KTorrent, Skanlite. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: broulik, #frameworks
D8296: Use Ctrl+, as the standard shortcut for "Configure "
broulik added a comment. +1 However I fear this might cause "shortcut xyz is ambiguous" messages after update for some users :/ Perhaps also consult VDG / usability REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks Cc: broulik, #frameworks
D8296: Use Ctrl+, as the standard shortcut for "Configure "
ngraham added a reviewer: Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks Cc: #frameworks
D8296: Use Ctrl+, as the standard shortcut for "Configure "
ngraham created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Use Ctrl+, as the standard keyboard shortcut to invoke KDE programs' "Configure " menu items. Right now there is no shortcut defined for this, which is a shame because having a standardized shortcut for it is really useful, and we actually have the opportunity to do so because our software uses KStandardActions for these kinds of things. I chose Ctrl+, because that's the standard shortcut for all (and I do mean all) programs in the macOS world--a standard that has started to trickle into the Windows world as well, because there was previously no standard there. Might as well standardize on what's already a de facto standard elsewhere, to avoid throwing away people's muscle memory. TEST PLAN Tested in KDE Neon. All KDE applications I tried now have a consistent keyboard shortcut for their "Configure " menu items. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D8296 AFFECTED FILES src/gui/kstandardshortcut.cpp To: ngraham Cc: #frameworks
D8284: Don't duplicate connect to wl_display_flush
graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Ahhh. That's of course tricky to spot in this change ;-) REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D8284 To: davidedmundson, graesslin Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
D8284: Don't duplicate connect to wl_display_flush
davidedmundson added a comment. The other ctor has a connect in the body. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8284 To: davidedmundson Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
D8284: Don't duplicate connect to wl_display_flush
graesslin added a comment. I don't see in the change what you describe. This seems to be just a refactoring. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8284 To: davidedmundson Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
Re: qqc2-desktop-style as framework
On Thursday, 31 August 2017 17:06:46 CEST Marco Martin wrote: > Hi all, > we have a qtquickcontrols style that is right now in workspace (unrelased, > to be released with Plasma 5.11) > it makes controls paint with qstyle to give it a reasonable desktop > appearance, plus some fixes/workarounds to make qml a bit more desktop > friendly (for instance fixes scrollwheel issues with Flickable) > sice it's pretty much untenable to make a desktop application with > QtQuickControls2 without it and make it look anything near "native", so > releasing it together plasma is probably not enough. > Applications using kirigami should be able to explicitly depend from it if > they want, to require a native-looking look and feel on linux desktops (even > on gnome would look already marginally better than with the stock > "universal" or "material" styles) > > it's a thing with no api, no libraries (not even an import, qqc2 styles work > a bit differently), so as with kirigami only source compatibility on the > qml- side will matter > > any objection into pulling it into a framework? anything particular for the > procedure? Observations while trying to add this to the KF5 Yocto recipes: - it shows up as Tier 1 on https://api.kde.org/frameworks/index.html but seems to have a hard dependency on Kirigami - it seems to be licensed LGPLv3 + GPLv2, which doesn't match what https:// community.kde.org/Policies/Licensing_Policy says about KF5 code (see item 4). Regards, Volker signature.asc Description: This is a digitally signed message part.
D7130: KMoreTools: Update and fix desktopfiles
gregormi added a comment.
> @ltoscano, can we commit this?
Hi Nate, thanks for pushing this forward.
> I still disagree in the way this is done, as it means manually periodically
updating the information and it's definitely not the right thing to do.
Hi Luigi,
I agree with you that the manual updating process is not good. As the library
was written, there was no better way. The desktop file method was chosen
because it was said that they avoid duplicate translation work. See last point
of the Introduction
https://api.kde.org/frameworks/knewstuff/html/classKMoreTools.html ("Reduce
translation effort by re-using .desktop files of the services added to the
menu."). Since the goal of KMoreTools is to present applications that are not
installed, I currently see no other way to ship all the desktop files.
> That said, if @elvisangelaccio approves this, it can go in as temporary fix
but the next update should work on using the appstream library to get those
information from appstream files. Or any other solutions which does not involve
duplicating the information.
I looked at the appstream documentation but I was not able to extract
information that would help me to understand how to use it in the KMoreTools
case. To be of use in KMoreTools there should be an offline database with all
needed applications and descriptions. How will this database be filled with new
applications? Maybe you can point me to some suitable documentation?
> I had tested the patch and it was fixing the bug.
> I'm fine with this as long as @gregormi volunteers to maintain this code
updated (and eventually to switch to a better design, if possible).
Hi Elvis, thanks for testing. Yes, I am currently volunteering to maintain.
The library was created to keep application code (like Dolphin) clean of such
details. I am regularly looking for a better design. Input welcome.
> I'm afraid this doesn't merge cleanly onto master. @gregormi, can you
rebase it against current master so that I can merge it?
OK, I will rebase onto master and report back when done.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,
ngraham
Cc: ngraham, ltoscano, #frameworks
Re: Persistent data with KDED (or KIOD) and a KIO Slave?
On dimanche 8 octobre 2017 15:22:00 CEST Mark Gaiser wrote:
> But then i still miss one rather important detail that i can't really find
> anywhere..
> Lets say I have that module and call it "tags2" (as Baloo already has tags,
> therefore tags2 to prevent naming issues).
>
> So i make a dbus service file named:
> Name=org.kde.tags2
>
> And in the "tags2.json" i put:
>
> {
> "KPlugin": {
> "Description": "Put tags on files and folders.",
> "Name": "Tags 2",
> "ServiceTypes": [
> "KDEDModule"
> ]
> },
>
> "X-KDE-DBus-ModuleName": "tags2",
> "X-KDE-DBus-ServiceName": "org.kde.tags2"
> }
>
> What do i do in the client side code to start this module?
You just make a DBus call to the service org.kde.tags, with
object path /modules/tags2. That will start kiod if needed,
load the module, and make the call.
The best solution for this is with type safety rather than without,
i.e. generating C++ from the DBus xml file. See e.g.
kio/core/kpasswdserverclient.cpp which makes calls to the kiod kpasswdserver
module using the generated OrgKdeKPasswdServerInterface class.
qt5_add_dbus_interface() is the cmake function for doing that.
> That "client side" can be an IO slave, but it can also be some special Tags
> helper classes to create a new tag name with description and icon or such.
Sure, anyone can make dbus calls.
> I need to call something to trigger KIOD to start this module, but i can't
> figure out what.
>
> How do i see qCDebug output from kiod plugins anyhow?
In ~/.xsession-errors, or by killing kiod and restarting it in a terminal.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
