date:20171029

D7810: Add missing icon sizes

2017-10-29 Thread Nathaniel Graham

ngraham added a subscriber: hein.
ngraham added a comment.


  @hein, it looks like you might have some context, based on 
https://cgit.kde.org/breeze-icons.git/commit/?id=3e3eaaa82169f48ae849b2349c1e981b8b542ba6

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D7810

To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham
Cc: hein, ngraham, cfeck, #frameworks

D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

2017-10-29 Thread Nathaniel Graham

ngraham retitled this revision from "Use Ctrl+Shift+. as the standard shortcut 
for "Configure "" to "Use Ctrl+Shift+, as the standard shortcut for 
"Configure "".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: ilic, abetts, elvisangelaccio, aacid, argonel, marten, graesslin, broulik, 
#frameworks

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

2017-10-29 Thread Nathaniel Graham

ngraham updated this revision to Diff 21542.
ngraham added a comment.


  Ctrl+Shift+Comma FTW

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8296?vs=21531=21542

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8296

AFFECTED FILES
  src/gui/kstandardshortcut.cpp

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: ilic, abetts, elvisangelaccio, aacid, argonel, marten, graesslin, broulik, 
#frameworks

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

2017-10-29 Thread Nathaniel Graham

ngraham added a comment.


  In https://phabricator.kde.org/D8296#161574, @rkflx wrote:
  
  > In https://phabricator.kde.org/D8296#161570, @rkflx wrote:
  >
  > > Possibly the conflict detection is broken?
  >
  >
  > Turns out it's not, the shortcut is actually defined for the "Light Table". 
However, there the shortcut is listed twice and works the same (for me at 
least). Might be worth talking to Digikam if this is an oversight or what is 
going on there.
  
  
  Yeah, I've filed https://bugs.kde.org/show_bug.cgi?id=386335
  
  In https://phabricator.kde.org/D8296#161576, @ilic wrote:
  
  > `KStandardShortcut::Preferences` label is being overridden in 
KConfigWidgets's `src/kstandardaction_p.h` to `" %1..."` and %1 
substituted with current application name.
  
  
  Hah! No wonder I couldn't find the string anywhere. Looks like a special case 
will be needed.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: ilic, abetts, elvisangelaccio, aacid, argonel, marten, graesslin, broulik, 
#frameworks

D8536: Add more hashing algorithms to KPropertiesDialog

2017-10-29 Thread Peter Majchrak

petermajchrak edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8536

To: petermajchrak, elvisangelaccio
Cc: bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks

D8536: Add more hashing algorithms to KPropertiesDialog

2017-10-29 Thread Peter Majchrak

petermajchrak updated this revision to Diff 21535.
petermajchrak added a comment.


  Convert to only combobox based layout

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8536?vs=21495=21535

REVISION DETAIL
  https://phabricator.kde.org/D8536

AFFECTED FILES
  src/widgets/checksumswidget.ui
  src/widgets/kpropertiesdialog.cpp
  src/widgets/kpropertiesdialog_p.h

To: petermajchrak, elvisangelaccio
Cc: bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

2017-10-29 Thread Chusslove Illich

ilic added a comment.


  `KStandardShortcut::Preferences` label is being overridden in 
KConfigWidgets's `src/kstandardaction_p.h` to `" %1..."` and %1 
substituted with current application name.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: ilic, abetts, elvisangelaccio, aacid, argonel, marten, graesslin, broulik, 
#frameworks

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

2017-10-29 Thread Henrik Fehlauer

rkflx added a comment.


  In https://phabricator.kde.org/D8296#161570, @rkflx wrote:
  
  > Possibly the conflict detection is broken?
  
  
  Turns out it's not, the shortcut is actually defined for the "Light Table". 
However, there the shortcut is listed twice and works the same (for me at 
least). Might be worth talking to Digikam if this is an oversight or what is 
going on there.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: ilic, abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, 
broulik, #frameworks

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

2017-10-29 Thread Henrik Fehlauer

rkflx added a comment.


  In https://phabricator.kde.org/D8296#161566, @ngraham wrote:
  
  > Digikam, which is as far as I can tell the only one using Ctrl+Shift+,
  
  
  Is it, though? I don't see it here:
  F5456767: digikam.png 
  
  There might actually be a bug here: Adapting your patch to [Ctrl] + [⇧] + 
[,], I get this for Digikam:
  
  - warning on startup
  - Configure Digikam works
  - Zoom to 100% works
  - shortcuts listed as [Ctrl] + [⇧] + [,] and [Ctrl] + [,]
  
  Possibly the conflict detection is broken?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: ilic, abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, 
broulik, #frameworks

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

2017-10-29 Thread Nathaniel Graham

ngraham added a comment.


  @rkflx
  If we need to change one app, we could also target Digikam, which is as far 
as I can tell the only one using Ctrl+Shift+,
  
  @ilic
  Actually the problem is that this string--whatever it is in the code--is 
being changed for English to "Configure System Settings..." when viewed in 
System Settings > Shortcuts > Standard Shortcuts:
  
  F5456736: Screenshot_20171029_123236.png 

  
  I haven't been able to find where that's being done.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: ilic, abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, 
broulik, #frameworks

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

2017-10-29 Thread Chusslove Illich

ilic added a comment.


  "Configure Application" does sound better than "Preferences", but that's just 
my opinion as a random translator, no link to my i18n plumber's hat :)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: ilic, abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, 
broulik, #frameworks

D8351: API dox: add note about calling setApplicationDomain after QApp creation

2017-10-29 Thread Chusslove Illich

ilic added a comment.


  Well... it's a tough situation. It is not by design that `i18n` calls should 
in any way depend on creation of `QApplication`, and also any library may place 
an `i18n` call before the main program creates `QApplication`. The only 
solution I see is that environment is rechecked at every `i18n` call. This 
would be easy to do (just replacing every `s->languages` with a newly 
implemented `s->getLanguages()`), but I've no idea what would be the 
performance hit of that.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D8351

To: kossebau, #frameworks, ilic, ltoscano

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

2017-10-29 Thread Nathaniel Graham

ngraham planned changes to this revision.
ngraham added a comment.


  Urgh, didn't find it because it's defined in Konsole like this:
  
  `Konsole::ACCEL + Qt::SHIFT + Qt::Key_Period`

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: ilic, abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, 
broulik, #frameworks

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

2017-10-29 Thread Henrik Fehlauer

rkflx added a comment.


  In https://phabricator.kde.org/D8296#161557, @rkflx wrote:
  
  > Let's hope nobody finds any obscure place where this is used already...
  
  
  Hm, conflicts in Konsole. However, can we change Konsole? At least, you could 
use this to improve your lxr search, so maybe more is found (bad) or Konsole is 
the only place (not quite as bad).

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: ilic, abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, 
broulik, #frameworks

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

2017-10-29 Thread Henrik Fehlauer

rkflx added a subscriber: ilic.
rkflx added a comment.


  Was confused and it took me a while to figure out how this will end up for 
different keyboard layouts. Turns out using the KCM combines [⇧] + [key], while 
`arc patch` results in all three keys shown in the menu.
  
  This means that [.] is always used, regardless of keyboard layout. As this 
key is quite important for writing, it should be easy to access almost 
everywhere.
  
  Great find, I like it :) (and it even fulfills @abetts' demands for two 
hands). Let's hope nobody finds any obscure place where this is used already...
  
  > can anyone give me a super-quick primer on how to submit a better string 
here?
  
  Last time we summoned @ilic it worked out well, otherwise do some API docs 
reading?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: ilic, abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, 
broulik, #frameworks

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

2017-10-29 Thread Nathaniel Graham

ngraham added a comment.


  So as for changing the name...
  I notice that this uses `QT_TRANSLATE_NOOP3()` instead of `i18n`. It seems 
that the English string at least is simply a bad translation, likely caused by 
the poorly-chosen base string, which I've changed to be a bit more descriptive. 
I've never done any translation work before; can anyone give me a super-quick 
primer on how to submit a better string here?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, 
#frameworks

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

2017-10-29 Thread Nathaniel Graham

ngraham updated this revision to Diff 21531.
ngraham added a comment.


  Improved translation string to provide a better hint about what this really is

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8296?vs=21530=21531

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8296

AFFECTED FILES
  src/gui/kstandardshortcut.cpp

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, 
#frameworks

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

2017-10-29 Thread Nathaniel Graham

ngraham retitled this revision from "Use Ctrl+Alt+, as the standard shortcut 
for "Configure "" to "Use Ctrl+Shift+. as the standard shortcut for 
"Configure "".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, 
#frameworks

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-29 Thread Nathaniel Graham

ngraham updated this revision to Diff 21530.
ngraham added a comment.


  Amazingly, Ctrl+Shift+. isn't taken!

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8296?vs=21507=21530

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8296

AFFECTED FILES
  src/gui/kstandardshortcut.cpp

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, 
#frameworks

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-29 Thread Henrik Fehlauer

rkflx added a comment.


  Well, that's more of a list than a well-explained guideline. This is quite 
good (grep for "system reserved shortcuts", but also see general reasoning): 
https://developer.gnome.org/hig/stable/keyboard-input.html.en

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, 
#frameworks

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-29 Thread Andres Betts

abetts added a comment.


  We don't seem to have anything against it. My only request is that if we do 
shortcuts, make them use 2 hands instead of just one. If the keys are too close 
together, this makes it harder to enter. Possibly harder for people with 
disabilities as well. So, space the sets in 2, one on the left side of the 
keyboard and the next symbol on the right.
  
  Shortcuts HIG 


REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, 
#frameworks

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-29 Thread Henrik Fehlauer

rkflx added a comment.


  Try typing that on a non-US keyboard layout :)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, 
#frameworks

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-29 Thread Nathaniel Graham

ngraham added a comment.


  I agree, @rkflx. Shame Ctrl+Shift+, is taken.
  
  Ctrl+Shift+\, maybe? That's not taken.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, 
#frameworks

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-29 Thread Henrik Fehlauer

rkflx added a comment.


  Is there any other menu action which has [Meta] in its shortcut? If not, this 
might be an indication that we are heading in the wrong direction. I find 
[Meta] more appropriate for global shortcuts (virtual desktops, activities, 
window management, Kickoff, …), where it is already used. Do we have a HIG 
regarding this, so we maintain at least some order and logic?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, 
#frameworks

D8545: kio: fix handling of KCookieAdvice::AcceptForSession

2017-10-29 Thread David Faure

dfaure accepted this revision.
This revision is now accepted and ready to land.

REVISION DETAIL
  https://phabricator.kde.org/D8545

To: schwab, dfaure
Cc: #frameworks

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-29 Thread Andres Betts

abetts added a comment.


  If you assume that most computers that run linux will have a windows key, I 
would call it just windows. Everyone else uses exceptions really.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, 
#frameworks

D8427: Allow cross compiling resource file

2017-10-29 Thread Volker Krause

vkrause added a task: T6715: Add cross compilation support for breeze-icons QRC 
generator.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8427

To: vpinon, apol, kfunk
Cc: #frameworks, bartoloni, benjaminnelan, afarid, fernandoteles, mardelle

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-29 Thread Nathaniel Graham

ngraham added a comment.


  That would work, and it's not taken, but I worry that this wouldn't help a 
lot of users, because outside of seasoned Linux users, Meta isn't a well known 
description for the Windows/super/Command key (depending on the keyboard 
hardware).

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, 
#frameworks

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-29 Thread Andres Betts

abetts added a comment.


  What about Windows/Meta + Something, let's say , comma?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, 
#frameworks

D8545: kio: fix handling of KCookieAdvice::AcceptForSession

2017-10-29 Thread Andreas Schwab

schwab updated this revision to Diff 21528.
schwab added a comment.


  Accidentally attached the wrong diff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8545?vs=21521=21528

REVISION DETAIL
  https://phabricator.kde.org/D8545

AFFECTED FILES
  src/kcms/kio/kcookiespolicyselectiondlg.h

To: schwab, dfaure
Cc: #frameworks

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-29 Thread Nathaniel Graham

ngraham added a comment.


  In https://phabricator.kde.org/D8296#161367, @rkflx wrote:
  
  > > Just checked: It's already there in Standard Shortcuts, where it can be 
changed.
  >
  > Well, it says Configure System Settings…, so I even discarded this when 
first looking for it. As a soon-to-be shortcut expert, do you see a chance this 
could be changed to Configure Application… (only in System Settings, of course)?
  
  
  Definitely, that bugs me too. Now to figure out where exactly this is set...
  
  In https://phabricator.kde.org/D8296#161367, @rkflx wrote:
  
  > Still feels a bit awkward and has the [Alt] accelerator problem. Maybe 
something involving [Ctrl] + [⇧]? (← that's a "Shift")
  
  
  Yeah that's probably for the Best. Too bad Ctrl+Shift+, doesn't work only 
because Digikam is using it. I'll to find something else.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, 
#frameworks

D6829: Add ability to use the new kauth helper in file ioslave

2017-10-29 Thread Chinmoy Ranjan Pradhan

chinmoyr reopened this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6829

To: chinmoyr, dfaure, #frameworks
Cc: #frameworks

D6197: Add kauth helper to file ioslave

2017-10-29 Thread Chinmoy Ranjan Pradhan

chinmoyr reopened this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6197

To: chinmoyr, elvisangelaccio, #frameworks, dfaure

D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper

2017-10-29 Thread Chinmoy Ranjan Pradhan

chinmoyr reopened this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6709

To: chinmoyr, thiago, #frameworks, dfaure
Cc: dfaure, davidedmundson, elvisangelaccio, shortstheory

D8545: kio: fix handling of KCookieAdvice::AcceptForSession

2017-10-29 Thread David Faure

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcookiespolicyselectiondlg.h:54
>  
>  if (advice == QLatin1String ("accept"))
>  return KCookieAdvice::Accept;

Oh, nasty, the kconfig key is the untranslated english message...

OK with the fix, except that you probably meant remove(' ').
I don't even see how replace(' ') can compile, all replace overloads take at 
least two args, no?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8545

To: schwab, dfaure
Cc: #frameworks

D8546: Add Aztec code generator

2017-10-29 Thread Volker Krause

vkrause created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Needed e.g. for boarding pass rendering in https://phabricator.kde.org/D8395.

REPOSITORY
  R280 Prison

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8546

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/aztec-compact-data-0011.png
  autotests/aztec-compact-data-0101.png
  autotests/aztec-compact-data-1001.png
  autotests/aztec-compact-data-1010.png
  autotests/aztec-compact-data-.png
  autotests/aztec-compact-grid.png
  autotests/aztec-compact-mode-.png
  autotests/aztec-compact-mode-1234-rev.png
  autotests/aztec-compact-mode-1234.png
  autotests/aztec-complete-big.png
  autotests/aztec-complete-compact1.png
  autotests/aztec-complete-compact4.png
  autotests/aztec-complete-full5.png
  autotests/aztec-full-data-0011.png
  autotests/aztec-full-data-0101.png
  autotests/aztec-full-data-1001.png
  autotests/aztec-full-data-1010.png
  autotests/aztec-full-data-.png
  autotests/aztec-full-grid.png
  autotests/aztec-full-mode-.png
  autotests/aztec-full-mode-1234-rev.png
  autotests/aztec-full-mode-1234.png
  autotests/aztec.qrc
  autotests/aztecbarcodetest.cpp
  autotests/reedsolomontest.cpp
  src/lib/CMakeLists.txt
  src/lib/aztecbarcode.cpp
  src/lib/aztecbarcode.h
  src/lib/bitvector.cpp
  src/lib/bitvector_p.h
  src/lib/prison.cpp
  src/lib/reedsolomon.cpp
  src/lib/reedsolomon_p.h

To: vkrause
Cc: #frameworks

D8545: kio: fix handling of KCookieAdvice::AcceptForSession

2017-10-29 Thread Andreas Schwab

schwab added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8545

To: schwab, dfaure
Cc: #frameworks

D8545: kio: fix handling of KCookieAdvice::AcceptForSession

2017-10-29 Thread Andreas Schwab

schwab created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Commit 
https://phabricator.kde.org/R241:23874cab9d192a12f3f9f0b261fc6e0784354c1f broke 
the handling of KCookieAdvice::AcceptForSession
  because strToAdvice(adviceToStr(KCookieAdvice::AcceptForSession)) now
  returns KCookieAdvice::Dunno.  Ignore spaces in the argument of
  strToAdvice to properly recognize the AcceptForSession setting and restore
  compatibility with previous configs.
  
  BUG: 386325

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8545

AFFECTED FILES
  src/kcms/kio/kcookiespolicyselectiondlg.h

To: schwab
Cc: #frameworks

D8544: KTextEditor : avoiding QML crashes

2017-10-29 Thread René J . V . Bertin

rjvbb marked an inline comment as done.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8544

To: rjvbb, #frameworks
Cc: kde-frameworks-devel, kevinapavew, demsking, head7, cullmann, kfunk, sars, 
dhaumann

D8544: KTextEditor : avoiding QML crashes

2017-10-29 Thread René J . V . Bertin

rjvbb added inline comments.

INLINE COMMENTS

> cstyle.js:518
> +} else if (currentLine == 0 || lineDelimiter == 0) {
> +return indentation;
>  }

`indentation` should always equal -1 here (so no need to add the dbg() 
statement).

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8544

To: rjvbb, #frameworks
Cc: kde-frameworks-devel, kevinapavew, demsking, head7, cullmann, kfunk, sars, 
dhaumann

D8544: KTextEditor : avoiding QML crashes

2017-10-29 Thread René J . V . Bertin

rjvbb created this revision.
rjvbb added a reviewer: Frameworks.
rjvbb added a project: KTextEditor.
Restricted Application added projects: Kate, Frameworks.

REVISION SUMMARY
  The transition from QtScript to QML introduced a propensity to crashing 
somewhere deep in Qt (in the V4 JIT engine to be exact), at often unexpected 
moments while editing texts, for users of certain versions of Qt5. It seems 
these crashes do not occur with Qt 5.9.1 and newer, but not everyone can update 
(readily) to that version.
  
  Upstream bug report: https://bugreports.qt.io/browse/QTBUG-63045
  
  I have tried to trace the JavaScript expressions that trigger the crashes 
I've seen myself, come up with a fix or at least a suitable and acceptable 
workaround (see https://bugs.kde.org/show_bug.cgi?id=385413). This review is 
for a patch that contains a fix for a specific crash as well as a general 
workaround.
  
  As far as I can tell the crashes I get (when hitting enter at the end of a 
line in documents using C style indentation) occur when unwinding the script 
interpreter stack, for instance when exiting from a `while` loop (or the 
equivalent `for` loop). This particular crash can be avoided by returning early 
from the procedure containing the loop, instead of exiting from the loop and 
returning via the shared return statement; see the patch to `cstyle.js`.
  
  Gentoo have come up with a blunt-force "solution": build QtDeclarative with 
the V4 JIT disabled. It works just as well to launch applications that are 
susceptible to the crash with the `QV4_FORCE_INTERPRETER` env. variable set 
which has less undesirable effects but is also more cumbersome.
  My patch explores an even less invasive approach: it uses the env. variable 
to disable the JIT when KTextEditor scripts are loaded/parsed, resetting (or 
unsetting) the variable when the crucial operation is done. The env.var 
manipulation is done in a dedicated KateScript subclass and is a noop for Qt 
version 5.9.1 and up.
  
  BUG: 385413

TEST PLAN
  Tested on Mac and Linux with Qt 5.8.0 . This works for me (read: I haven't 
seen any other crashes - yet!) but apparently does not prevent crashing with Qt 
5.7.1 (see the Qt bug report referenced in the summary).
  
  If necessary we can of course disable the JIT proactively in a KTextEditor 
initialiser routine (if possible reenabling it for plugins).

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8544

AFFECTED FILES
  src/script/data/indentation/cstyle.js
  src/script/katecommandlinescript.cpp
  src/script/kateindentscript.cpp
  src/script/katescript.cpp
  src/script/katescript.h
  src/script/katescripthelpers.cpp

To: rjvbb, #frameworks
Cc: kde-frameworks-devel, kevinapavew, demsking, head7, cullmann, kfunk, sars, 
dhaumann

D8188: Remove PreferCache from network requests

2017-10-29 Thread Albert Astals Cid

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:ed62ee204e4d: Remove PreferCache from network requests 
(authored by aacid).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8188?vs=20463=21513

REVISION DETAIL
  https://phabricator.kde.org/D8188

AFFECTED FILES
  src/core/jobs/httpworker.cpp

To: aacid, leinir
Cc: #frameworks

KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 35 - Unstable!

2017-10-29 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/35/
 Project:
Frameworks baloo kf5-qt5 XenialQt5.7
 Date of build:
Sun, 29 Oct 2017 07:39:20 +
 Build duration:
2 hr 14 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(12/12)77%
(111/144)77%
(111/144)73%
(5039/6932)50%
(2613/5194)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(42/42)89%
(16/18)autotests.integration100%
(3/3)100%
(3/3)95%
(242/255)64%
(140/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(40/40)57%
(25/44)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(736/736)53%
(390/740)autotests.unit.file100%
(11/11)100%
(11/11)97%
(788/809)51%
(438/864)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(315/326)52%
(156/302)src.codecs100%
(5/5)100%
(5/5)87%
(120/138)76%
(32/42)src.engine97%
(38/39)97%
(38/39)79%
(1607/2038)58%
(796/1379)src.file39%
(17/44)39%
(17/44)45%
(678/1506)38%
(374/980)src.file.extractor100%
(2/2)100%
(2/2)69%
(20/29)58%
(7/12)src.file.extractor.autotests100%
(1/1)100%
(1/1)100%
(22/22)61%
(11/18)src.lib55%
(6/11)55%
(6/11)43%
(429/991)40%
(228/575)

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-29 Thread David Faure

dfaure added a comment.


  Looks good, just some coding style issues.

INLINE COMMENTS

> kopenwithdialog.cpp:195
>  d->fillNode(QString(), d->root);
> +for (int i=0; i +fetchAll(index(i,0));

spaces around '=' and '<'

I would put rowCount() into a local var, the compiler can't optimize away that 
call.

> kopenwithdialog.cpp:196
> +for (int i=0; i +fetchAll(index(i,0));
> +}

space after comma

> kopenwithdialog.cpp:274
> +}
> +return;
> +}

remove useless statement

> kopenwithdialog.cpp:382
> +QSortFilterProxyModel(parent)
> +{
> +}

weird indentation, please indent these to column 0

> kopenwithdialog.cpp:398
> +
> +//Show the non-leaf node also if the regexp matches one one of its 
> children
> +int rows = sourceModel()->rowCount(index);

Ah. Filipe and I implemented recursive filtering in QSortFilterProxyModel but 
that's only in Qt 5.10. Too bad ;) We'll have to keep this for now then (easier 
here since the data doesn't change, anyway)

> kopenwithdialog.cpp:440
>  
> -d->appModel = qobject_cast(model);
> +d->appModel = qobject_cast *>(static_cast(model)->sourceModel());
>  if (d->appModel) {

Urgh. Why don't we change this method to be setModels(QSortFilterProxyModel *, 
KApplicationModel *) to avoid all these casts?

> kopenwithdialog.cpp:451
>  QModelIndex index = selectionModel()->currentIndex();
> +index = static_cast *>(model())->mapToSource(index);
>  return d->appModel->isDirectory(index);

... and keep a QSFPM * member variable to avoid these casts here.

> kopenwithdialog.cpp:479
> +if (indexes.count() == 1) {
> +if(!d->appModel->isDirectory(indexes.at(0))) {
> +QString exec = d->appModel->execFor(indexes.at(0));

space after if

> kopenwithdialog.cpp:819
> +// otherwise changing text but hitting the same result clears curService
> +bool selectionEmpty = !( d->view->currentIndex().row() >= 0);
> +if (d->curService && selectionEmpty) {

I think this would be more readable as

  const bool selectionEmpty = !d->view->currentIndex().isValid();

> kopenwithdialog.cpp:826
> +//Update the filter regexp with the new text in the lineedit
> +static_cast *>(d->view->model())->setFilterRegExp(QRegExp(d->edit->text(),
> +
> Qt::CaseInsensitive, QRegExp::FixedString));

Please use QRegularExpression; QRegExp is deprecated.

Although, if this is about FixedString, why not just use setFilterFixedString?
Regexps are slow, better avoid them when not necessary.

> kopenwithdialog.cpp:830
> +//Expand all the nodes when the search string is 3 characters long
> +//If the search string doesn't match anything there will be not nodes to 
> expand
> +if (d->edit->text().size() > 2) {

s/not/no/ ?

> kopenwithdialog.h:137
>  private:
> +bool eventFilter(QObject *object, QEvent *event);
> +

add "override" at the end

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham
Cc: subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-29 Thread Henrik Fehlauer

rkflx added a comment.


  > Just checked: It's already there in Standard Shortcuts, where it can be 
changed.
  
  Well, it says Configure System Settings…, so I even discarded this when first 
looking for it. As a soon-to-be shortcut expert, do you see a chance this could 
be changed to Configure Application… (only in System Settings, of course)?
  
  > Changed to Ctrl+Alt+, because Alt-only shortcuts are weird
  
  Still feels a bit awkward and has the [Alt] accelerator problem. Maybe 
something involving [Ctrl] + [⇧]? (← that's a "Shift")

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, 
#frameworks

D8528: Consider DjVu files to be documents

2017-10-29 Thread Henrik Fehlauer

rkflx accepted this revision.
rkflx added a comment.
This revision is now accepted and ready to land.


  I'd say this can land. Perhaps best to wait until Monday evening, so 
Frameworks people not spending their weekend at the computer have a chance to 
weigh in?

REPOSITORY
  R293 Baloo

BRANCH
  djvu_files_documents_369195

REVISION DETAIL
  https://phabricator.kde.org/D8528

To: ngraham, vhanda, #frameworks, rkflx
Cc: rkflx, #frameworks

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7 - Build # 52 - Still Unstable!

2017-10-29 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.7/52/
 Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7
 Date of build:
Sun, 29 Oct 2017 07:16:08 +
 Build duration:
9 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kstandarddirstest

47 matches

Mail list logo