D8590: KPageListView: Update width on font change

[Alexander Volkov]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:525cf0666bc1: KPageListView: Update width on font change 
(authored by volkov).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8590?vs=21690&id=22016

REVISION DETAIL
  https://phabricator.kde.org/D8590

AFFECTED FILES
  src/kpageview_p.cpp
  src/kpageview_p.h

To: volkov, cfeck, wojnilowicz, dfaure, rkflx, broulik
Cc: #frameworks

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 137 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/137/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
 Date of build:
Tue, 07 Nov 2017 03:41:16 +
 Build duration:
1 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R252:35656828f12c: Support downloading the 2nd or 3rd download 
link from a KNS product (authored by Zren).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8636?vs=21841&id=22014#toc

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8636?vs=21841&id=22014

REVISION DETAIL
  https://phabricator.kde.org/D8636

AFFECTED FILES
  src/kpackage-install-handlers/kns/main.cpp

To: Zren, apol
Cc: #frameworks

D8058: don't redefine output dirs on android

[Aleix Pol Gonzalez]

apol added a comment.


  https://phabricator.kde.org/D8173

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8058

To: mart, apol, dfaure, #frameworks
Cc: #frameworks, #build_system

D8546: Add Aztec code generator

[Sune Vuorela]

svuorela added a comment.


  Thanks for this contribution. I think it is good and needed.

INLINE COMMENTS

> CMakeLists.txt:1
> +set(aztecbarcodetest_srcs
> +aztecbarcodetest.cpp

I'd like an extra level of directories given the large amount of test files, so 
we have e.g. autotests/aztec/ with the relevant files and helpers.

> aztec-compact-data-0011.png:1


For all these images, are this the only valid encoding for the relevant data, 
or are there enough extra data in aztec codes that a valid set of data can be 
encoded in multiple ways ?

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D8546

To: vkrause, #frameworks, svuorela, dfaure
Cc: dfaure, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

simgunz marked an inline comment as done.
simgunz added a comment.


  @rkflx I agree on all your points.
  
  In general I also prefer to have the categories. Implementing what you 
propose will require a bit of time. Basically if we want any behavior different 
from the current one, we need to replace the `QTreeView` with a `QListView` 
every time some text is typed in the `QLineEdit`.
  
  I agree in opening a new task to talk about the proposed points.
  
  For this patch everything should be ok, now. I also fixed the `QRegExp` point.
  
  Just for my mental sanity, what is the remarkup syntax to make the ESC key? 
key Esc or Escape shows a hammer and sickle :-)

INLINE COMMENTS

> rkflx wrote in kopenwithdialog.cpp:826
> @simgunz This is marked as done, but still uses `QRegExp` and not 
> `QRegularExpression`?

I was using the regular expression only to provide cases insensitive filter, 
but I saw now I can achieve it with fixed string filter as well.

The interface of the method `setFilterRegExp` only accepts `QRegExp`.

Thanks for pointing this out.

> rkflx wrote in kopenwithdialog.cpp:1099
> Is this a "fixme-before-commit" or a "fixme-sometimes-in-the-future" FIXME?

It is a fixme-sometimes-in-the-future. Actually I am not even sure how much of 
a problem that is, so any other opinion is welcomed.

To be more clear on this point. Currently [↓] moves the focus to the tree view, 
while [↑] moves it back in the line edit history of commands. When the search 
provides no results, [↓] moves forward in the history. This is true for any 
completion type.

Before my changes, [↓] was just moving forward in the history of commands.

When we use CompletionPopup or CompletionPopupAuto we want [↓] to let use 
navigate the entries in the popup, so it shouldn't be used to focus on the 
treeview. At this point there are two possibilities:

1. We hit [Enter] and select an entry. The popup closes, and in the tree there 
will be likely a single result if the command chosen has also a desktop entry, 
or no results if the command is a shell command
2. We hit `Esc` and in the line edit there is a piece of text that may match 
something in the tree view

At this point, once the popup is closed, one could use [↓] to focus the tree 
view, but currently [↓] is disabled. So in this sense the behavior is not 
consistent with the cases where other completion modes are used. (Note that 
when the popup  is closed [↓] does not open it again, only typing more text 
opens it)

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham
Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

simgunz updated this revision to Diff 21990.
simgunz marked an inline comment as done.
simgunz added a comment.


  - Use fixed string case insensitive filter

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8056?vs=21925&id=21990

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

AFFECTED FILES
  src/widgets/kopenwithdialog.cpp
  src/widgets/kopenwithdialog.h
  src/widgets/kopenwithdialog_p.h

To: simgunz, dfaure, #frameworks, #vdg, ngraham
Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8383: [server] Support inhibiting the IdleInterface

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  inhibit-idle

REVISION DETAIL
  https://phabricator.kde.org/D8383

To: graesslin, #frameworks, #kwin, #plasma_on_wayland, davidedmundson
Cc: plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Henrik Fehlauer]

rkflx added a comment.


  @abetts  @simgunz If you agree with my ideas in general and also with doing 
those in followup patches, please add a short comment. I'll then open a task on 
some of Phab's workboards which is better suited for tracking the discussion 
than some random comment ;)

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham
Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Nathaniel Graham]

ngraham added a comment.


  In https://phabricator.kde.org/D8056#165014, @rkflx wrote:
  
  > That said, I would suggest to just commit this patch as is and work on any 
further improvements in a followup patch
  
  
  +1, no need to get bogged down making it perfect in the first patch. 
Incremental improvement, baby!

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham
Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8546: Add Aztec code generator

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:20
> +target_link_libraries(prison-reedsolomontest Qt5::Test KF5::Prison)
> +add_test(NAME prison-reedsolomontest COMMAND prison-reedsolomontest)

I suggest using ecm_add_test

> aztecbarcodetest.cpp:160
> +
> +void testComaptGrid()
> +{

typo for Compact?

> aztecbarcode.cpp:734
> +break;
> +if (*it)
> +p.drawPoint(x, y);

missing {...} on single-line statements (repeats)

> reedsolomon_p.h:27
>  
> -#include "prison.h"
> -#include "datamatrixbarcode.h"
> -#include "qrcodebarcode.h"
> -#include "code39barcode.h"
> -#include "code93barcode.h"
> +#ifndef PRISON_REEDSOLOMON_H
> +#define PRISON_REEDSOLOMON_H

_P_H to match the filename

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D8546

To: vkrause, #frameworks, svuorela, dfaure
Cc: dfaure, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Henrik Fehlauer]

rkflx added a comment.


  Gave this a spin, it's a really nice improvement. As for the categories, I do 
not feel they "get in the way", because:
  
  - In most cases, even after only typing three letters there is only one 
result left, which is already preselected so [Enter] will accept seemlessly.
  - It is actually helpful to also see which category an app is in, as this 
provides confirmation you are on the right track (e.g. if you do "graphics" 
things, you do not want "devel" stuff) as well as disambiguation of similar 
entries.
  - In a way those visual anchors help finding results faster in case the 
resulting list is long, as you can easily move to the next category instead of 
having to scan the complete list of results.
  
  Here is an idea for a compromise which both preserves important context and 
reduces visual noise: Include subtle grouping like in the new type-ahead search 
in System Settings, i.e. instead of a tree, flatten the list and include the 
categories as disabled items / intermediate headers. (Not sure how difficult 
this would be to implement, though.)
  
  At least any duplicates should be removed if you should decide to remove 
categories altogether (e.g. KMail is both in Internet and Office, which would 
be confusing without context). Note the duplication is actually helpful when 
just using categories, and searching in Kickoff already de-duplicates results.
  
  That said, there are some improvements I could imagine would polish this even 
further:
  
  - Expand the categories once the first character is typed. This gives a hint 
on what to type next (e.g. `km` would hint at KMail and KMag instead of just 
showing the categories).
  - Search in the descriptions too (e.g. `browser` would show Firefox and 
Chromium instead of returning nothing).
  - First line of text: Make it clear what is description and what is the item 
being opened, i.e. like on Phab I would not write "install the arc helper" but 
add markup like "install the `arc` helper". Not sure about the best way to do 
this, but using bold text would be a first step (also see screenshot below).
  - It is not discoverable you are allowed to type in a full path to a binary, 
which is important for a lot of third party / proprietary / binary.tar.gz-style 
software not installing proper desktop files and one of the primary use cases 
of this dialog IMHO. Ideas: Add something to the tooltip? Add a gray text (e.g. 
"Type to search or enter full path" – exact formulation could be better) to the 
line edit which is currently just empty?
  
  That said, I would suggest to just commit this patch as is and work on any 
further improvements in a followup patch (just wanted to put this out there to 
give a complete picture).
  
  ---
  
  In addition to the screenshot in https://phabricator.kde.org/D8056#159491, 
the dialog is used when opening `kcmshell5 filetypes` and then navigating 
"text" > "css" > Application Preference Order > Add…. Note the bold text 
(although I wish the colon in front of it could go):
  
  F5478956: app-chooser.png 
  
  I'm showing this because there is actually a mention of "If the program is 
not listed…". In the end both dialogs should be consistent in intro text, line 
edit background text and tooltip help text. I'd be happy to help implementing 
any adaptations in wording once we've reached a conclusion here.

INLINE COMMENTS

> dfaure wrote in kopenwithdialog.cpp:826
> Please use QRegularExpression; QRegExp is deprecated.
> 
> Although, if this is about FixedString, why not just use setFilterFixedString?
> Regexps are slow, better avoid them when not necessary.

@simgunz This is marked as done, but still uses `QRegExp` and not 
`QRegularExpression`?

> kopenwithdialog.cpp:1099
> +// FIXME: Disable arrow down in CompletionPopup and 
> CompletionPopupAuto only when the dropdown list is shown.
> +// When popup completion mode is used the down arrow is used to 
> navigate the dropdown list of results
> +if (combo->completionMode() != KCompletion::CompletionPopup && 
> combo->completionMode() != KCompletion::CompletionPopupAuto) {

Is this a "fixme-before-commit" or a "fixme-sometimes-in-the-future" FIXME?

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham
Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8683: Only prevent the name to update if it's empty

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8683

AFFECTED FILES
  src/core/kfileitem.cpp

To: apol, #frameworks, dfaure

D8643: Fix display of remote:/ in the qfiledialog

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> apol wrote in kfileitem.cpp:559
> My thinking was that if the display name was set through the UDSEntry, one 
> would want it to continue coming from a UDSEntry. e.g. if 
> `file:///boring.txt` display name is `Magnificient Text File` and we change 
> its url into `file:///boring2.txt` we would still want the same. Or we'd 
> issue a new UDSEntry.
> 
> I'm happy to change it to
> 
>   -if (!d->m_entry.contains(KIO::UDSEntry::UDS_DISPLAY_NAME)) {
>   +if (!d->m_strName.isEmpty()) {
> 
> It was my first approach in fact, it worked fine.

https://phabricator.kde.org/D8683

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8643

To: apol, #frameworks, davidedmundson
Cc: dfaure, ngraham

D8590: KPageListView: Update width on font change

[Henrik Fehlauer]

rkflx accepted this revision.
rkflx added a comment.


  Since I was added as a reviewer:
  
  - Tested with `KWordQuiz`: No app restart necessary anymore to adapt width to 
changed font.
  - Code looks simple enough and even passes the event to the base class.
  
  Perfect patch, thanks :)
  
  (Minor comment: You could have added some instructions to the test plan, 
saving me some time.)

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  KPageListView-updateWidth

REVISION DETAIL
  https://phabricator.kde.org/D8590

To: volkov, cfeck, wojnilowicz, dfaure, rkflx, broulik
Cc: #frameworks

D8592: Update default colors to match new colors in D7424

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:8bff75d10fa3: Update default colors to match new colors 
in D7424 (authored by ngraham).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8592?vs=21698&id=21978

REVISION DETAIL
  https://phabricator.kde.org/D8592

AFFECTED FILES
  src/kcolorscheme.cpp

To: ngraham, #frameworks, broulik, #vdg
Cc: jensreuterberg, #frameworks

D8592: Update default colors to match new colors in D7424

[Jens Reuterberg]

jensreuterberg added a comment.


  +1 but as with the original proposal - remember that we may need to revert 
this if the change balloons out of control

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D8592

To: ngraham, #frameworks, broulik, #vdg
Cc: jensreuterberg, #frameworks

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 134 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/134/
 Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
 Date of build:
Mon, 06 Nov 2017 14:18:34 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)62%
(57/92)62%
(57/92)38%
(3501/9225)26%
(1859/7152)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(22/22)100%
(22/22)76%
(607/795)38%
(390/1028)src.declarativeimports.core57%
(4/7)57%
(4/7)28%
(246/878)14%
(85/616)src.plasma62%
(13/21)62%
(13/21)40%
(1420/3581)29%
(773/2697)src.plasma.private46%
(11/24)46%
(11/24)39%
(649/1649)28%
(303/1080)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/190)0%
(0/126)src.plasmaquick50%
(6/12)50%
(6/12)27%
(548/2019)19%
(302/1583)src.plasmaquick.private33%
(1/3)33%
(1/3)27%
(31/113)27%
(6/22)

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 138 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/138/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
 Date of build:
Mon, 06 Nov 2017 14:18:35 +
 Build duration:
3 min 26 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D8638: Remove DataModel::roleNameToId

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:d51456bdfcbd: Remove DataModel::roleNameToId (authored by 
broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8638?vs=21831&id=21965

REVISION DETAIL
  https://phabricator.kde.org/D8638

AFFECTED FILES
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h

To: broulik, #plasma, mwolff
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8639: Optimize SortFilterModel role names

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:3ebdd64e6bbd: Optimize SortFilterModel role names 
(authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8639?vs=21832&id=21966

REVISION DETAIL
  https://phabricator.kde.org/D8639

AFFECTED FILES
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h

To: broulik, #plasma, mwolff
Cc: mwolff, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In https://phabricator.kde.org/D7823#164880, @marten wrote:
  
  > In https://phabricator.kde.org/D7823#164879, @cfeck wrote:
  >
  > > Are the copies in the attic directory still needed for compatibility 
reasons, or can they get removed?
  >
  >
  > No needed by anything within Frameworks, Plasma or Applications as far as 
I'm aware.  Shall I remove them?
  
  
  Yes, please

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D7823

To: marten, #frameworks, #build_system, cgiboudeaux
Cc: cgiboudeaux, cfeck, heikobecker

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

[Jonathan Marten]

marten added a comment.


  In https://phabricator.kde.org/D7823#164879, @cfeck wrote:
  
  > Are the copies in the attic directory still needed for compatibility 
reasons, or can they get removed?
  
  
  No needed by anything within Frameworks, Plasma or Applications as far as I'm 
aware.  Shall I remove them?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D7823

To: marten, #frameworks, #build_system, cgiboudeaux
Cc: cgiboudeaux, cfeck, heikobecker

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

[Christoph Feck]

cfeck added a comment.


  Are the copies in the attic directory still needed for compatibility reasons, 
or can they get removed?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D7823

To: marten, #frameworks, #build_system, cgiboudeaux
Cc: cgiboudeaux, cfeck, heikobecker

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

[Jonathan Marten]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:ee5b036c1df4: Add FindGLIB2.cmake and 
FindPulseAudio.cmake (authored by marten).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D7823?vs=19611&id=21961#toc

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7823?vs=19611&id=21961

REVISION DETAIL
  https://phabricator.kde.org/D7823

AFFECTED FILES
  docs/find-module/FindGLIB2.rst
  docs/find-module/FindPulseAudio.rst
  find-modules/FindGLIB2.cmake
  find-modules/FindPulseAudio.cmake

To: marten, #frameworks, #build_system, cgiboudeaux
Cc: cgiboudeaux, cfeck, heikobecker

D8643: Fix display of remote:/ in the qfiledialog

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> dfaure wrote in kfileitem.cpp:559
> Wouldn't it be safer to say if (!name.isEmpty()), for the actual bug you were 
> experiencing?
> 
> Otherwise I'm afraid that this commit breaks a number of things, like after 
> renaming a file, the new name doesn't appear because the old "display name" 
> still applies, or the documented use case for setName which is kfind wanting 
> to display subdir/subsubdir/file.txt (same issue, UDS_DISPLAY_NAME would 
> prevent that from working).

My thinking was that if the display name was set through the UDSEntry, one 
would want it to continue coming from a UDSEntry. e.g. if `file:///boring.txt` 
display name is `Magnificient Text File` and we change its url into 
`file:///boring2.txt` we would still want the same. Or we'd issue a new 
UDSEntry.

I'm happy to change it to

  -if (!d->m_entry.contains(KIO::UDSEntry::UDS_DISPLAY_NAME)) {
  +if (!d->m_strName.isEmpty()) {

It was my first approach in fact, it worked fine.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8643

To: apol, #frameworks, davidedmundson
Cc: dfaure, ngraham

D8640: [KDirModel] Emit change for HasJobRole when jobs change

[Kai Uwe Broulik]

broulik updated this revision to Diff 21954.
broulik added a comment.


  - `constBegin()` on `m_allCurrentDestUrls`
  - Use `indexForNode`

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8640?vs=21835&id=21954

REVISION DETAIL
  https://phabricator.kde.org/D8640

AFFECTED FILES
  src/widgets/kdirmodel.cpp

To: broulik, #frameworks, dfaure, hein, mwolff

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 95 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/95/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
 Date of build:
Mon, 06 Nov 2017 11:01:19 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.completion_test

D8577: Fix: Missing dependencies for ktexeditor autotests

[Kevin Funk]

kfunk added a comment.


  In https://phabricator.kde.org/D8577#164815, @cullmann wrote:
  
  > Could you just remove the problematic includes and try to compile without 
the dependency, IMHO I see no use of QtScript stuff.
  
  
  Done with: 
https://phabricator.kde.org/R39:631b1447c97f1d81de2e81d2556474f0bc3109dd

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8577

To: hgoebel, #ktexteditor, dfaure
Cc: kfunk, cullmann, dhaumann, #frameworks, kevinapavew, demsking, sars

D8577: Fix: Missing dependencies for ktexeditor autotests

[Hartmut Goebel]

hgoebel added a comment.


  My aim is to bring Plasma into GuixSD, not to develop ktexteditor. So please 
understand that I'm not going to work on ktexteditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8577

To: hgoebel, #ktexteditor, dfaure
Cc: cullmann, dhaumann, #frameworks, kevinapavew, demsking, sars

D8577: Fix: Missing dependencies for ktexeditor autotests

[Christoph Cullmann]

cullmann added a comment.


  Could you just remove the problematic includes and try to compile without the 
dependency, IMHO I see no use of QtScript stuff.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8577

To: hgoebel, #ktexteditor, dfaure
Cc: cullmann, dhaumann, #frameworks, kevinapavew, demsking, sars

D8577: Fix: Missing dependencies for ktexeditor autotests

[Hartmut Goebel]

hgoebel added a comment.


  Well, the currently the dependency is still needed, see 
https://cgit.kde.org/ktexteditor.git/tree/autotests/src/scripting_test.cpp#n51:
  
#include 
  
  If the code is not compiled in an isolated and controlled environment, and 
QtScript is installed on the system, the compiler might silently get the 
includes installed elsewhere. The same is true, if some QT package requires 
QtScript and QtScript is installed alongside that package.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8577

To: hgoebel, #ktexteditor, dfaure
Cc: cullmann, dhaumann, #frameworks, kevinapavew, demsking, sars