D8683: Only prevent the name to update if it's empty

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8683

To: apol, #frameworks, dfaure

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kopenwithdialog.cpp:463
>  
> -if (d->appModel && !d->appModel->isDirectory(current)) {
> -QString exec = d->appModel->execFor(current);
> +QModelIndex sourceCurrent = static_cast *>(model())->mapToSource(current);
> +

Use the member var instead of casting.

> kopenwithdialog.cpp:830
> +//Update the filter regexp with the new text in the lineedit
> +static_cast *>(d->view->model())->setFilterFixedString(d->edit->text());
> +

Could the view have a method that returns the proxymodel (possibly as a 
QSortFilterProxyModel* if we don't actually need a subclass-typed pointer), to 
avoid this cast?
Such casts make refactoring more difficult, moving problems from compile-time 
to runtime.

> kopenwithdialog.cpp:1108
> +}
> +return false;
> +}

All this "return false" cascade isn't really needed, a single return false at 
the end would do the job, or even better, calling the eventFilter method of the 
base class, just in case that's implemented for other reasons.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[David Faure]

dfaure added a comment.


  Yes, feel free to kill the hidden setting for completion, especially if the 
default value isn't the one that gives the best user experience.

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8696: Don't autoremove empty temp file

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  fix-empty-qtemporaryfile

REVISION DETAIL
  https://phabricator.kde.org/D8696

To: elvisangelaccio, dfaure
Cc: #frameworks

D8697: Don't check whether an empty filename exists

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  fix-empty-exists

REVISION DETAIL
  https://phabricator.kde.org/D8697

To: elvisangelaccio, dfaure
Cc: #frameworks

D8705: Remove Qt5::Widgets as a dependency

[Anthony Fieroni]

anthonyfieroni added a comment.


  One more place -> kselectionowner.cpp:37
  Dropping can't be done before KF6 :)

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D8705

To: apol, #frameworks
Cc: anthonyfieroni

D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Example for custom rendering in KDevelop as currently proposed with the 
matching KDevelop patch https://phabricator.kde.org/D8709:
  F5481057: Screenshot_20171108_013745.png 


REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8708

To: kossebau
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D8710: Fix VI-Mode buffer commands

[Christoph Roick]

croick created this revision.
croick added a reviewer: KTextEditor.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  - :tabclose currently makes kate crash.
  - Switching tabs with commands like :bp or :tabp only works once due to loss 
of focus. The user must click into the view to reactivate it.
  - Fix crash when switching documents with :b filename

TEST PLAN
  - use :tabclose to close a document
  - switch documents several times with :bp, :tabn, etc.
  - use :b filename to switch to corresponding tab

REPOSITORY
  R39 KTextEditor

BRANCH
  viedit

REVISION DETAIL
  https://phabricator.kde.org/D8710

AFFECTED FILES
  src/vimode/appcommands.cpp
  src/vimode/appcommands.h
  src/vimode/emulatedcommandbar/commandmode.cpp

To: croick, #ktexteditor
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

[Friedrich W . H . Kossebau]

kossebau added a dependent revision: D8709: [WIP] Add 
VcsAnnotationItemDelegate, for control of rendering, menus and tooltip.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8708

To: kossebau
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

[Friedrich W . H . Kossebau]

kossebau created this revision.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  The AbstractAnnotationItemDelegate is modelled after QAbstractItemDelegate
  and should allow consumers of the annotation interfaces to customize the
  rendering, the context menu and the tooltip per annotation as wanted.
  
  Yet to be solved:
  
  - whether, and if how, to adapt to zoomed content
  - which UI font to recommend if not wanting to use content font
  - tooltip hiding API (and perhaps support for async shown tooltips)
  
  and some other TODOs spread over the patch
  
  Done together with some new patches for KDevelop.

REPOSITORY
  R39 KTextEditor

BRANCH
  addAnnotationItemDelegate

REVISION DETAIL
  https://phabricator.kde.org/D8708

AFFECTED FILES
  src/CMakeLists.txt
  src/include/CMakeLists.txt
  src/include/ktexteditor/abstractannotationitemdelegate.h
  src/include/ktexteditor/annotationinterface.h
  src/view/kateannotationitemdelegate.cpp
  src/view/kateannotationitemdelegate.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h
  src/view/kateviewinternal.h

To: kossebau
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D8705: Remove Qt5::Widgets as a dependency

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Make it a private dependency for now, until we can possibly drop it from the
  library

TEST PLAN
  Built the rest of projects, including plasma, will send few patches

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8705

AFFECTED FILES
  KF5WindowSystemConfig.cmake.in
  src/CMakeLists.txt
  src/kstartupinfo.h
  src/kwindoweffects.h
  src/kwindowinfo.h
  src/kwindowinfo_p.h
  src/kwindowsystem.h
  src/kwindowsystem_p.h
  src/kwindowsystemplugininterface_p.h
  src/platforms/xcb/kwindowsystem.cpp
  src/platforms/xcb/netwm.h
  src/pluginwrapper_p.h

To: apol, #frameworks

D7272: [DropJob] Enable drag and drop in a read-only folder

[Nathaniel Graham]

ngraham added a comment.


  How are we doing here?

REVISION DETAIL
  https://phabricator.kde.org/D7272

To: chinmoyr, #frameworks, dfaure
Cc: ngraham

D7430: Add unit test

[Nathaniel Graham]

ngraham added a comment.


  How are we doing here?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7430

To: chinmoyr, dfaure
Cc: ngraham, #frameworks

D8332: Added baloo urls into places model

[Nathaniel Graham]

ngraham added a comment.


  @ervin and @dvratil, any remaining concerns?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8332

To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, 
ervin, mlaurent
Cc: dfaure, ervin, usta, mlaurent, dvratil, ngraham, #frameworks

D8698: Fix KProtolInfoTest if krusader is installed

[Nathaniel Graham]

ngraham added a comment.


  Is the same problem present in the non-test code? I just noticed 
https://bugs.kde.org/show_bug.cgi?id=384991, which seems to report a similar or 
identical issue.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8698

To: elvisangelaccio, dfaure
Cc: ngraham, #frameworks

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 135 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/135/
 Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
 Date of build:
Tue, 07 Nov 2017 20:19:20 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)62%
(57/92)62%
(57/92)38%
(3501/9225)26%
(1859/7152)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(22/22)100%
(22/22)76%
(607/795)38%
(390/1028)src.declarativeimports.core57%
(4/7)57%
(4/7)28%
(246/878)14%
(85/616)src.plasma62%
(13/21)62%
(13/21)40%
(1420/3581)29%
(773/2697)src.plasma.private46%
(11/24)46%
(11/24)39%
(649/1649)28%
(303/1080)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/190)0%
(0/126)src.plasmaquick50%
(6/12)50%
(6/12)27%
(548/2019)19%
(302/1583)src.plasmaquick.private33%
(1/3)33%
(1/3)27%
(31/113)27%
(6/22)

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 139 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/139/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
 Date of build:
Tue, 07 Nov 2017 20:19:20 +
 Build duration:
4 min 14 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Nathaniel Graham]

ngraham added a comment.


  IMO popup completion is rendered obsolete by the new filter behavior, which 
is much nicer. We might consider just removing it.

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

simgunz marked an inline comment as done.
simgunz added a comment.


  > @simgunz If you have no further changes planned for this Diff and 
https://phabricator.kde.org/D8670, I could land both on your behalf. Contact 
information of non-developers are private by default on identity.kde.org, but I 
found some in https://github.com/simgunz/redshift-plasmoid. Are those okay to 
use for the authorship (name + email)?
  
  I don't need to add anything so you can land both. The contact information 
you have found are fine. Is it there a way to make my contact info in kde 
identity public? I couldn't find an option for it.
  
  > Stumbled upon this too some time ago, amazingly you used the very same 
workaround I applied back then. Looking at 
https://en.wikipedia.org/wiki/Esc_key the similar looking glyph seems 
intentional, so I don't see a chance to convince Phab upstream to change this. 
Just embrace and use it, maybe we all get accustomed after a while :) At least 
we get tooltips for all those symbols: [⎋] + [⌘] + [⌥]
  
  Wow. Never saw that glyph before. One never finish learning.
  
  > As for the [↓] and completion popup issues, the root cause seems to be that 
we have one input line but two overlapping "lists", which is really weird 
conceptually and gets complex quite fast as you noticed. A (quick to talk 
about, slow to implement) idea would be to get rid of the completion popup even 
for advanced users and merge those results (recent inputs, but also some other 
search results like `kmimetypefinder` which are not even in a category!?) into 
the list view as a new section.
  > 
  > This definitely needs more thinking, no need to rush…
  
  Yes, doesn't seems trivial. We can talk about it.
  
  One last note on this modification. Given that the previous default was to 
use `PopupCompletion`, it means that most of the users out there have this 
setting configured. And if they are like me, most of them don't even know they 
can change this behavior. If there will be any type of announcement or 
changelog regarding this change, it may be useful to explicitly suggest to 
change to completion `None` in order to fully enjoy the new feature without the 
popup covering the tree.

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Henrik Fehlauer]

rkflx accepted this revision.
rkflx added a comment.


  @dfaure Could we get your green (for real, on Phab :) light from a Frameworks 
point of view for this Diff?
  
  @simgunz If you have no further changes planned for this Diff and 
https://phabricator.kde.org/D8670, I could land both on your behalf. Contact 
information of non-developers are private by default on identity.kde.org, but I 
found some in https://github.com/simgunz/redshift-plasmoid. Are those okay to 
use for the authorship (name + email)?
  
  ---
  
  > Just for my mental sanity, what is the remarkup syntax to make the ESC key? 
key Esc or Escape shows a hammer and sickle :-)
  
  Stumbled upon this too some time ago, amazingly you used the very same 
workaround I applied back then. Looking at 
https://en.wikipedia.org/wiki/Esc_key the similar looking glyph seems 
intentional, so I don't see a chance to convince Phab upstream to change this. 
Just embrace and use it, maybe we all get accustomed after a while :) At least 
we get tooltips for all those symbols: [⎋] + [⌘] + [⌥]
  
  > I agree in opening a new task to talk about the proposed points.
  
  Great, I'll try to get this done on the weekend (need to digest your forum 
post and bugzillas first).
  
  As for the [↓] and completion popup issues, the root cause seems to be that 
we have one input line but two overlapping "lists", which is really weird 
conceptually and gets complex quite fast as you noticed. A (quick to talk 
about, slow to implement) idea would be to get rid of the completion popup even 
for advanced users and merge those results (recent inputs, but also some other 
search results like `kmimetypefinder` which are not even in a category!?) into 
the list view as a new section.
  
  This definitely needs more thinking, no need to rush…

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8652: Add supported transformations to OutputDevice

[Sebastian Kügler]

sebas accepted this revision.
sebas added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> outputdevice.h:244
> + * @returns The transformations supported on this OutputDevice
> + * @since 5.XX
> + * @see supportedTransformationAdded

5.40 I guess :)

> outputdevice_interface.h:133
> + * Due to that there is no remove operation for supported 
> transformations.
> + * @since 5.XX
> + **/

5.40

REPOSITORY
  R127 KWayland

BRANCH
  supported-transformations

REVISION DETAIL
  https://phabricator.kde.org/D8652

To: graesslin, #frameworks, #kwin, #plasma, sebas
Cc: sebas, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, apol, mart

D8696: Don't autoremove empty temp file

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Since 5.10 (commit 0dee566e98 in qtbase) Qt complains if we make a
  system call with an empty filename (with a "Empty filename passed to
  function" runtime warning).
  
  I even hit an assert with my self-compiled build:
  
ASSERT: "unnamedFile == d_func()->fileEntry.isEmpty()"
  
  (in qtemporaryfile.cpp, line 514).
  
  The problem is that after `socketfile.remove()` we get an empty
  `fileName()` which will be a problem when the QTemporaryFile gets
  destroyed at the end of the if() block.
  To avoid this issue we disable the autoremove mode.

TEST PLAN
  No longer get the runtime warning every time a file item gets hovered in 
KFileWidget.

REPOSITORY
  R241 KIO

BRANCH
  fix-empty-qtemporaryfile

REVISION DETAIL
  https://phabricator.kde.org/D8696

AFFECTED FILES
  src/core/connectionbackend.cpp

To: elvisangelaccio, dfaure
Cc: #frameworks

D8698: Fix KProtolInfoTest if krusader is installed

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Krusader has a `krarc` ioslave that handles zip files. If krusader is
  installed, `testProtocolForArchiveMimetype` randomly fails depending on
  the order the `zip` and `krarc` protocols are added to the cache.
  
  This patch makes sure the test always passes.

TEST PLAN
  Run `kprotocolinfotest` with krusader installed.

REPOSITORY
  R241 KIO

BRANCH
  kprotocolinfo-krarc

REVISION DETAIL
  https://phabricator.kde.org/D8698

AFFECTED FILES
  autotests/kprotocolinfotest.cpp

To: elvisangelaccio, dfaure
Cc: #frameworks

D8697: Don't check whether an empty filename exists

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Since 5.10 (commit 0dee566e98 in qtbase) Qt complains if we make a
  system call with an empty filename (with a "Empty filename passed to
  function" runtime warning).
  
  There is no reason to call `exists()` if we already know that a filename
  is empty. While at it, port to `QFileInfo::exists()` which is faster.

TEST PLAN
  Together with https://phabricator.kde.org/D8696, fixes all the runtime 
warnings when running `tests/kfilewidgettest_gui`.

REPOSITORY
  R241 KIO

BRANCH
  fix-empty-exists

REVISION DETAIL
  https://phabricator.kde.org/D8697

AFFECTED FILES
  src/core/knfsshare.cpp
  src/core/ksambashare.cpp

To: elvisangelaccio, dfaure
Cc: #frameworks

D8691: add some metadata

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  phab/moduledata

REVISION DETAIL
  https://phabricator.kde.org/D8691

To: mart, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8691: add some metadata

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  accessible by the qml implementations

TEST PLAN
  the properties kcm.name and kcm.description are accessible from the qml part 
of
  the cursortheme kcm

REPOSITORY
  R296 KDeclarative

BRANCH
  phab/moduledata

REVISION DETAIL
  https://phabricator.kde.org/D8691

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: mart, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8281: Allow to use IcoTool for Windows icons

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> FindIcoTool.cmake:1
> +# Copyright 2017 Vincent Pinon 
> +include(${CMAKE_CURRENT_LIST_DIR}/ECMFindModuleHelpersStub.cmake)

This module doesn't have any license and doesn't provide any doc.

> FindIcoTool.cmake:3
> +include(${CMAKE_CURRENT_LIST_DIR}/ECMFindModuleHelpersStub.cmake)
> +ecm_find_package_version_check(IcoTool)
> +find_program(IcoTool_EXECUTABLE NAMES icotool)

Is this really needed for a simple Find*.cmake module ?

> ECMAddAppIcon.cmake:29
>  #  target does not have the ``WIN32_EXECUTABLE`` property set.
> -#* The tool png2ico is required. See :find-module:`FindPng2Ico`.
> +#* The tools png2ico or icotool are required.
> +#  See :find-module:`FindPng2Ico` or :find-module:`FindIcotool`.

I'm unsure about the grammar here. Only one is needed (and none is required 
according to this file).

> ECMAddAppIcon.cmake:30
> +#* The tools png2ico or icotool are required.
> +#  See :find-module:`FindPng2Ico` or :find-module:`FindIcotool`.
>  #* Supported sizes: 16, 32, 48, 64, 128.

Don't forget to create the matching .rst file in docs/find-module

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8281

To: vpinon, dfaure, apol, kfunk, #windows
Cc: cgiboudeaux, #frameworks, #build_system

Re: Python bindings using cppyy (was: An update on Python bindings)

[Shaheed Haque]

I have made an attempt to get roughly all the bindings I was previously
attempting with SIP to be (a) generated and (b) built.

As of now, we have:

- Customisations with a diffstat that reads "21 files changed, 20
insertions(+), 48 deletions(-)".
- All but 5-6 of the formal tier 1, 2 and 3 frameworks [1] building.
- Of the wider set of 111 informal frameworks [2] I have all but 14
building.

Most of the customisations are to workaround missing dependencies in the
CMake descriptions.Most of the build issues are compile-issues (e.g.
incomplete #includes, or incorrect -I settings), but there are at least 2
that look like cppyy issues. This is pretty solid proof that building atop
technology that is based on LLVM and Cling can trivially process at least
these KDE sources (including templates, overloads, operators, and the rest).

Oh, and it has taken about a month to get here. As a baseline, the
SIP-based attempt took about 18 months, several thousand lines of custom
rules (including a lot of deleting overloads, operators and templates that
could not be handled) to get a little over half the bindings through steps
a and b. The build takes about 10 minutes on a single core, versus about
3-4 hours with the SIP-based attempt.

More anon...

Thanks, Shaheed

[1] https://api.kde.org/frameworks/
[2] More liberally defined than [1], corresponding to what Ubuntu installs
as "libkf5xxx" packages. This include [1].

D8281: Allow to use IcoTool for Windows icons

[Aleix Pol Gonzalez]

apol added a reviewer: Windows.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8281

To: vpinon, dfaure, apol, kfunk, #windows
Cc: #frameworks, #build_system

D8689: Fix the result of KDesktopFile::sortOrder()

[Alexander Volkov]

volkov added a reviewer: Frameworks.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8689

To: volkov, #frameworks
Cc: #frameworks

D8689: Fix the result of KDesktopFile::sortOrder()

[Alexander Volkov]

volkov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  KDesktopFile::sortOrder() returns the value of SortOrder key
  as a string whithout parsing it as a list.
  But according to Desktop Entry Specification
  
https://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
  it's type is "string(s)", i.e. the same type as the type of
  Actions and MimeType keys, and thus it should be read the same way.

REPOSITORY
  R237 KConfig

BRANCH
  fix-sort-order

REVISION DETAIL
  https://phabricator.kde.org/D8689

AFFECTED FILES
  autotests/kdesktopfiletest.cpp
  autotests/kdesktopfiletest.h
  src/core/kdesktopfile.cpp

To: volkov
Cc: #frameworks

D8173: Use readelf to find project dependencies

[Marco Martin]

mart added a comment.


  +1

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8173

To: apol, #frameworks, #build_system, aacid
Cc: mart