D8434: Created 'remote' section

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.


  Seems ok for me now.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8434

To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure
Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks

D8705: Remove Qt5::Widgets as a dependency

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  That is indeed source incompatible (apart from the change to the _p.h 
headers). You can either just add a "TODO KF6" comment, or provide a cmake 
option for linking to QtWidgets, but it needs to be on by default to keep 
source compat.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D8705

To: apol, #frameworks, dfaure
Cc: graesslin, dfaure, anthonyfieroni

D8098: Strip down and re-write the tags KIO slave.

[James Smith]

smithjd updated this revision to Diff 22107.
smithjd added a comment.


  - Merge local and tag file handling.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8098?vs=21851=22107

BRANCH
  master-nestedTags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D8098

AFFECTED FILES
  src/kioslaves/tags/kio_tags.cpp
  src/kioslaves/tags/kio_tags.h
  src/kioslaves/tags/tags.protocol

To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure
Cc: dfaure, nicolasfella, ngraham

D8536: Add more hashing algorithms to KPropertiesDialog

[Anthony Fieroni]

anthonyfieroni added a comment.


  In https://phabricator.kde.org/D8536#165865, @elvisangelaccio wrote:
  
  > As I mentioned, using //only// a combobox doesn't work, because the main 
functionality (= check integrity of downloaded files) is now harder to use.
  
  
  In other hand moslty user check one of following algorithms i.e. when i check 
a downloaded file i validate sha256, so i selected it in combobox (if needed) 
then paste expected. In most of time *one* prefered algorithm is used.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8536

To: petermajchrak, elvisangelaccio
Cc: anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 135 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/135/
 Project:
Frameworks kio kf5-qt5 XenialQt5.7
 Date of build:
Wed, 08 Nov 2017 18:29:39 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(22/22)80%
(278/346)80%
(278/346)57%
(30024/52384)42%
(16584/39374)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(67/67)100%
(67/67)96%
(8078/8399)51%
(4501/8824)autotests.http100%
(9/9)100%
(9/9)100%
(543/544)60%
(200/336)autotests.kcookiejar100%
(1/1)100%
(1/1)90%
(179/198)67%
(60/90)src.core85%
(99/117)85%
(99/117)57%
(8141/14200)49%
(4549/9281)src.core.kssl100%
(1/1)100%
(1/1)38%
(35/93)50%
(3/6)src.filewidgets73%
(27/37)73%
(27/37)46%
(3570/7729)30%
(1330/4476)src.gui100%
(2/2)100%
(2/2)95%
(104/110)75%
(54/72)src.ioslaves.file100%
(2/2)100%
(2/2)51%
(435/849)42%
(317/749)src.ioslaves.http100%
(8/8)100%
(8/8)47%
(1762/3782)38%
(1317/3462)src.ioslaves.http.kcookiejar100%
(2/2)100%
(2/2)80%
(622/782)72%
(608/839)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(70/258)8%
(16/200)src.ioslaves.trash80%
(8/10)80%
(8/10)60%
(704/1173)47%
(404/851)src.ioslaves.trash.tests100%
(2/2)100%
(2/2)90%
(707/785)48%
(461/970)src.kioslave100%
(1/1)100%
(1/1)52%
(14/27)50%
(5/10)src.kntlm100%
(2/2)100%
(2/2)97%
(373/385)80%
(111/138)src.kpasswdserver100%
(2/2)100%
(2/2)63%
(377/594)48%
(280/580)src.kpasswdserver.autotests100%
(1/1)100%
(1/1)99%
(283/286)57%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 136 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/136/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
 Date of build:
Wed, 08 Nov 2017 18:29:39 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: TestSuite.kiocore-threadtest

D8536: Add more hashing algorithms to KPropertiesDialog

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kpropertiesdialog.cpp:2657
> +class KChecksumAlgorithmListModel: public QAbstractListModel {
> +QVector algorithms;
> +

Make it static const and initialize it here.

> kpropertiesdialog.cpp:2681-2682
> +QVariant data(const QModelIndex , int role) const override {
> +if (!index.isValid())
> +return QVariant();
> +

Use braces {} even on one line block in all places.

> kpropertiesdialog.cpp:2757
>  {
> -auto label = new QLabel(i18nc("@action:button", "Calculating..."), 
> >m_widget);
> -label->setTextInteractionFlags(Qt::TextSelectableByMouse | 
> Qt::TextSelectableByKeyboard);
> -
> -d->m_ui.calculateWidget->layout()->replaceWidget(d->m_ui.sha1Button, 
> label);
> -d->m_ui.sha1Button->hide();
> -
> -showChecksum(QCryptographicHash::Sha1, label, d->m_ui.sha1CopyButton);
> -}
> -
> -void KChecksumsPlugin::slotShowSha256()
> -{
> -auto label = new QLabel(i18nc("@action:button", "Calculating..."), 
> >m_widget);
> -label->setTextInteractionFlags(Qt::TextSelectableByMouse | 
> Qt::TextSelectableByKeyboard);
> -
> -d->m_ui.calculateWidget->layout()->replaceWidget(d->m_ui.sha256Button, 
> label);
> -d->m_ui.sha256Button->hide();
> -
> -showChecksum(QCryptographicHash::Sha256, label, 
> d->m_ui.sha256CopyButton);
> -}
> -
> -void KChecksumsPlugin::slotVerifyChecksum(const QString )
> -{
> -auto algorithm = detectAlgorithm(input);
> -
> -// Input is not a supported hash algorithm.
> -if (algorithm == QCryptographicHash::Md4) {
> -if (input.isEmpty()) {
> -setDefaultState();
> -} else {
> -setInvalidChecksumState();
> -}
> +if (algorithms.isEmpty()){
>  return;

1 space between ) { in all places

> kpropertiesdialog.cpp:2777-2794
>  auto futureWatcher = new QFutureWatcher(this);
>  connect(futureWatcher, ::finished, this, [=]() {
> -
>  const QString checksum = futureWatcher->result();
>  futureWatcher->deleteLater();
>  
> -cacheChecksum(checksum, algorithm);
> -
> -switch (algorithm) {
> -case QCryptographicHash::Md5:
> -slotShowMd5();
> -break;
> -case QCryptographicHash::Sha1:
> -slotShowSha1();
> -break;
> -case QCryptographicHash::Sha256:
> -slotShowSha256();
> -break;
> -default:
> -break;
> -}
> +showChecksum(algorithm);
>  

Why not create all watchers in a loop not in recursion. When you use non-const 
QVector it can't garanteed that it'll not make a deep copy.

  verifyChecksumRecursive(input, std::move(algorithms));

?

> kpropertiesdialog.cpp:2782
>  
> -cacheChecksum(checksum, algorithm);
> -
> -switch (algorithm) {
> -case QCryptographicHash::Md5:
> -slotShowMd5();
> -break;
> -case QCryptographicHash::Sha1:
> -slotShowSha1();
> -break;
> -case QCryptographicHash::Sha256:
> -slotShowSha256();
> -break;
> -default:
> -break;
> -}
> +showChecksum(algorithm);
>  

Are you sure about calling this function in all watchers?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8536

To: petermajchrak, elvisangelaccio
Cc: anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Henrik Fehlauer]

rkflx added a comment.


  In https://phabricator.kde.org/D8056#165453, @simgunz wrote:
  
  > Is it there a way to make my contact info in kde identity public? I 
couldn't find an option for it.
  
  
  There is no such option yet, as far as I know. Turns out as you used `arc` to 
upload your patch (good job!) instead of the web upload, it was already 
included and I would not have needed to ask…
  
  > One last note on this modification. Given that the previous default was to 
use `PopupCompletion`, it means that most of the users out there have this 
setting configured. If there will be any type of announcement or changelog 
regarding this change, it may be useful to explicitly suggest to change to 
completion `None` in order to fully enjoy the new feature without the popup 
covering the tree.
  
  I see were you are coming from, but not sure this would work, would also be a 
bit weird to read. I remember some distro release notes advising on manual 
changes of high importance, but listing every little change would probably be 
too much. The closest would be someone with a blog aggregated on Planet KDE 
featuring this improvement (@ngraham you should totally start a blog, as I 
believe you have a quite good overview on what's happening each week in 
Phabricator land).
  
  Normally such changes can be automated with `kconf_update` 
. Recently, I 
did something similar  
(with a perl detour 
). Instead of 
copying you would have to set a new value explicitly and touch more than one 
file (e.g. `dolphinrc` and everywhere else the dialog is used). You can try 
this direction, but we could also just wait and see what further changes are 
possible for the dialog.
  
  In https://phabricator.kde.org/D8056#165455, @ngraham wrote:
  
  > IMO popup completion is rendered obsolete by the new filter behavior, which 
is much nicer. We might consider just removing it.
  
  
  
  
  In https://phabricator.kde.org/D8056#165599, @dfaure wrote:
  
  > Yes, feel free to kill the hidden setting for completion, especially if the 
default value isn't the one that gives the best user experience.
  
  
  As I wrote above, this would mean two things (I believe both should still be 
supported, in one form or another at least):
  
  - An important use case is to enter a custom path. Having a recent history of 
those paths to avoid typing/selecting them over and over again is useful. The 
history can still be accessed via the arrow on the right, but the completion 
would be gone.
  - There would be no way anymore to autocomplete or discover anything 
contained in your `$PATH` (e.g. your own/custom scripts), safe for typing it 
out in full.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8670: Change label "Advanced options" > "Terminal options"

[Henrik Fehlauer]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:83595ebd5636: Change label Advanced options 
 Terminal options (authored by simgunz, committed by rkflx).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8670?vs=21926=22096

REVISION DETAIL
  https://phabricator.kde.org/D8670

AFFECTED FILES
  src/widgets/kopenwithdialog.cpp

To: simgunz, dfaure, ngraham, fabianr
Cc: #frameworks

D8728: Install mimetype definitions for kcfg/kcfgc/ui.rc/knotify & qrc files

[Friedrich W . H . Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kde5.xml:3647
>
> +  
> +Qt Resource Collection file

This one surely should be also added to shared-mime-info, once proposed name 
and details have been checked.

Anyone up for that task, ideally someone who could run this also across Qt 
contributor eyes?
Surprised that one has not yet been added there.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D8728

To: kossebau, #frameworks

D8728: Install mimetype definitions for kcfg/kcfgc/ui.rc/knotify & qrc files

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  When browsing folders of sources with KDE software, e.g. in Dolphin or
  KDevelop, there are currently quite some files shown to be only simple text
  files, despite being well-known special ones.
  
  This patch adds mimetypes for a few typical special formats as used in
  software building on KDE Frameworks and Qt.

REPOSITORY
  R244 KCoreAddons

BRANCH
  mimetypesforkfdevelopmentfiles

REVISION DETAIL
  https://phabricator.kde.org/D8728

AFFECTED FILES
  src/mimetypes/kde5.xml

To: kossebau, #frameworks

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 134 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/134/
 Project:
Frameworks kio kf5-qt5 XenialQt5.7
 Date of build:
Wed, 08 Nov 2017 17:19:44 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: TestSuite.kiofilewidgets-kdiroperatortestFailed: TestSuite.kiowidgets-accessmanagertestFailed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(22/22)80%
(278/346)80%
(278/346)57%
(29964/52384)42%
(16547/39374)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(67/67)100%
(67/67)96%
(8078/8399)51%
(4510/8824)autotests.http100%
(9/9)100%
(9/9)100%
(543/544)60%
(200/336)autotests.kcookiejar100%
(1/1)100%
(1/1)90%
(179/198)67%
(60/90)src.core85%
(99/117)85%
(99/117)57%
(8160/14200)49%
(4567/9281)src.core.kssl100%
(1/1)100%
(1/1)38%
(35/93)50%
(3/6)src.filewidgets73%
(27/37)73%
(27/37)45%
(3513/7729)29%
(1282/4476)src.gui100%
(2/2)100%
(2/2)95%
(104/110)75%
(54/72)src.ioslaves.file100%
(2/2)100%
(2/2)52%
(441/849)43%
(322/749)src.ioslaves.http100%
(8/8)100%
(8/8)47%
(1770/3782)38%
(1326/3462)src.ioslaves.http.kcookiejar100%
(2/2)100%
(2/2)80%
(622/782)72%
(608/839)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(70/258)8%
(16/200)src.ioslaves.trash80%
(8/10)80%
(8/10)60%
(704/1173)47%
(404/851)src.ioslaves.trash.tests100%
(2/2)100%
(2/2)90%
(707/785)48%
(461/970)src.kioslave100%
(1/1)100%
(1/1)52%
(14/27)50%
(5/10)src.kntlm100%
(2/2)100%
(2/2)97%
(373/385)80%
(111/138)src.kpasswdserver100%
(2/2)100%
(2/2)63%
(377/594)48%
(280/580)src.kpasswdserver.autotests100%
(1/1)100%
(1/1)99%

D8536: Add more hashing algorithms to KPropertiesDialog

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  As I mentioned, using //only// a combobox doesn't work, because the main 
functionality (= check integrity of downloaded files) is now harder to use.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8536

To: petermajchrak, elvisangelaccio
Cc: bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 135 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/135/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
 Date of build:
Wed, 08 Nov 2017 17:19:44 +
 Build duration:
6 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)

D8696: Don't autoremove empty temp file

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:a2f1e9fa43d2: Dont autoremove empty temp file 
(authored by elvisangelaccio).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8696?vs=22034=22093

REVISION DETAIL
  https://phabricator.kde.org/D8696

AFFECTED FILES
  src/core/connectionbackend.cpp

To: elvisangelaccio, dfaure
Cc: #frameworks

D8451: JavaScript: include standard mime types

[Nikita Skovoroda]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:1d55f0448725: JavaScript: include standard mime types 
(authored by ChALkeR).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8451?vs=21248=22085#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8451?vs=21248=22085

REVISION DETAIL
  https://phabricator.kde.org/D8451

AFFECTED FILES
  data/syntax/javascript.xml

To: ChALkeR, #framework_syntax_highlighting, vkrause
Cc: vkrause, #frameworks

D8330: Open files in TagLib extractor readonly

[Nathaniel Graham]

ngraham added a comment.


  @davidk, I think you have commit rights; do you want to do the honors?

REPOSITORY
  R286 KFileMetaData

BRANCH
  readOnly

REVISION DETAIL
  https://phabricator.kde.org/D8330

To: davidk, #frameworks, vhanda, cgiboudeaux, dfaure, mgallien
Cc: mgallien, ngraham, #frameworks

D8330: Open files in TagLib extractor readonly

[Matthieu Gallien]

mgallien added a comment.


  Yes exactly.

REPOSITORY
  R286 KFileMetaData

BRANCH
  readOnly

REVISION DETAIL
  https://phabricator.kde.org/D8330

To: davidk, #frameworks, vhanda, cgiboudeaux, dfaure, mgallien
Cc: mgallien, ngraham, #frameworks

D8705: Remove Qt5::Widgets as a dependency

[Martin Flöser]

graesslin added subscribers: dfaure, graesslin.
graesslin added a comment.


  From my side a -1. This is not source compatible. Thus I think we need to 
wait for Frameworks 6 for it.
  
  I want @dfaure to ack/nack this change.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D8705

To: apol, #frameworks
Cc: graesslin, dfaure, anthonyfieroni

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 134 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/134/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
 Date of build:
Wed, 08 Nov 2017 13:56:03 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D8330: Open files in TagLib extractor readonly

[Nathaniel Graham]

ngraham added a comment.


  Do you want to land this?

REPOSITORY
  R286 KFileMetaData

BRANCH
  readOnly

REVISION DETAIL
  https://phabricator.kde.org/D8330

To: davidk, #frameworks, vhanda, cgiboudeaux, dfaure, mgallien
Cc: mgallien, ngraham, #frameworks

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 133 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/133/
 Project:
Frameworks kio kf5-qt5 XenialQt5.7
 Date of build:
Wed, 08 Nov 2017 13:56:03 +
 Build duration:
6 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(22/22)80%
(278/346)80%
(278/346)57%
(30048/52383)42%
(16600/39374)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(67/67)100%
(67/67)96%
(8078/8399)51%
(4501/8824)autotests.http100%
(9/9)100%
(9/9)100%
(543/544)60%
(200/336)autotests.kcookiejar100%
(1/1)100%
(1/1)90%
(179/198)67%
(60/90)src.core85%
(99/117)85%
(99/117)57%
(8158/14199)49%
(4558/9281)src.core.kssl100%
(1/1)100%
(1/1)38%
(35/93)50%
(3/6)src.filewidgets73%
(27/37)73%
(27/37)46%
(3569/7729)30%
(1329/4476)src.gui100%
(2/2)100%
(2/2)95%
(104/110)75%
(54/72)src.ioslaves.file100%
(2/2)100%
(2/2)51%
(435/849)42%
(317/749)src.ioslaves.http100%
(8/8)100%
(8/8)47%
(1770/3782)38%
(1326/3462)src.ioslaves.http.kcookiejar100%
(2/2)100%
(2/2)80%
(622/782)72%
(608/839)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(70/258)8%
(16/200)src.ioslaves.trash80%
(8/10)80%
(8/10)60%
(704/1173)47%
(404/851)src.ioslaves.trash.tests100%
(2/2)100%
(2/2)90%
(707/785)48%
(461/970)src.kioslave100%
(1/1)100%
(1/1)52%
(14/27)50%
(5/10)src.kntlm100%
(2/2)100%
(2/2)97%
(373/385)80%
(111/138)src.kpasswdserver100%
(2/2)100%
(2/2)63%
(377/594)48%
(280/580)src.kpasswdserver.autotests100%
(1/1)100%
(1/1)99%
(283/286)57%

D8697: Don't check whether an empty filename exists

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In https://phabricator.kde.org/D8697#165670, @apol wrote:
  
  > Here's an alternative: https://codereview.qt-project.org/210716
  
  
  That would be much cleaner indeed, I'll hold this patch for now.

REPOSITORY
  R241 KIO

BRANCH
  fix-empty-exists

REVISION DETAIL
  https://phabricator.kde.org/D8697

To: elvisangelaccio, dfaure
Cc: apol, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> simgunz wrote in kopenwithdialog.cpp:463
> Segmentation fault happens if I use the member var. Accessing the member var 
> is the cause of the fault, because even `qDebug() << d->m_proxyModel` 
> generates the same error. It is not clear to me why.

Please try moving that code inside `if (d->appModel) { ... }`.

> simgunz wrote in kopenwithdialog.cpp:1108
> Yes, the cascade of return false doesn't make sense. You mean calling 
> eventFilter of QDialog instead of returning false at the end? eventFilter of 
> QDialog is virtual.

Yes.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8697: Don't check whether an empty filename exists

[Aleix Pol Gonzalez]

apol added a comment.


  Here's an alternative: https://codereview.qt-project.org/210716

REPOSITORY
  R241 KIO

BRANCH
  fix-empty-exists

REVISION DETAIL
  https://phabricator.kde.org/D8697

To: elvisangelaccio, dfaure
Cc: apol, #frameworks

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 132 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/132/
 Project:
Frameworks kio kf5-qt5 XenialQt5.7
 Date of build:
Wed, 08 Nov 2017 10:44:37 +
 Build duration:
8 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: TestSuite.kiowidgets-accessmanagertestFailed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(22/22)80%
(278/346)80%
(278/346)57%
(30062/52384)42%
(16627/39374)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(67/67)100%
(67/67)96%
(8078/8399)51%
(4508/8824)autotests.http100%
(9/9)100%
(9/9)100%
(543/544)60%
(200/336)autotests.kcookiejar100%
(1/1)100%
(1/1)90%
(179/198)67%
(60/90)src.core85%
(99/117)85%
(99/117)58%
(8166/14199)49%
(4573/9281)src.core.kssl100%
(1/1)100%
(1/1)38%
(35/93)50%
(3/6)src.filewidgets73%
(27/37)73%
(27/37)46%
(3569/7729)30%
(1329/4476)src.gui100%
(2/2)100%
(2/2)95%
(104/110)75%
(54/72)src.ioslaves.file100%
(2/2)100%
(2/2)52%
(441/849)43%
(322/749)src.ioslaves.http100%
(8/8)100%
(8/8)47%
(1770/3783)38%
(1326/3462)src.ioslaves.http.kcookiejar100%
(2/2)100%
(2/2)80%
(622/782)72%
(608/839)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(70/258)8%
(16/200)src.ioslaves.trash80%
(8/10)80%
(8/10)60%
(704/1173)47%
(404/851)src.ioslaves.trash.tests100%
(2/2)100%
(2/2)90%
(707/785)48%
(461/970)src.kioslave100%
(1/1)100%
(1/1)52%
(14/27)50%
(5/10)src.kntlm100%
(2/2)100%
(2/2)97%
(373/385)80%
(111/138)src.kpasswdserver100%
(2/2)100%
(2/2)63%
(377/594)48%
(280/580)src.kpasswdserver.autotests100%
(1/1)100%
(1/1)99%
(283/286)57%
   

D8683: Only prevent the name to update if it's empty

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:1a7d545c4040: Only prevent the name to update if 
its empty (authored by apol).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8683?vs=21981=22067

REVISION DETAIL
  https://phabricator.kde.org/D8683

AFFECTED FILES
  src/core/kfileitem.cpp

To: apol, #frameworks, dfaure

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

simgunz added inline comments.

INLINE COMMENTS

> dfaure wrote in kopenwithdialog.cpp:463
> Use the member var instead of casting.

Segmentation fault happens if I use the member var. Accessing the member var is 
the cause of the fault, because even `qDebug() << d->m_proxyModel` generates 
the same error. It is not clear to me why.

> dfaure wrote in kopenwithdialog.cpp:830
> Could the view have a method that returns the proxymodel (possibly as a 
> QSortFilterProxyModel* if we don't actually need a subclass-typed pointer), 
> to avoid this cast?
> Such casts make refactoring more difficult, moving problems from compile-time 
> to runtime.

Ok I'll add a method.

> dfaure wrote in kopenwithdialog.cpp:1108
> All this "return false" cascade isn't really needed, a single return false at 
> the end would do the job, or even better, calling the eventFilter method of 
> the base class, just in case that's implemented for other reasons.

Yes, the cascade of return false doesn't make sense. You mean calling 
eventFilter of QDialog instead of returning false at the end? eventFilter of 
QDialog is virtual.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks