D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent added a comment. You still missing all patch... Please use arc diff so we are sure that all patch is updated. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
KDE CI: Frameworks kcrash kf5-qt5 WindowsMSVCQt5.9 - Build # 20 - Still unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20WindowsMSVCQt5.9/20/ Project: Frameworks kcrash kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 22 Dec 2017 04:56:30 + Build duration: 12 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.kcrashtest
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 46 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/46/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Fri, 22 Dec 2017 04:08:12 + Build duration: 23 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.testtrash
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/45/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 22 Dec 2017 04:08:12 + Build duration: 13 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.testtrash
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 25 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/25/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 22 Dec 2017 04:08:12 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiowidgets-kdirmodeltest
KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 10 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/10/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 21 Dec 2017 23:17:51 + Build duration: 16 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kstandarddirstest
D9211: Iterate over initializer_lists to avoid mem allocs
mwolff added a comment.
much better, but can be somewhat better still.
if people don't know the STL, they should learn it.
INLINE COMMENTS
> katedocument.cpp:109
> +auto it = std::find(list.begin(), list.end(), entry);
> +return it == list.end() ? -1 : std::distance(it, list.end());
> +}
you want to return `std::distance(list.begin(), it)` here
> katedocument.cpp:4526
> +static const auto vvl = {
>QStringLiteral("dynamic-word-wrap")
> , QStringLiteral("dynamic-word-wrap-indicators")
here and below, these could now contain QLatin1String, reducing the size of the
binary a bit
> katedocument.cpp:4561
> if (onlyViewAndRenderer) {
> -if (vvl.contains(var)) { // FIXME define above
> +if (indexOf(var, vvl) >= 0) { // FIXME define above
> setViewVariable(var, val);
add a contains that does this check, also use it below
> katedocument.cpp:4655
> // VIEW SETTINGS
> -else if (vvl.contains(var)) {
> +else if (indexOf(var, vvl) >= 0) {
> setViewVariable(var, val);
contains
> katedocument.cpp:4740
> val = val.trimmed().toLower();
> -static const QStringList trueValues{ QStringLiteral("1"),
> QStringLiteral("on"), QStringLiteral("true") };
> -if (trueValues.contains(val)) {
> +static const auto trueValues{ QStringLiteral("1"), QStringLiteral("on"),
> QStringLiteral("true") };
> +if (indexOf(val, trueValues) >= 0) {
QLatin1String
> katedocument.cpp:4741
> +static const auto trueValues{ QStringLiteral("1"), QStringLiteral("on"),
> QStringLiteral("true") };
> +if (indexOf(val, trueValues) >= 0) {
> *result = true;
contains
> katedocument.cpp:4746
>
> -static const QStringList falseValues{ QStringLiteral("0"),
> QStringLiteral("off"), QStringLiteral("false") };
> -if (falseValues.contains(val)) {
> +static const auto falseValues{ QStringLiteral("0"),
> QStringLiteral("off"), QStringLiteral("false") };
> +if (indexOf(val, falseValues) >= 0) {
QLatin1String
> katedocument.cpp:4747
> +static const auto falseValues{ QStringLiteral("0"),
> QStringLiteral("off"), QStringLiteral("false") };
> +if (indexOf(val, falseValues) >= 0) {
> *result = false;
contains
REPOSITORY
R39 KTextEditor
BRANCH
AvoidAllocs (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9211
To: dhaumann, mwolff, apol
Cc: ngraham, #frameworks, kevinapavew, demsking, cullmann, sars, dhaumann
KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 15 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/15/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Dec 2017 23:17:51 + Build duration: 5 min 10 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kmimetypetest
KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 16 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/16/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Thu, 21 Dec 2017 23:17:51 + Build duration: 4 min 56 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kmimetypetest
D6992: Fix build on Linux without X11
This revision was automatically updated to reflect the committed changes. Closed by commit R285:02d555f9db3e: Fix build on Linux without X11 (authored by vkrause). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6992?vs=24251&id=24270 REVISION DETAIL https://phabricator.kde.org/D6992 AFFECTED FILES src/kcrash.cpp To: vkrause, #frameworks, bshah, graesslin, dfaure Cc: dfaure, graesslin, bshah
D6992: Fix build on Linux without X11
dfaure accepted this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D6992 To: vkrause, #frameworks, bshah, graesslin, dfaure Cc: dfaure, graesslin, bshah
D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'
dfaure added a comment. Makes sense, I guess. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9423 To: habacker, dfaure, bcooksley, kfunk Cc: apol, kfunk, broulik, #frameworks
D9394: Show "Search wrapped" message in center of view for better visibility
dhaumann added a comment. @neundorf Did you try the patch? Or anyone else? I would like to get this right instead of having yet another solution that is not good enough. REPOSITORY R39 KTextEditor BRANCH SearchMessages (branched from master) REVISION DETAIL https://phabricator.kde.org/D9394 To: dhaumann, neundorf, cullmann, kfunk, mwolff Cc: ngraham, broulik, #frameworks, kevinapavew, demsking, cullmann, sars, dhaumann
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 45 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/45/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 21 Dec 2017 18:38:11 + Build duration: 26 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.testtrash
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 24 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/24/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 21 Dec 2017 18:38:11 + Build duration: 18 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiocore-threadtestFailed: TestSuite.testtrash
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/44/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Dec 2017 18:38:11 + Build duration: 13 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.testtrash
D9318: [knewstuff] Limit request cache size
This revision was automatically updated to reflect the committed changes. Closed by commit R304:6de0754aa925: Limit request cache size (authored by anthonyfieroni). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9318?vs=24144&id=24267 REVISION DETAIL https://phabricator.kde.org/D9318 AFFECTED FILES src/core/cache.cpp To: anthonyfieroni, leinir, #frameworks, dfaure Cc: dfaure, broulik
D9442: [kcoredirlister] FIx sub path creation
This revision was automatically updated to reflect the committed changes. Closed by commit R241:1b90a8c10547: [kcoredirlister] Fix sub path creation (authored by anthonyfieroni). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9442?vs=24183&id=24266 REVISION DETAIL https://phabricator.kde.org/D9442 AFFECTED FILES src/core/kcoredirlister.cpp To: anthonyfieroni, dfaure Cc: #frameworks
D9468: Refactor Solid::NetworkingPrivate to have a shared and platform specific implementation
habacker created this revision. habacker added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Access to the internal global static is provided by the already available method Solid::Networking::notifier(). FIXED-IN:5.43.0 TEST PLAN - unix: compiled and verified with networkingservice/networkingclient test apps - Window: compiled, but not tested because the kded5 module registered by networkingservice is not visible in org.kde.kded5 REPOSITORY R239 KDELibs4Support BRANCH master REVISION DETAIL https://phabricator.kde.org/D9468 AFFECTED FILES src/CMakeLists.txt src/solid/networking.cpp src/solid/networking_unix.cpp src/solid/networking_win.cpp To: habacker, dfaure Cc: #frameworks
D6992: Fix build on Linux without X11
vkrause updated this revision to Diff 24251. vkrause added a comment. follow kinit changes REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6992?vs=24227&id=24251 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6992 AFFECTED FILES src/kcrash.cpp To: vkrause, #frameworks, bshah, graesslin, dfaure Cc: dfaure, graesslin, bshah
D9454: Remove impossible to reach code
This revision was automatically updated to reflect the committed changes. Closed by commit R303:f68d54697318: Remove impossible to reach code (authored by vkrause). REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9454?vs=24249&id=24250 REVISION DETAIL https://phabricator.kde.org/D9454 AFFECTED FILES src/kdeinit/kinit.cpp src/wrapper.cpp To: vkrause, dfaure Cc: #frameworks
D9454: Remove impossible to reach code
dfaure accepted this revision. REPOSITORY R303 KInit BRANCH master REVISION DETAIL https://phabricator.kde.org/D9454 To: vkrause, dfaure Cc: #frameworks
D8536: Add more hashing algorithms to KPropertiesDialog
petermajchrak added a comment. Ou, ok. Sorry, I didn't know that. Perfect, so combobox it is then. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio, #vdg, colomar Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks
D8536: Add more hashing algorithms to KPropertiesDialog
colomar added a comment. In https://phabricator.kde.org/D8536#181775, @petermajchrak wrote: > I can revert it back to the combobox based layout. Don't we have some UX people that could take a look at this? Yes, me :) Which is what I did, and commented with my recommendation. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio, #vdg, colomar Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks
D9454: Remove impossible to reach code
vkrause updated this revision to Diff 24249. vkrause added a comment. address review comment REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9454?vs=24226&id=24249 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9454 AFFECTED FILES src/kdeinit/kinit.cpp src/wrapper.cpp To: vkrause, dfaure Cc: #frameworks
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 44 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/44/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 21 Dec 2017 14:59:00 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed: 4 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.testtrash
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
velurimithun updated this revision to Diff 24238. velurimithun marked 2 inline comments as done. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9420?vs=24199&id=24238 REVISION DETAIL https://phabricator.kde.org/D9420 AFFECTED FILES autotests/kaboutdatatest.cpp autotests/kpluginloadertest.cpp autotests/kprocesstest.cpp autotests/ktexttohtmltest.cpp autotests/multiplugin.cpp To: velurimithun, mlaurent Cc: #frameworks
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 23 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/23/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 21 Dec 2017 14:59:00 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiocore-ktcpsockettestFailed: TestSuite.kiowidgets-kdirmodeltest
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 43 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/43/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Dec 2017 14:59:00 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed: 4 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.testtrash
D9456: Remove blip.tv web shortcuts
This revision was automatically updated to reflect the committed changes. Closed by commit R241:0e26720cdb76: Remove blip.tv web shortcuts (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9456?vs=24230&id=24236 REVISION DETAIL https://phabricator.kde.org/D9456 AFFECTED FILES src/urifilters/ikws/searchproviders/blip.desktop To: broulik, #frameworks, apol Cc: ltoscano
D9456: Remove blip.tv web shortcuts
ltoscano added a comment. In https://phabricator.kde.org/D9456#182021, @broulik wrote: > One could potentially write an autotest that fires a search to every site and checks for whether it responds and doesn't throw a 404. However, I fear that test would be quite flaky. And not automatically run; iirc the build environments of the distributions may be isolated (for good reasons). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9456 To: broulik, #frameworks, apol Cc: ltoscano
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 43 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/43/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 21 Dec 2017 14:23:10 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed: 4 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.testtrash
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 42 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/42/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Dec 2017 14:23:10 + Build duration: 13 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.testtrash
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 22 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/22/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 21 Dec 2017 14:23:10 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiocore-ktcpsockettestFailed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.testtrash
KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 14 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/14/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Dec 2017 14:16:00 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kmimetypetestFailed: TestSuite.kurltest
D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'
habacker added a comment. In https://phabricator.kde.org/D9423#181793, @dfaure wrote: > A single .in file sounds good indeed. Sorry for approving the first one too fast. That means the solution needs to be applied to more then one git repo - kio - kwallet - just recgonized that kded is also affected (https://cgit.kde.org/kded.git/tree/src/org.kde.kded5.service.in) Would it then not be better to create and use an ecm function for that ? e.g something like function(ECM_GENERATE_DBUS_SERVICE_FILE target) 1. detect platform 2. if windows 3. set empty path 4. else 5. get target install location 6. endif 7. generate dbus service file from template contained in ecm packages or using raw write 8. install dbus service file endfunction() where 'target' - is the cmake target name e.g. ecm_generate_dbus_service_file(kded) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9423 To: habacker, dfaure, bcooksley, kfunk Cc: apol, kfunk, broulik, #frameworks
D9456: Remove blip.tv web shortcuts
broulik added a comment. One could potentially write an autotest that fires a search to every site and checks for whether it responds and doesn't throw a 404. However, I fear that test would be quite flaky. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9456 To: broulik, #frameworks, apol
D9456: Remove blip.tv web shortcuts
apol added a comment. Would it be possible to add some kind of test maybe? to make sure that they do something at least. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9456 To: broulik, #frameworks, apol
D9456: Remove blip.tv web shortcuts
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9456 To: broulik, #frameworks, apol
KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 15 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/15/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Thu, 21 Dec 2017 14:16:00 + Build duration: 7 min 31 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kmimetypetest
D9455: Fix Qt documentation web shortcut
This revision was automatically updated to reflect the committed changes. Closed by commit R241:5e984824d4c3: Fix Qt documentation web shortcut (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9455?vs=24228&id=24231 REVISION DETAIL https://phabricator.kde.org/D9455 AFFECTED FILES src/urifilters/ikws/searchproviders/qt.desktop src/urifilters/ikws/searchproviders/qt4.desktop To: broulik, #frameworks, vkrause
KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 9 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/9/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 21 Dec 2017 14:16:00 + Build duration: 6 min 33 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kstandarddirstest
D9454: Remove impossible to reach code
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> wrapper.cpp:49
> {
> // Can't use QGuiApplication::platformName() here, there is no app
> instance.
> return "DISPLAY";
Move this comment above the #if (of line 46), since that's what it's commenting
about.
REPOSITORY
R303 KInit
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9454
To: vkrause, dfaure
Cc: #frameworks
D9456: Remove blip.tv web shortcuts
broulik created this revision. broulik added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY The website was shut down in August 2015 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9456 AFFECTED FILES src/urifilters/ikws/searchproviders/blip.desktop To: broulik, #frameworks
D9453: Inform the user if the module can not be registered with org.kde.kded5 and exit with error
This revision was automatically updated to reflect the committed changes. Closed by commit R239:829c992b9997: Inform the user if the module can not be registered with org.kde.kded5 and exit… (authored by habacker). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9453?vs=24224&id=24229 REVISION DETAIL https://phabricator.kde.org/D9453 AFFECTED FILES tests/networkingservice.cpp tests/networkingservice.h To: habacker, dfaure Cc: #frameworks
D9455: Fix Qt documentation web shortcut
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9455 To: broulik, #frameworks, vkrause
D9455: Fix Qt documentation web shortcut
broulik created this revision. broulik added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY The URL changed after their website relaunch TEST PLAN Typed `qt test` into KRunner, got Qt 5 doc search for "test" Typed `qt4 test` into KRunner, got Qt 4.8 doc search for "test" REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9455 AFFECTED FILES src/urifilters/ikws/searchproviders/qt.desktop src/urifilters/ikws/searchproviders/qt4.desktop To: broulik, #frameworks
D6992: Fix build on Linux without X11
vkrause updated this revision to Diff 24227. vkrause added a comment. Remove dead code. REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6992?vs=24225&id=24227 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6992 AFFECTED FILES src/kcrash.cpp To: vkrause, #frameworks, bshah, graesslin, dfaure Cc: dfaure, graesslin, bshah
D9454: Remove impossible to reach code
vkrause created this revision. vkrause added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This also brings this back in sync with src/kdeinit/kinit.cpp. REPOSITORY R303 KInit BRANCH master REVISION DETAIL https://phabricator.kde.org/D9454 AFFECTED FILES src/wrapper.cpp To: vkrause, dfaure Cc: #frameworks
D9453: Inform the user if the module can not be registered with org.kde.kded5 and exit with error
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R239 KDELibs4Support BRANCH master REVISION DETAIL https://phabricator.kde.org/D9453 To: habacker, dfaure Cc: #frameworks
D6992: Fix build on Linux without X11
vkrause added inline comments. INLINE COMMENTS > dfaure wrote in kcrash.cpp:271 > I wonder why this isn't removed then, it can't happen ;-) Indeed, I'll clean it up here and in kinit. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D6992 To: vkrause, #frameworks, bshah, graesslin, dfaure Cc: dfaure, graesslin, bshah
D6992: Fix build on Linux without X11
dfaure accepted this revision. dfaure added a comment. Looks much better indeed, thanks. INLINE COMMENTS > kcrash.cpp:271 > return "MAC_DISPLAY"; > #elif defined(Q_OS_WIN) > return "WIN_DISPLAY"; I wonder why this isn't removed then, it can't happen ;-) REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D6992 To: vkrause, #frameworks, bshah, graesslin, dfaure Cc: dfaure, graesslin, bshah
D6992: Fix build on Linux without X11
vkrause updated this revision to Diff 24225. vkrause added a comment. Re-sync with KInit, and thus solve the non-X11 compile issue in the same way as it's handled there already. REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6992?vs=24216&id=24225 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6992 AFFECTED FILES src/kcrash.cpp To: vkrause, #frameworks, bshah, graesslin Cc: dfaure, graesslin, bshah
D9453: Inform the user if the module can not be registered with org.kde.kded5 and exit with error
habacker updated this revision to Diff 24224. habacker added a comment. - follow code style - do not call quit() REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9453?vs=24223&id=24224 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9453 AFFECTED FILES tests/networkingservice.cpp tests/networkingservice.h To: habacker, dfaure Cc: #frameworks
D6992: Fix build on Linux without X11
dfaure added a comment. Hmm, OK. Sounds like the whole thing could easily be refactored to not call qgetenv at all on non-X11... (i.e. including on OSX/Windows). That would be much less confusing. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D6992 To: vkrause, #frameworks, bshah, graesslin Cc: dfaure, graesslin, bshah
D9453: Inform the user if the module can not be registered with org.kde.kded5 and exit with error
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
kded5 is supposed to be autostarted on demand by the DBus activation
mechanism, but OK, if the setup is broken, I guess that might fail.
INLINE COMMENTS
> networkingservice.cpp:68
> QDBusConnection::sessionBus().registerService(
> "org.kde.Solid.Networking.TestService" );
> +if (!m_service->isValid())
> +kError() << "could not register module" << m_service->path() << "at"
> << m_service->service();
KF5 coding style: { ... } even around 1-line bodies.
> networkingservice.cpp:69
> +if (!m_service->isValid())
> +kError() << "could not register module" << m_service->path() << "at"
> << m_service->service();
>
kError() is deprecated, use qCritical()
> networkingservice.cpp:233
> +{
> +app.quit();
> +return 1;
this line serves no purpose, since exec() wasn't even called.
REPOSITORY
R239 KDELibs4Support
REVISION DETAIL
https://phabricator.kde.org/D9453
To: habacker, dfaure
Cc: #frameworks
D6992: Fix build on Linux without X11
vkrause added a comment.
It's going to call getenv("") and then continue with the empty display
variable case for non-X11 below. At least that's the assumption, an entirely
X11-free setup is still somewhat theoretical at this point :)
My goal for now is to make the KF5 Yocto recipes useful in a non-X11/pure
Wayland setup, kcrash matters there due to being a wide-spread (indirect)
dependency.
REPOSITORY
R285 KCrash
REVISION DETAIL
https://phabricator.kde.org/D6992
To: vkrause, #frameworks, bshah, graesslin
Cc: dfaure, graesslin, bshah
D9453: Inform the user if the module can not be registered with org.kde.kded5 and exit with error
habacker updated this revision to Diff 24223. habacker added a comment. - really shut down app in case of errors REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9453?vs=24220&id=24223 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9453 AFFECTED FILES tests/networkingservice.cpp tests/networkingservice.h To: habacker, dfaure Cc: #frameworks
D9453: Inform the user if the module can not be registered with org.kde.kded5 and exit with error
habacker created this revision. habacker added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY It makes no sense to run this test app without registering with kded5 as this is a required requirement. TEST PLAN compiled and tested without running kded5 REPOSITORY R239 KDELibs4Support BRANCH master REVISION DETAIL https://phabricator.kde.org/D9453 AFFECTED FILES tests/networkingservice.cpp tests/networkingservice.h To: habacker, dfaure Cc: #frameworks
D6992: Fix build on Linux without X11
dfaure added a comment.
so this is going to call getenv("") ? Or is this code path never called?
REPOSITORY
R285 KCrash
REVISION DETAIL
https://phabricator.kde.org/D6992
To: vkrause, #frameworks, bshah, graesslin
Cc: dfaure, graesslin, bshah
D6992: Fix build on Linux without X11
vkrause updated this revision to Diff 24216. vkrause added a comment. Reduced to a minimal compile fix for now. REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6992?vs=17388&id=24216 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6992 AFFECTED FILES src/kcrash.cpp To: vkrause, #frameworks, bshah, graesslin Cc: dfaure, graesslin, bshah
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 42 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/42/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 21 Dec 2017 11:45:59 + Build duration: 40 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.testtrash
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 41 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/41/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Dec 2017 11:45:59 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.testtrash
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 21 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/21/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 21 Dec 2017 11:45:59 + Build duration: 7 min 38 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiowidgets-kdirmodeltest
D5199: Reflect trash state in iconNameForUrl
This revision was automatically updated to reflect the committed changes. Closed by commit R241:ca6e6c0469a5: Reflect trash state in iconNameForUrl (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5199?vs=12872&id=24212 REVISION DETAIL https://phabricator.kde.org/D5199 AFFECTED FILES src/core/global.cpp To: broulik, hein, dfaure Cc: markg, #frameworks
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 40 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/40/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Dec 2017 10:24:19 + Build duration: 15 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiowidgets-kdirmodeltest
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 41 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/41/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 21 Dec 2017 10:24:19 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiowidgets-kdirmodeltest
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 20 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/20/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 21 Dec 2017 10:24:19 + Build duration: 8 min 54 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiowidgets-kdirmodeltest
D7968: Forward QComboBox signals instead of QComboBox lineedit signals
This revision was automatically updated to reflect the committed changes. Closed by commit R241:a43aea3e: Forward QComboBox signals instead of QComboBox lineedit signals (authored by mwolff). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7968?vs=24188&id=24203#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7968?vs=24188&id=24203 REVISION DETAIL https://phabricator.kde.org/D7968 AFFECTED FILES autotests/kurlrequestertest.cpp src/widgets/kurlrequester.cpp To: mwolff, apol, dfaure Cc: #frameworks
D9446: WIP: Allow to autogenerate and install categories file
fvogt added a comment.
`${KDE_INSTALL_CONFDIR}` should be changed to somewhere else (but maybe in a
different patch)
IMO `file(APPEND ...)` is the wrong approach, it should collect all
categories in a variable and only write it out once at the end (with
configure_file). I'm not fluent in CMake, I'm not sure whether that's actually
possible that way.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D9446
To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure, fvogt
Cc: #frameworks, #build_system
KDE CI: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.9 - Build # 25 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20WindowsMSVCQt5.9/25/ Project: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.9 Date of build: Thu, 21 Dec 2017 09:09:30 + Build duration: 3 min 17 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
D9318: [knewstuff] Limit request cache size
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D9318 To: anthonyfieroni, leinir, #frameworks, dfaure Cc: dfaure, broulik
D9386: Mingw32 compile fix
dfaure added a comment. Put it in the common file, and add an accessor for the other files, for instance a static method in Solid::NetworkingPrivate. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D9386 To: habacker, dfaure, ltoscano, bcooksley Cc: #frameworks
D7968: Forward QComboBox signals instead of QComboBox lineedit signals
dfaure added inline comments. INLINE COMMENTS > kurlrequestertest.cpp:186 > +QTest::keyEvent(QTest::Click, req.comboBox(), Qt::Key_Down); > +qDebug() << textSpy << editSpy << returnSpy << returnWithTextSpy; > +QCOMPARE(textSpy.size(), 2); Please remove this line though. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7968 To: mwolff, apol, dfaure Cc: #frameworks
D7968: Forward QComboBox signals instead of QComboBox lineedit signals
dfaure accepted this revision. dfaure added a comment. Thanks! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7968 To: mwolff, apol, dfaure Cc: #frameworks
D9442: [kcoredirlister] FIx sub path creation
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9442 To: anthonyfieroni, dfaure Cc: #frameworks
D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'
dfaure added a comment. A single .in file sounds good indeed. Sorry for approving the first one too fast. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9423 To: habacker, dfaure, bcooksley, kfunk Cc: apol, kfunk, broulik, #frameworks
D5175: Fix 'Installed name of kio_http_cache_cleaner conflicts with related KDE4 installation'.
bcooksley added a comment. In regards to needing to inspect the build directory (which is something we rarely get asked for) the system automatically tarballs a copy of the entire workspace (which includes the source code and build directory) whenever a build fails or has failing tests. These tarballs can be found at https://build-artifacts.kde.org/production/Workspaces/ (filenames match the job name on Jenkins itself). "Hidden build issues" aren't something we've really come across when standing up the native Windows CI system. Most dependencies are provided by Craft (with Git and Python being the notable exceptions there). The "list file" which controls what Craft packages we install can be found at https://cgit.kde.org/sysadmin/ci-tooling.git/tree/craftmaster/packages.list. We rely on the publicly accessible Craft cache packages, so anyone can replicate the CI setup on their system relatively easily. The Binary Factory also uses the same Craft Cache for it's binaries (and the Binary Factory generates usable binaries for many KDE applications already) and the Binary Factory is also responsible for populating that Craft Cache. For various reasons it's totally inpractical for us to provide remote shell access to the CI infrastructure. In the case of Linux builds you can download the Docker images and run them locally. For FreeBSD and Windows you'll have to rely on the tarballs. Also note that we won't be signing any binaries which are not generated by the Binary Factory. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5175 To: habacker, dfaure, ltoscano, bcooksley Cc: cgiboudeaux, #frameworks
D9446: WIP: Allow to autogenerate and install categories file
lbeltrame added a comment. For those who wonder why this would be necessary, see https://mail.kde.org/pipermail/kde-frameworks-devel/2017-December/054139.html. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9446 To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure, fvogt Cc: #frameworks, #build_system
D9446: WIP: Allow to autogenerate and install categories file
lbeltrame added a reviewer: fvogt. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9446 To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure, fvogt Cc: #frameworks, #build_system
D9446: WIP: Allow to autogenerate and install categories file
mlaurent added reviewers: kfunk, lbeltrame, cgiboudeaux, dfaure. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9446 To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure Cc: #frameworks, #build_system
