D9770: Optimization of byteSize(double size)

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  Imo this should be using `KFormat::formatByteSize`. 
https://api.kde.org/frameworks/kcoreaddons/html/classKFormat.html#ae7412420b70e2ca935d0ebed6770e313
  
  And if that function is slow, add a benchmark and optimize it there so that 
everyone profits and not only the job tracker.
  
  Furthermore: can you show me the callgrind file? I suspect the real issue is 
that `::byteSize` is called too often here. This is for a progress bar I 
suspect, right? That should only update itself every X ms at the most, instead 
of doing it millions of times which I suspect is the case here?

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D9770

To: jtamate, #frameworks, mwolff
Cc: mwolff, broulik

D9734: [KFileItemActions] Allow specifying the number of selected files required for an action

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9734

To: broulik, #frameworks, dfaure, michaelh, mlaurent

Re: duplicate icon in breeze-icons

[Harald Sitter]

Whatever's going on with that output Oo

On Fri, Jan 5, 2018 at 10:13 AM, David Faure  wrote:
> Hello Andreas,
>
> I'm emailing you since you committed some gnumeric icons to breeze-icons.
>
> CI fails because it says that
> /icons/actions/24/gnumeric-formulaguru.svg
> and
> /icons/actions/24/gnumeric-pagesetup-hf-cell.svg
> are the same (but aren't using a symlink).
>
> Can you take a look at the best fix for this?
>
> https://build.kde.org/view/Frameworks/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/11/testReport/(root)/TestSuite/dupe/
>
> Thanks!
>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>

D9734: [KFileItemActions] Allow specifying the number of selected files required for an action

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:4717e0e47316: [KFileItemActions] Allow specifying the 
number of selected files required for… (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9734?vs=24945&id=25058

REVISION DETAIL
  https://phabricator.kde.org/D9734

AFFECTED FILES
  src/widgets/kfileitemactions.cpp

To: broulik, #frameworks, dfaure, michaelh, mlaurent

D9729: [KPropertiesDialog] Enable word wrap for checksum description

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8ab0c0dbead7: [KPropertiesDialog] Enable word wrap for 
checksum description (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9729?vs=24926&id=25057

REVISION DETAIL
  https://phabricator.kde.org/D9729

AFFECTED FILES
  src/widgets/checksumswidget.ui

To: broulik, #frameworks, elvisangelaccio

D9781: do not incorrectly split spaces in paths of duplicate results

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
sitter requested review of this revision.

REVISION SUMMARY
  use kcoreaddons to split fdupes output. fdupes outputs
  `/space\ inbetween/x.svg /space\ inbetween/y.svg`
  as dupe result, which, if we split blindly for space, we'll split into 4
  pieces instead of 2.
  splitting the argument string using escape rules via kshell gives us
  correct splitting by taking into account the escaped spaces.
  
  unfortunately qregex doesn't seem to support negative lookbehind
  expressions, or we could solve this with a `(?https://phabricator.kde.org/D9781

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/dupetest.cpp

To: sitter, dfaure
Cc: #frameworks

Re: duplicate icon in breeze-icons

[Harald Sitter]

https://phabricator.kde.org/D9781

On Wed, Jan 10, 2018 at 10:06 AM, Harald Sitter  wrote:
> Whatever's going on with that output Oo
>
> On Fri, Jan 5, 2018 at 10:13 AM, David Faure  wrote:
>> Hello Andreas,
>>
>> I'm emailing you since you committed some gnumeric icons to breeze-icons.
>>
>> CI fails because it says that
>> /icons/actions/24/gnumeric-formulaguru.svg
>> and
>> /icons/actions/24/gnumeric-pagesetup-hf-cell.svg
>> are the same (but aren't using a symlink).
>>
>> Can you take a look at the best fix for this?
>>
>> https://build.kde.org/view/Frameworks/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/11/testReport/(root)/TestSuite/dupe/
>>
>> Thanks!
>>
>> --
>> David Faure, fa...@kde.org, http://www.davidfaure.fr
>> Working on KDE Frameworks 5
>>
>>
>>

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 44 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/44/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 10 Jan 2018 09:11:05 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 122 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/122/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Wed, 10 Jan 2018 09:11:05 +
 Build duration:
33 min and counting
   CONSOLE OUTPUT
  [...truncated 77.35 KB...]VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.12.25827\'VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Redist\MSVC\14.12.25810\'VCTOOLSVERSION= '14.12.25827'VISUALSTUDIOVERSION   = '15.0'VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'VS150COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\Tools\'VSCMD_ARG_APP_PLAT= 'Desktop'VSCMD_ARG_HOST_ARCH   = 'x64'VSCMD_ARG_TGT_ARCH= 'x64'VSCMD_VER = '15.5.3'VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\'WINDIR= 'C:\WINDOWS'WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.16299.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.16299.0'WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'WINDOWSSDKLIBVERSION  = '10.0.16299.0\'WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.16299.0\'WINDOWSSDKVERSION = '10.0.16299.0\'WORKSPACE = 'C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9'__DOTNET_ADD_64BIT= '1'__DOTNET_PREFERRED_BITNESS = '64'__VSCMD_PREINIT_PATH  = 'C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files (x86)\Git\cmd;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'CMAKE_PREFIX_PATH = 'C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\install-prefix;C:\CM\msvc2017x64d;C:\CM\msvc2017x64d\dev-utils'QT_PLUGIN_PATH= 'C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\install-prefix\lib\plugins'QML2_IMPORT_PATH  = 'C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\install-prefix\lib\qml'XDG_DATA_DIRS = 'C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\install-prefix\share;C:\CM\msvc2017x64d\share;C:\CM\msvc2017x64d\dev-utils\share'XDG_CONFIG_DIRS   = 'C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\install-prefix\etc/xdg'PKG_CONFIG_PATH   = 'C:\CM\msvc2017x64d\lib\pkgconfig;C:\CM\msvc2017x64d\dev-utils\lib\pkgconfig'QMAKEFEATURES = 'C:\CM\msvc2017x64d\mkspecs/features'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9/install-prefix/" -G "NMake Makefiles JOM"  "C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9"-- The C compiler identification is MSVC 19.12.25834.0-- The CXX compiler identification is MSVC 19.12.25834.0-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe -- brokenCMake Error at C:/CM/msvc2017x64d/dev-utils/cmake/share/cmake-3.9/Modules/CMakeTestCCompiler.cmake:51 (message):  The C compiler "C:/Program Files (x86)/Microsoft Visual  Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe"  is not able to compile a simple test program.  It fails with the following output:   Change Dir: C:/CI/workspace/Frameworks kio kf5-qt5 WindowsMSVCQt5.9/build/CMakeFiles/CMakeTmpRun Build Command:"jom" "/NOLOGO" "cmTC_47345\fast"  	C:\CM\msvc2017x64d\dev-utils\bin\jom.exe -f  CMakeFiles\cmTC_47345.dir\build.make /nologo -L  CMakeFiles\cmTC_47345.dir\build  Building C object CMakeFiles/cmTC_47345.dir/testCCompiler.c.obj	C:\PROGRA~2\MICROS~1\2017\PROFES~1\VC\Tools\MSVC\1412~1.258\bin\Hostx64\x64\cl.exe  @C:\Users\Jenkins\AppData\Local\Temp\testCCompiler.c.obj.4584.0.jom  testCCompiler.c  C:\CI\workspace\Frameworks kio kf5-qt5  WindowsMSVCQt5.9\build\CMakeFiles\CMakeTmp\testCCompiler.c: fatal error  C1902: Program database manager mismatch; please check your installation  jom: C:\CI\workspace\Frameworks kio kf5-qt5  WindowsMSVCQt5.9\build\CMakeFiles\CMakeTmp\CMakeFiles\cmTC_47345.dir\build.make  [CMakeFiles\cmTC_47345.dir\testCCo

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 123 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/123/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Wed, 10 Jan 2018 09:44:43 +
 Build duration:
3 min 48 sec and counting
   CONSOLE OUTPUT
  [...truncated 77.12 KB...]VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.12.25827\'VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Redist\MSVC\14.12.25810\'VCTOOLSVERSION= '14.12.25827'VISUALSTUDIOVERSION   = '15.0'VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'VS150COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\Tools\'VSCMD_ARG_APP_PLAT= 'Desktop'VSCMD_ARG_HOST_ARCH   = 'x64'VSCMD_ARG_TGT_ARCH= 'x64'VSCMD_VER = '15.5.3'VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\'WINDIR= 'C:\WINDOWS'WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.16299.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.16299.0'WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'WINDOWSSDKLIBVERSION  = '10.0.16299.0\'WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.16299.0\'WINDOWSSDKVERSION = '10.0.16299.0\'WORKSPACE = 'C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9'__DOTNET_ADD_64BIT= '1'__DOTNET_PREFERRED_BITNESS = '64'__VSCMD_PREINIT_PATH  = 'C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files (x86)\Git\cmd;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'CMAKE_PREFIX_PATH = 'C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\install-prefix;C:\CM\msvc2017x64d;C:\CM\msvc2017x64d\dev-utils'QT_PLUGIN_PATH= 'C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\install-prefix\lib\plugins'QML2_IMPORT_PATH  = 'C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\install-prefix\lib\qml'XDG_DATA_DIRS = 'C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\install-prefix\share;C:\CM\msvc2017x64d\share;C:\CM\msvc2017x64d\dev-utils\share'XDG_CONFIG_DIRS   = 'C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\install-prefix\etc/xdg'PKG_CONFIG_PATH   = 'C:\CM\msvc2017x64d\lib\pkgconfig;C:\CM\msvc2017x64d\dev-utils\lib\pkgconfig'QMAKEFEATURES = 'C:\CM\msvc2017x64d\mkspecs/features'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9/install-prefix/" -G "NMake Makefiles JOM"  "C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9"-- The C compiler identification is MSVC 19.12.25834.0-- The CXX compiler identification is MSVC 19.12.25834.0-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe -- brokenCMake Error at C:/CM/msvc2017x64d/dev-utils/cmake/share/cmake-3.9/Modules/CMakeTestCCompiler.cmake:51 (message):  The C compiler "C:/Program Files (x86)/Microsoft Visual  Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe"  is not able to compile a simple test program.  It fails with the following output:   Change Dir: C:/CI/workspace/Frameworks kio kf5-qt5 WindowsMSVCQt5.9/build/CMakeFiles/CMakeTmpRun Build Command:"jom" "/NOLOGO" "cmTC_ae964\fast"  	C:\CM\msvc2017x64d\dev-utils\bin\jom.exe -f  CMakeFiles\cmTC_ae964.dir\build.make /nologo -L  CMakeFiles\cmTC_ae964.dir\build  Building C object CMakeFiles/cmTC_ae964.dir/testCCompiler.c.obj	C:\PROGRA~2\MICROS~1\2017\PROFES~1\VC\Tools\MSVC\1412~1.258\bin\Hostx64\x64\cl.exe  @C:\Users\Jenkins\AppData\Local\Temp\testCCompiler.c.obj.10148.16.jom  testCCompiler.c  C:\CI\workspace\Frameworks kio kf5-qt5  WindowsMSVCQt5.9\build\CMakeFiles\CMakeTmp\testCCompiler.c: fatal error  C1902: Program database manager mismatch; please check your installation  jom: C:\CI\workspace\Frameworks kio kf5-qt5  WindowsMSVCQt5.9\build\CMakeFiles\CMakeTmp\CMakeFiles\cmTC_ae964.dir\build.make  [CMakeFiles\cmTC_ae964.dir

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 45 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/45/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 10 Jan 2018 09:39:52 +
 Build duration:
9 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 56 test(s)

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 124 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/124/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Wed, 10 Jan 2018 09:55:27 +
 Build duration:
15 min and counting

D9784: [ConfigModule] Re-use QML context and engine if any

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  In case the ConfigModule is created within a QML context, re-use it and its 
engine instead of creating a shared QML object that might use a different 
engine.
  
  CCBUG: 388766

TEST PLAN
  Needs a followup patch in Plasma to set the context

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D9784

AFFECTED FILES
  src/quickaddons/configmodule.cpp

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9785: [ConfigModel] Set QML context on ConfigModule

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This will have the ConfigModule use the same engine as we do, ensuring we use 
the correct QtQuick Controls style.
  
  BUG: 388766

TEST PLAN
  Plasma-pa plasmoid settings use correct QtQuick Controls style now (used 
Plasma style, now using desktop style again)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9785

AFFECTED FILES
  src/plasmaquick/configmodel.cpp

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.7 - Build # 27 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/27/
 Project:
Frameworks kirigami kf5-qt5 SUSEQt5.7
 Date of build:
Wed, 10 Jan 2018 10:37:46 +
 Build duration:
2 min 47 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)50%
(7/14)50%
(7/14)46%
(402/871)32%
(175/554)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)examples.galleryapp0%
(0/1)0%
(0/1)0%
(0/10)0%
(0/4)src71%
(5/7)71%
(5/7)32%
(171/534)25%
(102/416)src.libkirigami40%
(2/5)40%
(2/5)72%
(231/319)54%
(73/134)

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/26/
 Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 10 Jan 2018 10:37:46 +
 Build duration:
6 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/4)0%
(0/14)0%
(0/14)0%
(0/844)0%
(0/554)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)examples.galleryapp0%
(0/1)0%
(0/1)0%
(0/10)0%
(0/4)src0%
(0/7)0%
(0/7)0%
(0/520)0%
(0/416)src.libkirigami0%
(0/5)0%
(0/5)0%
(0/306)0%
(0/134)

D9734: [KFileItemActions] Allow specifying the number of selected files required for an action

[Michael Heidelbach]

michaelh added a comment.


  +1 This looks like a *very* good idea to me.
  
  How can I fetch this? I want to try it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9734

To: broulik, #frameworks, dfaure, michaelh, mlaurent

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/18/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 10 Jan 2018 10:37:46 +
 Build duration:
40 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

D9734: [KFileItemActions] Allow specifying the number of selected files required for an action

[Kai Uwe Broulik]

broulik added a comment.


  You might want to check out 
https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9734

To: broulik, #frameworks, dfaure, michaelh, mlaurent

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

[Veluri Mithun]

velurimithun updated this revision to Diff 25076.
velurimithun added a comment.


  - Use QString::fromUtf8(..) to decode an escape sequence like \x21

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9420?vs=24493&id=25076

BRANCH
  complieWithoutRemoveDef

REVISION DETAIL
  https://phabricator.kde.org/D9420

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/desktoptojsontest.cpp
  autotests/kaboutdataapplicationdatatest.cpp
  autotests/kaboutdatatest.cpp
  autotests/kautosavefiletest.cpp
  autotests/kdelibs4migrationtest.cpp
  autotests/kformattest.cpp
  autotests/kpluginfactorytest.cpp
  autotests/kpluginloadertest.cpp
  autotests/kpluginmetadatatest.cpp
  autotests/kprocesstest.cpp
  autotests/krandomtest.cpp
  autotests/kshelltest.cpp
  autotests/kstringhandlertest.cpp
  autotests/ktexttohtmltest.cpp
  autotests/kusertest.cpp
  autotests/multiplugin.cpp

To: velurimithun, mlaurent
Cc: dfaure, #frameworks

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

[Veluri Mithun]

velurimithun marked an inline comment as done.
velurimithun added a comment.


  Fixed :)
  
  StringEncodings  doc helped 
me to understand encoding and decoding.
  
  Still if there any modifications kindly let me know.
  
  Thank You.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9420

To: velurimithun, mlaurent
Cc: dfaure, #frameworks

D9734: [KFileItemActions] Allow specifying the number of selected files required for an action

[Michael Heidelbach]

michaelh added a comment.


  I overlooked that this was commited today.
  The general question remains: How can I fetch a diff that has not been 
committed yet?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9734

To: broulik, #frameworks, dfaure, michaelh, mlaurent

D9734: [KFileItemActions] Allow specifying the number of selected files required for an action

[Kai Uwe Broulik]

broulik added a comment.


  >   How can I fetch a diff that has not been committed yet?
  
  It has been :) Either "Download Raw Diff" and then `git apply` or use `arc 
patch D1234` using arcanist

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9734

To: broulik, #frameworks, dfaure, michaelh, mlaurent

D9734: [KFileItemActions] Allow specifying the number of selected files required for an action

[Michael Heidelbach]

michaelh added a comment.


  Just tried it. Great!
  
  > If the need should arise, this could be made more sophisticated by adding 
support for e.g. ranges and less than/more than operators, but let's keep it 
simple for now.
  
  Yes. E.g. I have a ServiceMenu to concatenate files. So something like this
  
X-KDE-RequiredNumberOfUrls=2-
  
  would be nice.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9734

To: broulik, #frameworks, dfaure, michaelh, mlaurent

D9468: Refactor Solid::NetworkingPrivate to have a shared and platform specific implementation

[Ralf Habacker]

habacker updated this revision to Diff 25088.
habacker added a comment.


  - fix generating slot access code

REPOSITORY
  R239 KDELibs4Support

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9468?vs=24256&id=25088

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9468

AFFECTED FILES
  src/CMakeLists.txt
  src/solid/networking.cpp
  src/solid/networking_unix.cpp
  src/solid/networking_win.cpp

To: habacker, dfaure
Cc: #frameworks

D9468: Refactor Solid::NetworkingPrivate to have a shared and platform specific implementation

[Ralf Habacker]

habacker edited the summary of this revision.
habacker edited the test plan for this revision.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D9468

To: habacker, dfaure
Cc: #frameworks

Re: Problem in loading QM translations with LANGUAGE="" envar

[Safa Alfulaij]

More investigation shows that it does not work with other locales than the
default one (the one that is used in case you don't pass a country code,
which, in case of Arabic, is ar_EG).

[safa@archlinux]$ LANG=ar_BH.utf8
> [safa@archlinux]$ python testQtLocale.py
> b'\xd9\xa2\xd9\xa0 B'
> [safa@archlinux]$ LANG=ar_EG.utf8
> [safa@archlinux]$ python testQtLocale.py
> b'\xd9\xa2\xd9\xa0 \xd8\xa8\xd8\xa7\xd9\x8a\xd8\xaa'
> [safa@archlinux]$ LANG=ar_SA.utf8
> [safa@archlinux]$ python testQtLocale.py
> b'\xd9\xa2\xd9\xa0 B'
> [safa@archlinux]$ LANG=ar_TN.utf8
> [safa@archlinux]$ python testQtLocale.py
> b'20 B'


Notice the translated version of "B" in ar_EG. The locale is set correctly
as we can see ar_TN uses the correct English/Arabic (not Hindi) numbering
system.
So it seems that the files are registered for that ar_EG locale only, which
is causing the trouble.

Note: Qt prioritizes LANGUAGE which has no country code, and that was the
problem. I'll be sending a small patch to use LANG if the first choice in
LANGUAGE is the same as LANG's main language.

Regards

2018-01-10 5:49 GMT+03:00 Safa Alfulaij :

> Well, I don't want to remove it but it's a must. First it's not right
> logically and second is that Qt prefers it over LANG, and use any locale
> varient since it has no country name. (QLocale("ar") returns "Arabic
> (Egypt)" (which is defind in unicode), instead of my "Arabic (Bahrain)"
> locale.
> And it's the only thing that is not getting translated which is obviously
> a bug.
>
> Regards
>
> On Jan 10, 2018 12:20 AM, "Albert Astals Cid"  wrote:
>
>> El dimarts, 9 de gener de 2018, a les 20:08:02 CET, Safa Alfulaij va
>> escriure:
>> > Hello all.
>> >
>> > After doing some investigation about a problem, I came into an issue in
>> > loading correct translations in Frameworks (that has the “_qt” suffix in
>> > translation system).
>> > Previously, I had my LANGUAGE enviroment variable containing “ar”,
>> which is
>> > because I added Arabic in my “Language” KCM (without knowing that I
>> don't
>> > need it if the locale is alread set to Arabic).
>> > This was normal and things was translated well. Today I removed that
>> “ar”
>> > because it's not needed, and all applications (Qt, KDE, Gnome, other
>> KF5s)
>> > worked except for those frameworks which are using QM files (the ones
>> with
>> > “_qt” suffix). The translation isn't loaded and strings are shown in
>> > English.
>>
>> So don't remove it?
>>
>> Cheers,
>>   Albert
>>
>

D9781: do not incorrectly split spaces in paths of duplicate results

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9781

To: sitter, dfaure, apol
Cc: #frameworks

D9116: Make sure to search for Qt5-based qmlplugindump

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In https://phabricator.kde.org/D9116#186638, @asturmlechner wrote:
  
  > Can we move forward with this?
  
  
  ECM provides ECMQueryQmake.cmake. you can try eg:
  
  include("${ECM_MODULE_DIR}/ECMQueryQmake.cmake")
  then calling query_qmake(qt_binaries_dir QT_INSTALL_BINS)
  
  and use ${qt_binaries_dir} as HINT

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D9116

To: asturmlechner, apol
Cc: aacid, dfaure, cgiboudeaux, #frameworks, #build_system

D9781: do not incorrectly split spaces in paths of duplicate results

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:08ddec40bf89: do not incorrectly split spaces in paths of 
duplicate results (authored by sitter).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9781?vs=25061&id=25092

REVISION DETAIL
  https://phabricator.kde.org/D9781

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/dupetest.cpp

To: sitter, dfaure, apol
Cc: #frameworks

KDE CI: Frameworks breeze-icons kf5-qt5 AndroidQt5.9 - Build # 32 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/32/
 Project:
Frameworks breeze-icons kf5-qt5 AndroidQt5.9
 Date of build:
Wed, 10 Jan 2018 15:41:22 +
 Build duration:
55 sec and counting
   CONSOLE OUTPUT
  [...truncated 38.19 KB...]JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/display/redirect'PATH  = '/opt/Qt/5.9.1/android_armv7/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/Qt/5.9.1/android_armv7/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/android-sdk-linux/tools:/opt/android-sdk-linux/platform-tools'XDG_DATA_DIRS = '/home/user/install-prefix/share:/opt/kdeandroid-deps/share'ANDROID_NDK_TOOLCHAIN_VERSION = '4.9'QT_ANDROID= '/opt/Qt/5.9.1/android_armv7'USER  = 'user'HUDSON_URL= 'https://build.kde.org/'PWD   = '/home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.9'JENKINS_NODE_COOKIE   = 'fba032bf-06a4-4ec9-9fe9-5a5a100b53b4'HOME  = '/home/user'BUILD_DISPLAY_NAME= '#32'BUILD_NUMBER  = '32'BUILD_URL = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/32/'JOB_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/'CMAKE_PREFIX_PATH = '/home/user/install-prefix:/opt/Qt/5.9.1/android_armv7:/opt/kdeandroid-deps'NODE_NAME = 'Docker Swarm-d40a119e2819'ANDROID_NDK_TOOLS_PREFIX  = 'arm-linux-androideabi'HUDSON_HOME   = '/home/production/data'STAGE_NAME= 'Configuring Build'JENKINS_URL   = 'https://build.kde.org/'WORKSPACE = '/home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.9'ANDROID_NDK_ROOT  = '/opt/android-ndk'JENKINS_HOME  = '/home/production/data'HOSTNAME  = '756b8e6d4d38'BUILD_TAG = 'jenkins-Frameworks breeze-icons kf5-qt5 AndroidQt5.9-32'NODE_LABELS   = 'AndroidQt5.9 Docker Swarm-d40a119e2819'SHLVL = '0'QMAKESPEC = 'android-g++'JOB_NAME  = 'Frameworks breeze-icons kf5-qt5 AndroidQt5.9'QT_PATH   = '/opt/Qt'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/32/display/redirect?page=changes'ANDROID_NDK_PLATFORM  = 'android-21'MAIL  = '/var/mail/user'ANDROID_NDK   = '/opt/android-ndk'ANDROID_SDK_ROOT  = '/opt/android-sdk-linux'EXECUTOR_NUMBER   = '0'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/32/display/redirect'DEBIAN_FRONTEND   = 'noninteractive'JOB_BASE_NAME = 'Frameworks breeze-icons kf5-qt5 AndroidQt5.9'SHELL = '/bin/sh'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/user/install-prefix/" -DBUILD_COVERAGE=ON -DCMAKE_TOOLCHAIN_FILE="/opt/kdeandroid-deps/share/ECM/toolchain/Android.cmake" -DKF5_HOST_TOOLING=/opt/nativetooling/lib/x86_64-linux-gnu/cmake/ -DECM_ADDITIONAL_FIND_ROOT_PATH="/home/user/install-prefix;/opt/Qt/5.9.1/android_armv7;/opt/kdeandroid-deps"  "/home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.9"-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET=-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET=-- The C compiler identification is GNU 4.9.0-- The CXX compiler identification is GNU 4.9.0-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - FailedCMake Error at autotests/CMakeLists.txt:7 (find_package):  By not providing "FindKF5CoreAddons.cmake" in CMAKE_MODULE_PATH this  project has asked CMake to find a package configurat

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 23 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/23/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 10 Jan 2018 15:41:22 +
 Build duration:
1 min 2 sec and counting
   CONSOLE OUTPUT
  [...truncated 58.10 KB...]MORE  = '-sl'WORKSPACE = '/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.10'PWD   = '/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.10'HUDSON_URL= 'https://build.kde.org/'HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-9ebf04e5a2d3'HOST  = '9ebf04e5a2d3'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JENKINS_HOME  = '/home/production/data'JOB_NAME  = 'Frameworks breeze-icons kf5-qt5 SUSEQt5.10'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'NLSPATH   = '/usr/dt/lib/nls/msg/%L/%N.cat'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/display/redirect'NNTPSERVER= 'news'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/23/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/'BUILD_DISPLAY_NAME= '#23'XCURSOR_THEME = 'DMZ'PYTHONSTARTUP = '/etc/pythonstart'SHLVL = '2'BUILD_TAG = 'jenkins-Frameworks breeze-icons kf5-qt5 SUSEQt5.10-23'NODE_LABELS   = 'Docker Swarm-9ebf04e5a2d3 SUSEQt5.10'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/etc/xdg'PATH  = '/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'PKG_CONFIG_PATH   = '/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.10"-- The C compiler identification is GNU 7.2.1-- The CXX compiler identification is GNU 7.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Error at autotests/CMakeLists.txt:7 (find_package):  By not providing "FindKF5CoreAddons.cmake" in CMAKE_MODULE_PATH this  project has asked CMake to find a package configuration file provided by  "KF5CoreAddons", but CMake did not find one.  Could not find a package configuration file provided by "KF5CoreAddons"  (requested version 5.42.0) with any of the following names:KF5CoreAddonsConfig.cmakekf5coreaddons-config.cmake  Add the installation prefix of "KF5CoreAddons" to CMAKE_PREFIX_PATH or set  "KF5CoreAddons_DIR" to a directory containing one of the above files.  If  "KF5CoreAddons" provides a separate development package or SDK, be sure it  has been installed.-- Configuring incomplete, errors occurred!See also "/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.10/build/CMakeFiles/CMakeOutput.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks breeze-icons kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environme

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 22 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/22/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 10 Jan 2018 15:41:22 +
 Build duration:
1 min 25 sec and counting
   CONSOLE OUTPUT
  [...truncated 42.81 KB...]SHELL = '/usr/local/bin/bash'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'JENKINS_NODE_COOKIE   = '178eedd5-d973-4cb0-b9f6-b73aa81dcf5f'JOB_BASE_NAME = 'Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9'STAGE_NAME= 'Configuring Build'NODE_LABELS   = 'FreeBSD Builder 3 FreeBSDQt5.9'PKG_CONFIG_PATH   = '/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'BUILD_TAG = 'jenkins-Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9-22'USER  = 'jenkins'PATH  = '/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/home/jenkins/bin'XDG_CONFIG_DIRS   = '/usr/local/etc/xdg'LOGNAME   = 'jenkins'BUILD_ID  = '22'SHLVL = '0'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/22/display/redirect'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'LANG  = 'en_US.UTF-8'JOB_NAME  = 'Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9'WORKSPACE = '/usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9"-- The C compiler identification is Clang 3.8.0-- The CXX compiler identification is Clang 3.8.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Warning (dev) at /usr/local/lib/cmake/Qt5/Qt5ModuleLocation.cmake:4 (set):  Policy CMP0053 is not set: Simplify variable reference and escape sequence  evaluation.  Run "cmake --help-policy CMP0053" for policy details.  Use the  cmake_policy command to set the policy and suppress this warning.  For input:'${_qt5_install_prefix}/Qt5@module@/Qt5@module@Config.cmake'  the old evaluation rules produce:'/usr/local/lib/cmake/Qt5/Qt5Config.cmake'  but the new evaluation rules produce:'/usr/local/lib/cmake/Qt5@module@/Qt5@module@Config.cmake'  Using the old result for compatibility since the policy is not set.Call Stack (most recent call first):  /usr/local/lib/cmake/Qt5/Qt5Config.cmake:25 (include)  autotests/CMakeLists.txt:6 (find_package)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Error at autotests/CMakeLists.txt:7 (find_package):  By not providing "FindKF5CoreAddons.cmake" in CMAKE_MODULE_PATH this  project has asked CMake to find a package configuration file provided by  "KF5CoreAddons", but CMake did not find one.  Could not find a package configuration file provided by "KF5CoreAddons"  (requested version 5.42.0) with any of the following names:KF5CoreAddonsConfig.cmakekf5coreaddons-config.cmake  Add the installation prefix of "KF5CoreAddons" to CMAKE_PREFIX_PATH or set  "KF5CoreAddons_DIR" to a directory containing one of the above files.  If  "KF5CoreAddons" provides a separate development package or SDK, be sure it  has been installed.-- Configuring incomplete, errors occurred!See also "/usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/build/CMakeFiles/CMakeOutput.log".See also "/usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/build/CMakeFiles/CMakeError.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 24 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/24/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
 Date of build:
Wed, 10 Jan 2018 15:41:22 +
 Build duration:
3 min 20 sec and counting
   CONSOLE OUTPUT
  [...truncated 58.35 KB...]MORE  = '-sl'WORKSPACE = '/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.7'PWD   = '/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.7'HUDSON_URL= 'https://build.kde.org/'HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-a8e7410d6063'HOST  = 'a8e7410d6063'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JENKINS_HOME  = '/home/production/data'JOB_NAME  = 'Frameworks breeze-icons kf5-qt5 SUSEQt5.7'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'NLSPATH   = '/usr/dt/lib/nls/msg/%L/%N.cat'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/display/redirect'NNTPSERVER= 'news'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/24/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/'BUILD_DISPLAY_NAME= '#24'XCURSOR_THEME = 'DMZ'PYTHONSTARTUP = '/etc/pythonstart'SHLVL = '2'BUILD_TAG = 'jenkins-Frameworks breeze-icons kf5-qt5 SUSEQt5.7-24'NODE_LABELS   = 'Docker Swarm-a8e7410d6063 SUSEQt5.7'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/etc/xdg'PATH  = '/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'PKG_CONFIG_PATH   = '/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.7"-- The C compiler identification is GNU 7.2.1-- The CXX compiler identification is GNU 7.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Error at autotests/CMakeLists.txt:7 (find_package):  By not providing "FindKF5CoreAddons.cmake" in CMAKE_MODULE_PATH this  project has asked CMake to find a package configuration file provided by  "KF5CoreAddons", but CMake did not find one.  Could not find a package configuration file provided by "KF5CoreAddons"  (requested version 5.42.0) with any of the following names:KF5CoreAddonsConfig.cmakekf5coreaddons-config.cmake  Add the installation prefix of "KF5CoreAddons" to CMAKE_PREFIX_PATH or set  "KF5CoreAddons_DIR" to a directory containing one of the above files.  If  "KF5CoreAddons" provides a separate development package or SDK, be sure it  has been installed.-- Configuring incomplete, errors occurred!See also "/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.7/build/CMakeFiles/CMakeOutput.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks breeze-icons kf5-qt5 SUSEQt5.7] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment productio

D9793: Fall back to language name for translations lookup if locale name fails

[Wolfgang Bauer]

wbauer created this revision.
wbauer added a reviewer: Frameworks.
wbauer added a project: Frameworks.
Restricted Application added a project: Build System.
Restricted Application added a subscriber: Build System.
wbauer requested review of this revision.

REVISION SUMMARY
  For locales like de_AT, the current code only looks in share/locale/de_AT/ 
and share/locale/de-AT/ for translation catalogs, but not in share/locale/de/ 
where they most likely are.
  That's because bcp47Name() returns "de-AT" for de_AT (though in the case of 
de_DE e.g. it does return "de").
  
  This patch instead tries to fall back to the general language by taking the 
part of the locale name before the first '_'.

TEST PLAN
  Rebuilt kwidgetsaddons with this change.
  Unset $LANGUAGE (if set) and set $LANG=de_AT.UTF-8 (or set $LANGUAGE=de_AT in 
the first place)
  Ran systemsettings5 and enter some module.
  
  Without this patch the Help/Default/Reset/Apply buttons are untranslated 
because the kwidgetsaddons translations are not loaded (according to strace or 
added debug output they are only looked up in share/locale/de_AT/ and 
share/locale/de-AT/, they are in share/locale/de/ on my system).
  With this patch the buttons are translated, the translations are now loaded 
from share/locale/de/ (after trying share/locale/de_AT/ and failing).
  
  Also ran "kdesu xxx". "Password:", "Remember password", "Cancel" were 
untranslated in the password dialog before, they are translated to german now.
  
  Tests that passed before still pass.
  The new/modified test passes now too, it fails with the original code.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D9793

AFFECTED FILES
  modules/ECMQmLoader.cpp.in
  tests/ECMPoQmToolsTest/check.cmake.in

To: wbauer, #frameworks
Cc: #build_system

D9793: Fall back to language name for translations lookup if locale name fails

[Wolfgang Bauer]

wbauer added a comment.


  I don't think bcp47Name makes any sense here.
  According to the Qt documentation, this "Returns the dash-separated language, 
script and country (and possibly other BCP47 fields) of this locale as a 
string" (and "Unlike the uiLanguages() the returned value of the bcp47Name() 
represents the locale name of the QLocale data but not the language the 
user-interface should be in").
  
  I will gladly leave it in if preferred though, and add my change afterwards 
if that fails as well.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D9793

To: wbauer, #frameworks
Cc: #build_system

D9794: Provide access to data returned by helper even on error replies

[Alexander Volkov]

volkov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
volkov requested review of this revision.

REVISION SUMMARY
  Helper may provide an additional information about an error in it.

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9794

AFFECTED FILES
  src/kauthexecutejob.cpp

To: volkov
Cc: #frameworks

D9794: Provide access to data returned by helper even on error replies

[Alexander Volkov]

volkov added a reviewer: Frameworks.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D9794

To: volkov, #frameworks
Cc: #frameworks

KDE CI: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9 - Build # 37 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.9/37/
 Project:
Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Wed, 10 Jan 2018 15:41:22 +
 Build duration:
41 min and counting
   CONSOLE OUTPUT
  [...truncated 59.50 KB...]PROGRAMW6432  = 'C:\Program Files'PROMPT= '$P$G'PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'PUBLIC= 'C:\Users\Public'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.9/37/display/redirect?page=changes'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.9/37/display/redirect'STAGE_NAME= 'Configuring Build'SYSTEMDRIVE   = 'C:'SYSTEMROOT= 'C:\WINDOWS'TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'UCRTVERSION   = '10.0.16299.0'UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'USERDOMAIN= 'DESKTOP-0LVFIKI'USERNAME  = 'Jenkins'USERPROFILE   = 'C:\Users\Jenkins'VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\IDE\VC\'VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\'VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.12.25827\'VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Redist\MSVC\14.12.25810\'VCTOOLSVERSION= '14.12.25827'VISUALSTUDIOVERSION   = '15.0'VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'VS150COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\Tools\'VSCMD_ARG_APP_PLAT= 'Desktop'VSCMD_ARG_HOST_ARCH   = 'x64'VSCMD_ARG_TGT_ARCH= 'x64'VSCMD_VER = '15.5.3'VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\'WINDIR= 'C:\WINDOWS'WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.16299.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.16299.0'WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'WINDOWSSDKLIBVERSION  = '10.0.16299.0\'WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.16299.0\'WINDOWSSDKVERSION = '10.0.16299.0\'WORKSPACE = 'C:\CI\workspace\Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9'__DOTNET_ADD_64BIT= '1'__DOTNET_PREFERRED_BITNESS = '64'__VSCMD_PREINIT_PATH  = 'C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files (x86)\Git\cmd;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'CMAKE_PREFIX_PATH = 'C:\CI\workspace\Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9\install-prefix;C:\CM\msvc2017x64d;C:\CM\msvc2017x64d\dev-utils'XDG_DATA_DIRS = 'C:\CI\workspace\Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9\install-prefix\share;C:\CM\msvc2017x64d\share;C:\CM\msvc2017x64d\dev-utils\share'PKG_CONFIG_PATH   = 'C:\CM\msvc2017x64d\lib\pkgconfig;C:\CM\msvc2017x64d\dev-utils\lib\pkgconfig'QMAKEFEATURES = 'C:\CM\msvc2017x64d\mkspecs/features'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:\CI\workspace\Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9/install-prefix/" -G "NMake Makefiles JOM"  "C:\CI\workspace\Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9"-- The C compiler identification is MSVC 19.12.25834.0-- The CXX compiler identification is MSVC 19.12.25834.0-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft 

D9770: Optimization of byteSize(double size)

[Jaime Torres Amate]

jtamate updated this revision to Diff 25114.
jtamate added a comment.


  - De-duplication of code in byteSize(double size)
  
  In fact Milian Wolff is right.
  
  Why so many calls to this function?
  Copying 20Gb it is called 19.026 times (aproximately 10 times per second) from
  processedSize() in slavebase.cpp in kio

REPOSITORY
  R288 KJobWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9770?vs=25034&id=25114

BRANCH
  performance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9770

AFFECTED FILES
  src/kjobtrackerformatters.cpp

To: jtamate, #frameworks, mwolff
Cc: mwolff, broulik

Re: Problem in loading QM translations with LANGUAGE="" envar

[Wolfgang Bauer]

Hi,

I noticed a similar problem here.
My LANG is set to "de_AT.UTF-8", and if LANGUAGE is not set, parts of KDE 
applications are untranslated (i.e. those frameworks translations that come 
from .qm files are missing).

Sure, setting LANGUAGE to "de" will fix that, but it's not necessarily set on 
other desktops, and even in Plasma it will not be set on a fresh user account 
(only if you explicitly configure the language in systemsettings5).
Also, the problem will also occur if LANGUAGE is set to "de_AT" or similar.

I investigated the issue and proposed a fix here though:
https://phabricator.kde.org/D9793

Note that if you'd want to try it, you'd need to recompile all affected 
frameworks with the patched extra-cmake-modules.

Kind Regards,
Wolfgang

Re: Problem in loading QM translations with LANGUAGE="" envar

[Albert Astals Cid]

El dimecres, 10 de gener de 2018, a les 5:49:54 CET, Safa Alfulaij va 
escriure:
> Well, I don't want to remove it but it's a must. First it's not right
> logically and second is that Qt prefers it over LANG, and use any locale
> varient since it has no country name. (QLocale("ar") returns "Arabic
> (Egypt)" (which is defind in unicode), instead of my "Arabic (Bahrain)"
> locale.
> And it's the only thing that is not getting translated which is obviously a
> bug.

Why not use ar_BH as LANGUAGE?

this is the output of my locale

$ locale
LANG=ca_ES.UTF-8
LANGUAGE=ca_ES
LC_CTYPE="ca_ES.UTF-8"
LC_NUMERIC="ca_ES.UTF-8"
LC_TIME="ca_ES.UTF-8"
LC_COLLATE="ca_ES.UTF-8"
LC_MONETARY="ca_ES.UTF-8"
LC_MESSAGES="ca_ES.UTF-8"
LC_PAPER="ca_ES.UTF-8"
LC_NAME="ca_ES.UTF-8"
LC_ADDRESS="ca_ES.UTF-8"
LC_TELEPHONE="ca_ES.UTF-8"
LC_MEASUREMENT="ca_ES.UTF-8"
LC_IDENTIFICATION="ca_ES.UTF-8"
LC_ALL=

Cheers,
  Albert


> 
> Regards
> 
> On Jan 10, 2018 12:20 AM, "Albert Astals Cid"  wrote:
> > El dimarts, 9 de gener de 2018, a les 20:08:02 CET, Safa Alfulaij va
> > 
> > escriure:
> > > Hello all.
> > > 
> > > After doing some investigation about a problem, I came into an issue in
> > > loading correct translations in Frameworks (that has the “_qt” suffix in
> > > translation system).
> > > Previously, I had my LANGUAGE enviroment variable containing “ar”, which
> > 
> > is
> > 
> > > because I added Arabic in my “Language” KCM (without knowing that I
> > > don't
> > > need it if the locale is alread set to Arabic).
> > > This was normal and things was translated well. Today I removed that
> > > “ar”
> > > because it's not needed, and all applications (Qt, KDE, Gnome, other
> > 
> > KF5s)
> > 
> > > worked except for those frameworks which are using QM files (the ones
> > 
> > with
> > 
> > > “_qt” suffix). The translation isn't loaded and strings are shown in
> > > English.
> > 
> > So don't remove it?
> > 
> > Cheers,
> > 
> >   Albert

D9770: Optimization of byteSize(double size)

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kjobtrackerformatters.cpp:26
>  #include "kjobtrackerformatters_p.h"
> +#include "kformat.h"
>  

Isn't KFormat from a different framework? Adjust the include to use  
style, and check if CMakeLists.txt needs to be adjusted.

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D9770

To: jtamate, #frameworks, mwolff
Cc: cfeck, mwolff, broulik

Re: KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 22 - Still Failing!

[Ben Cooksley]

On Wed, Jan 10, 2018 at 5:46 PM, Ben Cooksley  wrote:

> Hi Andreas,
>

Hi Andreas,


>
> Please see below. Following your two commits, breeze-icons failed on all
> platform/Qt versions monitored by the CI system.
> If you could fix that please it would be appreciated.
>

Your immediate response to this issue is required.
Should you fail to respond within the next 6 hours I will be reverting both
of the commits you made which broke the build.

Broken Frameworks builds significantly impairs the ability of people to
work on Frameworks and also has a knock on effect on our ability to make
changes to the CI system (such as adding system wide dependencies) which
has a KDE wide impact.

Regards,
Ben


>
> Cheers,
> Ben
>
>
> On Wed, Jan 10, 2018 at 9:42 AM, CI System  wrote:
>
>> *BUILD FAILURE*
>> Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-
>> qt5%20SUSEQt5.10/22/
>> Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10
>> Date of build: Tue, 09 Jan 2018 20:39:01 +
>> Build duration: 3 min 27 sec and counting
>> * CONSOLE OUTPUT *
>> [...truncated 58.37 KB...]
>> MORE = '-sl'
>> WORKSPACE = '/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5
>> SUSEQt5.10'
>> PWD = '/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5
>> SUSEQt5.10'
>> HUDSON_URL = 'https://build.kde.org/'
>> HOME = '/home/jenkins/'
>> NODE_NAME = 'Docker Swarm-786757edb734'
>> HOST = '786757edb734'
>> XNLSPATH = '/usr/X11R6/lib/X11/nls'
>> JENKINS_HOME = '/home/production/data'
>> JOB_NAME = 'Frameworks breeze-icons kf5-qt5 SUSEQt5.10'
>> XDG_DATA_DIRS = '/home/jenkins/install-prefix/
>> share:/usr/share:/usr/local/share:/usr/share'
>> NLSPATH = '/usr/dt/lib/nls/msg/%L/%N.cat'
>> LIBGL_DEBUG = 'quiet'
>> HUDSON_HOME = '/home/production/data'
>> JOB_DISPLAY_URL = 'https://build.kde.org/job/Fra
>> meworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/display/redirect'
>> NNTPSERVER = 'news'
>> PROFILEREAD = 'true'
>> MAIL = '/var/mail/jenkins'
>> LESSKEY = '/etc/lesskey.bin'
>> BUILD_URL = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-
>> qt5%20SUSEQt5.10/22/'
>> SHELL = '/bin/bash'
>> STAGE_NAME = 'Configuring Build'
>> JOB_URL = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-
>> qt5%20SUSEQt5.10/'
>> BUILD_DISPLAY_NAME = '#22'
>> XCURSOR_THEME = 'DMZ'
>> PYTHONSTARTUP = '/etc/pythonstart'
>> SHLVL = '2'
>> BUILD_TAG = 'jenkins-Frameworks breeze-icons kf5-qt5 SUSEQt5.10-22'
>> NODE_LABELS = 'Docker Swarm-786757edb734 SUSEQt5.10'
>> LOGNAME = 'jenkins'
>> JRE_HOME = '/usr/lib64/jvm/jre'
>> XDG_CONFIG_DIRS = '/etc/xdg'
>> PATH = '/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/
>> mit/bin:/usr/lib/mit/sbin'
>> JAVA_BINDIR = '/usr/lib64/jvm/jre/bin'
>> G_BROKEN_FILENAMES = '1'
>> HISTSIZE = '1000'
>> CPU = 'x86_64'
>> CVS_RSH = 'ssh'
>> LESSOPEN = 'lessopen.sh %s'
>> CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'
>> PKG_CONFIG_PATH = '/usr/lib/pkgconfig:/usr/lib64/pkgconfig'
>> QT_SELECT = 'qt5'
>> XDG_CURRENT_DESKTOP = 'KDE'
>> ASAN_OPTIONS = 'detect_leaks=0:new_delete_typ
>> e_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:
>> alloc_dealloc_mismatch=0'
>> == Commencing Configuration:
>> cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address'
>> -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/"
>> -DBUILD_COVERAGE=ON "/home/jenkins/workspace/Frameworks breeze-icons
>> kf5-qt5 SUSEQt5.10"
>> -- The C compiler identification is GNU 7.2.1
>> -- The CXX compiler identification is GNU 7.2.1
>> -- Check for working C compiler: /usr/bin/cc
>> -- Check for working C compiler: /usr/bin/cc -- works
>> -- Detecting C compiler ABI info
>> -- Detecting C compiler ABI info - done
>> -- Detecting C compile features
>> -- Detecting C compile features - done
>> -- Check for working CXX compiler: /usr/bin/c++
>> -- Check for working CXX compiler: /usr/bin/c++ -- works
>> -- Detecting CXX compiler ABI info
>> -- Detecting CXX compiler ABI info - done
>> -- Detecting CXX compile features
>> -- Detecting CXX compile features - done
>> --
>> -- Looking for __GLIBC__
>> -- Looking for __GLIBC__ - found
>> -- Performing Test _OFFT_IS_64BIT
>> -- Performing Test _OFFT_IS_64BIT - Success
>> -- Performing Test HAVE_DATE_TIME
>> -- Performing Test HAVE_DATE_TIME - Success
>> -- The following REQUIRED packages have been found:
>> * ECM (required version >= 5.42.0), Extra CMake Modules., <
>> https://projects.kde.org/projects/kdesupport/extra-cmake-modules>
>> * Qt5Core
>> * Qt5Test
>> * Qt5 (required version >= 5.7.0)
>> -- Configuring done
>> CMake Error at CMakeLists.txt:79 (add_custom_target):
>> Cannot find source file:
>> /home/jenkins/workspace/Frameworks breeze-icons kf5-qt5
>> SUSEQt5.10/icons-dark/status/16/state-error.svg
>> Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
>> .hxx .in .txx
>> -- Generating done
>> -- Build files have been written to: /home/jenkins/workspace/Frameworks
>> breeze-icons kf5-qt5 SUSEQt5

D9802: Avoid Dolphin crash

[Michael Heidelbach]

michaelh created this revision.
michaelh added reviewers: Dolphin, Frameworks.
michaelh added projects: Dolphin, Frameworks, KDE Applications.
michaelh requested review of this revision.

REVISION SUMMARY
  Removed Q_ASSERT

TEST PLAN
  $ dolphin tags:/Genre/Drama/

REPOSITORY
  R241 KIO

BRANCH
  nestedtags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9802

AFFECTED FILES
  src/core/kcoredirlister.cpp

To: michaelh, #dolphin, #frameworks
Cc: ngraham, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, 
alexeymin, genaxxx, emmanuelp

D9802: Avoid Dolphin crash

[Michael Heidelbach]

michaelh added a comment.


  Reason:
  dolphin crashes when navigation to a nested tag e.g.
  
tags:/Genre/Drama/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9802

To: michaelh, #dolphin, #frameworks
Cc: ngraham, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, 
alexeymin, genaxxx, emmanuelp

D9802: Avoid Dolphin crash

[Nathaniel Graham]

ngraham added a comment.


  Hmm, I can't reproduce the crash with Dolphin and KIO from git master. 
`dolphin tags:/Genre/Drama/` (after created a nested tag Genre/Drama) works 
fine for me.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9802

To: michaelh, #dolphin, #frameworks
Cc: ngraham, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, 
alexeymin, genaxxx, emmanuelp

D9802: Avoid Dolphin crash

[Andreas Krutzler]

akrutzler added inline comments.

INLINE COMMENTS

> kcoredirlister.cpp:1233
>  
> -Q_ASSERT(!name.isEmpty());
>  if (name.isEmpty()) {

Q_ASSERT is just executed in debug builds. It wont crash in release builds.
Checkout https://doc-snapshots.qt.io/qt5-dev/qtglobal.html#Q_ASSERT

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9802

To: michaelh, #dolphin, #frameworks
Cc: akrutzler, ngraham, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, alexeymin, genaxxx, emmanuelp

D9781: do not incorrectly split spaces in paths of duplicate results

[Christoph Feck]

cfeck added a comment.


  CI doesn't like Tier1 frameworks have a dependency on other Tier1 frameworks.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D9781

To: sitter, dfaure, apol
Cc: cfeck, #frameworks

D9770: Optimization of byteSize(double size)

[Jaime Torres Amate]

jtamate updated this revision to Diff 25121.
jtamate added a comment.


  - De-duplication of code in byteSize(double size)
  
  Changed the include.
  There is no need to change the CMakeLists.txt as 
  find_package(KF5CoreAddons ${KF5_DEP_VERSION} REQUIRED)
  is already included.

REPOSITORY
  R288 KJobWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9770?vs=25114&id=25121

BRANCH
  performance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9770

AFFECTED FILES
  src/kjobtrackerformatters.cpp

To: jtamate, #frameworks, mwolff
Cc: cfeck, mwolff, broulik

D9802: Avoid Dolphin crash

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> akrutzler wrote in kcoredirlister.cpp:1233
> Q_ASSERT is just executed in debug builds. It wont crash in release builds.
> Checkout https://doc-snapshots.qt.io/qt5-dev/qtglobal.html#Q_ASSERT

I'm working with kio right now. Is better to just comment it out for the time 
being?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9802

To: michaelh, #dolphin, #frameworks
Cc: akrutzler, ngraham, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, alexeymin, genaxxx, emmanuelp

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 25 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/25/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
 Date of build:
Wed, 10 Jan 2018 19:55:33 +
 Build duration:
42 sec and counting
   CONSOLE OUTPUT
  [...truncated 58.19 KB...]MORE  = '-sl'WORKSPACE = '/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.7'PWD   = '/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.7'HUDSON_URL= 'https://build.kde.org/'HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-e5376c1672f7'HOST  = 'e5376c1672f7'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JENKINS_HOME  = '/home/production/data'JOB_NAME  = 'Frameworks breeze-icons kf5-qt5 SUSEQt5.7'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'NLSPATH   = '/usr/dt/lib/nls/msg/%L/%N.cat'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/display/redirect'NNTPSERVER= 'news'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/25/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/'BUILD_DISPLAY_NAME= '#25'XCURSOR_THEME = 'DMZ'PYTHONSTARTUP = '/etc/pythonstart'SHLVL = '2'BUILD_TAG = 'jenkins-Frameworks breeze-icons kf5-qt5 SUSEQt5.7-25'NODE_LABELS   = 'Docker Swarm-e5376c1672f7 SUSEQt5.7'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/etc/xdg'PATH  = '/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'PKG_CONFIG_PATH   = '/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.7"-- The C compiler identification is GNU 7.2.1-- The CXX compiler identification is GNU 7.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Error at autotests/CMakeLists.txt:7 (find_package):  By not providing "FindKF5CoreAddons.cmake" in CMAKE_MODULE_PATH this  project has asked CMake to find a package configuration file provided by  "KF5CoreAddons", but CMake did not find one.  Could not find a package configuration file provided by "KF5CoreAddons"  (requested version 5.42.0) with any of the following names:KF5CoreAddonsConfig.cmakekf5coreaddons-config.cmake  Add the installation prefix of "KF5CoreAddons" to CMAKE_PREFIX_PATH or set  "KF5CoreAddons_DIR" to a directory containing one of the above files.  If  "KF5CoreAddons" provides a separate development package or SDK, be sure it  has been installed.-- Configuring incomplete, errors occurred!See also "/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.7/build/CMakeFiles/CMakeOutput.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks breeze-icons kf5-qt5 SUSEQt5.7] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipe

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 23 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/23/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 10 Jan 2018 19:55:33 +
 Build duration:
34 sec and counting
   CONSOLE OUTPUT
  [...truncated 42.69 KB...]EXECUTOR_NUMBER   = '0'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'JENKINS_NODE_COOKIE   = 'ed306a57-680a-4a3f-90e9-7226b6e9e59d'LOGNAME   = 'jenkins'SHELL = '/usr/local/bin/bash'JOB_NAME  = 'Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/display/redirect'QT_SELECT = 'qt5'PWD   = '/usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9'MM_CHARSET= 'UTF-8'TERM  = 'su'JOB_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/'JAVA_HOME = '/usr/local/openjdk8-jre'HOME  = '/usr/home/jenkins/'XDG_CONFIG_DIRS   = '/usr/local/etc/xdg'PKG_CONFIG_PATH   = '/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'BUILD_URL = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/23/'BUILD_TAG = 'jenkins-Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9-23'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins//install-prefix/"  "/usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9"-- The C compiler identification is Clang 3.8.0-- The CXX compiler identification is Clang 3.8.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Warning (dev) at /usr/local/lib/cmake/Qt5/Qt5ModuleLocation.cmake:4 (set):  Policy CMP0053 is not set: Simplify variable reference and escape sequence  evaluation.  Run "cmake --help-policy CMP0053" for policy details.  Use the  cmake_policy command to set the policy and suppress this warning.  For input:'${_qt5_install_prefix}/Qt5@module@/Qt5@module@Config.cmake'  the old evaluation rules produce:'/usr/local/lib/cmake/Qt5/Qt5Config.cmake'  but the new evaluation rules produce:'/usr/local/lib/cmake/Qt5@module@/Qt5@module@Config.cmake'  Using the old result for compatibility since the policy is not set.Call Stack (most recent call first):  /usr/local/lib/cmake/Qt5/Qt5Config.cmake:25 (include)  autotests/CMakeLists.txt:6 (find_package)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Error at autotests/CMakeLists.txt:7 (find_package):  By not providing "FindKF5CoreAddons.cmake" in CMAKE_MODULE_PATH this  project has asked CMake to find a package configuration file provided by  "KF5CoreAddons", but CMake did not find one.  Could not find a package configuration file provided by "KF5CoreAddons"  (requested version 5.42.0) with any of the following names:KF5CoreAddonsConfig.cmakekf5coreaddons-config.cmake  Add the installation prefix of "KF5CoreAddons" to CMAKE_PREFIX_PATH or set  "KF5CoreAddons_DIR" to a directory containing one of the above files.  If  "KF5CoreAddons" provides a separate development package or SDK, be sure it  has been installed.-- Configuring incomplete, errors occurred!See also "/usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/build/CMakeFiles/CMakeOutput.log".See also "/usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/build/CMakeFiles/CMakeError.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 24 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/24/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 10 Jan 2018 19:55:33 +
 Build duration:
57 sec and counting
   CONSOLE OUTPUT
  [...truncated 58.24 KB...]MORE  = '-sl'WORKSPACE = '/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.10'PWD   = '/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.10'HUDSON_URL= 'https://build.kde.org/'HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-3d1a353bc865'HOST  = '3d1a353bc865'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JENKINS_HOME  = '/home/production/data'JOB_NAME  = 'Frameworks breeze-icons kf5-qt5 SUSEQt5.10'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'NLSPATH   = '/usr/dt/lib/nls/msg/%L/%N.cat'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/display/redirect'NNTPSERVER= 'news'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/24/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/'BUILD_DISPLAY_NAME= '#24'XCURSOR_THEME = 'DMZ'PYTHONSTARTUP = '/etc/pythonstart'SHLVL = '2'BUILD_TAG = 'jenkins-Frameworks breeze-icons kf5-qt5 SUSEQt5.10-24'NODE_LABELS   = 'Docker Swarm-3d1a353bc865 SUSEQt5.10'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/etc/xdg'PATH  = '/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'PKG_CONFIG_PATH   = '/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.10"-- The C compiler identification is GNU 7.2.1-- The CXX compiler identification is GNU 7.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Error at autotests/CMakeLists.txt:7 (find_package):  By not providing "FindKF5CoreAddons.cmake" in CMAKE_MODULE_PATH this  project has asked CMake to find a package configuration file provided by  "KF5CoreAddons", but CMake did not find one.  Could not find a package configuration file provided by "KF5CoreAddons"  (requested version 5.42.0) with any of the following names:KF5CoreAddonsConfig.cmakekf5coreaddons-config.cmake  Add the installation prefix of "KF5CoreAddons" to CMAKE_PREFIX_PATH or set  "KF5CoreAddons_DIR" to a directory containing one of the above files.  If  "KF5CoreAddons" provides a separate development package or SDK, be sure it  has been installed.-- Configuring incomplete, errors occurred!See also "/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.10/build/CMakeFiles/CMakeOutput.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks breeze-icons kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment pr

D9802: Avoid Dolphin crash

[Andreas Krutzler]

akrutzler added inline comments.

INLINE COMMENTS

> michaelh wrote in kcoredirlister.cpp:1233
> I'm working with kio right now. Is better to just comment it out for the time 
> being?

Yes, i would just comment this out :) Once you are done, undo the comment.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9802

To: michaelh, #dolphin, #frameworks
Cc: akrutzler, ngraham, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, alexeymin, genaxxx, emmanuelp

D9802: Avoid Dolphin crash

[Michael Heidelbach]

michaelh abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9802

To: michaelh, #dolphin, #frameworks
Cc: akrutzler, ngraham, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, alexeymin, genaxxx, emmanuelp

KDE CI: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9 - Build # 38 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.9/38/
 Project:
Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Wed, 10 Jan 2018 19:55:33 +
 Build duration:
2 min 26 sec and counting
   CONSOLE OUTPUT
  [...truncated 59.37 KB...]PROGRAMW6432  = 'C:\Program Files'PROMPT= '$P$G'PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'PUBLIC= 'C:\Users\Public'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.9/38/display/redirect?page=changes'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.9/38/display/redirect'STAGE_NAME= 'Configuring Build'SYSTEMDRIVE   = 'C:'SYSTEMROOT= 'C:\WINDOWS'TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'UCRTVERSION   = '10.0.16299.0'UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'USERDOMAIN= 'DESKTOP-0LVFIKI'USERNAME  = 'Jenkins'USERPROFILE   = 'C:\Users\Jenkins'VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\IDE\VC\'VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\'VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.12.25827\'VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Redist\MSVC\14.12.25810\'VCTOOLSVERSION= '14.12.25827'VISUALSTUDIOVERSION   = '15.0'VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'VS150COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\Tools\'VSCMD_ARG_APP_PLAT= 'Desktop'VSCMD_ARG_HOST_ARCH   = 'x64'VSCMD_ARG_TGT_ARCH= 'x64'VSCMD_VER = '15.5.3'VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\'WINDIR= 'C:\WINDOWS'WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.16299.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.16299.0'WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'WINDOWSSDKLIBVERSION  = '10.0.16299.0\'WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.16299.0\'WINDOWSSDKVERSION = '10.0.16299.0\'WORKSPACE = 'C:\CI\workspace\Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9'__DOTNET_ADD_64BIT= '1'__DOTNET_PREFERRED_BITNESS = '64'__VSCMD_PREINIT_PATH  = 'C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files (x86)\Git\cmd;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'CMAKE_PREFIX_PATH = 'C:\CI\workspace\Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9\install-prefix;C:\CM\msvc2017x64d;C:\CM\msvc2017x64d\dev-utils'XDG_DATA_DIRS = 'C:\CI\workspace\Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9\install-prefix\share;C:\CM\msvc2017x64d\share;C:\CM\msvc2017x64d\dev-utils\share'PKG_CONFIG_PATH   = 'C:\CM\msvc2017x64d\lib\pkgconfig;C:\CM\msvc2017x64d\dev-utils\lib\pkgconfig'QMAKEFEATURES = 'C:\CM\msvc2017x64d\mkspecs/features'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:\CI\workspace\Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9/install-prefix/" -G "NMake Makefiles JOM"  "C:\CI\workspace\Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9"-- The C compiler identification is MSVC 19.12.25834.0-- The CXX compiler identification is MSVC 19.12.25834.0-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe-- Check for working CXX compiler: C:/Program Files (x86)/Micr

KDE CI: Frameworks breeze-icons kf5-qt5 AndroidQt5.9 - Build # 33 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/33/
 Project:
Frameworks breeze-icons kf5-qt5 AndroidQt5.9
 Date of build:
Wed, 10 Jan 2018 19:55:33 +
 Build duration:
3 min 8 sec and counting
   CONSOLE OUTPUT
  [...truncated 38.61 KB...]MAIL  = '/var/mail/user'ANDROID_NDK_TOOLCHAIN_VERSION = '4.9'USER  = 'user'HUDSON_URL= 'https://build.kde.org/'ANDROID_SDK_ROOT  = '/opt/android-sdk-linux'ANDROID_NDK_HOST  = 'linux-x86_64'XDG_DATA_DIRS = '/home/user/install-prefix/share:/opt/kdeandroid-deps/share'BUILD_URL = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/33/'JOB_NAME  = 'Frameworks breeze-icons kf5-qt5 AndroidQt5.9'BUILD_DISPLAY_NAME= '#33'SHELL = '/bin/sh'ANDROID_NDK_TOOLS_PREFIX  = 'arm-linux-androideabi'ANDROID_NDK_ROOT  = '/opt/android-ndk'QMAKESPEC = 'android-g++'LD_LIBRARY_PATH   = '/opt/Qt/5.9.1/android_armv7/lib:/opt/kdeandroid-deps/lib'ANDROID_NDK_TOOLCHAIN_PREFIX = 'arm-linux-androideabi'LOGNAME   = 'user'QT_PATH   = '/opt/Qt'HOME  = '/home/user'WORKSPACE = '/home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.9'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/display/redirect'PWD   = '/home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.9'EXECUTOR_NUMBER   = '0'ANDROID_NDK_PLATFORM  = 'android-21'DEBIAN_FRONTEND   = 'noninteractive'JENKINS_URL   = 'https://build.kde.org/'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/33/display/redirect?page=changes'BUILD_NUMBER  = '33'NODE_LABELS   = 'AndroidQt5.9 Docker Swarm-20c90d2d5e84'JENKINS_HOME  = '/home/production/data'OLDPWD= '/home/user'JOB_BASE_NAME = 'Frameworks breeze-icons kf5-qt5 AndroidQt5.9'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/33/display/redirect'ANDROID_NDK   = '/opt/android-ndk'BUILD_ID  = '33'ANDROID_HOME  = '/opt/android-sdk-linux'JENKINS_NODE_COOKIE   = '6432f77e-df88-4f37-9f79-932030b0cab1'NODE_NAME = 'Docker Swarm-20c90d2d5e84'QT_SELECT = 'qt5'CMAKE_PREFIX_PATH = '/home/user/install-prefix:/opt/Qt/5.9.1/android_armv7:/opt/kdeandroid-deps'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/user/install-prefix/" -DBUILD_COVERAGE=ON -DCMAKE_TOOLCHAIN_FILE="/opt/kdeandroid-deps/share/ECM/toolchain/Android.cmake" -DKF5_HOST_TOOLING=/opt/nativetooling/lib/x86_64-linux-gnu/cmake/ -DECM_ADDITIONAL_FIND_ROOT_PATH="/home/user/install-prefix;/opt/Qt/5.9.1/android_armv7;/opt/kdeandroid-deps"  "/home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.9"-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET=-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET=-- The C compiler identification is GNU 4.9.0-- The CXX compiler identification is GNU 4.9.0-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - FailedCMake Error at autotests/CMakeLists.txt:7 (find_package):  By not providing "FindKF5CoreAddons.cmake" in CMAKE_MODULE_PATH this  project has asked CMake to find a package configuration file provided by  "KF5CoreAddons", but CMake did not find one.  Could not find a package configuration file provided by "KF5CoreAddons"  (requested version 5.42.0) with any of the following names:KF5CoreAddonsConfig.cmakekf5coreaddons-config.cmake  Add the installation prefix of "KF5CoreAddons" to CMAKE_PREFIX_

D9802: Avoid Dolphin crash

[Michael Heidelbach]

michaelh marked 3 inline comments as done.
michaelh added inline comments.

INLINE COMMENTS

> akrutzler wrote in kcoredirlister.cpp:1233
> Yes, i would just comment this out :) Once you are done, undo the comment.

I'd like to ask for some help here.
Debugging in KDevelop, trying to step through the code:
it's not possible for me. Sometimes the debugger even crashed.

- I checked for debugging symbols with file libKF5*: OK
- I checked loading with lsof $(pgrep dolphin): OK

What do I miss?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9802

To: michaelh, #dolphin, #frameworks
Cc: akrutzler, ngraham, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, alexeymin, genaxxx, emmanuelp

D9802: Avoid Dolphin crash

[Michael Heidelbach]

michaelh marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9802

To: michaelh, #dolphin, #frameworks
Cc: akrutzler, ngraham, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, alexeymin, genaxxx, emmanuelp

Re: Problem in loading QM translations with LANGUAGE="" envar

[Wolfgang Bauer]

Am Wed, 10 Jan 2018 20:09:35 +0100, Albert Astals Cid  schrieb:


> Why not use ar_BH as LANGUAGE?
That probably won't help, see my previous reply here (that got delayed by 
moderation for some reason even though I am subscribed, so you may not have 
read it yet),
 or https://phabricator.kde.org/D9793

Kind Regards,
Wolfgang

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 46 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/46/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 10 Jan 2018 21:25:02 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiocore-threadtest

D9781: do not incorrectly split spaces in paths of duplicate results

[David Faure]

dfaure added a comment.


  I don't either ;)
  
  I'll fix this with a micro-handmade-state-machine, I like those.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D9781

To: sitter, dfaure, apol
Cc: cfeck, #frameworks

D9781: do not incorrectly split spaces in paths of duplicate results

[David Faure]

dfaure added a comment.


  https://phabricator.kde.org/D9807  (to be applied after reverting this commit)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D9781

To: sitter, dfaure, apol
Cc: cfeck, #frameworks

D9807: autotests: do not incorrectly split spaces in paths of duplicate results

[David Faure]

dfaure created this revision.
dfaure added reviewers: sitter, apol.
dfaure requested review of this revision.

REVISION SUMMARY
  Now using a hand-made loop to avoid the dependency on kcoreaddons
  introduced by the earlier commit.

TEST PLAN
  bin/dupes from a srcdir with a space, after duplicating one icon

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9807

AFFECTED FILES
  autotests/dupetest.cpp

To: dfaure, sitter, apol
Cc: cfeck, #frameworks

D9807: autotests: do not incorrectly split spaces in paths of duplicate results

[David Faure]

dfaure added a comment.


  Sample output:
  
* Start testing of DupeTest *
Config: Using QtTest library 5.9.2, Qt 5.9.2 (x86_64-little_endian-lp64 
shared (dynamic) debug build; by GCC 5.3.1 20160301 [gcc-5-branch revision 
233849])
PASS   : DupeTest::initTestCase()
FAIL!  : DupeTest::test_duplicates() 
  The following files are duplicates but not links:
- /d/kde/src/5/frameworks/breeze\ icons/icons/places/16/user-trash.svg
- /d/kde/src/5/frameworks/breeze\ icons/icons/places/16/david.svg

   Loc: [/d/kde/src/5/frameworks/breeze icons/autotests/testhelpers.h(42)]
PASS   : DupeTest::cleanupTestCase()
Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 392ms
* Finished testing of DupeTest *

REVISION DETAIL
  https://phabricator.kde.org/D9807

To: dfaure, sitter, apol
Cc: cfeck, #frameworks

D9802: Avoid Dolphin crash

[Andreas Krutzler]

akrutzler added inline comments.

INLINE COMMENTS

> michaelh wrote in kcoredirlister.cpp:1233
> I'd like to ask for some help here.
> Debugging in KDevelop, trying to step through the code:
> it's not possible for me. Sometimes the debugger even crashed.
> 
> - I checked for debugging symbols with file libKF5*: OK
> - I checked loading with lsof $(pgrep dolphin): OK
> 
> What do I miss?

Sorry i don't use KDevelop, i am using QtCreator and debugging works pretty 
good there. Maybe give QtCreator a try :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9802

To: michaelh, #dolphin, #frameworks
Cc: akrutzler, ngraham, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, alexeymin, genaxxx, emmanuelp

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 26 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/26/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
 Date of build:
Wed, 10 Jan 2018 23:05:57 +
 Build duration:
2 min 26 sec and counting
   CONSOLE OUTPUT
  [...truncated 58.17 KB...]MORE  = '-sl'WORKSPACE = '/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.7'PWD   = '/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.7'HUDSON_URL= 'https://build.kde.org/'HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-9908d5566a49'HOST  = '9908d5566a49'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JENKINS_HOME  = '/home/production/data'JOB_NAME  = 'Frameworks breeze-icons kf5-qt5 SUSEQt5.7'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'NLSPATH   = '/usr/dt/lib/nls/msg/%L/%N.cat'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/display/redirect'NNTPSERVER= 'news'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/26/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/'BUILD_DISPLAY_NAME= '#26'XCURSOR_THEME = 'DMZ'PYTHONSTARTUP = '/etc/pythonstart'SHLVL = '2'BUILD_TAG = 'jenkins-Frameworks breeze-icons kf5-qt5 SUSEQt5.7-26'NODE_LABELS   = 'Docker Swarm-9908d5566a49 SUSEQt5.7'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/etc/xdg'PATH  = '/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'PKG_CONFIG_PATH   = '/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.7"-- The C compiler identification is GNU 7.2.1-- The CXX compiler identification is GNU 7.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Error at autotests/CMakeLists.txt:7 (find_package):  By not providing "FindKF5CoreAddons.cmake" in CMAKE_MODULE_PATH this  project has asked CMake to find a package configuration file provided by  "KF5CoreAddons", but CMake did not find one.  Could not find a package configuration file provided by "KF5CoreAddons"  (requested version 5.42.0) with any of the following names:KF5CoreAddonsConfig.cmakekf5coreaddons-config.cmake  Add the installation prefix of "KF5CoreAddons" to CMAKE_PREFIX_PATH or set  "KF5CoreAddons_DIR" to a directory containing one of the above files.  If  "KF5CoreAddons" provides a separate development package or SDK, be sure it  has been installed.-- Configuring incomplete, errors occurred!See also "/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.7/build/CMakeFiles/CMakeOutput.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks breeze-icons kf5-qt5 SUSEQt5.7] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment productio

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 24 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/24/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 10 Jan 2018 23:05:57 +
 Build duration:
4 min 43 sec and counting
   CONSOLE OUTPUT
  [...truncated 43.10 KB...]TERM  = 'su'MAIL  = '/var/mail/jenkins'MM_CHARSET= 'UTF-8'BUILD_TAG = 'jenkins-Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9-24'BLOCKSIZE = 'K'JOB_NAME  = 'Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9'OLDPWD= '/usr/home/jenkins'BUILD_DISPLAY_NAME= '#24'JENKINS_NODE_COOKIE   = '21a7ad58-370b-4de5-8d98-76b34c498c20'BUILD_ID  = '24'PKG_CONFIG_PATH   = '/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'JAVA_HOME = '/usr/local/openjdk8-jre'HOME  = '/usr/home/jenkins'PWD   = '/usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9'BUILD_NUMBER  = '24'BUILD_URL = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/24/'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'SHLVL = '0'EXECUTOR_NUMBER   = '0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9"-- The C compiler identification is Clang 3.8.0-- The CXX compiler identification is Clang 3.8.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Warning (dev) at /usr/local/lib/cmake/Qt5/Qt5ModuleLocation.cmake:4 (set):  Policy CMP0053 is not set: Simplify variable reference and escape sequence  evaluation.  Run "cmake --help-policy CMP0053" for policy details.  Use the  cmake_policy command to set the policy and suppress this warning.  For input:'${_qt5_install_prefix}/Qt5@module@/Qt5@module@Config.cmake'  the old evaluation rules produce:'/usr/local/lib/cmake/Qt5/Qt5Config.cmake'  but the new evaluation rules produce:'/usr/local/lib/cmake/Qt5@module@/Qt5@module@Config.cmake'  Using the old result for compatibility since the policy is not set.Call Stack (most recent call first):  /usr/local/lib/cmake/Qt5/Qt5Config.cmake:25 (include)  autotests/CMakeLists.txt:6 (find_package)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Error at autotests/CMakeLists.txt:7 (find_package):  By not providing "FindKF5CoreAddons.cmake" in CMAKE_MODULE_PATH this  project has asked CMake to find a package configuration file provided by  "KF5CoreAddons", but CMake did not find one.  Could not find a package configuration file provided by "KF5CoreAddons"  (requested version 5.42.0) with any of the following names:KF5CoreAddonsConfig.cmakekf5coreaddons-config.cmake  Add the installation prefix of "KF5CoreAddons" to CMAKE_PREFIX_PATH or set  "KF5CoreAddons_DIR" to a directory containing one of the above files.  If  "KF5CoreAddons" provides a separate development package or SDK, be sure it  has been installed.-- Configuring incomplete, errors occurred!See also "/usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/build/CMakeFiles/CMakeOutput.log".See also "/usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/build/CMakeFiles/CMakeError.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks breeze-icons kf5-qt5 AndroidQt5.9 - Build # 34 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/34/
 Project:
Frameworks breeze-icons kf5-qt5 AndroidQt5.9
 Date of build:
Wed, 10 Jan 2018 23:05:57 +
 Build duration:
6 min 23 sec and counting
   CONSOLE OUTPUT
  [...truncated 38.63 KB...]ANDROID_NDK_TOOLS_PREFIX  = 'arm-linux-androideabi'STAGE_NAME= 'Configuring Build'HOME  = '/home/user'ANDROID_NDK_TOOLCHAIN_PREFIX = 'arm-linux-androideabi'PWD   = '/home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.9'QT_SELECT = 'qt5'SHLVL = '0'ANDROID_NDK_HOST  = 'linux-x86_64'NODE_LABELS   = 'AndroidQt5.9 Docker Swarm-2b7cbec8e2b1'ANDROID_NDK_PLATFORM  = 'android-21'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/34/display/redirect'ANDROID_NDK   = '/opt/android-ndk'ANDROID_HOME  = '/opt/android-sdk-linux'PKG_CONFIG_PATH   = '/opt/Qt/5.9.1/android_armv7/lib/pkgconfig'OLDPWD= '/home/user'CMAKE_PREFIX_PATH = '/home/user/install-prefix:/opt/Qt/5.9.1/android_armv7:/opt/kdeandroid-deps'USER  = 'user'WORKSPACE = '/home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.9'JOB_NAME  = 'Frameworks breeze-icons kf5-qt5 AndroidQt5.9'EXECUTOR_NUMBER   = '0'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/34/display/redirect?page=changes'BUILD_NUMBER  = '34'BUILD_ID  = '34'JOB_BASE_NAME = 'Frameworks breeze-icons kf5-qt5 AndroidQt5.9'NODE_NAME = 'Docker Swarm-2b7cbec8e2b1'SHELL = '/bin/sh'MAIL  = '/var/mail/user'QMAKEFEATURES = '/opt/Qt/5.9.1/android_armv7/mkspecs/features'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/display/redirect'ANDROID_NDK_ROOT  = '/opt/android-ndk'LD_LIBRARY_PATH   = '/opt/Qt/5.9.1/android_armv7/lib:/opt/kdeandroid-deps/lib'JENKINS_URL   = 'https://build.kde.org/'DEBIAN_FRONTEND   = 'noninteractive'ANDROID_NDK_TOOLCHAIN_VERSION = '4.9'JOB_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/'ANDROID_SDK_ROOT  = '/opt/android-sdk-linux'BUILD_DISPLAY_NAME= '#34'HOSTNAME  = '756b8e6d4d38'HUDSON_URL= 'https://build.kde.org/'BUILD_TAG = 'jenkins-Frameworks breeze-icons kf5-qt5 AndroidQt5.9-34'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/user/install-prefix/" -DBUILD_COVERAGE=ON -DCMAKE_TOOLCHAIN_FILE="/opt/kdeandroid-deps/share/ECM/toolchain/Android.cmake" -DKF5_HOST_TOOLING=/opt/nativetooling/lib/x86_64-linux-gnu/cmake/ -DECM_ADDITIONAL_FIND_ROOT_PATH="/home/user/install-prefix;/opt/Qt/5.9.1/android_armv7;/opt/kdeandroid-deps"  "/home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.9"-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET=-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET=-- The C compiler identification is GNU 4.9.0-- The CXX compiler identification is GNU 4.9.0-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - FailedCMake Error at autotests/CMakeLists.txt:7 (find_package):  By not providing "FindKF5CoreAddons.cmake" in CMAKE_MODULE_PATH this  project has asked CMake to find a package configuration file provided by  "KF5CoreAddons", but CMake did not find one.  Could not find a package configuration file provided by "KF5CoreAddons"  (requested version 5.42.0) with any of the following names:KF5CoreAddonsConfig.cmakekf5coreaddons-config.cmake  Add the installation prefix of "

KDE CI: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9 - Build # 39 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.9/39/
 Project:
Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Wed, 10 Jan 2018 23:05:57 +
 Build duration:
6 min 50 sec and counting
   CONSOLE OUTPUT
  [...truncated 59.36 KB...]PROGRAMW6432  = 'C:\Program Files'PROMPT= '$P$G'PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'PUBLIC= 'C:\Users\Public'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.9/39/display/redirect?page=changes'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.9/39/display/redirect'STAGE_NAME= 'Configuring Build'SYSTEMDRIVE   = 'C:'SYSTEMROOT= 'C:\WINDOWS'TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'UCRTVERSION   = '10.0.16299.0'UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'USERDOMAIN= 'DESKTOP-0LVFIKI'USERNAME  = 'Jenkins'USERPROFILE   = 'C:\Users\Jenkins'VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\IDE\VC\'VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\'VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.12.25827\'VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Redist\MSVC\14.12.25810\'VCTOOLSVERSION= '14.12.25827'VISUALSTUDIOVERSION   = '15.0'VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'VS150COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\Tools\'VSCMD_ARG_APP_PLAT= 'Desktop'VSCMD_ARG_HOST_ARCH   = 'x64'VSCMD_ARG_TGT_ARCH= 'x64'VSCMD_VER = '15.5.3'VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\'WINDIR= 'C:\WINDOWS'WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.16299.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.16299.0'WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'WINDOWSSDKLIBVERSION  = '10.0.16299.0\'WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.16299.0\'WINDOWSSDKVERSION = '10.0.16299.0\'WORKSPACE = 'C:\CI\workspace\Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9'__DOTNET_ADD_64BIT= '1'__DOTNET_PREFERRED_BITNESS = '64'__VSCMD_PREINIT_PATH  = 'C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files (x86)\Git\cmd;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'CMAKE_PREFIX_PATH = 'C:\CI\workspace\Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9\install-prefix;C:\CM\msvc2017x64d;C:\CM\msvc2017x64d\dev-utils'XDG_DATA_DIRS = 'C:\CI\workspace\Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9\install-prefix\share;C:\CM\msvc2017x64d\share;C:\CM\msvc2017x64d\dev-utils\share'PKG_CONFIG_PATH   = 'C:\CM\msvc2017x64d\lib\pkgconfig;C:\CM\msvc2017x64d\dev-utils\lib\pkgconfig'QMAKEFEATURES = 'C:\CM\msvc2017x64d\mkspecs/features'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:\CI\workspace\Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9/install-prefix/" -G "NMake Makefiles JOM"  "C:\CI\workspace\Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9"-- The C compiler identification is MSVC 19.12.25834.0-- The CXX compiler identification is MSVC 19.12.25834.0-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe-- Check for working CXX compiler: C:/Program Files (x86)/Micr

Re: KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 22 - Still Failing!

[Christoph Feck]

The stale symlinks have been fixed; thanks Andreas for the prompt fix.

The remaining issue is a recent regression that will be fixed with 
https://phabricator.kde.org/D9807


--
Christoph Feck

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 25 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/25/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 10 Jan 2018 23:05:57 +
 Build duration:
9 min 37 sec and counting
   CONSOLE OUTPUT
  [...truncated 58.33 KB...]MORE  = '-sl'WORKSPACE = '/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.10'PWD   = '/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.10'HUDSON_URL= 'https://build.kde.org/'HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-ccf0b442abd8'HOST  = 'ccf0b442abd8'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JENKINS_HOME  = '/home/production/data'JOB_NAME  = 'Frameworks breeze-icons kf5-qt5 SUSEQt5.10'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'NLSPATH   = '/usr/dt/lib/nls/msg/%L/%N.cat'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/display/redirect'NNTPSERVER= 'news'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/25/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/'BUILD_DISPLAY_NAME= '#25'XCURSOR_THEME = 'DMZ'PYTHONSTARTUP = '/etc/pythonstart'SHLVL = '2'BUILD_TAG = 'jenkins-Frameworks breeze-icons kf5-qt5 SUSEQt5.10-25'NODE_LABELS   = 'Docker Swarm-ccf0b442abd8 SUSEQt5.10'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/etc/xdg'PATH  = '/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'PKG_CONFIG_PATH   = '/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.10"-- The C compiler identification is GNU 7.2.1-- The CXX compiler identification is GNU 7.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Error at autotests/CMakeLists.txt:7 (find_package):  By not providing "FindKF5CoreAddons.cmake" in CMAKE_MODULE_PATH this  project has asked CMake to find a package configuration file provided by  "KF5CoreAddons", but CMake did not find one.  Could not find a package configuration file provided by "KF5CoreAddons"  (requested version 5.42.0) with any of the following names:KF5CoreAddonsConfig.cmakekf5coreaddons-config.cmake  Add the installation prefix of "KF5CoreAddons" to CMAKE_PREFIX_PATH or set  "KF5CoreAddons_DIR" to a directory containing one of the above files.  If  "KF5CoreAddons" provides a separate development package or SDK, be sure it  has been installed.-- Configuring incomplete, errors occurred!See also "/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.10/build/CMakeFiles/CMakeOutput.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks breeze-icons kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environm

[kde-build-metadata] /: Introduce temporary dependency on KCoreaddons for Breeze Icons.

[Ben Cooksley]

Git commit 08e9c4955681587c0391b21550a52525ce37739b by Ben Cooksley.
Committed on 10/01/2018 at 23:17.
Pushed by bcooksley into branch 'master'.

Introduce temporary dependency on KCoreaddons for Breeze Icons.
This should be reverted once D9807 has been merged in.
Please note that it is generally considered the responsibility of developers to 
amend and update the dependency metadata when changing the dependency chain 
within KDE projects.
This is particularly critical for Frameworks which have tier restrictions the 
CI enforces through usage of this metadata.

CCMAIL: sit...@kde.org
CCMAIL: fa...@kde.org
CCMAIL: kde-frameworks-devel@kde.org

M  +3-0dependency-data-kf5-qt5
M  +3-0dependency-data-stable-kf5-qt5

https://commits.kde.org/kde-build-metadata/08e9c4955681587c0391b21550a52525ce37739b

diff --git a/dependency-data-kf5-qt5 b/dependency-data-kf5-qt5
index e6a349f..7c6c187 100644
--- a/dependency-data-kf5-qt5
+++ b/dependency-data-kf5-qt5
@@ -18,6 +18,9 @@
 
 ### Frameworks ###
 
+# Temporary Issue
+frameworks/breeze-icons: frameworks/kcoreaddons
+
 # Frameworks, tier2
 frameworks/kauth: frameworks/kcoreaddons
 frameworks/kauth: kdesupport/polkit-qt-1
diff --git a/dependency-data-stable-kf5-qt5 b/dependency-data-stable-kf5-qt5
index ea91c4c..fec5ab5 100644
--- a/dependency-data-stable-kf5-qt5
+++ b/dependency-data-stable-kf5-qt5
@@ -16,6 +16,9 @@
 *: Qt5[stable]
 *: frameworks/extra-cmake-modules
 
+# Temporary Issue
+frameworks/breeze-icons: frameworks/kcoreaddons
+
 # Frameworks, tier2
 frameworks/kauth: frameworks/kcoreaddons
 frameworks/kauth: kdesupport/polkit-qt-1

Re: [kde-build-metadata] /: Introduce temporary dependency on KCoreaddons for Breeze Icons.

[David Faure]

On jeudi 11 janvier 2018 00:17:24 CET Ben Cooksley wrote:
> Git commit 08e9c4955681587c0391b21550a52525ce37739b by Ben Cooksley.
> Committed on 10/01/2018 at 23:17.
> Pushed by bcooksley into branch 'master'.
> 
> Introduce temporary dependency on KCoreaddons for Breeze Icons.
> This should be reverted once D9807 has been merged in.
> Please note that it is generally considered the responsibility of developers
> to amend and update the dependency metadata when changing the dependency
> chain within KDE projects. This is particularly critical for Frameworks
> which have tier restrictions the CI enforces through usage of this
> metadata.

Hmm, given the existence of D9807, the best "quick fix" would have been to 
revert 08ddec40 in breeze-icons, no?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 25 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/25/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 10 Jan 2018 23:18:58 +
 Build duration:
1 min 42 sec and counting
   CONSOLE OUTPUT
  [...truncated 7.96 MB...]-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/64/dialog-question.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/64/dialog-warning.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/64/security-high.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/64/security-low.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/64/security-medium.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/symbolic-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/symbolic/alarm-symbolic.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/symbolic/appointment-missed-symbolic.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/symbolic/appointment-soon-symbolic.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/symbolic/audio-volume-high-symbolic.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/symbolic/audio-volume-low-symbolic.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/symbolic/audio-volume-medium-symbolic.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/symbolic/audio-volume-muted-symbolic.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/symbolic/avatar-default-symbolic.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/symbolic/changes-allow-symbolic.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/symbolic/changes-prevent-symbolic.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/symbolic/channel-insecure-symbolic.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/symbolic/channel-secure-symbolic.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/symbolic/rating-unrated.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/symbolic/computer-fail-symbolic.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/symbolic/content-loading-symbolic.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/symbolic/dialog-error-symbolic.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/share/icons/breeze-dark/status/symbolic/dialog-warning-symbolic.svg-- Installing: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkin

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 26 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/26/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 10 Jan 2018 23:18:57 +
 Build duration:
3 min 37 sec and counting
   CONSOLE OUTPUT
  [...truncated 90.73 KB...][Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks breeze-icons kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target breeze-validate-svgScanning dependencies of target symlink_autogenScanning dependencies of target dupe_autogenScanning dependencies of target qrcAlias_autogenScanning dependencies of target newline_autogenScanning dependencies of target scalable_autogen[  4%] Automatic MOC for target symlink[  8%] Automatic MOC for target newline[ 12%] Automatic MOC for target qrcAlias[ 16%] Automatic MOC for target scalable[ 20%] Automatic MOC for target dupeGenerating MOC predefs moc_predefs.hGenerating MOC compilation mocs_compilation.cpp[ 20%] Built target qrcAlias_autogenScanning dependencies of target breeze-icons-mkdir[ 20%] Built target breeze-icons-mkdirScanning dependencies of target breeze-icons-dark-mkdir[ 20%] Built target breeze-icons-dark-mkdirScanning dependencies of target qrcAlias[ 25%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias.cpp.oGenerating MOC predefs moc_predefs.hGenerating MOC source include/scalabletest.mocGenerating MOC compilation mocs_compilation.cppGenerating MOC predefs moc_predefs.hGenerating MOC source include/newlinetest.mocGenerating MOC compilation mocs_compilation.cppGenerating MOC predefs moc_predefs.hGenerating MOC source include/symlinktest.mocGenerating MOC compilation mocs_compilation.cppGenerating MOC predefs moc_predefs.hGenerating MOC source include/dupetest.mocGenerating MOC compilation mocs_compilation.cpp[ 25%] Built target dupe_autogen[ 25%] Built target symlink_autogen[ 25%] Built target scalable_autogen[ 25%] Built target newline_autogen[ 29%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias_autogen/mocs_compilation.cpp.oScanning dependencies of target symlinkScanning dependencies of target scalableScanning dependencies of target dupe[ 33%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_autogen/mocs_compilation.cpp.o[ 37%] Building CXX object autotests/CMakeFiles/scalable.dir/scalabletest.cpp.o[ 41%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.o[ 45%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.o[ 50%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_autogen/mocs_compilation.cpp.o[ 54%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilation.cpp.o[ 54%] Built target breeze-validate-svgScanning dependencies of target newline[ 58%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.o[ 62%] Building CXX object autotests/CMakeFiles/newline.dir/newline_autogen/mocs_compilation.cpp.o[ 66%] Linking CXX executable bin/qrcAlias[ 66%] Built target qrcAliasScanning dependencies of target breeze-icons-rccScanning dependencies of target breeze-icons-dark-rcc[ 70%] Generating res/breeze-icons-dark.qrc[ 75%] Generating res/breeze-icons.qrc[ 79%] Linking CXX executable ../bin/dupe[ 83%] Linking CXX executable ../bin/symlink[ 87%] Linking CXX executable ../bin/newline[ 87%] Built target symlink[ 87%] Built target dupe[ 87%] Built target newline[ 91%] Linking CXX executable ../bin/scalable[ 91%] Built target scalable[ 95%] Generating breeze-icons-dark.rcc[100%] Generating breeze-icons.rcc[100%] Built target breeze-icons-dark-rcc[100%] Built target breeze-icons-rcc[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Running Tests)[Pipeline] sh[Frameworks breeze-icons kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/run-tests.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/Traceback (most recent call last):  File "ci-tooling/helpers/run-tests.py", line 95, in wmProcess = subprocess.Popen( commandToRun, stdout=subprocess.STDOUT, stderr=subprocess.STDOUT, shell=True, env=buildEnvironment )  File "/usr/lib64/python3.6/subprocess.py", line 709, in __init__restore_signals, start_new_session)  File "/usr/lib64/python3.6/subprocess.py", line 1344, in _execute_childraise child_exception_type(errno_num, err_msg, err_filename)OSError: [Errno 9] Bad file descriptor[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks breeze-icons kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

D7272: [DropJob] Enable drag and drop in a read-only folder

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7272

To: chinmoyr, #frameworks, dfaure
Cc: mreeves, ngraham

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 26 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/26/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 10 Jan 2018 23:23:53 +
 Build duration:
3 min 14 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.scalable

D9807: autotests: do not incorrectly split spaces in paths of duplicate results

[Harald Sitter]

sitter accepted this revision.
This revision is now accepted and ready to land.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9807

To: dfaure, sitter, apol
Cc: cfeck, #frameworks

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 27 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/27/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
 Date of build:
Wed, 10 Jan 2018 23:18:56 +
 Build duration:
9 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)83%
(5/6)83%
(5/6)36%
(105/288)19%
(43/232)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests80%
(4/5)80%
(4/5)27%
(63/231)14%
(28/204)

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 27 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/27/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 10 Jan 2018 23:24:56 +
 Build duration:
4 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)83%
(5/6)83%
(5/6)36%
(105/288)19%
(43/232)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests80%
(4/5)80%
(4/5)27%
(63/231)14%
(28/204)

KDE CI: Frameworks breeze-icons kf5-qt5 AndroidQt5.9 - Build # 35 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/35/
 Project:
Frameworks breeze-icons kf5-qt5 AndroidQt5.9
 Date of build:
Wed, 10 Jan 2018 23:18:58 +
 Build duration:
10 min and counting

D6832: Integrate new file ioslave in KIO job

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Please keep in mind that we should remove one of the two flags before the end 
of the month, after people tested this as much as possible ;)
  
  I admit that it sucks a bit that I don't know what the default should be...
  Conservatively, I think opt-in is better, since the worst case is an app that 
regularly does a failing copy in the background, and it would now prompt the 
user every time... well, maybe this doesn't happen anywhere though ;)
  
  Anyhow, let's first get this in. Thanks for your perseverance!

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6832

To: chinmoyr, dfaure, #frameworks
Cc: mreeves, #frameworks

D6830: Make use of kauth helper in copy method of file ioslave

[David Faure]

dfaure added a comment.


  Doesn't execWithElevatedPrivilege call ERR_USER_CANCELED on cancel?
  That was the idea, at least.
  
  I can't check, it's really hard to navigate code spread over many review 
requests, I can't wait for all of this to be pushed ;-)

REPOSITORY
  R241 KIO

BRANCH
  6830

REVISION DETAIL
  https://phabricator.kde.org/D6830

To: chinmoyr, dfaure, #frameworks
Cc: elvisangelaccio, #frameworks

D7270: [FileUndoManager] Enable undoing changes in read-only folders

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7270

To: chinmoyr, #frameworks, dfaure

D6833: Add support for PrivilegeExecution in KIO jobs

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6833

To: chinmoyr, dfaure, #frameworks
Cc: #frameworks

D9807: autotests: do not incorrectly split spaces in paths of duplicate results

[David Faure]

dfaure closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D9807

To: dfaure, sitter, apol
Cc: cfeck, #frameworks

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/27/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 10 Jan 2018 23:39:42 +
 Build duration:
1 min 26 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.scalable

KDE CI: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9 - Build # 40 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.9/40/
 Project:
Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Wed, 10 Jan 2018 23:18:55 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/28/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 10 Jan 2018 23:39:42 +
 Build duration:
6 min 13 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)83%
(5/6)83%
(5/6)35%
(105/303)18%
(43/242)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests80%
(4/5)80%
(4/5)26%
(63/246)13%
(28/214)

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/28/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
 Date of build:
Wed, 10 Jan 2018 23:39:42 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)83%
(5/6)83%
(5/6)35%
(105/303)18%
(43/242)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests80%
(4/5)80%
(4/5)26%
(63/246)13%
(28/214)

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/28/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 10 Jan 2018 23:56:27 +
 Build duration:
1 min 59 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.scalable

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 29 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/29/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 10 Jan 2018 23:59:05 +
 Build duration:
1 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/29/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
 Date of build:
Wed, 10 Jan 2018 23:56:27 +
 Build duration:
5 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)77%
(236/305)57%
(143/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)78%
(194/248)57%
(128/224)

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 30 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/30/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
 Date of build:
Thu, 11 Jan 2018 00:01:46 +
 Build duration:
5 min 40 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)77%
(236/305)56%
(141/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)78%
(194/248)56%
(126/224)

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 29 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/29/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 10 Jan 2018 23:56:27 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)77%
(236/305)56%
(141/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)78%
(194/248)56%
(126/224)

D9802: Avoid Dolphin crash

[Michael Heidelbach]

michaelh marked 2 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9802

To: michaelh, #dolphin, #frameworks
Cc: akrutzler, ngraham, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, alexeymin, genaxxx, emmanuelp

Re: Making Purpose part of KF5

[Aleix Pol]

On Thu, Nov 9, 2017 at 5:10 PM, Aleix Pol  wrote:
> Hi,
> I would like to include Purpose [1] into the frameworks umbrella.
> It's been around for a while now, used by few applications and
> reasonably stable.
>
> Any thoughts?
>
> Aleix
>
> [1] https://phabricator.kde.org/source/purpose/

So... can I play along?
Can we take the 3 months of silence as a yes?

Aleix

Re: Problem in loading QM translations with LANGUAGE="" envar

[Safa Alfulaij]

Systemsettings sets that, and there is no ar_BH language, but ar only.
That's the standard for Arabic translations.

On Jan 10, 2018 10:09 PM, "Albert Astals Cid"  wrote:

> El dimecres, 10 de gener de 2018, a les 5:49:54 CET, Safa Alfulaij va
> escriure:
> > Well, I don't want to remove it but it's a must. First it's not right
> > logically and second is that Qt prefers it over LANG, and use any locale
> > varient since it has no country name. (QLocale("ar") returns "Arabic
> > (Egypt)" (which is defind in unicode), instead of my "Arabic (Bahrain)"
> > locale.
> > And it's the only thing that is not getting translated which is
> obviously a
> > bug.
>
> Why not use ar_BH as LANGUAGE?
>
> this is the output of my locale
>
> $ locale
> LANG=ca_ES.UTF-8
> LANGUAGE=ca_ES
> LC_CTYPE="ca_ES.UTF-8"
> LC_NUMERIC="ca_ES.UTF-8"
> LC_TIME="ca_ES.UTF-8"
> LC_COLLATE="ca_ES.UTF-8"
> LC_MONETARY="ca_ES.UTF-8"
> LC_MESSAGES="ca_ES.UTF-8"
> LC_PAPER="ca_ES.UTF-8"
> LC_NAME="ca_ES.UTF-8"
> LC_ADDRESS="ca_ES.UTF-8"
> LC_TELEPHONE="ca_ES.UTF-8"
> LC_MEASUREMENT="ca_ES.UTF-8"
> LC_IDENTIFICATION="ca_ES.UTF-8"
> LC_ALL=
>
> Cheers,
>   Albert
>
>
> >
> > Regards
> >
> > On Jan 10, 2018 12:20 AM, "Albert Astals Cid"  wrote:
> > > El dimarts, 9 de gener de 2018, a les 20:08:02 CET, Safa Alfulaij va
> > >
> > > escriure:
> > > > Hello all.
> > > >
> > > > After doing some investigation about a problem, I came into an issue
> in
> > > > loading correct translations in Frameworks (that has the “_qt”
> suffix in
> > > > translation system).
> > > > Previously, I had my LANGUAGE enviroment variable containing “ar”,
> which
> > >
> > > is
> > >
> > > > because I added Arabic in my “Language” KCM (without knowing that I
> > > > don't
> > > > need it if the locale is alread set to Arabic).
> > > > This was normal and things was translated well. Today I removed that
> > > > “ar”
> > > > because it's not needed, and all applications (Qt, KDE, Gnome, other
> > >
> > > KF5s)
> > >
> > > > worked except for those frameworks which are using QM files (the ones
> > >
> > > with
> > >
> > > > “_qt” suffix). The translation isn't loaded and strings are shown in
> > > > English.
> > >
> > > So don't remove it?
> > >
> > > Cheers,
> > >
> > >   Albert
>
>
>