KDE CI: Frameworks kdeclarative kf5-qt5 SUSEQt5.7 - Build # 16 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20SUSEQt5.7/16/
 Project:
Frameworks kdeclarative kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 12 Jan 2018 08:04:20 +
 Build duration:
7 min 16 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(5/15)24%
(19/79)24%
(19/79)21%
(715/3395)15%
(322/2099)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)83%
(386/463)41%
(202/490)src.calendarevents0%
(0/2)0%
(0/2)0%
(0/62)0%
(0/2)src.kdeclarative75%
(3/4)75%
(3/4)50%
(151/302)37%
(58/156)src.kdeclarative.private100%
(5/5)100%
(5/5)43%
(25/58)15%
(4/26)src.kpackagelauncherqml0%
(0/1)0%
(0/1)0%
(0/62)0%
(0/18)src.qmlcontrols.draganddrop0%
(0/11)0%
(0/11)0%
(0/359)0%
(0/210)src.qmlcontrols.kcmcontrols0%
(0/2)0%
(0/2)0%
(0/5)0%
(0/2)src.qmlcontrols.kconfig0%
(0/3)0%
(0/3)0%
(0/12)0%
(0/2)src.qmlcontrols.kcoreaddons0%
(0/5)0%
(0/5)0%
(0/83)0%
(0/46)src.qmlcontrols.kioplugin0%
(0/4)0%
(0/4)0%
(0/22)0%
(0/18)src.qmlcontrols.kquickcontrols.private0%
(0/5)0%
(0/5)0%
(0/315)0%
(0/220)src.qmlcontrols.kquickcontrolsaddons11%
(2/18)11%
(2/18)5%
(66/1303)5%
(35/767)src.qmlcontrols.kwindowsystemplugin0%
(0/3)0%
(0/3)0%
(0/59)0%
(0/36)src.quickaddons29%
(2/7)29%
(2/7)33%
(87/263)22%
(23/104)tests0%
(0/2)0%
(0/2)0%
(0/27)0%
(0/2)

D9830: Fix KFilePreviewGenerator::LayoutBlocker

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Nice investigation and fix! Do you happen to know the actual change in Qt 
which broke this? Wondering if it should 1) be mentioned in the commit log, 2) 
lead to an #if QT_VERSION.
  But if it's just a supposition, then that's fine, don't spend a week tracking 
down the change in Qt :-)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9830

To: fvogt, #frameworks, dfaure

D9424: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D9424

To: habacker, dfaure, bcooksley, apol
Cc: kfunk, vonreth, #windows, apol, #frameworks

D9830: Fix KFilePreviewGenerator::LayoutBlocker

[Fabian Vogt]

fvogt added a comment.


  In https://phabricator.kde.org/D9830#189769, @dfaure wrote:
  
  > Nice investigation and fix! Do you happen to know the actual change in Qt 
which broke this? Wondering if it should 1) be mentioned in the commit log, 2) 
lead to an #if QT_VERSION.
  >  But if it's just a supposition, then that's fine, don't spend a week 
tracking down the change in Qt :-)
  
  
  I don't - there were some reports before Qt 5.10 (I never hit it myself 
though) already, so it's always been broken, just not this severe.
  The change in Qt 5.10 is probably that some operation used by the preview 
generator calls processEvents or an eventLoop now instead of doing a 
fully-blocking operation - behaviour which kio definitely can't rely on.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9830

To: fvogt, #frameworks, dfaure

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> kdirwatch.cpp:721
> QFile::encodeName(e->path).data(), mask)) 
> >= 0) {
> +m_inotify_wd_to_entry[e->wd] = e;
>  if (s_verboseDebug) {

.insert(e->wd, e) is a hair faster, says Effective STL Item 24 :)

> rjvbb wrote in kdirwatch_p.h:224
> How much overhead does this give per watched item?
> 
> I mean in bytes but I'm guessing there might be a break-even point, a number 
> of entries under which the look-up in the map is more expensive than the 
> current implementation. That could affect applications using KDW to monitor a 
> tiny number of files. If correct, what kind of overhead are we talking about?

Each hash node will be approx 4+8=12 bytes, and something must point to it, so 
another 8 bytes, 20 in total. No big deal.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9824

To: mwolff, dfaure, rjvbb, #kdevelop
Cc: #frameworks

D9830: Fix KFilePreviewGenerator::LayoutBlocker

[David Faure]

dfaure added a comment.


  I certainly hope QListView doesn't trigger a nested event loop, that would be 
horribly nasty and the cause for a million more problems (up to and 
including crashes when closing the view/window while this is happening). But 
I'm assuming this is just a supposition, and I'm strongly hoping it's unfounded 
;-)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9830

To: fvogt, #frameworks, dfaure

D9830: Fix KFilePreviewGenerator::LayoutBlocker

[Fabian Vogt]

fvogt added a comment.


  In https://phabricator.kde.org/D9830#189776, @dfaure wrote:
  
  > I certainly hope QListView doesn't trigger a nested event loop, that would 
be horribly nasty and the cause for a million more problems (up to and 
including crashes when closing the view/window while this is happening). But 
I'm assuming this is just a supposition, and I'm strongly hoping it's unfounded 
;-)
  
  
  Not QListView - the preview generator can do all kinds of stuff. There's also 
a slim change that something else does a full relayout - I didn't spot anything 
like that however.
  Normally I'd expect `QListView::setUniformItemSizes` to trigger a relayout on 
change though, so this fix is in any case correct.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9830

To: fvogt, #frameworks, dfaure

D9830: Fix KFilePreviewGenerator::LayoutBlocker

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:248941a0f4b4: Fix KFilePreviewGenerator::LayoutBlocker 
(authored by fvogt).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9830?vs=25186&id=25201

REVISION DETAIL
  https://phabricator.kde.org/D9830

AFFECTED FILES
  src/filewidgets/kfilepreviewgenerator.cpp

To: fvogt, #frameworks, dfaure

D9815: [KFileItem] Use "emblem-shared" for shared files

[Andreas Kainz]

andreask added a comment.


  add an real emblem-shared icon cause the existing one was a symbolic one for 
gnome. should work now so +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9815

To: broulik, #frameworks, dfaure, andreask
Cc: apol

D9424: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

[Ralf Habacker]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R268:205b69533bb5: Use cmake function 
'kdbusaddons_generate_dbus_service_file' from kdbusaddons to… 
(authored by habacker).

REPOSITORY
  R268 KGlobalAccel

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9424?vs=25187&id=25204

REVISION DETAIL
  https://phabricator.kde.org/D9424

AFFECTED FILES
  src/runtime/CMakeLists.txt
  src/runtime/org.kde.kglobalaccel.service.in

To: habacker, dfaure, bcooksley, apol
Cc: kfunk, vonreth, #windows, apol, #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 70 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/70/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 12 Jan 2018 08:55:16 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 57 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report66%
(23/35)67%
(290/434)67%
(290/434)53%
(31258/58880)38%
(18397/48035)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(71/71)100%
(71/71)95%
(8538/8964)50%
(5275/10525)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8238/14202)50%
(4841/9648)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3851/7797)33%
(1617/4880)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(2/2)100%
(2/2)53%
(434/819)44%
(324/736)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%
(714/1384)45%
(437/968)src.ioslaves.trash.tests67%
(2/3)67%
(2/3)88%
 

D9808: fix incorrect emission of signals by kLineEdit

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks for the fix. Looking at the reasoning in 
https://phabricator.kde.org/R284:737a983febf4b44b5447c26d86eaedc624a8c35f the 
added emit is definitely wrong, as the unittest proves. Please push.

INLINE COMMENTS

> klineedit_unittest.cpp:71
>  QCOMPARE(textChangedSpy[0][0].toString(), w.text());
> -QCOMPARE(textEditedSpy.count(), 1);
> +QCOMPARE(textEditedSpy.count(), 0);
>  QVERIFY(!w.isModified());

LOL the comment above says "setText emits textChanged and userTextChanged, but 
not textEdited", and the code didn't match that. Someone quickly adapted the 
tests after someone else added the emit, none of them really thought about 
this, sigh.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D9808

To: dweatherill, #frameworks, dhaumann, cullmann, dfaure
Cc: mwolff, dfaure, anthonyfieroni, iodelay, vbspam, njensen, geetamc, 
Pilzschaf, akshaydeo, surgenight, arrowdodger

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 68 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/68/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 12 Jan 2018 08:55:16 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 57 test(s)
   CONSOLE OUTPUT
  [...truncated 1.41 MB...]-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/firefox16oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/firefox20oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/firefox30oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/firefox36oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/firefox520oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/googlebot.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ie401onwinnt4.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ie50onppc.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ie55onwinnt5.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ie60oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ie60onwinnt51.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ie70onwinnt51.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ie80onwinnt60.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ie90onwinnt71.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/lynxoncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/nn301oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/nn475oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/nn475onwin95.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ns71oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/ns71onwinnt51.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/op1162oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/op1202oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/op403onwinnt4.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/op85oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/op90oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/useragentstrings/op962oncurrent.desktop-- Installing: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/share/kservices5/us

D9823: Optimize: use QMetaObject::invokeMethod with functor

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kdirwatch.cpp:1405
> +#else
> +QMetaObject::invokeMethod(c.instance, [c, path]() { 
> c.instance->setDeleted(path); }, Qt::QueuedConnection)
> +#endif

Does this compile? The compiler in my eyes says: missing trailing semicolon.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9823

To: mwolff, dfaure, apol, mpyne
Cc: mpyne, #frameworks

D9829: Don't create 2 msgbox (one of them crashes) when can't change rights

[Jaime Torres Amate]

jtamate added a comment.


  In https://phabricator.kde.org/D9829#189580, @anthonyfieroni wrote:
  
  > What is job->error() ?
  
  
  job->error()= 115  job->errorText= "/d/borrar/file.img" (the text is the 
target file path)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9829

To: jtamate, #frameworks, anthonyfieroni, dfaure
Cc: ngraham

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

[Jaime Torres Amate]

jtamate created this revision.
jtamate added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  kservice uses kdirwatch to be notified when one of the directories containing 
it's source of information changes.
  But also the method TimestampChecker().checkTimestamps(allResourceDirs) is 
called once every 1500 miliseconds.
  When copying files from any directory to another one, this check introduces a 
big use of io/wait.

TEST PLAN
  Before, when copying 20Gb files, the cpu spent in io/wait, as seen by 
ksysguard, was around 80%.
  After, when copying 20Gb files, the cpu spent in io/wait, as seen by 
ksysguard, is around 50%

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D9840

AFFECTED FILES
  src/sycoca/ksycoca.cpp

To: jtamate, #frameworks

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

[Marijo Mustac]

mmustac added a comment.


  Does this patch then also affects the speed of the copy operation?

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D9840

To: jtamate, #frameworks
Cc: mmustac

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

[Jaime Torres Amate]

jtamate added a comment.


  In https://phabricator.kde.org/D9840#189862, @mmustac wrote:
  
  > Does this patch then also affects the speed of the copy operation?
  
  
  Not that I've noticed. Only the cpu in io/wait.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D9840

To: jtamate, #frameworks
Cc: mmustac

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

[René J . V . Bertin]

rjvbb added a comment.


  > Each hash node will be approx 4+8=12 bytes, and something must point to it, 
so another 8 bytes, 20 in total. No big deal.
  
  I didn't think it'd be a big deal, not under normal circumstances. Still,with 
applications like KDevelop that currently add every single item in their 
project trees we're potentially dealing with thousands of files (around 7500 
for GCC IIRC, much more for QtWebEngine). Then every byte starts to count esp. 
if file-change monitoring isn't the only feature that requires gobs of RAM.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9824

To: mwolff, dfaure, rjvbb, #kdevelop
Cc: #frameworks

D6709: Add support for sharing file descriptor between KIO slave and KAuth helper

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 25215.
chinmoyr edited the summary of this revision.
chinmoyr added a comment.


  Summary update

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6709?vs=24577&id=25215

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6709

AFFECTED FILES
  src/ioslaves/file/CMakeLists.txt
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/kauth/fdsender.h
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, thiago, #frameworks, dfaure
Cc: dfaure, davidedmundson, elvisangelaccio, shortstheory

D6709: Add support for sharing file descriptor between KIO slave and KAuth helper

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:bbf45d2cd550: Add support for sharing file descriptor 
between file KIO slave and it's KAuth… (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6709?vs=25215&id=25216

REVISION DETAIL
  https://phabricator.kde.org/D6709

AFFECTED FILES
  src/ioslaves/file/CMakeLists.txt
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/kauth/fdsender.h
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, thiago, #frameworks, dfaure
Cc: dfaure, davidedmundson, elvisangelaccio, shortstheory

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 69 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/69/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 12 Jan 2018 10:28:07 +
 Build duration:
6 min 3 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 57 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report66%
(23/35)67%
(291/436)67%
(291/436)53%
(31249/58925)38%
(18401/48137)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(71/71)100%
(71/71)95%
(8538/8964)50%
(5273/10525)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8218/14201)50%
(4835/9652)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3851/7797)33%
(1617/4880)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file75%
(3/4)75%
(3/4)50%
(435/866)43%
(326/762)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%
(724/1384)46%
(449/968)src.ioslaves.trash.tests67%
(2/3)67%
(2/3)88%

D6197: Add kauth helper to file ioslave

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:17bf6df0d8ba: Add kauth helper to file ioslave (authored 
by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6197?vs=20608&id=25217

REVISION DETAIL
  https://phabricator.kde.org/D6197

AFFECTED FILES
  src/ioslaves/file/CMakeLists.txt
  src/ioslaves/file/file_p.h
  src/ioslaves/file/kauth/CMakeLists.txt
  src/ioslaves/file/kauth/file.actions
  src/ioslaves/file/kauth/filehelper.cpp
  src/ioslaves/file/kauth/filehelper.h

To: chinmoyr, elvisangelaccio, #frameworks, dfaure

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 49 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/49/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 12 Jan 2018 10:28:07 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 50 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/50/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 12 Jan 2018 10:56:07 +
 Build duration:
2 min 27 sec and counting
   CONSOLE OUTPUT
  [...truncated 414.95 KB...]Scanning dependencies of target kio_ghelp[ 29%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_help.cpp.o/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/kauth/filehelper.cpp:135:20: error: use of undeclared identifier 'errno'reply.setError(errno ? errno : -1);   ^/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/kauth/filehelper.cpp:135:28: error: use of undeclared identifier 'errno'reply.setError(errno ? errno : -1);   ^2 errors generated.gmake[2]: *** [src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/build.make:63: src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/filehelper.cpp.o] Error 1gmake[1]: *** [CMakeFiles/Makefile2:1702: src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobs[ 29%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/fdreceiver.cpp.oGenerating MOC source include/http.mocGenerating MOC source include/moc_httpfilter.cppGenerating MOC source EWIEGA46WW/moc_httpobjecttest.cppGenerating MOC source Z6OQ364BWP/moc_http.cppGenerating MOC compilation mocs_compilation.cpp[ 29%] Built target httpobjecttest_autogen[ 29%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/kio_file_autogen/mocs_compilation.cpp.o[ 29%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/main_ghelp.cpp.oIn file included from /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/fdreceiver.cpp:26:/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/sharefd_p.h:46:33: warning: braces around scalar initializer [-Wbraced-scalar-init]sockaddr_un a{ AF_UNIX, {0}};^~~/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/sharefd_p.h:46:36: warning: missing field 'sun_path' initializer [-Wmissing-field-initializers]sockaddr_un a{ AF_UNIX, {0}};   ^[ 29%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/xslt_help.cpp.o2 warnings generated.[ 29%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_ghelp_autogen/mocs_compilation.cpp.o[ 29%] Linking CXX shared module ../../../bin/kf5/kio/file.so[ 29%] Built target kio_file[ 29%] Linking CXX shared module ../../../bin/kf5/kio/ghelp.so[ 29%] Built target kio_ghelpGenerating MOC source include/delegateanimationhandler.mocGenerating MOC source include/moc_delegateanimationhandler_p.cppGenerating MOC source include/moc_dropjob.cppGenerating MOC source include/fileundomanager.mocGenerating MOC source include/moc_fileundomanager.cppGenerating MOC source include/moc_fileundomanager_p.cppGenerating MOC source include/jobuidelegate.mocGenerating MOC source include/moc_joburlcache_p.cppGenerating MOC source include/moc_kacleditwidget.cppGenerating MOC source include/moc_kacleditwidget_p.cppGenerating MOC source include/moc_kautomount.cppGenerating MOC source include/moc_kbuildsycocaprogressdialog.cppGenerating MOC source include/moc_kdirlister.cppGenerating MOC source include/moc_kdirmodel.cppGenerating MOC source include/moc_kdynamicjobtracker_p.cppGenerating MOC source include/moc_kfile.cppGenerating MOC source include/moc_kopenwithdialog.cppGenerating MOC source include/moc_kopenwithdialog_p.cppGenerating MOC source include/moc_kpropertiesdialog.cppGenerating MOC source include/moc_kpropertiesdialog_p.cppGenerating MOC source include/krun.mocGenerating MOC source include/moc_krun.cppGenerating MOC source include/moc_krun_p.cppGenerating MOC source include/moc_kurlcombobox.cppGenerating MOC source include/kurlcompletion.mocGenerating MOC source include/moc_kurlcompletion.cppGenerating MOC source include/kurlrequester.mocGenerating MOC source include/moc_kurlrequester.cppGenerating MOC source include/moc_kurlrequesterdialog.cppGenerating MOC source include/moc_pastejob.cppGenerating MOC source include/moc_previewjob.cppGenerating MOC source EWIEGA46WW/moc_accessmanager.cppGenerating MOC source EWIEGA46WW/moc_accessmanagerreply_p.cppGenerating MOC source EWIEGA46WW/moc_clipboardupdater_p.cppGenerating MOC source EWIEGA46WW/moc_dndpopupmenuplugin.cppGenerating MOC source EWIEGA46WW/moc_executablefileopendialog_p.cppGenerating MOC source EWIEGA46WW/moc_jobuidelegate.cppGenerating MOC source EWIEGA46WW/moc_kabstractfileitemactionplugin.cppGenerating MOC source EWIEGA46WW/moc_kfileitemactions.cppGenerating MOC source EWIEGA46WW/moc_kfileitemactions_p.cppGenerating MOC source EWIEGA46WW/moc_kfileitemdelegate.cppGenerating MOC source EWIEGA46WW/moc_koverlayiconplugin.c

D6829: Add ability to use the new kauth helper in file ioslave

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:eebc78918817: Use kauth helper in file ioslave (authored 
by chinmoyr).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6829?vs=24578&id=25218#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6829?vs=24578&id=25218

REVISION DETAIL
  https://phabricator.kde.org/D6829

AFFECTED FILES
  src/core/global.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface.h
  src/ioslaves/file/file.h
  src/ioslaves/file/file_p.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp

To: chinmoyr, dfaure, #frameworks
Cc: #frameworks

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 51 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/51/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 12 Jan 2018 10:59:59 +
 Build duration:
3 min 20 sec and counting
   CONSOLE OUTPUT
  [...truncated 421.59 KB...]gmake[2]: *** Waiting for unfinished jobs[ 29%] Building CXX object src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/fdsender.cpp.o[ 29%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/kio_file_autogen/mocs_compilation.cpp.oIn file included from /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/kauth/fdsender.cpp:24:/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/kauth/../sharefd_p.h:46:33: warning: braces around scalar initializer [-Wbraced-scalar-init]sockaddr_un a{ AF_UNIX, {0}};^~~/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/kauth/../sharefd_p.h:46:36: warning: missing field 'sun_path' initializer [-Wmissing-field-initializers]sockaddr_un a{ AF_UNIX, {0}};   ^2 warnings generated.In file included from /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/fdreceiver.cpp:26:/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/sharefd_p.h:46:33: warning: braces around scalar initializer [-Wbraced-scalar-init]sockaddr_un a{ AF_UNIX, {0}};^~~/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/file/sharefd_p.h:46:36: warning: missing field 'sun_path' initializer [-Wmissing-field-initializers]sockaddr_un a{ AF_UNIX, {0}};   ^2 warnings generated.[ 29%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/xslt_help.cpp.ogmake[1]: *** [CMakeFiles/Makefile2:1702: src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobs[ 29%] Built target httpobjecttest_autogen[ 29%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_ghelp_autogen/mocs_compilation.cpp.oScanning dependencies of target kio_help[ 29%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/xslt_help.cpp.o[ 29%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/main.cpp.o[ 29%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/kio_help.cpp.o[ 29%] Linking CXX shared module ../../../bin/kf5/kio/file.so[ 29%] Built target kio_file[ 29%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/kio_help_autogen/mocs_compilation.cpp.o[ 29%] Linking CXX shared module ../../../bin/kf5/kio/ghelp.so[ 29%] Built target kio_ghelp[ 29%] Linking CXX shared module ../../../bin/kf5/kio/help.so[ 29%] Built target kio_helpGenerating MOC source include/delegateanimationhandler.mocGenerating MOC source include/moc_delegateanimationhandler_p.cppGenerating MOC source include/moc_dropjob.cppGenerating MOC source include/fileundomanager.mocGenerating MOC source include/moc_fileundomanager.cppGenerating MOC source include/moc_fileundomanager_p.cppGenerating MOC source include/jobuidelegate.mocGenerating MOC source include/moc_joburlcache_p.cppGenerating MOC source include/moc_kacleditwidget.cppGenerating MOC source include/moc_kacleditwidget_p.cppGenerating MOC source include/moc_kautomount.cppGenerating MOC source include/moc_kbuildsycocaprogressdialog.cppGenerating MOC source include/moc_kdirlister.cppGenerating MOC source include/moc_kdirmodel.cppGenerating MOC source include/moc_kdynamicjobtracker_p.cppGenerating MOC source include/moc_kfile.cppGenerating MOC source include/moc_kopenwithdialog.cppGenerating MOC source include/moc_kopenwithdialog_p.cppGenerating MOC source include/moc_kpropertiesdialog.cppGenerating MOC source include/moc_kpropertiesdialog_p.cppGenerating MOC source include/krun.mocGenerating MOC source include/moc_krun.cppGenerating MOC source include/moc_krun_p.cppGenerating MOC source include/moc_kurlcombobox.cppGenerating MOC source include/kurlcompletion.mocGenerating MOC source include/moc_kurlcompletion.cppGenerating MOC source include/kurlrequester.mocGenerating MOC source include/moc_kurlrequester.cppGenerating MOC source include/moc_kurlrequesterdialog.cppGenerating MOC source include/moc_pastejob.cppGenerating MOC source include/moc_previewjob.cppGenerating MOC source EWIEGA46WW/moc_accessmanager.cppGenerating MOC source EWIEGA46WW/moc_accessmanagerreply_p.cppGenerating MOC source EWIEGA46WW/moc_clipboardupdater_p.cppGenerating MOC source EWIEGA46WW/moc_dndpopupmenuplugin.cppGenerating MOC source EWIEGA46WW/moc_executablefileopendialog_p.cppGenerating MOC source EWIEGA46WW/moc_jobuidelegate.cppGenerating MOC source EWIEGA46WW/moc_kabstractfileitemactionplugin.cppGenerating MOC source EWIEGA46WW/moc_kfileitemactions.cppGenerating MOC source EWIEGA46WW/moc_kfil

D6831: Make use of kauth helper in methods of file ioslave

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 25219.
chinmoyr edited the summary of this revision.
chinmoyr added a comment.


  1.Merge code from https://phabricator.kde.org/D6830
  2.Fix FreeBSD (CI) build

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6831?vs=24585&id=25219

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6831

AFFECTED FILES
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp
  src/ioslaves/file/kauth/filehelper.cpp

To: chinmoyr, dfaure, #frameworks
Cc: dhaumann, #frameworks

D6831: Make use of kauth helper in methods of file ioslave

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:13ab6a85bbb8: Use kauth helper in member functions of 
FileProtocol (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6831?vs=25219&id=25220

REVISION DETAIL
  https://phabricator.kde.org/D6831

AFFECTED FILES
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp
  src/ioslaves/file/kauth/filehelper.cpp

To: chinmoyr, dfaure, #frameworks
Cc: dhaumann, #frameworks

D6830: Make use of kauth helper in copy method of file ioslave

[Chinmoy Ranjan Pradhan]

chinmoyr closed this revision.
chinmoyr added a comment.


  commit: 
https://phabricator.kde.org/R241:13ab6a85bbb8502fe47935f92f466e0223baa2ac

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6830

To: chinmoyr, dfaure, #frameworks
Cc: elvisangelaccio, #frameworks

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 52 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/52/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 12 Jan 2018 11:19:01 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiofilewidgets-kfilecopytomenutest

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 130 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/130/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Fri, 12 Jan 2018 11:28:35 +
 Build duration:
4 min 5 sec and counting
   CONSOLE OUTPUT
  [...truncated 400.54 KB...][ 20%] Automatic MOC for target jobtestGenerating MOC source EWIEGA46WW/moc_jobtest.cppGenerating MOC compilation mocs_compilation.cpp[ 20%] Built target jobtest_autogenScanning dependencies of target kprotocolinfotest_autogen[ 20%] Automatic MOC for target kprotocolinfotestGenerating MOC source include/kprotocolinfotest.mocGenerating MOC compilation mocs_compilation.cpp[ 20%] Built target kprotocolinfotest_autogenScanning dependencies of target ktcpsockettest_autogen[ 21%] Automatic MOC for target ktcpsockettestGenerating MOC source EWIEGA46WW/moc_ktcpsockettest.cppGenerating MOC compilation mocs_compilation.cpp[ 21%] Built target ktcpsockettest_autogenScanning dependencies of target mkpathjobtest_autogen[ 21%] Automatic MOC for target mkpathjobtestGenerating MOC source include/mkpathjobtest.mocGenerating MOC compilation mocs_compilation.cpp[ 21%] Built target mkpathjobtest_autogenScanning dependencies of target threadtest_autogen[ 22%] Automatic MOC for target threadtestGenerating MOC source include/threadtest.mocGenerating MOC compilation mocs_compilation.cpp[ 22%] Built target threadtest_autogenScanning dependencies of target udsentrytest_autogen[ 22%] Automatic MOC for target udsentrytestGenerating MOC source EWIEGA46WW/moc_udsentrytest.cppGenerating MOC compilation mocs_compilation.cpp[ 22%] Built target udsentrytest_autogenScanning dependencies of target deletejobtest_autogen[ 22%] Automatic MOC for target deletejobtestGenerating MOC source EWIEGA46WW/moc_deletejobtest.cppGenerating MOC compilation mocs_compilation.cpp[ 22%] Built target deletejobtest_autogenScanning dependencies of target urlutiltest_autogen[ 23%] Automatic MOC for target urlutiltestGenerating MOC source include/urlutiltest.mocGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target urlutiltest_autogenScanning dependencies of target batchrenamejobtest_autogen[ 23%] Automatic MOC for target batchrenamejobtestGenerating MOC source include/batchrenamejobtest.mocGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target batchrenamejobtest_autogenScanning dependencies of target http_jobtest_autogen[ 23%] Automatic MOC for target http_jobtestGenerating MOC source include/http_jobtest.mocGenerating MOC source EWIEGA46WW/moc_httpserver_p.cppGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target http_jobtest_autogenScanning dependencies of target kcookiejartest_autogen[ 23%] Automatic MOC for target kcookiejartestGenerating MOC source include/kcookiejartest.mocGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target kcookiejartest_autogenScanning dependencies of target kio_http_autogen[ 23%] Automatic MOC for target kio_httpGenerating MOC source include/http.mocGenerating MOC source include/moc_httpfilter.cppGenerating MOC source EWIEGA46WW/moc_http.cppGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target kio_http_autogenScanning dependencies of target httpauthenticationtest_autogen[ 24%] Automatic MOC for target httpauthenticationtestGenerating MOC source EWIEGA46WW/moc_httpauthenticationtest.cppGenerating MOC compilation mocs_compilation.cpp[ 24%] Built target httpauthenticationtest_autogenScanning dependencies of target httpobjecttest_autogen[ 24%] Automatic MOC for target httpobjecttestGenerating MOC source include/http.mocGenerating MOC source include/moc_httpfilter.cppGenerating MOC source EWIEGA46WW/moc_httpobjecttest.cppGenerating MOC source Z6OQ364BWP/moc_http.cppGenerating MOC compilation mocs_compilation.cpp[ 24%] Built target httpobjecttest_autogenScanning dependencies of target kio_file[ 24%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file.cpp.obj[ 24%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/kio_file_autogen/mocs_compilation.cpp.obj[ 24%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file_win.cpp.objfile.cppC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\src\ioslaves\file\file.cpp(677): error C3861: 'getuid': identifier not foundC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\src\ioslaves\file\file.cpp(677): error C3861: 'getgid': identifier not foundTODO: st_uid and st_gid are always zero, use GetSecurityInfo to find the ownerjom: C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\build\src\ioslaves\file\CMakeFiles\kio_file.dir\build.make [src\ioslaves\file\CMakeFiles\kio_file.dir\file.cpp.obj] Error 2file_win.cppmocs_compilation.cppjom: C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\build\CMakeFiles\Makefile2 [src\ioslaves\file\CMakeFiles\kio_file.dir\all] Error 2jom: C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\build\Makefile [all] Error 2[Pipeline] }[P

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 72 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/72/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 12 Jan 2018 11:19:06 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfilecopytomenutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(293/440)67%
(293/440)53%
(31346/59170)38%
(18487/48419)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(71/71)100%
(71/71)95%
(8538/8964)50%
(5290/10525)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8247/14209)50%
(4850/9653)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3851/7797)33%
(1617/4880)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)50%
(503/999)39%
(380/968)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%
 

D6832: Integrate new file ioslave in KIO job

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 25222.
chinmoyr edited the summary of this revision.
chinmoyr added a comment.


  Summary update
  Fixed windows build

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6832?vs=24598&id=25222

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6832

AFFECTED FILES
  src/core/job.cpp
  src/core/job_base.h
  src/core/job_p.h
  src/core/simplejob.cpp
  src/core/simplejob.h
  src/ioslaves/file/file.cpp

To: chinmoyr, dfaure, #frameworks
Cc: mreeves, #frameworks

D6832: Integrate new file ioslave in KIO job

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:596ef4ccf1d7: Integrate new file ioslave in KIO job 
(authored by chinmoyr).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6832?vs=25222&id=25223#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6832?vs=25222&id=25223

REVISION DETAIL
  https://phabricator.kde.org/D6832

AFFECTED FILES
  src/core/job.cpp
  src/core/job_base.h
  src/core/job_p.h
  src/core/simplejob.cpp
  src/core/simplejob.h
  src/ioslaves/file/file.cpp

To: chinmoyr, dfaure, #frameworks
Cc: mreeves, #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 73 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/73/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 12 Jan 2018 11:19:22 +
 Build duration:
46 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfilecopytomenutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(293/440)67%
(293/440)53%
(31357/59172)38%
(18489/48343)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(71/71)100%
(71/71)95%
(8538/8964)50%
(5289/10525)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8261/14210)50%
(4847/9649)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3852/7797)33%
(1618/4880)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)50%
(504/999)39%
(381/968)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%

D6833: Add support for privilege execution in KIO jobs

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 25224.
chinmoyr retitled this revision from "Add support for PrivilegeExecution in KIO 
jobs" to "Add support for privilege execution in KIO jobs".
chinmoyr edited the summary of this revision.
chinmoyr added a comment.


  Title and summary update

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6833?vs=24599&id=25224

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6833

AFFECTED FILES
  src/core/batchrenamejob.cpp
  src/core/chmodjob.cpp
  src/core/copyjob.cpp
  src/core/deletejob.cpp
  src/core/filecopyjob.cpp
  src/core/job_p.h
  src/core/mkpathjob.cpp
  src/core/simplejob.cpp
  src/core/storedtransferjob.cpp

To: chinmoyr, dfaure, #frameworks
Cc: #frameworks

D6833: Add support for privilege execution in KIO jobs

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:7ccf3cda121f: Add support for privilege execution in KIO 
jobs (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6833?vs=25224&id=25225

REVISION DETAIL
  https://phabricator.kde.org/D6833

AFFECTED FILES
  src/core/batchrenamejob.cpp
  src/core/chmodjob.cpp
  src/core/copyjob.cpp
  src/core/deletejob.cpp
  src/core/filecopyjob.cpp
  src/core/job_p.h
  src/core/mkpathjob.cpp
  src/core/simplejob.cpp
  src/core/storedtransferjob.cpp

To: chinmoyr, dfaure, #frameworks
Cc: #frameworks

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 131 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/131/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Fri, 12 Jan 2018 12:00:56 +
 Build duration:
8 min 31 sec and counting
   CONSOLE OUTPUT
  [...truncated 403.52 KB...]Scanning dependencies of target kprotocolinfotest_autogen[ 20%] Automatic MOC for target kprotocolinfotestGenerating MOC source include/kprotocolinfotest.mocGenerating MOC compilation mocs_compilation.cpp[ 20%] Built target kprotocolinfotest_autogenScanning dependencies of target ktcpsockettest_autogen[ 21%] Automatic MOC for target ktcpsockettestGenerating MOC source EWIEGA46WW/moc_ktcpsockettest.cppGenerating MOC compilation mocs_compilation.cpp[ 21%] Built target ktcpsockettest_autogenScanning dependencies of target mkpathjobtest_autogen[ 21%] Automatic MOC for target mkpathjobtestGenerating MOC source include/mkpathjobtest.mocGenerating MOC compilation mocs_compilation.cpp[ 21%] Built target mkpathjobtest_autogenScanning dependencies of target threadtest_autogen[ 22%] Automatic MOC for target threadtestGenerating MOC source include/threadtest.mocGenerating MOC compilation mocs_compilation.cpp[ 22%] Built target threadtest_autogenScanning dependencies of target udsentrytest_autogen[ 22%] Automatic MOC for target udsentrytestGenerating MOC source EWIEGA46WW/moc_udsentrytest.cppGenerating MOC compilation mocs_compilation.cpp[ 22%] Built target udsentrytest_autogenScanning dependencies of target deletejobtest_autogen[ 22%] Automatic MOC for target deletejobtestGenerating MOC source EWIEGA46WW/moc_deletejobtest.cppGenerating MOC compilation mocs_compilation.cpp[ 22%] Built target deletejobtest_autogenScanning dependencies of target urlutiltest_autogen[ 23%] Automatic MOC for target urlutiltestGenerating MOC source include/urlutiltest.mocGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target urlutiltest_autogenScanning dependencies of target batchrenamejobtest_autogen[ 23%] Automatic MOC for target batchrenamejobtestGenerating MOC source include/batchrenamejobtest.mocGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target batchrenamejobtest_autogenScanning dependencies of target http_jobtest_autogen[ 23%] Automatic MOC for target http_jobtestGenerating MOC source include/http_jobtest.mocGenerating MOC source EWIEGA46WW/moc_httpserver_p.cppGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target http_jobtest_autogenScanning dependencies of target kcookiejartest_autogen[ 23%] Automatic MOC for target kcookiejartestGenerating MOC source include/kcookiejartest.mocGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target kcookiejartest_autogenScanning dependencies of target kio_http_autogen[ 23%] Automatic MOC for target kio_httpGenerating MOC source include/http.mocGenerating MOC source include/moc_httpfilter.cppGenerating MOC source EWIEGA46WW/moc_http.cppGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target kio_http_autogenScanning dependencies of target httpauthenticationtest_autogen[ 24%] Automatic MOC for target httpauthenticationtestGenerating MOC source EWIEGA46WW/moc_httpauthenticationtest.cppGenerating MOC compilation mocs_compilation.cpp[ 24%] Built target httpauthenticationtest_autogenScanning dependencies of target httpobjecttest_autogen[ 24%] Automatic MOC for target httpobjecttestGenerating MOC source include/http.mocGenerating MOC source include/moc_httpfilter.cppGenerating MOC source EWIEGA46WW/moc_httpobjecttest.cppGenerating MOC source Z6OQ364BWP/moc_http.cppGenerating MOC compilation mocs_compilation.cpp[ 24%] Built target httpobjecttest_autogenScanning dependencies of target kio_file[ 24%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file_win.cpp.obj[ 24%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file.cpp.obj[ 24%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/kio_file_autogen/mocs_compilation.cpp.objfile.cppTODO: st_uid and st_gid are always zero, use GetSecurityInfo to find the ownerfile_win.cppmocs_compilation.cpp[ 25%] Linking CXX shared module ..\..\..\bin\kf5\kio\file.dll   Creating library ..\..\..\lib\file.lib and object ..\..\..\lib\file.expjom: C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\build\src\ioslaves\file\CMakeFiles\kio_file.dir\build.make [bin\kf5\kio\file.dll] Error 2file.cpp.obj : error LNK2019: unresolved external symbol "private: class PrivilegeOperationReturnValue __cdecl FileProtocol::tryOpen(class QFile &,class QByteArray const &,int,int)" (?tryOpen@FileProtocol@@AEAA?AVPrivilegeOperationReturnValue@@AEAVQFile@@AEBVQByteArray@@HH@Z) referenced in function "public: virtual void __cdecl FileProtocol::get(class QUrl const &)" (?get@FileProtocol@@UEAAXAEBVQUrl@@@Z)file.cpp.obj : error LNK2019: unresolved external symbol "private: class PrivilegeOperationReturnValue __cdecl FileProtocol::tryChangeFileAttr(enum ActionType,class QVar

Re: New KDE application

[Sayan Biswas]

Adding other lists.

On 10-Jan-2018 11:49 PM, "Sayan Biswas"  wrote:

> Hi,
>
> A very happy new year to all. Hope you guys are doing good. :)
>
> Me and Rahul (CC'ed; IRC nick - rahulch) came up with an idea for a
> new application in KDE, and we were hoping to get an opinion on it.
>
> The central idea behind the app will be to manage the expenses of a
> group of users. As a user, you can create one or more groups, add
> members to them, and add entries for expenses for a given group. You
> can also check the outstanding balances and choose to settle-up with one
> or more members. There will be options for fine-tuning a given entry -
> decide who all have born the total expenditure and by what
> proportions, how should the total expense be divided among the members
> (equally/specific amounts/etc), add pictures for receipts, add
> comments, and so on and so forth.
>
> We are planning to start off with desktop application with a decentralised
> approach, i.e. the users will hold the data of the shared expenses. Now
> again,
> there is a possibility of tampering with the expenditure so we might need
> to
> set a centralised archived or something similar data set to maintain the
> integrity and persistence of a transaction. We are open to opinions and
> discussions for this also. Further to that we will be building mobile
> application for the users ease of usage and add expenditure on the go.
> After
> all, mobiles are more widely used by user than desktop application.
>
>
> For settling up we were thinking of integrating some standard payment
> gateways (PayPal, etc) but I am not sure of how much of this
> integration is possible in KDE. Until then we can just maintain a
> transaction record indicating that members A and B have settled up. We
> were also considering developing a cryptocurrency (we could call it
> KCoin or something) that would serve as a means of payment. Opinions
> are welcome in this particular segment as possibilities can be immense.
>
> As for maintaining the ledgers, we wanted to implement it using
> blockchain, but again, I am not sure if it can be done in KDE, or if
> we have some libraries that support blockchain implementation, etc.
>
> An application like this comes in handy when a group of people need to
> manage their regular expenses, and we thought it might be a good idea
> to have something similar in KDE. The target audience for this will be
> college groups, work groups, school groups, etc whoever is entitled to
> shared expenditure. We would love to get your feedback, mainly on the
> feasibility of the features mentioned above.
>
>
> Regards,
> Sayan
>

D7430: Add unit tests for privilege excution in KIO

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ac51e5769c84: Add unit tests for privilege excution in 
KIO (authored by chinmoyr).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D7430?vs=24603&id=25226#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7430?vs=24603&id=25226

REVISION DETAIL
  https://phabricator.kde.org/D7430

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/privilegejobtest.cpp
  autotests/privilegejobtest.h
  src/ioslaves/file/file_win.cpp

To: chinmoyr, dfaure
Cc: ngraham, #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 73 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/73/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 12 Jan 2018 12:00:56 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfilecopytomenutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(293/440)67%
(293/440)53%
(31416/59306)38%
(18492/48478)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(71/71)100%
(71/71)95%
(8538/8964)50%
(5278/10525)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8312/14344)50%
(4862/9712)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3851/7797)33%
(1617/4880)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)50%
(503/1000)39%
(379/968)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 132 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/132/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Fri, 12 Jan 2018 12:10:39 +
 Build duration:
9 min 42 sec and counting
   CONSOLE OUTPUT
  [...truncated 403.04 KB...]Scanning dependencies of target kprotocolinfotest_autogen[ 20%] Automatic MOC for target kprotocolinfotestGenerating MOC source include/kprotocolinfotest.mocGenerating MOC compilation mocs_compilation.cpp[ 20%] Built target kprotocolinfotest_autogenScanning dependencies of target ktcpsockettest_autogen[ 21%] Automatic MOC for target ktcpsockettestGenerating MOC source EWIEGA46WW/moc_ktcpsockettest.cppGenerating MOC compilation mocs_compilation.cpp[ 21%] Built target ktcpsockettest_autogenScanning dependencies of target mkpathjobtest_autogen[ 21%] Automatic MOC for target mkpathjobtestGenerating MOC source include/mkpathjobtest.mocGenerating MOC compilation mocs_compilation.cpp[ 21%] Built target mkpathjobtest_autogenScanning dependencies of target threadtest_autogen[ 22%] Automatic MOC for target threadtestGenerating MOC source include/threadtest.mocGenerating MOC compilation mocs_compilation.cpp[ 22%] Built target threadtest_autogenScanning dependencies of target udsentrytest_autogen[ 22%] Automatic MOC for target udsentrytestGenerating MOC source EWIEGA46WW/moc_udsentrytest.cppGenerating MOC compilation mocs_compilation.cpp[ 22%] Built target udsentrytest_autogenScanning dependencies of target deletejobtest_autogen[ 22%] Automatic MOC for target deletejobtestGenerating MOC source EWIEGA46WW/moc_deletejobtest.cppGenerating MOC compilation mocs_compilation.cpp[ 22%] Built target deletejobtest_autogenScanning dependencies of target urlutiltest_autogen[ 23%] Automatic MOC for target urlutiltestGenerating MOC source include/urlutiltest.mocGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target urlutiltest_autogenScanning dependencies of target batchrenamejobtest_autogen[ 23%] Automatic MOC for target batchrenamejobtestGenerating MOC source include/batchrenamejobtest.mocGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target batchrenamejobtest_autogenScanning dependencies of target http_jobtest_autogen[ 23%] Automatic MOC for target http_jobtestGenerating MOC source include/http_jobtest.mocGenerating MOC source EWIEGA46WW/moc_httpserver_p.cppGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target http_jobtest_autogenScanning dependencies of target kcookiejartest_autogen[ 23%] Automatic MOC for target kcookiejartestGenerating MOC source include/kcookiejartest.mocGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target kcookiejartest_autogenScanning dependencies of target kio_http_autogen[ 23%] Automatic MOC for target kio_httpGenerating MOC source include/http.mocGenerating MOC source include/moc_httpfilter.cppGenerating MOC source EWIEGA46WW/moc_http.cppGenerating MOC compilation mocs_compilation.cpp[ 23%] Built target kio_http_autogenScanning dependencies of target httpauthenticationtest_autogen[ 24%] Automatic MOC for target httpauthenticationtestGenerating MOC source EWIEGA46WW/moc_httpauthenticationtest.cppGenerating MOC compilation mocs_compilation.cpp[ 24%] Built target httpauthenticationtest_autogenScanning dependencies of target httpobjecttest_autogen[ 24%] Automatic MOC for target httpobjecttestGenerating MOC source include/http.mocGenerating MOC source include/moc_httpfilter.cppGenerating MOC source EWIEGA46WW/moc_httpobjecttest.cppGenerating MOC source Z6OQ364BWP/moc_http.cppGenerating MOC compilation mocs_compilation.cpp[ 24%] Built target httpobjecttest_autogenScanning dependencies of target kio_file[ 24%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file_win.cpp.obj[ 24%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file.cpp.obj[ 24%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/kio_file_autogen/mocs_compilation.cpp.objfile.cppTODO: st_uid and st_gid are always zero, use GetSecurityInfo to find the ownermocs_compilation.cppfile_win.cpp[ 25%] Linking CXX shared module ..\..\..\bin\kf5\kio\file.dll   Creating library ..\..\..\lib\file.lib and object ..\..\..\lib\file.expfile.cpp.obj : error LNK2019: unresolved external symbol "private: class PrivilegeOperationReturnValue __cdecl FileProtocol::tryOpen(class QFile &,class QByteArray const &,int,int)" (?tryOpen@FileProtocol@@AEAA?AVPrivilegeOperationReturnValue@@AEAVQFile@@AEBVQByteArray@@HH@Z) referenced in function "public: virtual void __cdecl FileProtocol::get(class QUrl const &)" (?get@FileProtocol@@UEAAXAEBVQUrl@@@Z)file.cpp.obj : error LNK2019: unresolved external symbol "private: class PrivilegeOperationReturnValue __cdecl FileProtocol::tryChangeFileAttr(enum ActionType,class QVariant const &,class QVariant const &,class QVariant const &)" (?tryChangeFileAttr@FileProtocol@@AEAA?AVPrivilegeOperationReturnValue@@W4ActionType@@AEB

D7270: [FileUndoManager] Enable undoing changes in read-only folders

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 25227.
chinmoyr edited the summary of this revision.
chinmoyr added a comment.


  Summary update

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7270?vs=24600&id=25227

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7270

AFFECTED FILES
  src/widgets/fileundomanager.cpp

To: chinmoyr, #frameworks, dfaure

D7270: [FileUndoManager] Enable undoing changes in read-only folders

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ac9f30b4a334: [FileUndoManager] Enable undoing changes in 
read-only folders (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7270?vs=25227&id=25228

REVISION DETAIL
  https://phabricator.kde.org/D7270

AFFECTED FILES
  src/widgets/fileundomanager.cpp

To: chinmoyr, #frameworks, dfaure

D9815: [KFileItem] Use "emblem-shared" for shared files

[Kai Uwe Broulik]

broulik added a comment.


  F5641972: Screenshot_20180112_132818.png 

  Andreas added an "emblem-shared" icon

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9815

To: broulik, #frameworks, dfaure, andreask
Cc: apol

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 53 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/53/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 12 Jan 2018 12:00:56 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiocore-threadtestFailed: TestSuite.kiofilewidgets-kfilecopytomenutest

D7272: [DropJob] Enable drag and drop in a read-only folder

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:774b303c9680: [DropJob] Enable drag and drop in a 
read-only folder (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7272?vs=24601&id=25229

REVISION DETAIL
  https://phabricator.kde.org/D7272

AFFECTED FILES
  src/widgets/dropjob.cpp

To: chinmoyr, #frameworks, dfaure
Cc: mreeves, ngraham

D9815: [KFileItem] Use "emblem-shared" for shared files

[Andreas Kainz]

andreaska accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9815

To: broulik, #frameworks, dfaure, andreask, andreaska
Cc: apol

[kio] src/ioslaves/file/kauth: Do not cache root password for the whole session

[Luca Beltrame]

Git commit 029da62886e0571dfbe54cc4433af8ae8ac3433d by Luca Beltrame.
Committed on 12/01/2018 at 12:41.
Pushed by lbeltrame into branch 'master'.

Do not cache root password for the whole session

With something as KIO, this is *really* bad as further actions will
*not* get any password prompt for any action in file.actions.

CCMAIL: chinmoyr...@gmail.com
CCMAIL: kde-frameworks-devel@kde.org

M  +1-1src/ioslaves/file/kauth/file.actions

https://commits.kde.org/kio/029da62886e0571dfbe54cc4433af8ae8ac3433d

diff --git a/src/ioslaves/file/kauth/file.actions 
b/src/ioslaves/file/kauth/file.actions
index a1a5c117..33fa47c9 100644
--- a/src/ioslaves/file/kauth/file.actions
+++ b/src/ioslaves/file/kauth/file.actions
@@ -2,4 +2,4 @@
 Name=Execute action as root.
 Description=Root privileges are required to complete the action.
 Policy=auth_admin
-Persistence=session
+Persistence=

D9815: [KFileItem] Use "emblem-shared" for shared files

[Aleix Pol Gonzalez]

apol accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9815

To: broulik, #frameworks, dfaure, andreask, andreaska, apol
Cc: apol

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 54 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/54/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 12 Jan 2018 12:31:16 +
 Build duration:
15 min and counting
   CONSOLE OUTPUT
  [...truncated 177.17 KB...]Scanning dependencies of target protocoltojson_autogenqdbusxml2cpp: Got unknown type `(ysa{s(siv)})' processing '/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/core/org.kde.KPasswdServer.xml'You should add  to the XML descriptionqdbusxml2cpp: Got unknown type `(ysa{s(siv)})' processing '/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/core/org.kde.KPasswdServer.xml'You should add  to the XML description[  2%] Generating moc_predefs.h[  2%] Automatic MOC for target protocoltojsonScanning dependencies of target KF5KIONTLM_autogen[  3%] Generating klauncher_interface.cpp, klauncher_interface.hGenerating MOC compilation mocs_compilation.cppScanning dependencies of target org.kde.kio.file.policy-customtarget[  3%] Automatic MOC for target KF5KIOCore[  3%] Generating org.kde.kio.file.policy[  3%] Automatic MOC for target KF5KIONTLM[  3%] Built target protocoltojson_autogenWrong persistence: gmake[2]: *** [src/ioslaves/file/kauth/CMakeFiles/org.kde.kio.file.policy-customtarget.dir/build.make:62: src/ioslaves/file/kauth/org.kde.kio.file.policy] Error 1gmake[2]: *** Deleting file 'src/ioslaves/file/kauth/org.kde.kio.file.policy'gmake[1]: *** [CMakeFiles/Makefile2:1739: src/ioslaves/file/kauth/CMakeFiles/org.kde.kio.file.policy-customtarget.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobsGenerating MOC compilation mocs_compilation.cppScanning dependencies of target kded_kcookiejar_autogen[  3%] Built target KF5KIONTLM_autogen[  3%] Generating org.kde.KCookieServer.xml[  3%] Generating kcookieserveradaptor.cpp, kcookieserveradaptor.h[  3%] Automatic MOC for target kded_kcookiejarAutoMoc: Warning: "/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/http/kcookiejar/kcookieserver.cpp"The file includes the moc file "kcookieserver.moc", but does not contain a Q_OBJECT or Q_GADGET macro.[  3%] Built target docs-kcontrol5-useragent-index-cache-bz2[  3%] Built target docs-kcontrol5-webshortcuts-index-cache-bz2Generating MOC source include/kcookieserver.mocGenerating MOC source EWIEGA46WW/moc_kcookieserver.cppGenerating MOC source EWIEGA46WW/moc_kcookiewin.cppGenerating MOC compilation mocs_compilation.cpp[  3%] Built target kded_kcookiejar_autogenGenerating MOC source include/moc_batchrenamejob.cppGenerating MOC source include/moc_chmodjob.cppGenerating MOC source include/moc_connection_p.cppGenerating MOC source include/moc_copyjob.cppGenerating MOC source include/moc_deletejob.cppGenerating MOC source include/moc_directorysizejob.cppGenerating MOC source include/moc_emptytrashjob.cppGenerating MOC source include/moc_filecopyjob.cppGenerating MOC source include/moc_filejob.cppGenerating MOC source include/moc_filesystemfreespacejob.cppGenerating MOC source include/moc_forwardingslavebase.cppGenerating MOC source include/hostinfo.mocGenerating MOC source include/moc_job_base.cppGenerating MOC source include/moc_job_p.cppGenerating MOC source include/moc_kcoredirlister.cppGenerating MOC source include/moc_kcoredirlister_p.cppGenerating MOC source include/moc_klocalsocket.cppGenerating MOC source include/moc_knfsshare.cppGenerating MOC source include/moc_kpasswdserverloop_p.cppGenerating MOC source include/kprotocolmanager.mocGenerating MOC source include/moc_ksambashare.cppGenerating MOC source include/moc_kssld_interface.cppGenerating MOC source include/moc_ktcpsocket.cppGenerating MOC source include/moc_listjob.cppGenerating MOC source include/moc_mimetypejob.cppGenerating MOC source include/moc_mkdirjob.cppGenerating MOC source include/moc_mkpathjob.cppGenerating MOC source include/moc_multigetjob.cppGenerating MOC source include/moc_restorejob.cppGenerating MOC source include/moc_scheduler.cppGenerating MOC source include/moc_scheduler_p.cppGenerating MOC source include/moc_simplejob.cppGenerating MOC source include/moc_slaveinterface.cppGenerating MOC source include/moc_specialjob.cppGenerating MOC source include/moc_statjob.cppGenerating MOC source include/storedtransferjob.mocGenerating MOC source include/moc_storedtransferjob.cppGenerating MOC source include/moc_transferjob.cppGenerating MOC source EWIEGA46WW/moc_connectionbackend_p.cppGenerating MOC source EWIEGA46WW/moc_connectionserver.cppGenerating MOC source EWIEGA46WW/moc_dataprotocol_p.cppGenerating MOC source EWIEGA46WW/moc_dataslave_p.cppGenerating MOC source EWIEGA46WW/moc_davjob.cppGenerating MOC source EWIEGA46WW/moc_faviconscache_p.cppGenerating MOC source EWIEGA46WW/moc_idleslave.cppGenerating MOC source EWIEGA46WW/moc_kdirnotify.cppGenerating MOC source EWIEGA46WW/moc_sessiondata_p.cppGenerating MOC source EWIEGA46WW/moc_slave.cppGenerating MO

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 74 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/74/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 12 Jan 2018 12:19:27 +
 Build duration:
29 min and counting
   CONSOLE OUTPUT
  [...truncated 197.97 KB...][  3%] Built target docs-kcontrol5-smb-index-cache-bz2[  3%] Built target docs-kcontrol5-proxy-index-cache-bz2[  3%] Built target docs-kcontrol5-netpref-index-cache-bz2Scanning dependencies of target KF5KIOCore_autogenScanning dependencies of target protocoltojson_autogenScanning dependencies of target KF5KIONTLM_autogen[  3%] Built target docs-kcontrol5-trash-index-cache-bz2[  4%] Generating kpasswdserver_interface.cpp, kpasswdserver_interface.h[  4%] Automatic MOC for target protocoltojson[  5%] Automatic MOC for target KF5KIONTLMScanning dependencies of target org.kde.kio.file.policy-customtarget[  5%] Built target docs-kcontrol5-useragent-index-cache-bz2Generating MOC compilation mocs_compilation.cppGenerating MOC compilation mocs_compilation.cpp[  5%] Generating klauncher_interface.cpp, klauncher_interface.h[  5%] Built target protocoltojson_autogen[  5%] Generating org.kde.kio.file.policyWrong persistence: make[2]: *** [src/ioslaves/file/kauth/CMakeFiles/org.kde.kio.file.policy-customtarget.dir/build.make:62: src/ioslaves/file/kauth/org.kde.kio.file.policy] Error 1make[2]: *** Deleting file 'src/ioslaves/file/kauth/org.kde.kio.file.policy'make[1]: *** [CMakeFiles/Makefile2:1701: src/ioslaves/file/kauth/CMakeFiles/org.kde.kio.file.policy-customtarget.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[  5%] Built target KF5KIONTLM_autogenScanning dependencies of target kcookiejar5_autogen[  5%] Generating org.kde.KCookieServer.xmlGot unknown type `(ysa{s(siv)})'You should add  to the XML descriptionGot unknown type `(ysa{s(siv)})'You should add  to the XML description[  6%] Generating kcookieserverinterface.cpp, kcookieserverinterface.h[  6%] Automatic MOC for target KF5KIOCore[  6%] Automatic MOC for target kcookiejar5Generating MOC compilation mocs_compilation.cpp[  6%] Built target kcookiejar5_autogenNote: namesp. add : added namespace before processing  Web Shortcuts[  6%] Built target docs-kcontrol5-webshortcuts-index-cache-bz2Generating MOC source include/moc_batchrenamejob.cppGenerating MOC source include/moc_chmodjob.cppGenerating MOC source include/moc_connection_p.cppGenerating MOC source include/moc_copyjob.cppGenerating MOC source include/moc_deletejob.cppGenerating MOC source include/moc_directorysizejob.cppGenerating MOC source include/moc_emptytrashjob.cppGenerating MOC source include/moc_filecopyjob.cppGenerating MOC source include/moc_filejob.cppGenerating MOC source include/moc_filesystemfreespacejob.cppGenerating MOC source include/moc_forwardingslavebase.cppGenerating MOC source include/hostinfo.mocGenerating MOC source include/moc_job_base.cppGenerating MOC source include/moc_job_p.cppGenerating MOC source include/moc_kcoredirlister.cppGenerating MOC source include/moc_kcoredirlister_p.cppGenerating MOC source include/moc_klocalsocket.cppGenerating MOC source include/moc_knfsshare.cppGenerating MOC source include/moc_kpasswdserverloop_p.cppGenerating MOC source include/kprotocolmanager.mocGenerating MOC source include/moc_ksambashare.cppGenerating MOC source include/moc_kssld_interface.cppGenerating MOC source include/moc_ktcpsocket.cppGenerating MOC source include/moc_listjob.cppGenerating MOC source include/moc_mimetypejob.cppGenerating MOC source include/moc_mkdirjob.cppGenerating MOC source include/moc_mkpathjob.cppGenerating MOC source include/moc_multigetjob.cppGenerating MOC source include/moc_restorejob.cppGenerating MOC source include/moc_scheduler.cppGenerating MOC source include/moc_scheduler_p.cppGenerating MOC source include/moc_simplejob.cppGenerating MOC source include/moc_slaveinterface.cppGenerating MOC source include/moc_specialjob.cppGenerating MOC source include/moc_statjob.cppGenerating MOC source include/storedtransferjob.mocGenerating MOC source include/moc_storedtransferjob.cppGenerating MOC source include/moc_transferjob.cppGenerating MOC source EWIEGA46WW/moc_connectionbackend_p.cppGenerating MOC source EWIEGA46WW/moc_connectionserver.cppGenerating MOC source EWIEGA46WW/moc_dataprotocol_p.cppGenerating MOC source EWIEGA46WW/moc_dataslave_p.cppGenerating MOC source EWIEGA46WW/moc_davjob.cppGenerating MOC source EWIEGA46WW/moc_faviconscache_p.cppGenerating MOC source EWIEGA46WW/moc_idleslave.cppGenerating MOC source EWIEGA46WW/moc_kdirnotify.cppGenerating MOC source EWIEGA46WW/moc_sessiondata_p.cppGenerating MOC source EWIEGA46WW/moc_slave.cppGenerating MOC source EWIEGA46WW/moc_slaveconfig.cppGenerating MOC source EWIEGA46WW/moc_usernotificationhandler_p.cppGenerating MOC compilation mocs_compilation.cpp[  6%] Built target KF5KIOCore_autogenmake: *** [Makefile:141: all] Error 2[Pipeline] }[Pipeline] // stage[

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 74 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/74/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 12 Jan 2018 12:05:31 +
 Build duration:
49 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfilecopytomenutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31539/59381)38%
(18561/48480)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8611/9037)50%
(5318/10603)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8361/14345)50%
(4875/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3851/7797)33%
(1617/4880)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(514/1000)41%
(399/968)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52

D9815: [KFileItem] Use "emblem-shared" for shared files

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:5aa5de9a7a07: [KFileItem] Use "emblem-shared" 
for shared files (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9815?vs=25149&id=25232

REVISION DETAIL
  https://phabricator.kde.org/D9815

AFFECTED FILES
  src/core/kfileitem.cpp

To: broulik, #frameworks, dfaure, andreask, andreaska, apol
Cc: apol

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 133 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/133/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Fri, 12 Jan 2018 12:20:54 +
 Build duration:
43 min and counting

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 55 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/55/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 12 Jan 2018 12:47:44 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiowidgets-dropjobtest

Re: [kio] src/ioslaves/file/kauth: Do not cache root password for the whole session

[Luca Beltrame]

In data venerdì 12 gennaio 2018 14:00:17 CET, hai scritto:

(putting kde-frameworks-devel in CC, this is important)

> shown depending on the persistence value.  Totally removing the persistence
> will lead  to two prompts, one from job and another one from kauth.

I'm not doing so unless the underlying issue with Persistence=session, which 
caches the root password for the whole session, is fixed.

It was pointed out in D6198 that there's no such thing as persistence in 
polkit, however as David mentioned, we don't want the authorization to last 
the whole session.

Double prompts are bad UX, but better than a program potentially making abuse 
of a persistent file action as root.

-- 
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 75 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/75/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 12 Jan 2018 12:49:07 +
 Build duration:
32 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiowidgets-dropjobtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31474/59400)38%
(18506/48568)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8564/9037)50%
(5270/10603)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8358/14345)50%
(4880/9712)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3851/7797)33%
(1617/4880)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(509/1000)41%
(395/968)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1376/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
  

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 75 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/75/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 12 Jan 2018 12:54:53 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiowidgets-dropjobtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31467/59401)38%
(18498/48492)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8564/9037)50%
(5275/10603)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8346/14345)50%
(4870/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3851/7797)33%
(1617/4880)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(509/1000)41%
(395/968)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 56 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/56/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 12 Jan 2018 13:09:11 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-threadtestFailed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiowidgets-dropjobtest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 76 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/76/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 12 Jan 2018 13:21:51 +
 Build duration:
9 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiowidgets-dropjobtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31472/59400)38%
(18500/48492)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8564/9037)50%
(5275/10603)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8346/14344)50%
(4868/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3851/7797)33%
(1617/4880)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(509/1000)41%
(395/968)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
   

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 76 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/76/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 12 Jan 2018 13:21:32 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiowidgets-dropjobtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31479/59400)38%
(18506/48568)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8564/9037)50%
(5270/10603)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8358/14345)50%
(4879/9712)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3851/7797)33%
(1617/4880)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(509/1000)41%
(395/968)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
  

Re: [kio] src/ioslaves/file/kauth: Do not cache root password for the whole session

[Luca Beltrame]

In data venerdì 12 gennaio 2018 14:40:07 CET, chinmoy ranjan ha scritto:

> TBH I can't see how any application will bypass the prompt. Maybe I am
> wrong. Can you elaborate on the potential risks?

I just tested this in my session:

kioclient5 copy  /mnt

Prompt appears, all OK.

Now I do this again in the same session, after removing the file:

kioclient5 copy  /mnt

No password prompt and the file is copied anyway.

-- 
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

Re: [kio] src/ioslaves/file/kauth: Do not cache root password for the whole session

[Luca Beltrame]

In data venerdì 12 gennaio 2018 14:42:39 CET, Luca Beltrame ha scritto:

> No password prompt and the file is copied anyway.

To clarify, this happened before my change to Persistence.

-- 
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 31 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/31/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 12 Jan 2018 13:50:50 +
 Build duration:
1 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 32 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/32/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 12 Jan 2018 13:50:50 +
 Build duration:
4 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(257/305)62%
(157/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(215/248)63%
(142/224)

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 32 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/32/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 12 Jan 2018 13:50:50 +
 Build duration:
9 min 35 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(257/305)62%
(157/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(215/248)63%
(142/224)

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/32/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 12 Jan 2018 14:01:10 +
 Build duration:
2 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/33/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 12 Jan 2018 14:01:10 +
 Build duration:
7 min 21 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(257/305)62%
(157/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(215/248)63%
(142/224)

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/33/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 12 Jan 2018 14:01:10 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(257/305)62%
(157/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(215/248)63%
(142/224)

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/20/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 12 Jan 2018 15:10:30 +
 Build duration:
1 min 26 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/28/
 Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 12 Jan 2018 15:10:30 +
 Build duration:
4 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/4)0%
(0/14)0%
(0/14)0%
(0/844)0%
(0/554)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)examples.galleryapp0%
(0/1)0%
(0/1)0%
(0/10)0%
(0/4)src0%
(0/7)0%
(0/7)0%
(0/520)0%
(0/416)src.libkirigami0%
(0/5)0%
(0/5)0%
(0/306)0%
(0/134)

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/21/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 12 Jan 2018 15:18:25 +
 Build duration:
56 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

D9829: Don't create 2 msgbox (one of them crashes) when can't change rights

[Anthony Fieroni]

anthonyfieroni added a comment.


  I'm still not sure that is correct fix. Can you investigate why second msgbox 
is shown? Maybe there is the problem.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9829

To: jtamate, #frameworks, anthonyfieroni, dfaure
Cc: ngraham

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/29/
 Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 12 Jan 2018 15:18:25 +
 Build duration:
2 min 28 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/4)0%
(0/14)0%
(0/14)0%
(0/847)0%
(0/552)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)examples.galleryapp0%
(0/1)0%
(0/1)0%
(0/10)0%
(0/4)src0%
(0/7)0%
(0/7)0%
(0/523)0%
(0/414)src.libkirigami0%
(0/5)0%
(0/5)0%
(0/306)0%
(0/134)

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/22/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 12 Jan 2018 15:23:15 +
 Build duration:
1 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/30/
 Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 12 Jan 2018 15:23:15 +
 Build duration:
4 min 49 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/4)0%
(0/14)0%
(0/14)0%
(0/847)0%
(0/552)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)examples.galleryapp0%
(0/1)0%
(0/1)0%
(0/10)0%
(0/4)src0%
(0/7)0%
(0/7)0%
(0/523)0%
(0/414)src.libkirigami0%
(0/5)0%
(0/5)0%
(0/306)0%
(0/134)

D9785: [ConfigModel] Set QML context on ConfigModule

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9785

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9784: [ConfigModule] Re-use QML context and engine if any

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D9784

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9275: fix RTL appearance for ComboBox

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  listrtl

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D9844: Don't stat(/etc/localtime) between read() and write() copying files

[Jaime Torres Amate]

jtamate created this revision.
jtamate added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  Unfortunately, QDateTime::currentDateTime() checks /etc/localtime
  each time it is called.
  Chaning to QElapsedTime, no check of /etc/localtime.
  Reproducing bug 384561, the strace of file.so was something like:
  read(), stat(/etc/localtime), stat(/etc/localtime),
  stat(/etc/localtime), stat(/etc/localtime), stat(/etc/localtime),
  write(), read() ..
  Now it is: read(), write()
  It also reduces the cpu in io/wait around 10% in a debug build.

REPOSITORY
  R241 KIO

BRANCH
  elapsedtimer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9844

AFFECTED FILES
  src/core/slavebase.cpp

To: jtamate, #frameworks

D9844: Don't stat(/etc/localtime) between read() and write() copying files

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham added a subscriber: Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9844

To: jtamate, #frameworks
Cc: #dolphin

D9844: Don't stat(/etc/localtime) between read() and write() copying files

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9844

To: jtamate, #frameworks
Cc: ngraham, #dolphin

D9770: Optimization of byteSize(double size)

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D9770

To: jtamate, #frameworks, mwolff
Cc: ngraham, cfeck, mwolff, broulik

D9808: fix incorrect emission of signals by kLineEdit

[Dan Weatherill]

dweatherill added a comment.


  as I don't have a developer account, I will need someone else to push it 
please :-)

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D9808

To: dweatherill, #frameworks, dhaumann, cullmann, dfaure
Cc: mwolff, dfaure, anthonyfieroni, iodelay, vbspam, njensen, geetamc, 
Pilzschaf, akshaydeo, surgenight, arrowdodger

Re: [kio] src/ioslaves/file/kauth: Do not cache root password for the whole session

[David Edmundson]

Can we keep all messages on the ML. We can only see half a conversation on
here.

> TBH I can't see how any application will bypass the prompt

A rogue plugin can call org.kde.kio.file.exec directly with kauth.  Or even
just use DBus directly.

D9808: fix incorrect emission of signals by kLineEdit

[Nathaniel Graham]

ngraham added a comment.


  If this actually fixes any of the bugs you mentioned, please edit the Summary 
section to include "BUG: " on its own line for each bug that this 
fixes. Those are special keywords that will cause the Bugzilla tickets to get 
closed when this lands.
  
  If there's any bug that's relevant but not directly fixed by this, you can do 
"CCBUG: ", which will make a comment in the Bugzilla ticket, but 
not close it.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D9808

To: dweatherill, #frameworks, dhaumann, cullmann, dfaure
Cc: ngraham, mwolff, dfaure, anthonyfieroni, iodelay, vbspam, njensen, geetamc, 
Pilzschaf, akshaydeo, surgenight, arrowdodger

D9808: fix incorrect emission of signals by kLineEdit

[Dan Weatherill]

dweatherill edited the summary of this revision.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D9808

To: dweatherill, #frameworks, dhaumann, cullmann, dfaure
Cc: ngraham, mwolff, dfaure, anthonyfieroni, iodelay, vbspam, njensen, geetamc, 
Pilzschaf, akshaydeo, surgenight, arrowdodger

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 77 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/77/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 12 Jan 2018 20:56:56 +
 Build duration:
9 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiowidgets-dropjobtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31477/59411)38%
(18504/48570)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8564/9037)50%
(5273/10603)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8356/14345)50%
(4878/9712)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3851/7797)33%
(1617/4880)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(509/1000)41%
(395/968)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 77 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/77/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 12 Jan 2018 20:56:56 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiowidgets-dropjobtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31460/59412)38%
(18489/48494)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8564/9037)50%
(5276/10603)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8349/14345)50%
(4874/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3851/7797)33%
(1617/4880)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(509/1000)41%
(395/968)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 57 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/57/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 12 Jan 2018 20:56:56 +
 Build duration:
34 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiowidgets-dropjobtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.testtrash

D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

[Nathaniel Graham]

ngraham added a comment.


  Looks like DigiKam 5.8.0 is supposed to be released in two days: 
https://staging.digikam.org/news/2018-01-14-5.8.0_release_announcement/
  
  Once it's released, I'll land this.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: ilic, abetts, elvisangelaccio, aacid, argonel, marten, graesslin, broulik, 
#frameworks

Re: [kio] src/ioslaves/file/kauth: Do not cache root password for the whole session

[chinmoy ranjan]

>I just tested this in my session:
>
>kioclient5 copy  /mnt
>
>Prompt appears, all OK.
>
>Now I do this again in the same session, after removing the file:
>
>kioclient5 copy  /mnt
>
>No password prompt and the file is copied anyway.

I executed the commands in the same order on a new VM and I am getting
proper prompts (with persistence=session).

There's one thing I don't understand, how did you execute two kioclient
commands in one session? I mean, as soon as one kioclient5 command finishes
the session ends and for the next command there will be a new session. Am I
wrong? If not then there should be a password prompt (persistence value
doesn't matter) shown right after every call to kioclient5.
Since you didn't get  a password prompt the second time, it seems to me its
more likely a issue with your setup. Is there any way we can confirm if
this depends on local setup or not? Meanwhile, can you try using
kioslavetest. Maybe that will work properly.

Re: [kio] src/ioslaves/file/kauth: Do not cache root password for the whole session

[chinmoy ranjan]

>It was pointed out in D6198 that
>there's
>no such thing as persistence in
>polkit,

Persistence =session or always both are same and will cache the password
for 5 mins.

>however as David mentioned, we don't
>want the authorization to last
>the whole session

In response to David's comment I added the code for warning dialogs. Untill
the warning dialog is shown the helper won't be called. So privilege
execution is not possible in unit tests and background jobs.
TBH I can't see how any application will bypass the prompt. Maybe I am
wrong. Can you elaborate on the potential risks?

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:547dade2f803: fix RTL appearance for ComboBox (authored 
by mvourlakos).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9275?vs=23708&id=25254

REVISION DETAIL
  https://phabricator.kde.org/D9275

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ComboBox.qml

To: mvourlakos, #plasma, mart
Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 42 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/42/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 13 Jan 2018 01:24:37 +
 Build duration:
7 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13208)19%
(1975/10437)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)54%
(609/1130)28%
(421/1482)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)12%
(251/2152)7%
(98/1450)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1445/3488)28%
(827/2907)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1611)28%
(318/1119)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/1966)18%
(306/1701)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
   

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/45/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 13 Jan 2018 01:24:37 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3559/13204)19%
(1974/10437)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)54%
(609/1130)28%
(421/1482)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)12%
(250/2148)7%
(97/1446)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1445/3488)28%
(827/2911)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1611)28%
(318/1119)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/1966)18%
(306/1701)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
   

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/18/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 13 Jan 2018 01:24:37 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/15/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 13 Jan 2018 02:09:05 +
 Build duration:
2 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest