KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 9 - Still Unstable!

2018-01-26 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/9/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 27 Jan 2018 04:01:29 +
 Build duration:
5 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/20)0%
(0/57)0%
(0/57)0%
(0/2065)0%
(0/1228)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests0%
(0/4)0%
(0/4)0%
(0/149)0%
(0/172)src0%
(0/8)0%
(0/8)0%
(0/284)0%
(0/229)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/141)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/4)0%
(0/4)0%
(0/243)0%
(0/84)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas0%
(0/1)0%
(0/1)0%
(0/51)0%
(0/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/121)0%
(0/44)src.quick0%
(0/2)0%
(0/2)0%
(0/5)100%
(0/0)src.widgets0%
(0/2)0%
(0/2)0%
(0/43)0%

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

2018-01-26 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/8/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 27 Jan 2018 04:01:29 +
 Build duration:
3 min 3 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/20)0%
(0/57)0%
(0/57)0%
(0/2065)0%
(0/1228)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests0%
(0/4)0%
(0/4)0%
(0/149)0%
(0/172)src0%
(0/8)0%
(0/8)0%
(0/284)0%
(0/229)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/141)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/4)0%
(0/4)0%
(0/243)0%
(0/84)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas0%
(0/1)0%
(0/1)0%
(0/51)0%
(0/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/121)0%
(0/44)src.quick0%
(0/2)0%
(0/2)0%
(0/5)100%
(0/0)src.widgets0%
(0/2)0%
(0/2)0%
(0/43)0%

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 8 - Still Unstable!

2018-01-26 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/8/
 Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 27 Jan 2018 04:01:29 +
 Build duration:
2 min 53 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.alternativesmodeltest

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

2018-01-26 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10114

To: ijanssen, #plasma, dfaure
Cc: aacid, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

2018-01-26 Thread Albert Astals Cid 
aacid added a comment.


  autotest possible?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10114

To: ijanssen, #plasma, dfaure
Cc: aacid, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2018-01-26 Thread Andres Betts 
abetts added a comment.


  Is this change purely a conversation of what developers use in code to call 
up fonts in their applications? Or does this also include a discussion where 
regular users have interfaces that allow changes to font naming? Let's say, 
something like System Settings that would allow users to change the naming for 
system fonts?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: abetts, anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2018-01-26 Thread Nathaniel Graham 
ngraham added a comment.


  Does anyone have strong objections to landing this?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2018-01-26 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10072: Add APKBUILD to be highlighted as a Bash file

2018-01-26 Thread Bart Ribbers 
PureTryOut updated this revision to Diff 25985.
PureTryOut added a comment.


  Updated the version from 6 to 7

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10072?vs=25871=25985

REVISION DETAIL
  https://phabricator.kde.org/D10072

AFFECTED FILES
  data/syntax/bash.xml

To: PureTryOut, vkrause
Cc: dhaumann, bshah, vkrause, bcooksley, #frameworks

D9332: Allow filter places based on alternative application name

2018-01-26 Thread Phabricator 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:fc1f2fe296d6: Allow filter places based on alternative 
application name (authored by Renato Araujo Oliveira Filho 
renato.ara...@kdab.com).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9332?vs=25880=25988

REVISION DETAIL
  https://phabricator.kde.org/D9332

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: renatoo, mwolff, mlaurent
Cc: elvisangelaccio, mlaurent, aacid, ngraham, #frameworks

D10077: [Default Tooltip] Fix sizing

2018-01-26 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10077

To: broulik, #plasma, #vdg, mart
Cc: ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10072: Add APKBUILD to be highlighted as a Bash file

2018-01-26 Thread Volker Krause 
vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10072

To: PureTryOut, vkrause
Cc: dhaumann, bshah, vkrause, bcooksley, #frameworks

D10106: Relocate the Baloo database to the XDG cache location.

2018-01-26 Thread Michael Heidelbach 
michaelh added a comment.


  The way I use baloo the DB is not easily recreated at all.
  
  1. Indexing takes around 2hrs.
  2. On top of that I have to make a lot of manual adjustments due some bugs in 
baloo. That takes about another hour.
  
  In my view a cache is for faster access of data that already exist somewhere 
else. "non-essential" data as freedesktop Standard states. The baloo db, though 
recreatable, definitely is essential data and as such belongs to XDG_DATA_HOME.
  
  Putting something into  XDG_CACHE_HOME is communicating to the users. "You 
can delete these data without harm".
  At least in my case that is not true.
  
  IMO the db should stay at its current location.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10106

To: smithjd
Cc: ltoscano, michaelh, ngraham, #frameworks

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 30 - Still Unstable!

2018-01-26 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/30/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 26 Jan 2018 19:34:42 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 54 - Still Unstable!

2018-01-26 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/54/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 26 Jan 2018 19:34:42 +
 Build duration:
8 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13224)19%
(1976/10459)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)12%
(251/2156)7%
(98/1454)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1445/3488)28%
(828/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/1968)18%
(306/1703)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 57 - Still Unstable!

2018-01-26 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/57/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 26 Jan 2018 19:34:42 +
 Build duration:
7 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3557/13219)19%
(1974/10459)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(607/1138)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)12%
(250/2152)7%
(97/1450)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1445/3488)28%
(828/2917)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(317/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/1968)18%
(306/1703)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

2018-01-26 Thread Michael Heidelbach 
michaelh retitled this revision from "Emit metaDataRequestFinished once per 
request" to "baloo-widgets: Emit metaDataRequestFinished once per request".

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10113

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks

D10124: Faster simplejob start

2018-01-26 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> simplejob.cpp:142
>  
>  q->connect(slave, SIGNAL(infoMessage(QString)),
> SLOT(_k_slotSlaveInfoMessage(QString)));

Try something along the lines of

  q->connect(slave, ::infoMessage, q, 
std::bind(::_k_slotSlaveInfoMessage, this);

Note that if there's a `disconnect` for that particular signal somewhere in the 
code this will not work but at a quick glance I can only see a 
`disconnect(m_slave);` which is fine

`QObject::connect` is static, so you might as well do `QObject::connect` 
instead of `q->connect`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10124

To: jtamate, #frameworks
Cc: broulik, ngraham, anthonyfieroni

D10124: Faster simplejob start

2018-01-26 Thread Anthony Fieroni 
anthonyfieroni added a comment.


  This -> https://wiki.qt.io/New_Signal_Slot_Syntax#Overload

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10124

To: jtamate, #frameworks
Cc: ngraham, anthonyfieroni

D10113: Emit metaDataRequestFinished once per request

2018-01-26 Thread Michael Heidelbach 
michaelh added a dependency: D10105: baloo-widgets: Refactor 
filemetadataprovider for better readability.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10113

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 29 - Still Unstable!

2018-01-26 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/29/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 26 Jan 2018 14:50:59 +
 Build duration:
8 min 36 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 56 - Still Unstable!

2018-01-26 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/56/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 26 Jan 2018 14:50:59 +
 Build duration:
9 min 35 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3543/13222)19%
(1969/10463)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)12%
(250/2152)7%
(97/1450)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1445/3488)28%
(828/2917)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(537/1970)18%
(300/1707)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

2018-01-26 Thread Michael Heidelbach 
michaelh added a dependent revision: D10113: Emit metaDataRequestFinished once 
per request.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10105

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D10113: Emit metaDataRequestFinished once per request

2018-01-26 Thread Michael Heidelbach 
michaelh created this revision.
michaelh added reviewers: elvisangelaccio, smithjd, vhanda, ngraham, Dolphin, 
Frameworks.
michaelh requested review of this revision.

REVISION SUMMARY
  Add signal 'dataAvailable' to allow chunkwise data processing
  Emit metaDataRequestFinished when request processing is finished
  
  CCBUG: 388583

TEST PLAN
  Visual inspection
  make test

REPOSITORY
  R824 Baloo Widgets

BRANCH
  dataavail

REVISION DETAIL
  https://phabricator.kde.org/D10113

AFFECTED FILES
  src/filemetadataprovider.cpp
  src/filemetadataprovider.h
  src/filemetadatawidget.cpp
  src/filemetadatawidget.h

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks

D10072: Add APKBUILD to be highlighted as a Bash file

2018-01-26 Thread Dominik Haumann 
dhaumann added a comment.


  The version needs to be increased from 6 to 7. Besides this, the patch looks 
good.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10072

To: PureTryOut, vkrause
Cc: dhaumann, bshah, vkrause, bcooksley, #frameworks

D10124: Faster simplejob start

2018-01-26 Thread Jaime Torres Amate 
jtamate added a comment.


  In https://phabricator.kde.org/D10124#196534, @anthonyfieroni wrote:
  
  > Is there any problems to change other connects too?
  
  
  There is only one problem,  that I do not know how to do it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10124

To: jtamate, #frameworks
Cc: ngraham, anthonyfieroni

D10124: Faster simplejob start

2018-01-26 Thread Jaime Torres Amate 
jtamate created this revision.
jtamate added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  Changing only 4 of the signals connections to the new syntax almost
  doubles the spped of simplejob::start in a kioclient5 copy of 3000
  files.

TEST PLAN
  If someone knows how to change the other 6 connect, please, please
  do it.
  I've tried lots of combinations but I've been unable to find the
  one that compiles.

REPOSITORY
  R241 KIO

BRANCH
  simplejob (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10124

AFFECTED FILES
  src/core/simplejob.cpp

To: jtamate, #frameworks

D10077: [Default Tooltip] Fix sizing

2018-01-26 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f31e7860d98f: [Default Tooltip] Fix sizing (authored by 
broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10077?vs=25885=25993

REVISION DETAIL
  https://phabricator.kde.org/D10077

AFFECTED FILES
  src/declarativeimports/core/private/DefaultToolTip.qml

To: broulik, #plasma, #vdg, mart
Cc: ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10092: [Examples] Fix build

2018-01-26 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:595fd8805430: [Examples] Fix build (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10092?vs=25923=25992

REVISION DETAIL
  https://phabricator.kde.org/D10092

AFFECTED FILES
  examples/dataengines/customDataContainers/customDataContainersEngine.cpp
  examples/dataengines/customDataContainers/customDataContainersEngine.h
  examples/dataengines/customDataContainers/httpContainer.cpp
  examples/dataengines/customDataContainers/httpContainer.h
  examples/dataengines/simpleEngine/simpleEngine.cpp
  examples/dataengines/sourcesOnRequest/sourcesOnRequest.cpp
  examples/dataengines/sourcesOnRequest/sourcesOnRequest.h
  examples/shell/customcorona.cpp
  examples/shell/customcorona.h
  examples/shell/main.cpp
  examples/testcontainmentactionsplugin/test.cpp
  examples/testcontainmentactionsplugin/test.h

To: broulik, #plasma, rjvbb
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

2018-01-26 Thread Kai Uwe Broulik 
broulik added a comment.


  Yes, please!
  
  I agree that shared-mime-info must be fixed to remove the `.bin` extension 
but this will take forever and this is a serious regression preventing any 
novice user from downloading files properly.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10114

To: ijanssen, #plasma, dfaure
Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

2018-01-26 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/53/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 26 Jan 2018 14:50:59 +
 Build duration:
6 min 25 sec and counting
   JUnit Tests
  Name: (root) Failed: 8 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3507/13223)19%
(1947/10463)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)51%
(583/1138)27%
(406/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)12%
(251/2156)7%
(98/1454)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1444/3488)28%
(826/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(317/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(527/1968)17%
(295/1707)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 80 - Still Unstable!

2018-01-26 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/80/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 26 Jan 2018 13:25:53 +
 Build duration:
1 hr 26 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfilecopytomenutest

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

2018-01-26 Thread Michael Heidelbach 
michaelh added a dependent revision: D10119: Create test to assert 
metaDataRequestFinished is emitted once only.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10113

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

2018-01-26 Thread Igor Janssen 
ijanssen added reviewers: Plasma, dfaure.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10114

To: ijanssen, #plasma, dfaure
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

2018-01-26 Thread Igor Janssen 
ijanssen edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10114

To: ijanssen
Cc: #frameworks

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

2018-01-26 Thread Igor Janssen 
ijanssen created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
ijanssen requested review of this revision.

REVISION SUMMARY
  https://bugs.kde.org/show_bug.cgi?id=382437
  //One cause of the bug is commit at plasma-integration:
  authorElvis Angelaccio  2017-05-23 
10:48:24 (GMT)
  commit
https://phabricator.kde.org/R135:0dafb9403266d6064074250d44b74dc0db946cfb
   /src/platformtheme/kdeplatformfiledialoghelper.cpp
  parent
https://phabricator.kde.org/R135:708ff0d0b2905e4c68a9fb22b8a2f439d2f2fb65 (diff)
  Make sure we always set a default mime filter in save mode
  KFileWidget::setMimeFilter() documentation says a default mime filter
  should be set if the dialog is being open in save mode.
  
  Without a default filter, the dialog uses a custom item (created by
  concatenating all the mime type filters) as default. This is not useful
  because it means an additional click for the user to select a filter that can
  actually be useful.
  
  If the initiallySelectedMimeTypeFilter() is empty, we use the first mime
  filter as fallback.
  //
  
  Chrome opens kdialog with 2 mime types: application/octet-stream (means any 
file) and (for example) image/jpeg. But application/octet-stream is associated 
with *.bin extension. When you choose this mime extention becomes *.bin. That 
commit does this mime default (it's first).
  This patch blocks changing extention to bin for "application/octet-stream" 
selected.

TEST PLAN
  Tested with Google  Chrome. Used Open/Save dialogs for files.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10114

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: ijanssen
Cc: #frameworks

D10124: Faster simplejob start

2018-01-26 Thread Anthony Fieroni 
anthonyfieroni added a comment.


  Is there any problems to change other connects too?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10124

To: jtamate, #frameworks
Cc: anthonyfieroni

D1231: Add Remote Access interface to KWayland

2018-01-26 Thread Oleg Chernovskiy 
Kanedias updated this revision to Diff 25976.
Kanedias edited the test plan for this revision.
Kanedias added a comment.


  - Add RemoteAccess interface to KWayland
  - Merge branch
  - Fix compilation warnings uint -> int

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1231?vs=21212=25976

BRANCH
  gbm-vnc

REVISION DETAIL
  https://phabricator.kde.org/D1231

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_remote_access.cpp
  src/client/CMakeLists.txt
  src/client/protocols/remote-access.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/remote_access.cpp
  src/client/remote_access.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/remote_access_interface.cpp
  src/server/remote_access_interface.h
  src/server/remote_access_interface_p.h
  src/tools/mapping.txt

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jgrulich, romangg, ngraham, alexeymin, #frameworks, davidedmundson, 
plasma-devel, schernikov, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D10124: Faster simplejob start

2018-01-26 Thread Jaime Torres Amate 
jtamate added a comment.


  F5675857: kcioclient5_move_2000_files_old_connect.png 

  
  F5675856: kcioclient5_move_2000_files_partly_connect.png 

  
  From spending 11.65% to 7.06%

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10124

To: jtamate, #frameworks