D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

simgunz added a comment.


  > - [↓] to move focus (this breaks with the completion enabled, though)
  
  Only for completion: popup. Still works for completion: auto
  
  I have changed the tooltip as suggested. I think we are ready to land it.
  
  Can't wait to see the gif!

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

simgunz updated this revision to Diff 27136.
simgunz added a comment.


  - Improve tooltip to let user know he can type a command

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8056?vs=27084=27136

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

AFFECTED FILES
  src/widgets/kopenwithdialog.cpp
  src/widgets/kopenwithdialog.h
  src/widgets/kopenwithdialog_p.h

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Nathaniel Graham]

ngraham added a comment.


  I'm super excited to see this happening. Fantastic work, @simgunz, and thanks 
as always for your incredibly thorough review prowess, @rkflx. I'm planning to 
feature this in the coming Sunday's Usability & Productivity post as it it not 
only a //serious// improvement to both, but it should also look really, really 
good in animated gif form. :)

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

D10495: Workaround to restore KF5 programs from system tray

[Martin Flöser]

graesslin added a comment.


  In D10495#205811 , @stikonas wrote:
  
  > This is more to start some discussion on system tray under Wayland. I'm not 
sure myself if this should be committed. I just use this workaround locally 
until winId() works on Wayland.
  
  
  winId will never work. I cannot say much on the patch as the context is 
missing.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Wolfgang Bauer]

wbauer added a subscriber: KWin.
wbauer added a comment.


  Indeed.
  One thing that started this is https://bugs.kde.org/show_bug.cgi?id=389663
  
  I do think this should be fixed on the lower level if possible.
  
  Adding KWin as subscriber as well to hopefully get most people that have more 
insight.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: #kwin, plasma-devel, kde-frameworks-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10494: update handle- icons for kirigami

[Matheus Marinho]

matheusm added a comment.


  The current icon reminds me of a phone dialer. +1 for the new icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: matheusm, mmustac, ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

[Nathaniel Graham]

ngraham added a comment.


  In D10494#205867 , @andreask wrote:
  
  > it doesn't matter where the element in kirigami swap it's for settings and 
have an dotted icon would only increase publicity like here in discover have 
three dot's in each line will give you the information that you can do 
something, but the focus is more on the line content than on the dotted icon.
  >  F5710557: Screenshot_20180213_230907.png 

  
  
  Sorry, I don't understand what you mean here, and your screenshot shows the 
//old// icon. Can you clarify?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: mmustac, ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

[Marijo Mustac]

mmustac added a comment.


  I agree with Andreas and think that the new icon is a huge improvement. +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: mmustac, ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

[Andreas Kainz]

andreask added a comment.


  it doesn't matter where the element in kirigami swap it's for settings and 
have an dotted icon would only increase publicity like here in discover have 
three dot's in each line will give you the information that you can do 
something, but the focus is more on the line content than on the dotted icon.
  F5710557: Screenshot_20180213_230907.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: ngraham, #frameworks, michaelh

D10492: add 64px media icons for elisa

[Nathaniel Graham]

ngraham added a comment.


  If you're going to use arc and Phabricator, wait for reviews. If you don't 
want to wait for reviews, then just push directly.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10492

To: andreask
Cc: ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

[Nathaniel Graham]

ngraham added a comment.


  Same thing, though. The icons on the left don't scream "Swipe me to the left!"
  
  It's a tough one. I have trouble imagining //any// icon that could 
communicate that, but of course I'm not an icon designer.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: ngraham, #frameworks, michaelh

D10492: add 64px media icons for elisa

[Andreas Kainz]

andreask added a comment.


  cause I changed my workflow and start use arc but I wasn't interested into a 
review.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10492

To: andreask
Cc: ngraham, #frameworks, michaelh

D10492: add 64px media icons for elisa

[Nathaniel Graham]

ngraham added a comment.


  Why bother to ask for a review on Phabricator if you're not going to post 
screenshots so people can see your changes or wait for any reviews before 
committing? If you don't want a review, just push to master directly.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10492

To: andreask
Cc: ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

[Andreas Kainz]

andreask added a comment.


  F5710546: Screenshot_20180213_230517.png 

  
  sorry wrong screenshot
  left new
  right old

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

[Nathaniel Graham]

ngraham added a comment.


  Thanks!
  
  I hate to throw cold water on your hard work here, but is the new one really 
any better? I'm not sure either the old or the new icon convey "swipe left 
here".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

[Andreas Kainz]

andreask added a comment.


  F5710538: photo5773697838952328398.jpg 
  left after
  right before

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

[Nathaniel Graham]

ngraham added a comment.


  needs moar screenshots

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: ngraham, #frameworks, michaelh

D10054: Fix: View jumps when Scroll past end of document is enabled

[Dominik Haumann]

dhaumann closed this revision.
dhaumann added a comment.


  Close as it should work now.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10054

To: dhaumann, cullmann
Cc: rikmills, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, 
sars, dhaumann

D10054: Fix: View jumps when Scroll past end of document is enabled

[Dominik Haumann]

dhaumann added a comment.


  This is fixed, see commit 
https://phabricator.kde.org/R39:1a38adebb64e6e7d5acb756f68166d56d8ba0b72

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10054

To: dhaumann, cullmann
Cc: rikmills, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, 
sars, dhaumann

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 40 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/40/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
 Date of build:
Tue, 13 Feb 2018 21:35:53 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 67 test(s), Skipped: 0 test(s), Total: 67 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(301/337)89%
(301/337)69%
(34119/49379)52%
(17906/34216)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)94%
(4381/4672)49%
(2166/4386)autotests.src.vimode100%
(16/16)100%
(16/16)99%
(5493/5534)58%
(1073/1846)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1781/3121)43%
(1245/2905)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(185/460)22%
(79/360)src.dialogs0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/242)src.document100%
(4/4)100%
(4/4)60%
(1914/3208)49%
(1731/3517)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/296)src.render100%
(9/9)100%
(9/9)76%
(927/1219)66%
(627/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(306/517)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%
(6/8)30%

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 39 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/39/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 13 Feb 2018 21:35:53 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 67 test(s), Skipped: 0 test(s), Total: 67 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(301/337)89%
(301/337)69%
(34105/49373)52%
(17905/34214)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)94%
(4370/4669)49%
(2164/4386)autotests.src.vimode100%
(16/16)100%
(16/16)99%
(5493/5534)58%
(1073/1846)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1778/3121)43%
(1242/2905)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(185/460)22%
(79/360)src.dialogs0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/242)src.document100%
(4/4)100%
(4/4)60%
(1914/3208)49%
(1731/3517)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/296)src.render100%
(9/9)100%
(9/9)76%
(927/1219)66%
(627/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(306/517)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%
(6/8)30%

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas added a comment.


  This is more to start some discussion on system tray under Wayland. I'm not 
sure myself if this should be committed. I just use this workaround locally 
until winId() works on Wayland.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: plasma-devel, kde-frameworks-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas created this revision.
stikonas added reviewers: wbauer, Plasma, davidedmundson, volkov.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
stikonas requested review of this revision.

REVISION SUMMARY
  Currently restoring system tray does not work on Wayland.
  
  Even with this commit, the functionality is still worse than on X11 because 
clicking on system tray does not hide application window.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: plasma-devel, kde-frameworks-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Henrik Fehlauer]

rkflx accepted this revision.
rkflx added a comment.
This revision is now accepted and ready to land.


  In D8056#205595 , @simgunz wrote:
  
  > Fixed the problems reported by @rkflx  hopefully without introducing new 
ones. I did some testing and now everything seems ok, but please check again.
  
  
  Thanks Simone, works great now.
  
  Successfully tested opening a file with the following methods:
  
  - mouse selection only
  - type a few characters, select with the mouse
  - type a few characers, hit [Enter]
  - double click on entry
  - history dropdown
  - enable completion dropdown, open with custom bin in path
  - open button
  - paste custom bin not in path
  - autocomplete custom path
  - [↓] to move focus (this breaks with the completion enabled, though)
  
  That's basically all the dialog should be able to do that I know of, 
therefore we can land it (once the tooltip is changed).
  
  For improving the usability, I still want to open a task with some ideas to 
discuss them further (really soon™, the first step is done by listing the 
current functionality ↑↑↑). [My promise for Nate's 
https://phabricator.kde.org/D10245 is still open too…]
  
  ---
  
  In D8056#205608 , @simgunz wrote:
  
  > The tooltip of the line edit now says: `Type some text to filter the 
application tree.\nPress down arrow to navigate the results tree.`
  >  I suggest to change it to: `Type to filter the application tree or type 
the name of a command.\nPress down arrow to navigate the results tree.` just to 
avoid having a hidden feature, which is the possibility to type commands. Also 
because the completion mode default is now set to None, so there will not even 
be the completion that suggests the existence of this feature.
  
  
  You are right, the least we can do for now is to improve the tooltip. I don't 
think users know what a "tree" is, so how about this:
  
Type to filter the applications below, or specify the name of a command.
Press down arrow to navigate the results.
  
  Use/adapt it if you like it, I'll wait with landing.
  
  ---
  
  > When you click OK the function `checkAccepted` is called. To me it seems 
that it actually uses the service associated to the selected "Kate" entry 
(`kate -b %U`) and does not execute the command `kate`. 
  >  (That function is quite complicated and I haven't really analyzed it 
completely)
  
  Yeah, that's not ideal (but not too bad since the completion is off by 
default). In my testing the service was also preferred over the executable, 
which is fine because you can explicitly specify the latter by typing the full 
path.

INLINE COMMENTS

> kopenwithdialog.cpp:834-836
> -if (typedExec.isEmpty()) {
> -return false;
> -}

I checked this, but AFAIK it's fine to remove. @dfaure introduced this 10 years 
ago in R446:d6903613f07b 
, 
but I guess we are covered both by the disabled button for empty line edits as 
well as the checks below.

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

D10494: update handle- icons for kirigami

[Andreas Kainz]

andreask added a comment.


  the old icon with 12 dots are a bit of a overkill now with three dot's 
compare to three lines.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: #frameworks, michaelh

D10494: update handle- icons for kirigami

[Andreas Kainz]

andreask added reviewers: alex-l, mart.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: #frameworks, michaelh

D10494: update handle- icons for kirigami

[Andreas Kainz]

andreask created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
andreask requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10494

AFFECTED FILES
  icons-dark/actions/22/handle-left.svg
  icons-dark/actions/22/handle-right.svg
  icons/actions/22/handle-left.svg
  icons/actions/22/handle-right.svg

To: andreask
Cc: #frameworks, michaelh

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 51 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/51/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
 Date of build:
Tue, 13 Feb 2018 20:37:37 +
 Build duration:
8 min 38 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)77%
(237/306)60%
(152/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)78%
(195/249)61%
(137/224)

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 48 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/48/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 13 Feb 2018 20:37:37 +
 Build duration:
3 min 28 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.scalable

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 51 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/51/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 13 Feb 2018 20:37:38 +
 Build duration:
2 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)77%
(237/306)60%
(152/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)78%
(195/249)61%
(137/224)

D10492: add 64px media icons for elisa

[Andreas Kainz]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:6800b88f1819: add 64px media icons for elisa (authored by 
andreask).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10492?vs=27100=27102

REVISION DETAIL
  https://phabricator.kde.org/D10492

AFFECTED FILES
  icons-dark/actions/64/media-album-cover.svg
  icons-dark/actions/64/media-album-track.svg
  icons-dark/actions/64/view-media-playlist.svg
  icons-dark/index.theme
  icons/actions/64/media-album-cover.svg
  icons/actions/64/media-album-track.svg
  icons/actions/64/view-media-playlist.svg
  icons/index.theme

To: andreask
Cc: #frameworks, michaelh

D10492: add 64px media icons for elisa

[Andreas Kainz]

andreask created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
andreask requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10492

AFFECTED FILES
  icons-dark/actions/64/media-album-cover.svg
  icons-dark/actions/64/media-album-track.svg
  icons-dark/actions/64/view-media-playlist.svg
  icons-dark/index.theme
  icons/actions/64/media-album-cover.svg
  icons/actions/64/media-album-track.svg
  icons/actions/64/view-media-playlist.svg
  icons/index.theme

To: andreask
Cc: #frameworks, michaelh

D10365: New icon for Elisa music player

[Andreas Kainz]

andreask added a comment.


  can we get it now to master?
  
  @paullesur is hopefully interested in other icon's too.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien
Cc: mmustac, mgallien, januz, astippich, andreask, andreaska, ltoscano, 
ngraham, #frameworks, jussiv, paullesur, michaelh, ognarb, kmf, progwolff

D10054: Fix: View jumps when Scroll past end of document is enabled

[Christoph Cullmann]

cullmann added a comment.


  No idea ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10054

To: dhaumann, cullmann
Cc: rikmills, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, 
sars, dhaumann

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

simgunz added a comment.


  I rebased to master and updated the review. I hope I didn't messed up 
anything.
  
  In D8056#205621 , @ngraham wrote:
  
  > I was under the impression that the text box gave priority to the app 
filtering unless you checked the semi-hidden option to enable command-line 
completion instead.
  
  
  That is true, but in the moment you type a text, which is also a valid 
command, let's say `kate` you have two things:
  
  - The Kate entry is selected (and so its associated service `kate -b %U` or 
similar)
  - The text box contains a valid binary command `kate` that can be executed
  
  When you click OK the function `checkAccepted` is called. To me it seems that 
it actually uses the service associated to the selected "Kate" entry (`kate -b 
%U`) and does not execute the command `kate`. 
  (That function is quite complicated and I haven't really analyzed it 
completely)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

simgunz updated this revision to Diff 27084.
simgunz added a comment.


  - Automatically select first match of the filter
  - ArrowDown on lineEdit pass focus to QTreeView
  - Add tooltip to explain how to use the search filter
  - Fix code styling
  - Set appModel and proxyModel together, store proxyModel in data member
  - Avoid casts using pointer to proxyModel
  - Use fixed string case insensitive filter
  - Avoid cast by using member var to proxyModel
  - Initialize m_proxyModel to null pointer
  - Add access method to m_proxyModel, use it to avoid cast
  - Remove unuseful returns, call parent eventFilter if conditions unmatched
  - Fix OK button not disabled when category is selected
  - Fix cannot accept selection if filter line edit is empty

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8056?vs=27079=27084

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

AFFECTED FILES
  src/widgets/kopenwithdialog.cpp
  src/widgets/kopenwithdialog.h
  src/widgets/kopenwithdialog_p.h

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Nathaniel Graham]

ngraham added a comment.


  It's been a while since I tested (could you re-based it on current master?), 
but I was under the impression that the text box gave priority to the app 
filtering unless you checked the semi-hidden option to enable command-line 
completion instead.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

simgunz added a comment.


  In D8056#205614 , @ngraham wrote:
  
  > interspersing the CLI command and application filtering would be a mistake. 
Say I type `kate`. Am I intending to use the `kate` command, or select the 
"Kate" app? It's ambiguous if we use one text field for both.
  
  
  That is a good point, actually I need to check which of the two has the 
priority now. Given that we were planning to land the revision as it is now (so 
with this ambiguity), don't we need to describe correctly the current behavior? 
Then this can be changed when we figure out a better design for dealing with 
how to input the commands.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Nathaniel Graham]

ngraham added a comment.


  interspersing the CLI command and application filtering would be a mistake. 
Say I type `kate`. Am I intending to use the `kate` command, or select the 
"Kate" app? It's ambiguous if we use one text field for both.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

simgunz added a comment.


  The tooltip of the line edit now says: `Type some text to filter the 
application tree.\nPress down arrow to navigate the results tree.`
  I suggest to change it to: `Type to filter the application tree or type the 
name of a command.\nPress down arrow to navigate the results tree.` just to 
avoid having a hidden feature, which is the possibility to type commands. Also 
because the completion mode default is now set to None, so there will not even 
be the completion that suggests the existence of this feature.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

simgunz added a comment.


  Fixed the problems reported by @rkflx  hopefully without introducing new 
ones. I did some testing and now everything seems ok, but please check again.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

simgunz updated this revision to Diff 27079.
simgunz added a comment.


  - Fix OK button not disabled when category is selected
  - Fix cannot accept selection if filter line edit is empty

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8056?vs=24488=27079

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

AFFECTED FILES
  src/widgets/kopenwithdialog.cpp
  src/widgets/kopenwithdialog.h
  src/widgets/kopenwithdialog_p.h

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Friedrich W . H . Kossebau]

kossebau added a comment.


  To add some code to my words, a proposed fix for the detected unneeded json 
file and separate cmdl tool dependency now up here: 
https://phabricator.kde.org/D10485

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco
Cc: rakuco, kfunk, adridg, kossebau, #frameworks, michaelh

D7849: Fix the tray icon scaling on HiDPI screens

[Nathaniel Graham]

ngraham added a comment.


  Does this actually fully fix https://bugs.kde.org/show_bug.cgi?id=360333?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D7849

To: pgkos, #plasma
Cc: aspotashev, ngraham, anthonyfieroni, broulik, #frameworks, davidedmundson, 
plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 37 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/37/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 13 Feb 2018 14:32:30 +
 Build duration:
43 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 61 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/61/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 13 Feb 2018 14:32:30 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13295)19%
(1979/10493)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2227)7%
(102/1488)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/1968)18%
(306/1703)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 64 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/64/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Tue, 13 Feb 2018 14:32:30 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3559/13291)19%
(1978/10493)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2223)7%
(101/1484)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2917)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/1968)18%
(306/1703)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
  

D10464: Initialize m_actualGroup to NormalColorGroup

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:581dc48ff836: Initialize m_actualGroup to 
NormalColorGroup (authored by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10464?vs=27007=27064

REVISION DETAIL
  https://phabricator.kde.org/D10464

AFFECTED FILES
  src/declarativeimports/core/colorscope.cpp

To: apol, #frameworks, dfaure
Cc: michaelh

D10325: [KFileWidget] Hide places frame and header

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> apol wrote in kfilewidget.cpp:1351
> Does it really make sense that it's a dock if it can't be interacted with?

I don't know. You can still resize the panel, I also wanted to keep the patch 
as unintrusive as possible.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10325

To: broulik, #plasma, #vdg, #frameworks, ngraham, mart
Cc: apol, markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10380: Refactor KCoreDirLister(Cache) to use KFileItemListV2 where possible.

[Mark Gaiser]

markg abandoned this revision.
markg added a comment.


  As this is a no-go, rightfully so! Abandoning it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10380

To: markg, dfaure
Cc: #frameworks, michaelh

D10378: Deprecate KFileItemList and introduce KFileItemListV2

[Mark Gaiser]

markg added a comment.


  @dfaure What's your preference here?
  I do "want" to work on this, no promises though. It could take a very long 
while ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10378

To: markg, dfaure
Cc: #frameworks, michaelh

D10054: Fix: View jumps when Scroll past end of document is enabled

[Dominik Haumann]

dhaumann added a comment.


  Question is: what happens in the vi test? Did we really introduce a 
regression or is the test wrong?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10054

To: dhaumann, cullmann
Cc: rikmills, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, 
sars, dhaumann

D10437: Limit the use of file.so for privilege operation to one application

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  @dfaure I was thinking about revoking authorization just before the idle 
slave is reassigned by klauncher. polkit-qt-1 provides 
`revokeTemporaryAuthorization` just for this purpose. We only need to implement 
it on KAuth's side. Then on slave's side we can do something like 
`KAuth::Action("org.kde.kio.file.exec").revoke()`. How does this sound?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10437

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: markg, anthonyfieroni, michaelh

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

[Eike Hein]

hein added a comment.


  (Side note: I like the idea of a KRun job - something like that could even be 
added without needing a KIO 6.)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10405

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

[Eike Hein]

hein updated this revision to Diff 27048.
hein added a comment.


  - Fall back to qWarning if !qGuiApp
  - Use QTimer::singleShot to work on older Qt

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10405?vs=27046=27048

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10405

AFFECTED FILES
  src/widgets/krun.cpp

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

[Eike Hein]

hein added a comment.


  There's a problem with my patch :(. QMetaObject::invokeMethod(context, 
functor) is new in Qt 5.10. I don't think we can depend on that yet, right?
  
  Ah, but QTimer::singleShot added an overload w/ context in 5.4 ..

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10405

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> krun.cpp:1616
>  // (or with a full path, if m_executable is absolute), and then in 
> the PATH.
> -if (!QFile(m_executable).exists() && 
> QStandardPaths::findExecutable(m_executable).isEmpty()) {
> -QEventLoopLocker locker;
> -KMessageBox::sorry(nullptr, i18n("Could not find the program 
> '%1'", m_executable));
> +if (!QFile(m_executable).exists() && 
> QStandardPaths::findExecutable(m_executable).isEmpty() && qGuiApp) {
> +QMetaObject::invokeMethod(qGuiApp, [=]() {

if (qGuiApp) { your code } else { qWarning }
so we don't eat a possible error message completely.

Looks OK otherwise.

[we have KDialogJobUiDelegate::showErrorMessage which implements a mesagebox 
queue, but that goes back to the issue of not having a job or a uidelegate in 
the first place]
[Every 5 years I'm thinking KRun should be a KJob, we just found another reason 
why...]

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10405

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

[Eike Hein]

hein retitled this revision from "Don't proceed in runCommandInternal if the 
executable doesn't exit" to "Stuff the "Couldn't find executable" message box 
into a queued lambda".
hein edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10405

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

[Eike Hein]

hein updated this revision to Diff 27046.
hein added a comment.


  New approach.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10405?vs=26821=27046

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10405

AFFECTED FILES
  src/widgets/krun.cpp

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

[Eike Hein]

hein added a comment.


  It's totally conceivable for e.g. a KPart or a Plasma plugin to open a 
QWidget-based window where the KMessageBox is appropriate, and if there's only 
a global interface instance and Plasma overrides it to hide all message boxes 
it's going to break KIO users in plugins. So I don't think going to a single 
global is good enough, it would have to be able to set more narrowly. This also 
bubbles up actually - the KRun calls we're talking about are in libtaskmanager 
which is technically meant to be UI-agnostic, so it'd have to also expose some 
way to set the interface instance. I agree all of this is in theory good (we 
need to make KIO more toolkit-agnostic - I have another giant patch sitting 
around that's almost-unfinishable that adds QWindow support to some APIs that 
currently only accept QWidgets I don't even have), but I think it's KIO 6 
material and not the quick fix I'm looking for.
  
  I found a cludge that's ugly but works to fix the crash - I'll update this in 
a moment to see how much you hate it. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10405

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh

D7849: Fix the tray icon scaling on HiDPI screens

[Alexander Potashev]

aspotashev added a comment.


  related bug report: https://bugs.kde.org/show_bug.cgi?id=360333

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D7849

To: pgkos, #plasma
Cc: aspotashev, ngraham, anthonyfieroni, broulik, #frameworks, davidedmundson, 
plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

[David Faure]

dfaure added a comment.


  Which plugins?
  
  This stuff is for the application to decide how it wants to handle user 
interactions like the rename dialog, the skip dialog, the confirm-deletion 
dialog, and messageboxes.
  KIOWidgets provides a default implementation (with modal dialogs), but it can 
be overriden by the app if it wants to do this differently.
  This sounds like something Plasma might want to do, if it wants to avoid 
modal dialogs (although I'm not sure what it could do instead, since these 
methods return what the user selected).
  OK if the real need is for this interface to be async, that's more work 
indeed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10405

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

[Eike Hein]

hein added a comment.


  There's a Job::setUiDelegateExtension though in addition to 
KIO::setDefaultJobUiDelegateExtension. A global would wreak havoc with stuff 
like plugins, no?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10405

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

[David Faure]

dfaure added a comment.


  What? no no, KIO::defaultJobUiDelegateExtension()->requestMessageBox() is a 
kind of singleton, no refactoring needed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10405

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

[Eike Hein]

hein added a comment.


  Thanks for the solution for sure, but - it requires writing a million lines 
of boilerplate, extensively refactoring KRun and adding reams of new overloads 
to its API (there would need to be some way to pass an instance of that 
interface to all these - not internal - statics). It's more than I have 
time/energy for currently and I'm not really sure it's viable without a KIO6. I 
have another idea, though, let me see if it's viable ...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10405

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh

KDE CI: Frameworks knewstuff kf5-qt5 SUSEQt5.7 - Build # 38 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20SUSEQt5.7/38/
 Project:
Frameworks knewstuff kf5-qt5 SUSEQt5.7
 Date of build:
Tue, 13 Feb 2018 09:40:21 +
 Build duration:
3 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)17%
(12/72)17%
(12/72)16%
(921/5879)13%
(516/3850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(92/92)52%
(57/110)autotests.kmoretools50%
(1/2)50%
(1/2)73%
(204/281)39%
(131/338)src22%
(2/9)22%
(2/9)2%
(23/961)0%
(0/382)src.attica0%
(0/2)0%
(0/2)0%
(0/286)0%
(0/241)src.core18%
(4/22)18%
(4/22)11%
(188/1739)9%
(130/1399)src.core.jobs0%
(0/6)0%
(0/6)0%
(0/191)0%
(0/92)src.kmoretools60%
(3/5)60%
(3/5)48%
(414/867)35%
(198/572)src.qtquick0%
(0/6)0%
(0/6)0%
(0/278)0%
(0/90)src.staticxml0%
(0/2)0%
(0/2)0%
(0/158)0%
(0/138)src.ui0%
(0/11)0%
(0/11)0%
(0/749)0%
(0/340)src.upload0%
(0/2)0%
(0/2)0%
(0/122)0%
(0/86)tests0%
(0/2)0%
(0/2)0%
(0/32)0%
(0/20)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/123)0%
(0/42)

KDE CI: Frameworks knewstuff kf5-qt5 SUSEQt5.7 - Build # 37 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20SUSEQt5.7/37/
 Project:
Frameworks knewstuff kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 12 Feb 2018 04:15:55 +
 Build duration:
1 day 5 hr and counting
   CONSOLE OUTPUT
  [...truncated 201.44 KB...]/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/EWIEGA46WW/moc_security.cpp:106:19: warning: ‘Security’ is deprecated [-Wdeprecated-declarations] Security *_t = static_cast(_o);   ^~In file included from /home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/EWIEGA46WW/moc_security.cpp:9:0, from /home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/mocs_compilation.cpp:18:/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/EWIEGA46WW/../../../../../src/core/security.h:45:46: note: declared here class Q_DECL_DEPRECATED KNEWSTUFFCORE_EXPORT Security : public QObject  ^~~~In file included from /home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/mocs_compilation.cpp:18:0:/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/EWIEGA46WW/moc_security.cpp:106:45: warning: ‘Security’ is deprecated [-Wdeprecated-declarations] Security *_t = static_cast(_o); ^In file included from /home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/EWIEGA46WW/moc_security.cpp:9:0, from /home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/mocs_compilation.cpp:18:/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/EWIEGA46WW/../../../../../src/core/security.h:45:46: note: declared here class Q_DECL_DEPRECATED KNEWSTUFFCORE_EXPORT Security : public QObject  ^~~~In file included from /home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/mocs_compilation.cpp:18:0:/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/EWIEGA46WW/moc_security.cpp: In member function ‘virtual void* KNSCore::Security::qt_metacast(const char*)’:/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/EWIEGA46WW/moc_security.cpp:170:55: warning: ‘Security’ is deprecated [-Wdeprecated-declarations] return static_cast(const_cast< Security*>(this));   ^In file included from /home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/EWIEGA46WW/moc_security.cpp:9:0, from /home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/mocs_compilation.cpp:18:/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/EWIEGA46WW/../../../../../src/core/security.h:45:46: note: declared here class Q_DECL_DEPRECATED KNEWSTUFFCORE_EXPORT Security : public QObject  ^~~~In file included from /home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/mocs_compilation.cpp:18:0:/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/EWIEGA46WW/moc_security.cpp: In member function ‘void KNSCore::Security::signalInformation(const QString&) const’:/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/EWIEGA46WW/moc_security.cpp:209:57: warning: ‘Security’ is deprecated [-Wdeprecated-declarations] QMetaObject::activate(const_cast< KNSCore::Security *>(this), , 2, _a); ^In file included from /home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/EWIEGA46WW/moc_security.cpp:9:0, from /home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/mocs_compilation.cpp:18:/home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/EWIEGA46WW/../../../../../src/core/security.h:45:46: note: declared here class Q_DECL_DEPRECATED KNEWSTUFFCORE_EXPORT Security : public QObject  ^~~~In file included from /home/jenkins/workspace/Frameworks knewstuff kf5-qt5 SUSEQt5.7/build/src/core/KF5NewStuffCore_autogen/mocs_compilation.cpp:18:0:/home/jenkins/workspace/Frameworks 

D10437: Limit the use of file.so for privilege operation to one application

[David Faure]

dfaure added a comment.


  Sounds good, but the tricky part will be finding how to run some code in the 
(idle) slave at the right time. Maybe in SlaveBase::disconnectSlave() ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10437

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: markg, anthonyfieroni, michaelh

D10414: Add move semantics support to KIO::UDSEntry.

[David Faure]

dfaure added a comment.


  Yes.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10414

To: markg, dfaure
Cc: apol, #frameworks, michaelh

D10414: Add move semantics support to KIO::UDSEntry.

[Mark Gaiser]

markg added a comment.


  Ahh, will fix that when i get home.
  I missed the @since lines in KFileITem as well. Is it OK if i just add them 
outside of phabricator? They will get an "@since 5.43" i think.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10414

To: markg, dfaure
Cc: apol, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 113 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/113/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 13 Feb 2018 08:54:07 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 131 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/131/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Tue, 13 Feb 2018 08:54:07 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31490/59490)38%
(18479/48822)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8548/9096)48%
(5212/10759)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8339/14343)50%
(4872/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3873/7839)33%
(1634/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 133 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/133/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 13 Feb 2018 08:54:07 +
 Build duration:
9 min 38 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31491/59490)38%
(18483/48746)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8548/9096)48%
(5211/10759)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8330/14342)50%
(4865/9704)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3873/7839)33%
(1634/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

D9912: [KNewFileMenu] KDirNotify::emitFilesAdded after storedPut

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8b809b715f09: [KNewFileMenu] KDirNotify::emitFilesAdded 
after storedPut (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9912?vs=25446=27042

REVISION DETAIL
  https://phabricator.kde.org/D9912

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: broulik, dfaure, ngraham
Cc: ngraham, #frameworks, michaelh

D10464: Initialize m_actualGroup to NormalColorGroup

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10464

To: apol, #frameworks, dfaure
Cc: michaelh

D10414: Add move semantics support to KIO::UDSEntry.

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Sorry, just spotted one last typo (and two missing @since), feel free to push 
after fixing.

INLINE COMMENTS

> udsentrytest.cpp:231
> +{
> +// Create a temporaty file. Just to make a UDSEntry further down.
> +QTemporaryFile file;

Typo: tempora*r*y

> udsentry.h:94
> +/**
> + * Move constructor
> + */

@since 5.44

> udsentry.h:104
> +/**
> + * Move assignment
> + */

@since 5.44

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10414

To: markg, dfaure
Cc: apol, #frameworks, michaelh

D9912: [KNewFileMenu] KDirNotify::emitFilesAdded after storedPut

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9912

To: broulik, dfaure, ngraham
Cc: ngraham, #frameworks, michaelh