D10758: Use QLocale instead of QLocale::system

[Burkhard Lück]

lueck added a comment.


  using D10757 , D10758 
, and D10759 
 the bug reported in 
https://bugs.kde.org/show_bug.cgi?id=390623 is fixed for me, thanks a lot

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D10758

To: aacid
Cc: lueck, #frameworks, michaelh

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 25 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/25/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
 Date of build:
Fri, 23 Feb 2018 04:20:05 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report25%
(5/20)30%
(17/56)30%
(17/56)20%
(416/2096)20%
(248/1246)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)90%
(138/154)55%
(103/188)src100%
(8/8)100%
(8/8)66%
(197/299)47%
(110/235)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/141)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)55%
(29/53)63%
(30/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/121)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
(0/0)src.widgets100%
(2/2)100%
(2/2)88%
(43/49)50%
 

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

[Dmitri Ovodok]

dmitrio planned changes to this revision.
dmitrio added a comment.


  It seems that the proposed patch in its current state does not fully prevent 
possible problems with move operation (did not catch any problems while 
testing, but looking at the code again I don't think that all is good with it). 
I suppose I am better to revise it again.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10663

To: dmitrio, #frameworks, dfaure
Cc: ngraham, anthonyfieroni, meven, #frameworks, michaelh

D10759: Use QLocale instead of QLocale::system

[Albert Astals Cid]

aacid created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
aacid requested review of this revision.

REVISION SUMMARY
  That makes it work if someone called QLocale::setDefault like kxmlgui does 
when setting an individual app language

TEST PLAN
  See https://bugs.kde.org/show_bug.cgi?id=390623

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10759

AFFECTED FILES
  modules/ECMQmLoader.cpp.in

To: aacid
Cc: #frameworks, #build_system, michaelh

D10758: Use QLocale instead of QLocale::system

[Albert Astals Cid]

aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
aacid requested review of this revision.

REVISION SUMMARY
  That makes it work if someone called QLocale::setDefault like kxmlgui does 
when setting an individual app language

TEST PLAN
  See https://bugs.kde.org/show_bug.cgi?id=390623

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10758

AFFECTED FILES
  src/klocalizedstring.cpp
  src/main.cpp

To: aacid
Cc: #frameworks, michaelh

D10757: Set QLocale too when we have a custom app language

[Albert Astals Cid]

aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
aacid requested review of this revision.

TEST PLAN
  See https://bugs.kde.org/show_bug.cgi?id=390623

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10757

AFFECTED FILES
  src/kswitchlanguagedialog_p.cpp

To: aacid
Cc: #frameworks, michaelh

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/53/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 22 Feb 2018 22:14:49 +
 Build duration:
6 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 37 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/37/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 22 Feb 2018 22:14:49 +
 Build duration:
5 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 48 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/48/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
 Date of build:
Thu, 22 Feb 2018 22:14:48 +
 Build duration:
3 min 40 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest

D10724: Help automoc to find metadata JSON files referenced in the code

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:7d642aec3a89: Help automoc to find metadata JSON files 
referenced in the code (authored by kossebau).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10724?vs=27722&id=27820

REVISION DETAIL
  https://phabricator.kde.org/D10724

AFFECTED FILES
  CMakeLists.txt
  KF5CoreAddonsConfig.cmake.in

To: kossebau, #frameworks, #build_system, apol
Cc: michaelh

D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file

[Friedrich W . H . Kossebau]

kossebau added a comment.


  @apol So +1 on this for pushing? (sorry for possibly confusing you with all 
the many related review requests :) )

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10665

To: kossebau, #frameworks, apol
Cc: michaelh

D10365: New icon for Elisa music player

[Matthieu Gallien]

mgallien added a comment.


  In D10365#206602 , @mgallien wrote:
  
  > In D10365#205750 , @andreask 
wrote:
  >
  > > can we get it now to master?
  > >
  > > @paullesur is hopefully interested in other icon's too.
  >
  >
  > @paullesur do you have a KDE contributor account ? If not, I cannot push 
due to life events pushing me away from keyboard.
  
  
  @paullesur ping ?

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien
Cc: mmustac, mgallien, januz, astippich, andreask, andreaska, ltoscano, 
ngraham, #frameworks, jussiv, paullesur, michaelh, ognarb, kmf

D10749: [RFC] Add ECMSetupQtPluginMacroNames

[Friedrich W . H . Kossebau]

kossebau edited the summary of this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D10749

To: kossebau, #build_system, #frameworks
Cc: michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/45/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 22 Feb 2018 17:42:37 +
 Build duration:
6 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 72 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/72/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Thu, 22 Feb 2018 17:42:37 +
 Build duration:
6 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3557/13335)19%
(1977/10549)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(607/1138)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2225)7%
(101/1488)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2917)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(317/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(553/2011)17%
(306/1755)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 69 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/69/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 22 Feb 2018 17:42:37 +
 Build duration:
6 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3558/13339)19%
(1978/10549)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(607/1138)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2229)7%
(102/1492)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(317/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(553/2011)17%
(306/1755)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
  

D10722: other preload microoptimizations

[Marco Martin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:79fb4ebfa77f: other preload microoptimizations (authored 
by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10722?vs=27798&id=27806

REVISION DETAIL
  https://phabricator.kde.org/D10722

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml

To: mart, #plasma, davidedmundson, broulik
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10749: [RFC] Add ECMSetupQtPluginMacroNames

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: Build System, Frameworks.
Restricted Application added projects: Frameworks, Build System.
kossebau requested review of this revision.

REVISION SUMMARY
  This macro should help with setting up all the boilerplate CMake code needed
  to instruct automoc about the custom C++ macros used to define Qt-style
  plugin class instances.
  
  Open questions:
  A) names of macro and arguments okay?
  B) other/similar/related use cases which should be covered?
  C) how to design argument passing for all the arg1, arg2, arg3,
  
currrent approach sane or how to suppotr someone needing some arg5?
  
  This new macro targets ECM 5.45 in April, ideally committed right after
  5.44 being tagged.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  addECMSetupQtPluginMacroNames

REVISION DETAIL
  https://phabricator.kde.org/D10749

AFFECTED FILES
  docs/module/ECMSetupQtPluginMacroNames.rst
  modules/ECMSetupQtPluginMacroNames.cmake

To: kossebau, #build_system, #frameworks
Cc: michaelh

D10722: other preload microoptimizations

[Kai Uwe Broulik]

broulik accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10722

To: mart, #plasma, davidedmundson, broulik
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10722: other preload microoptimizations

[Marco Martin]

mart updated this revision to Diff 27798.
mart added a comment.


  - err forgot typeof

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10722?vs=27797&id=27798

BRANCH
  arcpatch-D10722

REVISION DETAIL
  https://phabricator.kde.org/D10722

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml

To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10722: other preload microoptimizations

[Marco Martin]

mart updated this revision to Diff 27797.
mart added a comment.


  - fix typo

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10722?vs=27796&id=27797

BRANCH
  arcpatch-D10722

REVISION DETAIL
  https://phabricator.kde.org/D10722

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml

To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10722: other preload microoptimizations

[Marco Martin]

mart updated this revision to Diff 27796.
mart added a comment.


  - check for function

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10722?vs=27795&id=27796

BRANCH
  arcpatch-D10722

REVISION DETAIL
  https://phabricator.kde.org/D10722

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml

To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10722: other preload microoptimizations

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in svgitem.cpp:50
> > when the component is complete, in many cases i guessthe properties would 
> > all be already set?
> 
> We know for definitely they will be already set.
> 
> I don't understand what problem you think this is solving.

i was probably just confused reading hotspot reports with and without...
i think all this part can be ignored, i want to leave just the part about 
preloading of lists

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10722

To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10722: other preload microoptimizations

[Marco Martin]

mart updated this revision to Diff 27795.
mart added a comment.


  - Revert most of it
  - only leave the forcelayout part

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10722?vs=27707&id=27795

BRANCH
  arcpatch-D10722

REVISION DETAIL
  https://phabricator.kde.org/D10722

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml

To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 71 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/71/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Thu, 22 Feb 2018 16:24:01 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3559/13336)19%
(1978/10549)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2225)7%
(101/1488)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2917)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(553/2011)17%
(306/1755)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
  

D10722: other preload microoptimizations

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> mart wrote in svgitem.cpp:50
> when the component is complete, in many cases i guessthe properties would all 
> be already set? (could add a check on that) could even be worth directly a 
> loadPixmap, like an immediate updatePolish() there

> when the component is complete, in many cases i guessthe properties would all 
> be already set?

We know for definitely they will be already set.

I don't understand what problem you think this is solving.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10722

To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/44/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 22 Feb 2018 16:24:01 +
 Build duration:
7 min 21 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 68 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/68/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 22 Feb 2018 16:24:01 +
 Build duration:
6 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3558/13339)19%
(1978/10549)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(607/1138)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2229)7%
(102/1492)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(317/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(553/2011)17%
(306/1755)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
  

D10748: drop the setting of c++0x

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:11086bb7913f: drop the setting of c++0x (authored by 
mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10748?vs=27790&id=27793

REVISION DETAIL
  https://phabricator.kde.org/D10748

AFFECTED FILES
  CMakeLists.txt

To: mart, #plasma, kossebau
Cc: kossebau, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

[Mark Gaiser]

markg added a comment.


  I unfortunately have no clue how to answer your questions.

INLINE COMMENTS

> kcoredirlister.cpp:825-829
> +// If take remove the element from the list.
> +if (take) {
> +dirItem->lstItems.erase(it);
> +}
> +return retKFileItem;

Hmm, this looks weird to me.
Sure, it works. "KFileItem retKFileItem = *it;" makes a copy.

A more efficient way (but requires you to change the lists this is backed by to 
a std::vector) is to:

1. Take the element out of the vector. Something like "KFileItem item = 
std::move(*it);
2. Now the vector would be in a valid state but with one invalid object (will 
post a problem if you iterate over it later on) so you have to remove that 
element from the vector like you did.

I'm not sure if the benefits of this justify the path of changing the list 
(dirItem->lstItems) to a std::vector, if possible at all.
That's up to you :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10742

To: jtamate, #frameworks, dfaure
Cc: markg, michaelh

D10748: drop the setting of c++0x

[Friedrich W . H . Kossebau]

kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  Builds here as before as well.
  
  Reducing duplicated flags in the compile commands for me from
  `-std=c++0x -std=c++0x -std=c++0x -std=gnu++11`
  to
   `-std=c++0x -std=c++0x -std=gnu++11` :)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/cpp0x

REVISION DETAIL
  https://phabricator.kde.org/D10748

To: mart, #plasma, kossebau
Cc: kossebau, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10671: [UDisks] Fix auto-mount regression

[Nathaniel Graham]

ngraham added a comment.


  Can this land?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10671

To: dkhlestkov, #frameworks, broulik
Cc: ngraham, sefaeyeoglu, rikmills, #frameworks, michaelh

D10747: Implement zwp_linux_dmabuf_v1

[Fredrik Höglund]

fredrik added inline comments.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

INLINE COMMENTS

> linuxdmabuf_v1_interface.h:39
> +
> +namespace LinuxDmabuf
> +{

Do we want these nested namespaces? We could have LinuxDmabufFlags, 
LinuxDmabufBuffer etc. instead.

> linuxdmabuf_v1_interface.h:65
> + */
> +class Buffer {
> +public:

Should the Buffer class use a d-pointer?

> linuxdmabuf_v1_interface.h:107
> + */
> +class Bridge {
> +public:

Is this the solution we want for interfacing with the compositor?

My preference would be to use std::function callbacks, with setters in 
LinuxDmabufUnstableV1Interface. Setting up the interface could then look like 
this:

  m_linuxDmabuf = m_display->createLinuxDmabufInterface(m_display);
  m_linuxDmabuf->setQuerySupportedFormats([]{ return 
Compositor::self()->scene()->supportedDrmFormats(); });
  ...
  m_linuxDmabuf->create();

This can also be extended without breaking binary compatibility. But I don't 
think we can use std::function in frameworks. There are also BIC issues when 
mixing different STL implementations, which we may or may not care about.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10747

To: fredrik, #kwin, #plasma, graesslin, davidedmundson, mart
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, schernikov, alexeymin, eliasp, hein

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/34/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 22 Feb 2018 14:53:00 +
 Build duration:
6 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/35/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
 Date of build:
Thu, 22 Feb 2018 14:53:00 +
 Build duration:
5 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

D10747: Implement zwp_linux_dmabuf_v1

[Marco Martin]

mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  +1 on my machine opengl apps seems to work well on wayland (after the first 
revision in which they were flipped upside down, now they are ok)
  would need a final ship it by someone more familiar with that area tough :)

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10747

To: fredrik, #kwin, #plasma, graesslin, davidedmundson, mart
Cc: plasma-devel, #frameworks, schernikov, michaelh, ZrenBot, alexeymin, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D10662: indexerconfig: Describe some functions

[Michael Heidelbach]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:70162de9741e: indexerconfig: Describe some functions 
(authored by michaelh).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10662?vs=27764&id=27791#toc

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10662?vs=27764&id=27791

REVISION DETAIL
  https://phabricator.kde.org/D10662

AFFECTED FILES
  src/file/fileindexerconfig.h
  src/lib/indexerconfig.h

To: michaelh, #baloo, lbeltrame
Cc: lbeltrame, adridg, #frameworks, ashaposhnikov, michaelh, spoorun, 
nicolasfella, alexeymin

D10748: drop the setting of c++0x

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  this is already done by KDEFrameworkCompilerSettings so it's just duplicated 
now

TEST PLAN
  still builds and runs

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/cpp0x

REVISION DETAIL
  https://phabricator.kde.org/D10748

AFFECTED FILES
  CMakeLists.txt

To: mart, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10719: Highlighting for OpenSCAD

[Nathaniel Graham]

ngraham added a comment.


  In case anyone wants a more complex test file, I'm attaching one (written by 
me, MIT license):
  
  F5725381: X-carriagestruder.scad 

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10719

To: julianstirling, dhaumann
Cc: dhaumann, ngraham, #frameworks, michaelh

D10747: Implement zwp_linux_dmabuf_v1

[Fredrik Höglund]

fredrik created this revision.
fredrik added reviewers: KWin, Plasma, graesslin, davidedmundson, mart.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
fredrik requested review of this revision.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

REVISION SUMMARY
  This interface provides a way for clients to create generic dmabuf-based 
wl_buffers.

TEST PLAN
  I asked Marco to test it with a driver that supports modifiers, and he says 
that it works.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10747

AFFECTED FILES
  src/client/protocols/linux-dmabuf-unstable-v1.xml
  src/server/CMakeLists.txt
  src/server/buffer_interface.cpp
  src/server/buffer_interface.h
  src/server/display.cpp
  src/server/display.h
  src/server/drm_fourcc.h
  src/server/linuxdmabuf_v1_interface.cpp
  src/server/linuxdmabuf_v1_interface.h

To: fredrik, #kwin, #plasma, graesslin, davidedmundson, mart
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/33/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 22 Feb 2018 14:23:00 +
 Build duration:
4 min 56 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/34/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
 Date of build:
Thu, 22 Feb 2018 14:23:00 +
 Build duration:
3 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

D10722: other preload microoptimizations

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in svgitem.cpp:50
> I don't see how this makes any difference.
> 
> Every setSomeProperty already calls scheduleImageUpdate regardless of whether 
> we're complete or not.
> and if you don't have any properties set, then there's nothing to polish.

when the component is complete, in many cases i guessthe properties would all 
be already set? (could add a check on that) could even be worth directly a 
loadPixmap, like an immediate updatePolish() there

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10722

To: mart, #plasma
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10661: indexerconfig: Expose canBeSearched function

[Michael Heidelbach]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:67a84fe99a03: indexerconfig: Expose canBeSearched 
function (authored by michaelh).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10661?vs=27667&id=27788

REVISION DETAIL
  https://phabricator.kde.org/D10661

AFFECTED FILES
  src/lib/indexerconfig.cpp
  src/lib/indexerconfig.h

To: michaelh, #baloo, #dolphin, dfaure, lbeltrame
Cc: lbeltrame, adridg, #frameworks, ashaposhnikov, michaelh, spoorun, 
nicolasfella, alexeymin

D10744: Use correct directory to lookup trigrams in windows build dir

[Hannah von Reth]

vonreth updated this revision to Diff 2.
vonreth added a comment.


  Build fix

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10744?vs=27776&id=2

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10744

AFFECTED FILES
  src/core/guesslanguage.cpp
  src/plugins/hunspell/CMakeLists.txt
  src/plugins/hunspell/hunspellclient.cpp
  src/plugins/hunspell/hunspelldict.h

To: vonreth, mlaurent, dfaure, leinir
Cc: #frameworks, michaelh

D10744: Use correct directory to lookup trigrams in windows build dir

[Hannah von Reth]

vonreth added reviewers: mlaurent, dfaure, leinir.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D10744

To: vonreth, mlaurent, dfaure, leinir
Cc: #frameworks, michaelh

D10744: Use correct directory to lookup trigrams in windows build dir

[Hannah von Reth]

vonreth created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
vonreth requested review of this revision.

REVISION SUMMARY
  Properly lookup system installed dictionaries
  
  Don't look for hunspell dictionaries in LibreOficce

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10744

AFFECTED FILES
  src/core/guesslanguage.cpp
  src/plugins/hunspell/CMakeLists.txt
  src/plugins/hunspell/hunspellclient.cpp
  src/plugins/hunspell/hunspelldict.h

To: vonreth
Cc: #frameworks, michaelh

D10743: Don't explicitly add install prefix to plugin search path

[Hannah von Reth]

vonreth created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
vonreth requested review of this revision.

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10743

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/loader.cpp

To: vonreth
Cc: #frameworks, michaelh

D10661: indexerconfig: Expose canBeSearched function

[Luca Beltrame]

lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.


  For what it's worth, LGTM .

REPOSITORY
  R293 Baloo

BRANCH
  expose_canbesearched (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10661

To: michaelh, #baloo, #dolphin, dfaure, lbeltrame
Cc: lbeltrame, adridg, #frameworks, ashaposhnikov, michaelh, spoorun, 
nicolasfella, alexeymin

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  This summary will change when the doubts are resolved (if they can be 
resolved!).
  
  Implement the first part of a TODO: get rid of the raw KFileItem pointers in 
KCoreDirListerCache
  
  I've added a way to remove the item from the lister in findByUrl, to be 
modified and, if needed, added back.
  
  Questions to be answered:
  
  - In findByUrl, the dirItem->rootItem should also be removed?
  - fileItem is get twice in slotFileRenamed. Is this patch removing the right 
fileitem?
  - Should the fileitem removed in slotFileRenamed be added back or is it added 
back in emitRefreshItem? If should be  added back, to which list?
  
  I know the patched code doesn't follow the original semantics because dolphin 
see duplicated entries while renaming takes place.

TEST PLAN
  findByUrl is slow, for example, renaming 50.000 small files, it has to go 
through a list of 50.000 items 50.000 times, so renaming that number of files 
takes more than an hour.
  This patch does not improve findByUrl performance, but allows future work on 
it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10742

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister_p.h

To: jtamate, #frameworks, dfaure
Cc: michaelh

D10739: Remove deprecated cmake code

[Hannah von Reth]

vonreth added inline comments.

INLINE COMMENTS

> apol wrote in CMakeLists.txt:20
> Then this also needs to go? Or just set it if the variable is defined?

That's how I understood the code, to allow to define a prebuild exe

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D10739

To: vonreth, kfunk, dfaure, vkrause, mlaurent
Cc: apol, #frameworks, michaelh

D10739: Remove deprecated cmake code

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> CMakeLists.txt:20
>  add_executable(KF5::parsetrigrams IMPORTED GLOBAL)
>  set_target_properties(KF5::parsetrigrams PROPERTIES IMPORTED_LOCATION 
> ${PARSETRIGRAMS_EXECUTABLE})
>  else()

Then this also needs to go? Or just set it if the variable is defined?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D10739

To: vonreth, kfunk, dfaure, vkrause, mlaurent
Cc: apol, #frameworks, michaelh

D10741: Use Locale::name() instead of Locale::bcp47Name()

[Hannah von Reth]

vonreth created this revision.
vonreth added reviewers: dfaure, mlaurent, kfunk, vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
vonreth requested review of this revision.

REVISION SUMMARY
  bcp47Name() is encoded like "en-US" the dictionary name on the other hand
  is "en_US" so lets use name().

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10741

AFFECTED FILES
  autotests/test_settings.cpp
  src/core/settings.cpp

To: vonreth, dfaure, mlaurent, kfunk, vkrause
Cc: #frameworks, michaelh

D10739: Remove deprecated cmake code

[Hannah von Reth]

vonreth added reviewers: kfunk, dfaure, vkrause, mlaurent.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D10739

To: vonreth, kfunk, dfaure, vkrause, mlaurent
Cc: #frameworks, michaelh

D10739: Remove deprecated cmake code

[Hannah von Reth]

vonreth created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
vonreth requested review of this revision.

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10739

AFFECTED FILES
  data/CMakeLists.txt

To: vonreth
Cc: #frameworks, michaelh

D10719: Highlighting for OpenSCAD

[Julian Stirling]

julianstirling updated this revision to Diff 27770.
julianstirling added a comment.


  Added the test file as requested and updated the license to MIT.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10719?vs=27698&id=27770

REVISION DETAIL
  https://phabricator.kde.org/D10719

AFFECTED FILES
  autotests/input/highlight.scad
  data/syntax/openscad.xml

To: julianstirling, dhaumann
Cc: dhaumann, ngraham, #frameworks, michaelh

D10732: Help automoc to find metadata JSON files referenced in the code

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Thanks for review.
  
  > Can't we reuse this same code from kcoreaddons? Maybe kcoreaddons can offer 
a macro that does this?
  
  As hinted in the commit message, plan is to have some ECM macro instead, but 
only for 5.45 in a month, to not hurry macro signature design. Soon up for 
discussion though.
  
  Current draft/working prototype results in code like the following for 
CMakeLists.txt (replacing the complete current code to set up things with 
CMAKE_AUTOMOC_MACRO_NAMES & :CMAKE_AUTOMOC_DEPEND_FILTERS):
  
include(ECMSetupQtPluginMacros)

ecm_setup_qtplugin_macros(
JSON_NONE
"K_EXPORT_PLASMA_SERVICE"
"K_EXPORT_PLASMA_APPLET"
"K_EXPORT_PLASMA_PACKAGE"
"K_EXPORT_PLASMA_APPLETSCRIPTENGINE"
"K_EXPORT_PLASMA_DATAENGINESCRIPTENGINE"
"K_EXPORT_PLASMA_DATAENGINE"
JSON_ARG2
"K_EXPORT_PLASMA_PACKAGE_WITH_JSON"
JSON_ARG3
"K_EXPORT_PLASMA_SERVICE_WITH_JSON"
"K_EXPORT_PLASMA_APPLET_WITH_JSON"
"K_EXPORT_PLASMA_APPLETSCRIPTENGINE_WITH_JSON"
"K_EXPORT_PLASMA_DATAENGINESCRIPTENGINE_WITH_JSON"
"K_EXPORT_PLASMA_CONTAINMENTACTIONS_WITH_JSON"
"K_EXPORT_PLASMA_DATAENGINE_WITH_JSON"
CONFIG_VARIABLE
 PACKAGE_SETUP_AUTOMOC_MACROS
)
  
  and in the KF5PlasmaConfig.cmake.in then just need some
  
@PACKAGE_SETUP_AUTOMOC_MACROS@
  
  The complete code copies as now in the patch are just a temporary solution by 
purpose, to already fix the issue, but without rushed new public API.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10732

To: kossebau, #frameworks, #build_system, apol
Cc: michaelh

D10662: indexerconfig: Describe some functions

[Michael Heidelbach]

michaelh updated this revision to Diff 27764.
michaelh added a comment.


  - Revert includes coding style

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10662?vs=27762&id=27764

BRANCH
  publicdescriptions (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10662

AFFECTED FILES
  src/file/fileindexerconfig.h
  src/lib/indexerconfig.h

To: michaelh, #baloo, lbeltrame
Cc: lbeltrame, adridg, #frameworks, ashaposhnikov, michaelh, spoorun, 
nicolasfella, alexeymin

D10662: indexerconfig: Describe some functions

[Luca Beltrame]

lbeltrame added inline comments.

INLINE COMMENTS

> fileindexerconfig.h:25
> +#include 
> +#include 
>  

I just noticed this. Can you do the #include changes as part of a separate 
commit?

REPOSITORY
  R293 Baloo

BRANCH
  publicdescriptions (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10662

To: michaelh, #baloo, lbeltrame
Cc: lbeltrame, adridg, #frameworks, ashaposhnikov, michaelh, spoorun, 
nicolasfella, alexeymin

D10662: indexerconfig: Describe some functions

[Michael Heidelbach]

michaelh marked an inline comment as done.

REPOSITORY
  R293 Baloo

BRANCH
  publicdescriptions (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10662

To: michaelh, #baloo, lbeltrame
Cc: lbeltrame, adridg, #frameworks, ashaposhnikov, michaelh, spoorun, 
nicolasfella, alexeymin

D10662: indexerconfig: Describe some functions

[Michael Heidelbach]

michaelh marked an inline comment as done.
michaelh added inline comments.

INLINE COMMENTS

> lbeltrame wrote in fileindexerconfig.h:50
> I'd put "index and analyze". Seems nitpicky, but reflects what Baloo does 
> (index first, extraction later).

To be really nitpicky it is index > analyze > index. :-)
And...
Wtr to method descriptions/manuals one cannot be nitpicky enough!

> lbeltrame wrote in fileindexerconfig.h:57
> "Descendant folders of an excluded folder can be added and they will be 
> indexed."

much better, thanks

REPOSITORY
  R293 Baloo

BRANCH
  publicdescriptions (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10662

To: michaelh, #baloo, lbeltrame
Cc: lbeltrame, adridg, #frameworks, ashaposhnikov, michaelh, spoorun, 
nicolasfella, alexeymin

D10662: indexerconfig: Describe some functions

[Michael Heidelbach]

michaelh updated this revision to Diff 27762.
michaelh marked an inline comment as done.
michaelh added a comment.


  - Refine descriptions more
  - Apply coding style to includes

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10662?vs=27673&id=27762

BRANCH
  publicdescriptions (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10662

AFFECTED FILES
  src/file/fileindexerconfig.h
  src/lib/indexerconfig.h

To: michaelh, #baloo, lbeltrame
Cc: lbeltrame, adridg, #frameworks, ashaposhnikov, michaelh, spoorun, 
nicolasfella, alexeymin

D10662: indexerconfig: Describe some functions

[Luca Beltrame]

lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.


  Looks OK to me with some changes (for readability).

INLINE COMMENTS

> fileindexerconfig.h:50
>  /**
> - * The folders to search for files to analyze. Cached and cleaned up.
> + * Folders to search for files to analyze and index.
> + * \return list of paths.

I'd put "index and analyze". Seems nitpicky, but reflects what Baloo does 
(index first, extraction later).

> fileindexerconfig.h:57
> + * Folders that are excluded from indexing.
> + * (It is possible to include descendants of an excluded folder again
> + * and they will be indexed.)

"Descendant folders of an excluded folder can be added and they will be 
indexed."

REPOSITORY
  R293 Baloo

BRANCH
  publicdescriptions (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10662

To: michaelh, #baloo, lbeltrame
Cc: lbeltrame, adridg, #frameworks, ashaposhnikov, michaelh, spoorun, 
nicolasfella, alexeymin