D10918: taglibextractor: Refactor for better readability

2018-02-28 Thread Matthieu Gallien 
mgallien added a comment.


  Thanks for your work.
  I would prefer to wait for D10803  to 
land before doing any big changes like that.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10918

To: michaelh, mgallien, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D10927: Apply fixes to simple clazy warnings

2018-02-28 Thread Fabian Kosmale 
fabiank retitled this revision from "Use const methods to prevent container 
from detaching

KHistoryComboBox: reserve list before populating it" to "Apply fixes to simple 
clazy warnings".
fabiank edited the summary of this revision.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D10927

To: fabiank
Cc: #frameworks, michaelh

KDE CI: Frameworks kpty kf5-qt5 SUSEQt5.9 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20SUSEQt5.9/1/
 Project:
Frameworks kpty kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 28 Feb 2018 19:50:51 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(8/8)100%
(8/8)78%
(449/576)52%
(131/251)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)99%
(116/117)52%
(47/90)src100%
(6/6)100%
(6/6)73%
(333/459)52%
(84/161)

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 - Build # 1 - Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.9/1/
 Project:
Frameworks kwindowsystem kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 28 Feb 2018 19:50:52 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindoweffectstest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(47/59)80%
(47/59)75%
(7191/9558)55%
(4098/7516)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests89%
(16/18)89%
(16/18)97%
(3078/3161)52%
(1758/3371)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src94%
(15/16)94%
(15/16)57%
(795/1395)46%
(344/747)src.platforms.wayland0%
(0/3)0%
(0/3)0%
(0/71)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3311/4642)60%
(1993/3342)tests0%
(0/5)0%
(0/5)0%
(0/279)0%
(0/50)

KDE CI: Frameworks kplotting kf5-qt5 SUSEQt5.9 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kplotting%20kf5-qt5%20SUSEQt5.9/1/
 Project:
Frameworks kplotting kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 28 Feb 2018 19:50:48 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)73%
(8/11)73%
(8/11)46%
(560/1206)22%
(164/730)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)100%
(234/234)50%
(107/214)examples0%
(0/3)0%
(0/3)0%
(0/116)0%
(0/13)src100%
(4/4)100%
(4/4)38%
(326/856)11%
(57/503)

KDE CI: Frameworks kcrash kf5-qt5 SUSEQt5.9 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20SUSEQt5.9/1/
 Project:
Frameworks kcrash kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 28 Feb 2018 19:50:50 +
 Build duration:
1 min 14 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(7/7)100%
(7/7)63%
(269/429)39%
(109/283)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)89%
(77/87)52%
(27/52)src100%
(4/4)100%
(4/4)56%
(192/342)35%
(82/231)

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 55 - Still Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/55/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 28 Feb 2018 18:10:27 +
 Build duration:
8 min 27 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D10902: Don't make Titles 20% transparent either

2018-02-28 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  opaque-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10902

To: ngraham, #plasma, mart
Cc: #frameworks, michaelh

KDE CI: Frameworks kholidays kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kholidays%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kholidays kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:07 +
 Build duration:
12 hr and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks kidletime kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kidletime%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kidletime kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:06 +
 Build duration:
12 hr and counting

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:07 +
 Build duration:
12 hr and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 22 test(s)Failed: TestSuite.kdelibs4configmigratortestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.krandomtest

D10918: taglibextractor: Refactor for better readability

2018-02-28 Thread Michael Heidelbach 
michaelh created this revision.
michaelh added reviewers: mgallien, Baloo, Frameworks.
michaelh added a project: Frameworks.
Restricted Application added a project: Baloo.
michaelh requested review of this revision.

REVISION SUMMARY
  - Use const where applicable

TEST PLAN
  make test

REPOSITORY
  R286 KFileMetaData

BRANCH
  taglibextractor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10918

AFFECTED FILES
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h

To: michaelh, mgallien, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

KDE CI: Frameworks kauth kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kauth%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kauth kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:07 +
 Build duration:
11 hr and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:06 +
 Build duration:
11 hr and counting

KDE CI: Frameworks krunner kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks krunner kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:06 +
 Build duration:
11 hr and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.dbusrunnertestFailed: TestSuite.runnercontexttest

KDE CI: Frameworks kjobwidgets kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kjobwidgets%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kjobwidgets kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:06 +
 Build duration:
11 hr and counting

KDE CI: Frameworks kpeople kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kpeople%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kpeople kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:06 +
 Build duration:
11 hr and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks threadweaver kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks threadweaver kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:07 +
 Build duration:
11 hr and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)

KDE CI: Frameworks knotifyconfig kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20knotifyconfig%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks knotifyconfig kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:06 +
 Build duration:
11 hr and counting

KDE CI: Frameworks kwallet kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwallet%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kwallet kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:06 +
 Build duration:
11 hr and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks oxygen-icons5 kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20oxygen-icons5%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks oxygen-icons5 kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
11 hr and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.dupe

KDE CI: Frameworks kdelibs4support kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kdelibs4support kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
11 hr and counting
   JUnit Tests
  Name: (root) Failed: 9 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kdatetimetestFailed: TestSuite.kdebug_unittestFailed: TestSuite.kdelibs4support-klocaletestFailed: TestSuite.klibloadertestFailed: TestSuite.kmimetypetestFailed: TestSuite.kstandarddirstestFailed: TestSuite.ktimezonestestFailed: TestSuite.kuniqueapptestFailed: TestSuite.kurltest

KDE CI: Frameworks kemoticons kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kemoticons kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:06 +
 Build duration:
10 hr and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks kplotting kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kplotting%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kplotting kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:06 +
 Build duration:
10 hr and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

KDE CI: Frameworks ki18n kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks ki18n kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:06 +
 Build duration:
10 hr and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks kservice kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kservice kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
10 hr and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.kmimeassociationstestFailed: TestSuite.kplugininfotestFailed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest

KDE CI: Frameworks kwindowsystem kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kwindowsystem kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
10 hr and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks kjs kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kjs%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kjs kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
10 hr and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
10 hr and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kmoretoolstest

KDE CI: Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
10 hr and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 147 - Still Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/147/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Wed, 28 Feb 2018 12:50:07 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31540/59609)38%
(18525/48954)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8565/9113)48%
(5231/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8342/14346)50%
(4874/9722)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)50%
(3897/7872)33%
(1644/4946)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(512/974)41%
(413/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks sonnet kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks sonnet kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
10 hr and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks frameworkintegration kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20frameworkintegration%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks frameworkintegration kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
10 hr and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 149 - Still Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/149/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 28 Feb 2018 12:50:08 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31559/59610)38%
(18520/48878)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8565/9113)48%
(5235/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8367/14346)50%
(4880/9718)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)50%
(3897/7872)33%
(1644/4946)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks purpose kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
10 hr and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 129 - Still Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/129/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 28 Feb 2018 12:50:08 +
 Build duration:
9 min 42 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirmodeltest

D10684: [Drop Job] Create proper trash file on linking

2018-02-28 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c600f0cb823e: [Drop Job] Create proper trash file on 
linking (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10684?vs=27617=28261

REVISION DETAIL
  https://phabricator.kde.org/D10684

AFFECTED FILES
  src/core/copyjob.cpp

To: broulik, #frameworks, #plasma, hein
Cc: plasma-devel, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Frameworks kxmlgui kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kxmlgui kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
10 hr and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.kxmlgui_unittest

KDE CI: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
10 hr and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 8 test(s)

KDE CI: Frameworks kxmlrpcclient kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kxmlrpcclient%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kxmlrpcclient kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
10 hr and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
9 hr 56 min and counting
   JUnit Tests
  Name: (root) Failed: 26 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: TestSuite.kiocore-deletejobtestFailed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kfileitemtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-ktcpsockettestFailed: TestSuite.kiocore-mkpathjobtestFailed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiofilewidgets-kfilecustomdialogtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiofilewidgets-knewfilemenutestFailed: TestSuite.kiofilewidgets-kurlnavigatortestFailed: TestSuite.kiogui-favicontestFailed: TestSuite.kiowidgets-accessmanagertestFailed: TestSuite.kiowidgets-accessmanagertest-qnamFailed: TestSuite.kiowidgets-dropjobtestFailed: TestSuite.kiowidgets-fileundomanagertestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.kiowidgets-kdynamicjobtrackernowidgetstestFailed: TestSuite.kiowidgets-krununittestFailed: TestSuite.kiowidgets-kurifiltertestFailed: TestSuite.kiowidgets-kurlcompletiontestFailed: TestSuite.kiowidgets-kurlcompletiontest-nowaitFailed: TestSuite.kpasswdservertest

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 53 - Still Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/53/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 28 Feb 2018 11:50:01 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 77 - Still Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/77/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 28 Feb 2018 11:50:01 +
 Build duration:
7 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13342)19%
(1979/10569)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2229)7%
(102/1492)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(553/2013)17%
(306/1775)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 80 - Still Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/80/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Wed, 28 Feb 2018 11:50:01 +
 Build duration:
7 min 36 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3559/13338)19%
(1978/10569)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2225)7%
(101/1488)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2917)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(553/2013)17%
(306/1775)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

D10870: [PackageUrlInterceptor] Don't rewrite "inline"

2018-02-28 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:4dda85971f1b: [PackageUrlInterceptor] Dont rewrite 
inline (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10870?vs=28118=28258

REVISION DETAIL
  https://phabricator.kde.org/D10870

AFFECTED FILES
  src/plasmaquick/packageurlinterceptor.cpp

To: broulik, #plasma, hein
Cc: #frameworks, michaelh

KDE CI: Frameworks kinit kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kinit%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kinit kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
8 hr 21 min and counting

KDE CI: Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
8 hr 19 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:06 +
 Build duration:
8 hr 18 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks attica kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks attica kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:06 +
 Build duration:
8 hr 17 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks kded kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kded%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kded kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
8 hr 15 min and counting

KDE CI: Frameworks kunitconversion kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kunitconversion kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:06 +
 Build duration:
8 hr 14 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kbookmarks%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
8 hr 12 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.kbookmarktest

KDE CI: Frameworks kparts kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kparts%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kparts kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
7 hr 59 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks solid kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20solid%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks solid kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
7 hr 54 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.fakehardwaretestFailed: TestSuite.solidhwtest

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

2018-02-28 Thread Mélanie Chauvel 
achauvel added a comment.


  > FWIW, Breeze shadows can now be turned off entirely (System Settings > 
Application Style > Window Decorations > Breeze > Click on the little Settings 
button in the corner > Shadows > Size: None), so the only thing this really 
adds is opaque backgrounds.
  
  You’re mistaken: this disable shadows only for window decorations. My themes 
disable shadows for panel (and widgets), Krunner and Kwin’s task switcher.
  
  > Not sure it's worth it IMHO. Maybe instead we should let people turn it off 
in Breeze without modifications.
  
  Sure, you can add an option to use fallback resources; my solution is dead 
simple but a generic solution is better. I just don’t happen to have the time 
or knowledge to do it.
  
  Also note that I use `kquitapp5 plasmashell && plasmashell` after applying my 
theme in order to make shadows disapear for Plasma; it works instantly for KWin.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10910

To: achauvel
Cc: ngraham, #frameworks, michaelh

KDE CI: Frameworks khtml kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20khtml%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks khtml kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:06 +
 Build duration:
7 hr 31 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
7 hr 23 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable

D10856: [WIP] Make tests compile, except one

2018-02-28 Thread Michael Heidelbach 
michaelh retitled this revision from "Make tests compile, except one" to "[WIP] 
Make tests compile, except one".
Restricted Application added a project: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10856

To: michaelh, adridg, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D10829: [WIP] Use DocumentId class

2018-02-28 Thread Michael Heidelbach 
michaelh retitled this revision from "Use DocumentId class" to "[WIP] Use 
DocumentId class".

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10829

To: michaelh, adridg, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, michaelh, spoorun, nicolasfella

D10825: [WIP] Introduce aliases DocId, DeviceId and Inode

2018-02-28 Thread Michael Heidelbach 
michaelh retitled this revision from "Introduce aliases DocId, DeviceId and 
Inode" to "[WIP] Introduce aliases DocId, DeviceId and Inode".

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10825

To: michaelh, adridg, #baloo, #frameworks
Cc: ngraham, alexeymin, ashaposhnikov, michaelh, spoorun, nicolasfella

KDE CI: Frameworks kdesignerplugin kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kdesignerplugin%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kdesignerplugin kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
7 hr 19 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

D10826: [WIP] Introduce DocumentId class

2018-02-28 Thread Michael Heidelbach 
michaelh retitled this revision from "Introduce DocumentId class" to "[WIP] 
Introduce DocumentId class".

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10826

To: michaelh, adridg, #baloo, #frameworks
Cc: anthonyfieroni, svuorela, ashaposhnikov, michaelh, spoorun, nicolasfella, 
alexeymin

KDE CI: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
7 hr 15 min and counting
   JUnit Tests
  Name: (root) Failed: 8 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.coronatestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetestFailed: TestSuite.plasma-themetest

KDE CI: Frameworks kjsembed kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kjsembed%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kjsembed kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
6 hr 57 min and counting

KDE CI: Frameworks kpackage kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kpackage kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
6 hr 56 min and counting
   JUnit Tests
  Name: (root) Failed: 8 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-plasmoidpackagetestFailed: TestSuite.plasma-querytestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testjsonmetadatapackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackagesdep-appstreamFailed: TestSuite.testpackagesdepinvalid-appstream

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
6 hr 53 min and counting

KDE CI: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
6 hr 51 min and counting
   JUnit Tests
  Name: (root) Failed: 9 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.kateindenttest_testCppstyleFailed: TestSuite.kateindenttest_testCstyleFailed: TestSuite.kateindenttest_testRubyFailed: TestSuite.katetextbuffertestFailed: TestSuite.kateview_testFailed: TestSuite.messagetestFailed: TestSuite.movingrange_testFailed: TestSuite.vimode_emulatedcommandbarFailed: TestSuite.vimode_keys

KDE CI: Frameworks kguiaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kguiaddons%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kguiaddons kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
6 hr 9 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks kiconthemes kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kiconthemes kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
6 hr 8 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: TestSuite.kiconloader_unittest

KDE CI: Frameworks kcmutils kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kcmutils%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kcmutils kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
6 hr 6 min and counting

KDE CI: Frameworks kdewebkit kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kdewebkit%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kdewebkit kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:06 +
 Build duration:
6 hr 3 min and counting

KDE CI: Frameworks karchive kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks karchive kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
6 hr 0 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks kactivities kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kactivities%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kactivities kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
5 hr 58 min and counting

KDE CI: Frameworks kitemviews kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kitemviews%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kitemviews kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
5 hr 44 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Unstable!

2018-02-28 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
5 hr 43 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: TestSuite.kcolorbuttontestFailed: TestSuite.kdatecomboboxtestFailed: TestSuite.kpasswordlineedittestFailed: TestSuite.ksplittercollapserbuttontest

KDE CI: Frameworks kross kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kross%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kross kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
5 hr 31 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks kconfigwidgets kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kconfigwidgets%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kconfigwidgets kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:06 +
 Build duration:
5 hr 29 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks kmediaplayer kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kmediaplayer%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kmediaplayer kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:05 +
 Build duration:
5 hr 27 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks kdbusaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 1 - Successful!

2018-02-28 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kdbusaddons%20kf5-qt5%20WindowsMSVCQt5.10/1/
 Project:
Frameworks kdbusaddons kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 28 Feb 2018 02:37:06 +
 Build duration:
5 hr 25 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)