D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, hein.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  `KProtocolInfoFactory::findProtocol` clears its cache when requested an 
unknown protocol in the hope of finding it due to an outdated cache. However, 
when the cache had just been created, there's no point in clearing and 
recreating it right away

TEST PLAN
  Mitigates the effects of D9094  somewhat 
(takes 4.5ms instead of 9ms on startup for me now)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11107

AFFECTED FILES
  src/core/kprotocolinfofactory.cpp

To: broulik, #frameworks, hein
Cc: michaelh

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 14 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/14/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 07 Mar 2018 05:40:48 +
 Build duration:
1 hr 36 min and counting
   JUnit Tests
  Name: (root) Failed: 27 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: TestSuite.kiocore-deletejobtestFailed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kfileitemtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-ktcpsockettestFailed: TestSuite.kiocore-mkpathjobtestFailed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiofilewidgets-kfilecustomdialogtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiofilewidgets-knewfilemenutestFailed: TestSuite.kiofilewidgets-kurlnavigatortestFailed: TestSuite.kiowidgets-accessmanagertestFailed: TestSuite.kiowidgets-accessmanagertest-qnamFailed: TestSuite.kiowidgets-clipboardupdatertestFailed: TestSuite.kiowidgets-dropjobtestFailed: TestSuite.kiowidgets-fileundomanagertestFailed: TestSuite.kiowidgets-jobguitestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.kiowidgets-kdynamicjobtrackernowidgetstestFailed: TestSuite.kiowidgets-krununittestFailed: TestSuite.kiowidgets-kurifiltertestFailed: TestSuite.kiowidgets-kurlcompletiontestFailed: TestSuite.kiowidgets-kurlcompletiontest-nowaitFailed: TestSuite.kpasswdservertest

D11099: Fix compilation on Android

[Aleix Pol Gonzalez]

apol added a comment.


  I actually hit this issue this week (you can see build.kde.org failing 
earlier this week:
  https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20AndroidQt5.9/
  
  I fixed it by using android-21 as the sdk version, maybe it's a more 
acceptable compromise?
  I'm not sure what we are compromising over though.

INLINE COMMENTS

> kshareddatacache_p.h:405
>  if (timeoutsSupported) {
> +#ifdef KSDC_TIMEOUTS_SUPPORTED
>  tempLock = QSharedPointer(new 
> semaphoreTimedLock(tempSemaphore));

There's a weird whitespace here.

> kshareddatacache_p.h:406
> +#ifdef KSDC_TIMEOUTS_SUPPORTED
>  tempLock = QSharedPointer(new 
> semaphoreTimedLock(tempSemaphore));
> +#endif

#else Q_UNREACHABLE?
Or what happens?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D11099

To: vkrause, #frameworks
Cc: apol, michaelh

D11102: [Dialog] Allow setting outputOnly for NoBackground dialog

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  I don't see why this would be silently discarded. The input shape has nothing 
to do with the window mask (e.g. rounded border depending on theme).

TEST PLAN
  - Created a dialog with `NoBackground` and instead a fully custom background 
and made it click-through successfully
  - Changing the property at runtime still update sfine
  - OSD is still click-through as before

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11102

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: broulik, #plasma
Cc: #frameworks, michaelh

D9973: ktooltipwidget: Fix tooltip positioning

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> michaelh wrote in ktooltipwidget.cpp:142
> In addition I cannot reproduce the behaviour depicted here 
> 
>  anymore.

Too happy too soon. This (partial) offscreen display is still happening. The 
tests cannot catch this, they are much too simple. A genuine baloowidget is 
needed. I've been told this is not possible because baloo-widgets is tier-3.
Also this behaviour is difficult to reproduce. I depends on screen size, 
content and relative position of the item rect hovered.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D9973

To: michaelh, elvisangelaccio, #frameworks, #dolphin, ngraham
Cc: dfaure, cfeck, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 162 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/162/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 06 Mar 2018 17:59:00 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31548/59628)38%
(18529/48886)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8570/9118)48%
(5229/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8346/14349)50%
(4873/9722)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3896/7874)33%
(1643/4942)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/13/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 06 Mar 2018 17:59:00 +
 Build duration:
8 min 12 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31609/59630)38%
(18547/48882)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8568/9118)48%
(5231/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)59%
(8413/14351)50%
(4897/9726)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3897/7874)33%
(1644/4942)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 142 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/142/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 06 Mar 2018 17:59:00 +
 Build duration:
7 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-kfileitemtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest

D11067: Fix more cases of incorrect parameter to findProtocol

[Jaime Torres Amate]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c25b6745366f: Fix more cases of incorrect parameter to 
findProtocol (authored by jtamate).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11067?vs=28801=28855

REVISION DETAIL
  https://phabricator.kde.org/D11067

AFFECTED FILES
  src/core/kprotocolmanager.cpp

To: jtamate, #frameworks, dfaure
Cc: michaelh

D10446: Add KLanguageName

[Albert Astals Cid]

aacid planned changes to this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid
Cc: markg, apol, #frameworks, michaelh

D10446: Add KLanguageName

[Albert Astals Cid]

aacid added a comment.


  In D10446#218954 , @markg wrote:
  
  > Isn't this better suited for KCoreAddons?
  
  
  The kf5_entry.desktop files are part of kconfigwidgets tarball, so that's why 
i put it here.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid
Cc: markg, apol, #frameworks, michaelh

D10168: Use nullptr for passing a null pointer to crc32

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R243:61d39cae560a: Use nullptr for passing a null pointer to 
crc32 (authored by aacid).

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10168?vs=26154=28852

REVISION DETAIL
  https://phabricator.kde.org/D10168

AFFECTED FILES
  src/kgzipfilter.cpp
  src/kzip.cpp

To: aacid, mpyne
Cc: mpyne, #frameworks, michaelh

D11099: Fix compilation on Android

[Volker Krause]

vkrause created this revision.
vkrause added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
vkrause requested review of this revision.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11099

AFFECTED FILES
  src/lib/caching/kshareddatacache_p.h

To: vkrause, #frameworks
Cc: michaelh

D10776: Make it possible to generate po files in parallel

[Aleix Pol Gonzalez]

apol updated this revision to Diff 28846.
apol added a comment.


  EQUAL

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10776?vs=28845=28846

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10776

AFFECTED FILES
  cmake/build-pofiles.cmake
  cmake/build-tsfiles.cmake

To: apol, #frameworks, sitter
Cc: michaelh

D10776: Make it possible to generate po files in parallel

[Aleix Pol Gonzalez]

apol updated this revision to Diff 28845.
apol marked 3 inline comments as done.
apol added a comment.


  Remove debug info and spaces

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10776?vs=28724=28845

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10776

AFFECTED FILES
  cmake/build-pofiles.cmake
  cmake/build-tsfiles.cmake

To: apol, #frameworks, sitter
Cc: michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 62 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/62/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 06 Mar 2018 14:15:14 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D11080: Make org.kde. components include a donate URL

[Aleix Pol Gonzalez]

apol updated this revision to Diff 28835.
apol added a comment.


  Include the app id when opening the url, to inform what's the donation trigger

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11080?vs=28775=28835

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11080

AFFECTED FILES
  src/kpackagetool/kpackagetool.cpp

To: apol, #frameworks
Cc: aacid, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 87 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/87/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 06 Mar 2018 14:15:14 +
 Build duration:
9 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13344)19%
(1979/10565)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2235)7%
(102/1492)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/2009)17%
(306/1771)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
  

D11080: Make org.kde. components include a donate URL

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> aacid wrote in kpackagetool.cpp:534
> Not sure if i'm saying crap, but should we check if it already has a donation 
> url and then give a warning or something else?

This is for the code that turns kpackage metadata files into appdata.xml files. 
So it doesn't really apply.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D11080

To: apol, #frameworks
Cc: aacid, michaelh

D11097: [Window Thumbnail] Allow using atlas texture

[David Edmundson]

davidedmundson added a comment.


  Edit.
  
  Just re-read. Sorry.
  
  createTextureFromId   with CanUseAtlas doesn't make any sense.
  
  It creates a QSGTexture object from an existing GL Texture, it's not creating 
any atlas or otherwise.
  
  It'll just no-op. So no harm done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11097

To: broulik, #plasma, davidedmundson
Cc: #frameworks, michaelh

D11097: [Window Thumbnail] Allow using atlas texture

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:48771a291229: [Window Thumbnail] Allow using atlas 
texture (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11097?vs=28832=28834

REVISION DETAIL
  https://phabricator.kde.org/D11097

AFFECTED FILES
  src/declarativeimports/core/windowthumbnail.cpp

To: broulik, #plasma, davidedmundson
Cc: #frameworks, michaelh

D11097: [Window Thumbnail] Allow using atlas texture

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11097

To: broulik, #plasma, davidedmundson
Cc: #frameworks, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 61 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/61/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 06 Mar 2018 13:52:57 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D11097: [Window Thumbnail] Allow using atlas texture

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  It's not using any custom shaders anyway

TEST PLAN
  Verified thumbnails still look good
  Verified fallback to window icon still looks good

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11097

AFFECTED FILES
  src/declarativeimports/core/windowthumbnail.cpp

To: broulik, #plasma
Cc: #frameworks, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 86 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/86/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 06 Mar 2018 13:43:57 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13344)19%
(1979/10565)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2235)7%
(102/1492)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/2009)17%
(306/1771)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 60 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/60/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 06 Mar 2018 12:36:51 +
 Build duration:
1 hr 15 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D10769: [Dialog] Remove now obsolete KWindowSystem::setState calls

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:7e5dff648f01: [Dialog] Remove now obsolete 
KWindowSystem::setState calls (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10769?vs=27851=28828

REVISION DETAIL
  https://phabricator.kde.org/D10769

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: broulik, #plasma, mart
Cc: mart, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

[Nathaniel Graham]

ngraham added a comment.


  @rkflx I'm looking into it now.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: ilic, abetts, elvisangelaccio, aacid, argonel, marten, graesslin, broulik, 
#frameworks, michaelh

D11054: Add media status icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Let's do it!

REPOSITORY
  R266 Breeze Icons

BRANCH
  mediaStatus

REVISION DETAIL
  https://phabricator.kde.org/D11054

To: romangg, #plasma, #frameworks, #vdg, andreask, ngraham
Cc: ngraham, michaelh

D11054: Add media status icons

[Andreas Kainz]

andreask accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  mediaStatus

REVISION DETAIL
  https://phabricator.kde.org/D11054

To: romangg, #plasma, #frameworks, #vdg, andreask
Cc: michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 85 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/85/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 06 Mar 2018 12:36:51 +
 Build duration:
6 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13348)19%
(1979/10569)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2235)7%
(102/1492)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(553/2013)17%
(306/1775)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
  

D11090: Fix FadingMaterial fragment with core profile

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:188be131bca5: Fix FadingMaterial fragment with core 
profile (authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11090?vs=28808=28822

REVISION DETAIL
  https://phabricator.kde.org/D11090

AFFECTED FILES
  src/declarativeimports/core/fadingmaterial_core.frag

To: davidedmundson, #plasma, broulik
Cc: #frameworks, michaelh

D11091: Support Atlas textures in FadingNode

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:02c419453462: Support Atlas textures in FadingNode 
(authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11091?vs=28809=28823

REVISION DETAIL
  https://phabricator.kde.org/D11091

AFFECTED FILES
  src/declarativeimports/core/fadingmaterial.frag
  src/declarativeimports/core/fadingmaterial_core.frag
  src/declarativeimports/core/fadingnode.cpp
  src/declarativeimports/core/iconitem.cpp

To: davidedmundson, #plasma, broulik
Cc: #frameworks, michaelh

D11090: Fix FadingMaterial fragment with core profile

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11090

To: davidedmundson, #plasma, broulik
Cc: #frameworks, michaelh

D11091: Support Atlas textures in FadingNode

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11091

To: davidedmundson, #plasma, broulik
Cc: #frameworks, michaelh

D11050: Remove frames around media buttons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks good!

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  reworkMediaIcons

REVISION DETAIL
  https://phabricator.kde.org/D11050

To: romangg, #frameworks, #plasma, ngraham
Cc: ngraham, mart, michaelh

D11049: Remove frame around media action icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Looks good to me too!

REPOSITORY
  R266 Breeze Icons

BRANCH
  reworkMediaActions

REVISION DETAIL
  https://phabricator.kde.org/D11049

To: romangg, #breeze, #vdg, andreask, ngraham
Cc: ngraham, mart, #frameworks, michaelh

D11091: Support Atlas textures in FadingNode

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Previously IconItem would create icons in new textures for animating. By
  keeping them in the atlas not only do we avoid that, but we should
  implicitly share the QSGTexture used for non-animating item.

TEST PLAN
  Moused over icon, it changed correctly
  Set core profile, moused over an icon it changed correctly

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11091

AFFECTED FILES
  src/declarativeimports/core/fadingmaterial.frag
  src/declarativeimports/core/fadingmaterial_core.frag
  src/declarativeimports/core/fadingnode.cpp
  src/declarativeimports/core/iconitem.cpp

To: davidedmundson, #plasma
Cc: #frameworks, michaelh

D11090: Fix FadingMaterial fragment with core profile

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Currently it asserts. I'm sure it worked at some point.
  Fixed to match shaders shipped with Qt.

TEST PLAN
  Set Core profile
  Did crash
  Now doesn't

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11090

AFFECTED FILES
  src/declarativeimports/core/fadingmaterial_core.frag

To: davidedmundson, #plasma
Cc: #frameworks, michaelh

D11049: Remove frame around media action icons

[Andreas Kainz]

andreask accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  reworkMediaActions

REVISION DETAIL
  https://phabricator.kde.org/D11049

To: romangg, #breeze, #vdg, andreask
Cc: mart, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/12/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 06 Mar 2018 09:41:19 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31613/59628)38%
(18563/48880)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8570/9118)48%
(5233/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)59%
(8403/14349)50%
(4895/9724)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)50%
(3898/7874)33%
(1645/4942)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(512/982)41%
(413/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 161 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/161/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 06 Mar 2018 09:41:19 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31558/59627)38%
(18540/48884)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8570/9118)48%
(5231/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8356/14348)50%
(4880/9720)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3896/7874)33%
(1643/4942)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

D10989: Check for nullptr in indexForNode

[David Faure]

dfaure added a comment.


  helgrind and drd are for multithreading data races, but KDirModel can't be 
used in a multithreading context, so I'm not sure why you're mentioning those 
tools.
  
  If you do want to detect data races, please note that helgrind and drd have 
lots of false positives (if you really want to use helgrind, read 
https://www.kdab.com/~dfaure/helgrind.html), and a much better tool is clang's 
thread-sanitizer. Downside: you need to build your own Qt first, with 
`-platform linux-clang-libc++ -sanitize thread`. Upside: the apps run much 
faster than with helgrind, and the reports are much more useful.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10989

To: jtamate, #frameworks, dfaure
Cc: mpyne, michaelh

D11067: Fix more cases of incorrect parameter to findProtocol

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11067

To: jtamate, #frameworks, dfaure
Cc: michaelh

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 141 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/141/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 06 Mar 2018 09:41:19 +
 Build duration:
7 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

D10989: Check for nullptr in indexForNode

[Jaime Torres Amate]

jtamate added a comment.


  In D10989#219594 , @mpyne wrote:
  
  > I think valgrind has some flags you can use to try to generate a backtrace 
for where a freed block of memory was freed from, which might be useful for 
debugging.
  
  
  Thanks. The parameter is --read-var-info=yes, but it confirms my assumption, 
the job is already deleted and its space used by many others before the crash.
  With --tool=helgrind it shows more than 4.500 errors.
  With -tool=drd it shows more than 90.000 errors.
  Therefore I'll try to fix as many of them as possible, step by step, if it's 
possible.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10989

To: jtamate, #frameworks, dfaure
Cc: mpyne, michaelh

D11067: Fix more cases of incorrect parameter to findProtocol

[Jaime Torres Amate]

jtamate updated this revision to Diff 28801.
jtamate retitled this revision from "Fix 3 more cases of incorrect parameter to 
findProtocol" to "Fix more cases of incorrect parameter to findProtocol".
jtamate added a comment.


  David's comment done.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11067?vs=28751=28801

REVISION DETAIL
  https://phabricator.kde.org/D11067

AFFECTED FILES
  src/core/kprotocolmanager.cpp

To: jtamate, #frameworks, dfaure
Cc: michaelh

D11089: KUrlCompletion: early return if the URL is invalid like ":/"

[David Faure]

dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11089

To: dfaure, jtamate
Cc: #frameworks, michaelh

D11089: KUrlCompletion: early return if the URL is invalid like ":/"

[Jaime Torres Amate]

jtamate accepted this revision.
jtamate added a comment.
This revision is now accepted and ready to land.


  I'll change https://phabricator.kde.org/D11067.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11089

To: dfaure, jtamate
Cc: #frameworks, michaelh

D11089: KUrlCompletion: early return if the URL is invalid like ":/"

[David Faure]

dfaure created this revision.
dfaure added a reviewer: jtamate.
Restricted Application added a project: Frameworks.
dfaure requested review of this revision.

REVISION SUMMARY
  Don't send an empty protocol to findProtocol()

TEST PLAN
  New unittest

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11089

AFFECTED FILES
  autotests/kurlcompletiontest.cpp
  src/widgets/kurlcompletion.cpp

To: dfaure, jtamate
Cc: #frameworks, michaelh

D11067: Fix 3 more cases of incorrect parameter to findProtocol

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> jtamate wrote in kurlcompletion.cpp:626
> I missed one key stroke. With this test, in a non empty current dirt, it 
> fails.
> 
> void KUrlCompletionTest::testInvalidProtocol()
> {
> 
>   KUrlCompletion* completionHomeCwd = new KUrlCompletion;
>   completionHomeCwd->setDir(QUrl("/home/user"));
>   
>   completionHomeCwd->makeCompletion(QLatin1String(":/"));
>   waitForCompletion(completionHomeCwd);
>   const auto matches = completionHomeCwd->allMatches();
>   // just don't crash
> 
> }

Thanks for finding this. I made a copy/paste error, the "EmptyCwd" should have 
been removed, there's already a completion object set up with a base dir, in 
this test.

Here's the simpler test, with a fix that seems safer to me: 
https://phabricator.kde.org/D11089

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11067

To: jtamate, #frameworks, dfaure
Cc: michaelh

D11088: [KFilePlacesView] Call KDiskFreeSpaceInfo only if neccessary

[Kai Uwe Broulik]

broulik updated this revision to Diff 28797.
broulik added a comment.


  - Slightly optimize

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11088?vs=28794=28797

REVISION DETAIL
  https://phabricator.kde.org/D11088

AFFECTED FILES
  src/filewidgets/kfileplacesview.cpp

To: broulik, #frameworks
Cc: michaelh

D11088: [KFilePlacesView] Call KDiskFreeSpaceInfo only if neccessary

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  I found this was called 350 times for me when opening the file dialog since 
for every paint pass it would needlessly call this for every place. It queries 
all mountpoints and does other expensive work.
  Instead, only do so when the bar would actually be shown. Ideally this would 
be cached somehow but this patch is a nice simple optimization already.

TEST PLAN
  - Verified it is no longer called when opening file dialog
  - Free space bar still shows up fine when hovering a mounted USB device

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11088

AFFECTED FILES
  src/filewidgets/kfileplacesview.cpp

To: broulik, #frameworks
Cc: michaelh

D10989: Check for nullptr in indexForNode

[David Faure]

dfaure added a comment.


  That's actually valgrind-memcheck's default behaviour.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10989

To: jtamate, #frameworks, dfaure
Cc: mpyne, michaelh

D11080: Make org.kde. components include a donate URL

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> kpackagetool.cpp:534
> +writer.writeStartElement(QStringLiteral("url"));
> +writer.writeAttribute(QStringLiteral("type"), 
> QStringLiteral("donation"));
> +
> writer.writeCharacters(QStringLiteral("https://www.kde.org/donate.php;));

Not sure if i'm saying crap, but should we check if it already has a donation 
url and then give a warning or something else?

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D11080

To: apol, #frameworks
Cc: aacid, michaelh

D11077: [Icon Item] Remove unused variables

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:8019cb369cde: [Icon Item] Remove unused variables 
(authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11077?vs=28770=28791

REVISION DETAIL
  https://phabricator.kde.org/D11077

AFFECTED FILES
  src/declarativeimports/core/iconitem.h

To: broulik, #plasma, davidedmundson
Cc: #frameworks, michaelh

Kirigami breeze icons on android

[Camilo Higuita Rodriguez]

Hi, I'm having trouble making use of the breeze icons on Android using
Kirigami.

I added kirigami-icons.qrc to the app project and added a few icons to it,
but it only picksup the icons defined on kirigami own kirigami-icons.qrc
file.

Although when running qmake it says :
Using icons QRC file shipped by the project

Maybe I'm missing something?

I'm using qmake and Kirigami is being statically linked on Android.

Saludos,
Camilo Higuita

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 84 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/84/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 06 Mar 2018 08:13:29 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13342)19%
(1979/10569)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2229)7%
(102/1492)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(553/2013)17%
(306/1775)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

D11067: Fix 3 more cases of incorrect parameter to findProtocol

[Jaime Torres Amate]

jtamate added inline comments.

INLINE COMMENTS

> dfaure wrote in kurlcompletion.cpp:626
> I'm not 100% sure about this one because kurl() is only supposed to be called 
> if url.isURL().
> 
> Also, I tried to reproduce this assert with a unittest for kcompletion, but 
> it works here !?
> 
> http://www.davidfaure.fr/2018/kurlcompletion_test.diff

I missed one key stroke. With this test, in a non empty current dirt, it fails.

void KUrlCompletionTest::testInvalidProtocol()
{

  KUrlCompletion* completionHomeCwd = new KUrlCompletion;
  completionHomeCwd->setDir(QUrl("/home/user"));
  
  completionHomeCwd->makeCompletion(QLatin1String(":/"));
  waitForCompletion(completionHomeCwd);
  const auto matches = completionHomeCwd->allMatches();
  // just don't crash

}

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11067

To: jtamate, #frameworks, dfaure
Cc: michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 59 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/59/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 06 Mar 2018 08:13:29 +
 Build duration:
4 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest