D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham added a comment.


  Any more opinions on this? As you can see from the Summary section, it fixes 
(or obviates) a //ton// of bugs, many of them very old.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure, #frameworks
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

[Nathaniel Graham]

ngraham added a comment.


  I'm not thrilled about the dropdown menu button losing its an arrow when you 
make it activate-able with a regular click, but that's a Breeze issue (that I 
plan to fix soon...).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12077

To: ngraham, #frameworks
Cc: mmustac, broulik, michaelh, ngraham, bruns

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

[Nathaniel Graham]

ngraham retitled this revision from "Show toggle buttons in the toolbar for the 
two most commonly-used view modes in the file open/save dialogs" to "Show view 
mode buttons and a sort menu in the open/save dialog's toolbar".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12077

To: ngraham, #frameworks
Cc: mmustac, broulik, michaelh, ngraham, bruns

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

[Nathaniel Graham]

ngraham updated this revision to Diff 31848.
ngraham added a comment.


  Also add a Sort menu to the toolbar

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12077?vs=31813=31848

BRANCH
  show-view-mode-toggles-on-open-save-dialog-toolbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12077

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: ngraham, #frameworks
Cc: mmustac, broulik, michaelh, ngraham, bruns

D12034: Use the more appropriate "two sliders" icon for "configure"

[Nathaniel Graham]

ngraham added a comment.


  Eike reports that I have bribed him into acquiescing to this patch! 
  
  Keep in mind we will be able to very easily change the icons in the future if 
need be, once this is landed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12034

To: ngraham, #vdg, #plasma, #breeze
Cc: hein, bruns, abetts, sharvey, #frameworks, michaelh, ngraham

D12034: Use the more appropriate "two sliders" icon for "configure"

[Eike Hein]

hein added a comment.


  In D12034#244019 , @hein wrote:
  
  > In principle I totally agree with this, but I'm not sure about the 
`input-keyboard` icon it extends to. Do you know where it's used currently?
  
  
  It's sometimes even used as window icon: 
https://lxr.kde.org/search?_filestring=&_string=input-keyboard

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12034

To: ngraham, #vdg, #plasma, #breeze
Cc: hein, bruns, abetts, sharvey, #frameworks, michaelh, ngraham

D12034: Use the more appropriate "two sliders" icon for "configure"

[Eike Hein]

hein added a comment.


  In principle I totally agree with this, but I'm not sure about the 
`input-keyboard` icon it extends to. Do you know where it's used currently?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12034

To: ngraham, #vdg, #plasma, #breeze
Cc: hein, bruns, abetts, sharvey, #frameworks, michaelh, ngraham

D11984: Android: Explicitly point at upstream documentation and deprecate duplicated concepts

[Aleix Pol Gonzalez]

apol added a comment.


  ping-o

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D11984

To: apol, #build_system, #frameworks
Cc: michaelh, ngraham, bruns

D12097: Make room for footer and header.

[Eike Hein]

hein added a dependent revision: D12102: Port Language KCM to Qt Quick.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12097

To: hein, #kirigami, mart
Cc: plasma-devel, #frameworks, michaelh, ngraham, bruns, apol, davidedmundson, 
mart, hein

D12034: Use the more appropriate "two sliders" icon for "configure"

[Nathaniel Graham]

ngraham added a comment.


  If we're proposing new icons, what I'd like to see is a "base" configure 
iconography that you can add other things to. For example, if we use a base 
"two sliders" icon for "configure", then...
  
  - "Configure shortcuts" would have one of the sliders replaced with a 
keyboard or an individual key
  - "Configure toolbars" would have one of the sliders replaced with a little 
toolbar
  - "Configure notifications" would have one of the sliders replaced with a 
little balloon with an exclamation mark in it, and so on.
  
  That said, all of that is rather out of scope for this patch right here. Yea 
or nay on this patch?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12034

To: ngraham, #vdg, #plasma, #breeze
Cc: bruns, abetts, sharvey, #frameworks, michaelh, ngraham

D12034: Use the more appropriate "two sliders" icon for "configure"

[Stefan Brüns]

bruns added a comment.


  Thats a new one

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12034

To: ngraham, #vdg, #plasma, #breeze
Cc: bruns, abetts, sharvey, #frameworks, michaelh, ngraham

D12034: Use the more appropriate "two sliders" icon for "configure"

[Nathaniel Graham]

ngraham added a comment.


  Is that "three sliders" icon one we already have, or did you just mock it up?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12034

To: ngraham, #vdg, #plasma, #breeze
Cc: bruns, abetts, sharvey, #frameworks, michaelh, ngraham

D12034: Use the more appropriate "two sliders" icon for "configure"

[Stefan Brüns]

bruns added a comment.


  +1 for making it more consistent ...
  
  For the design - how about this one (Shortcuts - old, Toolbars - new)?
  F5803306: Screenshot_20180410_224347.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12034

To: ngraham, #vdg, #plasma, #breeze
Cc: bruns, abetts, sharvey, #frameworks, michaelh, ngraham

D12016: [ktexteditor] much faster positionFromCursor

[Milian Wolff]

mwolff added a comment.


  some nits, otherwise lgtm assuming all tests pass
  
  bonus points for a proper benchmark that shows the before/after gain in hard 
numbers

INLINE COMMENTS

> kateviewaccessible.h:191
>  {
> -int pos = 0;
> -for (int line = 0; line < cursor.line(); ++line) {
> -// length of the line plus newline
> -pos += view->view()->document()->line(line).size() + 1;
> +int pos = m_lastPosition;
> +const KTextEditor::Document *doc = view->view()->document();

I know the old code used int already, but shouldn't this better be a quint64 as 
it's a file offset?

> kateviewaccessible.h:192
> +int pos = m_lastPosition;
> +const KTextEditor::Document *doc = view->view()->document();
> +

const auto *doc =

> kateviewaccessible.h:204
> +m_lastView = view;
>  }
> +else {

style: join with next line

> kateviewaccessible.h:215
> +pos += cursor.line() - m_lastCursor.line();
> +}
> +else {

dito

> kateviewaccessible.h:231
>  private:
> +
>  inline KateViewInternal *view() const

unrelated change?

> kateviewaccessible.h:270
> +mutable KTextEditor::Cursor m_lastCursor;
> +// m_lastPosition stores the positionFromCursor, with the cursor always 
> in column 0
> +mutable int m_lastPosition;

maybe also mention that this is a file offset?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12016

To: jtamate, #kate, cullmann, #frameworks
Cc: mwolff, brauch, cullmann, #frameworks, michaelh, kevinapavew, ngraham, 
bruns, demsking, sars, dhaumann

D11851: Add syntax highlighting for Logcat

[Nibaldo González]

nibags added a comment.


  Everything is ready. But my account is not developer and I do not have 
permission to push it to the repository.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-logcat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11851

To: nibags, #framework_syntax_highlighting, cullmann
Cc: cullmann, #frameworks, michaelh, genethomas, ngraham, bruns, vkrause, 
dhaumann

D11733: Allow opening items from the open/save dialogs

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  After thinking about this for a few weeks, I can't imagine and haven't seen a 
use case for using the Open File dialog to open the file in a different app 
that wouldn't be better served in another way.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11733

To: ngraham, #dolphin, #frameworks
Cc: gregormi, rkflx, broulik, michaelh, ngraham, bruns

D12097: Make room for footer and header.

[Eike Hein]

hein created this revision.
hein added reviewers: Kirigami, mart.
Restricted Application added projects: Kirigami, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
hein requested review of this revision.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12097

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml

To: hein, #kirigami, mart
Cc: plasma-devel, #frameworks, michaelh, ngraham, bruns, apol, davidedmundson, 
mart, hein

D12045: Clean up existing documentation

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> ngraham wrote in README.md:36
> I think the original paragraph was fine, but needed a bit of cleanup and 
> grammar work. How's this?
> 
> "We recommend not packaging Baloo for Windows or macOS, as both these 
> operating systems offer their own file searching solutions that integrate 
> better than Baloo can."

- In CI Baloo is fully built and tested for Linux and FreeBSD.
- In CI an untested stub for Windows is build. I think that is to fulfill the 
dependencies.
- macOS is not mentioned anywhere (and I don't know anything about it).

If Baloo has to be present for the dependency, it makes no sense to recommend 
not packaging it. That, or I got it wrong.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12045

To: michaelh, #baloo
Cc: ngraham, bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, 
alexeymin

D12034: Use the more appropriate "two sliders" icon for "configure"

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12034

To: ngraham, #vdg, #plasma, #breeze
Cc: abetts, sharvey, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure, #frameworks
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D12095: convert setDirLister to the new connect syntax

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Should remove the private slot declaration?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12095

To: jtamate, dfaure, #frameworks, apol
Cc: apol, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham added a reviewer: Frameworks.
ngraham edited subscribers, added: Dolphin; removed: Frameworks.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure, #frameworks
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: cfeck, fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D12095: convert setDirLister to the new connect syntax

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  The only tricky part is the use of QOverload<>::of to distinguish between 
signals with same name but different signatures.

TEST PLAN
  kdirmodeltest passes all tests.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12095

AFFECTED FILES
  src/widgets/kdirmodel.cpp

To: jtamate, dfaure, #frameworks
Cc: michaelh, ngraham, bruns

D12045: Clean up existing documentation

[Nathaniel Graham]

ngraham added a comment.


  Sorry, not aware of a better workflow for now, but yeah, this does not seem 
ideal. Perhaps real-time chat would be better, during a time when everyone's 
available.

INLINE COMMENTS

> michaelh wrote in README.md:36
> "Baloo is developed and tested exclusively for 64-bit Linux and FreeBSD. It 
> may run on other ​unix based systems. On those it should be thoroughly tested 
> as Baloo may affect system stability.
> 
> Baloo may run on 32-bit systems, but also may not work correctly. Please..."
> 
> (Is there a better way to collaborate on texts? This is tedious and not very 
> effective. @ngraham?)

I think the original paragraph was fine, but needed a bit of cleanup and 
grammar work. How's this?

"We recommend not packaging Baloo for Windows or macOS, as both these operating 
systems offer their own file searching solutions that integrate better than 
Baloo can."

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12045

To: michaelh, #baloo
Cc: ngraham, bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, 
alexeymin

D11948: [KFileWidget] Hardcode example user name

[Kevin Funk]

kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  Makes sense to me. Go for it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11948

To: broulik, #frameworks, kfunk
Cc: kfunk, elvisangelaccio, michaelh, ngraham, bruns

D11745: databasesanitizer: Use flags for filtering

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> databasesanitizer.cpp:116
>  if ((!includeIds.isEmpty() && 
> !includeIds.contains(info.deviceId))
>  || (!excludeIds.isEmpty() && 
> excludeIds.contains(info.deviceId))
>  || (urlFilter && !urlFilter->match(info.url).hasMatch())

I think this becomes a little bit clearer if you move it to the top of the map 
iteration and use a `continue;` to process the next item, e.g.:

  quint64 id= it.key();
  deviceId = idToDeviceId(id);  // idutils.h
  
  if (!includeIds.isEmpty() && !includeIds.contains(deviceId)) {
  continue;
  } else if (excludeIds.contains(info.deviceId)) {
  continue;
  } else if (urlFilter && !urlFilter->match(it.value()).hasMatch())
  continue;
  }
  
  checkedFiles += 1;
  FileInfo info; 
  
  if (info.accessible)
 accessibleCount++
  
  if ((info.accessible && !(accessFilter & IgnoreAvailable)) ||
  (!info.accessible && !(accessFilter & IgnoreUnavailable))) {
  result.append(info);
  }


`ignoredCount = map.size() - checkedFiles`
`inaccessibleCount = checkedFiles - accessibleCount`

> michaelh wrote in databasesanitizer.cpp:134
> I'm not content with this solution. Still, it's the best I could do without 
> bloating the code too much.

for the second, return

  struct summary {
  quint64 ignored;
  quint64 accessible;
  quint64 inaccessible;
  };

> databasesanitizer.cpp:183
> +if ((it.value().mounted && !(accessFilter & 
> DatabaseSanitizer::IgnoreMounted))
> +|| (!it.value().mounted && !(accessFilter & 
> DatabaseSanitizer::IgnoreUnmounted))
> +) {

You can omit `DatabaseSanitizer::` here

> bruns wrote in databasesanitizer.h:41
> Hm still awkward:
> 
>   IgnoreNone = 0,
>   IgnoreAvailable = 1,
>   IgnoreUnavailable = 2,
>   IgnoreMounted = IgnoreAvailable << 4,   <--  (1 << 4) == 16
>   IgnoreUnmounted = IgnoreUnavailable << 4<--  (2 << 4) == 32

Thats probably not what you want - IgnoreUnmounted (mounted-only) implicitly 
includes IgnoreUnavailable, so you will exclude listing unavailable files even 
on mounted filesystems.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11745

To: michaelh, #baloo, #frameworks
Cc: bruns, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
alexeymin

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12077

To: ngraham, #frameworks
Cc: mmustac, broulik, michaelh, ngraham, bruns

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12077

To: ngraham, #frameworks
Cc: mmustac, broulik, michaelh, ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 126 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/126/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 10 Apr 2018 13:39:13 +
 Build duration:
8 min 42 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3558/13481)19%
(1978/10637)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/453)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2314)7%
(102/1552)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3500)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1622)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2015)17%
(305/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1177)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
 

D12082: Don't offer qml plugin as a link target

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D12082

To: leinir, #frameworks, #knewstuff, apol
Cc: michaelh, ZrenBot, ngraham, bruns

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

[Nathaniel Graham]

ngraham added a comment.


  To elaborate, the open/save dialog has four view modes:
  
  - Simple View: what most other platforms would calll "Icons view". Can be 
configured to have the icons to the left side of the labels (Windows style), or 
above them (macOS, GNOME, Cinnamon, XFCE, ElementraryOS, everyone-else style).
  - Details View: what most other platforms would call "List view"
  - Tree View: a somewhat useless view that's like Details View except that it 
allows expanding the contents of folders, but omits all of the detail columns
  - Detailed Tree View: like Details view, but allows expanding the folders
  
  I think Simple View and Detailed View make the most sense to put in the 
toolbar.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12077

To: ngraham, #frameworks
Cc: mmustac, broulik, michaelh, ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 101 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/101/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 10 Apr 2018 13:39:13 +
 Build duration:
3 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D12064: Don't alter memory management to hide an item

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:2785916d01b2: Dont alter memory management to hide 
an item (authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12064?vs=31726=31816

REVISION DETAIL
  https://phabricator.kde.org/D12064

AFFECTED FILES
  src/plasmaquick/containmentview.cpp

To: davidedmundson, #plasma, mart
Cc: rikmills, #frameworks, michaelh, ngraham, bruns

D11675: use KDE_INSTALL_DATADIR instead of FULL_DATADIR

[Friedrich W . H . Kossebau]

kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  If no-one else can be bothered, here my shipit.

REPOSITORY
  R290 KPackage

BRANCH
  usedatadir

REVISION DETAIL
  https://phabricator.kde.org/D11675

To: bshah, kossebau
Cc: #frameworks, michaelh, ngraham, bruns

D12064: Don't alter memory management to hide an item

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12064

To: davidedmundson, #plasma, mart
Cc: rikmills, #frameworks, michaelh, ngraham, bruns

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

[Nathaniel Graham]

ngraham added a comment.


  In D12077#243556 , @broulik wrote:
  
  > Can we arrange them so that they're more consistent with Dolphin? i.e. put 
the Preview button at right-most
  
  
  Sure!
  F5802899: Like this.png 
  
  In D12077#243562 , @mmustac wrote:
  
  > Great, I even didn't know that this was possible *lol*
  >  But wouldn't it be more consistent with dolphin to add the list view also ?
  
  
  Yes, I suspect a lot of people didn't know this. :) I'm hesitant to add a 
third mode for a couple of reasons:
  
  1. The open/save dialog doesn't really support the same modes in the same way 
that Dolphin does. It toggles between having the icons on top or on the left 
side by making them discinct modes; the open/save dialog does it by having the 
icons mode be a single mode, and toggling only the position of the icons
  2. Three modes is honestly overkill; icons and list mode are sufficient for 
95% of use cases. The other modes are still available via the Configure icon in 
the top-right corner. "Simple By default, powerful when needed"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12077

To: ngraham, #frameworks
Cc: mmustac, broulik, michaelh, ngraham, bruns

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

[Nathaniel Graham]

ngraham updated this revision to Diff 31813.
ngraham added a comment.


  Also move the Preview button over to the right, so it doesn't compete with 
the view mode buttons

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12077?vs=31779=31813

BRANCH
  show-view-mode-toggles-on-open-save-dialog-toolbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12077

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: ngraham, #frameworks
Cc: mmustac, broulik, michaelh, ngraham, bruns

D11745: databasesanitizer: Use flags for filtering

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> databasesanitizer.cpp:134
> +map.size() - ignoredCount - accessibleCount
> +)};
>  }

I'm not content with this solution. Still, it's the best I could do without 
bloating the code too much.

> databasesanitizer.cpp:245
>  }
> -err << i18n("Found %1 matching items", infos.count()) << endl;
> +err << infos.second << endl;
>  

see above

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11745

To: michaelh, #baloo, #frameworks
Cc: bruns, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
alexeymin

D11786: Fix returning of data in the helper example

[Alexander Volkov]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R283:de225f87ae11: Fix returning of data in the helper example 
(authored by volkov).

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11786?vs=30857=31812

REVISION DETAIL
  https://phabricator.kde.org/D11786

AFFECTED FILES
  examples/helper.cpp
  src/kauthactionreply.h

To: volkov, #frameworks
Cc: #frameworks, michaelh, ngraham, bruns

D11745: databasesanitizer: Use flags for filtering

[Michael Heidelbach]

michaelh marked 4 inline comments as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11745

To: michaelh, #baloo, #frameworks
Cc: bruns, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
alexeymin

D11745: databasesanitizer: Use flags for filtering

[Michael Heidelbach]

michaelh updated this revision to Diff 31811.
michaelh added a comment.


  - Improve printList summary

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11745?vs=31807=31811

BRANCH
  sanitize-enums (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11745

AFFECTED FILES
  src/engine/databasesanitizer.cpp
  src/engine/databasesanitizer.h
  src/tools/baloodb/main.cpp

To: michaelh, #baloo, #frameworks
Cc: bruns, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
alexeymin

D11745: databasesanitizer: Use flags for filtering

[Michael Heidelbach]

michaelh updated this revision to Diff 31807.
michaelh marked 2 inline comments as done.
michaelh added a comment.


  - Adapt to upstream changes
  - Correct enum
  - Apply suggested changes

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11745?vs=31365=31807

BRANCH
  sanitize-enums (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11745

AFFECTED FILES
  src/engine/databasesanitizer.cpp
  src/engine/databasesanitizer.h
  src/tools/baloodb/main.cpp

To: michaelh, #baloo, #frameworks
Cc: bruns, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
alexeymin

D11948: [KFileWidget] Hardcode example user name

[Kai Uwe Broulik]

broulik added a comment.


  Ping, if no one objects I'll push this once next FW is released

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11948

To: broulik, #frameworks
Cc: elvisangelaccio, michaelh, ngraham, bruns

D11960: Support nvidia reset notifications in QtQuickViews

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:2b0a68b70e71: Support nvidia reset notifications in 
QtQuickViews (authored by davidedmundson).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11960?vs=31400=31799

REVISION DETAIL
  https://phabricator.kde.org/D11960

AFFECTED FILES
  src/quickaddons/qtquicksettings.cpp

To: davidedmundson, #plasma, hein
Cc: #frameworks, michaelh, ngraham, bruns

Upcoming CI changes - service disruption

[Ben Cooksley]

Hi all,

In order to allow for two replacement physical build hosts to be
rotated in and the old ones to be decommissioned, i'm scheduling some
downtime for both the CI system and the Binary Factory tomorrow.

Assuming all goes well, this downtime should be fairly short. During
the downtime Jenkins will still be accessible, however builds will not
trigger on push as they usually do. The system will perform these
builds once the changeover is completed.

To help us detect issues with the changeover, it would be appreciated
if everyone could make sure their builds, particularly on FreeBSD and
Windows are successful prior to the switch.

At this time the following projects appear to have builds which have
regressed on these platforms:
- KItinerary
- Plasma Vault
- Amarok

Thanks,
Ben

D10702: Always use a job to delete files to avoid freezing process waiting on IO

[Jaime Torres Amate]

jtamate added a comment.


  This freezing process happens for me in ktorrent the first time in a day I 
delete a file, but not the files after, even if they are iso images (>4GiB).
  Are we sure the problem is here and not in the notification step, for example 
loading the sound data and starting the sound processor?
  Does the freezing process happens if you delete a second big file?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, dfaure, ngraham, #dolphin, jtamate
Cc: jtamate, markg, ngraham, #frameworks, michaelh, bruns

D12082: Don't offer qml plugin as a link target

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added reviewers: Frameworks, KNewStuff.
leinir added a project: KNewStuff.
Restricted Application added a project: Frameworks.
leinir requested review of this revision.

REVISION SUMMARY
  This removes the KNSQuick plugin as a link target for cmake. It was never 
intended to be one, and this was just never picked up as it didn't cause issues 
until attempting to build an app using it on the Windows binary factory. The 
patch also switches to using the KDE QML install locations, equalising it with 
other Frameworks.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D12082

AFFECTED FILES
  CMakeLists.txt
  KF5NewStuffQuickConfig.cmake.in
  src/qtquick/CMakeLists.txt

To: leinir, #frameworks, #knewstuff
Cc: michaelh, ZrenBot, ngraham, bruns

D11452: sanitizer: Improve device listing

[Michael Heidelbach]

michaelh updated this revision to Diff 31791.
michaelh added a comment.


  - Optimize device listing even more

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11452?vs=31773=31791

BRANCH
  sanitize-devices (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11452

AFFECTED FILES
  src/engine/databasesanitizer.cpp
  src/engine/databasesanitizer.h
  src/engine/fsutils.cpp
  src/engine/fsutils.h
  src/engine/idutils.h
  src/tools/baloodb/main.cpp

To: michaelh, #baloo, #frameworks
Cc: bruns, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
alexeymin

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

[Marijo Mustac]

mmustac added a comment.


  Great, I even didn't know that this was possible *lol*
  But wouldn't it be more consistent with dolphin to add the list view also ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12077

To: ngraham, #frameworks
Cc: mmustac, broulik, michaelh, ngraham, bruns

D12071: add a new ConstrainedSquare formfactor

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> plasma.h:89
>   for the desktop or the particular device. */
> +ConstrainedSquare /**When the applet is constrained both vertically 
> and horizontally,
> + and can't grow in neither directions, such as those 
> hosted in the SystemTray @since 5.46*/

Lacks < on the comment.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12071

To: mart, #plasma
Cc: apol, kossebau, #frameworks, michaelh, ngraham, bruns

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

[Kai Uwe Broulik]

broulik added a comment.


  Can we arrange them so that they're more consistent with Dolphin? i.e. put 
the Preview button at right-most

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12077

To: ngraham, #frameworks
Cc: broulik, michaelh, ngraham, bruns

D12045: Clean up existing documentation

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> michaelh wrote in README.md:36
> For FreeBSD everything is built, test are run in CI and pass. For Windows 
> it's a stub: Only KF5Baloo.dll and KF5BalooEngine.dll. OSX?
> 
> "Baloo is developed and tested exclusively for Linux and FreeBSD. While it 
> may run on other ​unix based systems. It is not tested and therefore not 
> recommended." ?
> Drop "We do not recommend to package..." ?

"Baloo is developed and tested exclusively for 64-bit Linux and FreeBSD. It may 
run on other ​unix based systems. On those it should be thoroughly tested as 
Baloo may affect system stability.

Baloo may run on 32-bit systems, but also may not work correctly. Please..."

(Is there a better way to collaborate on texts? This is tedious and not very 
effective. @ngraham?)

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12045

To: michaelh, #baloo
Cc: ngraham, bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, 
alexeymin