D12016: [ktexteditor] much faster positionFromCursor

[Christoph Cullmann]

cullmann added a comment.


  Hmm, I don't understand that comment?
  Now you have one (or more) object per view, or?
  That looks sane to me.
  Or do I misunderstand how that works?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12016

To: jtamate, #kate, cullmann, #frameworks
Cc: anthonyfieroni, mwolff, brauch, cullmann, #frameworks, michaelh, 
kevinapavew, ngraham, bruns, demsking, sars, dhaumann

D12016: [ktexteditor] much faster positionFromCursor

[Anthony Fieroni]

anthonyfieroni added a comment.


  So design is broken,for me. Function should be static and cursor from view 
(KateViewInternal) should be compared against cursor parameter.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12016

To: jtamate, #kate, cullmann, #frameworks
Cc: anthonyfieroni, mwolff, brauch, cullmann, #frameworks, michaelh, 
kevinapavew, ngraham, bruns, demsking, sars, dhaumann

D12016: [ktexteditor] much faster positionFromCursor

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I am ok with it as it is ;=)
  I would have been ok with the version that still inherits from QObject, too, 
but now that one has done all the hassle to avoid that ok ;)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12016

To: jtamate, #kate, cullmann, #frameworks
Cc: mwolff, brauch, cullmann, #frameworks, michaelh, kevinapavew, ngraham, 
bruns, demsking, sars, dhaumann

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

[Dmitri Ovodok]

dmitrio added a comment.


  If I understand correctly what has happened, without this patch the file at 
destination path existed after the operation was cancelled, and it might even 
not be corrupted. Still I believe that it is the **source** file that may 
remain after the cancellation, but not the one existed at the destination path. 
Try the same test with different files (I mean, with different content) at the 
source and destination paths. After cancelling an overwrite operation you will 
have either a copy of the source file or a corrupted file if the source file 
was sufficiently large (more than 1 GB works in my case, but this probably 
depends on memory size and disk I/O speed).
  
  I agree though that disappearing of the destination file may be confusing to 
user, so some special handling of this case may be useful. But currently I do 
not see any sign of this case being already handled by KIO, neither in the 
source code nor in real tests.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10663

To: dmitrio, #frameworks, dfaure, ngraham
Cc: elvisangelaccio, ngraham, anthonyfieroni, meven, #frameworks, michaelh, 
bruns

KDE CI: Frameworks kimageformats kf5-qt5 FreeBSDQt5.10 - Build # 2 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20FreeBSDQt5.10/2/
 Project:
Frameworks kimageformats kf5-qt5 FreeBSDQt5.10
 Date of build:
Wed, 02 May 2018 00:11:20 +
 Build duration:
3 hr 39 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kimageformats-read-xcf

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> filecopyjob.cpp:320
> +// It is better to clean up this file.
> +if (!isSuspended() && d->m_bFileWritingIsInProcess) {
> +KIO::file_delete(d->m_dest);

&& metadata(QStringLiteral("overwrite")) != QLatin1String("true")

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10663

To: dmitrio, #frameworks, dfaure, ngraham
Cc: elvisangelaccio, ngraham, anthonyfieroni, meven, #frameworks, michaelh, 
bruns

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

[Nathaniel Graham]

ngraham added a comment.


  Here, let me show you.
  
  Without your patch:
  F5829979: without the patch.webm 
  
  With your patch:
  F5829981: with the patch.webm 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10663

To: dmitrio, #frameworks, dfaure, ngraham
Cc: elvisangelaccio, ngraham, anthonyfieroni, meven, #frameworks, michaelh, 
bruns

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.9 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.9/9/
 Project:
Frameworks kimageformats kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 02 May 2018 00:11:20 +
 Build duration:
4 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-xcf
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)88%
(21/24)88%
(21/24)46%
(1663/3633)38%
(847/2228)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)72%
(273/379)51%
(129/252)src.imageformats94%
(17/18)94%
(17/18)44%
(1386/3120)37%
(716/1918)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.10 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.10/17/
 Project:
Frameworks kimageformats kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 02 May 2018 00:11:20 +
 Build duration:
1 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-tgaFailed: TestSuite.kimageformats-read-xcfFailed: TestSuite.kimageformats-write-tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)79%
(19/24)79%
(19/24)42%
(1532/3631)36%
(798/2228)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)75%
(283/379)59%
(149/252)src.imageformats83%
(15/18)83%
(15/18)40%
(1245/3118)34%
(647/1918)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

D12650: Fix incorrect version in @since tag

[Huon Imberger]

This revision was automatically updated to reflect the committed changes.
Closed by commit R302:b506a48214a0: Fix incorrect version in @since tag 
(authored by huoni).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12650?vs=33466=33468

REVISION DETAIL
  https://phabricator.kde.org/D12650

AFFECTED FILES
  src/kiconloader.h

To: huoni, #frameworks, cfeck
Cc: michaelh, bruns

D12557: [XCF/GIMP loader] Raise maximimum allowed image size to 32767x32767 on 64 bit platforms

[Christoph Feck]

This revision was automatically updated to reflect the committed changes.
Closed by commit R287:19f33239e7a7: [XCF/GIMP loader] Raise maximimum allowed 
image size to 32767x32767 on 64 bit… (authored by cfeck).

REPOSITORY
  R287 KImageFormats

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12557?vs=33184=33467

REVISION DETAIL
  https://phabricator.kde.org/D12557

AFFECTED FILES
  src/imageformats/xcf.cpp

To: cfeck, alexmerry, dfaure
Cc: #frameworks, michaelh, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 2 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/2/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 21:12:33 +
 Build duration:
2 hr 58 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D12650: Fix incorrect version in @since tag

[Christoph Feck]

cfeck accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12650

To: huoni, #frameworks, cfeck
Cc: michaelh, bruns

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

[Dmitri Ovodok]

dmitrio added a comment.


  Sorry, but I was not able to locate such a behavior. When cancelling an 
overwrite in the middle of the process I got only a partially copied file at 
the destination path. Tested in the latest git-stable KDE Neon, the procedure 
was a copying of the source file to the other folder containing the file with 
the same name. Perhaps you told about some other kind of an overwrite operation?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10663

To: dmitrio, #frameworks, dfaure, ngraham
Cc: elvisangelaccio, ngraham, anthonyfieroni, meven, #frameworks, michaelh, 
bruns

D12650: Fix incorrect version in @since tag

[Huon Imberger]

huoni created this revision.
huoni added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
huoni requested review of this revision.

REVISION SUMMARY
  The following functions only appeared in v5.39, however their @since
  tag specified v5.38.
  
  `KIconLoader::setCustomPalette()`
  `KIconLoader::customPalette()`
  `KIconLoader::resetPalette()`

TEST PLAN
  Ensure the above functions didn't exist in v5.38

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12650

AFFECTED FILES
  src/kiconloader.h

To: huoni, #frameworks
Cc: michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Nathaniel Graham]

ngraham added a comment.


  Seems like nobody has any objections. Wanna land this, @anemeth?

REPOSITORY
  R241 KIO

BRANCH
  image_smooth_downscale (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12385

To: anemeth, #frameworks, #vdg, ngraham, elvisangelaccio, rkflx
Cc: cfeck, broulik, ngraham, #frameworks, michaelh, bruns

D12513: CVE-2018-10361: privilege escalation

[Albert Astals Cid]

aacid added a comment.


  Next time please use arc to upload patches, so that instead of those ugly 
"Context not available." we get nice links to see more code :)
  
  @mgerstner I don't really understand why we need the chdir, renameat, etc.
  
  Dropping privileges to the minimum needed should be enough, shouldn't it?
  
  I mean at that point the only thing that can happen is that some user breaks 
files he can write to anyway, so why should we take extra precautions from that 
point on?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12513

To: cullmann, dfaure
Cc: mgerstner, aacid, ngraham, fvogt, cullmann, #frameworks, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D12388: Output device color curves correction

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Note frameworks tags are in 3 days. It would be reckless to rush merging 
anything.

REPOSITORY
  R127 KWayland

BRANCH
  outputColorCorrectionCurvesOnly

REVISION DETAIL
  https://phabricator.kde.org/D12388

To: romangg, #frameworks, davidedmundson
Cc: davidedmundson, zzag, cfeck, michaelh, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Nathaniel Graham]

ngraham added a comment.


  Yeah, once all is said and done, we might be able to remove both the View and 
Sorting menu items from the file dialog's context menu.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12337

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: andreaska, markg, broulik, anemeth, michaelh, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Nathaniel Graham]

ngraham updated this revision to Diff 33464.
ngraham added a comment.


  - Address review comments: Sorting > Sort by Name

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12337?vs=33459=33464

BRANCH
  arcpatch-D12337

REVISION DETAIL
  https://phabricator.kde.org/D12337

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kfilewidget.cpp

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: andreaska, markg, broulik, anemeth, michaelh, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12337

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: andreaska, markg, broulik, anemeth, michaelh, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Henrik Fehlauer]

rkflx added a comment.


  In D12337#256813 , @ngraham wrote:
  
  > the context menu will have "Sorting > Sort by name. Thoughts?
  
  
  Actually I'd still find that kind of acceptable.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12337

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: andreaska, markg, broulik, anemeth, michaelh, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Henrik Fehlauer]

rkflx added a comment.


  In D12337#256813 , @ngraham wrote:
  
  > Now we have a problem. With no text in the toolbar button, the actual items 
don't reveal their purpose so readily unless we change all of their strings to 
say "Sort by Name" (etc.). But if we do that, then the context menu will have 
"Sorting > Sort by name. Thoughts?
  
  
  What about injecting a header as proposed in D12337#249821 
?
  
  Or could we simply remove the context menu (only for the file dialog)?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12337

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: andreaska, markg, broulik, anemeth, michaelh, bruns

KDE CI: Frameworks baloo kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks baloo kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 37 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 37 test(s)

KDE CI: Frameworks kdoctools kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kdoctools kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 36 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Nathaniel Graham]

ngraham added a comment.


  Now we have a problem. With no text in the toolbar button, the actual items 
don't reveal their purpose so readily unless we change all of their strings to 
say "Sort by Name" (etc.). But if we do that, then the context menu will have 
"Sorting > Sort by name. Thoughts?
  
  The issue is that the strings for the submenu items are intimately tied to 
the text of the parent menu item or toolbar button. Opposition to a toolbar 
button with a label leads the submenu items being labeled wrong wrong for one 
of those two UIs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12337

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: andreaska, markg, broulik, anemeth, michaelh, bruns

KDE CI: Frameworks kplotting kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kplotting%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kplotting kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 35 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 34 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 34 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 12 test(s)

KDE CI: Frameworks kparts kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kparts%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kparts kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 33 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks kguiaddons kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kguiaddons%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kguiaddons kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 32 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 93 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/93/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 01 May 2018 21:12:33 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31673/59769)38%
(18597/48987)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8598/9151)48%
(5251/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)59%
(8426/14392)50%
(4907/9755)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3883/7883)33%
(1631/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.10 - Build # 1 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 31 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm

KDE CI: Frameworks bluez-qt kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks bluez-qt kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 31 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)

KDE CI: Frameworks kjs kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kjs%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kjs kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 29 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks kunitconversion kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kunitconversion kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 29 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 - Build # 1 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 28 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream

KDE CI: Frameworks kactivities kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kactivities%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kactivities kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 27 min and counting

KDE CI: Frameworks kbookmarks kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kbookmarks%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kbookmarks kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 27 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks knotifications kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks knotifications kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 26 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks sonnet kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks sonnet kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 26 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks attica kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks attica kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 24 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 1 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 24 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kmediaplayer kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kmediaplayer%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kmediaplayer kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 23 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks kconfigwidgets kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kconfigwidgets%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kconfigwidgets kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 22 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 245 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/245/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 01 May 2018 21:12:33 +
 Build duration:
6 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31569/59767)38%
(18553/48991)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8598/9151)48%
(5253/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8347/14390)50%
(4875/9751)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3883/7883)33%
(1631/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12337

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: andreaska, markg, broulik, anemeth, michaelh, bruns

KDE CI: Frameworks kpeople kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kpeople%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kpeople kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 21 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

D12321: Hide file preview when icon is too small

[Henrik Fehlauer]

rkflx added a comment.


  In D12321#256797 , @anemeth wrote:
  
  > In D12321#256791 , @ngraham 
wrote:
  >
  > > Reverted. Alex, now that you have a fancy contributor account, you can 
land this yourself on 5/6/18, or else offer up a version of this without the 
tooltip change and petition to get that in for 5.46.
  >
  >
  > I'll rather wait.
  >  5/6 as in May 6th or June 5th?
  
  
  Please read the link I gave and understand what a string freeze is. As you 
have commit access now, that's your job to get right ;)

REPOSITORY
  R241 KIO

BRANCH
  conditional_preview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, elvisangelaccio
Cc: elvisangelaccio, markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, 
michaelh, bruns

KDE CI: Frameworks prison kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20prison%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks prison kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 20 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

D12648: Update mount point after mount operations

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The order of udisks evaluation has changed from:
  
  call Mount
  propertiesChanged
  mount call returns
  
  call Mount
  mount call returns
  propertiesChanged
  
  The mount has finished, but the property is not yet updated.
  
  Solid caches properties, updating them when they change. This worked
  before, but due to the re-ordering client code gets "setupDone" requests
  the mount point, gets an outdated version from the cache and we get
  errors. Invalidating the cache causes us to round-trip to the udisks
  daemon meaning we'll have the correct values.
  
  BUG: 370975

TEST PLAN
  Diagnosed but with dbus-monitor trace 
  Asked someone on the bug report to test this

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12648

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksdevice.cpp
  src/solid/devices/backends/udisks2/udisksdevice.h
  src/solid/devices/backends/udisks2/udisksstorageaccess.cpp

To: davidedmundson, #plasma
Cc: #frameworks, michaelh, bruns

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 19 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 18 test(s)

KDE CI: Frameworks kcrash kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kcrash kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 19 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

D12321: Hide file preview when icon is too small

[Nathaniel Graham]

ngraham added a comment.


  May 6th.

REPOSITORY
  R241 KIO

BRANCH
  conditional_preview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, elvisangelaccio
Cc: elvisangelaccio, markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, 
michaelh, bruns

D12321: Hide file preview when icon is too small

[Alex Nemeth]

anemeth added a comment.


  In D12321#256791 , @ngraham wrote:
  
  > Reverted. Alex, now that you have a fancy contributor account, you can land 
this yourself on 5/6/18, or else offer up a version of this without the tooltip 
change and petition to get that in for 5.46.
  
  
  I'll rather wait.
  5/6 as in May 6th or June 5th?

REPOSITORY
  R241 KIO

BRANCH
  conditional_preview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, elvisangelaccio
Cc: elvisangelaccio, markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, 
michaelh, bruns

KDE CI: Frameworks kimageformats kf5-qt5 FreeBSDQt5.10 - Build # 1 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kimageformats kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 18 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kimageformats-read-xcf

D12321: Hide file preview when icon is too small

[Henrik Fehlauer]

rkflx added a comment.


  In D12321#256786 , @ngraham wrote:
  
  > Darn, my bad. Could we revert just the tooltip string change and land that 
for 5.47, or would you prefer to hold the whole feature until 5.47?
  
  
  Well, the tooltip was added for a reason. The reason is still there, so the 
tooltip still has to be there.
  
  Maybe later on we won't need the tooltip when removing the button, but until 
that's done (and agreed upon – I did not see any agreement from others, yet you 
already started on the implementation…), it should stay. Let's not rush this 
please, it only leads to more work in the end.

REPOSITORY
  R241 KIO

BRANCH
  conditional_preview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, elvisangelaccio
Cc: elvisangelaccio, markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, 
michaelh, bruns

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 17 min and counting

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Nathaniel Graham]

ngraham updated this revision to Diff 33459.
ngraham added a comment.


  - Address review comments

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12337?vs=32533=33459

BRANCH
  arcpatch-D12337

REVISION DETAIL
  https://phabricator.kde.org/D12337

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kfilewidget.cpp

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: andreaska, markg, broulik, anemeth, michaelh, bruns

KDE CI: Frameworks kholidays kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kholidays%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kholidays kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 16 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D12321: Hide file preview when icon is too small

[Nathaniel Graham]

ngraham reopened this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Reverted. Alex, now that you have a fancy contributor account, you can land 
this yourself on 5/6/18, or else offer up a version of this without the tooltip 
change and petition to get that in for 5.46.

REPOSITORY
  R241 KIO

BRANCH
  conditional_preview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, elvisangelaccio
Cc: elvisangelaccio, markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, 
michaelh, bruns

KDE CI: Frameworks kiconthemes kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kiconthemes kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 16 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 15 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks kdnssd kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kdnssd%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kdnssd kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 14 min and counting

KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 13 min and counting

D12321: Hide file preview when icon is too small

[Nathaniel Graham]

ngraham added a comment.


  Well, I'll revert and then we can discuss whether or not we can land a more 
limited version without the tooltip change.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, elvisangelaccio
Cc: elvisangelaccio, markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, 
michaelh, bruns

KDE CI: Frameworks frameworkintegration kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20frameworkintegration%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks frameworkintegration kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 13 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kservice kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 12 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 10 test(s)

KDE CI: Frameworks oxygen-icons5 kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20oxygen-icons5%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks oxygen-icons5 kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 11 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 10 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

KDE CI: Frameworks kemoticons kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kemoticons kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 10 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks kauth kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kauth%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kauth kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 8 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks kded kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kded%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kded kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 8 min and counting

KDE CI: Frameworks knewstuff kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks knewstuff kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 7 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

D12321: Hide file preview when icon is too small

[Nathaniel Graham]

ngraham added a comment.


  Darn, my bad. Could we revert just the tooltip string change and land that 
for 5.47, or would you prefer to hold the whole feature until 5.47?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, elvisangelaccio
Cc: elvisangelaccio, markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, 
michaelh, bruns

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 7 min and counting

KDE CI: Frameworks kross kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kross%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kross kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 7 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks kglobalaccel kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kglobalaccel kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 5 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 - Build # 1 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kconfig kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 5 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 33 test(s), Skipped: 0 test(s), Total: 35 test(s)Failed: TestSuite.kconfigcore-kconfigtestFailed: TestSuite.kconfigcore-test_kconf_update

D12641: Workaround Device Notifier showing an error despite volume being mounted correctly

[Mariusz Libera]

mlibera abandoned this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12641

To: mlibera, #plasma, broulik, #frameworks
Cc: anthonyfieroni, bruns, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 4 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 66 test(s)

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 1 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
7 hr 2 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 92 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/92/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 01 May 2018 20:45:32 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfilecustomdialogtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31677/59787)38%
(18601/48999)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8593/9151)48%
(5250/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8416/14392)50%
(4907/9755)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3907/7901)33%
(1638/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%

D12321: Hide file preview when icon is too small

[Henrik Fehlauer]

rkflx added a comment.


  In D12321#253903 , @rkflx wrote:
  
  > Cool, LGTM now. Due to the string change this will have to wait for 5.47
  
  
  ...and I even added a warning :/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, elvisangelaccio
Cc: elvisangelaccio, markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, 
michaelh, bruns

KDE CI: Frameworks kjsembed kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kjsembed%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kjsembed kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 3 min and counting

KDE CI: Frameworks kcmutils kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kcmutils%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kcmutils kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
7 hr 0 min and counting

D12321: Hide file preview when icon is too small

[Henrik Fehlauer]

rkflx added a comment.


  This breaks the string freeze. Please revert.
  
  See https://community.kde.org/Schedules/Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, elvisangelaccio
Cc: elvisangelaccio, markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, 
michaelh, bruns

KDE CI: Frameworks kidletime kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kidletime%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kidletime kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
6 hr 59 min and counting

KDE CI: Frameworks kcompletion kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kcompletion%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kcompletion kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
6 hr 58 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

KDE CI: Frameworks kdbusaddons kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kdbusaddons%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kdbusaddons kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
6 hr 58 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks kwallet kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwallet%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kwallet kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
6 hr 57 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks kdeclarative kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kdeclarative kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
6 hr 56 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

D12388: Output device color curves correction

[Roman Gilg]

romangg marked an inline comment as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12388

To: romangg, #frameworks
Cc: davidedmundson, zzag, cfeck, michaelh, bruns

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Oops, updated the wrong revision. This wasn't gonna get done anyway.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12333

To: ngraham, #frameworks, #dolphin, #vdg
Cc: abetts, jtamate, broulik, anemeth, rkflx, michaelh, bruns

D12388: Output device color curves correction

[Roman Gilg]

romangg updated this revision to Diff 33453.
romangg added a comment.


  - memcpy wl_array in colorcurvesCallback

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12388?vs=33397=33453

BRANCH
  outputColorCorrectionCurvesOnly

REVISION DETAIL
  https://phabricator.kde.org/D12388

AFFECTED FILES
  autotests/client/test_wayland_outputdevice.cpp
  autotests/client/test_wayland_outputmanagement.cpp
  src/client/outputconfiguration.cpp
  src/client/outputconfiguration.h
  src/client/outputdevice.cpp
  src/client/outputdevice.h
  src/client/protocols/output-management.xml
  src/client/protocols/outputdevice.xml
  src/server/outputchangeset.cpp
  src/server/outputchangeset.h
  src/server/outputchangeset_p.h
  src/server/outputconfiguration_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/outputdevice_interface.h

To: romangg, #frameworks
Cc: davidedmundson, zzag, cfeck, michaelh, bruns

KDE CI: Frameworks kxmlrpcclient kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kxmlrpcclient%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks kxmlrpcclient kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
6 hr 55 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks knotifyconfig kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20knotifyconfig%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks knotifyconfig kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
6 hr 55 min and counting

KDE CI: Frameworks threadweaver kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks threadweaver kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:16 +
 Build duration:
6 hr 54 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.10/1/
 Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 01 May 2018 13:57:17 +
 Build duration:
6 hr 54 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

[Nathaniel Graham]

ngraham updated this revision to Diff 33452.
ngraham added a comment.


  - Merge master
  - Remove custom styling

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12333?vs=32522=33452

BRANCH
  move-sort-order-chooser-to-toolbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12333

AFFECTED FILES
  autotests/kfileplacesviewtest.cpp
  src/core/batchrenamejob.h
  src/core/connectionserver.h
  src/core/copyjob.h
  src/core/dataslave_p.h
  src/core/deletejob.h
  src/core/directorysizejob.h
  src/core/emptytrashjob.h
  src/core/filecopyjob.h
  src/core/filesystemfreespacejob.h
  src/core/forwardingslavebase.h
  src/core/hostinfo.cpp
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister.h
  src/core/krecentdocument.cpp
  src/core/listjob.h
  src/core/mimetypejob.h
  src/core/mkdirjob.h
  src/core/mkpathjob.cpp
  src/core/mkpathjob.h
  src/core/multigetjob.h
  src/core/restorejob.h
  src/core/scheduler.cpp
  src/core/simplejob.h
  src/core/statjob.h
  src/core/tcpslavebase.h
  src/core/transferjob.h
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdirsortfilterproxymodel.h
  src/filewidgets/kfilebookmarkhandler_p.h
  src/filewidgets/kfilecopytomenu.h
  src/filewidgets/kfilecustomdialog.h
  src/filewidgets/kfilefiltercombo.h
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp
  src/filewidgets/kfileplacesview.h
  src/filewidgets/kfilepreviewgenerator.cpp
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h
  src/filewidgets/kimagefilepreview.h
  src/filewidgets/kpreviewwidgetbase.h
  src/filewidgets/kurlnavigator.cpp
  src/filewidgets/kurlnavigator.h
  src/filewidgets/kurlnavigatorbutton.cpp
  src/filewidgets/kurlnavigatordropdownbutton_p.h
  src/filewidgets/kurlnavigatormenu_p.h
  src/filewidgets/kurlnavigatorplacesselector_p.h
  src/filewidgets/kurlnavigatortogglebutton_p.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/kauth/file.actions
  src/ioslaves/trash/kcmtrash.desktop
  src/pathhelpers_p.h
  src/urifilters/ikws/searchproviders/qt.desktop
  src/urifilters/ikws/searchproviders/qt4.desktop
  src/widgets/kpropertiesdialog.cpp

To: ngraham, #frameworks, #dolphin, #vdg
Cc: abetts, jtamate, broulik, anemeth, rkflx, michaelh, bruns