D9219: WIP: Extend Scripting API

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  ;=)
  Just missed that.
  Why not ;)

REPOSITORY
  R39 KTextEditor

BRANCH
  Scripting (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9219

To: dhaumann, cullmann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D9219: WIP: Extend Scripting API

[Dominik Haumann]

dhaumann added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel, 
kwrite-devel; removed: Frameworks.


  @cullmann ping? :-)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9219

To: dhaumann, cullmann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann, #frameworks

D12508: Make KMessageWidget match Kirigami inlineMessage's style

[Dominik Haumann]

dhaumann added a comment.


  I think the setIcon() is also buggy, since if you call setIcon() and then 
setMessageType(), the icon is lost. So yes, I would be in favor of a better 
solution.
  
  If you revert the setIcon() part, do the screenshot examples all loose their 
icon? Or is it still set explicitly in the respective application code?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12508

To: ngraham, hein, #plasma, #vdg, cfeck
Cc: kde-frameworks-devel, dhaumann, broulik, anemeth, abetts, cfeck, mart, 
fabianr, elvisangelaccio, jnoack, michaelh, ngraham, bruns

D12508: Make KMessageWidget match Kirigami inlineMessage's style

[Nathaniel Graham]

ngraham added a comment.


  Sure, I'll be happy to fix those issues.
  
  The additional `setIcon()` call is to match the behavior of the Kirigami 
version, which always has an icon by default. I can revert that if we're okay 
with having it be a little bit inconsistent with the Kirigami version.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12508

To: ngraham, hein, #plasma, #vdg, cfeck
Cc: kde-frameworks-devel, dhaumann, broulik, anemeth, abetts, cfeck, mart, 
fabianr, elvisangelaccio, jnoack, michaelh, ngraham, bruns

D12320: [RFC] add ability to read embedded cover files

[Anthony Fieroni]

anthonyfieroni added a comment.


  In D12320#260768 , @astippich 
wrote:
  
  > Unfortunately, found it only after I wrote all that myself :/
  
  
  Sorry i don't see RFC earlier.
  
  In D12320#260768 , @astippich 
wrote:
  
  > Off topic: The file preview does only work for folder previews, but for the 
individual files the previews are not shown. Is that intended behavior?
  
  
  It *should* work for files as well as folders. Recently was added a patch 
that disable file preview for small sizes, can you increase icon size by slider?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12320

To: astippich, mgallien, michaelh, bruns
Cc: anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham

D12508: Make KMessageWidget match Kirigami inlineMessage's style

[Dominik Haumann]

dhaumann added a comment.


  Somehow my other comments were lost, here we go:
  
  - could you also update the screenshot in the doxygen documentation?
  - setIcon() is behavior incompatible, and in fact, the referenced bugs did 
not complain about icons. So why the change? In my opinion this is not good 
enough in case of Kate/KWrite.
  - setIcon(): Now the API documentation in the header file is wrong, since it 
says by default no icon is set.
  
  @ngraham Could we have another revision?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12508

To: ngraham, hein, #plasma, #vdg, cfeck
Cc: kde-frameworks-devel, dhaumann, broulik, anemeth, abetts, cfeck, mart, 
fabianr, elvisangelaccio, jnoack, michaelh, ngraham, bruns

D12508: Make KMessageWidget match Kirigami inlineMessage's style

[Dominik Haumann]

dhaumann added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  Can we revert the setIcon() part? It changes application behavior, an in the 
case of Kate/KWrite, this is note wanted, see my comments.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12508

To: ngraham, hein, #plasma, #vdg, cfeck
Cc: kde-frameworks-devel, dhaumann, broulik, anemeth, abetts, cfeck, mart, 
fabianr, elvisangelaccio, jnoack, michaelh, ngraham, bruns, #frameworks

D12270: Create a public function to access the actionMenu

[Nathaniel Graham]

ngraham abandoned this revision.
Restricted Application added a subscriber: kde-frameworks-devel.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12270

To: ngraham, #frameworks
Cc: kde-frameworks-devel, broulik, michaelh, ngraham, bruns

D12392: Fix the "Default" color scheme to match Breeze again

[Nathaniel Graham]

ngraham added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  Ping? Shell I take silence to mean tacit acceptance?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D12392

To: ngraham, #breeze, #plasma, hein
Cc: kde-frameworks-devel, cfeck, abetts, michaelh, ngraham, bruns, #frameworks

D12320: [RFC] add ability to read embedded cover files

[Alexander Stippich]

astippich added a comment.


  In D12320#260761 , @anthonyfieroni 
wrote:
  
  > I do *same* thing in KIO-Extras 
https://phabricator.kde.org/source/kio-extras/browse/master/thumbnail/audiocreator.cpp
  
  
  Yeah, I found that when I was looking into what's needed for a preview for 
audio files and was quite surprised.
  Unfortunately, found it only after I wrote all that myself :/
  Anyways, KFIleMetaData needs such a thing.
  Off topic: The file preview does only work for folder previews, but for the 
individual files the previews are not shown. Is that intended behavior?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12320

To: astippich, mgallien, michaelh, bruns
Cc: anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 260 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/260/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 10 May 2018 17:37:00 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31757/60011)38%
(18746/49362)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8704/9259)48%
(5403/11151)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8391/14498)50%
(4899/9804)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3900/7899)33%
(1638/4952)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

D12320: [RFC] add ability to read embedded cover files

[Anthony Fieroni]

anthonyfieroni added a comment.


  I do *same* thing in KIO-Extras 
https://phabricator.kde.org/source/kio-extras/browse/master/thumbnail/audiocreator.cpp

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12320

To: astippich, mgallien, michaelh, bruns
Cc: anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 259 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/259/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 10 May 2018 17:23:06 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31757/60011)38%
(18739/49362)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8704/9259)48%
(5405/11151)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8391/14498)50%
(4890/9804)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3900/7899)33%
(1638/4952)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 109 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/109/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 10 May 2018 17:29:00 +
 Build duration:
4 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31784/60011)38%
(18742/49358)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8704/9259)48%
(5403/11151)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8439/14498)50%
(4910/9808)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3901/7899)33%
(1639/4952)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/15/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Thu, 10 May 2018 17:27:46 +
 Build duration:
3 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 108 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/108/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 10 May 2018 17:23:06 +
 Build duration:
5 min 53 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31755/59905)38%
(18735/49305)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8702/9259)48%
(5406/11151)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8415/14392)50%
(4907/9755)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3901/7899)33%
(1639/4952)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1780/4338)34%
(1364/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/14/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Thu, 10 May 2018 17:23:06 +
 Build duration:
4 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D12696: Use the new uds implementation

[Jaime Torres Amate]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e80c31163170: Use the new uds implementation (authored by 
jtamate).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12696?vs=33929=33957

REVISION DETAIL
  https://phabricator.kde.org/D12696

AFFECTED FILES
  src/core/kfileitem.cpp
  src/core/listjob.cpp
  src/core/udsentry.cpp
  src/core/udsentry.h

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, bruns, michaelh, ngraham

D12371: Don't redirect smb:/ to smb:// and then to smb:///

[Jaime Torres Amate]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:2a57054a718a: Dont redirect smb:/ to smb:// and 
then to smb:/// (authored by jtamate).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D12371?vs=33872=33956#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12371?vs=33872=33956

REVISION DETAIL
  https://phabricator.kde.org/D12371

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: jtamate, dfaure, #frameworks, apol
Cc: kde-frameworks-devel, anthonyfieroni, apol, michaelh, ngraham, bruns

D12371: Don't redirect smb:/ to smb:// and then to smb:///

[Jaime Torres Amate]

jtamate retitled this revision from "fix always reproducible crash" to "Don't 
redirect smb:/ to smb:// and then to smb:///".
jtamate edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12371

To: jtamate, dfaure, #frameworks, apol
Cc: kde-frameworks-devel, anthonyfieroni, apol, michaelh, ngraham, bruns

D12320: [RFC] add ability to read embedded cover files

[Alexander Stippich]

astippich marked 4 inline comments as done.
astippich added a comment.


  Thanks a lot!

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12320

To: astippich, mgallien, michaelh, bruns
Cc: kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham

D12320: [RFC] add ability to read embedded cover files

[Alexander Stippich]

astippich updated this revision to Diff 33955.
astippich added a comment.


  - fix usage of qflags
  - use unique_ptr

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12320?vs=33934=33955

BRANCH
  cover_read

REVISION DETAIL
  https://phabricator.kde.org/D12320

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/embeddedimagedatatest.cpp
  autotests/embeddedimagedatatest.h
  autotests/samplefiles/test.mpc
  src/CMakeLists.txt
  src/embeddedimagedata.cpp
  src/embeddedimagedata.h

To: astippich, mgallien, michaelh, bruns
Cc: kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham

D10937: Retouching of Screen Layout Selection OSD Icons

[Stefan Brüns]

bruns added a comment.


  Two remarks regarding the rotation icons:
  
  1. I would remove the keyboard from the icons - you will use these with a 
tablet, a 2-in-1, or a pivoted external display.
  
  2. For the large versions, rotate the content pictogram/window not by ~20 
degres, but ~70 degrees. Think of holding e.g. a tablet. You will typically 
rotate the screen first, and then rotate the contents back. If rotated by 70 
deg, the shown content will be upright.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, 
michaelh, crozbo, firef, alexeymin, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Andres Betts]

abetts added a comment.


  In D10937#260688 , @pstefan wrote:
  
  > In D10937#260289 , @abetts wrote:
  >
  > > In D10937#260277 , @ngraham 
wrote:
  > >
  > > > Someone will need to land the changes for you. I'd prefer a few more 
thumbs up first. @abetts, are you good with these?
  > >
  > >
  > > I am linking these a lot. I am "almost" there with the designs. I would 
just ask that the center image of the sample window be simplified. I think it 
has a lot of detail. Maybe we can tone it down by removing some elements and 
making the window look more simple.
  >
  >
  > Could you give me more examples of what you'd remove?  As in direction.
  
  
  I would remove the user image and the text representation. Make the window 
title bar bigger. Just leave it blank.
  
  > 
  > 
  >> Icons 5-6 have a representation that is meant to be a second screen, or a 
projector screen? Can you tell me what it is meant to represent?
  > 
  > It's supposed to be a projector screen. I took the original icon metaphor 
to be a projector screen, so I continued with that.
  
  For the projector idea, I am a bit split, because my experience tells me that 
in most cases people are just adding another monitor and not a projector, 
except when they are presenting in front of an audience. Adding an extra 
monitor is a more common situation than a presentation IMHO. Therefore, I 
wonder if you could provide an alternative design where you have a screen 
representation instead of a projector? Just to see the contrast.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, 
michaelh, crozbo, firef, alexeymin, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Stefan Brüns]

bruns added a comment.


  In D10937#260688 , @pstefan wrote:
  
  > It's supposed to be a projector screen. I took the original icon metaphor 
to be a projector screen, so I continued with that.
  
  
  I think you should remove the tripod - I have not seen a projector screen not 
mounted directly to a wall for a long time. IMHO, the tripod adds only clutter, 
but no information.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, 
michaelh, crozbo, firef, alexeymin, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan added a comment.


  In D10937#260289 , @abetts wrote:
  
  > In D10937#260277 , @ngraham 
wrote:
  >
  > > Someone will need to land the changes for you. I'd prefer a few more 
thumbs up first. @abetts, are you good with these?
  >
  >
  > I am linking these a lot. I am "almost" there with the designs. I would 
just ask that the center image of the sample window be simplified. I think it 
has a lot of detail. Maybe we can tone it down by removing some elements and 
making the window look more simple.
  
  
  Could you give me more examples of what you'd remove?  As in direction.
  
  > Icons 5-6 have a representation that is meant to be a second screen, or a 
projector screen? Can you tell me what it is meant to represent?
  
  It's supposed to be a projector screen. I took the original icon metaphor to 
be a projector screen, so I continued with that.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, 
michaelh, crozbo, firef, bruns, alexeymin, skadinna, aaronhoneycutt, mbohlender

D12320: [RFC] add ability to read embedded cover files

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> embeddedimagedata.cpp:69
> +
> +if (types == EmbeddedImageData::FrontCover) {
> +
> imageData.insert(EmbeddedImageData::FrontCover,d->getFrontCover(fileUrl,mimeType));

should be `types & EmbeddedImageData::FrontCover`

> embeddedimagedata.cpp:149
> +if (pictureFlac->type() == pictureFlac->FrontCover) {
> +return 
> QByteArray(pictureFlac->data().data(),pictureFlac->data().size());
> +}

missing space after `,`

> embeddedimagedata.cpp:170
> +// Attached Picture.
> +if (!lstPic.isEmpty()) {
> +for (TagLib::List::Iterator it = 
> lstPic.begin(); it != lstPic.end(); ++it) {

This is identical to the "audio/flac" case, can you use the same variable names 
etc. in both places?

> astippich wrote in embeddedimagedata.h:40
> std::make_unique is C++14, right? According to 
> https://community.kde.org/Frameworks/Policies#Frameworks_Qt_requirements
> C++11 is the currently minimum version, so I left it unchanged. This is also 
> similar to the other classes in KFileMetaData

`std::make_unique` is just a convenience helper

`auto foo = std::make_unique` is exactly the same as  `auto foo = 
std::unique_ptr(new Foo());`
see http://en.cppreference.com/w/cpp/memory/unique_ptr/make_unique

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12320

To: astippich, mgallien, michaelh, bruns
Cc: kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham

D12647: Move the inline preview button into the menu

[Nathaniel Graham]

ngraham added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  Now that previews are on by default but not shown for small icons, are there 
any other objections to doing this?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12647

To: ngraham, #frameworks, rkflx
Cc: kde-frameworks-devel, anemeth, michaelh, ngraham, bruns

D12801: search for album artist and albumartist tags in taglibextractor

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  album_artist

REVISION DETAIL
  https://phabricator.kde.org/D12801

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12800: split tests for better readability

[Stefan Brüns]

bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.


  Nice, thanks!

REPOSITORY
  R286 KFileMetaData

BRANCH
  split_tests

REVISION DETAIL
  https://phabricator.kde.org/D12800

To: astippich, mgallien, bruns
Cc: bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham

D12696: Use the new uds implementation

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12696

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, bruns, michaelh, ngraham

D12801: search for album artist and albumartist tags in taglibextractor

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: mgallien.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  album artist and albumartist tags are in use, so search for both in case one 
is missing

REPOSITORY
  R286 KFileMetaData

BRANCH
  album_artist

REVISION DETAIL
  https://phabricator.kde.org/D12801

AFFECTED FILES
  src/extractors/taglibextractor.cpp

To: astippich, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12800: split tests for better readability

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: mgallien.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  create separate test functions for different file types

REPOSITORY
  R286 KFileMetaData

BRANCH
  split_tests

REVISION DETAIL
  https://phabricator.kde.org/D12800

AFFECTED FILES
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h

To: astippich, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12320: [RFC] add ability to read embedded cover files

[Alexander Stippich]

astippich marked 2 inline comments as done.
astippich added inline comments.

INLINE COMMENTS

> mgallien wrote in embeddedimagedata.h:40
> You should be using a std::unique_ptr instead of a raw pointer. You also 
> should take care of either forbidding copy (operator= and copy constructor) 
> or implement them to perform a deep copy including duplicating the private 
> object.
> Currently, it will be implicitly shared between instances.
> In many classes in KDE repository you do not need to do it because QObject 
> inheritance gives you exactly that.

std::make_unique is C++14, right? According to 
https://community.kde.org/Frameworks/Policies#Frameworks_Qt_requirements
C++11 is the currently minimum version, so I left it unchanged. This is also 
similar to the other classes in KFileMetaData

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12320

To: astippich, mgallien, michaelh
Cc: kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham

D12320: [RFC] add ability to read embedded cover files

[Alexander Stippich]

astippich retitled this revision from "{RFC] add ability to read embedded cover 
files" to "[RFC] add ability to read embedded cover files".

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12320

To: astippich, mgallien, michaelh
Cc: kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham

D12320: {RFC] add ability to read embedded cover files

[Alexander Stippich]

astippich updated this revision to Diff 33934.
astippich added a comment.
Restricted Application edited subscribers, added: Baloo, kde-frameworks-devel; 
removed: Frameworks.


  - adjust to feedback

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12320?vs=33375=33934

BRANCH
  cover_read

REVISION DETAIL
  https://phabricator.kde.org/D12320

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/embeddedimagedatatest.cpp
  autotests/embeddedimagedatatest.h
  autotests/samplefiles/test.mpc
  src/CMakeLists.txt
  src/embeddedimagedata.cpp
  src/embeddedimagedata.h

To: astippich, mgallien, michaelh
Cc: kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 107 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/107/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 10 May 2018 08:29:31 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31785/59905)38%
(18765/49305)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8704/9259)48%
(5407/11151)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8419/14392)50%
(4911/9755)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3900/7899)33%
(1640/4952)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(522/1008)42%
(418/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 258 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/258/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 10 May 2018 08:29:31 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31727/59903)38%
(18731/49309)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8704/9259)48%
(5403/11151)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8357/14390)50%
(4881/9751)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3899/7899)33%
(1639/4952)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/13/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Thu, 10 May 2018 08:29:31 +
 Build duration:
5 min 16 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D12696: Use the new uds implementation

[Jaime Torres Amate]

jtamate updated this revision to Diff 33929.
jtamate marked 8 inline comments as done and 3 inline comments as done.
jtamate edited the summary of this revision.
jtamate added a comment.


  Added the documentation for insert.
  Removed the () from the QDataStream& operators, but must be kept for QDebug 
or clang++ will not compile.
  Adjusted the reserved amounts.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12696?vs=33889=33929

REVISION DETAIL
  https://phabricator.kde.org/D12696

AFFECTED FILES
  src/core/kfileitem.cpp
  src/core/listjob.cpp
  src/core/udsentry.cpp
  src/core/udsentry.h

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, bruns, michaelh, ngraham

D12538: Allow accepting by double-click in save dialog

[Alex Nemeth]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c537a717363c: Allow accepting by double-click in save 
dialog (authored by anemeth).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12538?vs=33914=33930

REVISION DETAIL
  https://phabricator.kde.org/D12538

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: kde-frameworks-devel, ltoscano, rkflx, broulik, jtamate, ngraham, 
#frameworks, michaelh, bruns

D12538: Allow accepting by double-click in save dialog

[Henrik Fehlauer]

rkflx accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D12538 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: kde-frameworks-devel, ltoscano, rkflx, broulik, jtamate, ngraham, 
#frameworks, michaelh, bruns