D13128: Make sure ungrab keyboard request is processed before emitting shortcut

2018-05-25 Thread Nathaniel Graham 
ngraham added reviewers: Frameworks, Plasma.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D13128

To: sontolbonggol, #frameworks, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13128: Make sure ungrab keyboard request is processed before emitting shortcut

2018-05-25 Thread Sontol Bonggol 
sontolbonggol edited the summary of this revision.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D13128

To: sontolbonggol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13128: Make sure ungrab keyboard request is processed before emitting shortcut

2018-05-25 Thread Sontol Bonggol 
sontolbonggol created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
sontolbonggol requested review of this revision.

REVISION SUMMARY
  In some rare cases, the ungrab keyboard request is processed later than
  the action of the key shortcut. This can make the application that try
  to grab the keyboard (e.g. in kwin) fail to do so. The solution is to
  use ungrab_keyboard_checked() and xcb_request_check() before emitting
  the shortcut signal.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D13128

AFFECTED FILES
  src/runtime/plugins/xcb/kglobalaccel_x11.cpp

To: sontolbonggol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

2018-05-25 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12756

To: ngraham, #frameworks, #vdg
Cc: cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D11529: Balooctl: Deindex unfound files with check command.

2018-05-25 Thread James Smith 
smithjd updated this revision to Diff 34892.
smithjd added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  - Uniformly use storageDevices.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11529?vs=31136=34892

BRANCH
  master-filedeindexer

REVISION DETAIL
  https://phabricator.kde.org/D11529

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/file/fileindexerconfig.h
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/file/indexcleaner.cpp
  src/file/indexerstate.h
  src/tools/balooctl/main.cpp

To: smithjd, #baloo, vhanda, michaelh, broulik
Cc: kde-frameworks-devel, mgallien, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, #frameworks

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

2018-05-25 Thread David Faure 
dfaure accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10410

To: chinmoyr, #frameworks, ossi, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12945: kcoredirlister lstItems benchmark

2018-05-25 Thread David Faure 
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcoredirlister_benchmark.cpp:244
> +uint hash=qHash(url);
> +auto it = std::lower_bound(lstItems.cbegin(), lstItems.cend(), hash, 
> lessThanHash);
> +if (it != lstItems.cend() && it->item->url() == url) {

As discussed in https://phabricator.kde.org/D10742, this doesn't handle the 
case of hash collisions (this code assumes each URL gets a unique hash). So 
this commit needs to be updated as well, possibly by just removing this class 
if making it right is too much effort, for too slow code in the end?

> kcoredirlister_benchmark.cpp:329
> +
> +template  void createFiles(int number)
> +{

`number` is always 50 so you could remove it as a parameter in all these 
methods and just use a static const int for instance.

It's more dangerous to have it as a method parameter: if one caller passes a 
different number, the benchmarks won't be comparable anymore...

> kcoredirlister_benchmark.cpp:376
> +QBENCHMARK {
> +for (int i=0; i<5000; i++) {
> +data.findByUrl(u1);

QBENCHMARK takes care of repeating as many times as necessary, so this for loop 
isn't needed, is it?

> kcoredirlister_benchmark.cpp:384
> +
> QUrl::fromLocalFile(QLatin1String("/home/user/Folder1/SubFolder2/a4505.txt")));
> +
> QCOMPARE(data.findByUrl(QUrl::fromLocalFile(QLatin1String("/home/user/Folder1/SubFolder2/a4505.txt")))->url(),
> +
> QUrl::fromLocalFile(QLatin1String("/home/user/Folder1/SubFolder2/a4505.txt")));

copy/paste errors? This is looking up the same URL three times.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12945

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 30 - Still Unstable!

2018-05-25 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/30/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 25 May 2018 23:01:08 +
 Build duration:
3 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(239/306)57%
(143/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)79%
(197/249)57%
(128/224)

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 86 - Still Unstable!

2018-05-25 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/86/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 25 May 2018 23:01:08 +
 Build duration:
1 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(239/306)57%
(143/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)79%
(197/249)57%
(128/224)

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 - Build # 6 - Still Unstable!

2018-05-25 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.10/6/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 25 May 2018 23:01:09 +
 Build duration:
1 min 21 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.scalable

D12728: KFileItemActions: fallback to default mimetype when selecting only files

2018-05-25 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  It should be easy to use lxr to see which KDE applications uses 
KFileItemListProperties::mimeType(), but OK, your solution is safer in case of 
third-party applications.

REPOSITORY
  R241 KIO

BRANCH
  kfileitemactions-emptymime (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12728

To: elvisangelaccio, #frameworks, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

2018-05-25 Thread Nathaniel Graham 
ngraham added a reviewer: VDG.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12756

To: ngraham, #frameworks, #vdg
Cc: cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

2018-05-25 Thread Nathaniel Graham 
ngraham retitled this revision from "[KDateTable] Use a more visible red color" 
to "[KDateTable] Use more appropriate and readable text colors for weekends and 
holidays".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12756

To: ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D12756: [KDateTable] Use a more visible red color

2018-05-25 Thread Nathaniel Graham 
ngraham updated this revision to Diff 34884.
ngraham added a comment.


  Use conditional grays instead of reds (red was never an appropriate color 
anyway)

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12756?vs=34883=34884

BRANCH
  arcpatch-D12756

REVISION DETAIL
  https://phabricator.kde.org/D12756

AFFECTED FILES
  src/kdatetable.cpp

To: ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D13120: fix i18n issues in framworks/purpose/plugins

2018-05-25 Thread Albert Astals Cid 
aacid added a comment.


  Are you sure you need the backslashes in add_definitions?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13120

To: lueck, #frameworks, #localization, nicolasfella, apol
Cc: aacid, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D12756: [KDateTable] Use a more visible red color

2018-05-25 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12756

To: ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D12756: [KDateTable] Use a more visible red color

2018-05-25 Thread Nathaniel Graham 
ngraham updated this revision to Diff 34883.
ngraham added a comment.


  Use a conditional lightness check but the same colors, pending a better color 
option (TBD)

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12756?vs=33824=34883

REVISION DETAIL
  https://phabricator.kde.org/D12756

AFFECTED FILES
  src/kdatetable.cpp

To: ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D13026: Open Schema toolbar button with normal click rather than click-and-hold

2018-05-25 Thread Nathaniel Graham 
ngraham added a comment.


  Fair enough!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13026

To: ngraham, #ktexteditor, #kate
Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

2018-05-25 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13026

To: ngraham, #ktexteditor, #kate
Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

2018-05-25 Thread Hugo Pereira Da Costa 
hpereiradacosta added a comment.


  Hello, 
  I would appreciate that you rephrase the description for this patch (and 
others where the same comment appear):  the dissapearing arrow with breeze is 
not a *bug* in breeze, but a (conscious) design choice, that is discussed in  
D13064  and in the bug attached.  D13064 
 is not fixing that bug, it is a proposal 
to revert that design choice.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13026

To: ngraham, #ktexteditor, #kate
Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D12756: [KDateTable] Use a more visible red color

2018-05-25 Thread Nathaniel Graham 
ngraham added a subscriber: cfeck.
ngraham added a comment.


  In D12756#268311 , @cfeck wrote:
  
  > I will not block this change, but cannot approve it either.
  >
  > Reasons:
  >
  > - The pure red is looks too saturated, as if something dangerous is about 
to happen. Maybe add the VDG as a reviewer.
  
  
  I understand, and agree. I'm also not sure that red is the right color here 
in the first place.
  
  > - We should not use hardcoded colors on varying backgrounds. While the 
chance that someone uses Qt::red as a background color is zero, the code 
_should_ handle the dark vs. bright case as stated in the bug report.
  
  OK, I'll implement that part at least (even if for now we keep the colors 
identical, whatever we choose).

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12756

To: ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D12756: [KDateTable] Use a more visible red color

2018-05-25 Thread Christoph Feck 
cfeck resigned from this revision.
cfeck added a comment.


  I will not block this change, but cannot approve it either.
  
  Reasons:
  
  - The pure red is looks too saturated, as if something dangerous is about to 
happen. Maybe add the VDG as a reviewer.
  - We should not use hardcoded colors on varying backgrounds. While the chance 
that someone uses Qt::red as a background color is zero, the code _should_ 
handle the dark vs. bright case as stated in the bug report.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12756

To: ngraham, #frameworks
Cc: kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D12756: [KDateTable] Use a more visible red color

2018-05-25 Thread Nathaniel Graham 
ngraham added a comment.


  Friendly ping!

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12756

To: ngraham, #frameworks, cfeck
Cc: kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D13026: Open Schema toolbar button with normal click rather than click-and-hold

2018-05-25 Thread Nathaniel Graham 
ngraham added a comment.


  Friendly ping!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13026

To: ngraham, #ktexteditor, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

2018-05-25 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13026

To: ngraham, #ktexteditor, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D13120: fix i18n issues in framworks/purpose/plugins

2018-05-25 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13120

To: lueck, #frameworks, #localization, nicolasfella, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D13120: fix i18n issues in framworks/purpose/plugins

2018-05-25 Thread Burkhard Lück 
lueck created this revision.
lueck added reviewers: Frameworks, Localization, nicolasfella.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
lueck requested review of this revision.

REVISION SUMMARY
  add missing TRANSLATION_DOMAIN to CMakeLists.txt to load the catalogs
  
  email
  
no *.rc + *.u files
rm $EXTRACTRC
  
  kdeconnect i18n() only in qml
  
use i18nd()
  
  nextcloud  i18n() in qml + in cpp
  
no *.rc + *.u files
rm $EXTRACTRC
  
  reviewboard i18n() in qml + in cpp
  
ok
  
  saveas i18n() in qml + in cpp
  
no *.rc + *.u files
rm $EXTRACTRC
  
  imgur i18n() in cpp
  
no *.rc + *.u files
rm $EXTRACTRC
  
  twitter 2 i18n() in qml
  
no *.rc + *.u files
rm $EXTRACTRC
only qml -> use i18nd()
  
  ktp-sendfile 1 i18n() in cpp
  
no *.rc + *.u files
rm $EXTRACTRC
  
  phabricator i18n() in qml + in cpp
  
no *.rc + *.u files
rm $EXTRACTRC
  
  youtube i18n() in qml + in cpp
  
no *.rc + *.u files
rm $EXTRACTRC
  
  pastebin i18n() in cpp
  
no *.rc + *.u files
rm $EXTRACTRC
  
  telegram/Messages.sh, but no i18n()
  
rm Messages.sh

TEST PLAN
  path/to/l10n-kf5/scripts/extract-messages.sh creates all catalogs

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13120

AFFECTED FILES
  src/plugins/email/CMakeLists.txt
  src/plugins/email/Messages.sh
  src/plugins/imgur/CMakeLists.txt
  src/plugins/imgur/Messages.sh
  src/plugins/kdeconnect/CMakeLists.txt
  src/plugins/kdeconnect/Messages.sh
  src/plugins/kdeconnect/kdeconnectplugin_config.qml
  src/plugins/ktp-sendfile/CMakeLists.txt
  src/plugins/ktp-sendfile/Messages.sh
  src/plugins/nextcloud/Messages.sh
  src/plugins/pastebin/CMakeLists.txt
  src/plugins/pastebin/Messages.sh
  src/plugins/phabricator/Messages.sh
  src/plugins/saveas/CMakeLists.txt
  src/plugins/saveas/Messages.sh
  src/plugins/telegram/Messages.sh
  src/plugins/twitter/Messages.sh
  src/plugins/twitter/contents/config/config.qml
  src/plugins/youtube/CMakeLists.txt
  src/plugins/youtube/Messages.sh

To: lueck, #frameworks, #localization, nicolasfella
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

2018-05-25 Thread Marco Martin 
mart added a comment.


  different version for a new round of discussion: try to implement the 
neighbour concept for the desktop that stay near asnother one, so there may be 
as many grids unconnected with each other as possible
  
  so far there is not integrity check that an added it is actually an existing 
desktop, but i would really rather add such checks and auto updates as well.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12820

To: mart, #kwin, #plasma, graesslin, hein
Cc: zzag, bshah, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

2018-05-25 Thread Marco Martin 
mart updated this revision to Diff 34871.
mart added a comment.


  - Revert "virtual diland Virtual desktop protocol"
  - rename the xml file to be consistent with the rest
  - fix copyright
  - replace the concept of layout with neighbours
  - smaller fixes

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12820?vs=33979=34871

BRANCH
  mart/plasmavirtualdesktop

REVISION DETAIL
  https://phabricator.kde.org/D12820

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_plasma_virtual_desktop.cpp
  src/client/CMakeLists.txt
  src/client/plasmavirtualdesktop.cpp
  src/client/plasmavirtualdesktop.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-virtual-desktop.xml
  src/client/protocols/plasma-window-management.xml
  src/client/registry.cpp
  src/client/registry.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/plasmavirtualdesktop_interface.cpp
  src/server/plasmavirtualdesktop_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  src/tools/mapping.txt

To: mart, #kwin, #plasma, graesslin, hein
Cc: zzag, bshah, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D13117: Don't set custom domain filter rules

2018-05-25 Thread Aleksander Morgado 
aleksanderm added a reviewer: Frameworks.

REPOSITORY
  R281 ModemManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D13117

To: aleksanderm, jgrulich, broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13117: Don't set custom domain filter rules

2018-05-25 Thread Aleksander Morgado 
aleksanderm created this revision.
aleksanderm added reviewers: jgrulich, broulik.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
aleksanderm requested review of this revision.

REVISION SUMMARY
  The library shouldn't set custom filter rules, it's a task of the app
  using the library to enable or disable them.

REPOSITORY
  R281 ModemManagerQt

BRANCH
  fix-logging

REVISION DETAIL
  https://phabricator.kde.org/D13117

AFFECTED FILES
  src/manager.cpp

To: aleksanderm, jgrulich, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13043: Properly sanitize input

2018-05-25 Thread Aleix Pol Gonzalez 
apol marked 3 inline comments as done.
apol added inline comments.

INLINE COMMENTS

> broulik wrote in kconcatenaterowsproxymodel.cpp:112
> You can also use `{}` here, no? Also, I would prefer an early return rather 
> than unary operator

No, the ternary operator doesn't allow using {} saying it can't infer the type. 
Can change to an if.

> broulik wrote in kconcatenaterowsproxymodel.cpp:151
> Coding style. Also, check `parent.isValid() return {};` since this is a flat 
> model?

why is it flat?

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D13043

To: apol, #frameworks
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13043: Properly sanitize input

2018-05-25 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 34858.
apol marked 2 inline comments as done.
apol added a comment.


  address kai's remarks

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13043?vs=34659=34858

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13043

AFFECTED FILES
  src/kconcatenaterowsproxymodel.cpp

To: apol, #frameworks
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.10 - Build # 20 - Still Unstable!

2018-05-25 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.10/20/
 Project:
Frameworks kimageformats kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 25 May 2018 11:37:57 +
 Build duration:
1 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-tgaFailed: TestSuite.kimageformats-read-xcfFailed: TestSuite.kimageformats-write-tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)79%
(19/24)79%
(19/24)42%
(1532/3631)36%
(798/2228)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)75%
(283/379)59%
(149/252)src.imageformats83%
(15/18)83%
(15/18)40%
(1245/3118)34%
(647/1918)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.9 - Build # 13 - Still Unstable!

2018-05-25 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.9/13/
 Project:
Frameworks kimageformats kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 25 May 2018 11:37:57 +
 Build duration:
1 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-xcf
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)88%
(21/24)88%
(21/24)46%
(1663/3633)38%
(847/2228)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)72%
(273/379)51%
(129/252)src.imageformats94%
(17/18)94%
(17/18)44%
(1386/3120)37%
(716/1918)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

KDE CI: Frameworks kimageformats kf5-qt5 FreeBSDQt5.10 - Build # 5 - Still Unstable!

2018-05-25 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20FreeBSDQt5.10/5/
 Project:
Frameworks kimageformats kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 25 May 2018 11:37:57 +
 Build duration:
1 min 16 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kimageformats-read-xcf

D13102: Don't include a 64 when building 64bit architectures on flatpak

2018-05-25 Thread Aleix Pol Gonzalez 
apol added a comment.


  In D13102#268015 , @cgiboudeaux 
wrote:
  
  > Please update the doc above.
  
  
  the documentation right now is:
  
# ``LIBDIR``
# object code libraries (``EXECROOTDIR/lib``, ``EXECROOTDIR/lib64`` or
# ``EXECROOTDIR/lib/

D3837: [Calendar] Optimize Backend

2018-05-25 Thread Kai Uwe Broulik 
broulik abandoned this revision.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D3837

To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, davidedmundson, plasma-devel, ragreen, Pitel, 
michaelh, ZrenBot, ngraham, bruns, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, #frameworks

D3838: [Calendar] Optimize day delegate

2018-05-25 Thread Kai Uwe Broulik 
broulik abandoned this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D3838

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, plasma-devel, ragreen, Pitel, michaelh, ZrenBot, 
ngraham, bruns, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D13102: Don't include a 64 when building 64bit architectures on flatpak

2018-05-25 Thread Christophe Giboudeaux 
cgiboudeaux added a comment.


  Please update the doc above.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D13102

To: apol, #frameworks
Cc: cgiboudeaux, eszlari, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns