D13510: Add XDG WM Base support to our XDGShell API

2018-06-13 Thread David Edmundson 
davidedmundson updated this revision to Diff 36127.
davidedmundson marked 2 inline comments as done.
davidedmundson added a comment.


  ZZag's comments

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13510?vs=36089=36127

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13510

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_shell.cpp
  autotests/client/test_xdg_shell_stable.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-shell.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgshell.cpp
  src/client/xdgshell.h
  src/client/xdgshell_p.h
  src/client/xdgshell_stable.cpp
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/xdgshell_interface.h
  src/server/xdgshell_stable_interface.cpp
  src/server/xdgshell_stable_interface_p.h

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13510: Add XDG WM Base support to our XDGShell API

2018-06-13 Thread David Edmundson 
davidedmundson marked 10 inline comments as done.
davidedmundson added inline comments.

INLINE COMMENTS

> zzag wrote in test_xdg_shell.cpp:120
> Missing `default`. Is it okay if version is unknown?

IMHO it's better not to as it means we get a compile time warning in the 
unlikely event that someone adds a new value to the enum without updating this.

> zzag wrote in xdgshell_stable_interface.cpp:242-243
> Which one should return?

oops, thanks

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13510

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13211: Enable comparing KFileItems by url

2018-06-13 Thread Mark Gaiser 
markg added a comment.


  While this works, there is a newer en better way for it.
  It's new in C++14 and called "transparent compare".
  In "this" case it won't change the resulting code of how you compare, but it 
might be worth checking that out.
  
  Read this: https://www.fluentcpp.com/2017/06/09/search-set-another-type-key/
  And watch this: https://www.youtube.com/watch?v=BBUacofxOP8
  
  those will explain how to use it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13211

To: jtamate, dfaure
Cc: markg, bruns, kde-frameworks-devel, michaelh, ngraham

D13442: Implemented displaying of total lines in kate

2018-06-13 Thread Shubham 
shubham added a comment.


  Since the word count option is similar to line count in the config options, 
can't I just show word count and line count with a single button option?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 50 - Still Unstable!

2018-06-13 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/50/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Wed, 13 Jun 2018 17:32:58 +
 Build duration:
4 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D13211: Enable comparing KFileItems by url

2018-06-13 Thread Jaime Torres Amate 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:fb3c94ed96c3: Enable comparing KFileItems by url 
(authored by jtamate).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13211?vs=36037=36112

REVISION DETAIL
  https://phabricator.kde.org/D13211

AFFECTED FILES
  autotests/kfileitemtest.cpp
  autotests/kfileitemtest.h
  src/core/kfileitem.cpp
  src/core/kfileitem.h

To: jtamate, dfaure
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D13515: Remove KNS::Engine d-pointer hack

2018-06-13 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:d659619e0c96: Remove KNS::Engine d-pointer hack (authored 
by apol).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13515?vs=36098=36105

REVISION DETAIL
  https://phabricator.kde.org/D13515

AFFECTED FILES
  src/core/engine.cpp
  src/core/engine.h

To: apol, #frameworks, leinir, mwolff
Cc: mwolff, kde-frameworks-devel, michaelh, ngraham, bruns

D13402: FrameSvg: Simplify updateSizes

2018-06-13 Thread Vlad Zagorodniy 
zzag added a comment.


  Ping.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13402

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

2018-06-13 Thread Vlad Zagorodniy 
zzag added a comment.


  Ping?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13384

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13502: Fix compiler warning about hidden virtual overloads

2018-06-13 Thread Vlad Zagorodniy 
zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  In D13502#277837 , @davidedmundson 
wrote:
  
  > ...
  >  But if this is accepted as a good solution for the problem, ...
  
  
  Well, yeah, that's pretty good solution to name hiding. Another solution 
would be to implement hidden overloads.

REPOSITORY
  R127 KWayland

BRANCH
  xdg_squash

REVISION DETAIL
  https://phabricator.kde.org/D13502

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13442: Implemented displaying of total lines in kate

2018-06-13 Thread Shubham 
shubham added a comment.


  In D13442#277786 , @ngraham wrote:
  
  > I'm not sure how to do that, and I realize it might be a lot of work.
  >
  > In D13442#277600 , @shubham 
wrote:
  >
  > > How can the self toggling be done based on the space available?
  >
  >
  > Conceptually, I would have the status bar emit a signal when it's about to 
elide some of its text, and then connect that to a slot that hides content as 
needed.
  
  
  Seems like they want it as a context menu option

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13502: Fix compiler warning about hidden virtual overloads

2018-06-13 Thread David Edmundson 
davidedmundson added a comment.


  Yes, but it gets complex with the existing XDGShell having a tonne of other 
changes on phab.
  But if this is accepted as a good solution for the problem, I'll fixup 
XDGShell when we merge that.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13502

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13515: Remove KNS::Engine d-pointer hack

2018-06-13 Thread Milian Wolff 
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  this is binary compatible from what I can see

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13515

To: apol, #frameworks, leinir, mwolff
Cc: mwolff, kde-frameworks-devel, michaelh, ngraham, bruns

D13502: Fix compiler warning about hidden virtual overloads

2018-06-13 Thread Vlad Zagorodniy 
zzag added a comment.


  In D13502#277828 , @davidedmundson 
wrote:
  
  > I meant the class I changed no longer had warnings.
  
  
  Oh, I thought you were talking about all -Woverloaded-virtual warnings. I 
think it would be better to fix those warnings in one go.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13502

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13502: Fix compiler warning about hidden virtual overloads

2018-06-13 Thread David Edmundson 
davidedmundson added a comment.


  I meant the class I changed no longer had warnings.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13502

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13502: Fix compiler warning about hidden virtual overloads

2018-06-13 Thread Vlad Zagorodniy 
zzag added a comment.


  > Compiles with no warnings \o/
  
  Nope.
  
In file included from 
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v6.cpp:20:
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:49:13: 
warning: ‘virtual KWayland::Client::XdgShell::Private::operator xdg_shell*() 
const’ was hidden [-Woverloaded-virtual]
 virtual operator xdg_shell*() const {
 ^~~~
: warning:   by ‘operator’ [-Woverloaded-virtual]
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:46:13: 
warning: ‘virtual KWayland::Client::XdgShell::Private::operator xdg_shell*()’ 
was hidden [-Woverloaded-virtual]
 virtual operator xdg_shell*() {
 ^~~~
: warning:   by ‘operator’ [-Woverloaded-virtual]
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:60:28: 
warning: ‘virtual KWayland::Client::XdgShellPopup* 
KWayland::Client::XdgShell::Private::getXdgPopup(KWayland::Client::Surface*, 
KWayland::Client::Surface*, KWayland::Client::Seat*, quint32, const QPoint&, 
QObject*)’ was hidden [-Woverloaded-virtual]
 virtual XdgShellPopup *getXdgPopup(Surface *surface, Surface 
*parentSurface, Seat *seat, quint32 serial, const QPoint , QObject 
*parent) {
^~~
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v6.cpp:45:20: 
warning:   by ‘KWayland::Client::XdgShellUnstableV6::Private::getXdgPopup’ 
[-Woverloaded-virtual]
 XdgShellPopup *getXdgPopup(Surface *surface, XdgShellPopup 
*parentSurface, const XdgPositioner , QObject *parent) override;
^~~
In file included from 
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v6.cpp:20:
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:163:13: 
warning: ‘virtual KWayland::Client::XdgShellSurface::Private::operator 
xdg_surface*() const’ was hidden [-Woverloaded-virtual]
 virtual operator xdg_surface*() const {
 ^~~~
: warning:   by ‘operator’ [-Woverloaded-virtual]
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:160:13: 
warning: ‘virtual KWayland::Client::XdgShellSurface::Private::operator 
xdg_surface*()’ was hidden [-Woverloaded-virtual]
 virtual operator xdg_surface*() {
 ^~~~
: warning:   by ‘operator’ [-Woverloaded-virtual]
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:225:13: 
warning: ‘virtual KWayland::Client::XdgShellPopup::Private::operator 
xdg_popup*() const’ was hidden [-Woverloaded-virtual]
 virtual operator xdg_popup*() const {
 ^~~~
: warning:   by ‘operator’ [-Woverloaded-virtual]
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:222:13: 
warning: ‘virtual KWayland::Client::XdgShellPopup::Private::operator 
xdg_popup*()’ was hidden [-Woverloaded-virtual]
 virtual operator xdg_popup*() {
 ^~~~
: warning:   by ‘operator’ [-Woverloaded-virtual]

In file included from 
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v5.cpp:20:
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:55:13: 
warning: ‘virtual KWayland::Client::XdgShell::Private::operator 
zxdg_shell_v6*() const’ was hidden [-Woverloaded-virtual]
 virtual operator zxdg_shell_v6*() const {
 ^~~~
: warning:   by ‘operator’ [-Woverloaded-virtual]
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:52:13: 
warning: ‘virtual KWayland::Client::XdgShell::Private::operator 
zxdg_shell_v6*()’ was hidden [-Woverloaded-virtual]
 virtual operator zxdg_shell_v6*() {
 ^~~~
: warning:   by ‘operator’ [-Woverloaded-virtual]
In file included from 
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v5.cpp:20:
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:80:28: 
warning: ‘virtual KWayland::Client::XdgShellPopup* 
KWayland::Client::XdgShell::Private::getXdgPopup(KWayland::Client::Surface*, 
KWayland::Client::XdgShellPopup*, const KWayland::Client::XdgPositioner&, 
QObject*)’ was hidden [-Woverloaded-virtual]
 virtual XdgShellPopup *getXdgPopup(Surface *surface, XdgShellPopup 
*parentSurface, const XdgPositioner , QObject *parent) {
^~~
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v5.cpp:41:20: 
warning:   by ‘virtual KWayland::Client::XdgShellPopup* 
KWayland::Client::XdgShellUnstableV5::Private::getXdgPopup(KWayland::Client::Surface*,
 KWayland::Client::Surface*, KWayland::Client::Seat*, quint32, const QPoint&, 
QObject*)’ [-Woverloaded-virtual]
 XdgShellPopup *getXdgPopup(Surface *surface, Surface *parentSurface, 
Seat *seat, quint32 serial, const QPoint , QObject *parent) override;
^~~
In file included from

D13515: Remove KNS::Engine d-pointer hack

2018-06-13 Thread Dan Leinir Turthra Jensen 
leinir added a comment.


  H... this is tricky, but... yes, it seems reasonable to me that replacing 
one pointer with another would cause no BIC issues... and i certainly am happy 
to get rid of the d-pointer hack, so... if we're absolutely super-sure that 
this is BC, i'm all for it... would kind of like someone with better linker-fu 
to give word on this, but in principle, i like :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13515

To: apol, #frameworks, leinir
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13515: Remove KNS::Engine d-pointer hack

2018-06-13 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added reviewers: Frameworks, leinir.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Put one of the pointers in KNS::Engine in the d-pointer and normally store the
  d-pointer as a class member, instead of doing it statically.

TEST PLAN
  Tests still pass, discover still runs

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13515

AFFECTED FILES
  src/core/engine.cpp
  src/core/engine.h

To: apol, #frameworks, leinir
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13442: Implemented displaying of total lines in kate

2018-06-13 Thread Nathaniel Graham 
ngraham added a comment.


  I'm not sure how to do that, and I realize it might be a lot of work.
  
  In D13442#277600 , @shubham wrote:
  
  > How can the self toggling be done based on the space available?
  
  
  Conceptually, I would have the status bar emit a signal when it's about to 
elide some of its text, and then connect that to a slot that hides content as 
needed.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13442: Implemented displaying of total lines in kate

2018-06-13 Thread Shubham 
shubham added a comment.


  Oh, didnt come to me that of part when translated to other languages may 
result in longer texts, so this configure option is to be received and context 
menu is to be added?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13442: Implemented displaying of total lines in kate

2018-06-13 Thread Dominik Haumann 
dhaumann added a comment.


  +1 for the context menu on the line/column fields.
  
  By the way, the argument that " of " is short does not hold, since 
translations into other languages may result in much longer text.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13482: Implement support for the Voice and Call interfaces

2018-06-13 Thread Jan Grulich 
jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Looks good to me. Having a test for this would be nice,  but looks that not 
all interfaces are unit tested.

REPOSITORY
  R281 ModemManagerQt

BRANCH
  master-fixes

REVISION DETAIL
  https://phabricator.kde.org/D13482

To: aleksanderm, #frameworks, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13510: Add XDG WM Base support to our XDGShell API

2018-06-13 Thread Vlad Zagorodniy 
zzag added inline comments.

INLINE COMMENTS

> zzag wrote in xdgshell_stable.cpp:525
> Shouldn't it be also static?

Ignore it.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13510

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks modemmanager-qt kf5-qt5 SUSEQt5.10 - Build # 27 - Fixed!

2018-06-13 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20modemmanager-qt%20kf5-qt5%20SUSEQt5.10/27/
 Project:
Frameworks modemmanager-qt kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 13 Jun 2018 11:14:24 +
 Build duration:
9 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(4/4)85%
(99/117)85%
(99/117)78%
(3672/4681)56%
(1168/2070)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(20/20)100%
(20/20)96%
(981/1017)52%
(518/1000)src79%
(41/52)79%
(41/52)67%
(1342/2015)55%
(486/884)src.dbus81%
(26/32)81%
(26/32)53%
(242/456)100%
(0/0)src.fakemodem92%
(12/13)92%
(12/13)93%
(1107/1193)88%
(164/186)

KDE CI: Frameworks modemmanager-qt kf5-qt5 SUSEQt5.9 - Build # 16 - Fixed!

2018-06-13 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20modemmanager-qt%20kf5-qt5%20SUSEQt5.9/16/
 Project:
Frameworks modemmanager-qt kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 13 Jun 2018 11:14:25 +
 Build duration:
5 min 25 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(4/4)85%
(99/117)85%
(99/117)78%
(3672/4681)56%
(1168/2070)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(20/20)100%
(20/20)96%
(981/1017)52%
(518/1000)src79%
(41/52)79%
(41/52)67%
(1342/2015)55%
(486/884)src.dbus81%
(26/32)81%
(26/32)53%
(242/456)100%
(0/0)src.fakemodem92%
(12/13)92%
(12/13)93%
(1107/1193)88%
(164/186)

D13510: Add XDG WM Base support to our XDGShell API

2018-06-13 Thread Vlad Zagorodniy 
zzag added inline comments.

INLINE COMMENTS

> test_xdg_shell.cpp:120
> +break;
> +}
>  

Missing `default`. Is it okay if version is unknown?

> xdgshell_stable.cpp:28
> +
> +#include 
> +

Seems like QDebug is not used here.

> xdgshell_stable.cpp:307
> +Q_UNUSED(surface)
> +auto s = reinterpret_cast(data);
> +s->q->configureRequested(s->pendingSize, s->pendingState, serial);

Use static_cast. Same down below.

> xdgshell_stable.cpp:336
> +states = states | XdgShellSurface::State::Activated;
> +break;
> +}

Missing `default`. Is it okay if the state is unknown?

> xdgshell_stable.cpp:525
> +
> +const struct xdg_popup_listener 
> XdgShellPopupStable::Private::s_popupListener = {
> +configureCallback,

Shouldn't it be also static?

> xdgshell_stable.cpp:536
> +{
> +Q_UNUSED(xdg_popup);
> +auto s = reinterpret_cast(data);

Nitpick: no semicolons after Q_UNUSED.

> xdgshell_stable_interface.cpp:75
> +Private(XdgPopupStableInterface *q, XdgShellStableInterface *c, 
> SurfaceInterface *surface, wl_resource *parentResource);
> +~Private();
> +

I would also add override, e.g.

  ~Private() override;

> xdgshell_stable_interface.cpp:242-243
> +[surface](XdgSurfaceStableInterface *s) {
> +return false;
> +return surface == s->surface();
> +}

Which one should return?

> xdgshell_stable_interface.cpp:488-493
> +if (parentXdgSurface) {
> +pd->parent = parentXdgSurface->surface();
> +} else {
> +wl_resource_post_error(parentResource, 
> XDG_WM_BASE_ERROR_INVALID_POPUP_PARENT, "Invalid popup parent");
> +return;
> +}

Can be simplified, e.g.

  if (!parentXdgSurface) {
  wl_resource_post_error(parentResource, 
XDG_WM_BASE_ERROR_INVALID_POPUP_PARENT, "Invalid popup parent");
  return;
  }
  
  pd->parent = parentXdgSurface->surface();
  pd->

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13510

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13510: Add XDG WM Base support to our XDGShell API

2018-06-13 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This adds XDG WM Base (essentially XDG Shell v7/stable edition) into our
  existing XDGShell classes which wrap v5, v6 and now this.
  
  It's mostly copy and paste from V6 except for the enum types for gravity
  and anchor edges on positioners.
  
  There's been no attempt to share code with V6 as realistically that
  won't get updates whereas XDGWMBase will; and at some point we will 
  want to drop V6 without things being too tangled.

TEST PLAN
  Same test suite as V6 has
  
  Compiled GTK master and ran against suitably modified kwin
  running WAYLAND_DEBUG=1 gtk-demo showed we were using this interface
  Everything worked as well as V6 does.

REPOSITORY
  R127 KWayland

BRANCH
  xdg_squash

REVISION DETAIL
  https://phabricator.kde.org/D13510

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_shell.cpp
  autotests/client/test_xdg_shell_stable.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-shell.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgshell.cpp
  src/client/xdgshell.h
  src/client/xdgshell_p.h
  src/client/xdgshell_stable.cpp
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/xdgshell_interface.h
  src/server/xdgshell_stable_interface.cpp
  src/server/xdgshell_stable_interface_p.h

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13442: Implemented displaying of total lines in kate

2018-06-13 Thread F. Fox 
firef added a comment.


  a line counter as an ECMAscript snippet ships with:
  
  https://store.kde.org/p/1240493

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D11173: Actually vote when clicking stars in the list view

2018-06-13 Thread F. Fox 
Restricted Application added a subscriber: kde-frameworks-devel.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D11173

To: leinir, #knewstuff, #frameworks, sitter, apol
Cc: kde-frameworks-devel, michaelh, ZrenBot, ngraham, bruns

D13211: Enable comparing KFileItems by url

2018-06-13 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13211

To: jtamate, dfaure
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D13442: Implemented displaying of total lines in kate

2018-06-13 Thread Sven Brauch 
brauch added a comment.


  I was also thinking about the context menu, yes. That is also where a lot of 
users would first look for it I think, even before the config dialog.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

2018-06-13 Thread Shubham 
shubham added a comment.


  The "of " is mere couple of alphabets, does this takes space on the bar and 
annoys, I dont think so, in my view 
  it should be by default,what u say cullmann?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

2018-06-13 Thread Christoph Cullmann 
cullmann added a comment.


  But then the question is: some want it, some not, and it is always visible, 
what to do?
  Perhaps the choice to have a config dialog entry is already bad and we should 
just have a context menu for the statusbar that allows to configure the 
appearance like other editors do?
  Then we wouldn't clutter the config dialog at all.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

2018-06-13 Thread Sven Brauch 
brauch added a comment.


  I don't like this being user-controllable. We spend so much effort in keeping 
our option set clearly arranged and limited to useful choices, to me this seems 
like a very bad opportunity to break that rule.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars