D13565: CoffeeScript: add extension .cson
nibags added a reviewer: dhaumann. nibags added a project: Framework: Syntax Highlighting. nibags edited subscribers, added: Framework: Syntax Highlighting; removed: kde-frameworks-devel. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13565 To: nibags, dhaumann Cc: #framework_syntax_highlighting, michaelh, genethomas, ngraham, bruns, cullmann, vkrause, dhaumann, kde-frameworks-devel
D13565: CoffeeScript: add extension .cson
nibags created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nibags requested review of this revision. REVISION SUMMARY `cson` is a CoffeeScript-Object-Notation. It is a format for storing data, like JSON, and it is a subset of the CoffeeScript language. - https://github.com/bevry/cson REPOSITORY R216 Syntax Highlighting BRANCH add-cson-coffeescript REVISION DETAIL https://phabricator.kde.org/D13565 AFFECTED FILES data/syntax/coffee.xml To: nibags Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13026: Make menu-bearing toolbar buttons show their menus with normal click rather than click-and-hold
This revision was automatically updated to reflect the committed changes. Closed by commit R39:b099af9eb569: Make menu-bearing toolbar buttons show their menus with normal click rather… (authored by ngraham). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13026?vs=35890=36214 REVISION DETAIL https://phabricator.kde.org/D13026 AFFECTED FILES src/mode/katemodemenu.h src/schema/kateschema.h src/script/katescriptaction.cpp src/syntax/katehighlightmenu.h src/utils/kateautoindent.cpp src/utils/katebookmarks.cpp To: ngraham, #ktexteditor, #kate, dhaumann, cullmann Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D13510: Add XDG WM Base support to our XDGShell API
zzag added inline comments. INLINE COMMENTS > xdgshell_stable.cpp:305 > +Q_UNUSED(surface) > +auto s = reinterpret_cast(data); > +s->q->configureRequested(s->pendingSize, s->pendingState, serial); Did you forget to change it to static_cast? Or there is a reason why it's still reinterpret_cast? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13510 To: davidedmundson, #kwin Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
D7033: Port ki18n from QtScript to QtQml
Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D7033 To: carewolf, ilic Cc: kde-frameworks-devel, huftis, ngraham, dhaumann, ltoscano, kfunk, michaelh, bruns, #frameworks
D13510: Add XDG WM Base support to our XDGShell API
romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in xdgshell_stable_interface.cpp:246 > What role do you think it should be? > > I'm using the error for when a wl_surface has another role in the case that > you call get_xdg_surface twice on the same wl_surface, which seems close > enough. `XDG_SURFACE_ERROR_ALREADY_CONSTRUCTED` REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13510 To: davidedmundson, #kwin Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
D13510: Add XDG WM Base support to our XDGShell API
davidedmundson updated this revision to Diff 36206. davidedmundson added a comment. Roman's comments (except the one I commented on) REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13510?vs=36127=36206 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13510 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_xdg_shell.cpp autotests/client/test_xdg_shell_stable.cpp src/client/CMakeLists.txt src/client/protocols/xdg-shell.xml src/client/registry.cpp src/client/registry.h src/client/xdgshell.cpp src/client/xdgshell.h src/client/xdgshell_p.h src/client/xdgshell_stable.cpp src/server/CMakeLists.txt src/server/display.cpp src/server/xdgshell_interface.h src/server/xdgshell_stable_interface.cpp src/server/xdgshell_stable_interface_p.h To: davidedmundson, #kwin Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
D13510: Add XDG WM Base support to our XDGShell API
davidedmundson marked 4 inline comments as done. davidedmundson added inline comments. INLINE COMMENTS > romangg wrote in xdgshell_stable_interface.cpp:246 > Wrong id `XDG_WM_BASE_ERROR_ROLE`. What role do you think it should be? I'm using the error for when a wl_surface has another role in the case that you call get_xdg_surface twice on the same wl_surface, which seems close enough. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13510 To: davidedmundson, #kwin Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
D13026: Make menu-bearing toolbar buttons show their menus with normal click rather than click-and-hold
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm - thanks! Please only in master (as this review request shows). REPOSITORY R39 KTextEditor BRANCH schema-toolbar-button-opens-on-normal-click (branched from master) REVISION DETAIL https://phabricator.kde.org/D13026 To: ngraham, #ktexteditor, #kate, dhaumann, cullmann Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D13026: Make menu-bearing toolbar buttons show their menus with normal click rather than click-and-hold
ngraham added a comment. Friendly ping! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13026 To: ngraham, #ktexteditor, #kate, dhaumann, cullmann Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D13552: [Properties dialog] Improve some permissions-related strings
ngraham retitled this revision from "Improve some permissions-related strings" to "[Properties dialog] Improve some permissions-related strings". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13552 To: ngraham, #frameworks, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13559: Fix some of cppcheck warnings
bshah created this revision. bshah added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY - selfInitialization - memleak I could probably suppress the selfInitialization warning, but probably is cleaner this way. Opinions welcome TEST PLAN - arc lint --everything - Fix issues - build - run tests REPOSITORY R127 KWayland BRANCH fix-cppcheck REVISION DETAIL https://phabricator.kde.org/D13559 AFFECTED FILES autotests/server/test_display.cpp src/client/xdgoutput.cpp src/server/dpms_interface.cpp src/server/xdgoutput_interface.cpp To: bshah, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13541: Port solid from Qt5::Widgets to Qt5::Gui
apol accepted this revision. REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks, dhaumann, apol Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 57 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/57/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Fri, 15 Jun 2018 09:10:05 + Build duration: 9 min 2 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testRemoteAccess Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report57% (4/7)90% (225/251)90% (225/251)84% (24102/28745)52% (11792/22732)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.client98% (40/41)98% (40/41)98% (11225/11508)49% (7708/15599)autotests.server100% (5/5)100% (5/5)99% (359/362)49% (220/446)src.client97% (69/71)97% (69/71)84% (5688/6743)65% (1783/2752)src.server97% (111/115)97% (111/115)86% (6830/7964)64% (2081/3256)src.tools0% (0/2)0% (0/2)0% (0/786)0% (0/346)src.tools.testserver0% (0/3)0% (0/3)0% (0/120)0% (0/16)tests0% (0/14)0% (0/14)0% (0/1262)0% (0/317)
KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 19 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/19/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 15 Jun 2018 09:10:05 + Build duration: 6 min 34 sec and counting JUnit Tests Name: (root) Failed: 13 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurface
KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 29 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/29/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Fri, 15 Jun 2018 09:10:05 + Build duration: 5 min 37 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testRemoteAccess Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report57% (4/7)90% (225/251)90% (225/251)84% (24102/28745)52% (11791/22732)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.client98% (40/41)98% (40/41)98% (11225/11508)49% (7708/15599)autotests.server100% (5/5)100% (5/5)99% (359/362)49% (220/446)src.client97% (69/71)97% (69/71)84% (5688/6743)65% (1782/2752)src.server97% (111/115)97% (111/115)86% (6830/7964)64% (2081/3256)src.tools0% (0/2)0% (0/2)0% (0/786)0% (0/346)src.tools.testserver0% (0/3)0% (0/3)0% (0/120)0% (0/16)tests0% (0/14)0% (0/14)0% (0/1262)0% (0/317)
KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 56 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/56/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Fri, 15 Jun 2018 08:48:40 + Build duration: 9 min 34 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testRemoteAccess Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report57% (4/7)90% (225/251)90% (225/251)84% (24104/28746)52% (11792/22732)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.client98% (40/41)98% (40/41)98% (11227/11509)49% (7708/15599)autotests.server100% (5/5)100% (5/5)99% (359/362)49% (220/446)src.client97% (69/71)97% (69/71)84% (5688/6743)65% (1783/2752)src.server97% (111/115)97% (111/115)86% (6830/7964)64% (2081/3256)src.tools0% (0/2)0% (0/2)0% (0/786)0% (0/346)src.tools.testserver0% (0/3)0% (0/3)0% (0/120)0% (0/16)tests0% (0/14)0% (0/14)0% (0/1262)0% (0/317)
KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 28 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/28/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Fri, 15 Jun 2018 08:48:40 + Build duration: 9 min 3 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testRemoteAccess Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report57% (4/7)90% (225/251)90% (225/251)84% (24103/28745)52% (11790/22732)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.client98% (40/41)98% (40/41)98% (11226/11508)49% (7707/15599)autotests.server100% (5/5)100% (5/5)99% (359/362)49% (220/446)src.client97% (69/71)97% (69/71)84% (5688/6743)65% (1782/2752)src.server97% (111/115)97% (111/115)86% (6830/7964)64% (2081/3256)src.tools0% (0/2)0% (0/2)0% (0/786)0% (0/346)src.tools.testserver0% (0/3)0% (0/3)0% (0/120)0% (0/16)tests0% (0/14)0% (0/14)0% (0/1262)0% (0/317)
KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 18 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/18/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 15 Jun 2018 08:48:40 + Build duration: 7 min 25 sec and counting JUnit Tests Name: (root) Failed: 13 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurface
D13533: Add the arclint file in kwayland
This revision was automatically updated to reflect the committed changes. Closed by commit R127:b046ca8e9d1f: Add the arclint file in kwayland (authored by bshah). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13533?vs=36152=36192 REVISION DETAIL https://phabricator.kde.org/D13533 AFFECTED FILES .arclint To: bshah, #frameworks, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns
