D14062: Python: fix escapes in quoted-comments

2018-07-12 Thread Nibaldo González 
nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14062

To: nibags, #framework_syntax_highlighting, #kate, dhaumann, cullmann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 54 - Still Unstable!

2018-07-12 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/54/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 13 Jul 2018 03:24:00 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)27%
(14/52)27%
(14/52)20%
(429/2119)19%
(206/1084)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(113/123)50%
(48/96)src100%
(8/8)100%
(8/8)75%
(235/312)59%
(124/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/48)0%
(0/22)src.plugins.youtube0%
(0/4)0%
(0/4)0%
(0/112)0%

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 77 - Unstable!

2018-07-12 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/77/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 13 Jul 2018 03:24:00 +
 Build duration:
8 min 35 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)27%
(14/52)27%
(14/52)19%
(406/2119)17%
(186/1084)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(113/123)50%
(48/96)src100%
(8/8)100%
(8/8)68%
(212/312)50%
(104/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/48)0%
(0/22)src.plugins.youtube0%
(0/4)0%
(0/4)0%
(0/112)0%

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 185 - Still Unstable!

2018-07-12 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/185/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 13 Jul 2018 03:23:56 +
 Build duration:
7 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)31%
(39/126)31%
(39/126)27%
(3489/13084)19%
(1785/9412)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests79%
(11/14)79%
(11/14)53%
(588/1113)29%
(310/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core19%
(3/16)19%
(3/16)11%
(252/2208)7%
(94/1432)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma55%
(12/22)55%
(12/22)41%
(1410/3477)30%
(779/2613)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(661/1540)30%
(300/1001)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)28%
(547/1973)17%
(297/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 79 - Still Unstable!

2018-07-12 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/79/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 13 Jul 2018 03:23:35 +
 Build duration:
5 min 53 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 35 - Still Unstable!

2018-07-12 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/35/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 13 Jul 2018 03:23:56 +
 Build duration:
4 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D14006: Fix WebDAV destination header on COPY and MOVE operations

2018-07-12 Thread Nathaniel Graham 
ngraham added reviewers: Frameworks, Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14006

To: dantti, dfaure, #frameworks, #dolphin
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14042: Support special URLs for finding files of a certain type

2018-07-12 Thread Nathaniel Graham 
ngraham added a comment.


  In D14042#290555 , @hein wrote:
  
  > Does it make sense to name the queries after XDG_USER_DIRS, so e.g. 
pictures instead of images?
  >
  > https://www.freedesktop.org/wiki/Software/xdg-user-dirs/
  
  
  That might introduce the potential for user confusion, for people who add the 
XDG dirs to their Places panels (or if we ever did that by default), because 
then there would be multiple entries in different sections with the same text.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D14042

To: broulik, #frameworks, bruns, dfaure, renatoo, franckarrecot, hein, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D14062: Python: fix escapes in quoted-comments

2018-07-12 Thread Dominik Haumann 
dhaumann added a comment.


  Can you add a test line to autotests/input/test.py ?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14062

To: nibags, #framework_syntax_highlighting, #kate, dhaumann, cullmann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, bruns, 
demsking, cullmann, sars, dhaumann

D13570: Add workaround for labels with word-wrapping

2018-07-12 Thread Elvis Angelaccio 
elvisangelaccio updated this revision to Diff 37669.
elvisangelaccio added a comment.


  - Added bug report

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13570?vs=36232&id=37669

BRANCH
  workaround-wordwrap (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13570

AFFECTED FILES
  src/kcollapsiblegroupbox.cpp
  tests/kcollapsiblegroupboxtest.cpp

To: elvisangelaccio, davidedmundson, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13570: Add workaround for labels with word-wrapping

2018-07-12 Thread Elvis Angelaccio 
elvisangelaccio edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D13570

To: elvisangelaccio, davidedmundson, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11235: [DrKonqi] Request change of ptrace scope from KCrash

2018-07-12 Thread Harald Sitter 
sitter added a subscriber: lepagevalleeemmanuel.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks
Cc: lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D11236: [KCrash] Establish socket to allow change of ptrace scope

2018-07-12 Thread Harald Sitter 
sitter added a subscriber: lepagevalleeemmanuel.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks
Cc: lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D12950: add test which checks the property types

2018-07-12 Thread Alexander Stippich 
astippich added a comment.


  I would like to work on D11365  again 
where it was suggested to add the test first. As you can see from the tests, 
the types defined for each property in KFileMetaData do not match the output 
for the taglibextractor. The types are actually different if you query via 
Baloo or if you use KFileMetaData directly.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12950

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D11236: [KCrash] Establish socket to allow change of ptrace scope

2018-07-12 Thread Christoph Roick 
croick added a comment.


  Is there anybody who feels like reviewing this?
  I'm happily using the patch on my system, but I understand that there might 
still be hidden issues here.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks
Cc: kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D13970: Handle empty preview lists

2018-07-12 Thread Andreas Cord-Landwehr 
cordlandwehr added a reviewer: dhaumann.
cordlandwehr added a comment.


  Somehow removed all reviewers with my last message (sorry!)
  Trying to fix this now.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13970

To: cordlandwehr, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13970: Handle empty preview lists

2018-07-12 Thread Andreas Cord-Landwehr 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:c4275aaf79fc: Handle empty preview lists (authored by 
cordlandwehr).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13970?vs=37345&id=37665

REVISION DETAIL
  https://phabricator.kde.org/D13970

AFFECTED FILES
  src/qtquick/quickitemsmodel.cpp

To: cordlandwehr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12950: add test which checks the property types

2018-07-12 Thread Matthieu Gallien 
mgallien added a comment.


  Sorry for the delay on my side.
  Why are you adding this test ?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12950

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D6513: Add support for Attica tags support

2018-07-12 Thread Dan Leinir Turthra Jensen 
leinir added a comment.


  Pingaling, it would be super handy if we could get this merged soon :) It's 
needed to support the moderation happening on the KDE Store, and also needed 
for better handling of specific types of content like e.g. comic books in 
Peruse. Thanks! :D

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D6512: Add support for proposed tags addition in OCS 1.7

2018-07-12 Thread Dan Leinir Turthra Jensen 
leinir added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  Ping, if we could get this merged soon, it would be terribly handy :) (it's 
the basis for moderating the ghns content, and needed for the knewstuff patch 
in D6513 )

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D6512

To: leinir, #knewstuff, apol, whiting, #kde_store
Cc: kde-frameworks-devel, #kde_store, michaelh, ZrenBot, ngraham, bruns, 
akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, starbuck, sebas, 
#frameworks

D14062: Python: fix escapes in quoted-comments

2018-07-12 Thread Nathaniel Graham 
ngraham added reviewers: Kate, dhaumann, cullmann.
ngraham added a comment.


  Please change `Bug #386685: https://bugs.kde.org/show_bug.cgi?id=386685` to 
`BUG: 386685`. See 
https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14062

To: nibags, #framework_syntax_highlighting, #kate, dhaumann, cullmann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, bruns, 
demsking, cullmann, sars, dhaumann

D13814: Speedup sort

2018-07-12 Thread Stefan Brüns 
bruns added a comment.


  In D13814#290556 , @markg wrote:
  
  > Is there even a need to have n QCollator objects?
  >  I'm talking about a QCollator _within_ a given view. Each view could 
obviously have it's own collator due to different view settings.
  
  
  Strictly speaking you need one collator per thread (it is reentrant (save the 
bug), but not thread-safe). As long as the collator objects are not modified, 
each one is just the d-pointer, as QCollator is CoW.
  
  Copying a clean QCollator is cheap. Default-constructing one and modifying it 
is expensive - each one has to be initialize the underlying ICU (actually, this 
happens twice for each one, once on construction, once after the 
m_collator.setFoo(...) calls).
  
  Using a const reference, as done here, is even slightly cheaper. But doing so 
is also undefined behaviour - QCollator is reentrant, but not thread-safe. We 
get away with it by using the forced initialization, which avoids the UB (UB 
only happens when the QCollator is dirty).
  
  When the fix in https://codereview.qt-project.org/#/c/234359/3//ALL,unified 
is applied, it is no longer necessary to force the `init()` under the premise 
each thread uses its own private collator object (which is implicitly shared).

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio, bruns
Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, 
firef, andrebarros, emmanuelp

[no subject]

2018-07-12 Thread Jaime Torres Amate via Kde-frameworks-devel 
--- Begin Message ---
jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  Don't restore user places with invalid attribute href.
  This avoids asking for empty protocol in KFilePlacesItem::groupType and the 
assert in KProtocolInfoFactory::findProtocol.

TEST PLAN
  Don't assert asking for invalid protocols when creating the save dialog with 
an invalid bookmark (empty href) in ~/.local/share/user-places.xbel
  

 Project Folder
 
  http://freedesktop.org";>
   
  
  http://www.kde.org";>
   kdenlive
  
 


REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14072

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
--- End Message ---