D14360: Remove custom icon selection for trash

[Pino Toscano]

pino added a comment.


  In D14360#299441 , @shubham wrote:
  
  > indirectly you mean to transfer all the logic to helper function
  
  
  No, I suggested something like:
  
bool KFilePlaceEditDialog::canEditIcon() const
{
  return m_iconButton;
}
  
  using it in `KFilePlaceEditDialog::getInformation()`.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14360

To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14360: Remove custom icon selection for trash

[Shubham]

shubham added a comment.


  indirectly you mean to transfer all the logic to helper function

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14360

To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14360: Remove custom icon selection for trash

[Pino Toscano]

pino added a comment.


  In D14360#299439 , @shubham wrote:
  
  > pino, I understood your idea of having a helper class function, but the 
condition for editing the icon will remain the same ( based on its scheme), 
what can be the other condition?
  
  
  For example if in the future you exclude another scheme from icon editing. 
Generally speaking, there is a logic here (`url.scheme() != 
QLatin1String("trash")`), and usually duplicating it even across the very same 
source file is not a good idea.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14360

To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14360: Remove custom icon selection for trash

[Shubham]

shubham added a comment.


  pino, I understood your idea of having a helper class function, but the 
condition for editing the icon will remain the same ( based on its scheme), 
what can be the other condition?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14360

To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14360: Remove custom icon selection for trash

[Pino Toscano]

pino requested changes to this revision.
pino added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfileplaceeditdialog.cpp:66
> +// Get icon except for trash
> +if (url.scheme() != QLatin1String("trash")) {
> +icon = dialog->icon();

This duplicates the logic that is used in the constructor below. A better 
option might be to create an helper class method to get whether the icon can be 
edited, basically checking for `m_iconButton`.

> kfileplaceeditdialog.cpp:123
>  
>  whatsThisText = i18n("This is the icon that will appear in the 
> Places panel."
>   "Click on the button to select a different 
> icon.");

This variable assignment can be moved inside the `if` as well, since this 
"what's this" text is used only for the icon button & its label.

> kfileplaceeditdialog.cpp:132
> +m_iconButton->setIconType(KIconLoader::NoGroup, KIconLoader::Place);
> +
> +if (icon.isEmpty()) {

Extra empty line.

> kfileplaceeditdialog.cpp:138
> +}
> +
> +m_iconButton->setWhatsThis(whatsThisText);

Extra empty line.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14360

To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

[Bhushan Shah]

bshah removed a project: Frameworks.
bshah removed a subscriber: kde-frameworks-devel.
Restricted Application added a project: Frameworks.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, michaelh, ngraham, bruns, kde-frameworks-devel

D13819: dummy commit to test pre-review CI

[Phabricator]

Harbormaster failed remote builds in B1283: Diff 38634!

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

[Jenkins-CI]

jenkins-ci added a comment.


  Build is unstable
  
  Link to build: https://build.kde.org/job/Reviews/job/13819/3/
  See console output for more information: 
https://build.kde.org/job/Reviews/job/13819/3/console

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D14360: Remove custom icon selection for trash

[Shubham]

shubham updated this revision to Diff 38633.
shubham added a comment.


  Check before getting the icon, whether it's editable or not

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14360?vs=38524=38633

REVISION DETAIL
  https://phabricator.kde.org/D14360

AFFECTED FILES
  src/filewidgets/kfileplaceeditdialog.cpp

To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

[Bhushan Shah]

bshah updated this revision to Diff 38634.
bshah added a comment.


  - Revert "make it fail"
  - break test

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13819?vs=38632=38634

BRANCH
  bshah

REVISION DETAIL
  https://phabricator.kde.org/D13819

AFFECTED FILES
  CMakeLists.txt
  autotests/karchivetest.cpp

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

[Jenkins-CI]

jenkins-ci added a comment.


  Build has FAILED
  
  Link to build: https://build.kde.org/job/Reviews/job/13819/2/
  See console output for more information: 
https://build.kde.org/job/Reviews/job/13819/2/console

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

[Phabricator]

Harbormaster failed remote builds in B1282: Diff 38632!

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

[Bhushan Shah]

bshah updated this revision to Diff 38632.
bshah added a comment.


  - make it fail

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13819?vs=38631=38632

BRANCH
  bshah

REVISION DETAIL
  https://phabricator.kde.org/D13819

AFFECTED FILES
  CMakeLists.txt

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

[Jenkins-CI]

jenkins-ci added a comment.


  Build is green https://build.kde.org/job/Reviews/job/13819/1/ for more 
details.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

[Bhushan Shah]

bshah updated this revision to Diff 38631.
bshah added a comment.


  - change

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13819?vs=38500=38631

BRANCH
  bshah

REVISION DETAIL
  https://phabricator.kde.org/D13819

AFFECTED FILES
  CMakeLists.txt

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D14434: add functions to access keywords

[jonathan poelen]

jpoelen added a comment.


  This follows 
https://mail.kde.org/pipermail/kde-frameworks-devel/2018-July/066564.html

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14434

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14434: add functions to access keywords

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: kwrite-devel.
jpoelen requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  keywordlist

REVISION DETAIL
  https://phabricator.kde.org/D14434

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  src/lib/definition.cpp
  src/lib/definition.h
  src/lib/keywordlist.cpp
  src/lib/keywordlist_p.h

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

[Alexander Schlarb]

tundracomp added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  Any review of this would be greatly apprechiated…

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D12709

To: tundracomp
Cc: kde-frameworks-devel, michaelh, ngraham, bruns, #frameworks

D13819: dummy commit to test pre-review CI

[Jenkins-CI]

jenkins-ci added a comment.


  Build is green https://build.kde.org/job/Reviews/job/38500/4/ for more 
details.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

[Alexander Schlarb]

tundracomp added a comment.


  Could I get a new review on this please!?

REVISION DETAIL
  https://phabricator.kde.org/D12674

To: tundracomp
Cc: ltoscano, cgiboudeaux, #frameworks, michaelh, ngraham, bruns

D14401: Don't instantiate a QStringRef into a QString only to search in a QStringList

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> parser.cpp:58
>  parseMetadataXml(xml);
> -} else if (elements.contains(xml.name().toString())) {
> +} else if (stringList_contains_stringRef(elements, xml.name())) {
>  item = parseXml(xml);

You could also use

  if (std::any_of(elements.begin(), elements.end(),
  [](const auto& e) { return e == xml.name(); }) {

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D14401

To: apol, leinir, whiting, aacid
Cc: bruns, aacid, kde-frameworks-devel, michaelh, ngraham

D14237: Make Konqi look good in HiDPI

[Stefan Brüns]

bruns added a comment.


  I have traced the image with GIMPs selection tool, "convert selection to 
path" and export path as SVG. IMHO works best for tracing pixel art.
  
  F6154333: konqui.png 
  
  F6154332: konqui.svg 

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D14237

To: ngraham, broulik, cfeck, #frameworks
Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 334 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/334/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 27 Jul 2018 14:46:43 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 59 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(258/396)65%
(258/396)53%
(31887/59867)38%
(16113/42642)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(55/55)100%
(55/55)95%
(9005/9435)51%
(3923/7700)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8293/14357)50%
(4639/9285)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3892/7900)34%
(1580/4655)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(528/1015)39%
(316/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4320)35%
(1306/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1330)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)52%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 91 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/91/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 27 Jul 2018 14:46:43 +
 Build duration:
9 min 59 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 181 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/181/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 27 Jul 2018 14:46:43 +
 Build duration:
3 min 45 sec and counting
   CONSOLE OUTPUT
  [...truncated 433.16 KB...]/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:27:5: warning: this use of "defined" may not be portable [-Wexpansion-to-defined] #if WITH_SHM ^~~~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:27:5: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:199:5: warning: this use of "defined" may not be portable [-Wexpansion-to-defined] #if WITH_SHM ^~~~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:199:5: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:645:5: warning: this use of "defined" may not be portable [-Wexpansion-to-defined] #if WITH_SHM ^~~~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:645:5: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:677:5: warning: this use of "defined" may not be portable [-Wexpansion-to-defined] #if WITH_SHM ^~~~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:677:5: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp: In function ‘KIO::PreviewJob* KIO::filePreview(const KFileItemList&, int, int, int, int, bool, bool, const QStringList*)’:/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:769:54: warning: ‘KIO::PreviewJob::PreviewJob(const KFileItemList&, int, int, int, int, bool, bool, const QStringList*)’ is deprecated [-Wdeprecated-declarations]   scale, save, enabledPlugins);  ^/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:159:1: note: declared here PreviewJob::PreviewJob(const KFileItemList , int width, int height, ^~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp: In function ‘KIO::PreviewJob* KIO::filePreview(const QList&, int, int, int, int, bool, bool, const QStringList*)’:/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:782:54: warning: ‘KIO::PreviewJob::PreviewJob(const KFileItemList&, int, int, int, int, bool, bool, const QStringList*)’ is deprecated [-Wdeprecated-declarations]   scale, save, enabledPlugins);  ^/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:159:1: note: declared here PreviewJob::PreviewJob(const KFileItemList , int width, int height, ^~[ 50%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/renamedialog.cpp.o[ 50%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/ksslcertificatebox.cpp.o[ 50%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kdynamicjobtracker.cpp.o[ 50%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/ksslinfodialog.cpp.o[ 50%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/joburlcache.cpp.o[ 50%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/sslui.cpp.o[ 50%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/skipdialog.cpp.o[ 50%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/krun.cpp.o[ 51%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/jobuidelegate.cpp.o[ 51%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kurlrequester.cpp.o[ 51%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kdirlister.cpp.o/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/krun.cpp: In member function ‘virtual void KRun::foundMimeType(const QString&)’:/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/krun.cpp:1354:128: warning: ‘static bool KRun::runUrl(const QUrl&, const QString&, QWidget*, bool, bool, const QString&, const QByteArray&)’ is deprecated [-Wdeprecated-declarations] if (!KRun::runUrl(d->m_strURL, type, d->m_window, false /*tempfile*/, d->m_runExecutables, d->m_suggestedFileName, d->m_asn)) {^/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/krun.cpp:170:6: note: declared here bool KRun::runUrl(const QUrl , const QString , 

D12945: kcoredirlister lstItems benchmark

[Jaime Torres Amate]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:908bfca9fe72: kcoredirlister lstItems benchmark (authored 
by jtamate).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D12945?vs=38134=38612#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12945?vs=38134=38612

REVISION DETAIL
  https://phabricator.kde.org/D12945

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kcoredirlister_benchmark.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14397: Support libcanberra for audio notification

[Kai Uwe Broulik]

broulik added a comment.


  > Currently, libcanberra is tested on Linux only.
  
  I restored the Phonon option for when canberra isn't available on the 
platform.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D14397

To: broulik, #frameworks, dfaure, davidedmundson, sitter, drosca, kfunk, rjvbb
Cc: alexeymin, ngraham, nicolasfella, kde-frameworks-devel, michaelh, bruns

D14397: Support libcanberra for audio notification

[Alexey Min]

alexeymin added a comment.


  But `Currently, libcanberra is tested on Linux only.`  Plasma-pa and 
plasma-whatever can use anything and be Linux-centric, KNotifications is a 
framework, isn't it?
  ++vote for QtMultimedia option...

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D14397

To: broulik, #frameworks, dfaure, davidedmundson, sitter, drosca, kfunk, rjvbb
Cc: alexeymin, ngraham, nicolasfella, kde-frameworks-devel, michaelh, bruns

D14397: Support libcanberra for audio notification

[Kai Uwe Broulik]

broulik added a comment.


  > phonon works just fine
  
  That's not true. If it worked fine, this patch would not exist, as I would 
not have apps freeze for seconds on teardown of Phonon objects, or latencies 
beyond all comparison

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D14397

To: broulik, #frameworks, dfaure, davidedmundson, sitter, drosca, kfunk, rjvbb
Cc: ngraham, nicolasfella, kde-frameworks-devel, michaelh, bruns

D14397: Support libcanberra for audio notification

[Harald Sitter]

sitter added a comment.


  In D14397#299073 , @rjvbb wrote:
  
  > >   That's reinventing the wheel to a point.
  >
  > Creating Qt after Gtk or vice-versa was also reinventing the wheel to a 
much larger extent - so is adding more and more OS features to Qt as has been 
going on for years.
  >
  > libcanberra comes from "the other" GUI universe. My arguments against 
depending on it stand, I think, including the one about not increasing and 
probably reducing the number of dependencies.
  
  
  Your arguments were against depending on gstreamer. Canberra is an 
abstraction. You could shove coreaudio or quicktime behind it if you wanted.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D14397

To: broulik, #frameworks, dfaure, davidedmundson, sitter, drosca, kfunk, rjvbb
Cc: ngraham, nicolasfella, kde-frameworks-devel, michaelh, bruns

D14397: Support libcanberra for audio notification

[Nicolas Fella]

nicolasfella added a comment.


  Not using something because it's from a "rival GUI" is not a valid argument. 
FWIW plasma-pa already uses Glib and Canberra. QtMultimedia uses GStreamer as 
backend on Unix, so it pulls in glib anyway. The only advantage, if any, of 
using QtMultimedia is that it uses native APIs on Mac/Windows, but Canberra 
over GStreamer works there as well.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D14397

To: broulik, #frameworks, dfaure, davidedmundson, sitter, drosca, kfunk, rjvbb
Cc: ngraham, nicolasfella, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks ki18n kf5-qt5 SUSEQt5.9 - Build # 33 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.9/33/
 Project:
Frameworks ki18n kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 27 Jul 2018 10:29:31 +
 Build duration:
4 min 42 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(17/17)100%
(17/17)67%
(1979/2970)49%
(933/1889)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(5/5)100%
(5/5)92%
(373/405)50%
(155/308)src100%
(12/12)100%
(12/12)63%
(1606/2565)49%
(778/1581)

KDE CI: Frameworks ki18n kf5-qt5 AndroidQt5.11 - Build # 13 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20AndroidQt5.11/13/
 Project:
Frameworks ki18n kf5-qt5 AndroidQt5.11
 Date of build:
Fri, 27 Jul 2018 10:29:31 +
 Build duration:
4 min 17 sec and counting

KDE CI: Frameworks ki18n kf5-qt5 SUSEQt5.10 - Build # 45 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.10/45/
 Project:
Frameworks ki18n kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 27 Jul 2018 10:29:31 +
 Build duration:
2 min 27 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(17/17)100%
(17/17)67%
(1980/2970)50%
(936/1889)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(5/5)100%
(5/5)92%
(373/405)50%
(155/308)src100%
(12/12)100%
(12/12)63%
(1607/2565)49%
(781/1581)

KDE CI: Frameworks ki18n kf5-qt5 FreeBSDQt5.10 - Build # 17 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20FreeBSDQt5.10/17/
 Project:
Frameworks ki18n kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 27 Jul 2018 10:29:31 +
 Build duration:
1 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D14397: Support libcanberra for audio notification

[René J . V . Bertin]

rjvbb added a comment.


  >   That's reinventing the wheel to a point.
  
  Creating Qt after Gtk or vice-versa was also reinventing the wheel to a much 
larger extent - so is adding more and more OS features to Qt as has been going 
on for years.
  
  libcanberra comes from "the other" GUI universe. My arguments against 
depending on it stand, I think, including the one about not increasing and 
probably reducing the number of dependencies.
  
  Improving QtMultimedia with useful features (as far as that's even 
necessary!) may be reinventing the wheel but will have benefits for much more 
than just KNotifications (because, you know, *useful*).
  
  I'd love to look into using QAudioOutput (esp. if someone a bit more familiar 
with audio programming is willing to provide guidance), but after summer.  
(Thinking beyond the issue at hand: phonon works just fine, but its backends 
have been bothering me for a while and a QtMultiMedia backend could be an 
interesting idea to investigate as an easier cross-platform option.)

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D14397

To: broulik, #frameworks, dfaure, davidedmundson, sitter, drosca, kfunk, rjvbb
Cc: ngraham, nicolasfella, kde-frameworks-devel, michaelh, bruns

D13744: Let ki18n macro file name follow style of other find_package related files

[Marco Martin]

mart added a comment.


  KI18n fails to install now

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D13744

To: habacker, apol, ilic
Cc: mart, kde-frameworks-devel, leinir, michaelh, ngraham, bruns

D14401: Don't instantiate a QStringRef into a QString only to search in a QStringList

[Aleix Pol Gonzalez]

apol added a comment.


  In D14401#298611 , @aacid wrote:
  
  > Does this really make a difference?
  
  
  I was looking at heaptrack and this function was a point of contention, maybe 
not a big deal.
  
  > Also... fix qt to get QStringList::containst(QStringRef)?
  
  Last time I submitted a QStringRef overload to Qt, QStringView-man told me it 
was the wrong thing to do and he had everything figured out. I can do it though.

REPOSITORY
  R235 Attica

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14401

To: apol, leinir, whiting, aacid
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D14401: Don't instantiate a QStringRef into a QString only to search in a QStringList

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R235:1b7564fabf2b: Dont instantiate a QStringRef into a 
QString only to search in a QStringList (authored by apol).

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14401?vs=38499=38575

REVISION DETAIL
  https://phabricator.kde.org/D14401

AFFECTED FILES
  src/parser.cpp

To: apol, leinir, whiting, aacid
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D14397: Support libcanberra for audio notification

[Harald Sitter]

sitter added a comment.


  In D14397#298557 , @ngraham wrote:
  
  > Impressive work, Kai! However I rather like the idea of improving 
QTMultiMedia's sound handling features rather than working around the lack of 
them by using a different library.
  
  
  That's reinventing the wheel to a point. There is a perfectly reasonable 
abstraction layer already. It's libcanberra. A library specifically designed 
for notification sounds.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D14397

To: broulik, #frameworks, dfaure, davidedmundson, sitter, drosca, kfunk, rjvbb
Cc: ngraham, nicolasfella, kde-frameworks-devel, michaelh, bruns

D13743: Migrate build system to use find_package in autotests/ki18n_install

[Ralf Habacker]

habacker updated this revision to Diff 38569.
habacker added a comment.


  - rebased

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13743?vs=36708=38569

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13743

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/ki18n_install/CMakeLists.txt

To: habacker, apol, ilic
Cc: bcooksley, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks ki18n kf5-qt5 SUSEQt5.10 - Build # 44 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.10/44/
 Project:
Frameworks ki18n kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 27 Jul 2018 08:50:26 +
 Build duration:
3 min 38 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   CONSOLE OUTPUT
  [...truncated 146.56 KB...] KLocalizedString::removeQtDomain("ki18n-test-qt"); ^In file included from /home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.10/autotests/klocalizedstringtest.cpp:34:/home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.10/src/klocalizedstring.h:655:34: note: declared here KI18N_DEPRECATED static void removeQtDomain(const char *domain);  ^~/home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.10/autotests/klocalizedstringtest.cpp:490:53: warning: ‘static void KLocalizedString::removeQtDomain(const char*)’ is deprecated [-Wdeprecated-declarations] KLocalizedString::removeQtDomain("ki18n-test-qt"); ^In file included from /home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.10/autotests/klocalizedstringtest.cpp:34:/home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.10/src/klocalizedstring.h:655:34: note: declared here KI18N_DEPRECATED static void removeQtDomain(const char *domain);  ^~[ 88%] Building CXX object autotests/CMakeFiles/ki18n-klocalizedstringtest.dir/ki18n-klocalizedstringtest_autogen/mocs_compilation.cpp.o[ 91%] Linking CXX executable ../bin/ki18n-klocalizedstringtest[ 91%] Built target ki18n-klocalizedstringtest[ 94%] Building CXX object autotests/CMakeFiles/ki18n-ktranscriptcleantest.dir/__/src/common_helpers.cpp.o[ 97%] Building CXX object autotests/CMakeFiles/ki18n-ktranscriptcleantest.dir/ki18n-ktranscriptcleantest_autogen/mocs_compilation.cpp.o[100%] Linking CXX executable ../bin/ki18n-ktranscriptcleantest[100%] Built target ki18n-ktranscriptcleantest[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Running Tests)[Pipeline] sh[Frameworks ki18n kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/run-tests.py --product Frameworks --project ki18n --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix//bin/sh: kdeinit5: command not foundCannot find file: /home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.10/build/DartConfiguration.tcl   Site:Build name: (empty)Create new tag: 20180727-0853 - ExperimentalCannot find file: /home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.10/build/DartConfiguration.tclTest project /home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.10/buildStart 1: appstreamtest1/6 Test #1: appstreamtest    Passed0.04 secStart 2: ki18n-declarativetest2/6 Test #2: ki18n-declarativetest    Passed0.72 secStart 3: ki18n-klocalizedstringtest3/6 Test #3: ki18n-klocalizedstringtest ...   Passed0.74 secStart 4: ki18n-ktranscripttest4/6 Test #4: ki18n-ktranscripttest    Passed0.18 secStart 5: ki18n-ktranscriptcleantest5/6 Test #5: ki18n-ktranscriptcleantest ...   Passed0.03 secStart 6: ki18n_install6/6 Test #6: ki18n_install    Passed4.06 sec100% tests passed, 0 tests failed out of 6Total Test time (real) =   5.77 secXIO:  fatal IO error 4 (Interrupted system call) on X server ":90"  after 838 requests (838 known processed) with 0 events remaining.[Pipeline] junitRecording test results[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Installing)[Pipeline] sh[Frameworks ki18n kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/install-build.py --product Frameworks --project ki18n --branchGroup kf5-qt5 --platform SUSEQt5.10 --installTo /home/jenkins//install-prefix/ --divertTo '/home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.10/install-divert/'[  5%] Automatic MOC for target KF5I18n[  5%] Automatic MOC for target ktranscript[  5%] Built target ktranscript_autogen[  5%] Built target KF5I18n_autogen[ 17%] Built target ktranscript[ 44%] Built target KF5I18n[ 50%] Automatic MOC for target ki18n-ktranscripttest[ 50%] Automatic MOC for target ki18n-declarativetest[ 50%] Built target ki18n-ktranscripttest_autogen[ 50%] Built target ki18n-declarativetest_autogen[ 52%] Automatic MOC for target ki18n-ktranscriptcleantest[ 55%] Automatic MOC for target ki18n-klocalizedstringtest[ 55%] Built target ki18n-klocalizedstringtest_autogen[ 55%] Built target ki18n-ktranscriptcleantest_autogen[ 64%] Built target ki18n-declarativetest[ 76%] Built target ki18n-ktranscripttest[ 91%] Built target ki18n-ktranscriptcleantest[100%] Built target ki18n-klocalizedstringtestInstall the proj

KDE CI: Frameworks ki18n kf5-qt5 SUSEQt5.9 - Build # 32 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.9/32/
 Project:
Frameworks ki18n kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 27 Jul 2018 08:50:26 +
 Build duration:
1 min 44 sec and counting
   CONSOLE OUTPUT
  [...truncated 132.42 KB...]In file included from /home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.9/autotests/klocalizedstringtest.cpp:34:/home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.9/src/klocalizedstring.h:624:55: note: declared here Q_REQUIRED_RESULT KI18N_DEPRECATED static QString translateQt(const char *context, const char *text,   ^~~/home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.9/autotests/klocalizedstringtest.cpp:473:98: warning: ‘static QString KLocalizedString::translateQt(const char*, const char*, const char*, int)’ is deprecated [-Wdeprecated-declarations] QString result = KLocalizedString::translateQt("QPrintPreviewDialog", "Landscape", nullptr, 0);  ^In file included from /home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.9/autotests/klocalizedstringtest.cpp:34:/home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.9/src/klocalizedstring.h:624:55: note: declared here Q_REQUIRED_RESULT KI18N_DEPRECATED static QString translateQt(const char *context, const char *text,   ^~~/home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.9/autotests/klocalizedstringtest.cpp:490:23: warning: ‘static void KLocalizedString::removeQtDomain(const char*)’ is deprecated [-Wdeprecated-declarations] KLocalizedString::removeQtDomain("ki18n-test-qt");   ^~In file included from /home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.9/autotests/klocalizedstringtest.cpp:34:/home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.9/src/klocalizedstring.h:655:34: note: declared here KI18N_DEPRECATED static void removeQtDomain(const char *domain);  ^~/home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.9/autotests/klocalizedstringtest.cpp:490:53: warning: ‘static void KLocalizedString::removeQtDomain(const char*)’ is deprecated [-Wdeprecated-declarations] KLocalizedString::removeQtDomain("ki18n-test-qt"); ^In file included from /home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.9/autotests/klocalizedstringtest.cpp:34:/home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.9/src/klocalizedstring.h:655:34: note: declared here KI18N_DEPRECATED static void removeQtDomain(const char *domain);  ^~/home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.9/autotests/klocalizedstringtest.cpp:490:53: warning: ‘static void KLocalizedString::removeQtDomain(const char*)’ is deprecated [-Wdeprecated-declarations] KLocalizedString::removeQtDomain("ki18n-test-qt"); ^In file included from /home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.9/autotests/klocalizedstringtest.cpp:34:/home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.9/src/klocalizedstring.h:655:34: note: declared here KI18N_DEPRECATED static void removeQtDomain(const char *domain);  ^~[ 64%] Building CXX object autotests/CMakeFiles/ki18n-klocalizedstringtest.dir/ki18n-klocalizedstringtest_autogen/mocs_compilation.cpp.o[ 67%] Linking CXX executable ../bin/ki18n-klocalizedstringtest[ 67%] Built target ki18n-klocalizedstringtestScanning dependencies of target ki18n-ktranscriptcleantest_autogen[ 70%] Automatic MOC for target ki18n-ktranscriptcleantest[ 70%] Built target ki18n-ktranscriptcleantest_autogenScanning dependencies of target ki18n-ktranscripttest_autogen[ 73%] Automatic MOC for target ki18n-ktranscripttest[ 73%] Built target ki18n-ktranscripttest_autogenScanning dependencies of target ki18n-ktranscriptcleantest[ 76%] Building CXX object autotests/CMakeFiles/ki18n-ktranscriptcleantest.dir/ktranscriptcleantest.cpp.o[ 79%] Building CXX object autotests/CMakeFiles/ki18n-ktranscriptcleantest.dir/ki18n-ktranscriptcleantest_autogen/mocs_compilation.cpp.o[ 82%] Building CXX object autotests/CMakeFiles/ki18n-ktranscriptcleantest.dir/__/src/common_helpers.cpp.o[ 85%] Building CXX object autotests/CMakeFiles/ki18n-ktranscriptcleantest.dir/__/src/ktranscript.cpp.o[ 88%] Linking CXX executable ../bin/ki18n-ktranscriptcleantest[ 88%] Built target ki18n-ktranscriptcleantestScanning dependencies of target ki18n-ktranscripttest[ 91%] Building CXX object autotests/CMakeFiles/ki18n-ktranscripttest.dir/ktranscripttest.cpp.o[ 94%] Building CXX object 

KDE CI: Frameworks ki18n kf5-qt5 FreeBSDQt5.10 - Build # 16 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20FreeBSDQt5.10/16/
 Project:
Frameworks ki18n kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 27 Jul 2018 08:50:26 +
 Build duration:
45 sec and counting
   CONSOLE OUTPUT
  [...truncated 89.83 KB...]Scanning dependencies of target ki18n-ktranscripttest_autogenScanning dependencies of target ki18n-ktranscriptcleantest_autogenScanning dependencies of target ki18n-klocalizedstringtest_autogenScanning dependencies of target ki18n-declarativetest_autogen[ 47%] Automatic MOC for target ki18n-ktranscripttest[ 50%] Automatic MOC for target ki18n-declarativetest[ 52%] Automatic MOC for target ki18n-klocalizedstringtest[ 55%] Automatic MOC for target ki18n-ktranscriptcleantest[ 55%] Built target ki18n-ktranscripttest_autogen[ 55%] Built target ki18n-klocalizedstringtest_autogen[ 55%] Built target ki18n-ktranscriptcleantest_autogenScanning dependencies of target ki18n-ktranscripttestScanning dependencies of target ki18n-klocalizedstringtest[ 55%] Built target ki18n-declarativetest_autogen[ 58%] Building CXX object autotests/CMakeFiles/ki18n-ktranscripttest.dir/ktranscripttest.cpp.o[ 61%] Building CXX object autotests/CMakeFiles/ki18n-klocalizedstringtest.dir/klocalizedstringtest.cpp.o[ 64%] Building CXX object autotests/CMakeFiles/ki18n-klocalizedstringtest.dir/ki18n-klocalizedstringtest_autogen/mocs_compilation.cpp.o[ 67%] Building CXX object autotests/CMakeFiles/ki18n-ktranscripttest.dir/ki18n-ktranscripttest_autogen/mocs_compilation.cpp.o[ 70%] Building CXX object autotests/CMakeFiles/ki18n-ktranscripttest.dir/testhelpers.cpp.oScanning dependencies of target ki18n-ktranscriptcleantestScanning dependencies of target ki18n-declarativetest[ 73%] Building CXX object autotests/CMakeFiles/ki18n-ktranscriptcleantest.dir/ktranscriptcleantest.cpp.o[ 76%] Building CXX object autotests/CMakeFiles/ki18n-ktranscriptcleantest.dir/__/src/common_helpers.cpp.o[ 79%] Building CXX object autotests/CMakeFiles/ki18n-ktranscriptcleantest.dir/__/src/ktranscript.cpp.o[ 82%] Building CXX object autotests/CMakeFiles/ki18n-declarativetest.dir/ki18ndeclarativetest.cpp.o[ 85%] Building CXX object autotests/CMakeFiles/ki18n-ktranscriptcleantest.dir/ki18n-ktranscriptcleantest_autogen/mocs_compilation.cpp.o[ 88%] Building CXX object autotests/CMakeFiles/ki18n-declarativetest.dir/ki18n-declarativetest_autogen/mocs_compilation.cpp.o[ 91%] Linking CXX executable ../bin/ki18n-declarativetest/usr/home/jenkins/workspace/Frameworks ki18n kf5-qt5 FreeBSDQt5.10/autotests/klocalizedstringtest.cpp:472:23: warning: 'insertQtDomain' is deprecated [-Wdeprecated-declarations]KLocalizedString::insertQtDomain("ki18n-test-qt");  ^/usr/home/jenkins/workspace/Frameworks ki18n kf5-qt5 FreeBSDQt5.10/src/klocalizedstring.h:637:34: note: 'insertQtDomain' has been explicitly marked deprecated hereKI18N_DEPRECATED static void insertQtDomain(const char *domain); ^/usr/home/jenkins/workspace/Frameworks ki18n kf5-qt5 FreeBSDQt5.10/autotests/klocalizedstringtest.cpp:473:40: warning: 'translateQt' is deprecated [-Wdeprecated-declarations]QString result = KLocalizedString::translateQt("QPrintPreviewDialog", "Landscape", nullptr, 0);   ^/usr/home/jenkins/workspace/Frameworks ki18n kf5-qt5 FreeBSDQt5.10/src/klocalizedstring.h:624:55: note: 'translateQt' has been explicitly marked deprecated hereQ_REQUIRED_RESULT KI18N_DEPRECATED static QString translateQt(const char *context, const char *text,  ^/usr/home/jenkins/workspace/Frameworks ki18n kf5-qt5 FreeBSDQt5.10/autotests/klocalizedstringtest.cpp:490:23: warning: 'removeQtDomain' is deprecated [-Wdeprecated-declarations]KLocalizedString::removeQtDomain("ki18n-test-qt");  ^/usr/home/jenkins/workspace/Frameworks ki18n kf5-qt5 FreeBSDQt5.10/src/klocalizedstring.h:655:34: note: 'removeQtDomain' has been explicitly marked deprecated hereKI18N_DEPRECATED static void removeQtDomain(const char *domain); ^[ 91%] Built target ki18n-declarativetest[ 94%] Linking CXX executable ../bin/ki18n-ktranscriptcleantest[ 97%] Linking CXX executable ../bin/ki18n-ktranscripttest[ 97%] Built target ki18n-ktranscripttest[ 97%] Built target ki18n-ktranscriptcleantest3 warnings generated.[100%] Linking CXX executable ../bin/ki18n-klocalizedstringtest[100%] Built target ki18n-klocalizedstringtest[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Installing)[Pipeline] sh[Frameworks ki18n kf5-qt5 FreeBSDQt5.10] Running shell script+ python3.5 -u ci-tooling/helpers/install-build.py --product Frameworks --project ki18n --branchGroup kf5-qt5 --platform FreeBSDQt5.10 --installTo /home/jenkins/install-prefix/ --divertTo '/usr/home/jenkins/workspace/Frameworks ki18n kf5-qt5 FreeBSDQt5.10/install-divert/'[  2%] Automatic MOC 

KDE CI: Frameworks ki18n kf5-qt5 AndroidQt5.11 - Build # 12 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20AndroidQt5.11/12/
 Project:
Frameworks ki18n kf5-qt5 AndroidQt5.11
 Date of build:
Fri, 27 Jul 2018 08:50:26 +
 Build duration:
55 sec and counting
   CONSOLE OUTPUT
  [...truncated 89.92 KB...][ 23%] Building CXX object src/CMakeFiles/KF5I18n.dir/kcatalog.cpp.o[ 26%] Building CXX object src/CMakeFiles/KF5I18n.dir/kuitmarkup.cpp.oIn file included from /home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.11/src/kcatalog.cpp:23:0:/home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.11/src/gettext.h: In function 'const char* dpgettext_expr(const char*, const char*, const char*)':/home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.11/src/gettext.h:115:45: warning: ISO C++ forbids variable length array 'msg_ctxt_id' [-Wvla] char msg_ctxt_id[msgctxt_len + msgid_len]; ^/home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.11/src/gettext.h: In function 'const char* dnpgettext_expr(const char*, const char*, const char*, const char*, long unsigned int)':/home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.11/src/gettext.h:165:45: warning: ISO C++ forbids variable length array 'msg_ctxt_id' [-Wvla] char msg_ctxt_id[msgctxt_len + msgid_len]; ^[ 29%] Building CXX object src/CMakeFiles/KF5I18n.dir/KF5I18n_autogen/mocs_compilation.cpp.o[ 32%] Building CXX object src/CMakeFiles/KF5I18n.dir/main.cpp.o[ 35%] Building CXX object src/CMakeFiles/KF5I18n.dir/klocalizedcontext.cpp.o[ 38%] Building CXX object src/CMakeFiles/KF5I18n.dir/common_helpers.cpp.o[ 41%] Linking CXX shared module ../bin/ktranscript.so[ 41%] Built target ktranscript[ 44%] Linking CXX shared library ../bin/libKF5I18n.so[ 44%] Built target KF5I18nScanning dependencies of target ki18n-ktranscripttest_autogenScanning dependencies of target ki18n-declarativetest_autogenScanning dependencies of target ki18n-ktranscriptcleantest_autogenScanning dependencies of target ki18n-klocalizedstringtest_autogen[ 47%] Automatic MOC for target ki18n-ktranscripttest[ 50%] Automatic MOC for target ki18n-ktranscriptcleantest[ 52%] Automatic MOC for target ki18n-declarativetest[ 55%] Automatic MOC for target ki18n-klocalizedstringtest[ 55%] Built target ki18n-ktranscripttest_autogen[ 55%] Built target ki18n-klocalizedstringtest_autogen[ 55%] Built target ki18n-ktranscriptcleantest_autogen[ 55%] Built target ki18n-declarativetest_autogenScanning dependencies of target ki18n-klocalizedstringtestScanning dependencies of target ki18n-ktranscripttestScanning dependencies of target ki18n-declarativetestScanning dependencies of target ki18n-ktranscriptcleantest[ 58%] Building CXX object autotests/CMakeFiles/ki18n-klocalizedstringtest.dir/klocalizedstringtest.cpp.o[ 61%] Building CXX object autotests/CMakeFiles/ki18n-klocalizedstringtest.dir/ki18n-klocalizedstringtest_autogen/mocs_compilation.cpp.o[ 64%] Building CXX object autotests/CMakeFiles/ki18n-declarativetest.dir/ki18ndeclarativetest.cpp.o[ 67%] Building CXX object autotests/CMakeFiles/ki18n-declarativetest.dir/ki18n-declarativetest_autogen/mocs_compilation.cpp.o[ 76%] Building CXX object autotests/CMakeFiles/ki18n-ktranscripttest.dir/testhelpers.cpp.o[ 76%] Building CXX object autotests/CMakeFiles/ki18n-ktranscripttest.dir/ktranscripttest.cpp.o[ 76%] Building CXX object autotests/CMakeFiles/ki18n-ktranscripttest.dir/ki18n-ktranscripttest_autogen/mocs_compilation.cpp.o[ 79%] Building CXX object autotests/CMakeFiles/ki18n-ktranscriptcleantest.dir/ktranscriptcleantest.cpp.o[ 82%] Building CXX object autotests/CMakeFiles/ki18n-ktranscriptcleantest.dir/__/src/ktranscript.cpp.o[ 85%] Building CXX object autotests/CMakeFiles/ki18n-ktranscriptcleantest.dir/__/src/common_helpers.cpp.o[ 88%] Building CXX object autotests/CMakeFiles/ki18n-ktranscriptcleantest.dir/ki18n-ktranscriptcleantest_autogen/mocs_compilation.cpp.o[ 91%] Linking CXX executable ../bin/ki18n-declarativetest[ 91%] Built target ki18n-declarativetest[ 94%] Linking CXX executable ../bin/ki18n-ktranscripttest[ 94%] Built target ki18n-ktranscripttest[ 97%] Linking CXX executable ../bin/ki18n-klocalizedstringtest[ 97%] Built target ki18n-klocalizedstringtest[100%] Linking CXX executable ../bin/ki18n-ktranscriptcleantest[100%] Built target ki18n-ktranscriptcleantest[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Installing)[Pipeline] sh[Frameworks ki18n kf5-qt5 AndroidQt5.11] Running shell script+ python3 -u ci-tooling/helpers/install-build.py --product Frameworks --project ki18n --branchGroup kf5-qt5 --platform AndroidQt5.11 --installTo /home/user/install-prefix/ --divertTo /home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.11/install-divert/[  5%] Automatic MOC for target ktranscript[  5%] Automatic MOC for target KF5I18n[  5%] Built target ktranscript_autogen[  5%] Built target KF5I18n_autogen[ 17%] Built target 

D13744: Let ki18n macro file name follow style of other find_package related files

[Ralf Habacker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R249:382cf9ca29ad: Let ki18n macro file name follow style of 
other find_package related files (authored by habacker).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13744?vs=38567=38568#toc

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13744?vs=38567=38568

REVISION DETAIL
  https://phabricator.kde.org/D13744

AFFECTED FILES
  CMakeLists.txt
  KF5I18nConfig.cmake.in
  autotests/ki18n_install/CMakeLists.txt
  cmake/KF5I18NMacros.cmake.in
  cmake/KF5I18nMacros.cmake.in

To: habacker, apol, ilic
Cc: kde-frameworks-devel, leinir, michaelh, ngraham, bruns

D13744: Let ki18n macro file name follow style of other find_package related files

[Ralf Habacker]

habacker updated this revision to Diff 38567.
habacker added a comment.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.


  - rebased

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13744?vs=36709=38567

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13744

AFFECTED FILES
  CMakeLists.txt
  KF5I18nConfig.cmake.in
  autotests/ki18n_install/CMakeLists.txt
  cmake/KF5I18NMacros.cmake.in
  cmake/KF5I18nMacros.cmake.in

To: habacker, apol, ilic
Cc: kde-frameworks-devel, leinir, michaelh, ngraham, bruns

D12945: kcoredirlister lstItems benchmark

[Jaime Torres Amate]

jtamate edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12945

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns