KDE CI: Frameworks kdoctools kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/49/
 Project:
Frameworks kdoctools kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 15 Aug 2018 07:01:43 +
 Build duration:
1 min 8 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kdoctools_install
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(1/1)67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)

D14817: Convert manual install test to an autotest

[Ben Cooksley]

bcooksley added a comment.


  This change has caused CI wide breakage and makes kdoctools unrelocatable. It 
needs to be reverted urgently, and Dependency Builds triggered to roll it out 
to all the non Frameworks jobs which have already picked this up.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: bcooksley, kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, 
ngraham, bruns, skadinna

D14817: Convert manual install test to an autotest

[Ralf Habacker]

habacker added a comment.


  This is the remaining issue on non Windows KDE CI Qt 5.10
  
  
https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/49/consoleFull
  
07:02:43 cd "/home/jenkins/workspace/Frameworks kdoctools kf5-qt5 
SUSEQt5.10/autotests/kdoctools-install" && "/home/jenkins/workspace/Frameworks 
kdoctools kf5-qt5 SUSEQt5.10/build/bin/meinproc5" --check --cache 
/home/jenkins/workspace/Frameworks\ kdoctools\ kf5-  qt5\ 
SUSEQt5.10/build/autotests/kdoctools-install/po/es/docs/foobar/index.cache.bz2 
po/es/docs/foobar/index.docbook
07:02:43 gmake[2]: *** 
[CMakeFiles/po-es-docs-foobar-index-cache-bz2.dir/build.make:65: 
po/es/docs/foobar/index.cache.bz2] Error 1

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: bcooksley, kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, 
ngraham, bruns, skadinna

D14817: Convert manual install test to an autotest

[Ralf Habacker]

habacker added a comment.


  In D14817#309281 , @bcooksley 
wrote:
  
  > This change has caused CI wide breakage and makes kdoctools unrelocatable.
  
  
  This has been fixed with commit  
https://phabricator.kde.org/R238:4e48476f47414f1077a181ef56a19f7d9289d50d
  
  See other comments for the remaining issues.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: bcooksley, kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, 
ngraham, bruns, skadinna

D14817: Convert manual install test to an autotest

[Ralf Habacker]

habacker added a comment.


  In D14817#309283 , @habacker wrote:
  
  > This is the remaining issue on non Windows KDE CI Qt 5.10
  >
  > 
https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/49/consoleFull
  >
  >   07:02:43 cd "/home/jenkins/workspace/Frameworks kdoctools kf5-qt5 
SUSEQt5.10/autotests/kdoctools-install" && "/home/jenkins/workspace/Frameworks 
kdoctools kf5-qt5 SUSEQt5.10/build/bin/meinproc5" --check --cache 
/home/jenkins/workspace/Frameworks\ kdoctools\ kf5-  qt5\ 
SUSEQt5.10/build/autotests/kdoctools-install/po/es/docs/foobar/index.cache.bz2 
po/es/docs/foobar/index.docbook
  >   07:02:43 gmake[2]: *** 
[CMakeFiles/po-es-docs-foobar-index-cache-bz2.dir/build.make:65: 
po/es/docs/foobar/index.cache.bz2] Error 1
  
  
  Funny, that this works with Qt 5.9 
https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.9/ and Qt 
5.11 (locally tested) - it only happens with Qt 5.10

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: bcooksley, kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, 
ngraham, bruns, skadinna

D14817: Convert manual install test to an autotest

[Ralf Habacker]

habacker added a comment.


  In D14817#309285 , @habacker wrote:
  
  > Funny, that this works with Qt 5.9 
https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.9/ and Qt 
5.11 (locally tested) - it only happens with Qt 5.10
  
  
  Because I cannot reproduce this issue on a local build there is the question 
how

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: bcooksley, kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, 
ngraham, bruns, skadinna

D14817: Convert manual install test to an autotest

[Ralf Habacker]

habacker added a comment.


  According to https://cgit.kde.org/kdoctools.git/tree/src/meinproc.cpp#n51 
uses meinproc5  qCCritical(KDocToolsLog) - How can this be enabled on KDE CI ?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: bcooksley, kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, 
ngraham, bruns, skadinna

D14817: Convert manual install test to an autotest

[Ralf Habacker]

habacker added a comment.


  In D14817#309281 , @bcooksley 
wrote:
  
  > Dependency Builds triggered to roll it out to all the non Frameworks jobs 
which have already picked this up.
  
  
  How to do this ?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: bcooksley, kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, 
ngraham, bruns, skadinna

D14817: Convert manual install test to an autotest

[Ben Cooksley]

bcooksley added a comment.


  You aren't seeing the error the CI system sees because your build prefix 
still exists. Try removing that and the error it has should show up on your 
local system

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: bcooksley, kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, 
ngraham, bruns, skadinna

D14817: Convert manual install test to an autotest

[Ralf Habacker]

habacker added a comment.


  In D14817#309295 , @habacker wrote:
  
  > According to https://cgit.kde.org/kdoctools.git/tree/src/meinproc.cpp#n51 
uses meinproc5  qCCritical(KDocToolsLog) - How can this be enabled on KDE CI ?
  
  
  Got it - see 
https://phabricator.kde.org/R238:81a3d951169b7f575c0a09c2cf19eb911fab9882

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: bcooksley, kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, 
ngraham, bruns, skadinna

KDE CI: Frameworks kdoctools kf5-qt5 SUSEQt5.10 - Build # 50 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/50/
 Project:
Frameworks kdoctools kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 15 Aug 2018 07:52:38 +
 Build duration:
3 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kdoctools_install
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(1/1)67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)

D11838: Turn on line numbers by default

[Dominik Haumann]

dhaumann added a comment.


  Just to make everyone aware of what this implies:
  
  1. Every application now has a separate KTextEditor configuration
  2. Every application now has line numbers on by default (that includes Kile)
  
  Especially 2. is something that was @mludwig definitely wanted to avoid...
  
  @mludwig @cullmann Can you both please discuss a solution that works for 
Kile? If this is not fixed this week during Akademy, it will likely not be 
fixed until the next KDE Frameworks releases.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D11838

To: ngraham, #kate, #ktexteditor, dhaumann, mludwig
Cc: kwrite-devel, kde-frameworks-devel, cullmann, aacid, acrouthamel, brauch, 
mludwig, kfunk, dhaumann, michaelh, kevinapavew, ngraham, bruns, demsking, sars

D11838: Turn on line numbers by default

[Dominik Haumann]

dhaumann added a comment.


  @mludwig @cullmann Sorry, what I wrote is not correct, since this change is 
in Kate, not KTextEditor. Sorry for the noise... :)

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D11838

To: ngraham, #kate, #ktexteditor, dhaumann, mludwig
Cc: kwrite-devel, kde-frameworks-devel, cullmann, aacid, acrouthamel, brauch, 
mludwig, kfunk, dhaumann, michaelh, kevinapavew, ngraham, bruns, demsking, sars

D14817: Convert manual install test to an autotest

[Ben Cooksley]

bcooksley added a comment.


  The Windows failure looks like a problem with handling of DESTDIR - probably 
due to reliance on it being handled by $DESTDIR instead of %DESTDIR% (which is 
the correct syntax for Windows)

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: bcooksley, kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, 
ngraham, bruns, skadinna

D12587: Indentation script for R

[Pierre de Villemereuil]

devillemereuil added a comment.


  Just to say: this didn't fall off my radar. I'm just incredibly busy nowadays 
and it never quite make it to the top of my todo list... But I think about 
doing it regularly, which is a good sign it'll happen!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12587

To: devillemereuil, #ktexteditor, #rkward, cullmann
Cc: kwrite-devel, kde-frameworks-devel, cullmann, tfry, dhaumann, michaelh, 
kevinapavew, ngraham, bruns, demsking, sars

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 - Build # 122 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.9/122/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 15 Aug 2018 08:19:29 +
 Build duration:
6 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 15 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5181/13168)29%
(2736/9434)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1073/1117)51%
(555/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(746/2232)27%
(384/1432)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)49%
(1700/3505)39%
(1030/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(944/1556)42%
(425/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1975)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%
(0/1)0%

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 199 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/199/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 15 Aug 2018 08:19:30 +
 Build duration:
6 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13107)19%
(1821/9434)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(299/2212)7%
(96/1432)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(663/1542)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1976)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
  

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 219 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/219/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 15 Aug 2018 08:19:35 +
 Build duration:
7 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 59 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(258/396)65%
(258/396)53%
(31995/59969)38%
(16186/42784)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(55/55)100%
(55/55)95%
(9072/9503)51%
(3972/7804)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8332/14358)50%
(4652/9293)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3893/7926)34%
(1585/4669)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1022)38%
(315/830)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
(698/1373

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 374 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/374/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 15 Aug 2018 08:19:36 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 59 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(258/396)65%
(258/396)53%
(31961/59969)38%
(16182/42786)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(55/55)100%
(55/55)95%
(9072/9503)51%
(3975/7804)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8284/14358)50%
(4635/9289)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3894/7926)34%
(1586/4669)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(528/1022)38%
(316/830)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4320)35%
(1306/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)52%
(719/1373)43%

D14856: Search: Add workaround for missing icons in Gnome icon-theme

[Kåre Särs]

sars created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
sars requested review of this revision.

TEST PLAN
  Install Gnome-icon-theme and start kate using that theme

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14856

AFFECTED FILES
  src/search/katesearchbar.cpp

To: sars
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14817: Convert manual install test to an autotest

[Ralf Habacker]

habacker added a comment.


  In D14817#309303 , @bcooksley 
wrote:
  
  > Try removing that and the error it has should show up on your local system
  
  
  I see. 
  Since this problem has been fixed in kdoctools git repo and kdoctools has 
been rebuilt on KDE CI, packages like kio, which depend on kdoctools, are 
automatically rebuilt, as is the case with OBS?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: bcooksley, kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, 
ngraham, bruns, skadinna

D14856: Search: Add workaround for missing icons in Gnome icon-theme

[Kåre Särs]

sars added a reviewer: Kate.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14856

To: sars, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14856: Search: Add workaround for missing icons in Gnome icon-theme

[Kåre Särs]

sars edited the test plan for this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14856

To: sars
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14817: Convert manual install test to an autotest

[Ralf Habacker]

habacker added a comment.


  In D14817#309332 , @bcooksley 
wrote:
  
  > The Windows failure looks like a problem with handling of DESTDIR - 
probably due to reliance on it being handled by $DESTDIR instead of %DESTDIR% 
(which is the correct syntax for Windows)
  
  
  No , it is a install path mismatch.  According to 
https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20WindowsMSVCQt5.10/39/console
 the files are installed below <...>/bin/data 
(https://cgit.kde.org/extra-cmake-modules.git/tree/kde-modules/KDEInstallDirs.cmake)
 but test.qmake expects them in <...>/share 
(https://cgit.kde.org/kdoctools.git/tree/autotests/kdoctools-install/test.cmake)

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: bcooksley, kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, 
ngraham, bruns, skadinna

D12587: Indentation script for R

[Dominik Haumann]

dhaumann added a comment.


  @devillemereuil That is good to hear. If you can, feel free to paste a 
MIT-licensed snippet of R-code with a function, a loop, a if-condition etc. 
Maybe we find the time to turn this into a unit test. The code does not need to 
run, it just needs to be syntactically correct.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12587

To: devillemereuil, #ktexteditor, #rkward, cullmann
Cc: kwrite-devel, kde-frameworks-devel, cullmann, tfry, dhaumann, michaelh, 
kevinapavew, ngraham, bruns, demsking, sars

D14856: Search: Add workaround for missing icons in Gnome icon-theme

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Albeit a bi hacky, if that helps Kate users on Gnome, I am fine with this.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14856

To: sars, #kate, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars

D14856: Search: Add workaround for missing icons in Gnome icon-theme

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> katesearchbar.cpp:1332
> +// Gnome does not seem to have all icons we want, so we use 
> fall-back icons for those that are missing.
> +QIcon mutateIcon = 
> QIcon::hasThemeIcon(QStringLiteral("games-config-options")) ? 
> QIcon::fromTheme(QStringLiteral("games-config-options")) : 
> QIcon::fromTheme(QStringLiteral("preferences-system"));
> +QIcon matchCaseIcon = 
> QIcon::hasThemeIcon(QStringLiteral("format-text-superscript")) ? 
> QIcon::fromTheme(QStringLiteral("format-text-superscript")) : 
> QIcon::fromTheme(QStringLiteral("format-text-bold"));

`hasThemeIcon)foo)` just does `!QIcon::fromTheme(foo).isNull()` so you might as 
well just do the same and safe a lookup

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14856

To: sars, #kate, dhaumann
Cc: broulik, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, cullmann, sars

D14856: Search: Add workaround for missing icons in Gnome icon-theme

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> broulik wrote in katesearchbar.cpp:1332
> `hasThemeIcon)foo)` just does `!QIcon::fromTheme(foo).isNull()` so you might 
> as well just do the same and safe a lookup

What would also be possible:

QIcon mutateIcon = QIcon::fromTheme(QStringLiteral("games-config-options"), 
QIcon::fromTheme(QStringLiteral("preferences-system")));

The 2nd parameter is the fallback Icon. This would be much shorter.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14856

To: sars, #kate, dhaumann
Cc: broulik, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, cullmann, sars

D14817: Convert manual install test to an autotest

[Ben Cooksley]

bcooksley added a comment.


  On Windows the correct path to use is $prefix/bin/data/... as that is what 
QStandardPaths expects.
  The location $prefix/share/ won't work on Windows, so the test will need to 
handle that case.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: bcooksley, kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, 
ngraham, bruns, skadinna

D13813: Make this test work again with new uds implementation

[Elvis Angelaccio]

elvisangelaccio added a comment.


  @jtamate Any updates on this? Can you use the new `fastInsert()` calls here?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13813

To: jtamate, #dolphin, #frameworks, elvisangelaccio
Cc: dfaure, aacid, ngraham, bruns, elvisangelaccio, kfm-devel, spoorun, 
navarromorales, firef, andrebarros, emmanuelp

KDE CI: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10 - Build # 125 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.10/125/
 Project:
Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 15 Aug 2018 08:19:28 +
 Build duration:
42 min and counting
   JUnit Tests
  Name: (root) Failed: 9 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.coronatestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-framesvgtestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetestFailed: TestSuite.plasma-themetest

D14817: Convert manual install test to an autotest

[Ralf Habacker]

habacker added a comment.


  Because test.qmake do not anything about KDE  install path layout those 
pathes need to be specified in the ctest config in autotests/CMakeLists.txt I 
guess
  
--test-command ${CMAKE_COMMAND}
"-DKDE_INSTALL_MANDIR=${KDE_INSTALL_MANDIR}"
"-DKDE_INSTALL_DOCBUNDLEDIR=${KDE_INSTALL_DOCBUNDLEDIR}"

"-DCMAKE_INSTALL_PREFIX:PATH=${CMAKE_CURRENT_BINARY_DIR}/kdoctools-install/destdir"
-P "${CMAKE_CURRENT_SOURCE_DIR}/kdoctools-install/test.cmake")
  
  and in test.qmake
  
...
set(MANPATH ${CMAKE_INSTALL_PREFIX}/${KDE_INSTALL_MANDIR})
set(HTMLPATH ${CMAKE_INSTALL_PREFIX}/${KDE_INSTALL_DOCBUNDLEDIR})
 ...

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: bcooksley, kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, 
ngraham, bruns, skadinna

D12587: Indentation script for R

[Pierre de Villemereuil]

devillemereuil added a comment.


  I might get to that around September (no promise). If people are willing to 
help, my not-unit-at-all test code for indentation can be found here:
  https://github.com/devillemereuil/rindent/blob/master/example.R
  
  Automatic indent should not impact the code (this is how I test my commits), 
meaning it is already indented as the script is willing to indent.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12587

To: devillemereuil, #ktexteditor, #rkward, cullmann
Cc: kwrite-devel, kde-frameworks-devel, cullmann, tfry, dhaumann, michaelh, 
kevinapavew, ngraham, bruns, demsking, sars

D14817: Convert manual install test to an autotest

[Ralf Habacker]

habacker added a comment.


  another option would be to force the install path in the cmake call
  
add_test(kdoctools_install ${CMAKE_CTEST_COMMAND}
  --build-and-test
  "${CMAKE_CURRENT_SOURCE_DIR}/kdoctools-install"
  "${CMAKE_CURRENT_BINARY_DIR}/kdoctools-install"
  --build-generator ${CMAKE_GENERATOR}
  --build-makeprogram ${CMAKE_MAKE_PROGRAM}
  --build-target install
  --build-options
  "-DCMAKE_MODULE_PATH=${CMAKE_MODULE_PATH}"
  
"-DCMAKE_INSTALL_PREFIX:PATH=${CMAKE_CURRENT_BINARY_DIR}/kdoctools-install/destdir"
  "-DKF5DocTools_DIR=${CMAKE_BINARY_DIR}/cmake"
  "-DKDOCTOOLS_CUSTOMIZATION_DIR=${KDOCTOOLS_CUSTOMIZATION_DIR}"
  "-DKDOCTOOLS_ENABLE_HTMLHANDBOOK=1"
 ...
"-DKDE_INSTALL_MANDIR=share/man"
"-DKDE_INSTALL_DOCBUNDLEDIR=share/doc/HTML"

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: bcooksley, kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, 
ngraham, bruns, skadinna

D14817: Convert manual install test to an autotest

[Ralf Habacker]

habacker added a comment.


  In D14817#309370 , @bcooksley 
wrote:
  
  > On Windows the correct path to use is $prefix/bin/data/... as that is what 
QStandardPaths expects.
  >  The location $prefix/share/ won't work on Windows, so the test will need 
to handle that case.
  
  
  Agreed, as long as there is Qt on Windows not patched to also use unix style 
path layout, which is the case on OBS

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: bcooksley, kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, 
ngraham, bruns, skadinna

D14856: Search: Add workaround for missing icons in Gnome icon-theme

[Kåre Särs]

sars updated this revision to Diff 39772.
sars added a comment.


  use fromTheme("foo", fromTheme("fall-back"));

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14856?vs=39766&id=39772

REVISION DETAIL
  https://phabricator.kde.org/D14856

AFFECTED FILES
  src/search/katesearchbar.cpp

To: sars, #kate, dhaumann
Cc: broulik, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, cullmann, sars

D14856: Search: Add workaround for missing icons in Gnome icon-theme

[Kåre Särs]

sars marked an inline comment as done.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14856

To: sars, #kate, dhaumann
Cc: broulik, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, cullmann, sars

D8964: Fix two bugs in KMessageWidget

[Albert Astals Cid]

This revision was not accepted when it landed; it landed in state "Changes 
Planned".
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:e3368be660e3: Fix two bugs in KMessageWidget (authored by 
aacid).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8964?vs=22827&id=39774#toc

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8964?vs=22827&id=39774

REVISION DETAIL
  https://phabricator.kde.org/D8964

AFFECTED FILES
  autotests/kmessagewidgetautotest.cpp
  autotests/kmessagewidgetautotest.h
  src/kmessagewidget.cpp

To: aacid, #frameworks, dhaumann
Cc: kde-frameworks-devel, ngraham, dhaumann, anthonyfieroni, #frameworks, 
michaelh, bruns

D14817: Convert manual install test to an autotest

[Ralf Habacker]

habacker added a comment.


  In D14817#309388 , @habacker wrote:
  
  > Agreed, as long as there is Qt on Windows not patched to also use unix 
style path layout, which is the case on OBS
  
  
  but this case should be covered by ECM module 'KDEInstallDirs'.
  
  If KDE_INSTALL_XXX always return a relative dir , it should be save to use

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: bcooksley, kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, 
ngraham, bruns, skadinna

D14856: Search: Add workaround for missing icons in Gnome icon-theme

[Kai Uwe Broulik]

broulik accepted this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14856

To: sars, #kate, dhaumann, broulik
Cc: broulik, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, cullmann, sars

D14856: Search: Add workaround for missing icons in Gnome icon-theme

[Kåre Särs]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:e63efbdb8e4c: Search: Add workaround for missing icons in 
Gnome icon-theme (authored by sars).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14856?vs=39772&id=39777

REVISION DETAIL
  https://phabricator.kde.org/D14856

AFFECTED FILES
  src/search/katesearchbar.cpp

To: sars, #kate, dhaumann, broulik
Cc: broulik, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, cullmann, sars

D13813: Make this test work again with new uds implementation

[Jaime Torres Amate]

jtamate added a comment.


  In D13813#309371 , 
@elvisangelaccio wrote:
  
  > @jtamate Any updates on this? Can you use the new `fastInsert()` calls here?
  
  
  Not until dolphin depends on KIO 5.47, currently its minimum required kio 
version is 5.43.
  
  But it could land as it is and be ready for just change insert by fastInsert 
when it depends on that kio version.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13813

To: jtamate, #dolphin, #frameworks, elvisangelaccio
Cc: dfaure, aacid, ngraham, bruns, elvisangelaccio, kfm-devel, spoorun, 
navarromorales, firef, andrebarros, emmanuelp

D14859: Don't try to call transaction documentUrl with a 0 id

[Jaime Torres Amate]

jtamate created this revision.
jtamate added a reviewer: Frameworks.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  In Transaction::documentUrl(quint64 id) const, there is
  Q_ASSERT(id > 0);
  so don't even try to call it with a 0 id.

TEST PLAN
  Executing balooshow -i /home/user/* when baloo is creating the index after 
deleting .local/share/baloo
  before: crash (assert)
  after: balooshow ends normally.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D14859

AFFECTED FILES
  src/tools/balooshow/main.cpp

To: jtamate, #frameworks
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D14859: Don't try to call transaction documentUrl with a 0 id

[Pino Toscano]

pino requested changes to this revision.
pino added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.cpp:140
>  fid = Baloo::devIdAndInodeToId(devId, inode);
> -url = QFile::decodeName(tr.documentUrl(fid));
> +if (fid) {
> +url = QFile::decodeName(tr.documentUrl(fid));

maybe `fid > 0` for clarity

> main.cpp:143
> +} else {
> +stream << i18n("No index information for") << url << endl;
> +continue;

string puzzle, please use placeholders for i18n()

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D14859

To: jtamate, #frameworks, pino
Cc: pino, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D14859: Don't try to call transaction documentUrl with a 0 id

[Jaime Torres Amate]

jtamate updated this revision to Diff 39788.
jtamate added a comment.


  Done requested changes.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14859?vs=39784&id=39788

REVISION DETAIL
  https://phabricator.kde.org/D14859

AFFECTED FILES
  src/tools/balooshow/main.cpp

To: jtamate, #frameworks, pino
Cc: pino, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D14274: Modelines: add byte-order-mark & small fixes

[Nibaldo González]

nibags updated this revision to Diff 39789.
nibags added a comment.


  - Fix test (use Modelines in Python instead of Bash)

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14274?vs=39717&id=39789

BRANCH
  arcpatch-D14274

REVISION DETAIL
  https://phabricator.kde.org/D14274

AFFECTED FILES
  autotests/folding/modelines.py.fold
  autotests/html/modelines.py.html
  autotests/input/modelines.py
  autotests/reference/modelines.py.ref
  data/syntax/modelines.xml

To: nibags, turbov, dhaumann, cullmann, vkrause, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

[Ivan Shapovalov]

intelfx added a comment.


  @mwolff @dhaumann @brauch I'm sorry for my silence — I stopped using 
KDE/KDevelop some time ago and did not track this changeset properly. Could you 
please reiterate what was the conclusion and what were @mwolff's requested 
changes?
  
  > The idea is to have just one color for search results that need to match. 
This currently is the foreground color of normal text. We would need to really 
make sure all color schemes still work properly.
  
  Sorry, I did not understand this. Could you please rephrase?
  
  > Couldn't this be fixed by checking what color has the higher contrast - 
selection or normal? Then pick the one that has the higher contrast.
  
  IMO this is too specific logic to hard-code. What if there is a schema 
explicitly designed for low contrast?
  
  > Can't we simply update our shipped schemas, and expect users with custom 
schemas to fix them?
  
  I believe many would oppose :)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5802

To: intelfx, #kdevelop, #ktexteditor, #kate, mwolff
Cc: kde-frameworks-devel, brauch, dhaumann, mwolff, kwrite-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, cullmann, sars

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

[Christoph Feck]

cfeck resigned from this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14779

To: habacker, #frameworks
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

[Christoph Feck]

cfeck removed a reviewer: cfeck.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14779

To: habacker, #frameworks
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D14237: Make Konqi look good in HiDPI

[Christoph Feck]

cfeck added a comment.


  In D14237#299303 , @bruns wrote:
  
  > I have traced the image with GIMPs selection tool, "convert selection to 
path" and export path as SVG.
  
  
  If I understand it correctly, the SVG only contains the outline of the 
selection, but not the actual colors. What I see is just a black silhouette.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D14237

To: ngraham, broulik, cfeck, #frameworks
Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D14237: Make Konqi look good in HiDPI

[Christoph Feck]

cfeck added a reviewer: VDG.
cfeck added a comment.


  Does someone from the VDG use professional tools that are able to trace to 
SVG?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D14237

To: ngraham, broulik, cfeck, #frameworks, #vdg
Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D13808: Fix KMainWindow saving incorrect widget settings

[Christoph Feck]

cfeck added a comment.


  Is this still needed after https://phabricator.kde.org/D14454?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: anthonyfieroni, marten, asturmlechner, wbauer, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

[Christoph Feck]

cfeck edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  more-liberal-recent-document-duplicate-detection (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13804

To: ngraham, broulik, #dolphin, #frameworks, cfeck
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D14757: Warn user before copy operation if available space is not enough

[Shubham]

shubham added a reviewer: cfeck.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14757

To: shubham, pino, dfaure, cfeck
Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14237: Make Konqi look good in HiDPI

[Stefan Brüns]

bruns added a comment.


  In D14237#309615 , @cfeck wrote:
  
  > In D14237#299303 , @bruns wrote:
  >
  > > I have traced the image with GIMPs selection tool, "convert selection to 
path" and export path as SVG.
  >
  >
  > If I understand it correctly, the SVG only contains the outline of the 
selection, but not the actual colors. What I see is just a black silhouette.
  
  
  The outline exported from the GIMP is just an outline. The SVG I attached are 
all outlines properly stacked and filled.
  
  If you see only an outline, your SVG viewer is broken. Try opening it in 
Inkscape.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D14237

To: ngraham, broulik, cfeck, #frameworks, #vdg
Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D14856: Search: Add workaround for missing icons in Gnome icon-theme

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> katesearchbar.cpp:1332
> +// Gnome does not seem to have all icons we want, so we use 
> fall-back icons for those that are missing.
> +QIcon mutateIcon = 
> QIcon::fromTheme(QStringLiteral("games-config-options"), 
> QIcon::fromTheme(QStringLiteral("preferences-system")));
> +QIcon matchCaseIcon = 
> QIcon::fromTheme(QStringLiteral("format-text-superscript"), 
> QIcon::fromTheme(QStringLiteral("format-text-bold")));

Doesn't this evaluate the fallback always, even if not needed?
IIRC QIcon::fromTheme is not really lightweight ...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14856

To: sars, #kate, dhaumann, broulik
Cc: bruns, broulik, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, ngraham, demsking, cullmann, sars

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

[Ralf Habacker]

habacker added a comment.


  In D14779#308603 , @aacid wrote:
  
  > I think that in the test we just need to call
  >
  >   bool QCoreApplication::installTranslator(QTranslator *translationFile)
  >
  > with the location of the fake translation
  
  
  
  
  > and since newest location is tried first it should overwrite the one from 
the ecm loader.
  
  According to 
http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/kernel/qcoreapplication.cpp#n1985
 new translators are prepended - not overwritten. Not sure if a missing 
translation in the latest file added would be search in the previous 
translators.
  
  To  understand you correctly: You really are thinking about generating  a qm 
file  from the kcoreaddons lib source with gettext containing real translations 
 added with lokalize or similar to avoid this issue ?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14779

To: habacker, #frameworks
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D13808: Fix KMainWindow saving incorrect widget settings

[David Faure]

dfaure added a comment.


  I don't understand your question.
  By "this", do you mean the KMainWindow fix that was posted in a previous 
iteration here and that was pushed? That one is very much needed, yes, to make 
setAutoSaveSettings work.
  The change that you link to, is about porting KMail to setAutoSaveSettings, 
so that it benefits from that fix.
  
  If by "this" you mean what's left in this review request, which is to write a 
proper unittest for the KMainWindow fix, yes, that would still be very nice to 
have. But apparently it's pretty hard to write (if emulating native events is 
the only way then indeed it seems really difficult)... so maybe we have to give 
up on the idea.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: anthonyfieroni, marten, asturmlechner, wbauer, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns

D14237: Make Konqi look good in HiDPI

[Christoph Feck]

cfeck added a comment.


  My viewer is QtSVG.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D14237

To: ngraham, broulik, cfeck, #frameworks, #vdg
Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D11604: kdirlistertest doesn't fail at random

[Jaime Torres Amate]

jtamate updated this revision to Diff 39801.
jtamate edited the summary of this revision.
jtamate added a comment.
Herald added a subscriber: kde-frameworks-devel.


  Removed the use of enterLoop and exitLoop in favor of QTRY_COMPARE and 
QTRY_VERIFY.
  Removed some waits
  Changed all the connections to the new syntax.
  Have run it several times and it hasn't failed here.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11604?vs=33623&id=39801

REVISION DETAIL
  https://phabricator.kde.org/D11604

AFFECTED FILES
  autotests/kdirlistertest.cpp
  autotests/kdirlistertest.h

To: jtamate, #frameworks, dfaure
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D14856: Search: Add workaround for missing icons in Gnome icon-theme

[Dominik Haumann]

dhaumann added a comment.


  True... Is this a performance issue? ;)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14856

To: sars, #kate, dhaumann, broulik
Cc: bruns, broulik, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, ngraham, demsking, cullmann, sars

D14274: Modelines: add byte-order-mark & small fixes

[Christoph Cullmann]

cullmann added a comment.


  Will try that out again.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14274

To: nibags, turbov, dhaumann, cullmann, vkrause, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14274: Modelines: add byte-order-mark & small fixes

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Works, will integrate, thanks for the patch!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  arcpatch-D14274

REVISION DETAIL
  https://phabricator.kde.org/D14274

To: nibags, turbov, dhaumann, cullmann, vkrause, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14274: Modelines: add byte-order-mark & small fixes

[Christoph Cullmann]

cullmann closed this revision.
cullmann added a comment.


  Git commit e1c3d16a35ddae90de6e457a31f54d899abb84c8 by Christoph Cullmann, on 
behalf of Nibaldo González.
  Committed on 15/08/2018 at 18:22.
  Pushed by cullmann into branch 'master'.
  
  Modelines: add byte-order-mark & small fixes
  
  Summary:
  Changes:
  
  - Add missing keyword: `byte-order-mark` (there is only "byte-order-marker" 
and "bom"). Obtained from: 
https://docs.kde.org/stable5/en/applications/katepart/config-variables.html
  - Remove keywords delimiters "*" and "+", because in the 
"RemoveSpacesOptions" list, the keywords "*" and "+" are not highlighted.
  - Fix ";" in the "RemoveSpaces" context ("remove-trailing-spaces" variable). 
The character ";" it is not highlighted as in the rest of the variables, since 
when writing a value, the context ends.
  
  F6128802: modelines-spaces.png 
  
  - For a strange reason, the use of ``, 
in others files, causes the line continuation character ("\") to be highlighted 
as `dsNormal`. This is solved by removing the LineContinue rule in the "Normal" 
context in Modelines. I consider the LineContinue & DetectSpaces rules to be 
unnecessary in the "Normal" context, so I've eliminated them.
  
  F6128805: modelines-linecont.png 
  
  I was going to add a test file, but there are errors when generating the html 
and ref files, even with the unmodified modelines.xml file :S
  
  Reviewers: turbov, dhaumann, cullmann, vkrause, #kate 

  
  Reviewed By: cullmann, #kate 
  
  Subscribers: kwrite-devel, kde-frameworks-devel
  
  Tags: #kate , #frameworks 

  
  Differential Revision: https://phabricator.kde.org/D14274
  
  A  +10   -0autotests/folding/modelines.py.fold
  A  +17   -0autotests/html/modelines.py.html
  A  +10   -0autotests/input/modelines.py
  A  +10   -0autotests/reference/modelines.py.ref
  M  +7-4data/syntax/modelines.xml
  
  
https://commits.kde.org/syntax-highlighting/e1c3d16a35ddae90de6e457a31f54d899abb84c8

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14274

To: nibags, turbov, dhaumann, cullmann, vkrause, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14826: inline note interface wip #2

[Sven Brauch]

brauch updated this revision to Diff 39802.
brauch added a comment.


  I added the rest of the interaction interface (click, mouseover)
  and reduced the API a bit by moving a few hints into the InlineNote
  object.
  
  Only thing I still intend to change about the API would be that
  we use the Qt mouse button enum to provide details about mouse events,
  otherwise nothing comes to mind.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14826?vs=39721&id=39802

BRANCH
  inlinenotes

REVISION DETAIL
  https://phabricator.kde.org/D14826

AFFECTED FILES
  CMakeLists.txt
  src/document/katedocument.h
  src/include/CMakeLists.txt
  src/include/ktexteditor/inlinenoteinterface.h
  src/render/katerenderer.cpp
  src/render/katerenderer.h
  src/utils/ktexteditor.cpp
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: brauch, michalsrb, dhaumann, cullmann
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14826: inline note interface wip #2

[Christoph Cullmann]

cullmann added a comment.


  I would not implement any function inline and just hide their implementation 
in the .cpp to be able to alter them later (for InlineNote).
  For the activation, I would like to be able to differentiate between the 
different mouse buttons like the qt mousepressed stuff would do.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14826

To: brauch, michalsrb, dhaumann, cullmann
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D13808: Fix KMainWindow saving incorrect widget settings

[Christoph Feck]

cfeck added a comment.


  Ah, unit tests are still open. Thanks for the clarification.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: anthonyfieroni, marten, asturmlechner, wbauer, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns

D14856: Search: Add workaround for missing icons in Gnome icon-theme

[David Faure]

dfaure added a comment.


  I don't think so, because QIcon::fromTheme just creates an icon engine. The 
actual lookup happens when the first call to isNull or paint (etc) is made. 
None of which are going to be done on the fallback icon if the main icon can be 
found.
  
  So this looks fine to me, unless a profiler or strace says otherwise.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14856

To: sars, #kate, dhaumann, broulik
Cc: dfaure, bruns, broulik, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, ngraham, demsking, cullmann, sars

D14826: inline note interface wip #2

[Dominik Haumann]

dhaumann added a comment.


  I think this goes into the right direction :-)

INLINE COMMENTS

> inlinenoteinterface.h:2
> +/* This file is part of the KDE libraries
> +
> +   This library is free software; you can redistribute it and/or

author missing

> inlinenoteinterface.h:73
> + * \see InlineNoteProvider
> + */
> +class KTEXTEDITOR_EXPORT InlineNoteInterface

@since 5.50

> inlinenoteinterface.h:100
> +virtual void 
> unregisterInlineNoteProvider(KTextEditor::InlineNoteProvider *provider) = 0;
> +};
> +

Please add a d-pointer as placeholder.

private:

  /**
   * private d-pointer
   */
  class InlineNoteInterfacePrivate *const d = nullptr;

> inlinenoteinterface.h:117
> +public:
> +enum ActivationType {
> +Inactive, ///< The note is inactive (the default)

- move to InlineNote
- turn into enum class

> inlinenoteinterface.h:173-176
> + * \param note note to paint, containing location and index
> + * \param height the height of the line in pixels
> + * \param font the QFont used in the editor
> + * \param painter painter prepared for rendering the note

- API documentation is wrong
- please use @param instead of \param everywhere, i.e. we prefer @xyz over \xyz

> inlinenoteinterface.h:195
> + */
> +virtual void noteActivated(const InlineNote& note, ActivationType type, 
> QPoint pos) {
> +Q_UNUSED(note);

noteActivated -> inlineNoteActivated()

> inlinenoteinterface.h:295
> +}
> +
> +/**

can you try making all variables private?

> inlinenoteinterface.h:325
> +int lineHeight;
> +};
> +

please add d-pointer:

  private:
  class InlineNotePrivate * const d = nullptr;

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14826

To: brauch, michalsrb, dhaumann, cullmann
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D11604: kdirlistertest doesn't fail at random

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kdirlistertest.cpp:530
> +const QMimeType htmlType = 
> db.mimeTypeForUrl(QUrl(QLatin1String("file:///index.html")));
> +qDebug() << "html mimeType=" << htmlType;
> +

Should be removed -- or QCOMPAREd.

> kdirlistertest.cpp:926
>  dirLister.openUrl(QUrl::fromLocalFile(path));
> -QVERIFY(spyCompleted.wait(1000));
> -QVERIFY(spyCompleted.wait(1000));

We no longer verify that completed is emitted twice...

> kdirlistertest.cpp:963
>  QSignalSpy spyCompleted(&secondDirLister, SIGNAL(completed()));
> -QVERIFY(spyCompleted.wait(1000));
> -QVERIFY(secondDirLister.isFinished());

why was this removed?

> kdirlistertest.cpp:1107
>  QSignalSpy spyCompleted(&m_dirLister, SIGNAL(completed()));
> -QVERIFY(spyCompleted.wait(1000));
> -QVERIFY(m_dirLister.isFinished());

same here and elsewhere

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11604

To: jtamate, #frameworks, dfaure
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

[Christoph Cullmann]

cullmann added a comment.


  I think we don't want to change that now.
  We perhaps will port all things to the KSyntaxHighlighting theming and then 
we will alter this behavior anyways.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5802

To: intelfx, #kdevelop, #ktexteditor, #kate, mwolff
Cc: cullmann, kde-frameworks-devel, brauch, dhaumann, mwolff, kwrite-devel, 
michaelh, kevinapavew, ngraham, bruns, demsking, sars

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

[Albert Astals Cid]

aacid added a comment.


  In D14779#309643 , @habacker wrote:
  
  > In D14779#308603 , @aacid wrote:
  >
  > > I think that in the test we just need to call
  > >
  > >   bool QCoreApplication::installTranslator(QTranslator *translationFile)
  > >
  > > with the location of the fake translation
  >
  >
  >
  >
  > > and since newest location is tried first it should overwrite the one from 
the ecm loader.
  >
  > According to 
http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/kernel/qcoreapplication.cpp#n1985
 new translators are prepended - not overwritten.
  
  
  So exactly what i said, the newly installed translator gets used first
  
  > Not sure if a missing translation in the latest file added would be search 
in the previous translators.
  
  Why would it be missing?
  
  > To  understand you correctly: You really are thinking about generating  a 
qm file  from the kcoreaddons lib source with gettext containing real 
translations  added with lokalize or similar to avoid this issue ?
  
  I am not sure what is "this issue", but what we need to do is just copy the 
english translation from the tarball to here and make sure it's used when the 
test is run.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14779

To: habacker, #frameworks
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D14828: remove highlighting download dialog

[Christoph Cullmann]

cullmann added a comment.


  Independent of mom/dad/somebody else, for highlighting files you create on 
your own, you just can perfectly add them to the local directories as specified 
in the manual.
  If you really want to have new highlighting files and risk that stuff like 
indenters or included stuff might break, you can still get them from the 
syntax-highlighting git and put them in that folders manually, too.
  The only thing that is no longer there is the "auto" download dialog.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14828

To: cullmann, dhaumann
Cc: rjvbb, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D14826: inline note interface wip #2

[Sven Brauch]

brauch updated this revision to Diff 39815.
brauch added a comment.


  address Dominik's suggestion and split focus handling and click handling

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14826?vs=39802&id=39815

BRANCH
  inlinenotes

REVISION DETAIL
  https://phabricator.kde.org/D14826

AFFECTED FILES
  CMakeLists.txt
  src/document/katedocument.h
  src/include/CMakeLists.txt
  src/include/ktexteditor/inlinenoteinterface.h
  src/render/katerenderer.cpp
  src/render/katerenderer.h
  src/utils/ktexteditor.cpp
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: brauch, michalsrb, dhaumann, cullmann
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

[Nathaniel Graham]

ngraham added a comment.


  Still works, and the same document is still available in the Open Recent... 
menu of multiple apps if you open it in multiple apps. Been using this for a 
month and a half.
  
  I'm hesitant to land it without more reviews, though.

REPOSITORY
  R241 KIO

BRANCH
  more-liberal-recent-document-duplicate-detection (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13804

To: ngraham, broulik, #dolphin, #frameworks, cfeck
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

[Nathaniel Graham]

ngraham updated this revision to Diff 39816.
ngraham added a comment.


  Rebase on master

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13804?vs=36920&id=39816

BRANCH
  more-liberal-recent-document-duplicate-detection (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13804

AFFECTED FILES
  src/core/krecentdocument.cpp

To: ngraham, broulik, #dolphin, #frameworks, cfeck
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D14237: Make Konqi look good in HiDPI

[Stefan Brüns]

bruns added a comment.


  Works fine in Inkscape, Gwenview, ShowFoto, Konqueror (KHTML mode)  ...

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D14237

To: ngraham, broulik, cfeck, #frameworks, #vdg
Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D14237: Make Konqi look good in HiDPI

[Stefan Brüns]

bruns added a comment.


  Minimal working application:
  
#include 
#include 

int main(int argc, char* argv[])
{
  QGuiApplication app(argc, argv);

  QIcon icon(QStringLiteral("./konqui.svg"));
  QPixmap pixmap = icon.pixmap(64, 64);

  pixmap.save("./konqui.png");
}

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D14237

To: ngraham, broulik, cfeck, #frameworks, #vdg
Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D14856: Search: Add workaround for missing icons in Gnome icon-theme

[Stefan Brüns]

bruns added a comment.


  In D14856#309714 , @dfaure wrote:
  
  > I don't think so, because QIcon::fromTheme just creates an icon engine. The 
actual lookup happens when the first call to isNull or paint (etc) is made. 
None of which are going to be done on the fallback icon if the main icon can be 
found.
  >
  > So this looks fine to me, unless a profiler or strace says otherwise.
  
  
  strace confirms you are correct

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14856

To: sars, #kate, dhaumann, broulik
Cc: dfaure, bruns, broulik, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, ngraham, demsking, cullmann, sars