KDE CI: Frameworks kdoctools kf5-qt5 SUSEQt5.10 - Build # 52 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/52/
 Project:
Frameworks kdoctools kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 28 Aug 2018 03:39:58 +
 Build duration:
4 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kdoctools_install
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(1/1)67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)

D15105: add JSON to general.entities

[Burkhard Lück]

This revision was automatically updated to reflect the committed changes.
Closed by commit R238:21232062fc8a: add JSON to general.entities (authored by 
lueck).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15105?vs=40517=40525

REVISION DETAIL
  https://phabricator.kde.org/D15105

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, #documentation, yurchor, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D15091: Compile python bindings with the same sipname used by PyQt

[Rex Dieter]

rdieter added a comment.


  I was asking mostly because that's what pyqt upstream strongly suggested (to 
use all sip_flags) when I asked them.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15091

To: arojas, #frameworks, bruns
Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15091: Compile python bindings with the same sipname used by PyQt

[Antonio Rojas]

arojas added a comment.


  In D15091#316150 , @rdieter wrote:
  
  > Why are you simply not using all  PYQT_CONFIGURATION["sip_flags"]?
  
  
  Not sure if we really want to do this. For instance, bindings would get 
tagged with the Qt version that PyQt was compiled with, not with the one KF5 is 
being compiled with (not sure if that would cause any actual issue)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15091

To: arojas, #frameworks, bruns
Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15076: Build failures with KSyntaxHighlighting 5.49

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  David, Elvis, what's the nicest way to fix this ? 
(https://phabricator.kde.org/D15076#315803 for the details)

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D15076

To: asemke, #kde_edu, #cantor, #frameworks
Cc: elvisangelaccio, dfaure, cgiboudeaux, mpyne, cullmann, kde-edu, narvaez, 
apol

D15076: Build failures with KSyntaxHighlighting 5.49

[Christophe Giboudeaux]

cgiboudeaux added subscribers: dfaure, elvisangelaccio.

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D15076

To: asemke, #kde_edu, #cantor, #frameworks
Cc: elvisangelaccio, dfaure, cgiboudeaux, mpyne, cullmann, kde-edu, narvaez, 
apol

D15105: add JSON to general.entities

[Luigi Toscano]

ltoscano accepted this revision as: ltoscano.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D15105

To: lueck, #documentation, yurchor, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D11945: Improve highlighting of SELinux CIL policies & file contexts

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Feel free to commit.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-selinux

REVISION DETAIL
  https://phabricator.kde.org/D11945

To: nibags, dhaumann, cullmann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D15105: add JSON to general.entities

[Yuri Chornoivan]

yurchor accepted this revision as: yurchor.
This revision is now accepted and ready to land.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D15105

To: lueck, #documentation, yurchor
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D15105: add JSON to general.entities

[Burkhard Lück]

lueck created this revision.
lueck added a reviewer: Documentation.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
lueck requested review of this revision.

REVISION SUMMARY
  see title

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D15105

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, #documentation
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D15071: Don't draw frames and shadows around images with transparency

[Nathaniel Graham]

ngraham added a comment.


  In D15071#316156 , @bruns wrote:
  
  > If we want to avoid **dangerous** confusion, we should not care for 
previews, but mark executables.
  
  
  This seems like an excellent idea to me. It would improve safety even without 
this patch.
  
  In addition, maybe we could also consider badging thumbnails with the icon of 
the app that will open them when clicked.
  
  (both material for different patches of course)

INLINE COMMENTS

> anthonyfieroni wrote in kfilepreviewgenerator.cpp:945
> Maybe you should add case when it has an alpha but it's nulll.

`hasAlpha()` already seems to check for that, in fact: it returns false for 
images that have an alpha channel but no transparency.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15071

To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck
Cc: anthonyfieroni, markg, abetts, bruns, kde-frameworks-devel, michaelh, 
ngraham

D15071: Don't draw frames and shadows around images with transparency

[Stefan Brüns]

bruns added a comment.


  In D15071#315839 , @broulik wrote:
  
  > I'm a bit concerned that removing the frame most of the time blurs the 
lines between "previews of images" and "actual file icons", especially for the 
SVG case.
  >
  > Now they all look like proper file icons rather than previews of the file's 
contents. I can see that an EXE "thumbnail" is a proper file icon but in many 
other cases it's misleading.
  
  
  I think the distinction should be between "Documents" and "Activatable 
items". Examples for the second category:
  
  - Folders (clicking enters the folder)
  - Executables (starts the program)
  - *.desktop files (starts the referenced program)
  
  Clicking on a document opens it in the associated applicaton (mime based).
  
  Now, confusion happens if you see e.g. the "Blender" icon - will a click open 
blender, or inkscape/gimp? Folder icon - dolphin or image editor?
  
  I think the confusion will be very rare - this only happens when the user 
browses e.g. /usr/share/icons/highcolor/*. In case a user takes an icon for the 
application, the worst thing that will happen is the wrong application is 
started.
  
  On the other hand, mistaking an application for a document may be bad. Think 
of an *.exe with an embedded icon which looks like a picture. This icon is 
passed to the UI unaltered. The current frame is hardly noticable form image 
previews, so confusion is easy - regardless if we add a frame or not. I think 
we have this somewhat covered by showing a warning if an executable is not in a 
trusted location.
  
  If we want to avoid **dangerous** confusion, we should not care for previews, 
but mark executables.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15071

To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck
Cc: anthonyfieroni, markg, abetts, bruns, kde-frameworks-devel, michaelh, 
ngraham

D15091: Compile python bindings with the same sipname used by PyQt

[Rex Dieter]

rdieter added a comment.


  Why are you simply not using all  PYQT_CONFIGURATION["sip_flags"]?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15091

To: arojas, #frameworks, bruns
Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15099: add a new property headerVisible

[Andres Betts]

abetts added a comment.


  Thanks for the work Marco!

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D15099

To: mart, #plasma, #frameworks
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

This revision was automatically updated to reflect the committed changes.
Closed by commit R121:d4ee26a76a21: Align lock icon with bold message text; 
reduce overall size of dialog (authored by sharvey).

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12311?vs=32758=40505

REVISION DETAIL
  https://phabricator.kde.org/D12311

AFFECTED FILES
  AuthDialog.cpp
  AuthDialog.ui

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D15099: add a new property headerVisible

[Marco Martin]

mart updated this revision to Diff 40504.
mart added a comment.


  - emit changed

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15099?vs=40501=40504

BRANCH
  phab/headerVisible

REVISION DETAIL
  https://phabricator.kde.org/D15099

AFFECTED FILES
  src/kpagemodel.h
  src/kpageview.cpp
  src/kpagewidgetmodel.cpp
  src/kpagewidgetmodel.h

To: mart, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15099: add a new property headerVisible

[Marco Martin]

mart added a comment.


  KCM showing its own title
  F6218375: Spectacle.y22236.png 
  Ttile shown by KPageWidget
  F6218377: Spectacle.S22236.png 

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D15099

To: mart, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15099: add a new property headerVisible

[Marco Martin]

mart added a reviewer: Frameworks.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D15099

To: mart, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15099: add a new property headerVisible

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  add a new property in KPageWidgetItem, headerVisible
  this way the page can control whether or not make its own header
  visible.
  This is necessary for the new systemsettings in which the new
  QML kcms display their own title, but the old QWidget based ones
  don't and have the KPageWidget display it for them.

TEST PLAN
  tested in systemsettings

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  phab/headerVisible

REVISION DETAIL
  https://phabricator.kde.org/D15099

AFFECTED FILES
  src/kpagemodel.h
  src/kpageview.cpp
  src/kpagewidgetmodel.cpp
  src/kpagewidgetmodel.h

To: mart, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

[Marco Martin]

mart updated this revision to Diff 40500.
mart added a comment.


  - use the new ConfigMoule push/pop api

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14580?vs=40370=40500

BRANCH
  mart/multipageKCM

REVISION DETAIL
  https://phabricator.kde.org/D14580

AFFECTED FILES
  src/CMakeLists.txt
  src/kcmoduleqml.cpp
  src/kcmoduleqml_p.h

To: mart, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15098: make push/pop part of ConfigModule API

[Marco Martin]

mart added a reviewer: Plasma.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D15098

To: mart, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15098: make push/pop part of ConfigModule API

[Marco Martin]

mart created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  for better separation, abstract push/pop and columnWidth in the ConfigModule 
class so
  the qml part won't have access to ApplicationItem (which will be eventually
  sandboxed anyways)

TEST PLAN
  tested a basic mock kcm with multiple columns

REPOSITORY
  R296 KDeclarative

BRANCH
  phab/multipageKCM

REVISION DETAIL
  https://phabricator.kde.org/D15098

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14747: [Exe Thumbnailer] Don't generate QTemporaryFile

[Kai Uwe Broulik]

broulik added a reviewer: vonreth.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14747

To: broulik, #frameworks, #windows, vonreth

D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave

[Kai Uwe Broulik]

broulik added a dependent revision: D15097: [Thumbnailer] Use enabled plugins 
passed in as metadata.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15096

To: broulik, dfaure, fvogt, kossebau
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: dfaure, fvogt, kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This way the thumbnailer can use the same enabled plugin configuration as the 
calling application
  
  CCBUG: 388303

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15096

AFFECTED FILES
  src/widgets/previewjob.cpp

To: broulik, dfaure, fvogt, kossebau
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15089: Add syntax highlighting for SELinux kernel policy language

[Nibaldo González]

nibags updated this revision to Diff 40492.
nibags added a comment.


  - Remove depreciated permissions (7 keywords)

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15089?vs=40472=40492

BRANCH
  add-selinux

REVISION DETAIL
  https://phabricator.kde.org/D15089

AFFECTED FILES
  autotests/folding/test.te.fold
  autotests/html/test.te.html
  autotests/input/test.te
  autotests/reference/test.te.ref
  data/syntax/selinux.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann