D15258: Remove random kio output

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15258

To: apol, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15240: Create a default wallet when user refuses to do so

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This strikes me as likely to cause intense frustration. Consider the 
following dramatized dialogue between a user and the computer:
  
  User: "Neat, I just set up this KDE plasma thing. Let's start seeing what 
cool stuff it can do!"
  Computer: "Hey hey hey first what kind of KWallet do you want to create? 
Technical jargon thingy 1, or technical jargon thingy 2? Huh? Huh? What'll it 
be O noble user!?"
  User: "Okay, I have no idea, let me cancel out of this stupid thing..."
  Computer: "Don't worry I created a thing anyway and chose technical jargon 
thingy 1 for you!"
  
  Speaking personally, this sort of experience would make me want to put my 
fist through the screen.
  
  It might be worth stepping back and asking more higher-level questions like:
  "Why are users cancelling the wizard? Is it too technically intimidating?"
  "Should we even have a wizard at all? Maybe should we create a wallet 
automatically by default and let advanced users change its settings or delete 
it if they don't like it?"

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D15240

To: McPain, #frameworks, ngraham
Cc: ngraham, abetts, kde-frameworks-devel, michaelh, bruns

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15189

To: achauvel, #frameworks, dfaure, cfeck
Cc: anthonyfieroni, ngraham, kde-frameworks-devel, michaelh, bruns

D15258: Remove random kio output

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  It's not even categorised and it seems more like someone was actually 
debugging something and added this.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15258

AFFECTED FILES
  src/kioslave/kioslave.cpp

To: apol, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15213: Provide icons for 2x scaling

[Chris Rizzitello]

rizzitello retitled this revision from "Link 16px icon folders to 16@2" to 
"Provide icons for 2x scaling".
rizzitello edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15213

To: rizzitello, #vdg, #plasma
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15252: [KPropertiesDialog] Use QIcon::fromTheme rather than KIconLoader::loadIcon

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15252

To: broulik, #frameworks, #vdg, davidedmundson, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15213: Link 16px icon folders to 16@2

[Kai Uwe Broulik]

broulik added a comment.


  Thanks a lot!
  
  There's a quirk in Dolphin where it wouldn't pick up the 22px places icons as 
in `KStandardItemListWidget::pixmapForIcon` it scales the size (22→44) first 
and then clamps it to an icon size (48) and so it won't find the fixed 22. 
Also, the problem of highlighted files turning white. I'd like to investigate 
those two issues before we merge this. Your patch looks good, however! :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15213

To: rizzitello, #vdg, #plasma
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15213: Link 16px icon folders to 16@2

[Chris Rizzitello]

rizzitello updated this revision to Diff 40942.
rizzitello added a comment.


  - Link 24 to 24@2x
  - Link actions/32 to actions/32@2x

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15213?vs=40941=40942

BRANCH
  2xIcons

REVISION DETAIL
  https://phabricator.kde.org/D15213

AFFECTED FILES
  icons-dark/actions/16@2x
  icons-dark/actions/22@2x
  icons-dark/actions/24@2x
  icons-dark/actions/32@2x
  icons-dark/animations/16@2x
  icons-dark/apps/16@2x
  icons-dark/apps/22@2x
  icons-dark/devices/16@2x
  icons-dark/devices/22@2x
  icons-dark/emblems/16@2x
  icons-dark/emblems/22@2x
  icons-dark/emotes/22@2x
  icons-dark/index.theme
  icons-dark/mimetypes/16@2x
  icons-dark/mimetypes/22@2x
  icons-dark/places/16@2x
  icons-dark/places/22@2x
  icons-dark/status/16@2x
  icons-dark/status/22@2x
  icons/actions/16@2x
  icons/actions/22@2x
  icons/actions/24@2x
  icons/actions/32@2x
  icons/animations/16@2x
  icons/apps/16@2x
  icons/apps/22@2x
  icons/devices/16@2x
  icons/devices/22@2x
  icons/emblems/16@2x
  icons/emblems/22@2x
  icons/emotes/22@2x
  icons/index.theme
  icons/mimetypes/16@2x
  icons/mimetypes/22@2x
  icons/places/16@2x
  icons/places/22@2x
  icons/status/16@2x
  icons/status/22@2x

To: rizzitello, #vdg, #plasma
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15213: Link 16px icon folders to 16@2

[Chris Rizzitello]

rizzitello updated this revision to Diff 40941.
rizzitello added a comment.


  - Add 22@2x links

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15213?vs=40934=40941

BRANCH
  2xIcons

REVISION DETAIL
  https://phabricator.kde.org/D15213

AFFECTED FILES
  icons-dark/actions/16@2x
  icons-dark/actions/22@2x
  icons-dark/animations/16@2x
  icons-dark/apps/16@2x
  icons-dark/apps/22@2x
  icons-dark/devices/16@2x
  icons-dark/devices/22@2x
  icons-dark/emblems/16@2x
  icons-dark/emblems/22@2x
  icons-dark/emotes/22@2x
  icons-dark/index.theme
  icons-dark/mimetypes/16@2x
  icons-dark/mimetypes/22@2x
  icons-dark/places/16@2x
  icons-dark/places/22@2x
  icons-dark/status/16@2x
  icons-dark/status/22@2x
  icons/actions/16@2x
  icons/actions/22@2x
  icons/animations/16@2x
  icons/apps/16@2x
  icons/apps/22@2x
  icons/devices/16@2x
  icons/devices/22@2x
  icons/emblems/16@2x
  icons/emblems/22@2x
  icons/emotes/22@2x
  icons/index.theme
  icons/mimetypes/16@2x
  icons/mimetypes/22@2x
  icons/places/16@2x
  icons/places/22@2x
  icons/status/16@2x
  icons/status/22@2x

To: rizzitello, #vdg, #plasma
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15252: [KPropertiesDialog] Use QIcon::fromTheme rather than KIconLoader::loadIcon

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, VDG, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The former knows high dpi scaling

TEST PLAN
  Before
  F6233455: Screenshot_20180903_224040.png 

  After
  F6233456: Screenshot_20180903_224103.png 


REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15252

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: broulik, #frameworks, #vdg, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15213: Link 16px icon folders to 16@2

[Chris Rizzitello]

rizzitello updated this revision to Diff 40934.
rizzitello added a comment.


  - 16@2x icons
  - icon.theme updated

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15213?vs=40840=40934

BRANCH
  16@2x

REVISION DETAIL
  https://phabricator.kde.org/D15213

AFFECTED FILES
  icons-dark/actions/16@2x
  icons-dark/animations/16@2x
  icons-dark/apps/16@2x
  icons-dark/devices/16@2x
  icons-dark/emblems/16@2x
  icons-dark/index.theme
  icons-dark/mimetypes/16@2x
  icons-dark/places/16@2x
  icons-dark/status/16@2x
  icons/actions/16@2x
  icons/animations/16@2x
  icons/apps/16@2x
  icons/devices/16@2x
  icons/emblems/16@2x
  icons/index.theme
  icons/mimetypes/16@2x
  icons/places/16@2x
  icons/status/16@2x

To: rizzitello, #vdg, #plasma
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

[Heiko Becker]

heikobecker created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
heikobecker requested review of this revision.

REVISION SUMMARY
  After 507415c54bd111fbb35716bd9809119d990f9a16 
 
KF5I18nQchTargets.cmake
  needs similar adjustments.

TEST PLAN
  The test passes again, KF5I18nQchTargets is still installed

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15251

AFFECTED FILES
  CMakeLists.txt

To: heikobecker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 207 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/207/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 03 Sep 2018 16:45:52 +
 Build duration:
2 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13112)19%
(1821/9436)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2217)7%
(96/1434)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(663/1542)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1976)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
  

D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:8497832a8bf0: [DialogShadows] Use 0 offset for disabled 
borders on Wayland (authored by zzag).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14946?vs=40150=40929

REVISION DETAIL
  https://phabricator.kde.org/D14946

AFFECTED FILES
  src/plasmaquick/dialogshadows.cpp

To: zzag, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15242: RFC: [KFileItem] Handle permissions ourselves in isReadable()/isWritable()

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: dfaure, elvisangelaccio, fvogt, lbeltrame.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Avoids creating a `QFileInfo` which might block `stat`'ing the file, 
especially if the information has been filled in by a KIO slave already.

TEST PLAN
  - Unittest still passes
  - Had an own file that I removed the own permission → became unreadable
  - Had a file from someone else but in the same group as me → was readable

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15242

AFFECTED FILES
  src/core/kfileitem.cpp

To: broulik, dfaure, elvisangelaccio, fvogt, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15180: kioexecd: watch for creations or modifications of the temporary files

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kioexecd.cpp:80
> +{
> +if (!m_deleted.contains(path)) {
> +return;

Contains should be also in the guard.

> kioexecd.h:40
>  virtual ~KIOExecd();
> +void clearDir(const QString );
>  

Unused?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15180

To: jtamate, #frameworks, broulik, ngraham, dfaure, elvisangelaccio
Cc: anthonyfieroni, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, 
bruns

D15180: kioexecd: watch for creations or modifications of the temporary files

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kioexecd.cpp:134
> +QDir(parentDir).removeRecursively();
> +it=m_deleted.erase(it);
> +}

Also for loop should looks like:

  for (it = begin(); it != end();) {
  if () {
  it = erase(it);
  } else {
  ++it;
  }
  }

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15180

To: jtamate, #frameworks, broulik, ngraham, dfaure, elvisangelaccio
Cc: anthonyfieroni, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, 
bruns

D15240: Create a default wallet when user refuses to do so

[Oleg Solovyov]

McPain added a reviewer: Frameworks.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D15240

To: McPain, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15240: Create a default wallet when user refuses to do so

[Oleg Solovyov]

McPain created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
McPain requested review of this revision.

REVISION SUMMARY
  This patch allows creating a default wallet with empty password when user 
explicitly refuses to create one (tons of KWallet dialogs looks annoying)
  
  Also, KWallet will notify user once the wallet was created.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D15240

AFFECTED FILES
  src/runtime/kwalletd/kwalletd.cpp

To: McPain
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15180: kioexecd: watch for creations or modifications of the temporary files

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kioexecd.cpp:122
> +m_deleted_mutex.unlock();
> +QTimer::singleShot(31000, [this]() { // 31s
> +m_deleted_mutex.lock();

Better to me, make a class variable single shot timer, then when you add in 
deleted start it if not, when it expires delete what you do, at last check if 
deleted is not empty just restart it. Make 30s predefined.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15180

To: jtamate, #frameworks, broulik, ngraham, dfaure, elvisangelaccio
Cc: anthonyfieroni, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, 
bruns

D15180: kioexecd: watch for creations or modifications of the temporary files

[Jaime Torres Amate]

jtamate updated this revision to Diff 40908.
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.
jtamate added a comment.


  As I'm never sure if a timed execution can happen in the middle of other 
execution, I've added a mutex for m_deleted.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15180?vs=40888=40908

REVISION DETAIL
  https://phabricator.kde.org/D15180

AFFECTED FILES
  src/kioexec/kioexecd.cpp
  src/kioexec/kioexecd.h
  src/kioexec/main.cpp

To: jtamate, #frameworks, broulik, ngraham, dfaure, elvisangelaccio
Cc: anthonyfieroni, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, 
bruns

D14162: Figure out the escaped path list on kconfig

[Aleix Pol Gonzalez]

apol added a comment.


  ping?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D14162

To: apol, #frameworks, dfaure
Cc: dfaure, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.11 - Build # 7 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.11/7/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 03 Sep 2018 07:26:37 +
 Build duration:
3 hr 14 min and counting
   JUnit Tests
  Name: (root) Failed: 27 test(s), Passed: 28 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: TestSuite.kiocore-deletejobtestFailed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kcoredirlister_benchmarkFailed: TestSuite.kiocore-kfileitemtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-mkpathjobtestFailed: TestSuite.kiofilewidgets-kdiroperatortestFailed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiofilewidgets-kfilecustomdialogtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiofilewidgets-knewfilemenutestFailed: TestSuite.kiofilewidgets-kurlnavigatortestFailed: TestSuite.kiowidgets-accessmanagertestFailed: TestSuite.kiowidgets-accessmanagertest-qnamFailed: TestSuite.kiowidgets-dropjobtestFailed: TestSuite.kiowidgets-fileundomanagertestFailed: TestSuite.kiowidgets-jobguitestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.kiowidgets-krununittestFailed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertestFailed: TestSuite.kiowidgets-kurlcompletiontestFailed: TestSuite.kiowidgets-kurlcompletiontest-nowaitFailed: TestSuite.kpasswdservertest

D15076: Build failures with KSyntaxHighlighting 5.49

[Ben Cooksley]

bcooksley added a comment.


  @dfaure That change was an urgent measure on my part, in order to allow 
KDevelop tests on the CI system to find something, and be able to complete 
successfully. At the moment they all hang due to being unable to find any 
plugins (they have an error popup...). The lack of available plugins was a 
result of the ECM code completely breaking QT_PLUGIN_PATH - this is why some 
Framework tests fail as well, being unable to find any KIO plugins (disabling 
this same logic in ECM was what gave me the output I emailed to you about a 
week ago). We'll find out if my urgent measure was successful next time the 
Dependency Builds run through.

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D15076

To: asemke, #kde_edu, #cantor, #frameworks
Cc: bcooksley, elvisangelaccio, dfaure, cgiboudeaux, mpyne, cullmann, kde-edu, 
narvaez, apol

D15180: kioexecd: watch for creations or modifications of the temporary files

[Jaime Torres Amate]

jtamate added a comment.


  In D15180#319314 , @anthonyfieroni 
wrote:
  
  > I'm unhappy with that stop watching is on exit == 0, so when it's not, 
somehow, containers will continue to grow, it'll result in higher memory usage 
and slower performance. So stop watching should not depend on process return 
code, also same command should not stop container to shrink, that's my opinion, 
but i can miss something.
  
  
  I desist from this path, it has a big flaw: What if the tabbed application is 
already running? All the temporary files will be deleted immediately. :-(
  I'll try this other path: allowing the application a generous amount of time 
(30s) to recreate the deleted file, otherwise deleting the temporary directory. 
Unfortunately, the temporary directories will not shrink unless the app deletes 
the temporary file.
  I guess the only complete solution is to implement use fuse (where available) 
.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15180

To: jtamate, #frameworks, broulik, ngraham, dfaure, elvisangelaccio
Cc: anthonyfieroni, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, 
bruns

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

[Mélanie Chauvel]

achauvel updated this revision to Diff 40897.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15189?vs=40784=40897

REVISION DETAIL
  https://phabricator.kde.org/D15189

AFFECTED FILES
  src/widgets/krun.cpp

To: achauvel, #frameworks, dfaure, cfeck
Cc: anthonyfieroni, ngraham, kde-frameworks-devel, michaelh, bruns

D15213: Link 16px icon folders to 16@2

[Kai Uwe Broulik]

broulik added a comment.


  About the `index.theme`, what you want to do is, for every folder duplicate 
the non-2x entry and add a `Scale=2` to it, e.g.
  
[places/16]
Size=16
Context=Places
Type=Fixed
  
  add after it
  
[places/16@2x]
Size=16
Scale=2
Context=Places
Type=Fixed
  
  and also add all the new directories to a `ScaledDirectories` key, below 
`Directories` (it is a separate key so that applications not supporting this 
don't get confused by the new scaled directories)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15213

To: rizzitello, #vdg, #plasma
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15180: kioexecd: watch for creations or modifications of the temporary files

[Anthony Fieroni]

anthonyfieroni added a comment.


  I'm unhappy with that stop watching is on exit == 0, so when it's not, 
somehow, containers will continue to grow, it'll result in higher memory usage 
and slower performance. So stop watching should not depend on process return 
code, also same command should not stop container to shrink, that's my opinion, 
but i can miss something.

INLINE COMMENTS

> kioexecd.cpp:138
> +m_openedBy.remove(command);
> + }
>  }

Indentation

> main.cpp:261
>  qDebug() << "about to delete" << parentDir << "containing" << 
> info.fileName();
> -QFile(QFile::encodeName(src)).remove();
> -QDir().rmdir(parentDir);
> + QDir(parentDir).removeRecursively();
>  }

Indentation

> main.cpp:263
>  }
> +if (mUseDaemon &&  exit_code == 0) {
> +OrgKdeKIOExecdInterface 
> kioexecd(QStringLiteral("org.kde.kioexecd"), 
> QStringLiteral("/modules/kioexecd"), QDBusConnection::sessionBus());

Extra space after &&

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15180

To: jtamate, #frameworks, broulik, ngraham, dfaure, elvisangelaccio
Cc: anthonyfieroni, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, 
bruns

D15180: kioexecd: watch for creations or modifications of the temporary files

[Jaime Torres Amate]

jtamate updated this revision to Diff 40888.
jtamate added a reviewer: elvisangelaccio.
jtamate added a comment.


  Updated with the code that handles m_openedBy right.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15180?vs=40779=40888

REVISION DETAIL
  https://phabricator.kde.org/D15180

AFFECTED FILES
  src/kioexec/kioexecd.cpp
  src/kioexec/kioexecd.h
  src/kioexec/main.cpp

To: jtamate, #frameworks, broulik, ngraham, dfaure, elvisangelaccio
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns