D14006: Fix WebDAV destination header on COPY and MOVE operations

[Daniel Nicoletti]

dantti added a comment.


  Test plan:
  
  1. Connecto to a WebDav server
  2. Create a file named "foo"
  3. Try to rename the file to "speçiál" - it should result in "spe"
  
  The COPY operation has the same issue but I'm not sure how to test it right 
now,
  probably it will also fail if the destination directory is named with special 
characters (non-latin1).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14006

To: dantti, dfaure, #frameworks, #dolphin
Cc: bruns, anthonyfieroni, ngraham, kde-frameworks-devel, michaelh

D15340: Add Solarized Light and Dark themes

[Andrew Crouthamel]

acrouthamel added a comment.


  In D15340#322453 , @dhaumann wrote:
  
  > Btw, we forgot to add the themes to the Qt resource file, see also D15358 

  >
  > You can test the theme with the demo app in ksyntaxhighlighting: Go to the 
build-directory, then type ./bin/codeeditor 
  >  Then, you can switch the theme with the context menu.
  
  
  Could you give me a quick tutorial on how to build that? I tried cmake && 
make, but that's about as far as I got.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15340

To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars

D15364: Plasma style: Remove hardcoded textFormat

[Nathaniel Graham]

ngraham added a reviewer: Plasma.
ngraham added a comment.


  Is there a reason for this change, or a bug report that it fixes? How have 
you tested this? Do any visual changes result from this patch? If so, are they 
all desirable? Etc. Some more information would be nice.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15364

To: jbbgameich, #plasma
Cc: ngraham, kde-frameworks-devel, lnj, michaelh, bruns

D15364: Plasma style: Remove hardcoded textFormat

[Jonah Brüchert]

jbbgameich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  This fixes all texts being displayed as Text.PlainText if not explicitly 
overriden.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15364

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Label.qml

To: jbbgameich
Cc: kde-frameworks-devel, lnj, michaelh, ngraham, bruns

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

[Ben Cooksley]

bcooksley added a comment.


  Yeah, unfortunately getting consensus that we shouldn't be distributing them 
is difficult - I suspect the issue is that for the most part people are used to 
building all of our software on their system and therefore don't have the 
necessary tooling or options supplied to CMake to ensure that the API 
Documentation is built locally as part of their builds - and therefore expect 
to be able to get it from api.kde.org.
  
  Given that the jump from web accessible docs to QCH downloadable files isn't 
much it doesn't bother me too much though as long as the process for doing so 
is well maintained.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D15251

To: heikobecker, kossebau, habacker
Cc: bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 110 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/110/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 08 Sep 2018 21:50:35 +
 Build duration:
2 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6335/8432)43%
(10169/23453)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2702/2776)49%
(5810/11901)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2317)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(731/908)52%
(827/1583)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D15358: Unit test: Check all shipped themes for completeness

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  +1 ;=)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  check-themes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15358

To: dhaumann, vkrause, cullmann, acrouthamel
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "[WIP] Introduce 
AbstractAnnotationItemDelegate for more control by consumer" to "Introduce 
AbstractAnnotationItemDelegate for more control by consumer".
kossebau edited the summary of this revision.
kossebau added reviewers: Kate, KDevelop.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8708

To: kossebau, #kate, #kdevelop
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 41225.
kossebau added a comment.


  Reaching review candidate state, please start reviewing the code.
  
  Target is Frameworks 5.52, so the one after the upcoming Frameworks version.
  The current planned consumer of the new API is KDevelop 5.4, which may be
  branched end of year or next year, so nothing urgent to push and giving this
  another month of API reconsiderations is fine.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8708?vs=41112=41225

BRANCH
  addAnnotationItemDelegate

REVISION DETAIL
  https://phabricator.kde.org/D8708

AFFECTED FILES
  src/CMakeLists.txt
  src/include/CMakeLists.txt
  src/include/ktexteditor/abstractannotationitemdelegate.h
  src/include/ktexteditor/annotationinterface.h
  src/view/kateannotationitemdelegate.cpp
  src/view/kateannotationitemdelegate.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h
  src/view/kateviewinternal.h

To: kossebau
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15340: Add Solarized Light and Dark themes

[Andrew Crouthamel]

acrouthamel added a comment.


  Thanks, I'll make sure to add to that file if I add more themes.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15340

To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars

D15340: Add Solarized Light and Dark themes

[Dominik Haumann]

dhaumann added a comment.


  Btw, we forgot to add the themes to the Qt resource file, see also D15358 

  
  You can test the theme with the demo app in ksyntaxhighlighting: Go to the 
build-directory, then type ./bin/codeeditor 
  Then, you can switch the theme with the context menu.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15340

To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars

D14006: Fix WebDAV destination header on COPY and MOVE operations

[Stefan Brüns]

bruns added a comment.


  In D14006#322270 , @dantti wrote:
  
  > Ping? This is a pretty obvious fix, desturl is QString which later becomes 
latin1 loosing characters...
  
  
  Can you add a test plan? Makes it much more obvious how to replicate the 
problem.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14006

To: dantti, dfaure, #frameworks, #dolphin
Cc: bruns, anthonyfieroni, ngraham, kde-frameworks-devel, michaelh

D15358: Unit test: Check all shipped themes for completeness

[Dominik Haumann]

dhaumann updated this revision to Diff 41221.
dhaumann added a comment.


  - Merge branch 'master' into check-themes
  - Include Solarized color themes

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15358?vs=41219=41221

BRANCH
  check-themes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15358

AFFECTED FILES
  autotests/theme_test.cpp
  data/themes/theme-data.qrc

To: dhaumann, vkrause, cullmann, acrouthamel
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15340: Add Solarized Light and Dark themes

[Dominik Haumann]

dhaumann added a comment.


  See D15358  :-)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15340

To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars

D15358: Unit test: Check all shipped themes for completeness

[Dominik Haumann]

dhaumann added a comment.


  Example output:
  
dh@eriador:syntax-highlighting :-)  $ ./bin/theme_test 
* Start testing of KSyntaxHighlighting::ThemeTest *
Config: Using QtTest library 5.11.1, Qt 5.11.1 (x86_64-little_endian-lp64 
shared (dynamic) release build; by GCC 8.1.1 20180614 [gcc-8-branch revision 
261584])
[...]
PASS   : 
KSyntaxHighlighting::ThemeTest::testThemeIntegrity(:/org.kde.syntax-highlighting/themes/default.theme)
PASS   : 
KSyntaxHighlighting::ThemeTest::testThemeIntegrity(:/org.kde.syntax-highlighting/themes/printing.theme)
PASS   : 
KSyntaxHighlighting::ThemeTest::testThemeIntegrity(:/org.kde.syntax-highlighting/themes/breeze-dark.theme)
[...]
Totals: 11 passed, 0 failed, 0 skipped, 0 blacklisted, 8ms
* Finished testing of KSyntaxHighlighting::ThemeTest *

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15358

To: dhaumann, vkrause, cullmann, acrouthamel
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15358: Unit test: Check all shipped themes for completeness

[Dominik Haumann]

dhaumann created this revision.
dhaumann added reviewers: vkrause, cullmann, acrouthamel.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  The added unit test makes sure
  
  - the *.theme files in the Qt resource are valid JSON
  - contain all text styles
  - all text styles are defined with correct entires
  - all text styles at least have a text-color set
  - all text style expected bool values are valid bool values
  - all text style expected colors are valid colors
  - contain all editor colors
  - all editor colors are valid colors

TEST PLAN
  make && make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  check-themes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15358

AFFECTED FILES
  autotests/theme_test.cpp

To: dhaumann, vkrause, cullmann, acrouthamel
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15340: Add Solarized Light and Dark themes

[Andrew Crouthamel]

acrouthamel added a comment.


  In D15340#322112 , @dhaumann wrote:
  
  > Looks good to me.
  >
  > Related: in order to have better unit testing, would you be willing to add 
a unit test to 
https://github.com/KDE/syntax-highlighting/blob/master/autotests/theme_test.cpp 
called
  >
  >   void testJsonData() { ... }
  >   
  >
  > This test would iterate over all themes via Qt Resources and check wether 
all 31 default text styles exist, and also check for the existence of the 
editor colors. This would help us to catch theme issues early in the future.
  >
  > Feel free to commit this patch now.
  
  
  Thanks! I would be glad to add that, but I honestly have no idea how to do 
so. I'm just starting out.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15340

To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars

D15340: Add Solarized Light and Dark themes

[Andrew Crouthamel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:6d26c25fcfda: Add Solarized Light and Dark themes 
(authored by acrouthamel).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15340?vs=41179=41216

REVISION DETAIL
  https://phabricator.kde.org/D15340

AFFECTED FILES
  data/themes/solarized-dark.theme
  data/themes/solarized-light.theme

To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

[Vlad Zagorodniy]

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  The EWMH spec doesn't have the _NET_WM_WINDOW_TYPE_COMBOBOX atom. Instead,
  it has _NET_WM_WINDOW_TYPE_COMBO.
  
  In addition to that, Qt sets _NET_WM_WINDOW_TYPE_COMBO on combo box popups.
  
  https://standards.freedesktop.org/wm-spec/wm-spec-latest.html

REPOSITORY
  R278 KWindowSystem

BRANCH
  use-combo-instead-of-combobox

REVISION DETAIL
  https://phabricator.kde.org/D15353

AFFECTED FILES
  autotests/netwininfotestclient.cpp
  src/platforms/xcb/atoms_p.h
  src/platforms/xcb/netwm.cpp

To: zzag, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14006: Fix WebDAV destination header on COPY and MOVE operations

[Anthony Fieroni]

anthonyfieroni added a comment.


  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14006

To: dantti, dfaure, #frameworks, #dolphin
Cc: anthonyfieroni, ngraham, kde-frameworks-devel, michaelh, bruns

D15350: Unit tests for the R indent script

[Christoph Cullmann]

cullmann added a comment.


  I needed to adjust R => r as mode, as the basename of the file is used for 
that, which is r.
  Seems to work locally that way, otherwise I got:
  
  org.kde.ktexteditor: mode "R" does not exist

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15350

To: devillemereuil, #ktexteditor, #rkward, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, sars, dhaumann

D15350: Unit tests for the R indent script

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:4c17dde71e20: Unit tests for the R indent script (authored 
by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15350?vs=41203=41208#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15350?vs=41203=41208

REVISION DETAIL
  https://phabricator.kde.org/D15350

AFFECTED FILES
  autotests/input/indent/R/.kateconfig
  autotests/input/indent/R/bracketsBreak/expected
  autotests/input/indent/R/bracketsBreak/input.js
  autotests/input/indent/R/bracketsBreak/origin
  autotests/input/indent/R/closeBracket/expected
  autotests/input/indent/R/closeBracket/input.js
  autotests/input/indent/R/closeBracket/origin
  autotests/input/indent/R/indentAssign/expected
  autotests/input/indent/R/indentAssign/input.js
  autotests/input/indent/R/indentAssign/origin
  autotests/input/indent/R/indentBracket/expected
  autotests/input/indent/R/indentBracket/input.js
  autotests/input/indent/R/indentBracket/origin
  autotests/input/indent/R/indentFormula/expected
  autotests/input/indent/R/indentFormula/input.js
  autotests/input/indent/R/indentFormula/origin
  autotests/input/indent/R/indentOperator/expected
  autotests/input/indent/R/indentOperator/input.js
  autotests/input/indent/R/indentOperator/origin
  autotests/input/indent/R/skipComment/expected
  autotests/input/indent/R/skipComment/input.js
  autotests/input/indent/R/skipComment/origin

To: devillemereuil, #ktexteditor, #rkward, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, sars, dhaumann

D15350: Unit tests for the R indent script

[Christoph Cullmann]

cullmann added a comment.


  Ok ;=)
  Have pushed the indenter change, need to rebuild my local stuff here with 
kdesrc-build and will apply + test this change then, too again.
  Hope to see more contributions, guess R users will like improved indenting ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15350

To: devillemereuil, #ktexteditor, #rkward, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, sars, dhaumann

D15350: Unit tests for the R indent script

[Pierre de Villemereuil]

devillemereuil added a comment.


  Yes, let's do that for now. I'll get an account if this becomes a habit. 
Thanks for your help!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15350

To: devillemereuil, #ktexteditor, #rkward, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, sars, dhaumann

D15349: Update of the R indent script

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:57a531ed368c: Update of the R indent script (authored by 
cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15349?vs=41201=41204

REVISION DETAIL
  https://phabricator.kde.org/D15349

AFFECTED FILES
  src/script/data/indentation/r.js

To: devillemereuil, #ktexteditor, #rkward, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15350: Unit tests for the R indent script

[Christoph Cullmann]

cullmann added a comment.


  :=)
  
  To push, you need some developer account, then you can just push to 
git.kde.org.
  It is no problem for me to just do that for you, like last time.
  
  I think for this time, it is the easiest and fastest thing that I just land 
your patches.
  
  If you want to push yourself in the future, you can apply for an account like 
described here:
  https://community.kde.org/Infrastructure/Get_a_Developer_Account
  
  > Thanks for the work.
  ==

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15350

To: devillemereuil, #ktexteditor, #rkward, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, sars, dhaumann

D15350: Unit tests for the R indent script

[Pierre de Villemereuil]

devillemereuil added a comment.


  I thought this phabricator review served as a push request? How can I push 
the revision myself? Can I push directly on annongit.kde.org? (Sorry for being 
yet again a newb!)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15350

To: devillemereuil, #ktexteditor, #rkward, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, sars, dhaumann

D15349: Update of the R indent script

[Christoph Cullmann]

cullmann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15349

To: devillemereuil, #ktexteditor, #rkward, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15350: Unit tests for the R indent script

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Hi, thanks for that!
  Can you push yourself or shall I push your indenter + tests?
  Thanks for taking the time to create some tests!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15350

To: devillemereuil, #ktexteditor, #rkward, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, sars, dhaumann

D15350: Unit tests for the R indent script

[Pierre de Villemereuil]

devillemereuil created this revision.
devillemereuil added reviewers: KTextEditor, RKWard.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
devillemereuil requested review of this revision.

REVISION SUMMARY
  A series of unit tests as was request in this previous review of the R indent 
script .

TEST PLAN
  The tests were... well, tested using kateindenttest built from sources 
(master) and were running OK.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15350

AFFECTED FILES
  autotests/input/indent/R/.kateconfig
  autotests/input/indent/R/bracketsBreak/expected
  autotests/input/indent/R/bracketsBreak/input.js
  autotests/input/indent/R/bracketsBreak/origin
  autotests/input/indent/R/closeBracket/expected
  autotests/input/indent/R/closeBracket/input.js
  autotests/input/indent/R/closeBracket/origin
  autotests/input/indent/R/indentAssign/expected
  autotests/input/indent/R/indentAssign/input.js
  autotests/input/indent/R/indentAssign/origin
  autotests/input/indent/R/indentBracket/expected
  autotests/input/indent/R/indentBracket/input.js
  autotests/input/indent/R/indentBracket/origin
  autotests/input/indent/R/indentFormula/expected
  autotests/input/indent/R/indentFormula/input.js
  autotests/input/indent/R/indentFormula/origin
  autotests/input/indent/R/indentOperator/expected
  autotests/input/indent/R/indentOperator/input.js
  autotests/input/indent/R/indentOperator/origin
  autotests/input/indent/R/skipComment/expected
  autotests/input/indent/R/skipComment/input.js
  autotests/input/indent/R/skipComment/origin

To: devillemereuil, #ktexteditor, #rkward
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14006: Fix WebDAV destination header on COPY and MOVE operations

[Daniel Nicoletti]

dantti added a comment.


  Ping? This is a pretty obvious fix, desturl is QString which later becomes 
latin1 loosing characters...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14006

To: dantti, dfaure, #frameworks, #dolphin
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15349: Update of the R indent script

[Pierre de Villemereuil]

devillemereuil created this revision.
devillemereuil added reviewers: KTextEditor, RKWard.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
devillemereuil requested review of this revision.

REVISION SUMMARY
  Changing the licence and Kate version as suggested in this previous Review 
 and fixing a bug where commented lines 
were not skipped correctly in calcOperatorIndent().

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15349

AFFECTED FILES
  src/script/data/indentation/r.js

To: devillemereuil, #ktexteditor, #rkward
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D15251#322205 , @bcooksley 
wrote:
  
  > That being said, given that the Online and Offline documentation should be 
essentially the same thing, it may be worth looking into basing the tooling for 
API.kde.org and utilising the QCH build process (however that works) to 
generate both the website version as well as the QCH files it offers for 
download.
  
  
  Very much agree to idea of deduplication.
  
  When it comes to providing QCH files from api.kde.org, there are multiple 
opinions though. My own is that QCH files should be part of the distributed 
product (e.g. in packages from distributions), not something offered separately 
and which needs manual updating by the user and extra checking to match the 
version of the library products one is currently using.
  Not sure why some people seem to think differently here when it comes to QCH 
files about API of KDE products, seems people have different needs and 
workflows. For comparison, the Qt QCH files are not available for download from 
docs.qt.io, unless I missed something.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D15251

To: heikobecker, kossebau, habacker
Cc: bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

[Ben Cooksley]

bcooksley added a comment.


  That being said, given that the Online and Offline documentation should be 
essentially the same thing, it may be worth looking into basing the tooling for 
API.kde.org and utilising the QCH build process (however that works) to 
generate both the website version as well as the QCH files it offers for 
download.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D15251

To: heikobecker, kossebau, habacker
Cc: bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D15251#322202 , @bcooksley 
wrote:
  
  > Please note that even if the generation of QCH files is enabled on the CI 
system, the resulting artifacts won't be made available outside the CI system 
itself.
  >  Availability of these files beyond the CI system would depend on separate 
work to improve api.kde.org, for which we're still looking for someone.
  
  
  Sure. These QCH files generated by ecm_add_qch are not what should end up on 
api.kde.org, but what should end up mainly in packages of (linux) 
distributions, same like docbook manuals for users.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D15251

To: heikobecker, kossebau, habacker
Cc: bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

[Ben Cooksley]

bcooksley added a comment.


  Please note that even if the generation of QCH files is enabled on the CI 
system, the resulting artifacts won't be made available outside the CI system 
itself.
  Availability of these files beyond the CI system would depend on separate 
work to improve api.kde.org, for which we're still looking for someone.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D15251

To: heikobecker, kossebau, habacker
Cc: bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kiconthemes kf5-qt5 WindowsMSVCQt5.11 - Build # 4 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20WindowsMSVCQt5.11/4/
 Project:
Frameworks kiconthemes kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 08 Sep 2018 09:07:28 +
 Build duration:
2 hr 5 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: TestSuite.kiconloader_benchmark

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.9/27/
 Project:
Frameworks kwindowsystem kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 08 Sep 2018 09:10:16 +
 Build duration:
1 hr 45 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7101/9495)55%
(3473/6357)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3004/3137)51%
(1260/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(776/1378)44%
(293/662)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3314/4657)60%
(1917/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

[Heiko Becker]

heikobecker added a comment.


  In D15251#322168 , @kossebau wrote:
  
  > ...as well as request to finally enable BUILD_QCH on CI, so this is covered.
  
  
  I wondered why that's not the case. I, for one, would welcome it.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D15251

To: heikobecker, kossebau, habacker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R249:7b2936a6d673: Fix autotests with -DBUILD_QCH:BOOL=TRUE 
(authored by heikobecker).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15251?vs=40932=41194

REVISION DETAIL
  https://phabricator.kde.org/D15251

AFFECTED FILES
  CMakeLists.txt

To: heikobecker, kossebau, habacker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 54 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/54/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 08 Sep 2018 09:05:34 +
 Build duration:
59 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6335/8432)43%
(10162/23449)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2701/2776)49%
(5804/11903)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1049/2827)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2315)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(863/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(731/908)52%
(826/1581)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 219 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/219/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 08 Sep 2018 09:10:57 +
 Build duration:
54 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)28%
(3609/13113)19%
(1823/9436)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2217)7%
(96/1434)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)44%
(673/1543)30%
(303/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1976)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

[Friedrich W. H. Kossebau]

kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  Ouch. Guess I should build my KF with clean build dirs every few weeks, as 
well as request to finally enable BUILD_QCH on CI, so this is covered.
  
  Looks good from pure reading.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15251

To: heikobecker, kossebau, habacker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D6513: Add support for Attica tags support

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D6513#322078 , @ngraham wrote:
  
  > So is this enough for people to start tagging KDE4 content as such? Or is 
anything else still required before that capability lands?
  
  
  In short, this is basically enough :) When people run KNewStuff with this 
patch, any content which has been marked as ghns_exclude (that tick box you and 
the other moderators have on the store) will be hidden from the user :) For 
doing more "proper" filtering, changes will want to be done to either just the 
knsrc files, or to the clients themselves (which would be for things like 
"don't show wallpapers with incorrect resolutions" or "only show things with 
x86 binaries" or that sort of stuff).

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, 
cfeck
Cc: dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, 
#knewstuff, michaelh, ZrenBot, bruns

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 39 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/39/
 Project:
Frameworks kwindowsystem kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 08 Sep 2018 09:10:16 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7101/9495)55%
(3475/6357)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3005/3137)51%
(1263/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(776/1378)44%
(293/662)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3313/4657)60%
(1916/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 83 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/83/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 08 Sep 2018 09:10:04 +
 Build duration:
32 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 45 test(s)Failed: TestSuite.kwayland-testXdgForeign
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(234/254)92%
(234/254)87%
(24726/28366)54%
(9770/18261)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(41/41)100%
(41/41)99%
(11625/11698)50%
(6163/12251)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(5735/6771)65%
(1508/2322)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(6932/7966)66%
(1930/2931)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/732)0%
(0/131)

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

[Heiko Becker]

heikobecker added reviewers: kossebau, habacker.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D15251

To: heikobecker, kossebau, habacker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 63 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/63/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 08 Sep 2018 09:06:05 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21615/45959)38%
(13051/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11364/11759)50%
(7174/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5546/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9694)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 109 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/109/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 08 Sep 2018 09:05:34 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6333/8432)43%
(10159/23453)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2700/2776)49%
(5800/11901)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2317)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(731/908)52%
(827/1583)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks kunitconversion kf5-qt5 AndroidQt5.11 - Build # 14 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20AndroidQt5.11/14/
 Project:
Frameworks kunitconversion kf5-qt5 AndroidQt5.11
 Date of build:
Sat, 08 Sep 2018 09:09:52 +
 Build duration:
1 min 26 sec and counting
   CONSOLE OUTPUT
  [...truncated 72.40 KB...] * Qt5Test * Qt5 (required version >= 5.8.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- Configuring done-- Generating doneCMake Warning:  Manually-specified variables were not used by the project:KF5_HOST_TOOLING-- Build files have been written to: /home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks kunitconversion kf5-qt5 AndroidQt5.11] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kunitconversion --branchGroup kf5-qt5 --platform AndroidQt5.11 --usingInstall /home/user/install-prefix/Scanning dependencies of target KF5UnitConversion_autogen[  2%] Automatic MOC for target KF5UnitConversion[  2%] Built target KF5UnitConversion_autogenScanning dependencies of target KF5UnitConversion[  4%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/converter.cpp.o[  7%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/velocity.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/mass.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/pressure.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/energy.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/currency.cpp.o[ 19%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/power.cpp.o[ 21%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/timeunit.cpp.o[ 23%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/fuel_efficiency.cpp.o[ 26%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/density.cpp.o[ 28%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/acceleration.cpp.o[ 30%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/force.cpp.o[ 33%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/angle.cpp.o[ 35%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/frequency.cpp.o[ 38%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/thermal_conductivity.cpp.o[ 40%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/thermal_flux.cpp.o[ 42%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/thermal_generation.cpp.o[ 45%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/voltage.cpp.o[ 47%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/electrical_current.cpp.o[ 50%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/electrical_resistance.cpp.o[ 52%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/KF5UnitConversion_autogen/mocs_compilation.cpp.o[ 54%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/temperature.cpp.o[ 57%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/volume.cpp.o[ 59%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/area.cpp.o[ 61%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/length.cpp.o[ 64%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/unitcategory.cpp.o[ 66%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/unit.cpp.o[ 69%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/value.cpp.o[ 71%] Linking CXX shared library ../bin/libKF5UnitConversion.so/home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.11/src/unit.cpp:33: error: undefined reference to 'KLocalizedString::KLocalizedString()'/home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.11/src/unit.cpp:33: error: undefined reference to 'KLocalizedString::KLocalizedString()'/home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.11/src/unit.cpp:33: error: undefined reference to 'KLocalizedString::KLocalizedString()'/home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.11/src/unit.cpp:49: error: undefined reference to 'KLocalizedString::KLocalizedString(KLocalizedString const&)'/home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.11/src/unit.cpp:49: error: undefined reference to 'KLocalizedString::KLocalizedString(KLocalizedString const&)'/home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.11/src/unit.cpp:49: error: undefined reference to 'KLocalizedString::KLocalizedString(KLocalizedString const&)'/home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.11/src/unit.cpp:53: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.11/src/unit.cpp:53: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/workspace/Frameworks kunitconversion kf5-qt5 

KDE CI: Frameworks kpackage kf5-qt5 AndroidQt5.11 - Build # 16 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20AndroidQt5.11/16/
 Project:
Frameworks kpackage kf5-qt5 AndroidQt5.11
 Date of build:
Sat, 08 Sep 2018 09:08:51 +
 Build duration:
1 min 24 sec and counting
   CONSOLE OUTPUT
  [...truncated 73.12 KB...]  "KF5DocTools_DIR" to a directory containing one of the above files.  If  "KF5DocTools" provides a separate development package or SDK, be sure it  has been installed.-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following REQUIRED packages have been found: * Qt5 (required version >= 5.8.0) * KF5Archive (required version >= 5.50.0) * Gettext * KF5I18n (required version >= 5.50.0) * KF5CoreAddons (required version >= 5.50.0) * ECM (required version >= 1.6.0), Extra CMake Modules.,  * Qt5Core * Qt5Test (required version >= 5.8.0)   Required for tests-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have not been found: * KF5DocTools (required version >= 5.50.0), Tools to generate documentation-- Configuring done-- Generating done-- Build files have been written to: /home/user/workspace/Frameworks kpackage kf5-qt5 AndroidQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks kpackage kf5-qt5 AndroidQt5.11] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kpackage --branchGroup kf5-qt5 --platform AndroidQt5.11 --usingInstall /home/user/install-prefix/Scanning dependencies of target mockhandler_autogenScanning dependencies of target KF5Package_autogenScanning dependencies of target testpackage-rcc[  1%] Automatic MOC for target mockhandler[  3%] Generating testpackage-rcc/contents.rcc[  5%] Automatic MOC for target KF5Package[  5%] Built target testpackage-rcc[  5%] Built target mockhandler_autogenScanning dependencies of target mockhandler[  8%] Building CXX object autotests/mockdepresolver/CMakeFiles/mockhandler.dir/main.cpp.o[  8%] Building CXX object autotests/mockdepresolver/CMakeFiles/mockhandler.dir/mockhandler_autogen/mocs_compilation.cpp.o[  8%] Built target KF5Package_autogen[ 10%] Automatic RCC for kpackage.qrcScanning dependencies of target KF5Package[ 11%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/package.cpp.o[ 13%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/packagestructure.cpp.o[ 15%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/packageloader.cpp.o[ 16%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packages.cpp.o[ 18%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packagejob.cpp.o[ 20%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packagejobthread.cpp.o[ 22%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/versionparser.cpp.o[ 23%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/version.cpp.o[ 25%] Linking CXX executable ../../bin/mockhandler[ 25%] Built target mockhandler[ 27%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/kpackage_debug.cpp.o[ 28%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/KF5Package_autogen/mocs_compilation.cpp.o[ 30%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/KF5Package_autogen/EWIEGA46WW/qrc_kpackage.cpp.o[ 32%] Linking CXX shared library ../../bin/libKF5Package.so/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1340: error: undefined reference to 'ki18nd(char const*, char const*)'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1340: error: undefined reference to 'KLocalizedString::toString() const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1340: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'ki18nd(char const*, char const*)'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::subs(QString const&, int, QChar) const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::subs(QString const&, int, QChar) const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::toString() const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined 

D13034: Add mechanism to notify other clients of config changes over DBus

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kconfigtest.cpp:1793
> +#if !KCONFIG_USE_DBUS
> +QEXPECT_FAIL("", "KConfig notification requires DBus", 
> QTest::Continue)
> +Q_ASSERT(false);

This is normally done using QSKIP.

Better than this, which will "fail to fail" in release mode (at least on the 
Q_ASSERT(false) line).

> kconfigtest.cpp:1800
> +
> +//mimcs a config in another process, which is watching for events
> +auto remoteConfig = KSharedConfig::openConfig(TEST_SUBDIR "kconfigtest");

typo: mimics

The fact that it's not actually another process, means that this test would 
pass with a simple emit as well ;)
A proper test would use QProcess to run a helper executable which would make 
changes to a config file.

> kconfig.cpp:460
> +if (e.bNotify) {
> +
> notifyGroupsGlobal[QString::fromLatin1(it.key().mGroup)] << it.key().mKey;
> +}

Why latin1? Can't groups use utf8?

> kconfig.cpp:465
> +if (e.bNotify) {
> +
> notifyGroupsLocal[QString::fromLatin1(it.key().mGroup)] << it.key().mKey;
> +}

I wonder if we should skip doing this work when DBUS support is disabled, for 
performance reasons.
More #if, but more speed... in the corner-case scenario though.
So I'm not sure ;)

> kconfigbase.h:61
> +/**<
> + * Notify remote KConfigWatchers of changes (Linux only)
> + * @since 5.CONFIGWATCHERVERSION

I see no reason why this wouldn't work on BSD :-)

I would change this to "(requires DBus support)".

> kconfigbase.h:62
> + * Notify remote KConfigWatchers of changes (Linux only)
> + * @since 5.CONFIGWATCHERVERSION
> + */

Let's go for 51 :)

> kconfigdata.cpp:304
> +case EntryNotify:
> +it->bNotify = bf;
>  default:

missing break;

> kconfigwatcher.cpp:1
> +#include "kconfigwatcher.h"
> +

License header missing

> kconfigwatcher.cpp:20
> +
> +typedef QHash> ConfigWatcherMap;
> +Q_GLOBAL_STATIC(ConfigWatcherMap, s_globalWatcherList)

(I'm curious, why not a raw pointer? You clean up the hash when the watcher is 
destroyed anyway; probably doesn't matter either way though)

> kconfigwatcher.cpp:21
> +typedef QHash> ConfigWatcherMap;
> +Q_GLOBAL_STATIC(ConfigWatcherMap, s_globalWatcherList)
> +

You could also do this the C++11 way with a static object inside the create() 
method, which is the only place where it's used.

> kconfigwatcher.cpp:28
> +
> +if (!s_globalWatcherList->contains(c)) {
> +watcher = KConfigWatcher::Ptr(new KConfigWatcher(config));

There should probably be a mutex around this whole method implementation, in 
case two threads create a watcher for the same KSharedConfig (which is itself 
threadsafe).

Alternatively, the static can be a QThreadStorage, like I did in 
ksharedconfig.cpp.

> kconfigwatcher.h:34
> + * Notifies when another client has updated this config file with the Notify 
> flag set.
> + * @since 5.CONFIGWATCHERVERSION
> + */

51

> kconfigwatcher.h:60
> +private Q_SLOTS:
> +void onConfigChangeNotification(QHash changes);
> +

const ref

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D13034

To: davidedmundson, broulik, dfaure
Cc: dfaure, broulik, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

Re: ECM Behaviour: Setting QT_PLUGIN_PATH on Windows

[David Faure]

On vendredi 31 août 2018 10:50:53 CEST Ben Cooksley wrote:
> On Tue, Aug 28, 2018 at 10:35 PM Ben Cooksley  wrote:
> > Hi all,
> 
> Hi all,
> 
> > We currently have a severe bug in ECM's AddTest macro due to it's
> > behaviour around the setting of QT_PLUGIN_PATH. On Windows it would
> > appear that the code in ECMAddTest mangles the environment variable,
> > removing crucial paths that the CI system includes within this
> > variable which are needed for applications and tests to function.
> > 
> > As a consequence of this, several projects tests are broken, and some
> > of these only fail by timeout. This has the effect of blocking Windows
> > CI builders for several hours in some instances simply due to tests
> > that are hanging and timing out as a result of being unable to load
> > plugins.
> > 
> > Can we please either short circuit this logic (and not try to set
> > QT_PLUGIN_PATH on Windows) or figure out the correct logic to be used
> > in this instance?
> > 
> > My suspicion is that CMake treats ';' specially, which means that when
> > the macro re-includes the existing content of the variable it gets
> > mangled by CMake, resulting in the entire content of that variable
> > being rendered unreadable.
> > 
> > Alternatively, CMAKE_LIBRARY_OUTPUT_DIRECTORY could have a trailing
> > backslash, which has certainly caused issues elsewhere.
> 
> Based on the lack of response to this, along with my earlier mail to
> k-f-d 7 days ago it doesn't look like anyone's going to pick this up.
> 
> As this issue is causing test breakages on the CI system including
> tying up valuable builder time for extraordinarily excessive amounts
> of time, i've taken a sledgehammer to the offending code in ECM.

Is there any indication that this code was misbehaving on Unix as well?
I'm surprised that you took out everything, not just the Windows case.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

[David Faure]

dfaure added a comment.


  OK after reading the bug report, I think this is more about "KRun as used by 
kde-open5 vs KRun as used by other apps such as konqueror".
  We want e.g. konqueror to follow the redirection. On the other hand we don't 
want kde-open5 to follow the redirection. Then what we might need is a 
KRun::setFollowRedirections(bool). On by default, set to off by kde-open5.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15189

To: achauvel, #frameworks, dfaure, cfeck
Cc: anthonyfieroni, ngraham, kde-frameworks-devel, michaelh, bruns

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I'm really not convinced about this. What about all the cases where you do 
want to see the redirection happen?
  
  - Redirection from http to https
  - Redirection from some outdated URL to the new correct URL
  - Redirection from google.com to www.google.com
  
  I think this needs more research. Why do other browsers show the new URL in 
all of the above cases and not for the twitter testcase? Different HTTP error 
code maybe?
  (I vaguely remember something about permanent redirections vs normal 
redirections?)

INLINE COMMENTS

> anthonyfieroni wrote in krun.cpp:1319
> Also you can add Qt::CaseInsensitive as second parameter to startsWith for 
> scheme with capital letters.

Not necessary, scheme() always returns the scheme lower-cased.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15189

To: achauvel, #frameworks, dfaure, cfeck
Cc: anthonyfieroni, ngraham, kde-frameworks-devel, michaelh, bruns

D13700: implement reading of the replaygain tags

[Matthieu Gallien]

mgallien accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  replaygain

REVISION DETAIL
  https://phabricator.kde.org/D13700

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D13700: implement reading of the replaygain tags

[Matthieu Gallien]

mgallien added a comment.


  Thanks for your hard work. This is a really nice addition to audio tags.
  I no longer have objections. Please finish to take into account feedback from 
@bruns.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D13700

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15340: Add Solarized Light and Dark themes

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good to me.
  
  Related: in order to have better unit testing, would you be willing to add a 
unit test to 
https://github.com/KDE/syntax-highlighting/blob/master/autotests/theme_test.cpp 
called
  
void testJsonData() { ... }
  
  This test would iterate over all themes via Qt Resources and check wether all 
31 default text styles exist, and also check for the existence of the editor 
colors. This would help us to catch theme issues early in the future.
  
  Feel free to commit this patch now.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-solarized-themes

REVISION DETAIL
  https://phabricator.kde.org/D15340

To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars