D15935: Don't show an emblem for mounted disks, only unmounted disks

2018-10-05 Thread Nathaniel Graham 
ngraham closed this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15935

To: ngraham, #vdg, abetts
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15935: Don't show an emblem for mounted disks, only unmounted disks

2018-10-05 Thread Andres Betts 
abetts accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  no-mounted-emblem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15935

To: ngraham, #vdg, abetts
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15939: Perform checks for unindexed files and stale index entries on startup

2018-10-05 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works great, thanks for all these Baloo patches! They are very much 
appreciated. Code looks good. As with the others, please commit for Frameworks 
5.52.
  
  While you're cranking away at these, might I suggest a few others that are 
sorely needed:
  
  - No apparent effect after removing a folder from the index; need to restart 
or kill all Baloo processes: https://bugs.kde.org/show_bug.cgi?id=373430 & 
https://bugs.kde.org/show_bug.cgi?id=353559
  - Baloo doesn't index or search symlinked folders: 
https://bugs.kde.org/show_bug.cgi?id=362226

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15939

To: poboiko, #baloo, #frameworks, vhanda, ngraham
Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
bruns, abrahams

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-10-05 Thread Dominik Haumann 
dhaumann added a comment.


  If Christoph accepts, I am fine with this.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8708

To: kossebau, #kate, #kdevelop
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars

D15944: [balooctl] Fix "index" command with already indexed, but moved file

2018-10-05 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Verified that this fixes https://bugs.kde.org/show_bug.cgi?id=397242. Can you 
add the following to the summary section:
  
BUG: 397242
FIXED-IN: 5.52
  
  Also please commit after 5.51 is tagged tomorrow.

REPOSITORY
  R293 Baloo

BRANCH
  fix-index-renamed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15944

To: poboiko, #baloo, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
bruns, abrahams

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-10-05 Thread Dominik Haumann 
dhaumann added a comment.


  Hm, given the size of the patch, and given it introduces new public API we 
cannot easily change, I think a silent +1 since noone reacts is not good enough.
  
  That said, I will not have time for another review until Oct 14th - so I 
would appreciate another review by someone else, if possible.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8708

To: kossebau, #kate, #kdevelop
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars

D15943: [balooctl] Monitor also for state changes

2018-10-05 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works for me and the code looks sane. Looks like this fixes 
https://bugs.kde.org/show_bug.cgi?id=364858, so can you add `BUG: 364858` and 
`FIXED-IN: 5.52` to the summary section and also make the changes that @bruns 
requested? Thanks!
  
  Also, please don't commit this until after Frameworks 5.51 has been tagged 
(which is tomorrow). This is the kind of change that we should have a month to 
test out ourselves before releasing it to customers.

REPOSITORY
  R293 Baloo

BRANCH
  monitor-state (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15943

To: poboiko, #frameworks, #baloo, ngraham
Cc: ngraham, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D15973: Add a 'Propreties' entry in the places panel context menu

2018-10-05 Thread Thomas Surrel 
thsurrel created this revision.
thsurrel added reviewers: Frameworks, VDG, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  Twin of D15929  for dolphin

TEST PLAN
  Right-click on a place or on a device in the Places panel now show a 
Properties entry.
  Clicking on it will open its folder property.

REPOSITORY
  R241 KIO

BRANCH
  arc_properties (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15973

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp

To: thsurrel, #frameworks, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-10-05 Thread Christoph Cullmann 
cullmann added a comment.


  As we have a usecase for this (the extension in KDevelop) I am ok if that 
goes in, if the extension in KDevelop is going in, too, as consumer.
  We can still fix minor issues in the KF6 iteration, they will never be found 
if it is not there and used.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8708

To: kossebau, #kate, #kdevelop
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars

D15839: extend PlasmaCore.ColorScope for custom colors

2018-10-05 Thread Michail Vourlakos 
mvourlakos edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15839

To: mvourlakos, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15970: Properly look for fallback themes

2018-10-05 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  At the moment we always look at the first fallback and load the original
  theme again, rendering moot the fallback look-up.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15970

AFFECTED FILES
  src/plasma/private/theme_p.cpp

To: apol, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15968: kreadconfig: make the tool slightly more useful

2018-10-05 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 42935.
apol added a comment.


  Remove unneeded values

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15968?vs=42934=42935

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15968

AFFECTED FILES
  src/kreadconfig/kreadconfig.cpp

To: apol, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15968: kreadconfig: make the tool slightly more useful

2018-10-05 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Include --help
  Don't assume that globals are disabled because we're reading an existing file.
  Allow the user to configure if cascading and globals are allowed

TEST PLAN
  Ran the application locally

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15968

AFFECTED FILES
  src/kreadconfig/kreadconfig.cpp

To: apol, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15960: Don't check if file is directory based on mime-type

2018-10-05 Thread Igor Poboiko 
poboiko created this revision.
poboiko added reviewers: Baloo, Frameworks.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.

REVISION SUMMARY
  `QDirIterator` returns URLs for directories without trailing slash. We're 
using `QMimeDatabase::matchTypeForFile(MatchExtension)`,
  which tries to guess mimetype based on file name only; and since we don't 
have trailing slash, it guesses it as `application/octet-stream`
  (generic type returned if `QMimeDatabase` wasn't able to guess) instead of 
`inode/directory`. Because of that, indexer does try to index folders
  (not a big problem, but still...)
  
  Since we've already use `QFileInfo`, use `isDir` check instead.

TEST PLAN
  It builds. My home directory no longer pops up in `UnindexedFileIterator`

REPOSITORY
  R293 Baloo

BRANCH
  check-dir (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15960

AFFECTED FILES
  src/file/modifiedfileindexer.cpp
  src/file/unindexedfileiterator.cpp

To: poboiko, #baloo, #frameworks
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15959: Wait for the extraction process to finish before scheduling

2018-10-05 Thread Igor Poboiko 
poboiko created this revision.
poboiko added reviewers: Baloo, Frameworks.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.

REVISION SUMMARY
  Right now, a race condition might happen. Signal `FileContentIndexer::done` 
is connected to `FileIndexScheduler::scheduleIndexing`,
  which does scheduling only when there is no active threads (NB: 
`FileContentIndexer` is running inside one).
  The signal is emitted in the very end of `FileContentIndexer::run`, which 
should be fine. However, after `run` is finished,
  it also calls destructor for local `ExtractorProcess process`, which destroys 
`QProcess m_extractorProcess`, which itself waits for the process to finish.
  
  If `FileContentIndexer::done` signal is processed before process is finished, 
scheduling won't happen and baloo will be stuck in `ContentIndexing` state.
  (which is exactly what pointed me to this issue: `File Indexer Monitor` 
application showed that baloo is stuck in `ContentIndexing`, when it clearly 
should be `Idle`)
  
  I suggest instead to emit `FileContentIndexer::done` signal only when 
`ExtractorProcess` is finished.

TEST PLAN
  I can no longer reproduce indexer being stuck in `ContentIndexing` phase.

REPOSITORY
  R293 Baloo

BRANCH
  wait-extractor-finish (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15959

AFFECTED FILES
  src/file/extractorprocess.cpp
  src/file/extractorprocess.h
  src/file/filecontentindexer.cpp

To: poboiko, #baloo, #frameworks
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15943: [balooctl] Monitor also for state changes

2018-10-05 Thread Igor Poboiko 
poboiko retitled this revision from "[balooctl] Monitor also for index changes" 
to "[balooctl] Monitor also for state changes".
poboiko edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15943

To: poboiko, #frameworks, #baloo
Cc: bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D15932: [UDisks2] Power down drive on remove if supported

2018-10-05 Thread Kai Uwe Broulik 
broulik accepted this revision.
broulik added a comment.


  Please wait till after Frameworks tagging (due tomorrow) so we can have more 
test exposure as Solid changes are usually quite delicate

REPOSITORY
  R245 Solid

BRANCH
  udisks2_power_down

REVISION DETAIL
  https://phabricator.kde.org/D15932

To: bruns, #frameworks, ngraham, broulik
Cc: broulik, kde-frameworks-devel, ngraham, michaelh, bruns