KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.10 - Build # 117 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.10/117/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 07 Oct 2018 04:02:41 +
 Build duration:
7 min 43 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.kmoretoolstest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)17%
(11/63)17%
(11/63)15%
(901/5957)12%
(439/3554)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(81/81)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)73%
(198/273)37%
(63/172)src22%
(2/9)22%
(2/9)2%
(22/960)0%
(0/376)src.attica0%
(0/2)0%
(0/2)0%
(0/298)0%
(0/231)src.core17%
(3/18)17%
(3/18)10%
(190/1819)11%
(146/1345)src.core.jobs0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/83)src.kmoretools60%
(3/5)60%
(3/5)52%
(410/796)36%
(192/532)src.qtquick0%
(0/5)0%
(0/5)0%
(0/276)0%
(0/104)src.staticxml0%
(0/1)0%
(0/1)0%
(0/169)0%
(0/148)src.ui0%
(0/8)0%
(0/8)0%
(0/745)0%
(0/317)src.upload0%
(0/1)0%
(0/1)0%
(0/121)0%
(0/80)tests0%
(0/3)0%
(0/3)0%
(0/133)0%
(0/72)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/22)

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 76 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/76/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 07 Oct 2018 04:02:40 +
 Build duration:
1 min 56 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.kmoretoolstest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)17%
(11/63)17%
(11/63)15%
(901/5957)12%
(439/3554)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(81/81)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)73%
(198/273)37%
(63/172)src22%
(2/9)22%
(2/9)2%
(22/960)0%
(0/376)src.attica0%
(0/2)0%
(0/2)0%
(0/298)0%
(0/231)src.core17%
(3/18)17%
(3/18)10%
(190/1819)11%
(146/1345)src.core.jobs0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/83)src.kmoretools60%
(3/5)60%
(3/5)52%
(410/796)36%
(192/532)src.qtquick0%
(0/5)0%
(0/5)0%
(0/276)0%
(0/104)src.staticxml0%
(0/1)0%
(0/1)0%
(0/169)0%
(0/148)src.ui0%
(0/8)0%
(0/8)0%
(0/745)0%
(0/317)src.upload0%
(0/1)0%
(0/1)0%
(0/121)0%
(0/80)tests0%
(0/3)0%
(0/3)0%
(0/133)0%
(0/72)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/22)

D15996: Add calls to KIO::UDSEntry::reserve in timeline/tags ioslaves

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:f517c4bc61a0: Add calls to KIO::UDSEntry::reserve in 
timeline/tags ioslaves (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15996?vs=42999&id=43001

REVISION DETAIL
  https://phabricator.kde.org/D15996

AFFECTED FILES
  src/kioslaves/tags/kio_tags.cpp
  src/kioslaves/timeline/kio_timeline.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15995: [balooctl] Flush buffered "Indexing " line when indexing starts

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:e4e519579656: [balooctl] Flush buffered "Indexing 
" line when indexing starts (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15995?vs=42994&id=43000

REVISION DETAIL
  https://phabricator.kde.org/D15995

AFFECTED FILES
  src/tools/balooctl/monitorcommand.cpp

To: bruns, #baloo, poboiko, ngraham, #frameworks
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15985: [balooctl] Print current state & indexing file when monitor starts

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Fantastic! Works great.

BRANCH
  monitor-initial-state (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15985

To: poboiko, #baloo, #frameworks, bruns, ngraham
Cc: ngraham, bruns

D15996: Add calls to KIO::UDSEntry::reserve in timeline/tags ioslaves

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  add_udsentry_reserve

REVISION DETAIL
  https://phabricator.kde.org/D15996

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15995: [balooctl] Flush buffered "Indexing " line when indexing starts

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  do_not_emit_finished_early

REVISION DETAIL
  https://phabricator.kde.org/D15995

To: bruns, #baloo, poboiko, ngraham, #frameworks
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15996: Add calls to KIO::UDSEntry::reserve in timeline/tags ioslaves

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Minor optimization

TEST PLAN
  make

REPOSITORY
  R293 Baloo

BRANCH
  add_udsentry_reserve

REVISION DETAIL
  https://phabricator.kde.org/D15996

AFFECTED FILES
  src/kioslaves/tags/kio_tags.cpp
  src/kioslaves/timeline/kio_timeline.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D11828: Simplify orPostingIterator and make it faster

[Stefan Brüns]

bruns added a reviewer: poboiko.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11828

To: bruns, #baloo, #frameworks, poboiko
Cc: fvogt, kde-frameworks-devel, #frameworks, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D15985: [balooctl] Print current state & indexing file when monitor starts

[Stefan Brüns]

bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.


  Looks sane ...

BRANCH
  monitor-initial-state (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15985

To: poboiko, #baloo, #frameworks, bruns
Cc: bruns

D15993: [PositionCodec] Avoid crash in case of corrupt data

[Stefan Brüns]

bruns added a comment.


  In D15993#337880 , @ngraham wrote:
  
  > Congrats, you just fixed the most common Baloo crash. :)
  
  
  Thx - I am just selfish here ;-)

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15993

To: bruns, #frameworks, poboiko, ngraham, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

Re: QtCreator-style block highlighting (and colours) in Kate(part)?

[Dominik Haumann]

Hi René,

my take on this is rather simple: I don't directly see the value in this
feature, so investing a significant amount of time is out of scope. I
believe this is valid for other Kate developers as well, especially since
we have more important issues to solve (finish port to KSyntaxHighlighting
framework to use its Themes for instance). That said, it won't happen,
except if someone provides a (good/clean!) patch... :)

PS: the better place for this discussion is kwrite-de...@kde.org.

Best regards
Dominik


René J. V. Bertin  schrieb am Sa., 6. Okt. 2018, 05:15:

> Dominik Haumann wrote:
>
> > No and no :)
> > But feel free to create/add a color scheme called Qt Creator.
>
> Not exactly the answer I was hoping for (though I kind of expected it ...)
>
> I *could* create a colour scheme if I had no other monk's tasks lying
> around
> (there are a *lot* of colours in the Creator scheme which would have to be
> mapped correctly). Implementing the distance-based backlighting feature is
> probably out of my league though. How much chance would it stand as a
> feature
> request?
>
> R.
>
>
>

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

[Stefan Brüns]

bruns added a reviewer: poboiko.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15826

To: bruns, #baloo, #frameworks, poboiko
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15994: [FileContentIndexer] Connect finished signal from extractor process

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:197545f873a8: [FileContentIndexer] Connect finished 
signal from extractor process (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15994?vs=42993&id=42996

REVISION DETAIL
  https://phabricator.kde.org/D15994

AFFECTED FILES
  src/file/filecontentindexer.cpp

To: bruns, #frameworks, poboiko, ngraham, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15993: [PositionCodec] Avoid crash in case of corrupt data

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:2d31a8500edb: [PositionCodec] Avoid crash in case of 
corrupt data (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15993?vs=42992&id=42995

REVISION DETAIL
  https://phabricator.kde.org/D15993

AFFECTED FILES
  src/codecs/positioncodec.cpp

To: bruns, #frameworks, poboiko, ngraham, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15993: [PositionCodec] Avoid crash in case of corrupt data

[Stefan Brüns]

bruns added a comment.


  In D15993#337854 , @ngraham wrote:
  
  > Thanks! Any chance this will fix 
https://bugs.kde.org/show_bug.cgi?id=367480?
  
  
  Absolutely!

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15993

To: bruns, #frameworks, poboiko, ngraham, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15993: [PositionCodec] Avoid crash in case of corrupt data

[Nathaniel Graham]

ngraham added a comment.


  Congrats, you just fixed the most common Baloo crash. :)

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15993

To: bruns, #frameworks, poboiko, ngraham, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15993: [PositionCodec] Avoid crash in case of corrupt data

[Stefan Brüns]

bruns edited the summary of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15993

To: bruns, #frameworks, poboiko, ngraham, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15995: [balooctl] Flush buffered "Indexing " line when indexing starts

[Stefan Brüns]

bruns edited the summary of this revision.
bruns edited the test plan for this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15995

To: bruns, #baloo, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15995: [balooctl] Flush buffered "Indexing " line when indexing starts

[Stefan Brüns]

bruns added a reviewer: Frameworks.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15995

To: bruns, #baloo, poboiko, ngraham, #frameworks
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15994: [FileContentIndexer] Connect finished signal from extractor process

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  > connect(&process, &ExtractorProcess::**started**IndexingFile, this, 
&FileContentIndexer::slot**Finished**IndexingFile);
  
  Lol whoops

REPOSITORY
  R293 Baloo

BRANCH
  do_not_emit_finished_early

REVISION DETAIL
  https://phabricator.kde.org/D15994

To: bruns, #frameworks, poboiko, ngraham, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15995: [balooctl] Flush buffered "Indexing " line when indexing starts

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Without the flush, the line is buffered until the endl from the finished
  flushes the output, i.e. the output is only visible after completion of
  a file, not while it is processed.
  
  See also D15993 

TEST PLAN
  same as for D15993 , but now visible in 
balooctl monitor instead of dbus-monitor

REPOSITORY
  R293 Baloo

BRANCH
  do_not_emit_finished_early

REVISION DETAIL
  https://phabricator.kde.org/D15995

AFFECTED FILES
  src/tools/balooctl/monitorcommand.cpp

To: bruns, #baloo, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15994: [FileContentIndexer] Connect finished signal from extractor process

[Nathaniel Graham]

ngraham added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15994

To: bruns, #frameworks, poboiko, ngraham, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15993: [PositionCodec] Avoid crash in case of corrupt data

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks! Any chance this will fix https://bugs.kde.org/show_bug.cgi?id=367480?

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15993

To: bruns, #frameworks, poboiko, ngraham, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15994: [FileContentIndexer] Connect finished signal from extractor process

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Only emit the "finished" signal to any watchers when the indexing
  is really finished. Also reset currentFile on finished.

TEST PLAN
  start dbus-monitor
  touch some larger files
  -> some time passes between started and finished signals

REPOSITORY
  R293 Baloo

BRANCH
  do_not_emit_finished_early

REVISION DETAIL
  https://phabricator.kde.org/D15994

AFFECTED FILES
  src/file/filecontentindexer.cpp

To: bruns, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15993: [PositionCodec] Avoid crash in case of corrupt data

[Nathaniel Graham]

ngraham added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15993

To: bruns, #frameworks, poboiko, ngraham, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15993: [PositionCodec] Avoid crash in case of corrupt data

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  getDifferentialVarInt* returns a nullptr in case of a decoding error.
  
  See also D11825 .

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15993

AFFECTED FILES
  src/codecs/positioncodec.cpp

To: bruns, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15988: Add 'Mount' option to context menu of unmounted device in Places

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  arc_mount (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15988

To: thsurrel, #frameworks, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15959: Wait for the extraction process to finish before scheduling

[Stefan Brüns]

bruns added a comment.


  I think the most trivial and completely correct way to fix this problem is to 
remove the `m_threadPool.activeThreadCount()` check from `scheduleIndexing()`. 
`QThreadPool::start(runnable)` puts the runnable in the run queue if there is 
still another thread running.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15959

To: poboiko, #baloo, #frameworks
Cc: bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D15973: Add a 'Propreties' entry in the places panel context menu

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added subscribers: anthonyfieroni, elvisangelaccio.
ngraham added a comment.
This revision is now accepted and ready to land.


  In your title: Propreties -> Properties
  
  Also, add `CCBUG: 181880` to your summary. That will result in the commit 
details making it into the Bugzilla ticket, but it won't be closed (since 
D15929  will close it).
  
  Otherwise this looks good and works well! Maybe wait for @elvisangelaccio 
and/or @anthonyfieroni to give their thumbs-up as well before landing the patch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15973

To: thsurrel, #frameworks, #vdg, ngraham
Cc: elvisangelaccio, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, 
bruns

D15973: Add a 'Propreties' entry in the places panel context menu

[Nathaniel Graham]

This revision now requires review to proceed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15973

To: thsurrel, #frameworks, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15939: Perform checks for unindexed files and stale index entries on startup

[Nathaniel Graham]

ngraham added a comment.


  In D15939#337757 , @poboiko wrote:
  
  > I've found the relevant bug: https://bugs.kde.org/show_bug.cgi?id=333678
  
  
  Hah, looks like you pushed a commit for it last year!
  
  I'm not wedded to symlink

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15939

To: poboiko, #baloo, #frameworks, vhanda, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D15939: Perform checks for unindexed files and stale index entries on startup

[Igor Poboiko]

poboiko added a comment.


  I've found the relevant bug: https://bugs.kde.org/show_bug.cgi?id=333678

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15939

To: poboiko, #baloo, #frameworks, vhanda, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D15973: Add a 'Propreties' entry in the places panel context menu

[Thomas Surrel]

thsurrel updated this revision to Diff 42984.
thsurrel added a comment.


  Use isLocalFile

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15973?vs=42945&id=42984

BRANCH
  arc_properties (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15973

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp

To: thsurrel, #frameworks, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15988: Add 'Mount' option to context menu of unmounted device in Places

[Thomas Surrel]

thsurrel created this revision.
thsurrel added reviewers: Frameworks, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  Twin of D15974  for dolphin

REPOSITORY
  R241 KIO

BRANCH
  arc_mount (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15988

AFFECTED FILES
  src/filewidgets/kfileplacesview.cpp

To: thsurrel, #frameworks, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15985: [balooctl] Print current state & indexing file when monitor starts

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: Baloo, Frameworks.
poboiko requested review of this revision.

REVISION SUMMARY
  This is based on D15943: [balooctl] Monitor also for state changes 
.
  Simply print current state & file when monitor starts.
  
  BUG: 364858
  FIXED-IN: 5.52

TEST PLAN
  `balooctl monitor` now prints
  
Press ctrl+c to stop monitoring
File indexer is running
Idle

BRANCH
  monitor-initial-state (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15985

AFFECTED FILES
  src/tools/balooctl/monitorcommand.cpp

To: poboiko, #baloo, #frameworks

D15959: Wait for the extraction process to finish before scheduling

[Igor Poboiko]

poboiko added a comment.


  That doesn't looks like it works all the time: sometimes I still have this 
issue. 
  Apparently, it still can happen that even when the process is finished, 
signal is emitted, but the thread is not finished yet.
  
  Also, it seems like due to `QueuedConnection`, `ExtractorProcess` can get 
removed before signal is processed, and because of that signal got lost. We can 
try something like that:
  
connect(&process, &ExtractorProcess::finished, this, [this]{
 QMetaObject::invokeMethod(this, "done", Qt::QueuedConnection);
});
  
  (so that `finished` signal is processed immediately, but the `done` signal is 
emitted queued).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15959

To: poboiko, #baloo, #frameworks
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15983: React to config updates inside indexer

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: Baloo, Frameworks.
poboiko requested review of this revision.

REVISION SUMMARY
  In case a config was changed, we need to:
  
  1. Stop the ContentIndexer (bug 373430)
  2. Remove all scheduled indexing of files that should not be indexed
  3. Check for stale index entries. Those includes documents marked for 
indexing, that should be removed
  
  (because of that we need to do it inside `scheduleIndexing` before content 
indexing)
  
  4. Finally, check for unindexed files (if new files were added)
  
  (based on D15939: Perform checks for unindexed files and stale index entries 
on startup ). Also note that `IndexCleaner` 
should clean all files, not just those inside `includeFolders`

TEST PLAN
  Seems to be working. But it would be nice to test it more.
  
  1. Add large folder to config. `baloo_file` start indexing it.
  2. Add it to exclude list. `baloo_file` stops indexing it, and removes 
entries from DB.
  3. Remove it from exclude list. `baloo_file` starts indexing it again.

BRANCH
  update-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15983

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/file/indexcleaner.cpp
  src/file/mainhub.cpp

To: poboiko, #baloo, #frameworks

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D8708#337408 , @dhaumann wrote:
  
  > Hm, given the size of the patch, and given it introduces new public API we 
cannot easily change, I think a silent +1 since noone reacts is not good enough.
  
  
  I agree that the amount of review done is not good enough. I would have liked 
some more feedback on both the patches, but most people sadly never got further 
than "nice feature, looking forward". I was very glad when you did your initial 
review :)
  
  On the other hand I have reiterated these patches a few times while they 
waited on phab for review, also tried multiple approaches last year before 
uploading the delegate one. So while my perfectionism-self still sees some 
issues in the new API, my pragmatism-self is actually pretty okay with it.
  The additional things I would have liked in the API actually would mean some 
rework of the currently line-based rendering approach inside `KateIconBorder`, 
which due to review needs might have worsened the chance of getting at least 
the basic feature in at all. So I dumped that work and reduced the patch to 
what we have now.
  
  > That said, I will not have time for another review until Oct 14th - so I 
would appreciate another review by someone else, if possible.
  
  Given this is API only needed for KDevelop 5.4, which might happen only begin 
of next year, I am okay with delaying another KF5 cycle/month, and schedule now 
to target 5.23 (merge after 5.22 has been tagged). If this actually means 
getting deep embracing reviews :) I was only going for action seeing that 
no-one seems to (have time to) care, before this feature is reaching it's first 
anniversary here on phabricator in November :( Not sure if I should have nagged 
more to get you to review this? But then I dislike being nagged myself for 
things which are pretty visible on phabricator, unless it's quick simple 
patches.
  
  So, anyone thinking they will have time & interest to do a full review in the 
October weeks?
  
  And I still think the annotation border feature would be a nice tool for 
people using kate/kwrite on versioned documents as well (given there is some 
VCS support to hook in). Is this really no use case Kate users have as well? -> 
https://frinring.wordpress.com/2018/09/09/from-code-to-related-bug-report-or-review-in-just-a-hover-click/
 Or do people not use Kate to work on old codebases? :P
  (a future planned addition will be integration to addressbooks/gravatar, so 
you could see the faces of the authors and/or have the option to directly 
contact them in case of need. All that could be done as one finds fancy thanks 
to the new delegate API introduced here, without having to twist something in 
KTextEditor)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8708

To: kossebau, #kate, #kdevelop
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars

D15939: Perform checks for unindexed files and stale index entries on startup

[Stefan Brüns]

bruns added a comment.


  In D15939#337534 , @poboiko wrote:
  
  > As for symlinked folders - I once looked into, a year ago or so. As far as 
I remember, those can be really tricky (but I don't really remember all the 
details):
  >
  > - There might be duplicated entries in index pointing to same file, which 
doesn't look good - if we index the same folder twice (symlink and original; 
but I guess we can always rely on `resolved` path, which should be unique - 
apart from hard links?)
  > - There might be recursive symlinks / loops, which should be handled (i.e. 
`dir1/subdir -> dir2` and `dir2/subdir -> dir1/`; but it looks like 
`QDirIterator` can handle symlink loops?)
  > - There might be a symlink to a folder, which has some parent excluded from 
indexing
  > - ...and maybe more
  >
  >   I'll see if there is something not easily manageable.
  
  
  Adding to all the points you already mentioned, I am also against following 
symlinks:
  
  - if a symlink points inside a hierarchy already included, there is nothing 
gained
  - if a symlink points outside, it can be included explicitly using 
includeFolders
  
  Prior to any implementation attempt I would like to see a specific use case 
for following symlinks, which is not already covered.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15939

To: poboiko, #baloo, #frameworks, vhanda, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D15939: Perform checks for unindexed files and stale index entries on startup

[Igor Poboiko]

poboiko added a comment.


  In D15939#337418 , @ngraham wrote:
  
  > Works great, thanks for all these Baloo patches! They are very much 
appreciated. Code looks good. As with the others, please commit for Frameworks 
5.52.
  >
  > While you're cranking away at these, might I suggest a few others that are 
sorely needed:
  >
  > - No apparent effect after removing a folder from the index; need to 
restart or kill all Baloo processes: 
https://bugs.kde.org/show_bug.cgi?id=373430 & 
https://bugs.kde.org/show_bug.cgi?id=353559
  
  
  I can look at these, shouldn't be too hard.
  
  > - Baloo doesn't index or search symlinked folders: 
https://bugs.kde.org/show_bug.cgi?id=362226
  
  I guess this link also should be added to previous two :)
  
  As for symlinked folders - I once looked into, a year ago or so. As far as I 
remember, those can be really tricky (but I don't really remember all the 
details):
  
  - There might be duplicated entries in index pointing to same file, which 
doesn't look good - if we index the same folder twice (symlink and original; 
but I guess we can always rely on `resolved` path, which should be unique - 
apart from hard links?)
  - There might be recursive symlinks / loops, which should be handled (i.e. 
`dir1/subdir -> dir2` and `dir2/subdir -> dir1/`; but it looks like 
`QDirIterator` can handle symlink loops?)
  - There might be a symlink to a folder, which has some parent excluded from 
indexing
  - ...and maybe more
  
  I'll see if there is something not easily manageable.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15939

To: poboiko, #baloo, #frameworks, vhanda, ngraham
Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
bruns, abrahams

D15943: [balooctl] Monitor also for state changes

[Stefan Brüns]

bruns added a comment.


  In D15943#337522 , @poboiko wrote:
  
  > In D15943#337385 , @ngraham 
wrote:
  >
  > > Works for me and the code looks sane. Looks like this fixes 
https://bugs.kde.org/show_bug.cgi?id=364858, so can you add `BUG: 364858` and 
`FIXED-IN: 5.52` to the summary section and also make the changes that @bruns 
requested? Thanks!
  >
  >
  > Weird, bug 364858 should be fine as it is - user asks for a way to display 
files Baloo is currently processing, but that's exactly what `monitor` does 
(even without this patch).
  
  
  I think 364858 is not affected by this, but is still broken.
  
  The monitor command watches for **changes** of the filename, but misses to 
fetch `currentFile` on startup. When the indexer "hangs", we never get a signal.

REPOSITORY
  R293 Baloo

BRANCH
  monitor-state (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15943

To: poboiko, #frameworks, #baloo, ngraham
Cc: ngraham, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D15859: allow non-local file:// redirect to a M$-WebDav URL

[Martin Koller]

mkoller added a comment.


  ping

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15859

To: mkoller, dfaure, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D15943: [balooctl] Monitor also for state changes

[Igor Poboiko]

poboiko edited the summary of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  monitor-state (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15943

To: poboiko, #frameworks, #baloo, ngraham
Cc: ngraham, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D15943: [balooctl] Monitor also for state changes

[Igor Poboiko]

poboiko added a comment.


  In D15943#337385 , @ngraham wrote:
  
  > Works for me and the code looks sane. Looks like this fixes 
https://bugs.kde.org/show_bug.cgi?id=364858, so can you add `BUG: 364858` and 
`FIXED-IN: 5.52` to the summary section and also make the changes that @bruns 
requested? Thanks!
  
  
  Weird, bug 364858 should be fine as it is - user asks for a way to display 
files Baloo is currently processing, but that's exactly what `monitor` does 
(even without this patch).
  
  > Also, please don't commit this until after Frameworks 5.51 has been tagged 
(which is tomorrow). This is the kind of change that we should have a month to 
test out ourselves before releasing it to customers.
  
  Sure, totally agree!

REPOSITORY
  R293 Baloo

BRANCH
  monitor-state (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15943

To: poboiko, #frameworks, #baloo, ngraham
Cc: ngraham, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D15944: [balooctl] Fix "index" command with already indexed, but moved file

[Igor Poboiko]

poboiko edited the summary of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  fix-index-renamed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15944

To: poboiko, #baloo, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
bruns, abrahams

Re: QtCreator-style block highlighting (and colours) in Kate(part)?

[René J . V . Bertin]

Dominik Haumann wrote:

> No and no :)
> But feel free to create/add a color scheme called Qt Creator.

Not exactly the answer I was hoping for (though I kind of expected it ...)

I *could* create a colour scheme if I had no other monk's tasks lying around 
(there are a *lot* of colours in the Creator scheme which would have to be 
mapped correctly). Implementing the distance-based backlighting feature is 
probably out of my league though. How much chance would it stand as a feature 
request?

R.

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 58 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/58/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 06 Oct 2018 08:48:24 +
 Build duration:
2 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 114 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/114/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 06 Oct 2018 08:48:24 +
 Build duration:
1 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

D11880: Add firewall-config and firewall-applet icons

[David Faure]

dfaure added a comment.


  This commit breaks the unittest "scalabletest" :
  
  FAIL!  : ScalableTest::test_scalable(icons:Applications) The following icons 
are not available in a scalable directory:
  
firewall-applet-panic
firewall-applet
firewall-applet-error
firewall-applet-shields_up
 Loc: [/d/kde/src/5/frameworks/breeze-icons/autotests/scalabletest.cpp(262)]
  
  FAIL!  : ScalableTest::test_scalable(icons-dark:Applications) The following 
icons are not available in a scalable directory:
  
firewall-applet-panic
firewall-applet
firewall-applet-error
firewall-applet-shields_up
 Loc: [/d/kde/src/5/frameworks/breeze-icons/autotests/scalabletest.cpp(262)]
  
  Please fix ;)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: dfaure, bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, 
michaelh