D16415: Creating new syntax highlighting file for Job Control Language (JCL)

[Dominik Haumann]

dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.


  Please add a small test file and explain what this highlighting language is 
used for :)

INLINE COMMENTS

> jcl.xml:3
> +
> + extensions="*.JCL;*.jcl" mimetype="">
> +  

kateversion="5.0" and license="MIT"

> jcl.xml:128
> +
> + String="^((?!\/\/\*).*)(\/\/).*?(?=\s)"/> 
> + String="^(?!\/\/).*"/>

Use column="0" and remove leading ^. Or do you mean firstNonSpace="true"?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16415

To: phily, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars

D16416: z/OS CLIST file syntax highlighting

[Dominik Haumann]

dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.


  Could you explain what CLIST is used for? Please add a small test file that 
is also MIT licensed.

INLINE COMMENTS

> clist.xml:3
> +
> + extensions="*.clist;*.CLIST" mimetype="">
> +  

license="MIT" is missing.

> clist.xml:3
> +
> + extensions="*.clist;*.CLIST" mimetype="">
> +  

kateversion="5.0", or are you indeed using an old Kate before Plasma5?

> clist.xml:61
> +  
> +  
> +

Maybe rename Commentar 1 to simply Comment? It seems you copy & pasted the file 
:)

> clist.xml:62
> +  
> +
> + endRegion="Comment"/>

Please use IncludeRules with ##Alerts, look into other highlighting files how 
this is done.

> clist.xml:69
> +  
> +  
> +  

Please remove the hard coded color. Hard coded colors are an issue with 
different color schemes. See 
https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/
 for more default styles.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16416

To: phily, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> batchrenamedialog.cpp:40
> +#include 
> +#include 
> +#include 

remove QtWidget

> batchrenamedialog.cpp:41
> +#include 
> +#include 
> +

remove QtGui prefix

> batchrenamedialog.cpp:46
> +
> +BatchRenameDialog::BatchRenameDialog(QWidget *parent, const KFileItemList 
> &items) : QDialog(parent)
> +{

new line before ": QDialog"

> batchrenamedialog.h:69
> +
> +KMessageWidget *m_messageWidget;
> +QTimer *m_timer;

it's a good idea to initialize to nullptr each pointer here.
So we can see problem easily.

> batchrenamedialogmodel_p.cpp:88
> +
> +BatchRenameDialogModel::BatchRenameDialogModel(QObject *parent, const 
> KFileItemList &items) : QAbstractTableModel(parent)
> +{

new line before : QAbstr...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, 
michaelh, bruns

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis updated this revision to Diff 44230.
ndavis added a comment.


  Make emblem-question symbol thicker

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16421?vs=44211&id=44230

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

AFFECTED FILES
  icons-dark/emblems/16/checkmark.svg
  icons-dark/emblems/16/emblem-added.svg
  icons-dark/emblems/16/emblem-checked.svg
  icons-dark/emblems/16/emblem-encrypted-unlocked.svg
  icons-dark/emblems/16/emblem-error.svg
  icons-dark/emblems/16/emblem-favorite.svg
  icons-dark/emblems/16/emblem-important.svg
  icons-dark/emblems/16/emblem-information.svg
  icons-dark/emblems/16/emblem-locked.svg
  icons-dark/emblems/16/emblem-mounted.svg
  icons-dark/emblems/16/emblem-pause.svg
  icons-dark/emblems/16/emblem-question.svg
  icons-dark/emblems/16/emblem-remove.svg
  icons-dark/emblems/16/emblem-shared.svg
  icons-dark/emblems/16/emblem-success.svg
  icons-dark/emblems/16/emblem-symbolic-link.svg
  icons-dark/emblems/16/emblem-unavailable.svg
  icons-dark/emblems/16/emblem-unlocked.svg
  icons-dark/emblems/16/emblem-unmounted.svg
  icons-dark/emblems/16/emblem-warning.svg
  icons-dark/emblems/16/rating-unrated.svg
  icons-dark/emblems/16/rating.svg
  icons-dark/emblems/16/vcs-added.svg
  icons-dark/emblems/16/vcs-conflicting.svg
  icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/16/vcs-locally-modified.svg
  icons-dark/emblems/16/vcs-normal.svg
  icons-dark/emblems/16/vcs-removed.svg
  icons-dark/emblems/16/vcs-update-required.svg
  icons-dark/emblems/22/checkmark.svg
  icons-dark/emblems/22/emblem-added.svg
  icons-dark/emblems/22/emblem-checked.svg
  icons-dark/emblems/22/emblem-encrypted-unlocked.svg
  icons-dark/emblems/22/emblem-error.svg
  icons-dark/emblems/22/emblem-favorite.svg
  icons-dark/emblems/22/emblem-important.svg
  icons-dark/emblems/22/emblem-information.svg
  icons-dark/emblems/22/emblem-locked.svg
  icons-dark/emblems/22/emblem-mounted.svg
  icons-dark/emblems/22/emblem-pause.svg
  icons-dark/emblems/22/emblem-question.svg
  icons-dark/emblems/22/emblem-remove.svg
  icons-dark/emblems/22/emblem-shared.svg
  icons-dark/emblems/22/emblem-success.svg
  icons-dark/emblems/22/emblem-symbolic-link.svg
  icons-dark/emblems/22/emblem-unavailable.svg
  icons-dark/emblems/22/emblem-unlocked.svg
  icons-dark/emblems/22/emblem-unmounted.svg
  icons-dark/emblems/22/emblem-warning.svg
  icons-dark/emblems/22/rating-unrated.svg
  icons-dark/emblems/22/rating.svg
  icons-dark/emblems/22/vcs-added.svg
  icons-dark/emblems/22/vcs-conflicting.svg
  icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/22/vcs-locally-modified.svg
  icons-dark/emblems/22/vcs-normal.svg
  icons-dark/emblems/22/vcs-removed.svg
  icons-dark/emblems/22/vcs-update-required.svg
  icons-dark/emblems/8/emblem-added.svg
  icons-dark/emblems/8/emblem-checked.svg
  icons-dark/emblems/8/emblem-encrypted-unlocked.svg
  icons-dark/emblems/8/emblem-error.svg
  icons-dark/emblems/8/emblem-favorite.svg
  icons-dark/emblems/8/emblem-important.svg
  icons-dark/emblems/8/emblem-information.svg
  icons-dark/emblems/8/emblem-locked.svg
  icons-dark/emblems/8/emblem-mounted.svg
  icons-dark/emblems/8/emblem-pause.svg
  icons-dark/emblems/8/emblem-question.svg
  icons-dark/emblems/8/emblem-remove.svg
  icons-dark/emblems/8/emblem-shared.svg
  icons-dark/emblems/8/emblem-symbolic-link.svg
  icons-dark/emblems/8/emblem-unavailable.svg
  icons-dark/emblems/8/emblem-unlocked.svg
  icons-dark/emblems/8/emblem-unmounted.svg
  icons-dark/emblems/8/emblem-warning.svg
  icons-dark/emblems/8/rating-unrated.svg
  icons-dark/emblems/8/rating.svg
  icons-dark/emblems/8/vcs-added.svg
  icons-dark/emblems/8/vcs-conflicting.svg
  icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/8/vcs-locally-modified.svg
  icons-dark/emblems/8/vcs-normal.svg
  icons-dark/emblems/8/vcs-removed.svg
  icons-dark/emblems/8/vcs-update-required.svg
  icons/emblems/16/checkmark.svg
  icons/emblems/16/emblem-added.svg
  icons/emblems/16/emblem-checked.svg
  icons/emblems/16/emblem-encrypted-unlocked.svg
  icons/emblems/16/emblem-error.svg
  icons/emblems/16/emblem-favorite.svg
  icons/emblems/16/emblem-important.svg
  icons/emblems/16/emblem-information.svg
  icons/emblems/16/emblem-locked.svg
  icons/emblems/16/emblem-mounted.svg
  icons/emblems/16/emblem-pause.svg
  icons/emblems/16/emblem-question.svg
  icons/emblems/16/emblem-remove.svg
  icons/emblems/16/emblem-shared.svg
  icons/emblems/16/emblem-success.svg
  icons/emblems/16/emblem-symbolic-link.svg
  icons/emblems/16/emblem-unavailable.svg
  icons/emblems/16/emblem-unlocked.svg
  icons/emblems/16/emblem-unmounted.svg
  icons/emblems/16/emblem-warning.svg
  icons/emblems/16/rating-unrated.svg
  icons/emblems/16/rating.svg
  icons/emblems/16/vcs-added.svg
  icons/emblems/16/vcs-conflicting.svg
  icons/emblems/16/vcs-locally-m

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#348702 , @ngraham wrote:
  
  > Does this problem still happen after you delete your icon cache? (`rm 
~/.cache/icon-cache.kcache`)
  
  
  Yes.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  In D16421#348664 , @ndavis wrote:
  
  > How is this?
  >  F6356555: Screenshot_20181025_193720.png 

  
  
  Much better! That looks great.
  
  In D16421#348675 , @ndavis wrote:
  
  > It's not that the symlink emblem gets trimmed, it's just normally off.
  
  
  That's really weird. I don't see any code that's looking for this specific 
emblem and drawing it in a different position. Does this problem still happen 
after you delete your icon cache? (`rm ~/.cache/icon-cache.kcache`)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#348609 , @ngraham wrote:
  
  > JFYI, I dug through `KIconLoader` today and couldn't find anything that 
explicitly or implicitly trims the bounds of loaded images that could account 
for the link emblem not having its original bounds respected and results in it 
being drawn too high. Either I missed the part that does this (which is quite 
possible), or it's some implicit thing in the SVG image itself (which is also 
possible, since I know nothing about SVG images), or it's something else 
entirely.
  
  
  It's not that the symlink emblem gets trimmed, it's just normally off. In 
this image, I changed the background of the symlink emblem to take up the whole 
canvas and it's 2 pixels farther in than the vcs-normal emblem.F6356652: 
Screenshot_20181025_195954.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16431: Guard data source being deleted before processing dataoffer receive event

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  A data source can disappear at any moment, it's plausible a client could
  have requested data whilst the client was alive and we are processing it
  afterwards.
  
  The accept and finish callback guard against the source being deleted,
  but recieve did not.
  
  BUG: 400311

TEST PLAN
  Could still copy/paste as before

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16431

AFFECTED FILES
  src/server/dataoffer_interface.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#348594 , @ngraham wrote:
  
  > Now that I stare at the summary graphics again, the white question mark 
looks a bit wispy and insubstantial at the 16px and 22px sizes. Do you agree? 
Other than that, everything looks pretty much perfect to me.
  
  
  How is this?
  F6356555: Screenshot_20181025_193720.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

[Stefan Brüns]

bruns updated this revision to Diff 44224.
bruns added a comment.


  use KLocalizedString for deferred i18n substitution

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15826?vs=43176&id=44224

BRANCH
  oob2

REVISION DETAIL
  https://phabricator.kde.org/D15826

AFFECTED FILES
  src/tools/balooshow/main.cpp

To: bruns, #baloo, #frameworks, poboiko
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16414: Changes to REXX syntax highlighting

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Hi, nice that you take care of fixing these issues.
  
  Two small things that could be improved:
  
  1. the version="2" needs to be bumped to 3
  2. there should be some unit test for the highlighting, you can put some test 
file into autotests/input (e.g. test.rex) this will make it much easier to keep 
this in a OK state in the future
  
  If you need more pointers on the testing, just ping us here, thanks!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16414

To: phily, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16421: Improve emblem contrast, legibility and consistency

[Stefan Brüns]

bruns added a comment.


  In D16421#348609 , @ngraham wrote:
  
  > JFYI, I dug through `KIconLoader` today and couldn't find anything that 
explicitly or implicitly trims the bounds of loaded images that could account 
for the link emblem not having its original bounds respected and results in it 
being drawn too high. Either I missed the part that does this (which is quite 
possible), or it's some implicit thing in the SVG image itself (which is also 
possible, since I know nothing about SVG images), or it's something else 
entirely.
  
  
  You could try to convert the emblem to PNG and see if it is aligned correctly.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  JFYI, I dug through `KIconLoader` today and couldn't find anything that 
explicitly or implicitly trims the bounds of loaded images that could account 
for the link emblem not having its original bounds respected and results in it 
being drawn too high. Either I missed the part that does this (which is quite 
possible), or it's some implicit thing in the SVG image itself (which is also 
possible, since I know nothing about SVG images), or it's something else 
entirely.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  Now that I stare at the summary graphics again, the white question mark looks 
a bit wispy and insubstantial at the 16px and 22px sizes. Do you agree? Other 
than that, everything looks pretty much perfect to me.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16236: [Extractor] Handle documents correctly where mimetype should not be indexed

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:db4aac4b6317: [Extractor] Handle documents correctly 
where mimetype should not be indexed (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16236?vs=43702&id=44219

REVISION DETAIL
  https://phabricator.kde.org/D16236

AFFECTED FILES
  src/file/extractor/app.cpp

To: bruns, #baloo, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
bruns, abrahams

D16236: [Extractor] Handle documents correctly where mimetype should not be indexed

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks, this seems to work well.

INLINE COMMENTS

> app.cpp:133
> +if (!m_config.shouldBeIndexed(url)) {
>  // FIXME: This should never be happening!
> +qCWarning(BALOO) << "Found" << url << "in the ContentIndexingDB, 
> although it should be skipped";

Is this FIXME still in need of fixing with your changes here?

REPOSITORY
  R293 Baloo

BRANCH
  mimetype_handling

REVISION DETAIL
  https://phabricator.kde.org/D16236

To: bruns, #baloo, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
bruns, abrahams

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[Emirald Mateli]

emateli marked 2 inline comments as done.
emateli added a comment.


  Something that might need a bit of input is `BatchRenameJob`.
  
  - This was added a while back so that Dolphin doesn't do a batch rename as a 
series of single file renames.
  - This job takes care of replacing the `#` placeholder as well.
  - What this patch really wants is an API to rename a list of files, into some 
new names without doing any additional handling except moving the files (as the 
placeholder replacement is done elsewhere).
  - By consulting 
https://lxr.kde.org/search?_filestring=&_string=BatchRenameJob we can see that 
Dolphin is the only application to make use of this `BatchRenameJob` API.
  - Leaving credit to the original author, since the `#` placeholder will not 
be used anymore. Should we re-purpose this class to accept two lists, one with 
the current names, the other with the new ones and remove the original 
placeholder implementation (as it would be mostly dead code at this point) 
while keeping everything else intact.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, 
michaelh, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[Emirald Mateli]

emateli updated this revision to Diff 44218.
emateli marked 3 inline comments as done.
emateli added a comment.


  - Remove QtCore/

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14631?vs=44217&id=44218

BRANCH
  batchrename2

REVISION DETAIL
  https://phabricator.kde.org/D14631

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/batchrenametypestest.cpp
  autotests/batchrenametypestest.h
  src/widgets/CMakeLists.txt
  src/widgets/rename/batchrenamedialog.cpp
  src/widgets/rename/batchrenamedialog.h
  src/widgets/rename/batchrenamedialogmodel_p.cpp
  src/widgets/rename/batchrenamedialogmodel_p.h
  src/widgets/rename/batchrenametypes_p.cpp
  src/widgets/rename/batchrenametypes_p.h
  src/widgets/rename/batchrenamevar_p.cpp
  src/widgets/rename/batchrenamevar_p.h
  src/widgets/rename/filenameutils_p.cpp
  src/widgets/rename/filenameutils_p.h
  tests/CMakeLists.txt
  tests/batchrenamedialogtest_gui.cpp

To: emateli, #frameworks, dfaure, mlaurent
Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, 
michaelh, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[Emirald Mateli]

emateli updated this revision to Diff 44217.
emateli added a comment.


  - fix indent
  - remove setlayout call
  - Add missing parent parameters
  - Remove unnecessary QtCore/ prefix

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14631?vs=44189&id=44217

BRANCH
  batchrename2

REVISION DETAIL
  https://phabricator.kde.org/D14631

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/batchrenametypestest.cpp
  autotests/batchrenametypestest.h
  src/widgets/CMakeLists.txt
  src/widgets/rename/batchrenamedialog.cpp
  src/widgets/rename/batchrenamedialog.h
  src/widgets/rename/batchrenamedialogmodel_p.cpp
  src/widgets/rename/batchrenamedialogmodel_p.h
  src/widgets/rename/batchrenametypes_p.cpp
  src/widgets/rename/batchrenametypes_p.h
  src/widgets/rename/batchrenamevar_p.cpp
  src/widgets/rename/batchrenamevar_p.h
  src/widgets/rename/filenameutils_p.cpp
  src/widgets/rename/filenameutils_p.h
  tests/CMakeLists.txt
  tests/batchrenamedialogtest_gui.cpp

To: emateli, #frameworks, dfaure, mlaurent
Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, 
michaelh, bruns

D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:43ab022f35e8: [Scheduler] Fix wrong usage of obsolete 
QFileInfo::created() timestamp (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16255?vs=43747&id=44216

REVISION DETAIL
  https://phabricator.kde.org/D16255

AFFECTED FILES
  src/engine/documenttimedb.h
  src/file/basicindexingjob.cpp
  src/file/modifiedfileindexer.cpp
  src/file/unindexedfileiterator.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham, lbeltrame
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16427: [solid-hardware5] List icon in device details

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:9910ad1473f4: [solid-hardware5] List icon in device 
details (authored by broulik).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16427?vs=44214&id=44215

REVISION DETAIL
  https://phabricator.kde.org/D16427

AFFECTED FILES
  src/tools/solid-hardware/solid-hardware.cpp

To: broulik, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16427: [solid-hardware5] List icon in device details

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D16427

To: broulik, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16427: [solid-hardware5] List icon in device details

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

TEST PLAN
udi = 
'/org/kde/solid/udev/sys/devices/pci:00/:00:01.1/:01:00.0/usb1/1-7'
  parent = '/org/kde/solid/udev'  (string)
  vendor = 'LGE'  (string)
  product = 'Nexus 5'  (string)
  description = 'Nexus 5'  (string)
  icon = 'multimedia-player'  (string)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D16427

AFFECTED FILES
  src/tools/solid-hardware/solid-hardware.cpp

To: broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp

[Luca Beltrame]

lbeltrame accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  indexer_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D16255

To: bruns, #baloo, #frameworks, poboiko, ngraham, lbeltrame
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16236: [Extractor] Handle documents correctly where mimetype should not be indexed

[Stefan Brüns]

bruns edited the test plan for this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16236

To: bruns, #baloo, #frameworks
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp

[Stefan Brüns]

bruns added a comment.


  Good to go?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16255

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16266: [Extractor] Make extractor crash resilient

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:1509ca51c5ed: [Extractor] Make extractor crash resilient 
(authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16266?vs=43777&id=44212

REVISION DETAIL
  https://phabricator.kde.org/D16266

AFFECTED FILES
  src/file/extractorprocess.cpp
  src/file/extractorprocess.h
  src/file/filecontentindexer.cpp
  src/file/filecontentindexerprovider.cpp
  src/file/filecontentindexerprovider.h

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: broulik, apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis updated this revision to Diff 44211.
ndavis added a comment.


  Change style of emblem-symbolic-link at 22px

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16421?vs=44210&id=44211

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

AFFECTED FILES
  icons-dark/emblems/16/checkmark.svg
  icons-dark/emblems/16/emblem-added.svg
  icons-dark/emblems/16/emblem-checked.svg
  icons-dark/emblems/16/emblem-encrypted-unlocked.svg
  icons-dark/emblems/16/emblem-error.svg
  icons-dark/emblems/16/emblem-favorite.svg
  icons-dark/emblems/16/emblem-important.svg
  icons-dark/emblems/16/emblem-information.svg
  icons-dark/emblems/16/emblem-locked.svg
  icons-dark/emblems/16/emblem-mounted.svg
  icons-dark/emblems/16/emblem-pause.svg
  icons-dark/emblems/16/emblem-question.svg
  icons-dark/emblems/16/emblem-remove.svg
  icons-dark/emblems/16/emblem-shared.svg
  icons-dark/emblems/16/emblem-success.svg
  icons-dark/emblems/16/emblem-symbolic-link.svg
  icons-dark/emblems/16/emblem-unavailable.svg
  icons-dark/emblems/16/emblem-unlocked.svg
  icons-dark/emblems/16/emblem-unmounted.svg
  icons-dark/emblems/16/emblem-warning.svg
  icons-dark/emblems/16/rating-unrated.svg
  icons-dark/emblems/16/rating.svg
  icons-dark/emblems/16/vcs-added.svg
  icons-dark/emblems/16/vcs-conflicting.svg
  icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/16/vcs-locally-modified.svg
  icons-dark/emblems/16/vcs-normal.svg
  icons-dark/emblems/16/vcs-removed.svg
  icons-dark/emblems/16/vcs-update-required.svg
  icons-dark/emblems/22/checkmark.svg
  icons-dark/emblems/22/emblem-added.svg
  icons-dark/emblems/22/emblem-checked.svg
  icons-dark/emblems/22/emblem-encrypted-unlocked.svg
  icons-dark/emblems/22/emblem-error.svg
  icons-dark/emblems/22/emblem-favorite.svg
  icons-dark/emblems/22/emblem-important.svg
  icons-dark/emblems/22/emblem-information.svg
  icons-dark/emblems/22/emblem-locked.svg
  icons-dark/emblems/22/emblem-mounted.svg
  icons-dark/emblems/22/emblem-pause.svg
  icons-dark/emblems/22/emblem-question.svg
  icons-dark/emblems/22/emblem-remove.svg
  icons-dark/emblems/22/emblem-shared.svg
  icons-dark/emblems/22/emblem-success.svg
  icons-dark/emblems/22/emblem-symbolic-link.svg
  icons-dark/emblems/22/emblem-unavailable.svg
  icons-dark/emblems/22/emblem-unlocked.svg
  icons-dark/emblems/22/emblem-unmounted.svg
  icons-dark/emblems/22/emblem-warning.svg
  icons-dark/emblems/22/rating-unrated.svg
  icons-dark/emblems/22/rating.svg
  icons-dark/emblems/22/vcs-added.svg
  icons-dark/emblems/22/vcs-conflicting.svg
  icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/22/vcs-locally-modified.svg
  icons-dark/emblems/22/vcs-normal.svg
  icons-dark/emblems/22/vcs-removed.svg
  icons-dark/emblems/22/vcs-update-required.svg
  icons-dark/emblems/8/emblem-added.svg
  icons-dark/emblems/8/emblem-checked.svg
  icons-dark/emblems/8/emblem-encrypted-unlocked.svg
  icons-dark/emblems/8/emblem-error.svg
  icons-dark/emblems/8/emblem-favorite.svg
  icons-dark/emblems/8/emblem-important.svg
  icons-dark/emblems/8/emblem-information.svg
  icons-dark/emblems/8/emblem-locked.svg
  icons-dark/emblems/8/emblem-mounted.svg
  icons-dark/emblems/8/emblem-pause.svg
  icons-dark/emblems/8/emblem-question.svg
  icons-dark/emblems/8/emblem-remove.svg
  icons-dark/emblems/8/emblem-shared.svg
  icons-dark/emblems/8/emblem-symbolic-link.svg
  icons-dark/emblems/8/emblem-unavailable.svg
  icons-dark/emblems/8/emblem-unlocked.svg
  icons-dark/emblems/8/emblem-unmounted.svg
  icons-dark/emblems/8/emblem-warning.svg
  icons-dark/emblems/8/rating-unrated.svg
  icons-dark/emblems/8/rating.svg
  icons-dark/emblems/8/vcs-added.svg
  icons-dark/emblems/8/vcs-conflicting.svg
  icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/8/vcs-locally-modified.svg
  icons-dark/emblems/8/vcs-normal.svg
  icons-dark/emblems/8/vcs-removed.svg
  icons-dark/emblems/8/vcs-update-required.svg
  icons/emblems/16/checkmark.svg
  icons/emblems/16/emblem-added.svg
  icons/emblems/16/emblem-checked.svg
  icons/emblems/16/emblem-encrypted-unlocked.svg
  icons/emblems/16/emblem-error.svg
  icons/emblems/16/emblem-favorite.svg
  icons/emblems/16/emblem-important.svg
  icons/emblems/16/emblem-information.svg
  icons/emblems/16/emblem-locked.svg
  icons/emblems/16/emblem-mounted.svg
  icons/emblems/16/emblem-pause.svg
  icons/emblems/16/emblem-question.svg
  icons/emblems/16/emblem-remove.svg
  icons/emblems/16/emblem-shared.svg
  icons/emblems/16/emblem-success.svg
  icons/emblems/16/emblem-symbolic-link.svg
  icons/emblems/16/emblem-unavailable.svg
  icons/emblems/16/emblem-unlocked.svg
  icons/emblems/16/emblem-unmounted.svg
  icons/emblems/16/emblem-warning.svg
  icons/emblems/16/rating-unrated.svg
  icons/emblems/16/rating.svg
  icons/emblems/16/vcs-added.svg
  icons/emblems/16/vcs-conflicting.svg
  icons/emblems/16/vcs-

D16266: [Extractor] Make extractor crash resilient

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yeah go ahead I think.

REPOSITORY
  R293 Baloo

BRANCH
  mimetype_handling

REVISION DETAIL
  https://phabricator.kde.org/D16266

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: broulik, apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  In D16421#348516 , @ndavis wrote:
  
  > F6350488: Screenshot_20181025_100526.png 

  
  
  //Perfect!//

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#348513 , @bruns wrote:
  
  > The center link looks slightly too heavy, but imho still better. Might be 
possible to shave off 1/2 pixel from the link top/bottom. As its a solid area, 
it should not make it too fuzzy.
  
  
  Here is how that looks:
  F6350488: Screenshot_20181025_100526.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Stefan Brüns]

bruns added a comment.


  In D16421#348507 , @ndavis wrote:
  
  > In D16421#348504 , @bruns wrote:
  >
  > > In D16421#348502 , @ndavis 
wrote:
  > >
  > > > Also, here is the 22px version adjusted to have a similar shape to your 
suggested 16px version.
  > > >  F6350193: Screenshot_20181025_093800.png 

  > >
  > >
  > > Also better, but can you also try to make the center link full solid?
  >
  >
  > Here is how that looks:
  >  F6350381: Screenshot_20181025_095315.png 

  
  
  The center link looks slightly too heavy, but imho still better. Might be 
possible to shave off 1/2 pixel from the link top/bottom. As its a solid area, 
it should not make it too fuzzy.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  In D16421#348507 , @ndavis wrote:
  
  > F6350381: Screenshot_20181025_095315.png 

  
  
  Good! How about making the center link a tiny bit thinner? I'll look into the 
code in `KIconLoader` that positions the emblems to see why it's not getting 
centered.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis updated this revision to Diff 44210.
ndavis added a comment.


  Change style of emblem-symbolic-link

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16421?vs=44201&id=44210

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

AFFECTED FILES
  icons-dark/emblems/16/checkmark.svg
  icons-dark/emblems/16/emblem-added.svg
  icons-dark/emblems/16/emblem-checked.svg
  icons-dark/emblems/16/emblem-encrypted-unlocked.svg
  icons-dark/emblems/16/emblem-error.svg
  icons-dark/emblems/16/emblem-favorite.svg
  icons-dark/emblems/16/emblem-important.svg
  icons-dark/emblems/16/emblem-information.svg
  icons-dark/emblems/16/emblem-locked.svg
  icons-dark/emblems/16/emblem-mounted.svg
  icons-dark/emblems/16/emblem-pause.svg
  icons-dark/emblems/16/emblem-question.svg
  icons-dark/emblems/16/emblem-remove.svg
  icons-dark/emblems/16/emblem-shared.svg
  icons-dark/emblems/16/emblem-success.svg
  icons-dark/emblems/16/emblem-symbolic-link.svg
  icons-dark/emblems/16/emblem-unavailable.svg
  icons-dark/emblems/16/emblem-unlocked.svg
  icons-dark/emblems/16/emblem-unmounted.svg
  icons-dark/emblems/16/emblem-warning.svg
  icons-dark/emblems/16/rating-unrated.svg
  icons-dark/emblems/16/rating.svg
  icons-dark/emblems/16/vcs-added.svg
  icons-dark/emblems/16/vcs-conflicting.svg
  icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/16/vcs-locally-modified.svg
  icons-dark/emblems/16/vcs-normal.svg
  icons-dark/emblems/16/vcs-removed.svg
  icons-dark/emblems/16/vcs-update-required.svg
  icons-dark/emblems/22/checkmark.svg
  icons-dark/emblems/22/emblem-added.svg
  icons-dark/emblems/22/emblem-checked.svg
  icons-dark/emblems/22/emblem-encrypted-unlocked.svg
  icons-dark/emblems/22/emblem-error.svg
  icons-dark/emblems/22/emblem-favorite.svg
  icons-dark/emblems/22/emblem-important.svg
  icons-dark/emblems/22/emblem-information.svg
  icons-dark/emblems/22/emblem-locked.svg
  icons-dark/emblems/22/emblem-mounted.svg
  icons-dark/emblems/22/emblem-pause.svg
  icons-dark/emblems/22/emblem-question.svg
  icons-dark/emblems/22/emblem-remove.svg
  icons-dark/emblems/22/emblem-shared.svg
  icons-dark/emblems/22/emblem-success.svg
  icons-dark/emblems/22/emblem-symbolic-link.svg
  icons-dark/emblems/22/emblem-unavailable.svg
  icons-dark/emblems/22/emblem-unlocked.svg
  icons-dark/emblems/22/emblem-unmounted.svg
  icons-dark/emblems/22/emblem-warning.svg
  icons-dark/emblems/22/rating-unrated.svg
  icons-dark/emblems/22/rating.svg
  icons-dark/emblems/22/vcs-added.svg
  icons-dark/emblems/22/vcs-conflicting.svg
  icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/22/vcs-locally-modified.svg
  icons-dark/emblems/22/vcs-normal.svg
  icons-dark/emblems/22/vcs-removed.svg
  icons-dark/emblems/22/vcs-update-required.svg
  icons-dark/emblems/8/emblem-added.svg
  icons-dark/emblems/8/emblem-checked.svg
  icons-dark/emblems/8/emblem-encrypted-unlocked.svg
  icons-dark/emblems/8/emblem-error.svg
  icons-dark/emblems/8/emblem-favorite.svg
  icons-dark/emblems/8/emblem-important.svg
  icons-dark/emblems/8/emblem-information.svg
  icons-dark/emblems/8/emblem-locked.svg
  icons-dark/emblems/8/emblem-mounted.svg
  icons-dark/emblems/8/emblem-pause.svg
  icons-dark/emblems/8/emblem-question.svg
  icons-dark/emblems/8/emblem-remove.svg
  icons-dark/emblems/8/emblem-shared.svg
  icons-dark/emblems/8/emblem-symbolic-link.svg
  icons-dark/emblems/8/emblem-unavailable.svg
  icons-dark/emblems/8/emblem-unlocked.svg
  icons-dark/emblems/8/emblem-unmounted.svg
  icons-dark/emblems/8/emblem-warning.svg
  icons-dark/emblems/8/rating-unrated.svg
  icons-dark/emblems/8/rating.svg
  icons-dark/emblems/8/vcs-added.svg
  icons-dark/emblems/8/vcs-conflicting.svg
  icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/8/vcs-locally-modified.svg
  icons-dark/emblems/8/vcs-normal.svg
  icons-dark/emblems/8/vcs-removed.svg
  icons-dark/emblems/8/vcs-update-required.svg
  icons/emblems/16/checkmark.svg
  icons/emblems/16/emblem-added.svg
  icons/emblems/16/emblem-checked.svg
  icons/emblems/16/emblem-encrypted-unlocked.svg
  icons/emblems/16/emblem-error.svg
  icons/emblems/16/emblem-favorite.svg
  icons/emblems/16/emblem-important.svg
  icons/emblems/16/emblem-information.svg
  icons/emblems/16/emblem-locked.svg
  icons/emblems/16/emblem-mounted.svg
  icons/emblems/16/emblem-pause.svg
  icons/emblems/16/emblem-question.svg
  icons/emblems/16/emblem-remove.svg
  icons/emblems/16/emblem-shared.svg
  icons/emblems/16/emblem-success.svg
  icons/emblems/16/emblem-symbolic-link.svg
  icons/emblems/16/emblem-unavailable.svg
  icons/emblems/16/emblem-unlocked.svg
  icons/emblems/16/emblem-unmounted.svg
  icons/emblems/16/emblem-warning.svg
  icons/emblems/16/rating-unrated.svg
  icons/emblems/16/rating.svg
  icons/emblems/16/vcs-added.svg
  icons/emblems/16/vcs-conflicting.svg
  icons/emblems/16/vcs-locally-

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#348506 , @ngraham wrote:
  
  > In D16421#348502 , @ndavis wrote:
  >
  > > F6350185: Screenshot_20181025_093827.png 

  > >  F6350193: Screenshot_20181025_093800.png 

  >
  >
  > +1, those are excellent. I agree that the rectangle should be vertically 
centered on the same line as the other emblems. You can probably do this by 
giving the the link emblem's file the same dimensions as other emblems, but 
positioning the actual emblem itself vertically centered inside it. Also +1 to 
seeing if making the center link solid would look better for the larger sizes 
too.
  
  
  That is actually how it currently is, Dolphin or whatever is responsible for 
displaying the emblems just posisions the symlink emblem in a different way 
from the other emblems.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#348504 , @bruns wrote:
  
  > In D16421#348502 , @ndavis wrote:
  >
  > > In D16421#348487 , @bruns 
wrote:
  > >
  > > > Can you try the following:
  > > >
  > > > - Make the center link solid and narower (e.g. 2px height for the 16px 
one)
  > > > - Reduce the height of the right and left links
  > >
  > >
  > > Like this?
  > >  F6350185: Screenshot_20181025_093827.png 

  >
  >
  > I think this looks much better. Although, the link emblem should be 
positioned somewhat lower, centered relative to the checkmark emblem.
  
  
  I agree, but that's an issue with how the icon is displayed, not the icon 
itself. If I make the icon background take up the whole canvas, it will still 
be significantly off.
  
  > 
  > 
  >> Also, here is the 22px version adjusted to have a similar shape to your 
suggested 16px version.
  >>  F6350193: Screenshot_20181025_093800.png 

  > 
  > Also better, but can you also try to make the center link full solid?
  
  Here is how that looks:
  F6350381: Screenshot_20181025_095315.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  
  
  In D16421#348502 , @ndavis wrote:
  
  > F6350185: Screenshot_20181025_093827.png 

  >  F6350193: Screenshot_20181025_093800.png 

  
  
  +1, those are excellent. I agree that the rectangle should be vertically 
centered on the same line as the other emblems. You can probably do this by 
giving the the link emblem's file the same dimensions as other emblems, but 
positioning the actual emblem itself vertically centered inside it. Also +1 to 
seeing if making the center link solid would look better for the larger sizes 
too.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Stefan Brüns]

bruns added a comment.


  BTW, +1 for all the icons!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Stefan Brüns]

bruns added a comment.


  In D16421#348502 , @ndavis wrote:
  
  > In D16421#348487 , @bruns wrote:
  >
  > > Can you try the following:
  > >
  > > - Make the center link solid and narower (e.g. 2px height for the 16px 
one)
  > > - Reduce the height of the right and left links
  >
  >
  > Like this?
  >  F6350185: Screenshot_20181025_093827.png 

  
  
  I think this looks much better. Although, the link emblem should be 
positioned somewhat lower, centered relative to the checkmark emblem.
  
  > Also, here is the 22px version adjusted to have a similar shape to your 
suggested 16px version.
  >  F6350193: Screenshot_20181025_093800.png 

  
  Also better, but can you also try to make the center link full solid?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#348487 , @bruns wrote:
  
  > Can you try the following:
  >
  > - Make the center link solid and narower (e.g. 2px height for the 16px one)
  > - Reduce the height of the right and left links
  
  
  Like this?
  F6350185: Screenshot_20181025_093827.png 

  Also, here is the 22px version adjusted to have a similar shape to your 
suggested 16px version.
  F6350193: Screenshot_20181025_093800.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16166: Pass the FileIndexerConfig as const to the individual indexers

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:b62e76f6f8c1: Pass the FileIndexerConfig as const to the 
individual indexers (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16166?vs=43508&id=44209

REVISION DETAIL
  https://phabricator.kde.org/D16166

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/file/fileindexerconfig.h
  src/file/filtereddiriterator.cpp
  src/file/filtereddiriterator.h
  src/file/modifiedfileindexer.cpp
  src/file/modifiedfileindexer.h
  src/file/newfileindexer.cpp
  src/file/newfileindexer.h
  src/file/unindexedfileindexer.cpp
  src/file/unindexedfileindexer.h
  src/file/unindexedfileiterator.cpp
  src/file/unindexedfileiterator.h
  src/file/xattrindexer.cpp
  src/file/xattrindexer.h

To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure, broulik
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16166: Pass the FileIndexerConfig as const to the individual indexers

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  indexer_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D16166

To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure, broulik
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16166: Pass the FileIndexerConfig as const to the individual indexers

[Stefan Brüns]

bruns added a comment.


  Can someone give this a go - as said, only code cleanup ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16166

To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16266: [Extractor] Make extractor crash resilient

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added a comment.


  How about accepting this as-is, and postponing any enhancements to another 
patch?
  
  This has three benefits:
  
  1. no further delay
  2. it is bisectable in case some bug appears
  3. it is easy to spot how much code such a change requires

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16266

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: broulik, apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16421: Improve emblem contrast, legibility and consistency

[Stefan Brüns]

bruns added a comment.


  Can you try the following:
  
  - Make the center link solid and narower (e.g. 2px height for the 16px one)
  - Reduce the height of the right and left links

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D14948: Port scriptabletags to QJSEngine

[Allan Sandfeld Jensen]

carewolf added a comment.


  See https://github.com/steveire/grantlee/pull/44

REVISION DETAIL
  https://phabricator.kde.org/D14948

To: carewolf, dhaumann, skelly
Cc: vkrause, skelly, dhaumann, kde-frameworks-devel

D16412: Add the possibility to have a keyboard shortcut to create a file

[Thomas Surrel]

thsurrel marked 3 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16412

To: thsurrel, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D16412: Add the possibility to have a keyboard shortcut to create a file

[Thomas Surrel]

thsurrel updated this revision to Diff 44202.
thsurrel added a comment.


  Fixes as per elvisangelaccio
  Thank you very much for the review!

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16412?vs=44178&id=44202

BRANCH
  newfileshortcut (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16412

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp
  src/filewidgets/knewfilemenu.h

To: thsurrel, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  Here are what the changes look like:
  
  8px symlink emblem, 16px emblem-remove:
  F6349477: Screenshot_20181025_041309.png 

  Pretty crowded.
  
  16px symlink emblem, 16px emblem-remove:
  F6349480: Screenshot_20181025_041224.png 

  Still pretty crowded
  
  22px symlink emblem, 22px emblem-remove:
  F6349485: Screenshot_20181025_041121.png 

  It's OK I guess.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh, bruns

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis updated this revision to Diff 44201.
ndavis added a comment.


  Change emblem-remove color to Plasma Blue, Change style of 
emblem-symbolic-link

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16421?vs=44194&id=44201

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

AFFECTED FILES
  icons-dark/emblems/16/checkmark.svg
  icons-dark/emblems/16/emblem-added.svg
  icons-dark/emblems/16/emblem-checked.svg
  icons-dark/emblems/16/emblem-encrypted-unlocked.svg
  icons-dark/emblems/16/emblem-error.svg
  icons-dark/emblems/16/emblem-favorite.svg
  icons-dark/emblems/16/emblem-important.svg
  icons-dark/emblems/16/emblem-information.svg
  icons-dark/emblems/16/emblem-locked.svg
  icons-dark/emblems/16/emblem-mounted.svg
  icons-dark/emblems/16/emblem-pause.svg
  icons-dark/emblems/16/emblem-question.svg
  icons-dark/emblems/16/emblem-remove.svg
  icons-dark/emblems/16/emblem-shared.svg
  icons-dark/emblems/16/emblem-success.svg
  icons-dark/emblems/16/emblem-symbolic-link.svg
  icons-dark/emblems/16/emblem-unavailable.svg
  icons-dark/emblems/16/emblem-unlocked.svg
  icons-dark/emblems/16/emblem-unmounted.svg
  icons-dark/emblems/16/emblem-warning.svg
  icons-dark/emblems/16/rating-unrated.svg
  icons-dark/emblems/16/rating.svg
  icons-dark/emblems/16/vcs-added.svg
  icons-dark/emblems/16/vcs-conflicting.svg
  icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/16/vcs-locally-modified.svg
  icons-dark/emblems/16/vcs-normal.svg
  icons-dark/emblems/16/vcs-removed.svg
  icons-dark/emblems/16/vcs-update-required.svg
  icons-dark/emblems/22/checkmark.svg
  icons-dark/emblems/22/emblem-added.svg
  icons-dark/emblems/22/emblem-checked.svg
  icons-dark/emblems/22/emblem-encrypted-unlocked.svg
  icons-dark/emblems/22/emblem-error.svg
  icons-dark/emblems/22/emblem-favorite.svg
  icons-dark/emblems/22/emblem-important.svg
  icons-dark/emblems/22/emblem-information.svg
  icons-dark/emblems/22/emblem-locked.svg
  icons-dark/emblems/22/emblem-mounted.svg
  icons-dark/emblems/22/emblem-pause.svg
  icons-dark/emblems/22/emblem-question.svg
  icons-dark/emblems/22/emblem-remove.svg
  icons-dark/emblems/22/emblem-shared.svg
  icons-dark/emblems/22/emblem-success.svg
  icons-dark/emblems/22/emblem-symbolic-link.svg
  icons-dark/emblems/22/emblem-unavailable.svg
  icons-dark/emblems/22/emblem-unlocked.svg
  icons-dark/emblems/22/emblem-unmounted.svg
  icons-dark/emblems/22/emblem-warning.svg
  icons-dark/emblems/22/rating-unrated.svg
  icons-dark/emblems/22/rating.svg
  icons-dark/emblems/22/vcs-added.svg
  icons-dark/emblems/22/vcs-conflicting.svg
  icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/22/vcs-locally-modified.svg
  icons-dark/emblems/22/vcs-normal.svg
  icons-dark/emblems/22/vcs-removed.svg
  icons-dark/emblems/22/vcs-update-required.svg
  icons-dark/emblems/8/emblem-added.svg
  icons-dark/emblems/8/emblem-checked.svg
  icons-dark/emblems/8/emblem-encrypted-unlocked.svg
  icons-dark/emblems/8/emblem-error.svg
  icons-dark/emblems/8/emblem-favorite.svg
  icons-dark/emblems/8/emblem-important.svg
  icons-dark/emblems/8/emblem-information.svg
  icons-dark/emblems/8/emblem-locked.svg
  icons-dark/emblems/8/emblem-mounted.svg
  icons-dark/emblems/8/emblem-pause.svg
  icons-dark/emblems/8/emblem-question.svg
  icons-dark/emblems/8/emblem-remove.svg
  icons-dark/emblems/8/emblem-shared.svg
  icons-dark/emblems/8/emblem-symbolic-link.svg
  icons-dark/emblems/8/emblem-unavailable.svg
  icons-dark/emblems/8/emblem-unlocked.svg
  icons-dark/emblems/8/emblem-unmounted.svg
  icons-dark/emblems/8/emblem-warning.svg
  icons-dark/emblems/8/rating-unrated.svg
  icons-dark/emblems/8/rating.svg
  icons-dark/emblems/8/vcs-added.svg
  icons-dark/emblems/8/vcs-conflicting.svg
  icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/8/vcs-locally-modified.svg
  icons-dark/emblems/8/vcs-normal.svg
  icons-dark/emblems/8/vcs-removed.svg
  icons-dark/emblems/8/vcs-update-required.svg
  icons/emblems/16/checkmark.svg
  icons/emblems/16/emblem-added.svg
  icons/emblems/16/emblem-checked.svg
  icons/emblems/16/emblem-encrypted-unlocked.svg
  icons/emblems/16/emblem-error.svg
  icons/emblems/16/emblem-favorite.svg
  icons/emblems/16/emblem-important.svg
  icons/emblems/16/emblem-information.svg
  icons/emblems/16/emblem-locked.svg
  icons/emblems/16/emblem-mounted.svg
  icons/emblems/16/emblem-pause.svg
  icons/emblems/16/emblem-question.svg
  icons/emblems/16/emblem-remove.svg
  icons/emblems/16/emblem-shared.svg
  icons/emblems/16/emblem-success.svg
  icons/emblems/16/emblem-symbolic-link.svg
  icons/emblems/16/emblem-unavailable.svg
  icons/emblems/16/emblem-unlocked.svg
  icons/emblems/16/emblem-unmounted.svg
  icons/emblems/16/emblem-warning.svg
  icons/emblems/16/rating-unrated.svg
  icons/emblems/16/rating.svg
  icons/emblems/16/vcs-added.svg
  icons/emblems/16/vcs-con