D15645: Add scheme selection menu with a "System" entry.

2018-10-27 Thread Pino Toscano 
pino requested changes to this revision.
pino added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcolorschememanager.cpp:52
> +QAction *const resetAction = new 
> QAction(index.data(Qt::DecorationRole).value(),
> + i18n("Default 
> (%0)").arg(systemScheme),
> + menu);

- not the correct way to pass arguments to i18n -- they are extra parameters to 
the i18n function itself
- even if %0 is supported, usually the first argument is %1

> kcolorschememanager.h:127
> + */
> +KActionMenu *createSchemeSelectionMenuWithDefaultEntry(const QIcon 
> , const QString , const QString , QObject 
> *parent);
> +

instead of a custom variant, what about creating new versions of the 
`createSchemeSelectionMenu` functions that take flags instead?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D15645

To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham, pino
Cc: pino, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15645: Add scheme selection menu with a "System" entry.

2018-10-27 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks, that lets it compile. I'm feeling a bit stupid right now, so could 
you help me figure out what's needed to test this? `kcolorschemedemo.cpp` does 
not actually seem to build an executable. Regardless, wouldn't it make sense to 
expose this new feature in the existing Settings > Color Theme menu? Or are you 
planning to do that in another patch?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D15645

To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham
Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D16471: [RFC] Listen for added DBus interfaces instead of registered services

2018-10-27 Thread Fabian Vogt 
fvogt updated this revision to Diff 44334.
fvogt added a comment.


  Fix bad merge

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16471?vs=44332=44334

BRANCH
  ifadded

REVISION DETAIL
  https://phabricator.kde.org/D16471

AFFECTED FILES
  src/manager.cpp
  src/manager_p.h
  src/secretagent.cpp
  src/secretagent.h
  src/secretagent_p.h

To: fvogt, #frameworks, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16471: [RFC] Listen for added DBus interfaces instead of registered services

2018-10-27 Thread Fabian Vogt 
fvogt created this revision.
fvogt added reviewers: Frameworks, jgrulich.
Herald added a project: Frameworks.
fvogt requested review of this revision.

REVISION SUMMARY
  When the service is registered, the interfaces might not be available yet.
  So wait for those instead.
  
  BUG: 400359
  
  This is RFC because:
  
  - I'm not sure whether it's guaranteed that InterfacesAdded is emitted on 
service registration as well or both connections are necessary
  - I don't know how it's possible to test this as org.kde.fakenetwork does not 
support the org.freedesktop.ObjectManager API

TEST PLAN
  Restarting NM while kded5 keeps running caused "nmcli up" to fail because of
  missing secrets.
  With this patch, it works successfully.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  ifadded

REVISION DETAIL
  https://phabricator.kde.org/D16471

AFFECTED FILES
  src/manager.cpp
  src/manager_p.h
  src/secretagent.cpp
  src/secretagent.h
  src/secretagent_p.h

To: fvogt, #frameworks, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16464: [KSambaShare] Trim trailing / from share path

2018-10-27 Thread Stefan Brüns 
bruns edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16464

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16465: [KSambaShare] Make "net usershare info" parser testable

2018-10-27 Thread Stefan Brüns 
bruns retitled this revision from "[KSambaShare] Make "net usershare list" 
parser testable" to "[KSambaShare] Make "net usershare info" parser testable".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16465

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16466: [KSambaShare] Add unit test for "net usershare info" parser

2018-10-27 Thread Stefan Brüns 
bruns retitled this revision from "[KSambaShare] Add unit test for "net 
usershare list" parser" to "[KSambaShare] Add unit test for "net usershare 
info" parser".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16466

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16465: [KSambaShare] Make "net usershare list" parser testable

2018-10-27 Thread Stefan Brüns 
bruns added a dependent revision: D16466: [KSambaShare] Add unit test for "net 
usershare list" parser.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16465

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16464: [KSambaShare] Trim trailing / from share path

2018-10-27 Thread Stefan Brüns 
bruns added a dependent revision: D16466: [KSambaShare] Add unit test for "net 
usershare list" parser.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16464

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16466: [KSambaShare] Add unit test for "net usershare list" parser

2018-10-27 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The existing tests depend on the runtime environment, i.e. they read
  the share list from the developers usershares. In case the account
  has no usershares, the parser is not tested.
  
  Inject some test data for several test cases into the parser.
  
  As the KSambaSharePrivate::parse() method is not visible from the
  shared library by default, link statically to it.
  
  Depends on D16464 
  Depends on D16465 

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  net_usershare

REVISION DETAIL
  https://phabricator.kde.org/D16466

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/ksambashareprivatetest.cpp
  autotests/ksambashareprivatetest.h

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16465: [KSambaShare] Make "net usershare list" parser testable

2018-10-27 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  KSambaSharePrivate::sync() reads from the runtime environment of the user
  and modifies the the share list in place.
  
  Split out the parser part, and create a fresh share list from the input,
  which replaces the old list after parsing.

TEST PLAN
  make && ctest
  no functional changes

REPOSITORY
  R241 KIO

BRANCH
  net_usershare

REVISION DETAIL
  https://phabricator.kde.org/D16465

AFFECTED FILES
  src/core/ksambashare.cpp
  src/core/ksambashare_p.h

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16464: [KSambaShare] Trim trailing / from share path

2018-10-27 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  When adding usershares manually on the command line, it is common to
  have a path with trailing "/" due to tab completion. Samba treats paths
  with and without / the same, but KIO does not pick up these shares.
  
  These folder paths are not marked in e.g. dolphin as shared and can not
  be edited properly.

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  net_usershare

REVISION DETAIL
  https://phabricator.kde.org/D16464

AFFECTED FILES
  src/core/ksambashare.cpp

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

2018-10-27 Thread Chinmoy Ranjan Pradhan 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129983/
---

(Updated Oct. 27, 2018, 4:38 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks, David Faure and Elvis Angelaccio.


Repository: kio


Description
---

This is regarding the GSOC idea 
https://community.kde.org/GSoC/2017/Ideas#Project:_Polkit_support_in_KIO.

This patch intends to demonstrate one possible approach to provide polkit 
support in kio. Here its only for the delete operation. This is based on the 
patch in task https://phabricator.kde.org/T5070.

The approach is as follows;
1. Whenever file ioslave gets access denied error it calls the method 
*execWithRoot* with the action that requires priviledge, the path of items
   upon which action needs to be performed and a warning ID as arguments.
2. *execWithRoot* then executes the KAuth::Action *org.kde.kio.file.execute*. 
3. This Kauth::Action has its Persistence set too 'session'. This means that 
after authentication the restrictions are dropped for a while, for
   about 5 minutes. This is similar to the behaviour of sudo command.
4. During this time we can perform any action as a privileged user without any 
authentication. So to prevent any mishap i added a warning box which
   would popup before performing any action(only during this period).
5. After the said time interval the root privileges are droped and calling 
*execWithRoot* should show the usual authentication dialog.


Diffs
-

  src/ioslaves/file/CMakeLists.txt b9132ce 
  src/ioslaves/file/file.h 109ea80 
  src/ioslaves/file/file.cpp eaf6c88 
  src/ioslaves/file/file_unix.cpp 82eb11a 
  src/ioslaves/file/kauth/CMakeLists.txt PRE-CREATION 
  src/ioslaves/file/kauth/file.actions PRE-CREATION 
  src/ioslaves/file/kauth/helper.h PRE-CREATION 
  src/ioslaves/file/kauth/helper.cpp PRE-CREATION 


Diff: https://git.reviewboard.kde.org/r/129983/diff/6/


Testing
---


File Attachments


warning dialog
  
https://git.reviewboard.kde.org/media/uploaded/files/2017/03/09/d42570e8-aedf-4c02-801e-362a68755c2c__polkit_integration.png


Thanks,

Chinmoy Ranjan Pradhan

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis 
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis 
ndavis added a comment.


  In D16421#349331 , @ngraham wrote:
  
  > Thanks for the updates. I know it's a PITA, but would you mind updating the 
image in the Summary section?
  
  
  Done.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis 
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis 
ndavis updated this revision to Diff 44313.
ndavis added a comment.


  Add 16 and 22 px versions of previous change

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16421?vs=44308=44313

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

AFFECTED FILES
  icons-dark/emblems/16/checkmark.svg
  icons-dark/emblems/16/emblem-added.svg
  icons-dark/emblems/16/emblem-checked.svg
  icons-dark/emblems/16/emblem-encrypted-locked.svg
  icons-dark/emblems/16/emblem-encrypted-unlocked.svg
  icons-dark/emblems/16/emblem-error.svg
  icons-dark/emblems/16/emblem-favorite.svg
  icons-dark/emblems/16/emblem-important.svg
  icons-dark/emblems/16/emblem-information.svg
  icons-dark/emblems/16/emblem-locked.svg
  icons-dark/emblems/16/emblem-mounted.svg
  icons-dark/emblems/16/emblem-pause.svg
  icons-dark/emblems/16/emblem-question.svg
  icons-dark/emblems/16/emblem-remove.svg
  icons-dark/emblems/16/emblem-shared.svg
  icons-dark/emblems/16/emblem-success.svg
  icons-dark/emblems/16/emblem-symbolic-link.svg
  icons-dark/emblems/16/emblem-unavailable.svg
  icons-dark/emblems/16/emblem-unlocked.svg
  icons-dark/emblems/16/emblem-unmounted.svg
  icons-dark/emblems/16/emblem-warning.svg
  icons-dark/emblems/16/rating-unrated.svg
  icons-dark/emblems/16/rating.svg
  icons-dark/emblems/16/vcs-added.svg
  icons-dark/emblems/16/vcs-conflicting.svg
  icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/16/vcs-locally-modified.svg
  icons-dark/emblems/16/vcs-normal.svg
  icons-dark/emblems/16/vcs-removed.svg
  icons-dark/emblems/16/vcs-update-required.svg
  icons-dark/emblems/22/checkmark.svg
  icons-dark/emblems/22/emblem-added.svg
  icons-dark/emblems/22/emblem-checked.svg
  icons-dark/emblems/22/emblem-encrypted-locked.svg
  icons-dark/emblems/22/emblem-encrypted-unlocked.svg
  icons-dark/emblems/22/emblem-error.svg
  icons-dark/emblems/22/emblem-favorite.svg
  icons-dark/emblems/22/emblem-important.svg
  icons-dark/emblems/22/emblem-information.svg
  icons-dark/emblems/22/emblem-locked.svg
  icons-dark/emblems/22/emblem-mounted.svg
  icons-dark/emblems/22/emblem-pause.svg
  icons-dark/emblems/22/emblem-question.svg
  icons-dark/emblems/22/emblem-remove.svg
  icons-dark/emblems/22/emblem-shared.svg
  icons-dark/emblems/22/emblem-success.svg
  icons-dark/emblems/22/emblem-symbolic-link.svg
  icons-dark/emblems/22/emblem-unavailable.svg
  icons-dark/emblems/22/emblem-unlocked.svg
  icons-dark/emblems/22/emblem-unmounted.svg
  icons-dark/emblems/22/emblem-warning.svg
  icons-dark/emblems/22/rating-unrated.svg
  icons-dark/emblems/22/rating.svg
  icons-dark/emblems/22/vcs-added.svg
  icons-dark/emblems/22/vcs-conflicting.svg
  icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/22/vcs-locally-modified.svg
  icons-dark/emblems/22/vcs-normal.svg
  icons-dark/emblems/22/vcs-removed.svg
  icons-dark/emblems/22/vcs-update-required.svg
  icons-dark/emblems/8/emblem-added.svg
  icons-dark/emblems/8/emblem-checked.svg
  icons-dark/emblems/8/emblem-encrypted-locked.svg
  icons-dark/emblems/8/emblem-encrypted-unlocked.svg
  icons-dark/emblems/8/emblem-error.svg
  icons-dark/emblems/8/emblem-favorite.svg
  icons-dark/emblems/8/emblem-important.svg
  icons-dark/emblems/8/emblem-information.svg
  icons-dark/emblems/8/emblem-locked.svg
  icons-dark/emblems/8/emblem-mounted.svg
  icons-dark/emblems/8/emblem-pause.svg
  icons-dark/emblems/8/emblem-question.svg
  icons-dark/emblems/8/emblem-remove.svg
  icons-dark/emblems/8/emblem-shared.svg
  icons-dark/emblems/8/emblem-symbolic-link.svg
  icons-dark/emblems/8/emblem-unavailable.svg
  icons-dark/emblems/8/emblem-unlocked.svg
  icons-dark/emblems/8/emblem-unmounted.svg
  icons-dark/emblems/8/emblem-warning.svg
  icons-dark/emblems/8/rating-unrated.svg
  icons-dark/emblems/8/rating.svg
  icons-dark/emblems/8/vcs-added.svg
  icons-dark/emblems/8/vcs-conflicting.svg
  icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/8/vcs-locally-modified.svg
  icons-dark/emblems/8/vcs-normal.svg
  icons-dark/emblems/8/vcs-removed.svg
  icons-dark/emblems/8/vcs-update-required.svg
  icons/emblems/16/checkmark.svg
  icons/emblems/16/emblem-added.svg
  icons/emblems/16/emblem-checked.svg
  icons/emblems/16/emblem-encrypted-locked.svg
  icons/emblems/16/emblem-encrypted-unlocked.svg
  icons/emblems/16/emblem-error.svg
  icons/emblems/16/emblem-favorite.svg
  icons/emblems/16/emblem-important.svg
  icons/emblems/16/emblem-information.svg
  icons/emblems/16/emblem-locked.svg
  icons/emblems/16/emblem-mounted.svg
  icons/emblems/16/emblem-pause.svg
  icons/emblems/16/emblem-question.svg
  icons/emblems/16/emblem-remove.svg
  icons/emblems/16/emblem-shared.svg
  icons/emblems/16/emblem-success.svg
  icons/emblems/16/emblem-symbolic-link.svg
  icons/emblems/16/emblem-unavailable.svg
  icons/emblems/16/emblem-unlocked.svg
  icons/emblems/16/emblem-unmounted.svg

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.9 - Build # 189 - Fixed!

2018-10-27 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.9/189/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 27 Oct 2018 15:31:29 +
 Build duration:
6 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)80%
(33/41)80%
(33/41)79%
(2637/3356)66%
(1865/2814)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)91%
(655/719)59%
(434/730)examples0%
(0/2)0%
(0/2)0%
(0/193)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/89)0%
(0/40)src.indexer100%
(1/1)100%
(1/1)76%
(223/293)77%
(212/276)src.lib90%
(26/29)90%
(26/29)85%
(1759/2062)73%
(1219/1670)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 245 - Fixed!

2018-10-27 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/245/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 27 Oct 2018 15:31:29 +
 Build duration:
2 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)80%
(33/41)80%
(33/41)79%
(2637/3356)66%
(1865/2814)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)91%
(655/719)59%
(434/730)examples0%
(0/2)0%
(0/2)0%
(0/193)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/89)0%
(0/40)src.indexer100%
(1/1)100%
(1/1)76%
(223/293)77%
(212/276)src.lib90%
(26/29)90%
(26/29)85%
(1759/2062)73%
(1219/1670)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.9 - Build # 188 - Still Failing!

2018-10-27 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.9/188/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 27 Oct 2018 15:15:30 +
 Build duration:
2 min 43 sec and counting
   CONSOLE OUTPUT
  [...truncated 120.86 KB...][ 37%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/wildcardmatcher.cpp.o[ 38%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/themedata.cpp.o[ 40%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/ECMQmLoader-syntaxhighlighting5_qt.cpp.o[ 41%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/ksyntaxhighlighting_logging.cpp.o[ 42%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/KF5SyntaxHighlighting_autogen/mocs_compilation.cpp.o[ 44%] Linking CXX shared library ../../bin/libKF5SyntaxHighlighting.so[ 44%] Built target KF5SyntaxHighlightingScanning dependencies of target kate-syntax-highlighter_autogenScanning dependencies of target testhighlighter_test_autogenScanning dependencies of target codeeditor_autogenScanning dependencies of target highlighter_benchmark_autogenScanning dependencies of target repository_benchmark_autogenScanning dependencies of target syntaxrepository_test_autogen[ 45%] Automatic MOC for target kate-syntax-highlighter[ 46%] Automatic MOC for target codeeditor[ 48%] Automatic MOC for target testhighlighter_test[ 49%] Automatic MOC for target repository_benchmark[ 50%] Automatic MOC for target highlighter_benchmark[ 52%] Automatic MOC for target syntaxrepository_test[ 52%] Built target kate-syntax-highlighter_autogenScanning dependencies of target wildcardmatcher_test_autogen[ 53%] Automatic MOC for target wildcardmatcher_test[ 53%] Built target repository_benchmark_autogen[ 53%] Built target highlighter_benchmark_autogen[ 53%] Built target codeeditor_autogen[ 53%] Built target syntaxrepository_test_autogen[ 53%] Built target testhighlighter_test_autogenScanning dependencies of target theme_test_autogenScanning dependencies of target htmlhighlighter_test_autogenScanning dependencies of target folding_test_autogen[ 54%] Automatic MOC for target htmlhighlighter_testScanning dependencies of target kate-syntax-highlighter[ 56%] Automatic MOC for target theme_testScanning dependencies of target codeeditor[ 57%] Automatic MOC for target folding_test[ 58%] Building CXX object src/cli/CMakeFiles/kate-syntax-highlighter.dir/kate-syntax-highlighter.cpp.o[ 60%] Building CXX object examples/CMakeFiles/codeeditor.dir/codeeditor.cpp.o[ 60%] Built target wildcardmatcher_test_autogen[ 61%] Building CXX object examples/CMakeFiles/codeeditor.dir/main.cpp.o[ 61%] Built target folding_test_autogen[ 61%] Built target htmlhighlighter_test_autogen[ 61%] Built target theme_test_autogen[ 62%] Building CXX object examples/CMakeFiles/codeeditor.dir/codeeditor_autogen/mocs_compilation.cpp.oScanning dependencies of target repository_benchmark[ 64%] Building CXX object src/cli/CMakeFiles/kate-syntax-highlighter.dir/kate-syntax-highlighter_autogen/mocs_compilation.cpp.o[ 65%] Building CXX object autotests/CMakeFiles/repository_benchmark.dir/repository_benchmark.cpp.oScanning dependencies of target highlighter_benchmark[ 66%] Building CXX object autotests/CMakeFiles/highlighter_benchmark.dir/highlighter_benchmark.cpp.o[ 68%] Linking CXX executable ../../bin/kate-syntax-highlighter[ 68%] Built target kate-syntax-highlighter[ 69%] Building CXX object autotests/CMakeFiles/highlighter_benchmark.dir/highlighter_benchmark_autogen/mocs_compilation.cpp.oScanning dependencies of target syntaxrepository_test[ 70%] Building CXX object autotests/CMakeFiles/syntaxrepository_test.dir/syntaxrepository_test.cpp.oScanning dependencies of target testhighlighter_test[ 72%] Building CXX object autotests/CMakeFiles/testhighlighter_test.dir/testhighlighter.cpp.oScanning dependencies of target wildcardmatcher_test[ 73%] Building CXX object autotests/CMakeFiles/wildcardmatcher_test.dir/wildcardmatcher_test.cpp.o[ 74%] Linking CXX executable ../bin/highlighter_benchmark[ 76%] Building CXX object autotests/CMakeFiles/repository_benchmark.dir/repository_benchmark_autogen/mocs_compilation.cpp.o[ 77%] Linking CXX executable ../bin/codeeditor[ 78%] Linking CXX executable ../bin/repository_benchmark[ 78%] Built target highlighter_benchmark[ 80%] Building CXX object autotests/CMakeFiles/testhighlighter_test.dir/testhighlighter_test_autogen/mocs_compilation.cpp.o[ 80%] Built target codeeditor[ 80%] Built target repository_benchmarkScanning dependencies of target theme_test[ 81%] Building CXX object autotests/CMakeFiles/wildcardmatcher_test.dir/__/src/lib/wildcardmatcher.cpp.o[ 82%] Building CXX object autotests/CMakeFiles/wildcardmatcher_test.dir/wildcardmatcher_test_autogen/mocs_compilation.cpp.o[ 84%] Building CXX object autotests/CMakeFiles/theme_test.dir/theme_test.cpp.o[ 85%] Building CXX object

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-10-27 Thread Christoph Cullmann 
cullmann added a comment.


  I merged that now.
  
  I bumped the version + required kate version
  
  Git commit f2c29ec618da08ebe9d17ff739e8b12bf3c33fff 
 by 
Christoph Cullmann.
  Committed on 27/10/2018 at 15:14.
  Pushed by cullmann into branch 'master'.
  
  inc version + fixup required kate version to current framework version
  
  M  +1-1data/syntax/scss.xml
  
  
https://commits.kde.org/syntax-highlighting/f2c29ec618da08ebe9d17ff739e8b12bf3c33fff
  
  diff --git a/data/syntax/scss.xml b/data/syntax/scss.xml
  index 1f472aa..2968868 100644
  
  - a/data/syntax/scss.xml
  
  +++ b/data/syntax/scss.xml
  @@ -34,7 +34,7 @@ Changelog:
  
  -->
  
  -
  +

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann, vkrause
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 244 - Still Failing!

2018-10-27 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/244/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 27 Oct 2018 15:15:04 +
 Build duration:
46 sec and counting
   CONSOLE OUTPUT
  [...truncated 116.24 KB...][ 29%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/keywordlist.cpp.o[ 30%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/definition.cpp.o[ 32%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/repository.cpp.o[ 33%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/state.cpp.o[ 34%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/syntaxhighlighter.cpp.o[ 36%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/theme.cpp.o[ 37%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/wildcardmatcher.cpp.o[ 38%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/themedata.cpp.o[ 40%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/ECMQmLoader-syntaxhighlighting5_qt.cpp.o[ 41%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/ksyntaxhighlighting_logging.cpp.o[ 42%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/KF5SyntaxHighlighting_autogen/mocs_compilation.cpp.o[ 44%] Linking CXX shared library ../../bin/libKF5SyntaxHighlighting.so[ 44%] Built target KF5SyntaxHighlightingScanning dependencies of target kate-syntax-highlighter_autogenScanning dependencies of target testhighlighter_test_autogenScanning dependencies of target repository_benchmark_autogenScanning dependencies of target highlighter_benchmark_autogenScanning dependencies of target syntaxrepository_test_autogenScanning dependencies of target codeeditor_autogenScanning dependencies of target wildcardmatcher_test_autogenScanning dependencies of target theme_test_autogenScanning dependencies of target htmlhighlighter_test_autogen[ 45%] Automatic MOC for target testhighlighter_test[ 46%] Automatic MOC for target kate-syntax-highlighter[ 48%] Automatic MOC for target repository_benchmark[ 49%] Automatic MOC for target syntaxrepository_test[ 50%] Automatic MOC for target codeeditor[ 52%] Automatic MOC for target highlighter_benchmark[ 53%] Automatic MOC for target htmlhighlighter_test[ 54%] Automatic MOC for target theme_test[ 56%] Automatic MOC for target wildcardmatcher_test[ 56%] Built target kate-syntax-highlighter_autogenScanning dependencies of target folding_test_autogen[ 57%] Automatic MOC for target folding_test[ 57%] Built target testhighlighter_test_autogen[ 57%] Built target repository_benchmark_autogen[ 57%] Built target highlighter_benchmark_autogen[ 57%] Built target htmlhighlighter_test_autogenScanning dependencies of target kate-syntax-highlighter[ 57%] Built target theme_test_autogen[ 57%] Built target syntaxrepository_test_autogen[ 57%] Built target codeeditor_autogen[ 57%] Built target wildcardmatcher_test_autogen[ 58%] Building CXX object src/cli/CMakeFiles/kate-syntax-highlighter.dir/kate-syntax-highlighter.cpp.o[ 60%] Building CXX object src/cli/CMakeFiles/kate-syntax-highlighter.dir/kate-syntax-highlighter_autogen/mocs_compilation.cpp.oScanning dependencies of target highlighter_benchmarkScanning dependencies of target repository_benchmarkScanning dependencies of target testhighlighter_testScanning dependencies of target htmlhighlighter_testScanning dependencies of target theme_testScanning dependencies of target syntaxrepository_test[ 61%] Building CXX object autotests/CMakeFiles/repository_benchmark.dir/repository_benchmark.cpp.o[ 62%] Building CXX object autotests/CMakeFiles/highlighter_benchmark.dir/highlighter_benchmark.cpp.o[ 64%] Building CXX object autotests/CMakeFiles/htmlhighlighter_test.dir/htmlhighlighter_test.cpp.o[ 65%] Building CXX object autotests/CMakeFiles/testhighlighter_test.dir/testhighlighter.cpp.o[ 66%] Building CXX object autotests/CMakeFiles/theme_test.dir/theme_test.cpp.o[ 68%] Building CXX object autotests/CMakeFiles/syntaxrepository_test.dir/syntaxrepository_test.cpp.oScanning dependencies of target codeeditor[ 68%] Built target folding_test_autogen[ 69%] Building CXX object examples/CMakeFiles/codeeditor.dir/codeeditor.cpp.o[ 70%] Building CXX object examples/CMakeFiles/codeeditor.dir/main.cpp.o[ 72%] Linking CXX executable ../../bin/kate-syntax-highlighterIn file included from /usr/include/qt5/QtTest/qtest.h:45, from /home/jenkins/workspace/Frameworks/syntax-highlighting/kf5-qt5 SUSEQt5.10/build/autotests/test-config.h:29, from /home/jenkins/workspace/Frameworks/syntax-highlighting/kf5-qt5 SUSEQt5.10/autotests/syntaxrepository_test.cpp:24:/home/jenkins/workspace/Frameworks/syntax-highlighting/kf5-qt5 SUSEQt5.10/autotests/syntaxrepository_test.cpp: In member function ���void

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.9 - Build # 187 - Failure!

2018-10-27 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.9/187/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 27 Oct 2018 15:12:34 +
 Build duration:
2 min 55 sec and counting
   CONSOLE OUTPUT
  [...truncated 121.28 KB...][ 38%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/themedata.cpp.o[ 40%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/ECMQmLoader-syntaxhighlighting5_qt.cpp.o[ 41%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/ksyntaxhighlighting_logging.cpp.o[ 42%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/KF5SyntaxHighlighting_autogen/mocs_compilation.cpp.o[ 44%] Linking CXX shared library ../../bin/libKF5SyntaxHighlighting.so[ 44%] Built target KF5SyntaxHighlightingScanning dependencies of target kate-syntax-highlighter_autogenScanning dependencies of target codeeditor_autogenScanning dependencies of target highlighter_benchmark_autogenScanning dependencies of target repository_benchmark_autogenScanning dependencies of target testhighlighter_test_autogenScanning dependencies of target syntaxrepository_test_autogen[ 45%] Automatic MOC for target kate-syntax-highlighter[ 46%] Automatic MOC for target codeeditor[ 48%] Automatic MOC for target highlighter_benchmark[ 49%] Automatic MOC for target repository_benchmark[ 52%] Automatic MOC for target testhighlighter_test[ 52%] Automatic MOC for target syntaxrepository_test[ 52%] Built target kate-syntax-highlighter_autogenScanning dependencies of target wildcardmatcher_test_autogen[ 53%] Automatic MOC for target wildcardmatcher_test[ 53%] Built target codeeditor_autogen[ 53%] Built target highlighter_benchmark_autogenScanning dependencies of target theme_test_autogenScanning dependencies of target htmlhighlighter_test_autogen[ 53%] Built target testhighlighter_test_autogen[ 53%] Built target syntaxrepository_test_autogen[ 53%] Built target repository_benchmark_autogen[ 54%] Automatic MOC for target theme_test[ 56%] Automatic MOC for target htmlhighlighter_testScanning dependencies of target folding_test_autogenScanning dependencies of target kate-syntax-highlighter[ 57%] Automatic MOC for target folding_testScanning dependencies of target codeeditor[ 58%] Building CXX object src/cli/CMakeFiles/kate-syntax-highlighter.dir/kate-syntax-highlighter.cpp.o[ 60%] Building CXX object examples/CMakeFiles/codeeditor.dir/codeeditor.cpp.o[ 60%] Built target wildcardmatcher_test_autogen[ 61%] Building CXX object examples/CMakeFiles/codeeditor.dir/main.cpp.o[ 61%] Built target htmlhighlighter_test_autogen[ 61%] Built target theme_test_autogen[ 62%] Building CXX object src/cli/CMakeFiles/kate-syntax-highlighter.dir/kate-syntax-highlighter_autogen/mocs_compilation.cpp.o[ 64%] Building CXX object examples/CMakeFiles/codeeditor.dir/codeeditor_autogen/mocs_compilation.cpp.o[ 64%] Built target folding_test_autogenScanning dependencies of target repository_benchmarkScanning dependencies of target highlighter_benchmark[ 65%] Building CXX object autotests/CMakeFiles/repository_benchmark.dir/repository_benchmark.cpp.o[ 66%] Building CXX object autotests/CMakeFiles/highlighter_benchmark.dir/highlighter_benchmark.cpp.o[ 68%] Linking CXX executable ../../bin/kate-syntax-highlighter[ 68%] Built target kate-syntax-highlighter[ 69%] Building CXX object autotests/CMakeFiles/highlighter_benchmark.dir/highlighter_benchmark_autogen/mocs_compilation.cpp.oScanning dependencies of target syntaxrepository_test[ 70%] Building CXX object autotests/CMakeFiles/repository_benchmark.dir/repository_benchmark_autogen/mocs_compilation.cpp.o[ 72%] Building CXX object autotests/CMakeFiles/syntaxrepository_test.dir/syntaxrepository_test.cpp.oScanning dependencies of target testhighlighter_test[ 73%] Building CXX object autotests/CMakeFiles/testhighlighter_test.dir/testhighlighter.cpp.o[ 74%] Building CXX object autotests/CMakeFiles/syntaxrepository_test.dir/syntaxrepository_test_autogen/mocs_compilation.cpp.o[ 76%] Building CXX object autotests/CMakeFiles/testhighlighter_test.dir/testhighlighter_test_autogen/mocs_compilation.cpp.oScanning dependencies of target wildcardmatcher_test[ 77%] Building CXX object autotests/CMakeFiles/wildcardmatcher_test.dir/wildcardmatcher_test.cpp.o[ 78%] Linking CXX executable ../bin/repository_benchmark[ 80%] Linking CXX executable ../bin/codeeditor[ 81%] Linking CXX executable ../bin/highlighter_benchmark[ 81%] Built target repository_benchmark[ 81%] Built target codeeditor[ 82%] Building CXX object autotests/CMakeFiles/wildcardmatcher_test.dir/__/src/lib/wildcardmatcher.cpp.o[ 82%] Built target highlighter_benchmarkScanning dependencies of target theme_test[ 84%] Building CXX object autotests/CMakeFiles/wildcardmatcher_test.dir/wildcardmatcher_test_autogen/mocs_compilation.cpp.o[ 85%] Building CXX object autotests/CMakeFiles/theme_test.dir/theme_test.cpp.oScanning dependencies of target

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 243 - Failure!

2018-10-27 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/243/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 27 Oct 2018 15:12:34 +
 Build duration:
50 sec and counting
   CONSOLE OUTPUT
  [...truncated 121.33 KB...][ 44%] Built target KF5SyntaxHighlightingScanning dependencies of target htmlhighlighter_test_autogenScanning dependencies of target codeeditor_autogenScanning dependencies of target kate-syntax-highlighter_autogenScanning dependencies of target repository_benchmark_autogenScanning dependencies of target highlighter_benchmark_autogenScanning dependencies of target syntaxrepository_test_autogenScanning dependencies of target theme_test_autogenScanning dependencies of target testhighlighter_test_autogenScanning dependencies of target wildcardmatcher_test_autogen[ 45%] Automatic MOC for target htmlhighlighter_test[ 46%] Automatic MOC for target codeeditor[ 48%] Automatic MOC for target testhighlighter_test[ 49%] Automatic MOC for target repository_benchmark[ 50%] Automatic MOC for target highlighter_benchmark[ 53%] Automatic MOC for target kate-syntax-highlighter[ 53%] Automatic MOC for target syntaxrepository_test[ 54%] Automatic MOC for target theme_test[ 56%] Automatic MOC for target wildcardmatcher_test[ 56%] Built target kate-syntax-highlighter_autogenScanning dependencies of target folding_test_autogen[ 57%] Automatic MOC for target folding_test[ 57%] Built target wildcardmatcher_test_autogen[ 57%] Built target htmlhighlighter_test_autogen[ 57%] Built target highlighter_benchmark_autogen[ 57%] Built target theme_test_autogen[ 57%] Built target testhighlighter_test_autogen[ 57%] Built target repository_benchmark_autogen[ 57%] Built target codeeditor_autogen[ 57%] Built target syntaxrepository_test_autogenScanning dependencies of target kate-syntax-highlighterScanning dependencies of target highlighter_benchmarkScanning dependencies of target testhighlighter_testScanning dependencies of target htmlhighlighter_testScanning dependencies of target wildcardmatcher_testScanning dependencies of target theme_testScanning dependencies of target codeeditor[ 58%] Building CXX object autotests/CMakeFiles/highlighter_benchmark.dir/highlighter_benchmark.cpp.oScanning dependencies of target repository_benchmark[ 60%] Building CXX object src/cli/CMakeFiles/kate-syntax-highlighter.dir/kate-syntax-highlighter.cpp.o[ 61%] Building CXX object autotests/CMakeFiles/testhighlighter_test.dir/testhighlighter.cpp.o[ 62%] Building CXX object autotests/CMakeFiles/theme_test.dir/theme_test.cpp.o[ 64%] Building CXX object autotests/CMakeFiles/htmlhighlighter_test.dir/htmlhighlighter_test.cpp.o[ 65%] Building CXX object autotests/CMakeFiles/wildcardmatcher_test.dir/wildcardmatcher_test.cpp.o[ 66%] Building CXX object examples/CMakeFiles/codeeditor.dir/codeeditor.cpp.o[ 68%] Building CXX object autotests/CMakeFiles/repository_benchmark.dir/repository_benchmark.cpp.o[ 68%] Built target folding_test_autogen[ 69%] Building CXX object autotests/CMakeFiles/repository_benchmark.dir/repository_benchmark_autogen/mocs_compilation.cpp.o[ 70%] Building CXX object src/cli/CMakeFiles/kate-syntax-highlighter.dir/kate-syntax-highlighter_autogen/mocs_compilation.cpp.o[ 72%] Building CXX object examples/CMakeFiles/codeeditor.dir/main.cpp.o[ 73%] Linking CXX executable ../../bin/kate-syntax-highlighter[ 74%] Building CXX object autotests/CMakeFiles/wildcardmatcher_test.dir/__/src/lib/wildcardmatcher.cpp.o[ 76%] Linking CXX executable ../bin/repository_benchmark[ 76%] Built target kate-syntax-highlighter[ 77%] Building CXX object autotests/CMakeFiles/wildcardmatcher_test.dir/wildcardmatcher_test_autogen/mocs_compilation.cpp.o[ 78%] Building CXX object examples/CMakeFiles/codeeditor.dir/codeeditor_autogen/mocs_compilation.cpp.o[ 80%] Building CXX object autotests/CMakeFiles/htmlhighlighter_test.dir/htmlhighlighter_test_autogen/mocs_compilation.cpp.oScanning dependencies of target syntaxrepository_test[ 81%] Building CXX object autotests/CMakeFiles/testhighlighter_test.dir/testhighlighter_test_autogen/mocs_compilation.cpp.o[ 82%] Building CXX object autotests/CMakeFiles/syntaxrepository_test.dir/syntaxrepository_test.cpp.o[ 84%] Linking CXX executable ../bin/testhighlighter_test[ 85%] Linking CXX executable ../bin/htmlhighlighter_test[ 86%] Building CXX object autotests/CMakeFiles/theme_test.dir/theme_test_autogen/mocs_compilation.cpp.o[ 88%] Building CXX object autotests/CMakeFiles/highlighter_benchmark.dir/highlighter_benchmark_autogen/mocs_compilation.cpp.o[ 89%] Linking CXX executable ../bin/wildcardmatcher_test[ 89%] Built target repository_benchmark[ 90%] Linking CXX executable ../bin/theme_test[ 92%] Linking CXX executable ../bin/highlighter_benchmarkScanning dependencies of target folding_test[ 93%] Building CXX object autotests/CMakeFiles/folding_test.dir/foldingtest.cpp.o[ 94%] Building CXX object

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-10-27 Thread Christoph Cullmann 
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:83a5c8ce9882: keyword rule: Spport for keywords inclusion 
from another language/file (authored by jpoelen, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14632?vs=42628=44311

REVISION DETAIL
  https://phabricator.kde.org/D14632

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  data/schema/language.xsd
  data/syntax/scss.xml
  src/indexer/katehighlightingindexer.cpp
  src/lib/definition.cpp
  src/lib/definition_p.h
  src/lib/keywordlist.cpp
  src/lib/keywordlist_p.h

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann, vkrause
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis 
ndavis updated this revision to Diff 44308.
ndavis added a comment.


  Add dark versions of previous change

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16421?vs=44304=44308

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

AFFECTED FILES
  icons-dark/emblems/16/checkmark.svg
  icons-dark/emblems/16/emblem-added.svg
  icons-dark/emblems/16/emblem-checked.svg
  icons-dark/emblems/16/emblem-encrypted-unlocked.svg
  icons-dark/emblems/16/emblem-error.svg
  icons-dark/emblems/16/emblem-favorite.svg
  icons-dark/emblems/16/emblem-important.svg
  icons-dark/emblems/16/emblem-information.svg
  icons-dark/emblems/16/emblem-locked.svg
  icons-dark/emblems/16/emblem-mounted.svg
  icons-dark/emblems/16/emblem-pause.svg
  icons-dark/emblems/16/emblem-question.svg
  icons-dark/emblems/16/emblem-remove.svg
  icons-dark/emblems/16/emblem-shared.svg
  icons-dark/emblems/16/emblem-success.svg
  icons-dark/emblems/16/emblem-symbolic-link.svg
  icons-dark/emblems/16/emblem-unavailable.svg
  icons-dark/emblems/16/emblem-unlocked.svg
  icons-dark/emblems/16/emblem-unmounted.svg
  icons-dark/emblems/16/emblem-warning.svg
  icons-dark/emblems/16/rating-unrated.svg
  icons-dark/emblems/16/rating.svg
  icons-dark/emblems/16/vcs-added.svg
  icons-dark/emblems/16/vcs-conflicting.svg
  icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/16/vcs-locally-modified.svg
  icons-dark/emblems/16/vcs-normal.svg
  icons-dark/emblems/16/vcs-removed.svg
  icons-dark/emblems/16/vcs-update-required.svg
  icons-dark/emblems/22/checkmark.svg
  icons-dark/emblems/22/emblem-added.svg
  icons-dark/emblems/22/emblem-checked.svg
  icons-dark/emblems/22/emblem-encrypted-unlocked.svg
  icons-dark/emblems/22/emblem-error.svg
  icons-dark/emblems/22/emblem-favorite.svg
  icons-dark/emblems/22/emblem-important.svg
  icons-dark/emblems/22/emblem-information.svg
  icons-dark/emblems/22/emblem-locked.svg
  icons-dark/emblems/22/emblem-mounted.svg
  icons-dark/emblems/22/emblem-pause.svg
  icons-dark/emblems/22/emblem-question.svg
  icons-dark/emblems/22/emblem-remove.svg
  icons-dark/emblems/22/emblem-shared.svg
  icons-dark/emblems/22/emblem-success.svg
  icons-dark/emblems/22/emblem-symbolic-link.svg
  icons-dark/emblems/22/emblem-unavailable.svg
  icons-dark/emblems/22/emblem-unlocked.svg
  icons-dark/emblems/22/emblem-unmounted.svg
  icons-dark/emblems/22/emblem-warning.svg
  icons-dark/emblems/22/rating-unrated.svg
  icons-dark/emblems/22/rating.svg
  icons-dark/emblems/22/vcs-added.svg
  icons-dark/emblems/22/vcs-conflicting.svg
  icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/22/vcs-locally-modified.svg
  icons-dark/emblems/22/vcs-normal.svg
  icons-dark/emblems/22/vcs-removed.svg
  icons-dark/emblems/22/vcs-update-required.svg
  icons-dark/emblems/8/emblem-added.svg
  icons-dark/emblems/8/emblem-checked.svg
  icons-dark/emblems/8/emblem-encrypted-locked.svg
  icons-dark/emblems/8/emblem-encrypted-unlocked.svg
  icons-dark/emblems/8/emblem-error.svg
  icons-dark/emblems/8/emblem-favorite.svg
  icons-dark/emblems/8/emblem-important.svg
  icons-dark/emblems/8/emblem-information.svg
  icons-dark/emblems/8/emblem-locked.svg
  icons-dark/emblems/8/emblem-mounted.svg
  icons-dark/emblems/8/emblem-pause.svg
  icons-dark/emblems/8/emblem-question.svg
  icons-dark/emblems/8/emblem-remove.svg
  icons-dark/emblems/8/emblem-shared.svg
  icons-dark/emblems/8/emblem-symbolic-link.svg
  icons-dark/emblems/8/emblem-unavailable.svg
  icons-dark/emblems/8/emblem-unlocked.svg
  icons-dark/emblems/8/emblem-unmounted.svg
  icons-dark/emblems/8/emblem-warning.svg
  icons-dark/emblems/8/rating-unrated.svg
  icons-dark/emblems/8/rating.svg
  icons-dark/emblems/8/vcs-added.svg
  icons-dark/emblems/8/vcs-conflicting.svg
  icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/8/vcs-locally-modified.svg
  icons-dark/emblems/8/vcs-normal.svg
  icons-dark/emblems/8/vcs-removed.svg
  icons-dark/emblems/8/vcs-update-required.svg
  icons/emblems/16/checkmark.svg
  icons/emblems/16/emblem-added.svg
  icons/emblems/16/emblem-checked.svg
  icons/emblems/16/emblem-encrypted-unlocked.svg
  icons/emblems/16/emblem-error.svg
  icons/emblems/16/emblem-favorite.svg
  icons/emblems/16/emblem-important.svg
  icons/emblems/16/emblem-information.svg
  icons/emblems/16/emblem-locked.svg
  icons/emblems/16/emblem-mounted.svg
  icons/emblems/16/emblem-pause.svg
  icons/emblems/16/emblem-question.svg
  icons/emblems/16/emblem-remove.svg
  icons/emblems/16/emblem-shared.svg
  icons/emblems/16/emblem-success.svg
  icons/emblems/16/emblem-symbolic-link.svg
  icons/emblems/16/emblem-unavailable.svg
  icons/emblems/16/emblem-unlocked.svg
  icons/emblems/16/emblem-unmounted.svg
  icons/emblems/16/emblem-warning.svg
  icons/emblems/16/rating-unrated.svg
  icons/emblems/16/rating.svg
  icons/emblems/16/vcs-added.svg

D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-10-27 Thread Christoph Cullmann 
cullmann requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16415

To: phily, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars

D16416: z/OS CLIST file syntax highlighting

2018-10-27 Thread Christoph Cullmann 
cullmann added a comment.


  To properly push it with you as author, what is your full name + mail address?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16416

To: phily, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars

D16416: z/OS CLIST file syntax highlighting

2018-10-27 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.


  I can add the test for you, otherwise this look ok to go in.
  
  Thanks for the contribution.
  
  The Alert include is missing, but I am not sure if it is really needed ;=)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16416

To: phily, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks for the updates. I know it's a PITA, but would you mind updating the 
image in the Summary section?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

2018-10-27 Thread Noah Davis 
ndavis updated this revision to Diff 44304.
ndavis added a comment.


  Improve arrow visibility on vcs emblems
  Add emblem-encrypted-locked
  Change emblem-locked back to orange

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16421?vs=44248=44304

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

AFFECTED FILES
  icons-dark/emblems/16/checkmark.svg
  icons-dark/emblems/16/emblem-added.svg
  icons-dark/emblems/16/emblem-checked.svg
  icons-dark/emblems/16/emblem-encrypted-unlocked.svg
  icons-dark/emblems/16/emblem-error.svg
  icons-dark/emblems/16/emblem-favorite.svg
  icons-dark/emblems/16/emblem-important.svg
  icons-dark/emblems/16/emblem-information.svg
  icons-dark/emblems/16/emblem-locked.svg
  icons-dark/emblems/16/emblem-mounted.svg
  icons-dark/emblems/16/emblem-pause.svg
  icons-dark/emblems/16/emblem-question.svg
  icons-dark/emblems/16/emblem-remove.svg
  icons-dark/emblems/16/emblem-shared.svg
  icons-dark/emblems/16/emblem-success.svg
  icons-dark/emblems/16/emblem-symbolic-link.svg
  icons-dark/emblems/16/emblem-unavailable.svg
  icons-dark/emblems/16/emblem-unlocked.svg
  icons-dark/emblems/16/emblem-unmounted.svg
  icons-dark/emblems/16/emblem-warning.svg
  icons-dark/emblems/16/rating-unrated.svg
  icons-dark/emblems/16/rating.svg
  icons-dark/emblems/16/vcs-added.svg
  icons-dark/emblems/16/vcs-conflicting.svg
  icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/16/vcs-locally-modified.svg
  icons-dark/emblems/16/vcs-normal.svg
  icons-dark/emblems/16/vcs-removed.svg
  icons-dark/emblems/16/vcs-update-required.svg
  icons-dark/emblems/22/checkmark.svg
  icons-dark/emblems/22/emblem-added.svg
  icons-dark/emblems/22/emblem-checked.svg
  icons-dark/emblems/22/emblem-encrypted-unlocked.svg
  icons-dark/emblems/22/emblem-error.svg
  icons-dark/emblems/22/emblem-favorite.svg
  icons-dark/emblems/22/emblem-important.svg
  icons-dark/emblems/22/emblem-information.svg
  icons-dark/emblems/22/emblem-locked.svg
  icons-dark/emblems/22/emblem-mounted.svg
  icons-dark/emblems/22/emblem-pause.svg
  icons-dark/emblems/22/emblem-question.svg
  icons-dark/emblems/22/emblem-remove.svg
  icons-dark/emblems/22/emblem-shared.svg
  icons-dark/emblems/22/emblem-success.svg
  icons-dark/emblems/22/emblem-symbolic-link.svg
  icons-dark/emblems/22/emblem-unavailable.svg
  icons-dark/emblems/22/emblem-unlocked.svg
  icons-dark/emblems/22/emblem-unmounted.svg
  icons-dark/emblems/22/emblem-warning.svg
  icons-dark/emblems/22/rating-unrated.svg
  icons-dark/emblems/22/rating.svg
  icons-dark/emblems/22/vcs-added.svg
  icons-dark/emblems/22/vcs-conflicting.svg
  icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/22/vcs-locally-modified.svg
  icons-dark/emblems/22/vcs-normal.svg
  icons-dark/emblems/22/vcs-removed.svg
  icons-dark/emblems/22/vcs-update-required.svg
  icons-dark/emblems/8/emblem-added.svg
  icons-dark/emblems/8/emblem-checked.svg
  icons-dark/emblems/8/emblem-encrypted-unlocked.svg
  icons-dark/emblems/8/emblem-error.svg
  icons-dark/emblems/8/emblem-favorite.svg
  icons-dark/emblems/8/emblem-important.svg
  icons-dark/emblems/8/emblem-information.svg
  icons-dark/emblems/8/emblem-locked.svg
  icons-dark/emblems/8/emblem-mounted.svg
  icons-dark/emblems/8/emblem-pause.svg
  icons-dark/emblems/8/emblem-question.svg
  icons-dark/emblems/8/emblem-remove.svg
  icons-dark/emblems/8/emblem-shared.svg
  icons-dark/emblems/8/emblem-symbolic-link.svg
  icons-dark/emblems/8/emblem-unavailable.svg
  icons-dark/emblems/8/emblem-unlocked.svg
  icons-dark/emblems/8/emblem-unmounted.svg
  icons-dark/emblems/8/emblem-warning.svg
  icons-dark/emblems/8/rating-unrated.svg
  icons-dark/emblems/8/rating.svg
  icons-dark/emblems/8/vcs-added.svg
  icons-dark/emblems/8/vcs-conflicting.svg
  icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/8/vcs-locally-modified.svg
  icons-dark/emblems/8/vcs-normal.svg
  icons-dark/emblems/8/vcs-removed.svg
  icons-dark/emblems/8/vcs-update-required.svg
  icons/emblems/16/checkmark.svg
  icons/emblems/16/emblem-added.svg
  icons/emblems/16/emblem-checked.svg
  icons/emblems/16/emblem-encrypted-unlocked.svg
  icons/emblems/16/emblem-error.svg
  icons/emblems/16/emblem-favorite.svg
  icons/emblems/16/emblem-important.svg
  icons/emblems/16/emblem-information.svg
  icons/emblems/16/emblem-locked.svg
  icons/emblems/16/emblem-mounted.svg
  icons/emblems/16/emblem-pause.svg
  icons/emblems/16/emblem-question.svg
  icons/emblems/16/emblem-remove.svg
  icons/emblems/16/emblem-shared.svg
  icons/emblems/16/emblem-success.svg
  icons/emblems/16/emblem-symbolic-link.svg
  icons/emblems/16/emblem-unavailable.svg
  icons/emblems/16/emblem-unlocked.svg
  icons/emblems/16/emblem-unmounted.svg
  icons/emblems/16/emblem-warning.svg
  icons/emblems/16/rating-unrated.svg
  icons/emblems/16/rating.svg
  icons/emblems/16/vcs-added.svg

D16414: Changes to REXX syntax highlighting

2018-10-27 Thread Christoph Cullmann 
cullmann closed this revision.
cullmann added a comment.


  Hmpf, arc failed :/
  
  But the stuff is in at least:
  
  Git commit e07306d9c22f6426d6b50287eee532555d74ac75 by Christoph Cullmann.
  Committed on 27/10/2018 at 14:36.
  Pushed by cullmann into branch 'master'.
  
  add test file + remove no longer existing instructions reference from xml
  
  A  +52   -0autotests/folding/test.rexx.fold
  A  +59   -0autotests/html/test.rexx.html
  A  +52   -0autotests/input/test.rexx
  A  +52   -0autotests/reference/test.rexx.ref
  M  +158  -93   data/syntax/rexx.xml
  
  
https://commits.kde.org/syntax-highlighting/e07306d9c22f6426d6b50287eee532555d74ac75

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16414

To: phily, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16414: Changes to REXX syntax highlighting

2018-10-27 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks for the test file, I fixed the no longer existing ref
  
  
  
  and pushed the stuff!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16414

To: phily, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-10-27 Thread Christoph Cullmann 
cullmann added a comment.


  Hi, could one remove the two hard-coded colors and just use a different 
builtin defStyleNum?
  
  Beside that, have you some small example script that we could add as 
auto-test?
  
  e.g. something perhaps a bit larger than the snippets I can find on
  
  https://en.wikipedia.org/wiki/Job_Control_Language
  
  (and that has no license issues)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16415

To: phily, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars

D16414: Changes to REXX syntax highlighting

2018-10-27 Thread Phil Young 
phily updated this revision to Diff 44283.
phily added a comment.


  Removed typo in test script

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16414?vs=44282=44283

REVISION DETAIL
  https://phabricator.kde.org/D16414

AFFECTED FILES
  autotests/input/test.rexx
  data/syntax/rexx.xml

To: phily, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16414: Changes to REXX syntax highlighting

2018-10-27 Thread Phil Young 
phily updated this revision to Diff 44282.
phily added a comment.


  Did not include the syntax file itself in my last update, now the diff 
includes both.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16414?vs=44281=44282

REVISION DETAIL
  https://phabricator.kde.org/D16414

AFFECTED FILES
  autotests/input/test.rexx
  data/syntax/rexx.xml

To: phily, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16414: Changes to REXX syntax highlighting

2018-10-27 Thread Phil Young 
phily updated this revision to Diff 44281.
phily added a comment.


  Added test file to autotests/input/test.rexx as well as upgrading the version 
number

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16414?vs=44180=44281

REVISION DETAIL
  https://phabricator.kde.org/D16414

AFFECTED FILES
  autotests/input/test.rexx

To: phily, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann