D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

[Ralf Habacker]

habacker added a comment.


  On opensuse there are the cross compile helper packages
  
  mingw32-cross-kde4-tools
  mingw32-cross-kf5-tools
  
  both containing docbookl10nhelper and nothing prevents them from been 
installed in parallel

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D17649

To: habacker
Cc: ltoscano, kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, 
skadinna

T3689: Add abi compliance checker to CI

[Ben Cooksley]

bcooksley added a comment.


  I've made an experimental change which should resolve this issue if it is 
what is suspected to be the issue here.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss, bcooksley
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Ben Cooksley]

bcooksley added a commit: R857:dbb3d8d9f37a: Make sure we wait and block until 
the publishing process is completed..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss, bcooksley
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

D17623: Add YaST icons

[Nathaniel Graham]

ngraham added a comment.


  In D17623#380204 , @ndavis wrote:
  
  > In D17623#378670 , @ngraham 
wrote:
  >
  > >   apps/32/yast-checkmedia.svg   
preferences/32/preferences-devices-drive-optical-ok.svg
  >
  >
  > Why `ok`? This is a preferences icon, so it doesn't make sense for there to 
be preferences about `ok`, which usually represents a state.
  
  
  My intention was to have the last word reflect the checkmark (presumably a 
version with an X  could be made). Another word could work too.
  
  >>   apps/32/yast-create-new-vm.svgpreferences/32/preferences-vm-add.svg
  >>   apps/32/yast-vm-install.svg   
preferences/32/preferences-vm-install.svg
  >>   apps/32/yast-vm-migrate.svg   
preferences/32/preferences-vm-migrate.svg
  >>   apps/32/yast-vm.svg   preferences/32/preferences-vm.svg
  > 
  > Is `vm` too short? Could `virtualization` be better? `preferences-vm-add` 
seems awfully similar to an action icon for a preferences icon, but that's 
because of how the icon is used in the first place.
  
  `virtualization` seems fine, yeah.
  
  >>   apps/32/yast-device-tree.svg  preferences/32/preferences-devices.svg
  > 
  > This icon represents a tree of devices in a graph of the system's drive 
partitions. I'm not sure if it's good as an icon for just any `devices`.
  
  `preferences-devices-tree.svg` then?
  
  >>   apps/32/yast-disk.svg 
preferences/32/preferences-devices-drive-harddisk-partitions.svg
  > 
  > This icon currently uses openSUSE colors to represent the YaST Partitioner. 
I might have to change the colors to make it a KDE partition preferences icon.
  
  Ok.
  
  >>   apps/32/yast-docker.svg   
preferences/32/preferences-system-docker.svg
  > 
  > Should this be `preferences-virtualization-docker`?
  
  +1
  
  >>   apps/32/yast-dsl.svg  
preferences/32/preferences-system-network-modem.svg
  > 
  > I was planning on turning this into a 64px device icon 
(`network-rj11-female`). If I were to do an actual modem icon, I would pick 
something that looks more like a modem. Lots of modems don't have RJ11 
(DSL/Telephone wire) ports and lots of devices that have RJ11 ports are not 
modems. I've had some issues with getting 64px icons to work though. They 
should work and I see no reason for them not to since I've seen them work, but 
whenever I try, the icons fallback to hicolor. I'll have to talk to LCP or YaST 
devs about that.
  
  So `preferences-system-network-rj11-female.svg` then?
  
  >>   apps/32/yast-lan.svg  
preferences/32/preferences-system-network-ethernet.svg
  > 
  > Same deal as the RJ11 icon, except it's RJ45. However, the name makes sense 
for a preferences icon specifically for ethernet, whatever that would be used 
for.
  
  Perhaps it could be `preferences-system-network-rj45-female.svg`, and create 
a symlink to it called `preferences-system-network-ethernet.svg`?
  
  >>   apps/32/yast-hwinfo.svg   
preferences/32/preferences-system-hwinfo.svg
  > 
  > This is a 32px version of the existing `hwinfo` icon since it looks blurry 
as hell when scaled down to 32px.
  
  Right.
  
  >>   apps/32/yast-instserver.svg   
preferences/32/preferences-system-network-server-install.svg
  > 
  > `instserver` is for providing installation repos, not specifically for 
installing a server. Is `install` good enough?
  
  Maybe `preferences-system-network-server-installation` then? Install servers 
aren't uncommon.
  
  >>   apps/32/yast-journal.svg  preferences/32/preferences-book.svg
  > 
  > This is an icon for the systemd journal. It could probably be replaced with 
a 32px version of the KSystemLog icon or something similar.
  
  Sounds good to me.
  
  >>   apps/32/yast-nis.svg  
preferences/32/preferences-desktop-user-nis.svg
  > 
  > Why is this `preferences-desktop-user-nis` and LDAP 
`preferences-system-network-ldap`? They both have similar functions, except 
LDAP is a more secure replacement for NIS.
  
  We could do `preferences-system-network-nis`.
  
  >>   apps/32/yast-snapper.svg  
preferences/32/preferences-devices-drive-harddisk-snapper.svg
  > 
  > Snapper is a system snapshotting program, not a type of device.
  
  I was just re-using the naming style of the other icons that have a hard disk 
with an icon in it. Ideas?
  
  > 
  > 
  >>   apps/32/yast-sudo.svg 
preferences/32/preferences-desktop-user-sudo.svg
  > 
  > This is for configuring `sudo`. It doesn't have anything to do with a 
specific user or the desktop.
  
  `preferences-system-user-sudo`?
  
  >>   apps/32/yast-vpn.svg  
preferences/32/preferences-web-browser-vpn.svg
  > 
  > Generally, VPNs are handled by `plasma-nm`, not anything to do with web 
browsers specifically. Perhaps I could have picked an icon that isn't 
consistent with the `preferences-web-browser-*` icons.
  
  Yeah, I 

D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable

[Shubham]

shubham added a comment.


  In D17632#380066 , @dfaure wrote:
  
  > Did you expect (or desire) anything else?
  
  
  I meant of adding test for copying multiple folders.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17632

To: dfaure, shubham, broulik, bruns
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis added a comment.


  In D17623#378670 , @ngraham wrote:
  
  >   apps/32/yast-checkmedia.svg   
preferences/32/preferences-devices-drive-optical-ok.svg
  
  
  Why `ok`? This is a preferences icon, so it doesn't make sense for there to 
be preferences about `ok`, which usually represents a state.
  
  >   apps/32/yast-create-new-vm.svgpreferences/32/preferences-vm-add.svg
  >   apps/32/yast-vm-install.svg   
preferences/32/preferences-vm-install.svg
  >   apps/32/yast-vm-migrate.svg   
preferences/32/preferences-vm-migrate.svg
  >   apps/32/yast-vm.svg   preferences/32/preferences-vm.svg
  
  Is `vm` too short? Could `virtualization` be better? BTW, the way this icon 
is used is similar to an action ico
  
  >   apps/32/yast-device-tree.svg  preferences/32/preferences-devices.svg
  
  This icon represents a tree of devices in a graph of the system's drive 
partitions. I'm not sure if it's good as an icon for just any `devices`.
  
  >   apps/32/yast-disk.svg 
preferences/32/preferences-devices-drive-harddisk-partitions.svg
  
  This icon currently uses openSUSE colors to represent the YaST Partitioner. I 
might have to change the colors to make it a KDE partition preferences icon.
  
  >   apps/32/yast-docker.svg   
preferences/32/preferences-system-docker.svg
  
  Should this be `preferences-virtualization-docker`?
  
  >   apps/32/yast-dsl.svg  
preferences/32/preferences-system-network-modem.svg
  
  I was planning on turning this into a 64px device icon 
(`network-rj11-female`). If I were to do an actual modem icon, I would pick 
something that looks more like a modem. Lots of modems don't have RJ11 
(DSL/Telephone wire) ports and lots of devices that have RJ11 ports are not 
modems. I've had some issues with getting 64px icons to work though. They 
should work and I see no reason for them not to since I've seen them work, but 
whenever I try, the icons fallback to hicolor. I'll have to talk to LCP or YaST 
devs about that.
  
  >   apps/32/yast-lan.svg  
preferences/32/preferences-system-network-ethernet.svg
  
  Same deal as the RJ11 icon, except it's RJ45. However, the name makes sense 
for a preferences icon specifically for ethernet, whatever that would be used 
for.
  
  >   apps/32/yast-hwinfo.svg   
preferences/32/preferences-system-hwinfo.svg
  
  This is a 32px version of the existing `hwinfo` icon since it looks blurry as 
hell when scaled down to 32px.
  
  >   apps/32/yast-instserver.svg   
preferences/32/preferences-system-network-server-install.svg
  
  `instserver` is for providing installation repos, not specifically for 
installing a server. Is `install` good enough?
  
  >   apps/32/yast-journal.svg  preferences/32/preferences-book.svg
  
  This is an icon for the systemd journal. It could probably be replaced with a 
32px version of the KSystemLog icon or something similar.
  
  >   apps/32/yast-nis.svg  
preferences/32/preferences-desktop-user-nis.svg
  
  Why is this `preferences-desktop-user-nis` and LDAP 
`preferences-system-network-ldap`? They both have similar functions, except 
LDAP is a more secure replacement for NIS.
  
  >   apps/32/yast-snapper.svg  
preferences/32/preferences-devices-drive-harddisk-snapper.svg
  
  Snapper is a system snapshotting program, not a type of device.
  
  >   apps/32/yast-sudo.svg 
preferences/32/preferences-desktop-user-sudo.svg
  
  This is for configuring `sudo`. It doesn't have anything to do with a 
specific user or the desktop.
  
  >   apps/32/yast-vpn.svg  
preferences/32/preferences-web-browser-vpn.svg
  
  Generally, VPNs are handled by `plasma-nm`, not anything to do with web 
browsers specifically. Perhaps I could have picked an icon that isn't 
consistent with the `preferences-web-browser-*` icons.
  
  >   apps/32/yast-wol.svg  
preferences/32/preferences-web-browser-power.svg
  
  This is Wake-on-Lan . It 
doesn'thave anything to do with web browsers. Perhaps I could have picked an 
icon that isn't consistent with the `preferences-web-browser-*` icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis added a comment.


  In D17623#378989 , @ngraham wrote:
  
  > In D17623#378783 , @ndavis wrote:
  >
  > > 2. It's supposed to be a newspaper. I tried to make it look similar to 
`message-news`: F6486579: Screenshot_20181218_073508.png 

  > >   - An alternative newspaper style might be something similar to 
`news-subscribe`: F6486581: Screenshot_20181218_073629.png 

  >
  >
  > Yeah, that might be better. `message-news` itself doesn't really look that 
much like a newspaper lol! Something more like this might be clearer, for both 
icons: https://www.flaticon.com/free-icon/text-lines_254005
  
  
  I'm not sure about the isometric-ish look. It just doesn't feel like it fits 
in with the other Breeze icons. How is this? F6495264: 
Screenshot_20181220_175818.png F6495266: 
Screenshot_20181220_180001.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/11/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 20 Dec 2018 22:48:00 +
 Build duration:
6 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(254/289)88%
(254/289)68%
(32952/48218)51%
(15851/30976)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4431/4730)49%
(1696/3450)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5483/5523)58%
(996/1712)src.buffer88%
(15/17)88%
(15/17)90%
(1697/1881)76%
(1214/1596)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1869/3151)47%
(1564/3305)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(627/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(6/6)100%
(6/6)74%
(1109/1498)64%
 

D17714: Clang: don't enable -Wzero-as-null-pointer-constant on 5.0.0

[David Faure]

dfaure added a comment.


  Damn, I went too fast. This doesn't fix the issue.
  
  CMake says 5.0.300080 is > 5.0.1, obviously.
  
  The reason I enabled it for 5.0.1 is that on x86_64 linux, clang 5.0.1 does 
support it (but now I realize that 5.0.0 does too, most probably).
  I don't understand what weird mess android does with the clang versioning, 
but apparently 5.0.380 is actually a kind of beta of 5.0.0 
https://stackoverflow.com/questions/47552782/llvm-version-on-ios-and-android 
seems to confirm that, in fact.
  
  I guess the bug is my own fault, I didn't see there was a NDK 15c after 15b, 
so I guess one shouldn't use 15b at all.
  I'll revert after confirming that it works with 15c, sorry for the noise.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D17714

To: dfaure, aacid, cgiboudeaux, apol
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17178: Don't ask for confimation when reloading

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:82a1673746ea: Dont ask for confimation when 
reloading (authored by nicolasfella).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17178?vs=47740=47918

REVISION DETAIL
  https://phabricator.kde.org/D17178

AFFECTED FILES
  src/document/katedocument.cpp

To: nicolasfella, #kate, ngraham, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D17714: Clang: don't enable -Wzero-as-null-pointer-constant on 5.0.0

[David Faure]

dfaure closed this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D17714

To: dfaure, aacid, cgiboudeaux, apol
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17714: Clang: don't enable -Wzero-as-null-pointer-constant on 5.0.0

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17714

To: dfaure, aacid, cgiboudeaux, apol
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17459: SearchBar: Add Cancel button to stop long running tasks

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> katesearchbar.cpp:89
> +ret = new KateSearchBarPrivate;
> +d_func()->insert(foo, ret);
> +}

You can take another approach

  connect(foo, ::destroyed, d_func, [foo]() { delete 
d_func()->take(foo); });

> katesearchbar.cpp:94-97
> +static void delete_d(const KateSearchBar *foo)
> +{
> +delete d_func()->take(foo);
> +}

Remove.

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, 
kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, 
sars, dhaumann

D17459: SearchBar: Add Cancel button to stop long running tasks

[loh tar]

loh.tar updated this revision to Diff 47907.
loh.tar added a comment.


  Fixed/Simplified as suggested
  
  - I noticed a reproducible crash when e.g. Kate will closed while a S is 
running. Happens also when a split view is closed (so far so good) and then 
Kate will closed . I will try to solve this later, but help is appreciated.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17459?vs=47891=47907

REVISION DETAIL
  https://phabricator.kde.org/D17459

AFFECTED FILES
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h
  src/search/searchbarpower.ui

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, 
kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, 
sars, dhaumann

D17714: Clang: don't enable -Wzero-as-null-pointer-constant on 5.0.0

[David Faure]

dfaure created this revision.
dfaure added reviewers: aacid, cgiboudeaux, apol.
Herald added projects: Frameworks, Build System.
Herald edited subscribers, added: kde-buildsystem, kde-frameworks-devel; 
removed: Build System, Frameworks.
dfaure requested review of this revision.

REVISION SUMMARY
  The clang compiler in Android NDK r15b, which has version 5.0.300080,
  warns as follows:
  
  warning: unknown warning option '-Wzero-as-null-pointer-constant'; did you 
mean '-Wint-to-void-pointer-cast'? [-Wunknown-warning-option]

TEST PLAN
  Removing the option removes the warning

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17714

AFFECTED FILES
  kde-modules/KDEFrameworkCompilerSettings.cmake

To: dfaure, aacid, cgiboudeaux, apol
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable

[David Faure]

dfaure added a comment.


  Same result: I copy 4 folders into "/", and I get one error saying: Access 
denied. Could not write to "/".
  
  Did you expect (or desire) anything else?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17632

To: dfaure, shubham, broulik, bruns
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns

D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable

[Shubham]

shubham added a comment.


  Can you try copying multiple folders?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17632

To: dfaure, shubham, broulik, bruns
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns

D17331: Extend PositionCodec unit tests, better code coverage

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:b5fd732b171e: Extend PositionCodec unit tests, better 
code coverage (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17331?vs=46790=47899

REVISION DETAIL
  https://phabricator.kde.org/D17331

AFFECTED FILES
  autotests/benchmarks/positioncodecbenchmark.cpp
  autotests/unit/codecs/positioncodectest.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko, lbeltrame
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 94 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/94/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 20 Dec 2018 16:17:29 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 45 test(s)Failed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(235/255)92%
(235/255)85%
(26343/30975)53%
(10549/19898)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(42/42)100%
(42/42)99%
(12067/12237)50%
(6343/12751)autotests.server100%
(5/5)100%
(5/5)99%
(355/358)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(6171/7258)65%
(1783/2756)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(7669/8849)66%
(2254/3418)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  In T3689#170601 , @bcooksley wrote:
  
  > I checked execution of KDav on all four build nodes, and the process ran 
fine when done manually.
  >  Given there is no output from check-abi.py, this is quite hard to diagnose.
  
  
  In the last `for l in libraries:` loop, we get output for every item in that 
list, etiher because there are candidates or there are not.
  That means the only way to produce no output at all is that libraries list 
must be empty. We do not remove any entry from that list, so the initial search 
do not find any matching entry.
  And the only way the list can be empty is that the `for key, entry in 
ourArchive.serverManifest.items()` don't find any matching entry.
  
  > Can you propose some debug output which might point out why it's doing 
nothing?
  
  I added D17710  to retry to reload the 
serverManiphest file again after 5secs to sleep. The added output is hopefully 
enough to spot the issue.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.11 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.11/3/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 20 Dec 2018 16:17:29 +
 Build duration:
7 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 45 test(s)Failed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(235/255)92%
(235/255)85%
(26340/30975)53%
(10546/19898)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(42/42)100%
(42/42)99%
(12067/12237)50%
(6342/12751)autotests.server100%
(5/5)100%
(5/5)99%
(355/358)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(6168/7258)65%
(1781/2756)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(7669/8849)66%
(2254/3418)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

[Nathaniel Graham]

ngraham added a comment.


  In D17137#379789 , @gregormi wrote:
  
  > If there are no further comments, would proceed with:
  >
  > - Introduce "Save Variants" by leaving Save and Save as... top-level. I 
will use the name 'file_save_variants'
  > - Introduce "Print and Export" submenu
  > - Introduce "Close Variants" while leaving the 'Ctrl+W' Close on top-level
  
  
  Sounds sane to me!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17137

To: gregormi, #kate, #kdevelop
Cc: ngraham, cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, 
hase, michaelh, bruns, demsking, sars

D17558: Fix XDGForeign Client header installs

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:25eae63002a4: Fix XDGForeign Client header installs 
(authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17558?vs=47506=47896

REVISION DETAIL
  https://phabricator.kde.org/D17558

AFFECTED FILES
  src/client/CMakeLists.txt

To: davidedmundson, zzag
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D17710: check-abi.py: Reload serverManiphest several 
times, if we don't find matching entries..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

D17459: SearchBar: Add Cancel button to stop long running tasks

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> katesearchbar.cpp:83
> +typedef QHash 
> KateSearchBarPrivateHash;
> +static KateSearchBarPrivateHash KateSearchBarPrivateData;
> +Q_GLOBAL_STATIC(KateSearchBarPrivateHash, d_func)

It's not needed, right?

> katesearchbar.cpp:97-99
> +KateSearchBarPrivate *ret = d_func()->value(foo);
> +delete ret;
> +d_func()->remove(foo);

Use directly

  delete d_func()->take(foo);

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, 
kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, 
sars, dhaumann

D17459: SearchBar: Add Cancel button to stop long running tasks

[loh tar]

loh.tar updated this revision to Diff 47891.
loh.tar added a comment.


  - Workaround to keep binary compatibility
  
  > It's exported class you cannot...
  
  Argh! How can I see this quickly the next time? KTEXTEDITOR_EXPORT ?
  
  - Seams still to work so far, but looks not so lovely
  - Fixed (hopefully) as described there 
https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B#Trouble_shooting
  - Some functions have now no implementation, is that a problem?
  - Some new function could be avoided and an old one used, but that would 
reduce the readability

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17459?vs=47843=47891

REVISION DETAIL
  https://phabricator.kde.org/D17459

AFFECTED FILES
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h
  src/search/searchbarpower.ui

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, 
kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, 
sars, dhaumann

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

[loh tar]

loh.tar added a comment.


  > the change from QChar to const QChar & does not improve the amount of 
copied data.
  
  Argh! OK. Was just an impulse to do it as usual and to follow 
isStartBracket(..) and isBracket(..)
  Will wait for further advice

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17693

To: loh.tar, #ktexteditor
Cc: sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, dhaumann

T3689: Add abi compliance checker to CI

[Ben Cooksley]

bcooksley added a comment.


  I checked execution of KDav on all four build nodes, and the process ran fine 
when done manually.
  Given there is no output from check-abi.py, this is quite hard to diagnose.
  
  Can you propose some debug output which might point out why it's doing 
nothing?

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss, bcooksley
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

D16643: Correct the accept flag of the event object on DragMove

[trmdi]

trmdi added a comment.


  !ping

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

[Kåre Särs]

sars added inline comments.

INLINE COMMENTS

> katedocument.cpp:117
>  
> -static inline QChar matchingStartBracket(QChar c, bool withQuotes)
> +static inline QChar matchingStartBracket(const QChar )
>  {

I'm not familiar with the auto-bracket code, but the change from QChar to const 
QChar & does not improve the amount of copied data.

Qt documentation: "Most compilers treat it like an unsigned short."

This means that in stead of adding unsigned short to the stack you add the 
64bit reference and add the tiny overhead that the reference brings with it.

It probably has no practical difference tho

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17693

To: loh.tar, #ktexteditor
Cc: sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, dhaumann