D17729: KateStatusBar: Reformatted by astyle command to follow coding style

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: KTextEditor, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17729

AFFECTED FILES
  src/view/katestatusbar.cpp
  src/view/katestatusbar.h

To: loh.tar, #ktexteditor, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

[loh tar]

loh.tar added a comment.


  Nothing else was done

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17729

To: loh.tar, #ktexteditor, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17619: Change the path for every item of the subdirectories in a directory rename

[Jaime Torres Amate]

jtamate updated this revision to Diff 47995.
jtamate added a comment.


  Added the unit test. It crashes for me every time without the patch and none 
with the patch.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17619?vs=47731&id=47995

REVISION DETAIL
  https://phabricator.kde.org/D17619

AFFECTED FILES
  autotests/kdirlistertest.cpp
  autotests/kdirlistertest.h
  src/core/kcoredirlister.cpp

To: jtamate, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17730: [WIP] Review KateStatusBar (based on D17729)

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  - KateStatusBar: Do actions on labels by single click instead of double-click
  
This way is the behavior harmonized with the available buttons

TEST PLAN
  Give feedback which of these commits you will reject or like to have as an 
own patch
  My main intent is to add somehow a spell check button/hint

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17730

AFFECTED FILES
  src/view/katestatusbar.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17730: [WIP] Review KateStatusBar (based on D17729)

[loh tar]

loh.tar updated this revision to Diff 47998.
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - KateStatusBar: Don't treat click in empty area as click on mode-label

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17730?vs=47997&id=47998

REVISION DETAIL
  https://phabricator.kde.org/D17730

AFFECTED FILES
  src/view/katestatusbar.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17730: [WIP] Review KateStatusBar (based on D17729)

[loh tar]

loh.tar added a comment.


  Oops, have now the first commit omitted in this update. Perhaps not too bad 
this way(?)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17730

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17730: [WIP] Review KateStatusBar (based on D17729)

[loh tar]

loh.tar added a comment.


  How about to change the "action-labels" to buttons? Thisway would it be less 
"quirky" and we would have a feedback that there is an action available when 
hovered by mouse

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17730

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17730: [WIP] Review KateStatusBar (based on D17729)

[loh tar]

loh.tar updated this revision to Diff 48000.
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - KateStatusBar: Move the modified-label from far right to far left
  
  Once again without all other patches

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17730?vs=47998&id=48000

REVISION DETAIL
  https://phabricator.kde.org/D17730

AFFECTED FILES
  src/view/katestatusbar.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

[David Faure]

dfaure added a comment.


  Please add a KIO version ifdef to avoid breaking compilation with older 
versions of KIO.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D15189

To: achauvel, #frameworks, dfaure, cfeck
Cc: plasma-devel, anthonyfieroni, ngraham, kde-frameworks-devel, GB_2, ragreen, 
Pitel, michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D17726: Add helper function to disable redirections (useful for kde-open)

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Looks good otherwise.

INLINE COMMENTS

> krun.h:161
> + * @param b wether to follow redirections or not.
> + */
> +void setFollowRedirections(bool b);

Missing @since 5.54

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17726

To: achauvel, dfaure, #frameworks, cfeck
Cc: yurchor, kde-frameworks-devel, michaelh, ngraham, bruns

D17619: Change the path for every item of the subdirectories in a directory rename

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kdirlistertest.cpp:1326
> +QCOMPARE(m_dirLister.url().toLocalFile(), newDir);
> +QVERIFY(ok);
> +currDir = newDir;

What's drive_c?

> kdirlistertest.cpp:1334
>  {
>  // ensure m_dirLister holds the items.
>  m_dirLister.openUrl(QUrl::fromLocalFile(path()), KDirLister::NoFlags);

This could be done before the previous line, and used there to remove some 
duplication?

> kdirlistertest.cpp:1343
>  QList deletedUrls;
>  for (int i = 0; i < m_dirLister.spyItemsDeleted.count(); ++i) {
>  deletedUrls += 
> m_dirLister.spyItemsDeleted[i][0].value().urlList();

Waiting for 0 signals doesn't really make sense, does it? I bet it works the 
same without the TRY_

> kdirlistertest.cpp:1346
>  }
>  //qDebug() << deletedUrls;
>  QUrl currentDirUrl = 
> QUrl::fromLocalFile(path()).adjusted(QUrl::StripTrailingSlash);

You could do the more compact and more informative

  QVERIFY2(job->exec(), qPrintable(job->errorString());

on line 1342, obviously, not here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17619

To: jtamate, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable

[David Faure]

dfaure updated this revision to Diff 48002.
dfaure added a comment.


  Upgrade the unittest to be data-driven, and to test for many different cases.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17632?vs=47689&id=48002

BRANCH
  skip_stat

REVISION DETAIL
  https://phabricator.kde.org/D17632

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/copyjob.cpp

To: dfaure, shubham, broulik, bruns
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns

D17528: Refactor SlaveInterface::calcSpeed

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:4e2a815b9a10: Refactor SlaveInterface::calcSpeed 
(authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17528?vs=47950&id=48003

REVISION DETAIL
  https://phabricator.kde.org/D17528

AFFECTED FILES
  src/core/slaveinterface.cpp
  src/core/slaveinterface_p.h

To: chinmoyr, dfaure
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D17623: Add YaST icons

[Fabian Vogt]

fvogt added a comment.


  In D17623#380551 , @ndavis wrote:
  
  > In D17623#380549 , @fvogt wrote:
  >
  > > In D17623#380511 , @ndavis 
wrote:
  > >
  > > > @fvogt @hellcp For some reason YaST Control Center only works with 32px 
icons from Breeze but it can work with seemingly any size icon from hicolor. If 
either of you could help me figure out why that is, I would appreciate it.
  > >
  > >
  > > AFAICT YaST just uses `QIcon::fromTheme("foo").pixmap(32, 32)` which 
should work just fine. Did you refresh the icon cache? What's the issue 
exactly? Do you see the wrong icon, wrong size or no icon at all?
  >
  >
  > Actually, it works with 32px and 48px Breeze icons, but not 64px. If the 
Breeze icon is 64px, yast-c-c shows the hicolor icon. If there is no hicolor 
icon for a module (i.e., I delete all `yast-printer` icons from hicolor), 
yast-c-c shows the `yast` icon, even if there is a Breeze icon at 64px. I'm 
pretty sure it's not an icon cache issue because there are no issues with 
changing icons to 48px versions, only 64px has issues.
  
  
  Turns out it's a trivial issue: breeze's index.theme doesn't contain the 
parameters for `apps/64` so it's like that directory doesn't even exist.
  
  I don't know how to fix it though - apps/48 is already configured to also 
contain 64px images so maybe apps/64 should just get moved into /48?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17619: Change the path for every item of the subdirectories in a directory rename

[Jaime Torres Amate]

jtamate updated this revision to Diff 48004.
jtamate marked 4 inline comments as done.
jtamate added a comment.


  Changes requested done and reduced code duplication.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17619?vs=47995&id=48004

REVISION DETAIL
  https://phabricator.kde.org/D17619

AFFECTED FILES
  autotests/kdirlistertest.cpp
  autotests/kdirlistertest.h
  src/core/kcoredirlister.cpp

To: jtamate, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17619: Change the path for every item of the subdirectories in a directory rename

[Jaime Torres Amate]

jtamate added inline comments.

INLINE COMMENTS

> dfaure wrote in kdirlistertest.cpp:1326
> What's drive_c?

I started this patch following the structure of .wine/drive_c ...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17619

To: jtamate, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17733: ViewPrivate: Don't hide 'Clear Dictionary Ranges' action

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: KTextEditor, VDG.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  Toggle the action instead enable/disable ensure the user knows that
  there is some interesting feature available

TEST PLAN
  No pic, guess not needed, you can imagine

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17733

AFFECTED FILES
  src/view/kateview.cpp

To: loh.tar, #ktexteditor, #vdg
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17371: [KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals

[Nathaniel Graham]

ngraham retitled this revision from "[KRun] when asked to open link in external 
browser, ball back to mimeapps.list if nothing is set in kdeglobals" to "[KRun] 
when asked to open link in external browser, fall back to mimeapps.list if 
nothing is set in kdeglobals".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17371

To: ngraham, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17371: [KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals

[Nathaniel Graham]

ngraham added reviewers: cfeck, elvisangelaccio.
ngraham added a comment.


  Can I get a review on this (or another version someone else submitted: D17727 
)? #frameworks 
 people? #dolphin 
? Anyone?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17371

To: ngraham, #frameworks, broulik, cfeck, elvisangelaccio
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17727: Get default web browser from xdg-settings if it’s not set in KDE

[Nathaniel Graham]

ngraham added a comment.


  I submitted almost the same diff in D17371 
. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17727

To: achauvel
Cc: ngraham, rdieter, kde-frameworks-devel, michaelh, bruns

D17733: ViewPrivate: Don't hide 'Clear Dictionary Ranges' action

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17733

To: loh.tar, #ktexteditor, #vdg, ngraham
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17623: Add YaST icons

[Noah Davis]

ndavis added a comment.


  In D17623#380743 , @fvogt wrote:
  
  > Turns out it's a trivial issue: breeze's index.theme doesn't contain the 
parameters for `apps/64` so it's like that directory doesn't even exist.
  >
  > I don't know how to fix it though - apps/48 is already configured to also 
contain 64px images so maybe apps/64 should just get moved into /48?
  
  
  They could both be scalable directories. 48px will just end up being the 
default size and 64px will only be used when there isn't a 48px icon. Maybe 
that's not ideal because that means 64px will never be used in the application 
dashboard for most apps, but we generally only make 48px versions of app icons 
anyway.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17737: [CopyJob] Create clones in btrf/xfs mount

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: dfaure, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  If Copy-on-Write is enabled in a btrfs/xfs mount then create a clone otherwise
  fallback to standard copy.

TEST PLAN
  Manually copied files and verified with "btrfs filesystem du" command.
  All existing unit tests pass.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17737

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/copyjob.h
  src/core/kmountpoint.cpp
  src/core/kmountpoint.h
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17371: [KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals

[Mélanie Chauvel]

achauvel added a comment.


  I think it’s better than what I proposed (without knowing about yours) in 
D17727 .

INLINE COMMENTS

> krun.cpp:1421-1431
> +
> +// If a default browser isn't set in kdeglobals, fall back to 
> mimeapps.list
> +if (d->m_externalBrowser.isEmpty()) {
> +KSharedConfig::Ptr profile = 
> KSharedConfig::openConfig(QStringLiteral("mimeapps.list"), 
> KConfig::NoGlobals, QStandardPaths::GenericConfigLocation);
> +KConfigGroup defaultApps(profile, "Default Applications");
> +
> +d->m_externalBrowser = 
> defaultApps.readEntry("x-scheme-handler/https");

I personally would have gone for

  // If a default browser isn't set in kdeglobals, fall back to mimeapps.list
  if (!d->m_externalBrowser.isEmpty()) {
  return;
  }
  KSharedConfig::Ptr profile = 
KSharedConfig::openConfig(QStringLiteral("mimeapps.list"), KConfig::NoGlobals, 
QStandardPaths::GenericConfigLocation);
  KConfigGroup defaultApps(profile, "Default Applications");
  
  d->m_externalBrowser = defaultApps.readEntry("x-scheme-handler/https");
  if (d->m_externalBrowser.isEmpty()) {
  d->m_externalBrowser = defaultApps.readEntry("x-scheme-handler/http");
  }

to avoid too much nesting.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17371

To: ngraham, #frameworks, broulik, cfeck, elvisangelaccio
Cc: achauvel, kde-frameworks-devel, michaelh, ngraham, bruns

D17371: [KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals

[Nathaniel Graham]

ngraham updated this revision to Diff 48021.
ngraham added a comment.


  Reduce unnecessary nesting with an early return

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17371?vs=46913&id=48021

BRANCH
  default-browser-fallback-to-mimeapps-if-nothing-is-set-in-kdeglobals 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17371

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/copyjob.h
  src/core/global.h
  src/core/job.cpp
  src/core/slaveinterface.cpp
  src/core/slaveinterface_p.h
  src/widgets/krun.cpp

To: ngraham, #frameworks, broulik, cfeck, elvisangelaccio
Cc: achauvel, kde-frameworks-devel, michaelh, ngraham, bruns

D17371: [KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals

[Nathaniel Graham]

ngraham updated this revision to Diff 48022.
ngraham added a comment.


  Reduce unnecessary nesting with an early return

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17371?vs=48021&id=48022

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17371

AFFECTED FILES
  src/widgets/krun.cpp

To: ngraham, #frameworks, broulik, cfeck, elvisangelaccio
Cc: achauvel, kde-frameworks-devel, michaelh, ngraham, bruns

D17371: [KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals

[Nathaniel Graham]

ngraham marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17371

To: ngraham, #frameworks, broulik, cfeck, elvisangelaccio
Cc: achauvel, kde-frameworks-devel, michaelh, ngraham, bruns

D17741: avoid blocking kio_http_cache_cleaner and ensure exit with session

[Martin Koller]

mkoller created this revision.
mkoller added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mkoller requested review of this revision.

REVISION SUMMARY
  Currently when logging out, kio_http_cache_cleaner stays alive and blocks in 
  QCoreApplication::processEvents(QEventLoop::WaitForMoreEvents);
  forever.
  
  This patch avoids this blocking and ensures that the main loop will exit when 
the session bus is no longer connected.

TEST PLAN
  logging in, check CPU load of kio_http_cache_cleaner, log out, check if 
kio_http_cache_cleaner still runs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17741

AFFECTED FILES
  http_cache_cleaner.cpp

To: mkoller, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17741: avoid blocking kio_http_cache_cleaner and ensure exit with session

[Martin Koller]

mkoller edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17741

To: mkoller, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17726: Add helper function to disable redirections (useful for kde-open)

[Mélanie Chauvel]

achauvel updated this revision to Diff 48028.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17726?vs=47986&id=48028

REVISION DETAIL
  https://phabricator.kde.org/D17726

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/krun.h
  src/widgets/krun_p.h

To: achauvel, dfaure, #frameworks, cfeck
Cc: yurchor, kde-frameworks-devel, michaelh, ngraham, bruns

D17743: Extend getExtensionFromPatternList reg exp filtering

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  getExtensionFromPatternList turns a filter string such "*.cpp" etc into
  an extension ".cpp".
  
  It tries to filter out any filter string that could be a glob pattern.
  However it didn't handle "[]" characters.
  
  See https://phabricator.kde.org/D17677 and D17738 


TEST PLAN
  Modified kfilewidgettest_gui test and confirmed
  that "automatically select file extension" checkbox didn't 
  insert irrelevant chars in the filename.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17743

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17726: Add helper function to disable redirections (useful for kde-open)

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17726

To: achauvel, dfaure, #frameworks, cfeck
Cc: yurchor, kde-frameworks-devel, michaelh, ngraham, bruns

D17629: Add method to BackgroundChecker to add word to session

[Martin Tobias Holmedahl Sandsmark]

sandsmark accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R246 Sonnet

BRANCH
  addWordToSession

REVISION DETAIL
  https://phabricator.kde.org/D17629

To: ahmadsamir, davidedmundson, cullmann, sandsmark
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17741: avoid blocking kio_http_cache_cleaner and ensure exit with session

[David Faure]

dfaure added a comment.


  I assume the processEvents() is necessary to process DBus disconnection, then?
  
  In that case let's add a comment, so the next person doesn't think this is 
unnecessary (it's certainly not necessary for the QLocalServer/QLocalSocket 
stuff).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17741

To: mkoller, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17371: [KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> krun.cpp:1423
> +// If a default browser isn't set in kdeglobals, fall back to 
> mimeapps.list
> +if (! d->m_externalBrowser.isEmpty()) {
> +return;

no space after "!"

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17371

To: ngraham, #frameworks, broulik, cfeck, elvisangelaccio, dfaure
Cc: dfaure, rdieter, achauvel, kde-frameworks-devel, michaelh, ngraham, bruns

D17737: [CopyJob] Create clones in btrf/xfs mount

[Stefan Brüns]

bruns added a comment.


  I think it would be much simpler if you just tried to do the the FICLONE 
iotctl in the job, without any prior checking:
  
  - no possibility for races
  - less syscals
  - less code

INLINE COMMENTS

> copyjob.cpp:742
> +if (!isDir && info.linkDest.isEmpty() && m_mode == CopyJob::Copy && 
> m_bDestSupportsCoW) {
> +const QString srcDevice = 
> KMountPoint::currentMountPoints().findByPath(info.uSource.toLocalFile())->mountedFrom();
> +info.bCreateClone = (srcDevice == m_destDevice);

it is *much* cheaper to compare the st_dev fields from stat for the source file 
and the destination directory.

> kmountpoint.cpp:471
>  || d->mountType == QLatin1String("smb-share");
> +const bool isCoWSupported = d->mountType == QLatin1String("btrfs") || 
> d->mountType == QLatin1String("xfs");
>  

This is not correct, xfs **may** support reflinks, but it is a feature only 
recently added, and has to be enabled at file system creation time.

> kmountpoint.h:145
>   * "foo" and "FOO" as being the same file (true for msdos systems)
> + * @li SupportsCoW: returns true if the filesystem supports Copy-on-Write
> + * (true for btrfs, xfs, etc.)

The correct term here is "reflink", not CoW.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17737

To: chinmoyr, dfaure, davidedmundson
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D17745: resolve tags to the commit, that was tagged..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  I have made sure that kde/pim is now cleanup in terms of the issue of "not 
runnig ABI", by triggering a rebuilt. So it is a good test if the patch is 
working.
  With more tests I have detected, that builds still use the oldest commit 
instead of tags commits (fix D17745 ) .

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

D17741: avoid blocking kio_http_cache_cleaner and ensure exit with session

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17741

To: mkoller, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17371: [KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals

[Nathaniel Graham]

ngraham updated this revision to Diff 48040.
ngraham marked an inline comment as done.
ngraham added a comment.


  Style fix

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17371?vs=48022&id=48040

BRANCH
  arcpatch-D17371

REVISION DETAIL
  https://phabricator.kde.org/D17371

AFFECTED FILES
  src/widgets/krun.cpp

To: ngraham, #frameworks, broulik, cfeck, elvisangelaccio, dfaure
Cc: dfaure, rdieter, achauvel, kde-frameworks-devel, michaelh, ngraham, bruns

D17371: [KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:7bd7f38400b9: [KRun] when asked to open link in external 
browser, fall back to mimeapps.list… (authored by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17371?vs=48040&id=48041

REVISION DETAIL
  https://phabricator.kde.org/D17371

AFFECTED FILES
  src/widgets/krun.cpp

To: ngraham, #frameworks, broulik, cfeck, elvisangelaccio, dfaure
Cc: dfaure, rdieter, achauvel, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 160 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/160/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sun, 23 Dec 2018 04:14:41 +
 Build duration:
2 min 31 sec and counting
   CONSOLE OUTPUT
  [...truncated 613 lines...][  3%] Built target protocoltojson_autogenScanning dependencies of target ktelnetservice5_autogenScanning dependencies of target httpheadertokenizetest_autogen[  3%] Built target kcookiejar5_autogen[  3%] Automatic MOC for target ktelnetservice5[  3%] Automatic MOC for target httpheadertokenizetestScanning dependencies of target httpfiltertest_autogen[  3%] Built target ktelnetservice5_autogen[  3%] Automatic MOC for target httpfiltertestScanning dependencies of target httpheaderdispositiontest_autogen[  3%] Built target kded_kcookiejar_autogen[  3%] Automatic MOC for target httpheaderdispositiontest[  3%] Built target httpheadertokenizetest_autogenScanning dependencies of target KF5KIONTLM[  3%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/kntlm.cpp.objkntlm.cppScanning dependencies of target protocoltojson[  3%] Built target httpheaderdispositiontest_autogen[  3%] Built target docs-kcontrol5-netpref-index-cache-bz2[  4%] Built target docs-kcontrol5-trash-index-cache-bz2[  4%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/des.cpp.obj[  3%] Building CXX object src/protocoltojson/CMakeFiles/protocoltojson.dir/main.cpp.obj[  4%] Built target docs-kcontrol5-smb-index-cache-bz2[  5%] Generating org.kde.KCookieServer.xml[  4%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/KF5KIONTLM_autogen/mocs_compilation.cpp.obj[  5%] Built target httpfiltertest_autogenmain.cpp[  5%] Built target docs-kcontrol5-webshortcuts-index-cache-bz2[  5%] Built target docs-kcontrol5-proxy-index-cache-bz2[  5%] Building CXX object src/protocoltojson/CMakeFiles/protocoltojson.dir/protocoltojson_autogen/mocs_compilation.cpp.obj[  5%] Built target docs-kcontrol5-useragent-index-cache-bz2mocs_compilation.cpp[  5%] Generating kcookieserveradaptor.cpp, kcookieserveradaptor.hqdbusxml2cpp: Cannot process input: 'C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/build/src/ioslaves/http/kcookiejar/org.kde.KCookieServer.xml'. Stop.jom: C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\src\ioslaves\http\kcookiejar\CMakeFiles\kded_kcookiejar.dir\build.make [src\ioslaves\http\kcookiejar\kcookieserveradaptor.cpp] Error 1jom: C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\CMakeFiles\Makefile2 [src\ioslaves\http\kcookiejar\CMakeFiles\kded_kcookiejar.dir\all] Error 2mocs_compilation.cppScanning dependencies of target ktelnetservice5[  5%] Building CXX object src/ioslaves/telnet/CMakeFiles/ktelnetservice5.dir/ktelnetservice.cpp.obj[  5%] Building CXX object src/ioslaves/telnet/CMakeFiles/ktelnetservice5.dir/ktelnetservice5_autogen/mocs_compilation.cpp.objktelnetservice.cppScanning dependencies of target httpheadertokenizetest[  5%] Generating kcookieserverinterface.cpp, kcookieserverinterface.hScanning dependencies of target httpfiltertestmocs_compilation.cppScanning dependencies of target httpheaderdispositiontest[  6%] Building CXX object autotests/http/CMakeFiles/httpheadertokenizetest.dir/httpheadertokenizetest.cpp.obj[  6%] Building CXX object autotests/http/CMakeFiles/httpheadertokenizetest.dir/httpheadertokenizetest_autogen/mocs_compilation.cpp.obj[  6%] Building CXX object autotests/http/CMakeFiles/httpfiltertest.dir/httpfiltertest.cpp.objdes.cpp[  6%] Building CXX object autotests/http/CMakeFiles/httpfiltertest.dir/__/__/src/ioslaves/http/httpfilter.cpp.objhttpheadertokenizetest.cpp[  6%] Building CXX object autotests/http/CMakeFiles/httpheaderdispositiontest.dir/httpheaderdispositiontest.cpp.obj[  6%] Generating kcookieserverinterface.mochttpfiltertest.cpphttpheaderdispositiontest.cpp[  7%] Building CXX object autotests/http/CMakeFiles/httpfiltertest.dir/httpfiltertest_autogen/mocs_compilation.cpp.objmocs_compilation.cpp[  7%] Building CXX object autotests/http/CMakeFiles/httpheaderdispositiontest.dir/httpheaderdispositiontest_autogen/mocs_compilation.cpp.objScanning dependencies of target kcookiejar5[  7%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/kcookiejar5_autogen/mocs_compilation.cpp.objmocs_compilation.cpp[  7%] Built target KF5KIOCore_autogen[  7%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/main.cpp.objmain.cpp[  7%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/kcookieserverinterface.cpp.obj[  7%] Linking CXX shared library ..\..\bin\KF5KIONTLM.dllC:\CI\WORKSP~1\FRAMEW~1\kio\KF5-QT~1.11\src\ioslaves\http\parsinghelpers.cpp(282): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[  7%] Linking CXX executable ..\..\bin\protocoltojson.exeC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\autotests\http\httpheadertokenizetest.

D17727: Get default web browser from xdg-settings if it’s not set in KDE

[Nathaniel Graham]

ngraham added a comment.


  D17371  just landed, so you can probably 
Abandon this now (it's under the Add Action... menu).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17727

To: achauvel
Cc: ngraham, rdieter, kde-frameworks-devel, michaelh, bruns

D17727: Get default web browser from xdg-settings if it’s not set in KDE

[Mélanie Chauvel]

achauvel abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17727

To: achauvel
Cc: ngraham, rdieter, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 95 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/95/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 23 Dec 2018 05:42:57 +
 Build duration:
1 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/8/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Sun, 23 Dec 2018 05:42:57 +
 Build duration:
1 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)