D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

2018-12-26 Thread loh tar 
loh.tar added a comment.


  > Btw., have you perhaps played a bit with the 
https://phabricator.kde.org/D12295 patch?
  
  No, but noticed it sometime in the past
  
  > If you use it, could you try that patch, too?
  
  Will try it

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17693

To: loh.tar, #ktexteditor
Cc: cullmann, sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, dhaumann

D17730: [WIP] Review KateStatusBar (based on D17729)

2018-12-26 Thread Christoph Cullmann 
cullmann added a comment.


  I am a bit confused which questions still need answers ;=)
  
  What I think about the current state of the patch:
  
  I am fine with it, beside that I think having the dictionary picker per 
default there takes to much space and one should have some "show XXX" in the 
context menu for it.
  
  I am fine with doing it all in one patch and I have no issues with the other 
changes.
  
  For the "should we use buttons": I think I tried that in the past and it did 
look horrible in many styles, but perhaps I am wrong ;)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17730

To: loh.tar, #ktexteditor
Cc: zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D17730: [WIP] Review KateStatusBar (based on D17729)

2018-12-26 Thread loh tar 
loh.tar updated this revision to Diff 48237.
loh.tar edited the test plan for this revision.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  - All in one diff
  - Rebased on master
  - Removed test plan
  - Will update Summary/Title before you commit

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17730?vs=48236&id=48237

REVISION DETAIL
  https://phabricator.kde.org/D17730

AFFECTED FILES
  src/view/katestatusbar.cpp

To: loh.tar, #ktexteditor
Cc: zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D17730: [WIP] Review KateStatusBar (based on D17729)

2018-12-26 Thread loh tar 
loh.tar updated this revision to Diff 48236.
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - Only show lineColLabel context menu when click on it and not somewhere on 
the bar
  
  As "usual" without all other patches.
  
  > No idea how the spell-checking code handles that.
  
  I have a working solution in the meantime. I may open a new Diff for that.
  
  > I think it is useful, but now the statusbar is very full.
  >  Could we make that configurable via context menu? Like we have "Show line 
count", ... there?
  
  Should be possible. Will look at it. Your comment to the next question?
  
  > I would like the status bar to get cut (if the status bar is scrollable or 
not, I personally dont care)
  
  About "cut" I have ATM no idea how to do that, and I guess nobody would like 
that. A Scrollbar may possible and a somehow
   "auto-wrap" behaviour too
  
  > will it be hard to implement?
  
  Hard to say ;-) The auto-wrap should be the most tricky
  
  @cullmann Let me know how much stuff I can add here or have remove. There are 
many possibilities left, e.g.
  
  > How about to change the "action-labels" to buttons? Thisway would it be 
less "quirky" and we would have a feedback that there is an action available 
when hovered by mouse
  
  I will upload a "all in one" diff for a better overview

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17730?vs=48000&id=48236

REVISION DETAIL
  https://phabricator.kde.org/D17730

AFFECTED FILES
  src/view/katestatusbar.cpp

To: loh.tar, #ktexteditor
Cc: zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D16643: Correct the accept flag of the event object on DragMove

2018-12-26 Thread trmdi 
trmdi edited the summary of this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D17812: Clean up tests build system

2018-12-26 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17812

To: vkrause, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17730: [WIP] Review KateStatusBar (based on D17729)

2018-12-26 Thread Francisco de Zuviría 
zetazeta added a comment.


  I don't know if it should be done in this revision but... I find it annoying 
that the status bar imposes a limit on the minimum width of the window.
  
  Let's say that I want a really small (20 chars width) instance of kwrite for 
note taking always on top - it cannot be done unless I hide the status bar. I 
would like the status bar to get cut (if the status bar is scrollable or not, I 
personally dont care)
  
  I could open a new bug on it, but since you are already working on the status 
bar... will it be hard to implement?
  
  Best regards

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17730

To: loh.tar, #ktexteditor
Cc: zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 13 - Still Unstable!

2018-12-26 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/13/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Wed, 26 Dec 2018 21:54:56 +
 Build duration:
6 min 23 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(254/289)88%
(254/289)68%
(32956/48222)51%
(15850/30978)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4431/4730)49%
(1696/3450)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5483/5523)58%
(996/1712)src.buffer88%
(15/17)88%
(15/17)90%
(1697/1881)76%
(1214/1596)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1869/3151)47%
(1564/3305)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(627/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(6/6)100%

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-26 Thread Christoph Cullmann 
cullmann added a comment.


  Btw., I have not played with the latest patch yet, but for the binary 
compatibility stuff: Nothing outside the KTextEditor:: namespace needs to be 
binary compatible.
  We don't install headers for these classes, they are just exported for the 
unit tests.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, 
kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, 
sars, dhaumann

D17630: Don't re-mark words added/ignored to the dictionary as misspelled

2018-12-26 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Makes sense, will push that after you fix the documentation for the other 
patch, thanks!

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-ontheflycheck-backgroundchecker

REVISION DETAIL
  https://phabricator.kde.org/D17630

To: ahmadsamir, cullmann, davidedmundson
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

2018-12-26 Thread Christoph Cullmann 
cullmann added a comment.


  I think the idea makes sense, thought I have no idea if the change in the 
updateView part is correct ;=)
  Others?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17661

To: loh.tar, #ktexteditor, #vdg
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D17128: DocumentPrivate: Remove comment mark when joining lines

2018-12-26 Thread Christoph Cullmann 
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  As said above, I think some "smart wrap" option and that can be used for it.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17128

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, head7, kfunk, sars

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 12 - Still Unstable!

2018-12-26 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/12/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Wed, 26 Dec 2018 21:22:59 +
 Build duration:
31 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(254/289)88%
(254/289)68%
(32952/48218)51%
(15850/30976)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4431/4730)49%
(1696/3450)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5483/5523)58%
(996/1712)src.buffer88%
(15/17)88%
(15/17)90%
(1697/1881)76%
(1214/1596)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1869/3151)47%
(1564/3305)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(627/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(6/6)100%

D17609: KTextEditor: Add action for static word wrap

2018-12-26 Thread Christoph Cullmann 
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:3a7a2d1ca986: KTextEditor: Add action for static word wrap 
(authored by loh.tar, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17609?vs=47632&id=48232

REVISION DETAIL
  https://phabricator.kde.org/D17609

AFFECTED FILES
  src/data/katepart5ui.rc
  src/view/kateview.cpp

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D17609: KTextEditor: Add action for static word wrap

2018-12-26 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Why not ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17609

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

2018-12-26 Thread Christoph Cullmann 
cullmann added a comment.


  I have no issues with freeing Fx keys.
  But perhaps we should think about that then in a more extended way: Do we 
really need Fx shortcuts at all for showing the left border stuff?
  People can add them and actually I would assume you once configure that and 
be done with it for the rest of your life.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17442

To: gregormi, #kate
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, hase, 
michaelh, bruns, demsking, sars

D17733: ViewPrivate: Don't hide 'Clear Dictionary Ranges' action

2018-12-26 Thread Christoph Cullmann 
cullmann added a comment.


  Last commit was for https://phabricator.kde.org/D17567

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17733

To: loh.tar, #ktexteditor, #vdg, ngraham
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D17730: [WIP] Review KateStatusBar (based on D17729)

2018-12-26 Thread Christoph Cullmann 
cullmann added a comment.


  In D17730#381237 , @loh.tar wrote:
  
  > > My main intent is to add somehow a spell check button/hint
  >
  > Here a snapshot how it looks currently
  >  F6503235: 1545570321.png 
  >
  > Sadly stuck I now, every help is appreciated
  >
  > I like to show on the button the current used dictionary (code), like 
"en_US". Because Kate support multible dictionary settings on a document, I 
miss a signal that the current dictionary has changed when the cursor moved 
into a new range. Note the few misspelled words in the pic.
  >
  > Is there a way to achieve this without to add new signal to somewhere, 
probably KTextEditor::DocumentPrivate ?
  
  
  Hmm, not sure about that ;=) No idea how the spell-checking code handles that.
  
  > Merry Christmas everybody!
  
  Same here!
  Happy holidays!
  
  ;=)
  
  For the added stuff: I think it is useful, but now the statusbar is very full.
  Could we make that configurable via context menu? Like we have "Show line 
count", ... there?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17730

To: loh.tar, #ktexteditor
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D17733: ViewPrivate: Don't hide 'Clear Dictionary Ranges' action

2018-12-26 Thread Christoph Cullmann 
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2c70c2184d70: ViewPrivate: Don't hide 'Clear 
Dictionary Ranges' action (authored by loh.tar, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17733?vs=48005&id=48231

REVISION DETAIL
  https://phabricator.kde.org/D17733

AFFECTED FILES
  src/view/kateview.cpp

To: loh.tar, #ktexteditor, #vdg, ngraham
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17629: Add method to BackgroundChecker to add word to session

2018-12-26 Thread Christoph Cullmann 
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  The old API is lacking docs, too, but could we have some doxygen comment for 
this with some @since version, too?
  Thanks.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17629

To: ahmadsamir, davidedmundson, cullmann, sandsmark
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

2018-12-26 Thread Christoph Cullmann 
cullmann added a comment.


  Btw., have you perhaps played a bit with the 
https://phabricator.kde.org/D12295 patch?
  I tried it once and it did behave ok, but I don'T use that feature that often.
  If you use it, could you try that patch, too?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17693

To: loh.tar, #ktexteditor
Cc: cullmann, sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, dhaumann

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

2018-12-26 Thread Christoph Cullmann 
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:5dde33b16bca: KateStatusBar: Reformatted by astyle command 
to follow coding style (authored by loh.tar, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17729?vs=48054&id=48229

REVISION DETAIL
  https://phabricator.kde.org/D17729

AFFECTED FILES
  src/view/katestatusbar.cpp
  src/view/katestatusbar.h

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, dhaumann

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

2018-12-26 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I am fine with that.
  Actually, if there is a astyle commandline that enforces the right style, 
could you paste it here?
  I am in favor of some script that runs that over the repo and just applying 
that regularly to enforce it stays sane, that is much more useful than to 
review each ( placement in all commits ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17729

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, dhaumann

D17812: Clean up tests build system

2018-12-26 Thread Volker Krause 
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  No need to search for ECM here again, and nothing in here needs Qt5::Test
  either.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17812

AFFECTED FILES
  tests/CMakeLists.txt

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17808: Don't force Phonon on Android

2018-12-26 Thread Volker Krause 
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:4b551eb9d5ee: Don't force Phonon on Android 
(authored by vkrause).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17808?vs=48219&id=48226

REVISION DETAIL
  https://phabricator.kde.org/D17808

AFFECTED FILES
  CMakeLists.txt

To: vkrause, bshah
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17802: Hide API documentation of internal classes

2018-12-26 Thread Dominik Haumann 
dhaumann added a comment.


  Another solution is to mark the class @internal. It is still visible then on 
api.kde.org, though.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D17802

To: vkrause, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D16643: Correct the accept flag of the event object on DragMove

2018-12-26 Thread Nathaniel Graham 
ngraham added a comment.


  A lot of folks are probably out on vacation, BTW.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

2018-12-26 Thread trmdi 
trmdi added a comment.


  What will happen if @bruns doesn't want to reply here anymore?
  I've updated the patch, can you review it ? @broulik

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 1 - Failure!

2018-12-26 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/1/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Wed, 26 Dec 2018 14:18:32 +
 Build duration:
59 sec and counting
   CONSOLE OUTPUT
  [...truncated 15 lines...]Cloning repository git://anongit.kde.org/prison > git init /home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11 # timeout=10Fetching upstream changes from git://anongit.kde.org/prison > git --version # timeout=10 > git fetch --tags --progress git://anongit.kde.org/prison +refs/heads/*:refs/remotes/origin/* # timeout=120Checking out Revision c93dedc0f0544c936670733c6fdb6731e70b0c80 (origin/master)Commit message: "GIT_SILENT Upgrade KF5 version to 5.54.0."First time build. Skipping changelog.[Pipeline] checkoutCloning the remote Git repository > git config remote.origin.url git://anongit.kde.org/prison # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url git://anongit.kde.org/prison # timeout=10Fetching upstream changes from git://anongit.kde.org/prison > git fetch --tags --progress git://anongit.kde.org/prison +refs/heads/*:refs/remotes/origin/* # timeout=120 > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f c93dedc0f0544c936670733c6fdb6731e70b0c80Cloning repository https://anongit.kde.org/sysadmin/ci-tooling > git init /home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/*Checking out Revision 0415899ef7d47d645d6c05e2518f4c7d825f6f1c (origin/master)Commit message: "cleanup++"[Pipeline] checkoutCloning the remote Git repository > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f 0415899ef7d47d645d6c05e2518f4c7d825f6f1cCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/*Checking out Revision 4c4d9e2b7ea1b8da4b77a13fb82e61a83601682e (origin/master)Commit message: "Track kdesrc-build under KF5 branches"[Pipeline] checkoutCloning the remote Git repository > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f 4c4d9e2b7ea1b8da4b77a13fb82e61a83601682eCloning repository https://anongit.kde.org/kde-build-metadata > git init /home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/*Checking out Revision 0855447437d58da5de03c79d55b96cf3f8d1eef2 (origin/master)Commit message: "Fix Python 3 warning" > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f 0855447437d58da5de03c79d55b96cf3f8d1eef2[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh+ python3 -u ci-tooling/helpers/prepare-dependencies

D17808: Don't force Phonon on Android

2018-12-26 Thread Bhushan Shah 
bshah accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17808

To: vkrause, bshah
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17808: Don't force Phonon on Android

2018-12-26 Thread Volker Krause 
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  The only notification backend that really makes sense on Android is
  using the native notification system, not our own stuff. That has yet
  to be written of course, but the first step is getting the framework
  to build.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17808

AFFECTED FILES
  CMakeLists.txt

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17629: Add method to BackgroundChecker to add word to session

2018-12-26 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 48218.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  arc diff verbatim

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17629?vs=48217&id=48218

BRANCH
  addWordToSession

REVISION DETAIL
  https://phabricator.kde.org/D17629

AFFECTED FILES
  src/core/backgroundchecker.cpp
  src/core/backgroundchecker.h

To: ahmadsamir, davidedmundson, cullmann, sandsmark
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17629: Add method to BackgroundChecker to add word to session

2018-12-26 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 48217.
ahmadsamir added a comment.


  Fix commit message

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17629?vs=47683&id=48217

BRANCH
  addWordToSession

REVISION DETAIL
  https://phabricator.kde.org/D17629

AFFECTED FILES
  src/core/backgroundchecker.cpp
  src/core/backgroundchecker.h

To: ahmadsamir, davidedmundson, cullmann, sandsmark
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17802: Hide API documentation of internal classes

2018-12-26 Thread Volker Krause 
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:e3d07cec0b6f: Hide API documentation of internal classes 
(authored by vkrause).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17802?vs=48202&id=48216

REVISION DETAIL
  https://phabricator.kde.org/D17802

AFFECTED FILES
  docs/Doxyfile.local

To: vkrause, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D17802: Hide API documentation of internal classes

2018-12-26 Thread Volker Krause 
vkrause added a comment.


  This is about classes like 
https://api.kde.org/frameworks/knotifications/html/classNotifyByPopupGrowl.html.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17802

To: vkrause, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D17802: Hide API documentation of internal classes

2018-12-26 Thread Dominik Haumann 
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  A bit more verbose description on why this patch is needed and a link to the 
generated page on api.kde.org would be useful :)
  
  PS: KTextEditor also shows hundreds of classes that are internal API. Only 
the classes in the KTextEditor namespace are public (unfortunately, this fact 
is mostly only known by KTextEditor developers).

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17802

To: vkrause, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns