D17817: Build without D-Bus on Android

[Volker Krause]

vkrause added a comment.


  In D17817#383354 , @dhaumann wrote:
  
  > +1, although it will likely break quickly since this branch is not tested 
via CI. Then again, this is also vslid for e.g. the KSyntaxHighlighting 
branches that were added for standalone deployment.
  
  
  At least the binary factory build for KDE Itinerary should be testing this 
configuration. And AFAIK there are also some KF5 Android builds on the CI.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D17817

To: vkrause
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST and new preference icons

[Noah Davis]

ndavis added a comment.


  > (again, not taking size constraints into consideration)
  
  This is what is wrong with the test. I've set the size constraints for 
apps/32 to not overlap with apps/48, so there should be no problem. apps/48 
does overlap with apps/64, but apps/64 isn't that important, so I can remove 
that from the patch.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: sitter, fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

[Nathaniel Graham]

ngraham added a subscriber: sitter.
ngraham added a comment.


  @sitter added the test in 7d01f3d8b5c0f2c9dc6014e8e04ba5701804fec2 
. 
Maybe he can shed some light on the best course of action here.
  
  Pertinent quote from the commit message:
  
test_scalableDuplicates asserts that each scalable icon only appears in one 
scalable directory. specifically if more than one scalable variant is available 
the icon theme spec does not specify that the closest match is used, but among 
scalable versions all are considered equal so the first wins. this is a problem 
if apps/48/klipper.svg and apps/32/klipper.svg exist and both are marked 
scalable but they have different visuals. in one application the 32 version 
might get used and in another the 48 version is used. this tests prevents this 
by enforcing the equality by means of not allowing multiple scalable variants 
(again, not taking size constraints into consideration)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: sitter, fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

[Noah Davis]

ndavis added a comment.


  OK, so it seems I can't have multiple scalable directories with different 
versions of the same icon when the directories have the Application context. 
This test is such a pain in the ass. I know most tests are there for a good 
reason, but this one has only ever gotten in my way and forced me to work 
around it. Should I just toss all the yast icons into preferences even though 
it's meant for KDE settings icons? I could make a brand new folder too, but it 
would basically be just for YaST icons and any other 3rd party control panel 
apps that happen to use 32px icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

[Nathaniel Graham]

ngraham added a comment.


  Look in `Testing/Temporary/LastTest.log`

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

[Noah Davis]

ndavis added a comment.


  In D17623#383392 , @ngraham wrote:
  
  > With the latest change, this now fails the `scalable` test.
  
  
  How do I see what tests a patch will pass or fail?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  With the latest change, this now fails the `scalable` test.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  yast-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  yast-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

[Noah Davis]

ndavis updated this revision to Diff 48332.
ndavis added a comment.


  Add most recent changes to breeze dark

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17623?vs=48331=48332

BRANCH
  yast-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17623

AFFECTED FILES
  icons-dark/apps/32/hwinfo.svg
  icons-dark/apps/32/system-help.svg
  icons-dark/apps/32/systemsettings.svg
  icons-dark/apps/32/utilities-log-viewer.svg
  icons-dark/apps/32/yast-addon.svg
  icons-dark/apps/32/yast-alternatives.svg
  icons-dark/apps/32/yast-apparmor.svg
  icons-dark/apps/32/yast-auth-client.svg
  icons-dark/apps/32/yast-autoyast.svg
  icons-dark/apps/32/yast-bootloader.svg
  icons-dark/apps/32/yast-checkmedia.svg
  icons-dark/apps/32/yast-create-new-vm.svg
  icons-dark/apps/32/yast-device-tree.svg
  icons-dark/apps/32/yast-dhcp-server.svg
  icons-dark/apps/32/yast-disk.svg
  icons-dark/apps/32/yast-dns-server.svg
  icons-dark/apps/32/yast-docker.svg
  icons-dark/apps/32/yast-dsl.svg
  icons-dark/apps/32/yast-fcoe.svg
  icons-dark/apps/32/yast-firewall.svg
  icons-dark/apps/32/yast-fonts.svg
  icons-dark/apps/32/yast-ftp-server.svg
  icons-dark/apps/32/yast-hardware.svg
  icons-dark/apps/32/yast-host.svg
  icons-dark/apps/32/yast-http-server.svg
  icons-dark/apps/32/yast-hwinfo.svg
  icons-dark/apps/32/yast-instserver.svg
  icons-dark/apps/32/yast-iscsi-client.svg
  icons-dark/apps/32/yast-iscsi-server.svg
  icons-dark/apps/32/yast-journal.svg
  icons-dark/apps/32/yast-kerberos-server.svg
  icons-dark/apps/32/yast-kernel.svg
  icons-dark/apps/32/yast-keyboard.svg
  icons-dark/apps/32/yast-lan.svg
  icons-dark/apps/32/yast-language.svg
  icons-dark/apps/32/yast-ldap-server.svg
  icons-dark/apps/32/yast-ldap.svg
  icons-dark/apps/32/yast-mail.svg
  icons-dark/apps/32/yast-messages.svg
  icons-dark/apps/32/yast-misc.svg
  icons-dark/apps/32/yast-network.svg
  icons-dark/apps/32/yast-nfs-server.svg
  icons-dark/apps/32/yast-nfs.svg
  icons-dark/apps/32/yast-nis-server.svg
  icons-dark/apps/32/yast-nis.svg
  icons-dark/apps/32/yast-ntp-client.svg
  icons-dark/apps/32/yast-printer.svg
  icons-dark/apps/32/yast-proxy.svg
  icons-dark/apps/32/yast-release-notes.svg
  icons-dark/apps/32/yast-remote.svg
  icons-dark/apps/32/yast-samba-client.svg
  icons-dark/apps/32/yast-samba-server.svg
  icons-dark/apps/32/yast-scanner.svg
  icons-dark/apps/32/yast-security.svg
  icons-dark/apps/32/yast-services-manager.svg
  icons-dark/apps/32/yast-slp-server.svg
  icons-dark/apps/32/yast-snapper.svg
  icons-dark/apps/32/yast-software.svg
  icons-dark/apps/32/yast-sound.svg
  icons-dark/apps/32/yast-sudo.svg
  icons-dark/apps/32/yast-support.svg
  icons-dark/apps/32/yast-sw_single.svg
  icons-dark/apps/32/yast-sw_source.svg
  icons-dark/apps/32/yast-sysconfig.svg
  icons-dark/apps/32/yast-system.svg
  icons-dark/apps/32/yast-tftp-server.svg
  icons-dark/apps/32/yast-timezone.svg
  icons-dark/apps/32/yast-update.svg
  icons-dark/apps/32/yast-users.svg
  icons-dark/apps/32/yast-vm-install.svg
  icons-dark/apps/32/yast-vm-migrate.svg
  icons-dark/apps/32/yast-vm.svg
  icons-dark/apps/32/yast-vpn.svg
  icons-dark/apps/32/yast-wol.svg
  icons-dark/apps/32/yast.svg
  icons-dark/apps/48/yast-installation.svg
  icons-dark/apps/48/yast-sw_single.svg
  icons-dark/apps/48/yast.svg
  icons-dark/index.theme
  icons-dark/preferences/32/preferences-devices-cpu.svg
  icons-dark/preferences/32/preferences-devices-drive-optical-check.svg
  icons-dark/preferences/32/preferences-devices-printer.svg
  icons-dark/preferences/32/preferences-devices-scanner.svg
  icons-dark/preferences/32/preferences-devices-tree.svg
  icons-dark/preferences/32/preferences-log.svg
  icons-dark/preferences/32/preferences-releasenotes.svg
  icons-dark/preferences/32/preferences-security-apparmor.svg
  icons-dark/preferences/32/preferences-security-firewall.svg
  icons-dark/preferences/32/preferences-security-kerberos.svg
  icons-dark/preferences/32/preferences-security.svg
  icons-dark/preferences/32/preferences-system-backup.svg
  icons-dark/preferences/32/preferences-system-linux.svg
  icons-dark/preferences/32/preferences-system-network-dsl.svg
  icons-dark/preferences/32/preferences-system-network-ethernet.svg
  icons-dark/preferences/32/preferences-system-network-iscsi.svg
  icons-dark/preferences/32/preferences-system-network-ldap.svg
  icons-dark/preferences/32/preferences-system-network-nis.svg
  icons-dark/preferences/32/preferences-system-network-ntp.svg
  icons-dark/preferences/32/preferences-system-network-proxy.svg
  icons-dark/preferences/32/preferences-system-network-remote.svg
  icons-dark/preferences/32/preferences-system-network-samba.svg
  icons-dark/preferences/32/preferences-system-network-server-boot.svg
  icons-dark/preferences/32/preferences-system-network-server-dhcp.svg
  icons-dark/preferences/32/preferences-system-network-server-dns.svg
  

D17623: Add YaST and new preference icons

[Noah Davis]

ndavis updated this revision to Diff 48331.
ndavis added a comment.


  fix yast-installation

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17623?vs=48329=48331

BRANCH
  yast-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17623

AFFECTED FILES
  icons-dark/apps/32/hwinfo.svg
  icons-dark/apps/32/system-help.svg
  icons-dark/apps/32/systemsettings.svg
  icons-dark/apps/32/utilities-log-viewer.svg
  icons-dark/apps/32/yast-addon.svg
  icons-dark/apps/32/yast-alternatives.svg
  icons-dark/apps/32/yast-apparmor.svg
  icons-dark/apps/32/yast-auth-client.svg
  icons-dark/apps/32/yast-autoyast.svg
  icons-dark/apps/32/yast-bootloader.svg
  icons-dark/apps/32/yast-checkmedia.svg
  icons-dark/apps/32/yast-create-new-vm.svg
  icons-dark/apps/32/yast-device-tree.svg
  icons-dark/apps/32/yast-dhcp-server.svg
  icons-dark/apps/32/yast-disk.svg
  icons-dark/apps/32/yast-dns-server.svg
  icons-dark/apps/32/yast-docker.svg
  icons-dark/apps/32/yast-dsl.svg
  icons-dark/apps/32/yast-fcoe.svg
  icons-dark/apps/32/yast-firewall.svg
  icons-dark/apps/32/yast-fonts.svg
  icons-dark/apps/32/yast-ftp-server.svg
  icons-dark/apps/32/yast-hardware.svg
  icons-dark/apps/32/yast-host.svg
  icons-dark/apps/32/yast-http-server.svg
  icons-dark/apps/32/yast-hwinfo.svg
  icons-dark/apps/32/yast-instserver.svg
  icons-dark/apps/32/yast-iscsi-client.svg
  icons-dark/apps/32/yast-iscsi-server.svg
  icons-dark/apps/32/yast-journal.svg
  icons-dark/apps/32/yast-kerberos-server.svg
  icons-dark/apps/32/yast-kernel.svg
  icons-dark/apps/32/yast-keyboard.svg
  icons-dark/apps/32/yast-lan.svg
  icons-dark/apps/32/yast-language.svg
  icons-dark/apps/32/yast-ldap-server.svg
  icons-dark/apps/32/yast-ldap.svg
  icons-dark/apps/32/yast-mail.svg
  icons-dark/apps/32/yast-messages.svg
  icons-dark/apps/32/yast-misc.svg
  icons-dark/apps/32/yast-network.svg
  icons-dark/apps/32/yast-nfs-server.svg
  icons-dark/apps/32/yast-nfs.svg
  icons-dark/apps/32/yast-nis-server.svg
  icons-dark/apps/32/yast-nis.svg
  icons-dark/apps/32/yast-ntp-client.svg
  icons-dark/apps/32/yast-printer.svg
  icons-dark/apps/32/yast-proxy.svg
  icons-dark/apps/32/yast-release-notes.svg
  icons-dark/apps/32/yast-remote.svg
  icons-dark/apps/32/yast-samba-client.svg
  icons-dark/apps/32/yast-samba-server.svg
  icons-dark/apps/32/yast-scanner.svg
  icons-dark/apps/32/yast-security.svg
  icons-dark/apps/32/yast-services-manager.svg
  icons-dark/apps/32/yast-slp-server.svg
  icons-dark/apps/32/yast-snapper.svg
  icons-dark/apps/32/yast-software.svg
  icons-dark/apps/32/yast-sound.svg
  icons-dark/apps/32/yast-sudo.svg
  icons-dark/apps/32/yast-support.svg
  icons-dark/apps/32/yast-sw_single.svg
  icons-dark/apps/32/yast-sw_source.svg
  icons-dark/apps/32/yast-sysconfig.svg
  icons-dark/apps/32/yast-system.svg
  icons-dark/apps/32/yast-tftp-server.svg
  icons-dark/apps/32/yast-timezone.svg
  icons-dark/apps/32/yast-update.svg
  icons-dark/apps/32/yast-users.svg
  icons-dark/apps/32/yast-vm-install.svg
  icons-dark/apps/32/yast-vm-migrate.svg
  icons-dark/apps/32/yast-vm.svg
  icons-dark/apps/32/yast-vpn.svg
  icons-dark/apps/32/yast-wol.svg
  icons-dark/apps/32/yast.svg
  icons-dark/apps/48/yast-installation.svg
  icons-dark/apps/48/yast-sw_single.svg
  icons-dark/apps/48/yast.svg
  icons-dark/index.theme
  icons-dark/preferences/32/preferences-devices-cpu.svg
  icons-dark/preferences/32/preferences-devices-drive-optical-check.svg
  icons-dark/preferences/32/preferences-devices-printer.svg
  icons-dark/preferences/32/preferences-devices-scanner.svg
  icons-dark/preferences/32/preferences-devices-tree.svg
  icons-dark/preferences/32/preferences-log.svg
  icons-dark/preferences/32/preferences-releasenotes.svg
  icons-dark/preferences/32/preferences-security-apparmor.svg
  icons-dark/preferences/32/preferences-security-firewall.svg
  icons-dark/preferences/32/preferences-security-kerberos.svg
  icons-dark/preferences/32/preferences-security.svg
  icons-dark/preferences/32/preferences-system-backup.svg
  icons-dark/preferences/32/preferences-system-linux.svg
  icons-dark/preferences/32/preferences-system-network-dsl.svg
  icons-dark/preferences/32/preferences-system-network-ethernet.svg
  icons-dark/preferences/32/preferences-system-network-iscsi.svg
  icons-dark/preferences/32/preferences-system-network-ldap.svg
  icons-dark/preferences/32/preferences-system-network-nis.svg
  icons-dark/preferences/32/preferences-system-network-ntp.svg
  icons-dark/preferences/32/preferences-system-network-proxy.svg
  icons-dark/preferences/32/preferences-system-network-remote.svg
  icons-dark/preferences/32/preferences-system-network-samba.svg
  icons-dark/preferences/32/preferences-system-network-server-boot.svg
  icons-dark/preferences/32/preferences-system-network-server-dhcp.svg
  icons-dark/preferences/32/preferences-system-network-server-dns.svg
  icons-dark/preferences/32/preferences-system-network-server-ftp.svg
  

D17692: Add a proper python-bytecode icon, use consistent color in python icons

[Nathaniel Graham]

ngraham added a comment.


  I've fixed the symlink issue in master, so now both 
`application-x-python-bytecode` and `text-x-python3` are both symlinks pointing 
to `text-x-python` You'll need to re-base this patch.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17692

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

[Noah Davis]

ndavis added a comment.


  F6513963: Screenshot_20181228_223854.png 

  
  I'm guessing I'll need to either do manual edits in the XML or recreate them 
from scratch.

REPOSITORY
  R266 Breeze Icons

BRANCH
  yast-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  How strange, you're right! I never noticed that. Oh well, material for 
another patch I suppose...

REPOSITORY
  R266 Breeze Icons

BRANCH
  yast-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

[Noah Davis]

ndavis added a comment.


  In D17623#383376 , @ngraham wrote:
  
  > Outstanding. Only one final issue that I can see: the long shadow cast by 
the arrow in `yast-installation` doesn't fade out; it just continues off the 
rest of the icon:
  >
  > F6513961: Screenshot_20181228_203322.png 

  
  
  Oddly, it does not look like that in Inkscape. The Ubiquity and Calamares 
installer icons also have the same problem.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

[Nathaniel Graham]

ngraham added a comment.


  Outstanding. Only one final issue that I can see: the long shadow cast by the 
arrow in `yast-installation` doesn't fade out; it just continues off the rest 
of the icon:
  
  F6513961: Screenshot_20181228_203322.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

[Noah Davis]

ndavis updated this revision to Diff 48329.
ndavis added a comment.


  Shift servers in dhcp and dns server icons to the right a bit and fix the 
shadow of the services icon

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17623?vs=48297=48329

BRANCH
  yast-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17623

AFFECTED FILES
  icons-dark/apps/32/hwinfo.svg
  icons-dark/apps/32/system-help.svg
  icons-dark/apps/32/systemsettings.svg
  icons-dark/apps/32/utilities-log-viewer.svg
  icons-dark/apps/32/yast-addon.svg
  icons-dark/apps/32/yast-alternatives.svg
  icons-dark/apps/32/yast-apparmor.svg
  icons-dark/apps/32/yast-auth-client.svg
  icons-dark/apps/32/yast-autoyast.svg
  icons-dark/apps/32/yast-bootloader.svg
  icons-dark/apps/32/yast-checkmedia.svg
  icons-dark/apps/32/yast-create-new-vm.svg
  icons-dark/apps/32/yast-device-tree.svg
  icons-dark/apps/32/yast-dhcp-server.svg
  icons-dark/apps/32/yast-disk.svg
  icons-dark/apps/32/yast-dns-server.svg
  icons-dark/apps/32/yast-docker.svg
  icons-dark/apps/32/yast-dsl.svg
  icons-dark/apps/32/yast-fcoe.svg
  icons-dark/apps/32/yast-firewall.svg
  icons-dark/apps/32/yast-fonts.svg
  icons-dark/apps/32/yast-ftp-server.svg
  icons-dark/apps/32/yast-hardware.svg
  icons-dark/apps/32/yast-host.svg
  icons-dark/apps/32/yast-http-server.svg
  icons-dark/apps/32/yast-hwinfo.svg
  icons-dark/apps/32/yast-instserver.svg
  icons-dark/apps/32/yast-iscsi-client.svg
  icons-dark/apps/32/yast-iscsi-server.svg
  icons-dark/apps/32/yast-journal.svg
  icons-dark/apps/32/yast-kerberos-server.svg
  icons-dark/apps/32/yast-kernel.svg
  icons-dark/apps/32/yast-keyboard.svg
  icons-dark/apps/32/yast-lan.svg
  icons-dark/apps/32/yast-language.svg
  icons-dark/apps/32/yast-ldap-server.svg
  icons-dark/apps/32/yast-ldap.svg
  icons-dark/apps/32/yast-mail.svg
  icons-dark/apps/32/yast-messages.svg
  icons-dark/apps/32/yast-misc.svg
  icons-dark/apps/32/yast-network.svg
  icons-dark/apps/32/yast-nfs-server.svg
  icons-dark/apps/32/yast-nfs.svg
  icons-dark/apps/32/yast-nis-server.svg
  icons-dark/apps/32/yast-nis.svg
  icons-dark/apps/32/yast-ntp-client.svg
  icons-dark/apps/32/yast-printer.svg
  icons-dark/apps/32/yast-proxy.svg
  icons-dark/apps/32/yast-release-notes.svg
  icons-dark/apps/32/yast-remote.svg
  icons-dark/apps/32/yast-samba-client.svg
  icons-dark/apps/32/yast-samba-server.svg
  icons-dark/apps/32/yast-scanner.svg
  icons-dark/apps/32/yast-security.svg
  icons-dark/apps/32/yast-services-manager.svg
  icons-dark/apps/32/yast-slp-server.svg
  icons-dark/apps/32/yast-snapper.svg
  icons-dark/apps/32/yast-software.svg
  icons-dark/apps/32/yast-sound.svg
  icons-dark/apps/32/yast-sudo.svg
  icons-dark/apps/32/yast-support.svg
  icons-dark/apps/32/yast-sw_single.svg
  icons-dark/apps/32/yast-sw_source.svg
  icons-dark/apps/32/yast-sysconfig.svg
  icons-dark/apps/32/yast-system.svg
  icons-dark/apps/32/yast-tftp-server.svg
  icons-dark/apps/32/yast-timezone.svg
  icons-dark/apps/32/yast-update.svg
  icons-dark/apps/32/yast-users.svg
  icons-dark/apps/32/yast-vm-install.svg
  icons-dark/apps/32/yast-vm-migrate.svg
  icons-dark/apps/32/yast-vm.svg
  icons-dark/apps/32/yast-vpn.svg
  icons-dark/apps/32/yast-wol.svg
  icons-dark/apps/32/yast.svg
  icons-dark/apps/48/yast-installation.svg
  icons-dark/apps/48/yast-sw_single.svg
  icons-dark/apps/48/yast.svg
  icons-dark/index.theme
  icons-dark/preferences/32/preferences-devices-cpu.svg
  icons-dark/preferences/32/preferences-devices-drive-optical-check.svg
  icons-dark/preferences/32/preferences-devices-printer.svg
  icons-dark/preferences/32/preferences-devices-scanner.svg
  icons-dark/preferences/32/preferences-devices-tree.svg
  icons-dark/preferences/32/preferences-log.svg
  icons-dark/preferences/32/preferences-releasenotes.svg
  icons-dark/preferences/32/preferences-security-apparmor.svg
  icons-dark/preferences/32/preferences-security-firewall.svg
  icons-dark/preferences/32/preferences-security-kerberos.svg
  icons-dark/preferences/32/preferences-security.svg
  icons-dark/preferences/32/preferences-system-backup.svg
  icons-dark/preferences/32/preferences-system-linux.svg
  icons-dark/preferences/32/preferences-system-network-dsl.svg
  icons-dark/preferences/32/preferences-system-network-ethernet.svg
  icons-dark/preferences/32/preferences-system-network-iscsi.svg
  icons-dark/preferences/32/preferences-system-network-ldap.svg
  icons-dark/preferences/32/preferences-system-network-nis.svg
  icons-dark/preferences/32/preferences-system-network-ntp.svg
  icons-dark/preferences/32/preferences-system-network-proxy.svg
  icons-dark/preferences/32/preferences-system-network-remote.svg
  icons-dark/preferences/32/preferences-system-network-samba.svg
  icons-dark/preferences/32/preferences-system-network-server-boot.svg
  icons-dark/preferences/32/preferences-system-network-server-dhcp.svg
  

D17651: Escape bytes that are larger than or equal to 127 in config files

[Albert Astals Cid]

aacid added a comment.


  In D17651#383320 , @vandenoever 
wrote
  
  > Can you give some more details? I see no problem on Jenkins. 
https://build.kde.org/job/Frameworks/job/kconfig/
  
  
  You need to look harder ;) Those yellow bubbles mean tests are failing
  
  https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.11/
  
  Build #3 was fine, build #4 broke the tests
  
  Build #4 was triggered by this patch 
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.11/4/
  
  Clearer now?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D17651

To: vandenoever, dfaure, arichardson, apol
Cc: aacid, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST and new preference icons

[Stasiek Michalski]

hellcp added a comment.


  That happens in Inkscape and other renderers with uneven (133%, 146% etc) 
magnification. When rendering also sometimes you will get a darker border when 
there is something dark behind an object. I used that to my advantage with new 
YaST Package Management icons
  
  F6513668: Screenshot from 2018-12-15 16-17-14.png 

  F6513669: Screenshot from 2018-12-15 16-22-53.png 

  Notice the difference between red elements, the first image depicts no darker 
object behind the red object and the second one depicts a darker object behind 
the red object (in the exact same position, exactly the same object, copied 
inside SVG XML file).

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 99 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/99/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 28 Dec 2018 23:57:03 +
 Build duration:
4 min 38 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

D17817: Build without D-Bus on Android

[Dominik Haumann]

dhaumann added a comment.


  +1, although it will likely break quickly since this branch is not tested via 
CI. Then again, this is also vslid for e.g. the KSyntaxHighlighting branches 
that were added for standalone deployment.
  
  Another +1 would be appreciated.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D17817

To: vkrause
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D17310: Improve Kile icon with LaTeX font

[Nathaniel Graham]

ngraham added a comment.


  #kile  folks, are you good with this 
now? If we don't hear back in a week or two, we'll have to assume yes. :)

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-kile-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17310

To: trickyricky26, #vdg, ngraham, #kile
Cc: loh.tar, mludwig, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

[Noah Davis]

ndavis added a comment.


  Here's the same icon in cuttlefish, except the line you saw on the bottom 
doesn't show up for me:
  F6513637: Screenshot_20181228_180802.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

[Noah Davis]

ndavis added a comment.


  In D17623#383325 , @ngraham wrote:
  
  > A few more little nitpicks:
  >
  > - `preferences-system-services` still has a shadow over the background 
rather than another part of itself: F6513586: shadow.png 

  
  
  I did that to hide a nasty vertical shadow cutoff point on the right side of 
the area between the bell and the stand.
  
  How is this? The shadow is slightly less dark due to the gradient being 
shifted and angled differently to avoid showing the vertical cutoff.
  F6513632: Screenshot_20181228_180401.png 

  
  > - All the the `preferences-system-network-server-*` icons have a little 
tiny line below the emblem at some sizes: F6513595: Line.png 

  
  That's a visual artifact that comes and goes when you zoom into an SVG where 
one element overlaps up to the edge of the other.
  
  > - `preferences-system-network-server-dns` has the server icon slightly 
shifted over to the left compared to all the others
  
  Are you sure? It's exactly the same as the others on my end.
  F6513611: Screenshot_20181228_174641.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

[Nathaniel Graham]

ngraham added a comment.


  A few more little nitpicks:
  
  - `preferences-system-services` still has a shadow over the background rather 
than another part of itself: F6513586: shadow.png 

  - All the the `preferences-system-network-server-*` icons have a little tiny 
line below the emblem at some sizes: F6513595: Line.png 

  - `preferences-system-network-server-dns` has the server icon slightly 
shifted over to the left compared to all the others

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

[Nathaniel Graham]

ngraham added a comment.


  `preferences/32/preferences-system-network-dsl.svg` and 
`preferences/32/preferences-system-network-ethernet.svg` are now very slightly 
different from the device icon versions. :) They have a bottom shadow, while 
the new device versions you just commitetd do not. Is the plan to symlink to 
the new device versions?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17651: Escape bytes that are larger than or equal to 127 in config files

[Jos van den Oever]

vandenoever added a comment.


  Can you give some more details? I see problem on Jenkins. 
https://build.kde.org/job/Frameworks/job/kconfig/
  
  Since my commits there was one more patch, but it's not related. 
https://cgit.kde.org/kconfig.git/commit/?id=d90a37b5a1d892d7b0ff7cc3b56c8a6e8c4bfe1a

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D17651

To: vandenoever, dfaure, arichardson, apol
Cc: aacid, apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/11/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 28 Dec 2018 21:51:58 +
 Build duration:
1 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 98 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/98/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 28 Dec 2018 21:51:58 +
 Build duration:
1 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

D17845: Add device icons for RJ11 and RJ45 ports

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:abed651411b9: Add device icons for RJ11 and RJ45 ports 
(authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17845?vs=48321=48322

REVISION DETAIL
  https://phabricator.kde.org/D17845

AFFECTED FILES
  icons-dark/devices/16/network-rj11-female.svg
  icons-dark/devices/16/network-rj45-female.svg
  icons-dark/devices/22/network-rj11-female.svg
  icons-dark/devices/22/network-rj45-female.svg
  icons-dark/devices/64/network-rj11-female.svg
  icons-dark/devices/64/network-rj45-female.svg
  icons/devices/16/network-rj11-female.svg
  icons/devices/16/network-rj45-female.svg
  icons/devices/22/network-rj11-female.svg
  icons/devices/22/network-rj45-female.svg
  icons/devices/64/network-rj11-female.svg
  icons/devices/64/network-rj45-female.svg

To: ndavis, #vdg, #breeze, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17845: Add device icons for RJ11 and RJ45 ports

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Shipit!

REPOSITORY
  R266 Breeze Icons

BRANCH
  network-jacks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17845

To: ndavis, #vdg, #breeze, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17845: Add device icons for RJ11 and RJ45 ports

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17845

To: ndavis, #vdg, #breeze
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17845: Add device icons for RJ11 and RJ45 ports

[Noah Davis]

ndavis updated this revision to Diff 48321.
ndavis added a comment.


  Update style

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17845?vs=48316=48321

BRANCH
  network-jacks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17845

AFFECTED FILES
  icons-dark/devices/16/network-rj11-female.svg
  icons-dark/devices/16/network-rj45-female.svg
  icons-dark/devices/22/network-rj11-female.svg
  icons-dark/devices/22/network-rj45-female.svg
  icons-dark/devices/64/network-rj11-female.svg
  icons-dark/devices/64/network-rj45-female.svg
  icons/devices/16/network-rj11-female.svg
  icons/devices/16/network-rj45-female.svg
  icons/devices/22/network-rj11-female.svg
  icons/devices/22/network-rj45-female.svg
  icons/devices/64/network-rj11-female.svg
  icons/devices/64/network-rj45-female.svg

To: ndavis, #vdg, #breeze
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17845: Add device icons for RJ11 and RJ45 ports

[Nathaniel Graham]

ngraham added a comment.


  In D17845#383277 , @ndavis wrote:
  
  > You mean like this?
  >  F6513525: Screenshot_20181228_160335.png 

  
  
  Yeah, I like that much better!
  
  Making the female version more femaley should hopefully make it easier to 
produce a contrasting male version later, should that ever be required.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17845

To: ndavis, #vdg, #breeze
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17845: Add device icons for RJ11 and RJ45 ports

[Noah Davis]

ndavis added a comment.


  In D17845#383266 , @ngraham wrote:
  
  > I love the full-color versions! For the monochrome ones, what do you think 
about putting them within a rounded rectangular frame like the full-color 
versions do? Right now the "femaleness" of the monochrome icons is not 
communicated as well as I think it could be; to me they look more like plugs 
than ports.
  
  
  You mean like this?
  F6513525: Screenshot_20181228_160335.png 

  
  To be honest, it's going to be a lot harder to create a good male version 
regardless of what the female version looks like. I only included the `-female` 
part because it's more accurate than just `rj*` and it at least leaves the 
option of implementing male versions, if that ever becomes necessary.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17845

To: ndavis, #vdg, #breeze
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D17845: Add device icons for RJ11 and RJ45 ports

[Nathaniel Graham]

ngraham added a comment.


  I love the full-color versions! For the monochrome ones, what do you think 
about putting them within a rounded rectangular frame like the full-color 
versions do? Right now the "femaleness" of the monochrome icons is not 
communicated as well as I think it could be; to me they look more like plugs 
than ports.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17845

To: ndavis, #vdg, #breeze
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17845: Add device icons for RJ11 and RJ45 ports

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17845

To: ndavis, #vdg, #breeze
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17845: Add device icons for RJ11 and RJ45 ports

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17845

To: ndavis, #vdg, #breeze
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17845: Add device icons for RJ11 and RJ45 ports

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Breeze.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  network-jacks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17845

AFFECTED FILES
  icons-dark/devices/16/network-rj11-female.svg
  icons-dark/devices/16/network-rj45-female.svg
  icons-dark/devices/22/network-rj11-female.svg
  icons-dark/devices/22/network-rj45-female.svg
  icons-dark/devices/64/network-rj11-female.svg
  icons-dark/devices/64/network-rj45-female.svg
  icons/devices/16/network-rj11-female.svg
  icons/devices/16/network-rj45-female.svg
  icons/devices/22/network-rj11-female.svg
  icons/devices/22/network-rj45-female.svg
  icons/devices/64/network-rj11-female.svg
  icons/devices/64/network-rj45-female.svg

To: ndavis, #vdg, #breeze
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17167: Provide a method of assigning custom default icons for non-XDG dirs

[Nathaniel Graham]

ngraham added a comment.


  In D17167#371906 , @cfeck wrote:
  
  > But why hardcode the list in the source, instead of reading it from a 
file/resource that the user could expand?
  
  
  I don't see the benefit of putting the data into a configuration file. The 
whole idea is to make KIO default to picking a nicer icon when the user creates 
a folder with a name that would benefit from having a a nice-looking Breeze 
icon rather than just the standard folder icon. Currently the only one in the 
list is "Games", but this could be extended over time for other useful folder 
names. E.g. "Books" "Source Code", etc.
  
  > Ideally, the "New Folder" dialog would have a button to pick an icon
  
  That sounds like a good idea. But even with that, this patch would still be 
useful because it could pre-populate that icon picker with a folder icon more 
appropriate than just the default one. For example when you type the name 
"Games" into the text field, the default icon in the picker would automatically 
change to `folder-games`.
  
  This doesn't add any new features that users can't already accomplish 
themselves using handmade .desktop files or the existing icon picker 
functionality. It just tries to make KIO a little smarter and more considerate 
about choosing the default icon when the user creates commonly-named folders. A 
user specifically requested this functionality in 
https://bugs.kde.org/show_bug.cgi?id=401218

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17167

To: ngraham, #frameworks, cfeck, broulik, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17797: Include applets/22

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  This needs to be rebased

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17797

To: nicolasfella, #breeze, ndavis
Cc: ndavis, kde-frameworks-devel, trickyricky26, michaelh, ngraham, bruns

D17617: Display error instead of silently failing when asked to create folder that already exists

[Nathaniel Graham]

ngraham added a comment.


  @elvisangelaccio?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17617

To: ngraham, #dolphin, elvisangelaccio, dfaure
Cc: anthonyfieroni, dfaure, emateli, elvisangelaccio, Codezela, 
kde-frameworks-devel, michaelh, ngraham, bruns

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D17843: python3.6 has no capture_output paramenter for 
subprocess.run..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D17651: Escape bytes that are larger than or equal to 127 in config files

[Albert Astals Cid]

aacid added a comment.


  You broke the tests with this change.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D17651

To: vandenoever, dfaure, arichardson, apol
Cc: aacid, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST and new preference icons

[Noah Davis]

ndavis updated this revision to Diff 48297.
ndavis added a comment.


  Change apps/32 to scalable and add apps/64 in index.theme

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17623?vs=48277=48297

BRANCH
  yast-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17623

AFFECTED FILES
  icons-dark/apps/32/hwinfo.svg
  icons-dark/apps/32/system-help.svg
  icons-dark/apps/32/systemsettings.svg
  icons-dark/apps/32/utilities-log-viewer.svg
  icons-dark/apps/32/yast-addon.svg
  icons-dark/apps/32/yast-alternatives.svg
  icons-dark/apps/32/yast-apparmor.svg
  icons-dark/apps/32/yast-auth-client.svg
  icons-dark/apps/32/yast-autoyast.svg
  icons-dark/apps/32/yast-bootloader.svg
  icons-dark/apps/32/yast-checkmedia.svg
  icons-dark/apps/32/yast-create-new-vm.svg
  icons-dark/apps/32/yast-device-tree.svg
  icons-dark/apps/32/yast-dhcp-server.svg
  icons-dark/apps/32/yast-disk.svg
  icons-dark/apps/32/yast-dns-server.svg
  icons-dark/apps/32/yast-docker.svg
  icons-dark/apps/32/yast-dsl.svg
  icons-dark/apps/32/yast-fcoe.svg
  icons-dark/apps/32/yast-firewall.svg
  icons-dark/apps/32/yast-fonts.svg
  icons-dark/apps/32/yast-ftp-server.svg
  icons-dark/apps/32/yast-hardware.svg
  icons-dark/apps/32/yast-host.svg
  icons-dark/apps/32/yast-http-server.svg
  icons-dark/apps/32/yast-hwinfo.svg
  icons-dark/apps/32/yast-instserver.svg
  icons-dark/apps/32/yast-iscsi-client.svg
  icons-dark/apps/32/yast-iscsi-server.svg
  icons-dark/apps/32/yast-journal.svg
  icons-dark/apps/32/yast-kerberos-server.svg
  icons-dark/apps/32/yast-kernel.svg
  icons-dark/apps/32/yast-keyboard.svg
  icons-dark/apps/32/yast-lan.svg
  icons-dark/apps/32/yast-language.svg
  icons-dark/apps/32/yast-ldap-server.svg
  icons-dark/apps/32/yast-ldap.svg
  icons-dark/apps/32/yast-mail.svg
  icons-dark/apps/32/yast-messages.svg
  icons-dark/apps/32/yast-misc.svg
  icons-dark/apps/32/yast-network.svg
  icons-dark/apps/32/yast-nfs-server.svg
  icons-dark/apps/32/yast-nfs.svg
  icons-dark/apps/32/yast-nis-server.svg
  icons-dark/apps/32/yast-nis.svg
  icons-dark/apps/32/yast-ntp-client.svg
  icons-dark/apps/32/yast-printer.svg
  icons-dark/apps/32/yast-proxy.svg
  icons-dark/apps/32/yast-release-notes.svg
  icons-dark/apps/32/yast-remote.svg
  icons-dark/apps/32/yast-samba-client.svg
  icons-dark/apps/32/yast-samba-server.svg
  icons-dark/apps/32/yast-scanner.svg
  icons-dark/apps/32/yast-security.svg
  icons-dark/apps/32/yast-services-manager.svg
  icons-dark/apps/32/yast-slp-server.svg
  icons-dark/apps/32/yast-snapper.svg
  icons-dark/apps/32/yast-software.svg
  icons-dark/apps/32/yast-sound.svg
  icons-dark/apps/32/yast-sudo.svg
  icons-dark/apps/32/yast-support.svg
  icons-dark/apps/32/yast-sw_single.svg
  icons-dark/apps/32/yast-sw_source.svg
  icons-dark/apps/32/yast-sysconfig.svg
  icons-dark/apps/32/yast-system.svg
  icons-dark/apps/32/yast-tftp-server.svg
  icons-dark/apps/32/yast-timezone.svg
  icons-dark/apps/32/yast-update.svg
  icons-dark/apps/32/yast-users.svg
  icons-dark/apps/32/yast-vm-install.svg
  icons-dark/apps/32/yast-vm-migrate.svg
  icons-dark/apps/32/yast-vm.svg
  icons-dark/apps/32/yast-vpn.svg
  icons-dark/apps/32/yast-wol.svg
  icons-dark/apps/32/yast.svg
  icons-dark/apps/48/yast-installation.svg
  icons-dark/apps/48/yast-sw_single.svg
  icons-dark/apps/48/yast.svg
  icons-dark/index.theme
  icons-dark/preferences/32/preferences-devices-cpu.svg
  icons-dark/preferences/32/preferences-devices-drive-optical-check.svg
  icons-dark/preferences/32/preferences-devices-printer.svg
  icons-dark/preferences/32/preferences-devices-scanner.svg
  icons-dark/preferences/32/preferences-devices-tree.svg
  icons-dark/preferences/32/preferences-log.svg
  icons-dark/preferences/32/preferences-releasenotes.svg
  icons-dark/preferences/32/preferences-security-apparmor.svg
  icons-dark/preferences/32/preferences-security-firewall.svg
  icons-dark/preferences/32/preferences-security-kerberos.svg
  icons-dark/preferences/32/preferences-security.svg
  icons-dark/preferences/32/preferences-system-backup.svg
  icons-dark/preferences/32/preferences-system-linux.svg
  icons-dark/preferences/32/preferences-system-network-dsl.svg
  icons-dark/preferences/32/preferences-system-network-ethernet.svg
  icons-dark/preferences/32/preferences-system-network-iscsi.svg
  icons-dark/preferences/32/preferences-system-network-ldap.svg
  icons-dark/preferences/32/preferences-system-network-nis.svg
  icons-dark/preferences/32/preferences-system-network-ntp.svg
  icons-dark/preferences/32/preferences-system-network-proxy.svg
  icons-dark/preferences/32/preferences-system-network-remote.svg
  icons-dark/preferences/32/preferences-system-network-samba.svg
  icons-dark/preferences/32/preferences-system-network-server-boot.svg
  icons-dark/preferences/32/preferences-system-network-server-dhcp.svg
  icons-dark/preferences/32/preferences-system-network-server-dns.svg
  

D17623: Add YaST and new preference icons

[Noah Davis]

ndavis added a comment.


  In D17623#382989 , @ngraham wrote:
  
  > In D17623#382912 , @ndavis wrote:
  >
  > > We still haven't figured out where to put all of the `yast-*` icons. Most 
of them are now symlinks to preferences icons, but that doesn't fix the fact 
that this patch can't pass the scalable test. This is because `apps/32` is a 
fixed size directory. I don't think `preferences/` should be used for the YaST 
icons because `preferences/` is meant to be used for our settings category 
icons and YaST is 3rd party. Would it be acceptable to change `apps/32` to the 
following?
  > >
  > >   [apps/32]
  > >   Size=32
  > >   Context=Applications
  > >   Type=Scalable
  > >   MinSize=24
  > >   MaxSize=32
  > >
  > >
  > > This way the icons can be used in YaST and Plasma won't try to use a 32px 
icon when a 48 px icon should be used for applications like Dolphin
  >
  >
  > I don't see why not. What would be the drawbacks of this approach that you 
can foresee?
  
  
  I don't see any, but it seems like a change that doesn't really do anything 
besides make it easier to satisfy the scalable test.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D17837: Switch to the new syntax (spaces -> tabs)..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D17836: add clang/7.0.0/include to make 
abi-compliance-checker happy again..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D17730: [WIP] Review KateStatusBar

[loh tar]

loh.tar updated this revision to Diff 48285.
loh.tar retitled this revision from "[WIP] Review KateStatusBar (based on 
D17729)" to "[WIP] Review KateStatusBar ".
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - Introduce StatusBarButton
  - Don't gray out m_modifiedLabel, Rename to m_modified to fit other naming
  - Revert 'Only show lineColLabel context menu when click on it'
  - Change m_lineColLabel to new StatusBarButton, Rename to m_cursorPosition to 
fit other naming
  - Change m_insertModeLabel to new StatusBarButton,  Rename to m_inputMode to 
fit other naming
  - Update Summary/Title
  
  The shown dictionary button is still not included in this patch
  F6513035: 1546012318.png 

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17730?vs=48237=48285

REVISION DETAIL
  https://phabricator.kde.org/D17730

AFFECTED FILES
  src/view/katestatusbar.cpp
  src/view/katestatusbar.h

To: loh.tar, #ktexteditor
Cc: zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D17816: Initial support for xattrs on kio copy/move

[Cochise César]

cochise added a comment.


  There is one use case (copy of dirs with rename, due name conflict) where the 
patches not work, and I can't test on *BSD or Mac.
  
  The first problem says I would need to add a very similar snippet in a third 
place, i trying to find right now, (any help from someone that knows KIO better 
than me is appreciated) but after this, we would need to rewrite as a function, 
to remove code duplication (and I'm open for suggestions of where to place it, 
as KIO is a rather big codebase). Baloo uses some very similar functions, from 
where i  so maybe we can unify the implementations in KIO level. So I'm 
planning to change things, but need some review to do this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure
Cc: ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, michaelh, 
bruns

D17623: Add YaST and new preference icons

[Nathaniel Graham]

ngraham added a comment.


  In D17623#382912 , @ndavis wrote:
  
  > We still haven't figured out where to put all of the `yast-*` icons. Most 
of them are now symlinks to preferences icons, but that doesn't fix the fact 
that this patch can't pass the scalable test. This is because `apps/32` is a 
fixed size directory. I don't think `preferences/` should be used for the YaST 
icons because `preferences/` is meant to be used for our settings category 
icons and YaST is 3rd party. Would it be acceptable to change `apps/32` to the 
following?
  >
  >   [apps/32]
  >   Size=32
  >   Context=Applications
  >   Type=Scalable
  >   MinSize=24
  >   MaxSize=32
  >
  >
  > This way the icons can be used in YaST and Plasma won't try to use a 32px 
icon when a 48 px icon should be used for applications like Dolphin
  
  
  I don't see why not. What would be the drawbacks of this approach that you 
can foresee?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17816: Initial support for xattrs on kio copy/move

[Nathaniel Graham]

ngraham added a comment.


  Thanks so much for working on this! Is it ready for review yet, or are you 
still changing things?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure
Cc: ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, michaelh, 
bruns

D17817: Build without D-Bus on Android

[Volker Krause]

vkrause updated this revision to Diff 48282.
vkrause added a comment.


  Remove accidentally added block that is not supposed to be part of this 
commit.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17817?vs=48241=48282

BRANCH
  arcpatch-D17817

REVISION DETAIL
  https://phabricator.kde.org/D17817

AFFECTED FILES
  CMakeLists.txt
  KF5NotificationsConfig.cmake.in
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/knotificationmanager.cpp
  tests/CMakeLists.txt

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15910: Implement wl_surface::damage_buffer

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> surface_interface.cpp:453
> +if (tr == Tr::Rotated90 || tr == Tr::Rotated270 ||
> +tr == Tr::Flipped90 || tr == Tr::Rotated270) {
> +// calculate transformed + scaled buffer damage

Should this last one be flipped 270?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15910

To: romangg, #kwin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.9 - Build # 62 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.9/62/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 28 Dec 2018 10:13:55 +
 Build duration:
7 min 50 sec and counting
   BUILD ARTIFACTS
  logs/KF5Config/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kconfigcore_kconfigtestName: projectroot.autotests Failed: 0 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 22 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)90%
(69/77)90%
(69/77)79%
(6804/8622)58%
(3525/6052)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)99%
(1941/1954)52%
(851/1625)autotests.kconfig_compiler96%
(24/25)96%
(24/25)92%
(277/301)47%
(96/206)src.core88%
(22/25)88%
(22/25)69%
(2382/3428)57%
(1233/2177)src.gui71%
(5/7)71%
(5/7)61%
(432/708)51%
(156/305)src.kconf_update100%
(2/2)100%
(2/2)72%
(423/591)59%
(247/422)src.kconfig_compiler100%
(1/1)100%
(1/1)86%
(1349/1564)80%
(942/1171)src.kreadconfig0%
(0/2)0%
(0/2)0%
(0/76)0%
(0/146)

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.11 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.11/6/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 28 Dec 2018 10:13:54 +
 Build duration:
1 min 55 sec and counting
   BUILD ARTIFACTS
  logs/KF5Config/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kconfigcore_kconfigtestName: projectroot.autotests Failed: 0 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 22 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)90%
(69/77)90%
(69/77)79%
(6804/8622)58%
(3524/6052)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)99%
(1941/1954)52%
(851/1625)autotests.kconfig_compiler96%
(24/25)96%
(24/25)92%
(277/301)47%
(96/206)src.core88%
(22/25)88%
(22/25)69%
(2382/3428)57%
(1232/2177)src.gui71%
(5/7)71%
(5/7)61%
(432/708)51%
(156/305)src.kconf_update100%
(2/2)100%
(2/2)72%
(423/591)59%
(247/422)src.kconfig_compiler100%
(1/1)100%
(1/1)86%
(1349/1564)80%
(942/1171)src.kreadconfig0%
(0/2)0%
(0/2)0%
(0/76)0%
(0/146)

D17623: Add YaST and new preference icons

[Noah Davis]

ndavis updated this revision to Diff 48277.
ndavis retitled this revision from "Add YaST icons" to "Add YaST and new 
preference icons".
ndavis added a comment.


  Change most `yast-*` icons to symlinks and create preference icons to use as 
`yast-*` icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17623?vs=47674=48277

BRANCH
  yast-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17623

AFFECTED FILES
  icons-dark/apps/32/hwinfo.svg
  icons-dark/apps/32/system-help.svg
  icons-dark/apps/32/systemsettings.svg
  icons-dark/apps/32/utilities-log-viewer.svg
  icons-dark/apps/32/yast-addon.svg
  icons-dark/apps/32/yast-alternatives.svg
  icons-dark/apps/32/yast-apparmor.svg
  icons-dark/apps/32/yast-auth-client.svg
  icons-dark/apps/32/yast-autoyast.svg
  icons-dark/apps/32/yast-bootloader.svg
  icons-dark/apps/32/yast-checkmedia.svg
  icons-dark/apps/32/yast-create-new-vm.svg
  icons-dark/apps/32/yast-device-tree.svg
  icons-dark/apps/32/yast-dhcp-server.svg
  icons-dark/apps/32/yast-disk.svg
  icons-dark/apps/32/yast-dns-server.svg
  icons-dark/apps/32/yast-docker.svg
  icons-dark/apps/32/yast-dsl.svg
  icons-dark/apps/32/yast-fcoe.svg
  icons-dark/apps/32/yast-firewall.svg
  icons-dark/apps/32/yast-fonts.svg
  icons-dark/apps/32/yast-ftp-server.svg
  icons-dark/apps/32/yast-hardware.svg
  icons-dark/apps/32/yast-host.svg
  icons-dark/apps/32/yast-http-server.svg
  icons-dark/apps/32/yast-hwinfo.svg
  icons-dark/apps/32/yast-instserver.svg
  icons-dark/apps/32/yast-iscsi-client.svg
  icons-dark/apps/32/yast-iscsi-server.svg
  icons-dark/apps/32/yast-journal.svg
  icons-dark/apps/32/yast-kerberos-server.svg
  icons-dark/apps/32/yast-kernel.svg
  icons-dark/apps/32/yast-keyboard.svg
  icons-dark/apps/32/yast-lan.svg
  icons-dark/apps/32/yast-language.svg
  icons-dark/apps/32/yast-ldap-server.svg
  icons-dark/apps/32/yast-ldap.svg
  icons-dark/apps/32/yast-mail.svg
  icons-dark/apps/32/yast-messages.svg
  icons-dark/apps/32/yast-misc.svg
  icons-dark/apps/32/yast-network.svg
  icons-dark/apps/32/yast-nfs-server.svg
  icons-dark/apps/32/yast-nfs.svg
  icons-dark/apps/32/yast-nis-server.svg
  icons-dark/apps/32/yast-nis.svg
  icons-dark/apps/32/yast-ntp-client.svg
  icons-dark/apps/32/yast-printer.svg
  icons-dark/apps/32/yast-proxy.svg
  icons-dark/apps/32/yast-release-notes.svg
  icons-dark/apps/32/yast-remote.svg
  icons-dark/apps/32/yast-samba-client.svg
  icons-dark/apps/32/yast-samba-server.svg
  icons-dark/apps/32/yast-scanner.svg
  icons-dark/apps/32/yast-security.svg
  icons-dark/apps/32/yast-services-manager.svg
  icons-dark/apps/32/yast-slp-server.svg
  icons-dark/apps/32/yast-snapper.svg
  icons-dark/apps/32/yast-software.svg
  icons-dark/apps/32/yast-sound.svg
  icons-dark/apps/32/yast-sudo.svg
  icons-dark/apps/32/yast-support.svg
  icons-dark/apps/32/yast-sw_single.svg
  icons-dark/apps/32/yast-sw_source.svg
  icons-dark/apps/32/yast-sysconfig.svg
  icons-dark/apps/32/yast-system.svg
  icons-dark/apps/32/yast-tftp-server.svg
  icons-dark/apps/32/yast-timezone.svg
  icons-dark/apps/32/yast-update.svg
  icons-dark/apps/32/yast-users.svg
  icons-dark/apps/32/yast-vm-install.svg
  icons-dark/apps/32/yast-vm-migrate.svg
  icons-dark/apps/32/yast-vm.svg
  icons-dark/apps/32/yast-vpn.svg
  icons-dark/apps/32/yast-wol.svg
  icons-dark/apps/32/yast.svg
  icons-dark/apps/48/yast-installation.svg
  icons-dark/apps/48/yast-sw_single.svg
  icons-dark/apps/48/yast.svg
  icons-dark/preferences/32/preferences-devices-cpu.svg
  icons-dark/preferences/32/preferences-devices-drive-optical-check.svg
  icons-dark/preferences/32/preferences-devices-printer.svg
  icons-dark/preferences/32/preferences-devices-scanner.svg
  icons-dark/preferences/32/preferences-devices-tree.svg
  icons-dark/preferences/32/preferences-log.svg
  icons-dark/preferences/32/preferences-releasenotes.svg
  icons-dark/preferences/32/preferences-security-apparmor.svg
  icons-dark/preferences/32/preferences-security-firewall.svg
  icons-dark/preferences/32/preferences-security-kerberos.svg
  icons-dark/preferences/32/preferences-security.svg
  icons-dark/preferences/32/preferences-system-backup.svg
  icons-dark/preferences/32/preferences-system-linux.svg
  icons-dark/preferences/32/preferences-system-network-dsl.svg
  icons-dark/preferences/32/preferences-system-network-ethernet.svg
  icons-dark/preferences/32/preferences-system-network-iscsi.svg
  icons-dark/preferences/32/preferences-system-network-ldap.svg
  icons-dark/preferences/32/preferences-system-network-nis.svg
  icons-dark/preferences/32/preferences-system-network-ntp.svg
  icons-dark/preferences/32/preferences-system-network-proxy.svg
  icons-dark/preferences/32/preferences-system-network-remote.svg
  icons-dark/preferences/32/preferences-system-network-samba.svg
  icons-dark/preferences/32/preferences-system-network-server-boot.svg
  icons-dark/preferences/32/preferences-system-network-server-dhcp.svg
  

D17830: Add YaST and new preferences icons

[Noah Davis]

ndavis abandoned this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17830

To: ndavis
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17830: Add YaST and new preferences icons

[Noah Davis]

ndavis created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  yast-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17830

AFFECTED FILES
  icons-dark/apps/32/hwinfo.svg
  icons-dark/apps/32/system-help.svg
  icons-dark/apps/32/systemsettings.svg
  icons-dark/apps/32/utilities-log-viewer.svg
  icons-dark/apps/32/yast-addon.svg
  icons-dark/apps/32/yast-alternatives.svg
  icons-dark/apps/32/yast-apparmor.svg
  icons-dark/apps/32/yast-auth-client.svg
  icons-dark/apps/32/yast-autoyast.svg
  icons-dark/apps/32/yast-bootloader.svg
  icons-dark/apps/32/yast-checkmedia.svg
  icons-dark/apps/32/yast-create-new-vm.svg
  icons-dark/apps/32/yast-device-tree.svg
  icons-dark/apps/32/yast-dhcp-server.svg
  icons-dark/apps/32/yast-disk.svg
  icons-dark/apps/32/yast-dns-server.svg
  icons-dark/apps/32/yast-docker.svg
  icons-dark/apps/32/yast-dsl.svg
  icons-dark/apps/32/yast-fcoe.svg
  icons-dark/apps/32/yast-firewall.svg
  icons-dark/apps/32/yast-fonts.svg
  icons-dark/apps/32/yast-ftp-server.svg
  icons-dark/apps/32/yast-hardware.svg
  icons-dark/apps/32/yast-host.svg
  icons-dark/apps/32/yast-http-server.svg
  icons-dark/apps/32/yast-hwinfo.svg
  icons-dark/apps/32/yast-instserver.svg
  icons-dark/apps/32/yast-iscsi-client.svg
  icons-dark/apps/32/yast-iscsi-server.svg
  icons-dark/apps/32/yast-journal.svg
  icons-dark/apps/32/yast-kerberos-server.svg
  icons-dark/apps/32/yast-kernel.svg
  icons-dark/apps/32/yast-keyboard.svg
  icons-dark/apps/32/yast-lan.svg
  icons-dark/apps/32/yast-language.svg
  icons-dark/apps/32/yast-ldap-server.svg
  icons-dark/apps/32/yast-ldap.svg
  icons-dark/apps/32/yast-mail.svg
  icons-dark/apps/32/yast-messages.svg
  icons-dark/apps/32/yast-misc.svg
  icons-dark/apps/32/yast-network.svg
  icons-dark/apps/32/yast-nfs-server.svg
  icons-dark/apps/32/yast-nfs.svg
  icons-dark/apps/32/yast-nis-server.svg
  icons-dark/apps/32/yast-nis.svg
  icons-dark/apps/32/yast-ntp-client.svg
  icons-dark/apps/32/yast-printer.svg
  icons-dark/apps/32/yast-proxy.svg
  icons-dark/apps/32/yast-release-notes.svg
  icons-dark/apps/32/yast-remote.svg
  icons-dark/apps/32/yast-samba-client.svg
  icons-dark/apps/32/yast-samba-server.svg
  icons-dark/apps/32/yast-scanner.svg
  icons-dark/apps/32/yast-security.svg
  icons-dark/apps/32/yast-services-manager.svg
  icons-dark/apps/32/yast-slp-server.svg
  icons-dark/apps/32/yast-snapper.svg
  icons-dark/apps/32/yast-software.svg
  icons-dark/apps/32/yast-sound.svg
  icons-dark/apps/32/yast-sudo.svg
  icons-dark/apps/32/yast-support.svg
  icons-dark/apps/32/yast-sw_single.svg
  icons-dark/apps/32/yast-sw_source.svg
  icons-dark/apps/32/yast-sysconfig.svg
  icons-dark/apps/32/yast-system.svg
  icons-dark/apps/32/yast-tftp-server.svg
  icons-dark/apps/32/yast-timezone.svg
  icons-dark/apps/32/yast-update.svg
  icons-dark/apps/32/yast-users.svg
  icons-dark/apps/32/yast-vm-install.svg
  icons-dark/apps/32/yast-vm-migrate.svg
  icons-dark/apps/32/yast-vm.svg
  icons-dark/apps/32/yast-vpn.svg
  icons-dark/apps/32/yast-wol.svg
  icons-dark/apps/32/yast.svg
  icons-dark/apps/48/yast-installation.svg
  icons-dark/apps/48/yast-sw_single.svg
  icons-dark/apps/48/yast.svg
  icons-dark/preferences/32/preferences-devices-cpu.svg
  icons-dark/preferences/32/preferences-devices-drive-optical-check.svg
  icons-dark/preferences/32/preferences-devices-printer.svg
  icons-dark/preferences/32/preferences-devices-scanner.svg
  icons-dark/preferences/32/preferences-devices-tree.svg
  icons-dark/preferences/32/preferences-log.svg
  icons-dark/preferences/32/preferences-releasenotes.svg
  icons-dark/preferences/32/preferences-security-apparmor.svg
  icons-dark/preferences/32/preferences-security-firewall.svg
  icons-dark/preferences/32/preferences-security-kerberos.svg
  icons-dark/preferences/32/preferences-security.svg
  icons-dark/preferences/32/preferences-system-backup.svg
  icons-dark/preferences/32/preferences-system-linux.svg
  icons-dark/preferences/32/preferences-system-network-dsl.svg
  icons-dark/preferences/32/preferences-system-network-ethernet.svg
  icons-dark/preferences/32/preferences-system-network-iscsi.svg
  icons-dark/preferences/32/preferences-system-network-ldap.svg
  icons-dark/preferences/32/preferences-system-network-nis.svg
  icons-dark/preferences/32/preferences-system-network-ntp.svg
  icons-dark/preferences/32/preferences-system-network-proxy.svg
  icons-dark/preferences/32/preferences-system-network-remote.svg
  icons-dark/preferences/32/preferences-system-network-samba.svg
  icons-dark/preferences/32/preferences-system-network-server-boot.svg
  icons-dark/preferences/32/preferences-system-network-server-dhcp.svg
  icons-dark/preferences/32/preferences-system-network-server-dns.svg
  icons-dark/preferences/32/preferences-system-network-server-ftp.svg
  

D15910: Implement wl_surface::damage_buffer

[Roman Gilg]

romangg added a comment.


  Ping

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15910

To: romangg, #kwin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, michaelh, ngraham, bruns